Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

com] >>> Sent: Wednesday, September 28, 2016 1:26 AM >>> To: Chris Hegarty <chris.hega...@oracle.com>; Mark Sheppard >>> <mark.shepp...@oracle.com>; net-dev <net-dev@openjdk.java.net>; Kaczmarek, >>> Eric <eric.kaczma...@intel.com>

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

<shirish.aun...@intel.com <mailto:shirish.aun...@intel.com>>; Lu, Yingqi <yingqi...@intel.com <mailto:yingqi...@intel.com>> *Subject:*Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false) Hi All, I had off line discussion her

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

t;sandhya.viswanat...@intel.com>; Kharbas, Kishor <kishor.khar...@intel.com>; > Aundhe, Shirish <shirish.aun...@intel.com>; Lu, Yingqi <yingqi...@intel.com> > Subject: Re: RFR 8153674: Expected SocketException not thrown when calling > bind() with setReuseAddress(f

RE: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

anat...@intel.com>; Kharbas, Kishor <kishor.khar...@intel.com>; Aundhe, Shirish <shirish.aun...@intel.com>; Lu, Yingqi <yingqi...@intel.com> Subject: Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false) Hi All, I had o

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

Thanks Vyom, On 28/09/16 09:25, Vyom Tewari wrote: Hi All, I had off line discussion here at Oracle and we decided not to override getReuseAddr/setReuseAddr for MulticastSocket. If user wants, he can set the SO_REUSEPORT with "setOption"before bind. Right. All options that we looked at seem

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

Hi All, I had off line discussion here at Oracle and we decided not to override getReuseAddr/setReuseAddr for MulticastSocket. If user wants, he can set the SO_REUSEPORT with "setOption"before bind. For MulticastSocket SO_REUSEADDR_REUSEPORT are semantically equivalent which means either

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

On 14/09/16 15:53, Mark Sheppard wrote: that's true wrt SO_REUSEPORT in MulticastSocket constructor. But the same could have been argued for the original invocation of setReuseAddress, by default , in the constructors, which is encapsulating, what pereceived as, common or defacto practice wrt

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

that's true wrt SO_REUSEPORT in MulticastSocket constructor. But the same could have been argued for the original invocation of setReuseAddress, by default , in the constructors, which is encapsulating, what pereceived as, common or defacto practice wrt applying SO_REUSEADDR on mcast sockets

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

One additional remark. Was it appropriate to update the legacy MC constructors to set the new JDK 9 SO_REUSEPORT in the first place? This can be achievable, opt-in from new code, by creating an unbound MS, setting the option, then binding. -Chris. On 14/09/16 14:47, Chris Hegarty wrote: Mark,

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

Mark, On 14/09/16 14:22, Mark Sheppard wrote: Hi Chris, I don't fully understand your objections to the approach taken. Is there a compatibility issue with the addition of the additional methods to MulticastSocket? The concern is with setReuseAddress performing an operation that is not

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

Hi Chris, I don't fully understand your objections to the approach taken. Is there a compatibility issue with the addition of the additional methods to MulticastSocket? I don't see Datagram.setReuseAddress(...) handling the SO_REUSEPORT option, this has to be done explicitly via

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

Mark, On 14/09/16 13:23, Mark Sheppard wrote: Hi Chris, so are you accepting that it is correct to add the overridden methods in MulticastSocket and that these need appropriate javadoc ? I think we need these, but they should just call their super equivalents, i.e. no implicit setting of

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

Hi Chris, so are you accepting that it is correct to add the overridden methods in MulticastSocket and that these need appropriate javadoc ? or are you advocating pushing the handing of the SO_REUSEPORT into the base DatagramSocket class ? It is not clear how your code changes fit in

Re: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

Vyom, On 11/09/16 08:01, Vyom Tewari wrote: Hi All, Please review the below code change. Bug: https://bugs.openjdk.java.net/browse/JDK-8153674 Webrev : http://cr.openjdk.java.net/~vtewari/8153674/webrev0.0/index.html

RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

Hi All, Please review the below code change. Bug: https://bugs.openjdk.java.net/browse/JDK-8153674 Webrev : http://cr.openjdk.java.net/~vtewari/8153674/webrev0.0/index.html This change override the