On 07/02/2018 18:02, gary.ad...@oracle.com wrote:
Yes, WSASendDisconnect is deprecated in vs2013.
As far as I know "shutdown(fd, SD_SEND)" prevents further outgoing writes
and there was no final payload to send.
I have not seen any failures in the java/nio tests.
Okay, I guess it should okay
A fresh webrev rebased with latest jdk/jdk repos:
http://cr.openjdk.java.net/~gadams/8080990/webrev.03/index.html
If there are no more comments, I'll check in locally with these reviewers
clanger,chegar,erikj
and cut patches on Thurs AM.
On 2/5/18 2:15 PM, Gary Adams wrote:
One more to
On 2/7/18 12:55 PM, gary.ad...@oracle.com wrote:
On 2/7/18 12:31 PM, Chris Hegarty wrote:
Gary,
http://cr.openjdk.java.net/%7Egadams/8080990/webrev.02/
I think the replacement of WSASendDisconnect with
shutdown(SD_SEND) should be fine. I do note that there
is another usage of
On 2/7/18 12:48 PM, Alan Bateman wrote:
On 07/02/2018 17:31, Chris Hegarty wrote:
Gary,
http://cr.openjdk.java.net/%7Egadams/8080990/webrev.02/
I think the replacement of WSASendDisconnect with
shutdown(SD_SEND) should be fine. I do note that there
is another usage of WSASendDisconnect in
On 2/7/18 12:31 PM, Chris Hegarty wrote:
Gary,
http://cr.openjdk.java.net/%7Egadams/8080990/webrev.02/
I think the replacement of WSASendDisconnect with
shutdown(SD_SEND) should be fine. I do note that there
is another usage of WSASendDisconnect in
On 07/02/2018 17:31, Chris Hegarty wrote:
Gary,
http://cr.openjdk.java.net/%7Egadams/8080990/webrev.02/
I think the replacement of WSASendDisconnect with
shutdown(SD_SEND) should be fine. I do note that there
is another usage of WSASendDisconnect in
Gary,
> http://cr.openjdk.java.net/%7Egadams/8080990/webrev.02/
I think the replacement of WSASendDisconnect with
shutdown(SD_SEND) should be fine. I do note that there
is another usage of WSASendDisconnect in
java.base/windows/native/libnet/net_util_md.c.
[ Maybe you want to separate out the
Cc: Langer, Christoph <christoph.lan...@sap.com>; OpenJDK Serviceability
<serviceability-...@openjdk.java.net>; OpenJDK Build
<build-...@openjdk.java.net>; OpenJDK Networking <net-dev@openjdk.java.net>
Subject: Re: JDK-8080990: libdt_socket/socket_md.c(202) : warning C499
Here's a revised webrev
http://cr.openjdk.java.net/~gadams/8080990/webrev.01/index.html
Still testing ...
Using shutdown() fixed problems reported by the
java/nio/channelSocketChannel tests.
I also noticed prior use of getaddrinfo for "localhost" was not calling
freeaddrinfo.
...
On
On 2/1/18, 6:59 AM, Langer, Christoph wrote:
But WSASendDisconnect isn't deprecated, right? So you wanted to get rid of it?
I still don't see the reason...
vs2013 include/um/winsock2.h has WSASendDisconnect deprecated.
.../src/jdk.jdwp.agent/windows/native/libdt_socket/socket_md.c(230) :
penJDK Serviceability
<serviceability-...@openjdk.java.net>; OpenJDK Build
<build-...@openjdk.java.net>; OpenJDK Networking <net-dev@openjdk.java.net>
Subject: Re: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996:
'gethostbyname': Use getaddrinfo() or GetAddrInfoW()
Fi
First pass over the code I disabled the compilation flag and then
did quick substitution for the easier functions. I commented out the
WSASendDisconnect calls so I could see what tests would fail if
the function was just removed. I have a replacement now that uses
"shutdown(fd,SD_SEND)", but I
Hi Gary,
I was having a look at your changes.
I'm wondering what the reason is behind uncommenting WSASendDisconnect in
Java_sun_nio_ch_SocketDispatcher_preClose0 of file SocketDispatcher.c? And in
dbgsysSocketClose?
In socketTransport.c, line:
331 setLastError(0,
13 matches
Mail list logo
