hg: jdk7/tl/jdk: 7005424: Resync java.util.concurrent classes with Dougs CVS - Jan 2011

2011-01-12 Thread chris . hegarty
Changeset: cb3ecb5e4ce5 Author:dl Date: 2011-01-12 14:40 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cb3ecb5e4ce5 7005424: Resync java.util.concurrent classes with Dougs CVS - Jan 2011 Reviewed-by: dholmes, chegar, mduigou ! src/share/classes/java/util/Collections.java !

Re: Code Review 6964547: Impossible to set useV4 in SocksSocketImpl

2011-01-12 Thread Chris Hegarty
I received some offline comments on this. 1) SocksProxyVersionFour -> SocksProxy 2) SocksProxy now contains the protocol version Updated webrev: http://cr.openjdk.java.net/~chegar/6964547/webrev.01/webrev/ -Chris. On 01/11/11 03:00 PM, Chris Hegarty wrote: Michael, Alan, Provide a property

Re: Code Review 6964547: Impossible to set useV4 in SocksSocketImpl

2011-01-12 Thread Alan Bateman
Chris Hegarty wrote: I received some offline comments on this. 1) SocksProxyVersionFour -> SocksProxy 2) SocksProxy now contains the protocol version Updated webrev: http://cr.openjdk.java.net/~chegar/6964547/webrev.01/webrev/ -Chris. This looks much cleaner. A few minor comments on the chan

Re: Code Review 6964547: Impossible to set useV4 in SocksSocketImpl

2011-01-12 Thread Damjan Jovanovic
Can I also suggest that Proxy.Type.SOCKS gets deprecated and Proxy.Type.SOCKS4 and Proxy.Type.SOCKS5 get introduced instead? Just about every application treats SOCKS 4 and 5 as different proxy types, only Java tries to lump them together. On Wed, Jan 12, 2011 at 5:04 PM, Chris Hegarty wrote: >

Re: Code Review 6964547: Impossible to set useV4 in SocksSocketImpl

2011-01-12 Thread Alan Bateman
Damjan Jovanovic wrote: Can I also suggest that Proxy.Type.SOCKS gets deprecated and Proxy.Type.SOCKS4 and Proxy.Type.SOCKS5 get introduced instead? Just about every application treats SOCKS 4 and 5 as different proxy types, only Java tries to lump them together. I wonder if SOCKS4 is still

Re: Code Review 6964547: Impossible to set useV4 in SocksSocketImpl

2011-01-12 Thread Chris Hegarty
On 01/12/11 03:36 PM, Alan Bateman wrote: Damjan Jovanovic wrote: Can I also suggest that Proxy.Type.SOCKS gets deprecated and Proxy.Type.SOCKS4 and Proxy.Type.SOCKS5 get introduced instead? Just about every application treats SOCKS 4 and 5 as different proxy types, only Java tries to lump th

Re: Code Review 6964547: Impossible to set useV4 in SocksSocketImpl

2011-01-12 Thread Chris Hegarty
On 01/12/11 03:24 PM, Alan Bateman wrote: Chris Hegarty wrote: I received some offline comments on this. 1) SocksProxyVersionFour -> SocksProxy 2) SocksProxy now contains the protocol version Updated webrev: http://cr.openjdk.java.net/~chegar/6964547/webrev.01/webrev/ -Chris. This looks muc

Re: Code Review 6964547: Impossible to set useV4 in SocksSocketImpl

2011-01-12 Thread Alan Bateman
Chris Hegarty wrote: : Updated Webrev: http://cr.openjdk.java.net/~chegar/6964547/webrev.02/webrev/ Looks fine except that that main thread needs to wait for the "socks server" thread to terminate as otherwise the test might pass before the thread sets failed to true. -Alan

hg: jdk7/tl/jdk: 7008713: diamond conversion of kerberos5 and security tools

2011-01-12 Thread stuart . marks
Changeset: a5a22f93e4c5 Author:smarks Date: 2011-01-12 13:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a5a22f93e4c5 7008713: diamond conversion of kerberos5 and security tools Reviewed-by: weijun ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/

hg: jdk7/tl/jdk: 2 new changesets

2011-01-12 Thread keith . mcguigan
Changeset: f5c0b3cbee2f Author:kamg Date: 2011-01-12 11:47 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f5c0b3cbee2f 6436034: Instance filter doesn't filter event if it occurs in native method Summary: Use 'GetLocalInstance' JVMTI extension if it exists Reviewed-by: coleenp