Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-05-03 Thread Chris Hegarty
On 02/05/2012 19:10, Alan Bateman wrote: On 27/04/2012 10:30, Deven You wrote: Hi Alan, I have updated the patch and test[1] for ::0. Please review it. [1] http://cr.openjdk.java.net/~littlee/OJDK-217/webrev.03/ Thanks a lot! Minor indentation issues, Inet4AddressImpl.c L684 and net_util_md.

Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-05-03 Thread Alan Bateman
On 03/05/2012 08:46, Chris Hegarty wrote: On the test, it would be good to run with it with -Djava.net.preferIPv4Stack=true too, but ::0 should not be reachable. I guess the test should check if preferIPv4Stack=true and skip testing with ::0. Or only add ::0 to addresses if !preferIPv4Stack?

Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-05-03 Thread Chris Hegarty
On 03/05/2012 08:51, Alan Bateman wrote: On 03/05/2012 08:46, Chris Hegarty wrote: On the test, it would be good to run with it with -Djava.net.preferIPv4Stack=true too, but ::0 should not be reachable. I guess the test should check if preferIPv4Stack=true and skip testing with ::0. Or only add