RFR: 8230310: SocksSocketImpl should handle the IllegalArgumentException thrown by ProxySelector.select usage

2019-08-28 Thread Jaikiran Pai
Can I please get a review and a sponsor for the patch for https://bugs.openjdk.java.net/browse/JDK-8230310? The patch is hosted as a webrev at [1]. As noted in that JBS issue, this is a follow-up patch to the changes that were done as part of [2]. During that patch review, it was decided that rema

Re: RFR: 8230310: SocksSocketImpl should handle the IllegalArgumentException thrown by ProxySelector.select usage

2019-08-28 Thread Daniel Fuchs
Hi Jaikiran, On 28/08/2019 15:47, Jaikiran Pai wrote: Can I please get a review and a sponsor for the patch for https://bugs.openjdk.java.net/browse/JDK-8230310? The patch is hosted as a webrev at [1]. As noted in that JBS issue, this is a follow-up patch to the changes that were done as part o

Re: RFR: 8230310: SocksSocketImpl should handle the IllegalArgumentException thrown by ProxySelector.select usage

2019-08-28 Thread Jaikiran Pai
Hello Daniel, On 28/08/19 8:45 PM, Daniel Fuchs wrote: > Hi Jaikiran, > > On 28/08/2019 15:47, Jaikiran Pai wrote: >> Can I please get a review and a sponsor for the patch for >> https://bugs.openjdk.java.net/browse/JDK-8230310? The patch is hosted as >> a webrev at [1]. >> >> As noted in that JBS

Re: RFR: 8230310: SocksSocketImpl should handle the IllegalArgumentException thrown by ProxySelector.select usage

2019-08-28 Thread Jaikiran Pai
On 29/08/19 9:12 AM, Jaikiran Pai wrote: > Hello Daniel, > > On 28/08/19 8:45 PM, Daniel Fuchs wrote: >> Hi Jaikiran, >> >> On 28/08/2019 15:47, Jaikiran Pai wrote: >>> Can I please get a review and a sponsor for the patch for >>> https://bugs.openjdk.java.net/browse/JDK-8230310? The patch is hos