Re: RFR JDK-8157273: Simplify outgoing messages queueing policy in WebSocket API

2016-06-14 Thread Simone Bordet
Hi, On Tue, Jun 14, 2016 at 6:15 PM, Chris Hegarty wrote: > Following this discussion, I think the point is that the size of the send > queue > is an implementation detail, and therefore cannot be replied upon ( another > implementation could have a smaller upper bound

Re: RFR JDK-8157273: Simplify outgoing messages queueing policy in WebSocket API

2016-06-14 Thread Chris Hegarty
Following this discussion, I think the point is that the size of the send queue is an implementation detail, and therefore cannot be replied upon ( another implementation could have a smaller upper bound ). Having a method on builder similar to the sketch below, may address this concern. /**

Re: RFR JDK-8157273: Simplify outgoing messages queueing policy in WebSocket API

2016-06-14 Thread Simone Bordet
Hi, On Tue, Jun 14, 2016 at 2:36 PM, Simone Bordet wrote: > That is again a semantic problem, but I think this one is simple: the > implementation cannot guarantee that one API call correspond to one > frame. > There are, for example, fragmentation extensions that >

Re: RFR JDK-8157273: Simplify outgoing messages queueing policy in WebSocket API

2016-06-14 Thread Simone Bordet
Hi, On Tue, Jun 14, 2016 at 1:26 PM, Pavel Rappo wrote: > >> On 13 Jun 2016, at 12:14, Simone Bordet wrote: >> >>> Should the application be in charge of chopping outgoing messages in chunks >>> in >>> order to provide better responsiveness when

Re: RFR JDK-8159039: sun/net/httpclient/hpack/HeaderTableTest.java fails on some locales

2016-06-14 Thread Pavel Rappo
Hi Naoto, Yes, you are right. This method execution affects all that go after. I will fix it. Thanks! > On 13 Jun 2016, at 16:58, Naoto Sato wrote: > > Does that mean each method test invocation on an separate vm, or the scope is > .java? If it's the latter, I would

RFR 8144008: Setting NO_PROXY on an URLConnection is not complied with

2016-06-14 Thread Vyom Tewari
Hi All, Please review the below fix. Bug : JDK-8144008 Setting NO_PROXY on an URLConnection is not complied with Webrev : http://cr.openjdk.java.net/~vtewari/8144008/webrev0.0/index.html Thanks, Vyom