Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-03-22 Thread Jamie Le Tual
On Fri, 19 Mar 2021 16:47:10 GMT, Chris Hegarty wrote: >>> I think that the changes are mostly good. I would like to try them out on >>> my local system and our internal buildAndTest system. >> >> Chris, were you able to test the patch? >> >> Also if anyone has an idea as to the best way to

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-03-19 Thread Chris Hegarty
On Tue, 16 Feb 2021 13:37:20 GMT, Jamie Le Tual wrote: >> I think that the changes are mostly good. I would like to try them out on my >> local system and our internal buildAndTest system. > >> I think that the changes are mostly good. I would like to try them out on my >> local system and

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-02-19 Thread Conor Cleary
On Thu, 18 Feb 2021 10:12:30 GMT, Conor Cleary wrote: >>> I think that the changes are mostly good. I would like to try them out on >>> my local system and our internal buildAndTest system. >> >> Chris, were you able to test the patch? >> >> Also if anyone has an idea as to the best way to

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-02-19 Thread Conor Cleary
On Fri, 19 Feb 2021 14:48:39 GMT, Conor Cleary wrote: >> Jamie Le Tual has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed formatting > > src/java.base/unix/native/libnet/Inet4AddressImpl.c line 375: > >> 373: icmp->icmp_type

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-02-19 Thread Conor Cleary
On Wed, 23 Dec 2020 14:06:12 GMT, Jamie Le Tual wrote: >> Users have been able to send ICMP packets without the need for root >> privileges or the CAP_NET_RAW capability since at least kernel 3.11. >> >> For some time now, if the kernel parameter net.ipv4.ping_group_range >> included the gid

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-02-18 Thread Conor Cleary
On Tue, 16 Feb 2021 13:37:20 GMT, Jamie Le Tual wrote: > > I think that the changes are mostly good. I would like to try them out on > > my local system and our internal buildAndTest system. > > Chris, were you able to test the patch? > > Also if anyone has an idea as to the best way to unit

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-02-16 Thread Jamie Le Tual
On Mon, 18 Jan 2021 09:17:51 GMT, Chris Hegarty wrote: > I think that the changes are mostly good. I would like to try them out on my > local system and our internal buildAndTest system. Chris, were you able to test the patch? Also if anyone has an idea as to the best way to unit test this,

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-02-16 Thread Jamie Le Tual
On Mon, 18 Jan 2021 08:25:34 GMT, Alan Bateman wrote: >> Jamie Le Tual has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed formatting > > src/java.base/unix/native/libnet/Inet6AddressImpl.c line 713: > >> 711: This usually

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-01-18 Thread Chris Hegarty
On Wed, 23 Dec 2020 14:06:12 GMT, Jamie Le Tual wrote: >> Users have been able to send ICMP packets without the need for root >> privileges or the CAP_NET_RAW capability since at least kernel 3.11. >> >> For some time now, if the kernel parameter net.ipv4.ping_group_range >> included the gid

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-01-18 Thread Alan Bateman
On Wed, 23 Dec 2020 14:06:12 GMT, Jamie Le Tual wrote: >> Users have been able to send ICMP packets without the need for root >> privileges or the CAP_NET_RAW capability since at least kernel 3.11. >> >> For some time now, if the kernel parameter net.ipv4.ping_group_range >> included the gid

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2020-12-23 Thread Jamie Le Tual
On Tue, 22 Dec 2020 14:08:26 GMT, Alan Bateman wrote: > Adding support for SOCK_DGRAM/IPPROTO_ICMP(6) is good and I think is mostly > okay. The comments and the formatting is messy in several places and should > be cleaned up before the patch is sponsored. Alan, thanks for taking a look at

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2020-12-23 Thread Jamie Le Tual
> Users have been able to send ICMP packets without the need for root > privileges or the CAP_NET_RAW capability since at least kernel 3.11. > > For some time now, if the kernel parameter net.ipv4.ping_group_range included > the gid of a user sending an icmp packet with the IPPROTO_ICMP