350588)
>
> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
> It adds a non-exposed / non-exported internal implementation of the QUIC
> protocol based on DatagramChannel and the SunJSSE SSLContext provider.
Daniel Fuchs has updated the pull request with a new
On Tue, 9 Sep 2025 15:03:15 GMT, Daniel Fuchs wrote:
> Hi,
>
> This is a documentation change only. The specification of
> `InterfaceAddress:getBroadcast()` should not say anything specific about the
> loopback interface as it appears that on some systems a broadcast ad
On Fri, 19 Sep 2025 10:07:01 GMT, Francesco Andreuzzi
wrote:
> I propose a change to have these tests listed appropriately as "skipped"
> rather than "passing" on Windows. I'm also taking the opportunity to save an
> indentation level since we can throw a `SkipException` early in all the
> re
On Fri, 19 Sep 2025 10:07:16 GMT, Volkan Yazici wrote:
>> Improves exception handling of built-in `HttpClient.BodyPublisher`s to
>> ensure exceptions get propagated in a way compliant with the reactive
>> specification.
>
> Volkan Yazici has updated the pull request with a new target base due t
On Wed, 17 Sep 2025 16:47:12 GMT, Sean Mullan wrote:
>> HttpClient currently ignores the named groups and signature schemes
>> configured on the SSLParameters. Given that it processes the configured
>> protocols and cipher suites, I think it should process named groups and
>> signature schemes
350588)
>
> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
> It adds a non-exposed / non-exported internal implementation of the QUIC
> protocol based on DatagramChannel and the SunJSSE SSLContext provider.
Daniel Fuchs has updated the pull request with a new
On Wed, 17 Sep 2025 14:22:39 GMT, SendaoYan wrote:
> Hi all,
>
> Currently test java/net/InetAddress/ptr/Lookup.java print message and return
> when test can not run normally. I think it's better to throw
> jtreg.SkippedException rather report test passed when test can not execute
> normally.
On Mon, 15 Sep 2025 11:29:24 GMT, Daniel Jeliński wrote:
> HttpClient currently ignores the named groups and signature schemes
> configured on the SSLParameters. Given that it processes the configured
> protocols and cipher suites, I think it should process named groups and
> signature schemes
On Tue, 9 Sep 2025 18:24:33 GMT, Volkan Yazici wrote:
>> I think it would make more sense to make sure that Utils.BUFSIZE is
>> initialized to a strictly positive value and only assert here. It could be
>> useful to see if we have any test that set BUFSIZE to a small value - but if
>> we don't
350588)
>
> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
> It adds a non-exposed / non-exported internal implementation of the QUIC
> protocol based on DatagramChannel and the SunJSSE SSLContext provider.
Daniel Fuchs has updated the pull request with a new
Hi,
This is a documentation change only. The specification of
`InterfaceAddress:getBroadcast()` should not say anything specific about the
loopback interface as it appears that on some systems a broadcast address can
be configured on the loopback. The API documentation of
`InterfaceAddress:ge
On Mon, 8 Sep 2025 18:06:23 GMT, Volkan Yazici wrote:
>> Can bufSize be <= 0 in our implementation? Where does bufSize comes from? If
>> it can't be <= 0 in our implemlementation then an `assert` would be more
>> appropriate.
>
> It is provided in the ctor above using `Utils.BUFSIZE`, which rea
On Thu, 21 Aug 2025 09:43:47 GMT, Volkan Yazici wrote:
> Improves exception handling of built-in `HttpClient.BodyPublisher`s to ensure
> exceptions get propagated in a way compliant with the reactive specification.
src/java.net.http/share/classes/jdk/internal/net/http/PullPublisher.java line
6
On Mon, 8 Sep 2025 10:08:05 GMT, Volkan Yazici wrote:
>> Improves exception handling of built-in `HttpClient.BodyPublisher`s to
>> ensure exceptions get propagated in a way compliant with the reactive
>> specification.
>
> src/java.net.http/share/classes/jdk/internal/net/http/PullPublisher.java
350588)
>
> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
> It adds a non-exposed / non-exported internal implementation of the QUIC
> protocol based on DatagramChannel and the SunJSSE SSLContext provider.
Daniel Fuchs has updated the pull request with a new
Hi Josia,
Unfortunately I can't look at that PR until the OCA
has been signed and processed.
That said I'd be worried about several potential issues:
- will the server keep a reference to the connection/socket
so that it can be closed if HttpServer::close is called?
- how will the server know
Hi Josiah,
This is a feature that is currently not supported by the
jdk.httpserver. Part of a larger problem that support for
sending interim responses (1xx) is currently missing.
The current code has some provision for some one hundred
codes but sendResponseHeaders appears not to have been
desi
On Fri, 29 Aug 2025 08:50:52 GMT, Volkan Yazici wrote:
>> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)`
>> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient`
>> publisher to upload a certain region of a file. The new publisher does not
>> mod
On Wed, 27 Aug 2025 07:29:11 GMT, Volkan Yazici wrote:
> Fixes `NetworkInterface.c::addif` memory leak on early returns. Issue
> reproduction is difficult – didn't add a test.
The fact that `CHECKED_MALLOC3` relies on the fact that it's being called from
within a method that returns a `netif*`
On Mon, 25 Aug 2025 15:58:08 GMT, Artur Barashev wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 628 commits:
>>
>> - merge latest changes from master branch
>> - http3:
On Wed, 20 Aug 2025 15:32:55 GMT, Artur Barashev wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 616 commits:
>>
>> - merge latest changes from master branch
>> - merge l
350588)
>
> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
> It adds a non-exposed / non-exported internal implementation of the QUIC
> protocol based on DatagramChannel and the SunJSSE SSLContext provider.
Daniel Fuchs has updated the pull request with a new
350588)
>
> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
> It adds a non-exposed / non-exported internal implementation of the QUIC
> protocol based on DatagramChannel and the SunJSSE SSLContext provider.
Daniel Fuchs has updated the pull request with a new
On Wed, 20 Aug 2025 16:21:42 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/sun/security/ssl/Finished.java line 852:
>>
>>> 850: QuicTLSEngineImpl engine =
>>> 851: (QuicTLSEngineImpl)
>>> shc.conContext.transport;
>>> 852:
On Wed, 20 Aug 2025 13:55:38 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517
350588)
>
> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
> It adds a non-exposed / non-exported internal implementation of the QUIC
> protocol based on DatagramChannel and the SunJSSE SSLContext provider.
Daniel Fuchs has updated the pull request with a new
On Wed, 20 Aug 2025 09:43:09 GMT, Volkan Yazici wrote:
>> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)`
>> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient`
>> publisher to upload a certain region of a file. The new publisher does not
>> mod
On Wed, 23 Jul 2025 11:00:57 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 550 commits:
>>
>> - merge latest changes from master branch
>> - htt
On Thu, 24 Jul 2025 12:21:56 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 550 commits:
>>
>> - merge latest changes from master branch
>> - htt
On Thu, 24 Jul 2025 19:28:16 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 550 commits:
>>
>> - merge latest changes from master branch
>> - htt
On Thu, 24 Jul 2025 17:04:52 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 550 commits:
>>
>> - merge latest changes from master branch
>> - htt
On Thu, 24 Jul 2025 16:02:44 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 550 commits:
>>
>> - merge latest changes from master branch
>> - htt
On Thu, 24 Jul 2025 15:31:21 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 550 commits:
>>
>> - merge latest changes from master branch
>> - htt
On Thu, 24 Jul 2025 15:20:37 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 550 commits:
>>
>> - merge latest changes from master branch
>> - htt
On Mon, 11 Aug 2025 07:47:03 GMT, Volkan Yazici wrote:
>> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)`
>> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient`
>> publisher to upload a certain region of a file. The new publisher does not
>> mod
On Mon, 18 Aug 2025 16:34:21 GMT, Leo Korinth wrote:
>> This changes the timeout factor from 4 to 1. Most of the changes add
>> timeouts to individual test cases so that I am able to run them with a
>> timeout factor of 0.7 (some margin to the checked in factor of one)
>>
>> In addition to cha
On Mon, 11 Aug 2025 07:47:03 GMT, Volkan Yazici wrote:
>> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)`
>> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient`
>> publisher to upload a certain region of a file. The new publisher does not
>> mod
On Fri, 15 Aug 2025 11:43:33 GMT, Leo Korinth wrote:
>> This changes the timeout factor from 4 to 1. Most of the changes add
>> timeouts to individual test cases so that I am able to run them with a
>> timeout factor of 0.7 (some margin to the checked in factor of one)
>>
>> In addition to cha
On Thu, 14 Aug 2025 18:33:51 GMT, Volkan Yazici wrote:
> Make `ProxyServer` not extend from `Thread`.
Marked as reviewed by dfuchs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/26786#pullrequestreview-3123891979
On Thu, 14 Aug 2025 18:33:51 GMT, Volkan Yazici wrote:
> Make `ProxyServer` not extend from `Thread`.
LGTM. Please make sure to run all tests that might be using this class (tier2
should do it) to double check that none of them use methods from Thread - such
as calling `proxy.join()`. With thi
On Fri, 8 Aug 2025 14:36:17 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8365086?
>>
>> `java.net.CookieStore` has some APIs which return a `java.util.List`. These
>> API are specified t
On Fri, 8 Aug 2025 09:21:59 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to fix an
>> intermittent failure in that test? This addresses
>> https://bugs.openjdk.org/browse/JDK-8364786.
>>
>> As noted in that issue, the test fails because the main
On Fri, 8 Aug 2025 07:38:27 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan's review - move the test definition back to before the imports
>
> test/jdk/java/net/vthread/HttpALot.java line 98:
350588)
>
> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
> It adds a non-exposed / non-exported internal implementation of the QUIC
> protocol based on DatagramChannel and the SunJSSE SSLContext provider.
Daniel Fuchs has updated the pull request with a new
On Thu, 10 Jul 2025 13:28:26 GMT, Darragh Clarke wrote:
>> Currently if a request has set Expect-Continue and receives a non 100
>> response the `responseMessage` wouldn't be set.
>>
>> This PR sets `responseMessage`, it also updates `getResponseMessage` to
>> check if the message has already
On Tue, 8 Jul 2025 14:33:04 GMT, Darragh Clarke wrote:
>> Currently if a request has set Expect-Continue and receives a non 100
>> response the `responseMessage` wouldn't be set.
>>
>> This PR sets `responseMessage`, it also updates `getResponseMessage` to
>> check if the message has already b
On Tue, 8 Jul 2025 14:33:04 GMT, Darragh Clarke wrote:
>> Currently if a request has set Expect-Continue and receives a non 100
>> response the `responseMessage` wouldn't be set.
>>
>> This PR sets `responseMessage`, it also updates `getResponseMessage` to
>> check if the message has already b
350588)
>
> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
> It adds a non-exposed / non-exported internal implementation of the QUIC
> protocol based on DatagramChannel and the SunJSSE SSLContext provider.
Daniel Fuchs has updated the pull request with a new
350588)
>
> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
> It adds a non-exposed / non-exported internal implementation of the QUIC
> protocol based on DatagramChannel and the SunJSSE SSLContext provider.
Daniel Fuchs has updated the pull request with a new
On Mon, 7 Jul 2025 09:32:33 GMT, Volkan Yazici wrote:
>> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)`
>> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient`
>> publisher to upload a certain region of a file. The new publisher does not
>> modi
On Mon, 7 Jul 2025 08:29:40 GMT, Daniel Fuchs wrote:
>> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)`
>> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient`
>> publisher to upload a certain region of a file. The new
On Mon, 7 Jul 2025 07:33:58 GMT, Volkan Yazici wrote:
> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)`
> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient`
> publisher to upload a certain region of a file. The new publisher does not
> modify t
On Wed, 2 Jul 2025 08:37:34 GMT, Daniel Fuchs wrote:
> The PlainHttpConnection::connectAsync method implements a retry logic that
> will call connect() again if connect() throws the first time. This will not
> work, as the channel is closed when connect() throws. That logic
On Fri, 4 Jul 2025 09:04:52 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review feedback
>
> Marked as reviewed by djelinski (Reviewer).
Thanks @djelinski @
On Fri, 4 Jul 2025 13:08:28 GMT, Michael McMahon wrote:
>I think this code was added to deal with
>https://bugs.openjdk.org/browse/JDK-8256459. Did the change not fix that
>problem? Or did that change include the changes to MultiExchange you mention
>above?
The change did not include changes
On Thu, 3 Jul 2025 12:56:00 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/PlainHttpConnection.java
>> line 1:
>>
>>> 1: /*
>>
>> Shouldn't we remove the following too?
>>
>> 1. The `unsuccessfulAttemp
at a higher level
> (MultiExchange).
Daniel Fuchs has updated the pull request incrementally with one additional
commit since the last revision:
Review feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/26087/files
- new: https://git.openjdk.org/jdk/pull/26087
at a higher level
> (MultiExchange).
Daniel Fuchs has updated the pull request incrementally with one additional
commit since the last revision:
Review feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/26087/files
- new: https://git.openjdk.org/jdk/pull/26087
On Thu, 3 Jul 2025 20:25:13 GMT, Volkan Yazici wrote:
> Explicitly use `NO_PROXY` in `LookupTest` to avoid test failures on
> environments where proxy is configured. Updated test run results on various
> platforms are attached to the ticket.
Sorry about that. It looks like we can withdraw thi
On Thu, 3 Jul 2025 10:49:21 GMT, Volkan Yazici wrote:
>> The PlainHttpConnection::connectAsync method implements a retry logic that
>> will call connect() again if connect() throws the first time. This will not
>> work, as the channel is closed when connect() throws. That logic should be
>> re
On Wed, 2 Jul 2025 12:45:59 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which updates the
>> `jdk.internal.net.http.HttpConnection` to keep track of the origin server
>> for which the `HttpConnection` was constructed? This addresses
>> https://bugs.openjdk.org/browse/J
The PlainHttpConnection::connectAsync method implements a retry logic that will
call connect() again if connect() throws the first time. This will not work, as
the channel is closed when connect() throws. That logic should be removed.
Reconnection should only be attempted at a higher level (Mult
On Wed, 2 Jul 2025 06:19:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which updates the
>> `jdk.internal.net.http.HttpConnection` to keep track of the origin server
>> for which the `HttpConnection` was constructed? This addresses
>> https://bugs.openjdk.org/browse/J
On Tue, 1 Jul 2025 11:21:53 GMT, Jaikiran Pai wrote:
>> test/jdk/com/sun/net/httpserver/Test12.java line 66:
>>
>>> 64: Path smallFilePath = createTempFileOfSize(TEMP_FILE_PREFIX,
>>> null, 23);
>>> 65: Path largeFilePath = createTempFileOfSize(TEMP_FILE_PREFIX,
>>> null, 27300
On Tue, 1 Jul 2025 12:43:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses an
>> intermittent failure in `test/jdk/com/sun/net/httpserver/Test12.java`? This
>> fixes https://bugs.openjdk.org/browse/JDK-8359477.
>>
>> In the linked JBS issue I've
On Tue, 1 Jul 2025 09:31:15 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses an
>> intermittent failure in `test/jdk/com/sun/net/httpserver/Test12.java`? This
>> fixes https://bugs.openjdk.org/browse/JDK-8359477.
>>
>> In the linked JBS issue I've
On Mon, 30 Jun 2025 15:23:22 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which updates the
>> `jdk.internal.net.http.HttpConnection` to keep track of the origin server
>> for which the `HttpConnection` was constructed? This addresses
>> https://bugs.openjdk.org/browse/
On Mon, 30 Jun 2025 11:07:55 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which updates the
> `jdk.internal.net.http.HttpConnection` to keep track of the origin server for
> which the `HttpConnection` was constructed? This addresses
> https://bugs.openjdk.org/browse/JDK-
On Mon, 30 Jun 2025 11:07:55 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which updates the
> `jdk.internal.net.http.HttpConnection` to keep track of the origin server for
> which the `HttpConnection` was constructed? This addresses
> https://bugs.openjdk.org/browse/JDK-
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517
On Mon, 30 Jun 2025 09:34:48 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517
On Mon, 16 Jun 2025 09:44:13 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to enhance the
>> implementation of `ServerSocket` and `ServerSocketChannel` to allow for
>> `backlog` values to be greater than 200 on Windows? This addresses
>> https://bugs.openj
On Fri, 27 Jun 2025 11:37:00 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run
On Fri, 27 Jun 2025 11:22:51 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517
On Thu, 26 Jun 2025 17:36:21 GMT, Daniel Jeliński wrote:
>> src/java.base/share/classes/jdk/internal/net/quic/QuicTLSContext.java line
>> 70:
>>
>>> 68: if (!(underlyingImpl instanceof SSLContextImpl ssci)) {
>>> 69: return false;
>>> 70: }
>>
>> Would there be a wa
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517
350588)
>
> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
> It adds a non-exposed / non-exported internal implementation of the QUIC
> protocol based on DatagramChannel and the SunJSSE SSLContext provider.
Daniel Fuchs has updated the pull request with a new
On Thu, 26 Jun 2025 11:04:33 GMT, Daniel Fuchs wrote:
>> Thank you Artur.
>>
>> @dfuch this conversation can be resolved too.
>
> Done
> Hi Jaikiran! Sounds good. It's likely we are going to re-work this code
> anyhow when we make QUIC engine pub
On Thu, 26 Jun 2025 13:22:28 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/sun/security/ssl/X509Authentication.java line
>> 226:
>>
>>> 224: chc.peerSupportedAuthorities == null ? null :
>>> 225: chc.peerSupportedAuthorities.clone(),
>>>
On Thu, 26 Jun 2025 10:48:56 GMT, Darragh Clarke wrote:
> Currently if a request has set Expect-Continue and receives a non 100
> response the `responseMessage` wouldn't be set.
>
> This PR sets `responseMessage`, it also updates `getResponseMessage` to check
> if the message has already been
On Thu, 26 Jun 2025 10:48:56 GMT, Darragh Clarke wrote:
> Currently if a request has set Expect-Continue and receives a non 100
> response the `responseMessage` wouldn't be set.
>
> This PR sets `responseMessage`, it also updates `getResponseMessage` to check
> if the message has already been
On Thu, 26 Jun 2025 01:04:41 GMT, Jaikiran Pai wrote:
>> Hi Jaikiran! Sounds good. It's likely we are going to re-work this code
>> anyhow when we make QUIC engine public in the next iteration. We had a
>> discussion with Daniel about it today.
>
> Thank you Artur.
>
> @dfuch this conversation
On Wed, 25 Jun 2025 09:58:55 GMT, Michael McMahon wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [1fa09052](https://github.com/openjdk/jdk/commit/1fa090524a7c3bb5f2c92fb0f7217b9277ade9d9)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Wed, 4 Jun 2025 17:43:16 GMT, Daniel Fuchs wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 506 commits:
>>
>> - merge latest changes from master branch
>> - http3: update
On Wed, 18 Jun 2025 09:16:21 GMT, Jaikiran Pai wrote:
> Can I please get a review of this backport to JDK 25 for
> https://bugs.openjdk.org/browse/JDK-8359709? This fix addresses a regression
> that was introduced in JDK 24. The mainline fix was integrated a few mintues
> back through https://
Hi David,
On 19/06/2025 18:08, David Nadeau wrote:
I do want to follow up on the expected behavior of HttpClient in this case.
If this kind of catastrophic failure within the HttpClient when using
ThreadPools with bounded queues is falling within the expected behaviors
of the HttpClient, then
On Thu, 19 Jun 2025 15:12:20 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This is a fix to j.n.HttpCookie (which has a doc/spec change). So, I'm
>> targeting it to 26.
>> We currently do not obey the rule in RFC 6265 that says if both Max-Age and
>> Expires attributes
>> are present in a cookie, t
On Thu, 19 Jun 2025 12:00:52 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This is a fix to j.n.HttpCookie (which has a doc/spec change). So, I'm
>> targeting it to 26.
>> We currently do not obey the rule in RFC 6265 that says if both Max-Age and
>> Expires attributes
>> are present in a cookie, t
Hi David,
As a general rule, the client doesn't expect tasks to
be rejected by the executor. Tasks need to be executed,
one way or another, for the client to work as expected.
Executing in the current thread is often not an option
as it may lead to deadlocks.
So if we get a RejectedTaskExection,
On Wed, 18 Jun 2025 10:54:12 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This is a fix to j.n.HttpCookie (which has a doc/spec change). So, I'm
>> targeting it to 26.
>> We currently do not obey the rule in RFC 6265 that says if both Max-Age and
>> Expires attributes
>> are present in a cookie, t
On Wed, 18 Jun 2025 09:16:21 GMT, Jaikiran Pai wrote:
> Can I please get a review of this backport to JDK 25 for
> https://bugs.openjdk.org/browse/JDK-8359709? This fix addresses a regression
> that was introduced in JDK 24. The mainline fix was integrated a few mintues
> back through https://
1 - 100 of 1679 matches
Mail list logo
