CFV: check for openssl functions instead of hardcoding in system/xxx.h

2010-08-24 Thread Robert Story
test for EVP_sha224/EVP_sha384 functions in openssl/evp.h instead of hardcoding lack of them per os, since any os could have an old openssl lib without support for these functions. commit 988cf6c985685849ffc6071b4777ee9e74094b04 Author: Robert Story Date: Wed Aug 25 00:02:50 2010 -0400 tes

Re: CFV: fix uninitialized local variable

2010-08-24 Thread Thomas Anders
Robert Story wrote: > anyhoo, this patch initializes the temporary variable. +1 -- Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook

Re: CFV: simple error string patch

2010-08-24 Thread Wes Hardaker
> On Tue, 24 Aug 2010 23:01:24 +0200, Thomas Anders > said: TA> Wes Hardaker wrote: >> To fix an error string which was a cut-n-paste without a replacement in >> the new DTLS code. TA> +1 (what a waste to even do voting on such a trivial TA> change. sometimes policies feel strange.) Y

Re: CFV: simple error string patch

2010-08-24 Thread Thomas Anders
Wes Hardaker wrote: > To fix an error string which was a cut-n-paste without a replacement in > the new DTLS code. +1 (what a waste to even do voting on such a trivial change. sometimes policies feel strange.) -- Sell a

Re: CFV: simple error string patch

2010-08-24 Thread Magnus Fromreide
On Tue, 2010-08-24 at 12:50 -0700, Wes Hardaker wrote: > To fix an error string which was a cut-n-paste without a replacement in > the new DTLS code. +1 /MF -- Sell apps to millions through the Intel(R) Atom(Tm) Develo

Re: CFV: CRITICAL: r19341 Patch 3042765 can cause client lockup

2010-08-24 Thread Magnus Fromreide
On Tue, 2010-08-24 at 14:46 -0400, Robert Story wrote: > Patch 3042765 breaks synchronous handling of a remote client disconnect > for a tcp session, causing the client to be stuck inside a select() call > waiting for data that will never come. > > Basically the change in session handling results i

CFV: simple error string patch

2010-08-24 Thread Wes Hardaker
To fix an error string which was a cut-n-paste without a replacement in the new DTLS code. -- Wes Hardaker Please mail all replies to [email protected] diff --git a/net-snmp/snmplib/transports/snmpDTLSUDPDomain.c b/net-snmp/snmplib/transports/snmpDTLSUDPDomain.c index b4e9230

Re: CFV: CRITICAL: r19341 Patch 3042765 can cause client lockup

2010-08-24 Thread Wes Hardaker
> On Tue, 24 Aug 2010 14:46:47 -0400, Robert Story > said: RS> The original patch is attached, and I think it should be reversed RS> ASAP. +1 (I applied it wondering how long it would be before spotting a problem with it; glad it was quick... There are so so many invocation paths that

Re: CFV: fix uninitialized local variable

2010-08-24 Thread Wes Hardaker
> On Tue, 24 Aug 2010 14:00:44 -0400, Robert Story > said: RS> anyhoo, this patch initializes the temporary variable. The code is RS> in the new support for (D)TLS, so it's not compiled in by default. +1 -- Wes Hardaker Please mail all replies to [email protected]

CFV: CRITICAL: r19341 Patch 3042765 can cause client lockup

2010-08-24 Thread Robert Story
Patch 3042765 breaks synchronous handling of a remote client disconnect for a tcp session, causing the client to be stuck inside a select() call waiting for data that will never come. CHANGES: snmplib: PATCH 3042765: from mehaf: make snmp_synch_response_cb() re-entrant Here are debug traces for

CFV: fix uninitialized local variable

2010-08-24 Thread Robert Story
r19179 fixed some compiler warnings by introducing temporary local variables matching types in function prototypes. The temporary variable was not initialized before being passed to the function, so it was working last week, but is failing this week (likely due to a change in the endianess of the t

Re: CFV: fix some tls tests

2010-08-24 Thread Thomas Anders
Robert Story wrote: > Sounds reasonable. I'll cache the patch and see what happens with rc2. To be honest, I think caching has more cons than pros here. rc2 is going to happen anyway and the later you commit your patch, the later we identify potential problems. IOW, my vote is to apply your patc

Re: CFV: fix some tls tests

2010-08-24 Thread Wes Hardaker
> On Tue, 24 Aug 2010 08:46:15 +0100, Dave Shield > said: DS> Alternatively, it might be sensible for such intermediate level changes DS> to require a +1 vote. So in practice it should be sufficient to flag the DS> change on the mailing list, with no dissenting voices. I'd be good wit

Re: CFV: fix some tls tests

2010-08-24 Thread Robert Story
On Tue, 24 Aug 2010 08:46:15 +0100 Dave wrote: DS> I'm inclined to treat these in a similar to inline-documentation tweaks, DS> i.e. only suitable if there's another RC candidate planned, but not DS> requiring an explicit vote. Sounds reasonable. I'll cache the patch and see what happens with rc2.

Re: Error messages in snmpd.log

2010-08-24 Thread Robert Story
On Mon, 23 Aug 2010 22:02:54 -0700 Abhimanyu wrote: AC> I am useing net-snmp-5.3.3 on MIPS architecture. You might try a more recent relese. AC> I am getting following error messages in snmpd.log during initial snmpd AC> bootup: AC> netsnmp_assert !"registration != duplicate" failed agent_registr

Re: CFV: fix some tls tests

2010-08-24 Thread Dave Shield
On 23 August 2010 21:34, Robert Story wrote: > do you think a CFV is needed for changes to non-default test scripts? i.e. > scripts that won't be run unless explicitly requested by the user? Probably not, no. Changes to test scripts (and to mib2c templates) feel to lie somewhere in between code