Re: Odd code

2010-08-31 Thread Madhu
its with the net-snmp-5.6.pre3 release as i found... On Wed, Sep 1, 2010 at 11:46 AM, rakesh zingade wrote: > can you mention the snmp version in which you saw this piece of code? > > I check 5.5 and 5.4 but unable to find the same.. > > > On Wed, Sep 1, 2010 at 11:30 AM, Magnus Fromreide wrote:

Re: Odd code

2010-08-31 Thread Magnus Fromreide
On Wed, 2010-09-01 at 11:46 +0530, rakesh zingade wrote: > can you mention the snmp version in which you saw this piece of code? trunk (5.6 to be - so yes, this is new code) -- This SF.net Dev2Dev email is sponsored by:

Re: Odd code

2010-08-31 Thread rakesh zingade
can you mention the snmp version in which you saw this piece of code? I check 5.5 and 5.4 but unable to find the same.. On Wed, Sep 1, 2010 at 11:30 AM, Magnus Fromreide wrote: > In snmp_api.c, at line 1521-1527, there is the following piece of code: > >if ((rc = > netsnmp_sess_config_transp

CFV: Call the debug statement before returning from the function

2010-08-31 Thread Magnus Fromreide
I'd like to add this pretty obvious patch. It calls DEBUGMSG before returning instead of after... Index: agent/mibgroup/hardware/cpu/cpu.c === --- agent/mibgroup/hardware/cpu/cpu.c (revision 19356) +++ agent/mibgroup/hardware/cpu/cpu.c

Odd code

2010-08-31 Thread Magnus Fromreide
In snmp_api.c, at line 1521-1527, there is the following piece of code: if ((rc = netsnmp_sess_config_transport(in_session->transport_configuration, transport)) != SNMPERR_SUCCESS) { return rc; in_session->s_snmp_errno = rc; i

undefined symbol: smux_listen_sd

2010-08-31 Thread Prakash
Hi All, When I restart the snmpd I am getting the following error. # service snmpd restart Shutting down snmpd: done Starting snmpd/usr/sbin/snmpd: symbol lookup error: /usr/sbin/snmpd: undefined symbol: smux_listen_sd startproc: exit status of parent of /usr/sbin/snmpd: 127 failed

CFV: don't do wildcards if exact match exists

2010-08-31 Thread Robert Story
The net-snmp-cert utility script currently does wildcard matching on any input when searching for certificates. e.g. 'joe' would match 'joe', 'joel' and 'joe bob'. With this patch (from Joe Marzot, who wrote the script) will only return 'joe', an require a wildcard to be specified to get additional

Re: CFV: Move some symbols from acconfig.h

2010-08-31 Thread Robert Story
On Tue, 31 Aug 2010 19:39:03 +0200 Bart wrote: BVA> > > - It breaks the MSVC build. ugh.. so forget the previous +1, breaking builds is a no-no. Bart, thanks for testing! BVA> > Then, still, what *should* be the (proper) separator character for net-snmp BVA> > on Cygwin and MinGW (in the long ru

Re: CFV: Move some symbols from acconfig.h

2010-08-31 Thread Robert Story
On Tue, 31 Aug 2010 06:52:04 -0700 Wes wrote: WH> Assuming you've tested it, +1 ditto -- This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010.

Re: CFV: Do not let the absence of an agent imply any mib modules

2010-08-31 Thread Robert Story
On Tue, 31 Aug 2010 10:42:52 -0700 Wes wrote: WH> So, +1 if you've compiled it successfully without the agent but with trapd :-) ditto.. -- This SF.net Dev2Dev email is sponsored by: Show off your parallel programming s

Re: CFV: TLS shutdown and proper cleanup

2010-08-31 Thread Robert Story
On Mon, 30 Aug 2010 21:35:52 -0700 Wes wrote: WH> The following patch provides proper (D)TLS shutdown and cleanup. It has WH> been tested using both command line tests as well as the existing TLS WH> test sub-suite. +1 -

Re: CFV: Do not let the absence of an agent imply any mib modules

2010-08-31 Thread Wes Hardaker
> On Tue, 31 Aug 2010 07:20:39 +0200, Magnus Fromreide > said: MF> I recently tried to build just the library (--disable-agent MF> --disable-applications --disable-scripts) and got surprised since MF> mibII/vacm_vars mibII/vacm_conf and utilities/execute got added MF> automatically. It t

Re: CFV: Move some symbols from acconfig.h

2010-08-31 Thread Bart Van Assche
On Tue, Aug 31, 2010 at 7:33 PM, Thomas Anders wrote: > Bart Van Assche wrote: > > This patch is not just cleanup because: > > - It breaks the MSVC build. > > - It changes behavior on the Cygwin and MinGW platforms. On these two > > platforms the PATH_SEPARATOR is a colon (':') while Net-SNMP uses

Re: CFV: Move some symbols from acconfig.h

2010-08-31 Thread Thomas Anders
Bart Van Assche wrote: > This patch is not just cleanup because: > - It breaks the MSVC build. > - It changes behavior on the Cygwin and MinGW platforms. On these two > platforms the PATH_SEPARATOR is a colon (':') while Net-SNMP uses the > semicolon (';') as ENV_SEPARATOR for these two platforms.

Re: CFV: TLS shutdown and proper cleanup

2010-08-31 Thread Thomas Anders
Wes Hardaker wrote: > The following patch provides proper (D)TLS shutdown and cleanup. It has > been tested using both command line tests as well as the existing TLS > test sub-suite. > > The clean up is obviously just "nice for memory", but the session > closing on the DTLS side was missed as th

Re: CFV: Move some symbols from acconfig.h

2010-08-31 Thread Bart Van Assche
On Tue, Aug 31, 2010 at 7:24 AM, Magnus Fromreide wrote: > I found some low hanging fruit in acconfig.h and would like to move it > to the configure script. Ok for trunk (together with regenerated > configure and net-snmp-config.h.in) > This patch is not just cleanup because: - It breaks the MSV

Re: CFV: Move some symbols from acconfig.h

2010-08-31 Thread Wes Hardaker
> On Tue, 31 Aug 2010 07:24:42 +0200, Magnus Fromreide > said: MF> I found some low hanging fruit in acconfig.h and would like to move it MF> to the configure script. Ok for trunk (together with regenerated MF> configure and net-snmp-config.h.in) Assuming you've tested it, +1 The only