Re: CFV: don't do wildcards if exact match exists

2010-09-03 Thread Thomas Anders
Wes Hardaker wrote: > (and I tested it to make sure the functionality works as expected) +1, then. +Thomas -- This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Thr

Re: CVF2: don't assume the process status is still available. ham

2010-09-03 Thread Thomas Anders
Wes Hardaker wrote:: > Ok, here's a now copy that checks all fopens and fgets: Error handling gets +2. :-) What about Robert's proposal to add a DEBUGMSG if the file/process went away? +Thomas -- This SF.net Dev2Dev e

Re: CFV: SA_REPEAT timers broken in 5.6.rc1 (Patch 3058451)

2010-09-03 Thread Wes Hardaker
> On Fri, 03 Sep 2010 10:13:06 +0200, Thomas Anders > said: TA> Revision 19323 broke SA_REPEAT timers by incorrectly removing all TA> flags instead of just SA_FIRED. Thanks Thomas. Applied! (err... "ing". It'll be "ed" in a second) -- Wes Hardaker Please mail all replies to net-snmp

Fwd: SF.net SVN: net-snmp:[19356] trunk/net-snmp

2010-09-03 Thread Bart Van Assche
This commit introduced a new compiler warning: transports/snmpTLSBaseDomain.c: In function 'netsnmp_tlsbase_free_tlsdata': transports/snmpTLSBaseDomain.c:777:9: warning: 'return' with no value, in function returning non-void -- Forwarded message -- From: Date: Wed, Sep 1, 2010 a

Re: CVF2: don't assume the process status is still available. ham

2010-09-03 Thread Bart Van Assche
On Fri, Sep 3, 2010 at 5:32 PM, Robert Story wrote: > On Thu, 02 Sep 2010 14:32:06 -0700 Wes wrote: > WH> > WH> Ok, here's a now copy that checks all fopens and fgets: > > +1 > +1 Bart. -- This SF.net Dev2Dev email is s

Re: CFV: use pci_lookup_name to set ifDescr

2010-09-03 Thread Robert Story
On Fri, 3 Sep 2010 12:51:06 -0400 Robert wrote: RS> WH> I think I'm leaning against this one for 5.6 as it seems new-feature-ish RS> WH> and we're beyond that point. RS> RS> I dunno, I can see lack of description as a bug. So I'll vote +1 and let RS> other shoot us down if it seems like a feature

Re: CFV: use pci_lookup_name to set ifDescr

2010-09-03 Thread Robert Story
On Fri, 3 Sep 2010 12:51:06 -0400 Robert wrote: RS> WH> I think I'm leaning against this one for 5.6 as it seems new-feature-ish RS> WH> and we're beyond that point. RS> RS> I dunno, I can see lack of description as a bug. So I'll vote +1 and let RS> other shoot us down if it seems like a feature

Re: CFV: ifAlias support

2010-09-03 Thread Robert Story
On Fri, 3 Sep 2010 10:35:05 -0700 Stephen wrote: SH> This is the correct patch. SH> SH> Subject: if-mib: add support for ifAlias SH> SH> Linux has a way of recording an ifAlias value for each interface. SH> The value is configurable with iproute utilities or sysfs. -1 because it doesn't integrat

Re: CFV: ifAlias support

2010-09-03 Thread Stephen Hemminger
This is the correct patch. Subject: if-mib: add support for ifAlias Linux has a way of recording an ifAlias value for each interface. The value is configurable with iproute utilities or sysfs. --- agent/mibgroup/if-mib/data_access/interface.c |6 agent/mibgroup/if-mib/data_access

Re: CFV: ifAlias support

2010-09-03 Thread Wes Hardaker
> On Fri, 3 Sep 2010 12:52:32 -0400, Robert Story > said: RS> This patch looks like a speed patch, not alias... did you attache the right RS> thing? Hmm... I agree and I think the patch attached to the patch DB is actually wrong. I just didn't notice. -- Wes Hardaker Please mail all

Re: CFV: fix: get_pid_from_inode when inode not found.

2010-09-03 Thread Robert Story
On Fri, 03 Sep 2010 09:29:03 -0700 Wes wrote: WH> get_pid_from_inode returns the last pid found in /proc/ when the inode WH> of a socket can not be found. Moving the following line to the place WH> where an inode match has been detected solves this problem, as the pid WH> was already set to zero a

Re: CFV:

2010-09-03 Thread Robert Story
On Fri, 03 Sep 2010 09:27:19 -0700 Wes wrote: WH> This seems bug-fix related and thus appropriate for 5.6. +1 for me, WH> though I'd appreciate it if someone knowledgeable in the code stack for WH> this table would look at it. If I wasn't getting ready to go on vacation... :-/ I'd rather fix th

Re: CFV: ifAlias support

2010-09-03 Thread Robert Story
On Fri, 03 Sep 2010 09:21:50 -0700 Wes wrote: WH> ID: 3057092 WH> Last Update: Attachment added ( shemminger ) WH> Details: WH> WH> Linux has a way of recording an ifAlias value for each interface. WH> The value is configurable with iproute utilities or sysfs. This patch looks like a sp

Re: snmpwalk response times

2010-09-03 Thread Robert Story
On Fri, 03 Sep 2010 09:24:58 -0700 Wes wrote: WH> This would be really cool but i also suspect it's too late for 5.6. agreed. -1 -- This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills.

Re: CFV: use pci_lookup_name to set ifDescr

2010-09-03 Thread Robert Story
On Fri, 03 Sep 2010 09:20:33 -0700 Wes wrote: WH> On Linux, use sysfs to find the vendor/device_id if possible for WH> interface. Then use the pci_lookup_name function to map that to a string WH> for use in ifDescr. Cool, I've wanted to do ifDescr support for years, but never had time to fig

CFV: Re: fix get_pid_from_inode when inode is zero

2010-09-03 Thread Robert Story
On Fri, 03 Sep 2010 09:18:44 -0700 Wes wrote: WH> When the inode is zero, get_pid_from_inode will match it with invalid WH> file descriptors. It will therefor return pid 1 (init), because it is WH> the first to match with inode zero. This patch checks the inode given WH> and returns a zero pid if

Re: CFV: fix includeAllDisks directive in trunk

2010-09-03 Thread Robert Story
On Fri, 03 Sep 2010 09:17:29 -0700 Wes wrote: WH> I'm actually wondering why we're not doing a full strcasecmp and why WH> we're using the 'n' version? Robert? good question.. I think that I initially only had the 'i' test there, and someone else added the 'n' version... I recall that Dave was ma

Re: CFV: (un)blocking unix recv call

2010-09-03 Thread Robert Story
On Fri, 03 Sep 2010 09:15:33 -0700 Wes wrote: WH> Though I wonder if MSG_DONTWAIT is defined on every OS or not. I'd be WH> tempted to do that call iff [sic] it exists, otherwise stay with the ,0 Given the lateness in the release cycle, I'd tend to go with that safer option, so a +1 for that. Ot

Sorry for the late calls on the patches DB

2010-09-03 Thread Wes Hardaker
If any get +3 in the next few hours, I'll apply them before rc2. They're worth looking through quickly as many are good bug fixes. -- Wes Hardaker Please mail all replies to [email protected] -- This

CFV: fix: get_pid_from_inode when inode not found.

2010-09-03 Thread Wes Hardaker
This is a +1 bugfix for me. ID: 3053428 Last Update: Attachment added ( takevos ) Details: get_pid_from_inode returns the last pid found in /proc/ when the inode of a socket can not be found. Moving the following line to the place where an inode match has been detected solves this problem, a

CFV:

2010-09-03 Thread Wes Hardaker
This seems bug-fix related and thus appropriate for 5.6. +1 for me, though I'd appreciate it if someone knowledgeable in the code stack for this table would look at it. - ID: 3053436 Last Update: Attachment added ( takevos ) Details: On some Linux systems the tcpListenerTable shows a random n

snmpwalk response times

2010-09-03 Thread Wes Hardaker
This would be really cool but i also suspect it's too late for 5.6. I also wonder if there would be a way to do this more generically for all the apps. ID: 3054817 Last Update: Attachment added ( nightcoding ) Details: I would consider it desirable to have snmpwalk output the response time f

add support for ethtool speed_hi

2010-09-03 Thread Wes Hardaker
Another patch that I think will be better for 5.7 at this point, but I'm posting them all :-) ID: 3057090 Last Update: Attachment added ( shemminger ) Details: Change the use of Linux ethtool interface to match current conventions used by the ethtool utility: * allow any reported value for spe

CFV: ifAlias support

2010-09-03 Thread Wes Hardaker
ID: 3057092 Last Update: Attachment added ( shemminger ) Details: Linux has a way of recording an ifAlias value for each interface. The value is configurable with iproute utilities or sysfs. Like the previous, I look forward to applying this post-5.6 but think it shouldn't go into 5.6.

CFV: use pci_lookup_name to set ifDescr

2010-09-03 Thread Wes Hardaker
ID: 3057093 Last Update: Attachment added ( shemminger ) Details: On Linux, use sysfs to find the vendor/device_id if possible for interface. Then use the pci_lookup_name function to map that to a string for use in ifDescr. This produces values like: ifDescr.5 = STRING: Intel Cor

fix get_pid_from_inode when inode is zero

2010-09-03 Thread Wes Hardaker
ID: 3058140 When the inode is zero, get_pid_from_inode will match it with invalid file descriptors. It will therefor return pid 1 (init), because it is the first to match with inode zero. This patch checks the inode given and returns a zero pid if the inode is also zero. Obviously I'd fix the c

CFV: fix includeAllDisks directive in trunk

2010-09-03 Thread Wes Hardaker
Patch 3058388: Changes in 'include' support in config file parsing seem to have broken includeAllDisks. I now get the following error: /etc/snmp/snmpd.conf: line 5: Warning: Unknown include token: includeAllDisks. No disks are included. Looks like it was caused by changes to snmplib/r

CFV: (un)blocking unix recv call

2010-09-03 Thread Wes Hardaker
This is patch 3058645 from the patches DB: In version 5.4.1 in snmplib/snmpUnixDomain.c in the function netsnmp_unix_recv there is a recv call on a unix domain socket. This call has the potential of blocking, even though select returned the socket as ready to read. The flag MSG_DONTWAI

Re: CFV: SA_REPEAT timers broken in 5.6.rc1 (Patch 3058451)

2010-09-03 Thread Robert Story
On Fri, 03 Sep 2010 10:13:06 +0200 Thomas wrote: TA> Patch 3058451 (https://sourceforge.net/tracker/?func=detail&atid=312694&aid=3058451&group_id=12694) says: TA> TA> Revision 19323 broke SA_REPEAT timers by incorrectly removing all flags instead of just SA_FIRED. TA> TA> http://net-snmp.svn.

Re: CFV: fix tlstcp address parsing

2010-09-03 Thread Robert Story
On Thu, 02 Sep 2010 12:16:15 -0700 Wes wrote: WH> The existing TLSTCP support doesn't handle tls:10.0.0.1 correctly. With WH> this patch all the proper formats work again: WH> tls:10161 WH> tls:0.0.0.0 WH> tls:0.0.0.0:10161 ah, you found it! just in time... +1

Re: CVF2: don't assume the process status is still available. ham

2010-09-03 Thread Robert Story
On Thu, 02 Sep 2010 14:32:06 -0700 Wes wrote: WH> WH> Ok, here's a now copy that checks all fopens and fgets: +1 -- This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R

Re: snmpd agent not listening on port

2010-09-03 Thread Fulko Hew
On Fri, Sep 3, 2010 at 1:27 AM, Abraham Varricatt wrote: > I can't get the snmpd agent I built to listed to connections. Here is > what happens when I start it, > >> sudo -i snmpd -f -Lo udp:161 -C -c /home/abraham/snmpd.conf > NET-SNMP version 5.5 > > > and no more output. It just stays stuck lik

Problem with counting procs

2010-09-03 Thread Johan Huysmans
Hi All, I'm running snmpd on my CentOS5 systems for monitoring. Every 3 seconds the prErrorFlags are checked from the configured procs. But on some moments it falsely detects an error, which is gone during the next check. Investigating this we didn't notice any strange behavior on the machine

Re: snmpd agent not listening on port

2010-09-03 Thread Wes Hardaker
I'd start by running both the agent and your tools with -d, which shows when packets are received. Then you can see if the agent is actually receiving something. It's also possible (likely) that agent is actually receiving the requests but discarding them since they're not authorized (and runnin

Re: CFV: SA_REPEAT timers broken in 5.6.rc1 (Patch 3058451)

2010-09-03 Thread Wes Hardaker
> On Fri, 03 Sep 2010 10:13:06 +0200, Thomas Anders > said: TA> Patch is attached. +1 -- Wes Hardaker Please mail all replies to [email protected] -- This SF.net Dev2Dev email is sponsored

Re: CFV: SA_REPEAT timers broken in 5.6.rc1 (Patch 3058451)

2010-09-03 Thread Bart Van Assche
On Fri, Sep 3, 2010 at 10:13 AM, Thomas Anders wrote: > Patch 3058451 ( > https://sourceforge.net/tracker/?func=detail&atid=312694&aid=3058451&group_id=12694) > says: > > Revision 19323 broke SA_REPEAT timers by incorrectly removing all flags > instead of just SA_FIRED. > > > http://net-snmp.svn.s

CFV: SA_REPEAT timers broken in 5.6.rc1 (Patch 3058451)

2010-09-03 Thread Thomas Anders
Patch 3058451 (https://sourceforge.net/tracker/?func=detail&atid=312694&aid=3058451&group_id=12694) says: Revision 19323 broke SA_REPEAT timers by incorrectly removing all flags instead of just SA_FIRED. http://net-snmp.svn.sourceforge.net/viewvc/net-snmp/trunk/net-snmp/snmplib/snmp_alarm.c?r1

[5.6-rc1 - python] Deprecated function snmp_api_errstring() still used

2010-09-03 Thread Diego Billi
I was checking the SVN tag version of the python module. I saw that in three points the code still uses the snmp_api_errstring() function. Is there any reason snmp_api_errstring() was added even if the README.thread file reports The following variables and functions are obsolete and may