Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-22 Thread Magnus Fromreide
On Mon, May 21, 2018 at 02:36:43PM -0400, Bill Fenner wrote: > On Mon, May 21, 2018 at 11:18 AM, Wes Hardaker < > harda...@users.sourceforge.net> wrote: > > > Bill Fenner writes: > > > > > So, +1 on committing Bart's patch, because it accomplishes the goal of > > > fixing the

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-21 Thread Bill Fenner
On Mon, May 21, 2018 at 11:18 AM, Wes Hardaker < harda...@users.sourceforge.net> wrote: > Bill Fenner writes: > > > So, +1 on committing Bart's patch, because it accomplishes the goal of > > fixing the regression, with the caveat that I really think that this > > whole area

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-21 Thread Wes Hardaker via Net-snmp-coders
Bill Fenner writes: > So, +1 on committing Bart's patch, because it accomplishes the goal of > fixing the regression, with the caveat that I really think that this > whole area needs to be revisited. I think this comment is spot on. So I'd accept the patch too, though my gut

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-20 Thread Bill Fenner
On Sun, May 20, 2018 at 2:25 PM, Robert Story wrote: > On Sun, 20 May 2018 13:06:43 -0400 Bill wrote: > BF> I do not think that now is the time to try to deal with any of > BF> the fundamentals, but just not regress from previous released > BF> behavior, and deal with the

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-20 Thread Robert Story
On Sun, 20 May 2018 13:06:43 -0400 Bill wrote: BF> I do not think that now is the time to try to deal with any of BF> the fundamentals, but just not regress from previous released BF> behavior, and deal with the underlying issue in 5.8.1 / 5.7.4. Just to clarify, do you mean a) accepts Bart's

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-20 Thread Bill Fenner
On Sun, May 20, 2018 at 12:18 AM, Robert Story wrote: > On Sat, 19 May 2018 14:07:56 -0700 Bart wrote: > BVA> strlcpy() implementations typically scan for the end of the > BVA> source argument passed to strlcpy(). Hence avoid passing an > BVA> unterminated string to

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-20 Thread Bart Van Assche
On 05/19/18 21:18, Robert Story wrote: On Sat, 19 May 2018 14:07:56 -0700 Bart wrote: BVA> strlcpy() implementations typically scan for the end of the BVA> source argument passed to strlcpy(). Hence avoid passing an BVA> unterminated string to strlcpy(). I'm going to say -1, but for the patch

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-19 Thread Magnus Fromreide
On Sat, May 19, 2018 at 05:28:31PM -0700, Bart Van Assche wrote: > On 05/19/18 15:14, Magnus Fromreide wrote: > > On Sat, May 19, 2018 at 02:07:56PM -0700, Bart Van Assche wrote: > > > strlcpy() implementations typically scan for the end of the source > > > argument > > > passed to strlcpy().

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-19 Thread Robert Story
On Sat, 19 May 2018 14:07:56 -0700 Bart wrote: BVA> strlcpy() implementations typically scan for the end of the BVA> source argument passed to strlcpy(). Hence avoid passing an BVA> unterminated string to strlcpy(). I'm going to say -1, but for the patch and not the need to fix the issue. This

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-19 Thread Bart Van Assche
On 05/19/18 15:14, Magnus Fromreide wrote: On Sat, May 19, 2018 at 02:07:56PM -0700, Bart Van Assche wrote: strlcpy() implementations typically scan for the end of the source argument passed to strlcpy(). Hence avoid passing an unterminated string to strlcpy(). Reported-by: Stuart Henderson

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-19 Thread Magnus Fromreide
On Sat, May 19, 2018 at 02:07:56PM -0700, Bart Van Assche wrote: > strlcpy() implementations typically scan for the end of the source argument > passed to strlcpy(). Hence avoid passing an unterminated string to strlcpy(). > > Reported-by: Stuart Henderson > Fixes:

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-19 Thread Stuart Henderson
On 2018/05/19 14:07, Bart Van Assche wrote: > strlcpy() implementations typically scan for the end of the source argument > passed to strlcpy(). Hence avoid passing an unterminated string to strlcpy(). > > Reported-by: Stuart Henderson > Fixes: 7f05daa8e0e0 ("CHANGES: BUG:

[PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-19 Thread Bart Van Assche
strlcpy() implementations typically scan for the end of the source argument passed to strlcpy(). Hence avoid passing an unterminated string to strlcpy(). Reported-by: Stuart Henderson Fixes: 7f05daa8e0e0 ("CHANGES: BUG: 3444939: BUG: 1796886: snmplib: Avoid that