Re: patch 1927751 broke build on Linux?

2009-03-31 Thread Jan Safranek
Magnus Fromreide wrote: On Mon, 2009-03-30 at 13:50 +0200, Jan Safranek wrote: Maybe plain #ifdef checks in icmp.c would be more readable, the MLD_ macros are used only there... I think you are right - #ifdef checks in icmp.c is more readable and keeps the change more localized, I'd say to

Re: patch 1927751 broke build on Linux?

2009-03-30 Thread Jan Safranek
Magnus Fromreide wrote: On Thu, Mar 26, 2009 at 11:10:24AM +0900, Mitsuru Chinen wrote: Hi Thomas, What kind of Linux distribution are you using? I supppose he is using a linux distribution with a libc version lower than 2.4 - at a guess RHEL4 is one of those. For glibc 2.4

Re: patch 1927751 broke build on Linux?

2009-03-30 Thread Magnus Fromreide
On Mon, 2009-03-30 at 13:50 +0200, Jan Safranek wrote: Magnus Fromreide wrote: On Thu, Mar 26, 2009 at 11:10:24AM +0900, Mitsuru Chinen wrote: Hi Thomas, What kind of Linux distribution are you using? I supppose he is using a linux distribution with a libc version lower than 2.4 -

Re: patch 1927751 broke build on Linux?

2009-03-27 Thread Mitsuru Chinen
On Thu, 26 Mar 2009 08:37:48 +0100 Magnus Fromreide ma...@lysator.liu.se wrote: On Thu, Mar 26, 2009 at 11:10:24AM +0900, Mitsuru Chinen wrote: Hi Thomas, What kind of Linux distribution are you using? I supppose he is using a linux distribution with a libc version lower than 2.4 - at

Re: patch 1927751 broke build on Linux?

2009-03-26 Thread Magnus Fromreide
On Thu, Mar 26, 2009 at 11:10:24AM +0900, Mitsuru Chinen wrote: Hi Thomas, What kind of Linux distribution are you using? I supppose he is using a linux distribution with a libc version lower than 2.4 - at a guess RHEL4 is one of those. For glibc 2.4 MLD_LISTENER_QUERY changed name from

Re: patch 1927751 broke build on Linux?

2009-03-25 Thread Mitsuru Chinen
Hi Thomas, What kind of Linux distribution are you using? When I built on Fedora10 for i386, I don't see this build error. Mitsuru Chinen mi...@linux.vnet.ibm.com On Wed, 25 Mar 2009 00:08:03 +0100 Thomas Anders thomas.and...@blue-cable.de wrote: The following patch

patch 1927751 broke build on Linux?

2009-03-24 Thread Thomas Anders
The following patch r17362 | jsafranek | 2009-01-19 16:01:42 +0100 (Mo, 19 Jan 2009) | 1 line NEWS: snmpd: PATCH: 1927751: from Mitsuru Chinen: implement icmpMsgStatsTable on Linux