[PATCH] Fix C++ guard in library/types.h

2009-08-26 Thread Jan Safranek
While testing net-snmp-rc1 I have noticed C++ packages (like tog-pegasus) do not like include/net-snmp/library/types.h. The file contains closing brace for the C++ guard, but not the opening one, so I'd suggest to add one in this patch. The C++ guard is not needed at all, there is no function

Re: [PATCH] Fix C++ guard in library/types.h

2009-08-26 Thread Dave Shield
2009/8/26 Jan Safranek jsafr...@redhat.com: While testing net-snmp-rc1 I have noticed C++ packages (like tog-pegasus) do not like include/net-snmp/library/types.h. The file contains closing brace for the C++ guard, but not the opening one, so I'd suggest to add one in this patch. My fault -

Re: [PATCH] Fix C++ guard in library/types.h

2009-08-26 Thread Thomas Anders
Jan Safranek wrote: While testing net-snmp-rc1 I have noticed C++ packages (like tog-pegasus) do not like include/net-snmp/library/types.h. The file contains closing brace for the C++ guard, but not the opening one, so I'd suggest to add one in this patch. +1 +Thomas

Re: [PATCH] Fix C++ guard in library/types.h

2009-08-26 Thread Wes Hardaker
On Wed, 26 Aug 2009 16:11:32 +0100, Dave Shield d.t.shi...@liverpool.ac.uk said: DS +1 (assuming this makes it in time for rc2) It will; I've been waiting for you to come back and comment on the other patch thread ;-) +1 from me too. -- Wes Hardaker Please mail all replies to

Re: [PATCH] Fix C++ guard in library/types.h

2009-08-26 Thread Wes Hardaker
On Wed, 26 Aug 2009 15:11:49 +0200, Jan Safranek jsafr...@redhat.com said: JS The file contains closing brace for the C++ guard, but not the opening one, JS so I'd suggest to add one in this patch. You have three, so go ahead and apply it (even though the 24 hour window hasn't closed). --

Re: [PATCH] Fix C++ guard in library/types.h

2009-08-26 Thread Wes Hardaker
On Wed, 26 Aug 2009 15:11:49 +0200, Jan Safranek jsafr...@redhat.com said: JS While testing net-snmp-rc1 I have noticed C++ packages (like tog-pegasus) JS do not like include/net-snmp/library/types.h. FYI, I applied this and the other default route one so I can publish .rc2 with them. -- Wes