Debugging neighbour.c: timers

2005-09-06 Thread Ben Greear
I added a separate flag to keep track of whether a neighbour struct is on the timer list or not. I also added some logic to dump the stack if the add-timer method was called while we are already on the timer list. This dump-stack method is being called quite often in my test that used to reprodu

Re: [PATCH] sock_sendfile(), generic_file_sendpage() or world without copy_from_user().

2005-09-06 Thread Evgeniy Polyakov
On Tue, Sep 06, 2005 at 08:57:57PM -0700, David S. Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Fri, 2 Sep 2005 18:00:55 +0400 > > > sock_sendfile() and generic_file_sendpage() were implemented > > and presented in the attached patch. > > Such methods all

[git patches] net driver update

2005-09-06 Thread Jeff Garzik
[just sent this to Andrew/Linus] Please pull from 'upstream' branch of rsync://rsync.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git to obtain the various updates described below: drivers/net/Kconfig |7 drivers/net/Makefile |2 d

[PATCH] ipv6: need to use pskb_trim_rcsum

2005-09-06 Thread Stephen Hemminger
Several places in IPV6 need to use pskb_trim_rcsum to handle the case of skb's received on devices that set CHECKSUM_HW Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: csum/net/ipv6/exthdrs.c === --- csum.orig/net/ipv6/ex

[PATCH] udp: trim forgets about CHECKSUM_HW

2005-09-06 Thread Stephen Hemminger
A UDP packet may contain extra data that needs to be trimmed off. But when doing so, UDP forgets to fixup the skb checksum if CHECKSUM_HW is being used. I think this explains the case of a NFS receive using skge driver causing 'udp hw checksum failures' when interacting with a crufty settop box.

[PATCH] optimize pskb_trim_rcsum

2005-09-06 Thread Stephen Hemminger
Since packets almost never contain extra garbage at the end, it is worthwhile to optimize for that case. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: csum/include/linux/skbuff.h === --- csum.orig/include/linux/skbuff.h

Re: [PATCH] WE-19 for kernel 2.6.13

2005-09-06 Thread Jeff Garzik
Jean Tourrilhes wrote: @@ -69,11 +69,12 @@ /* INCLUDES */ -/* To minimise problems in user space, I might remove those headers - * at some point. Jean II */ -#include /* for "caddr_t" et al*/ -#include

Re: ieee80211 patches

2005-09-06 Thread James Ketrenos
Jeff Garzik wrote: > It seems like some of this overlaps changes already in upstream. > What's the best way to start this process? I would prefer to receive > patches rather than 'git pull' at the present time. Understood. > Should I Lindent the files first? Probably cleanest that way. I've

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 08:49:35PM -0700, Matt Mackall wrote: > On Tue, Sep 06, 2005 at 08:37:36PM -0700, Eugene Surovegin wrote: > > On Tue, Sep 06, 2005 at 08:22:25PM -0700, Matt Mackall wrote: > > > Which would I rather have: > > > > > > "netconsole never catches my oopses, it's useless." > >

Re: [PATCH] sock_sendfile(), generic_file_sendpage() or world without copy_from_user().

2005-09-06 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Fri, 2 Sep 2005 18:00:55 +0400 > sock_sendfile() and generic_file_sendpage() were implemented > and presented in the attached patch. > Such methods allows to use sendfile() for any file descriptor <-> file > descriptor usage, especially usefull it i

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 08:37:36PM -0700, Eugene Surovegin wrote: > On Tue, Sep 06, 2005 at 08:22:25PM -0700, Matt Mackall wrote: > > Which would I rather have: > > > > "netconsole never catches my oopses, it's useless." > > > > "netconsole didn't work with my driver, so I tried another card and

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 08:35:32PM -0700, Matt Mackall wrote: > On Tue, Sep 06, 2005 at 08:19:34PM -0700, David S. Miller wrote: > > From: Matt Mackall <[EMAIL PROTECTED]> > > Date: Tue, 6 Sep 2005 20:08:10 -0700 > > > > > Think upon the kgdb-over-ethernet case, please. The kernel hits a > > > bre

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread David S. Miller
From: Matt Mackall <[EMAIL PROTECTED]> Date: Tue, 6 Sep 2005 20:35:32 -0700 > Kgdboe simply wants the asynchronous subsystem to get out of the > way. For most cards, it works just fine. It wants to impose a locking model restriction which never ever existed in the past. As I said, I myself even

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 08:22:25PM -0700, Matt Mackall wrote: > Which would I rather have: > > "netconsole never catches my oopses, it's useless." > > "netconsole didn't work with my driver, so I tried another card and it > works great." Well, not all world which uses Linux is PC with PCI slots

Re: neighbour.c and NUD_IN_TIMER (netdev unregister problem fixed!?!)

2005-09-06 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Tue, 06 Sep 2005 20:24:38 -0700 > How about this call site? The check is for new & NUD_IN_TIMER, > but there is no guarantee (that I can see) that neigh->nud_timer > has any of the NUD_IN_TIMER bits set. The one place earlier > that sets neigh->nud_time

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 08:19:34PM -0700, David S. Miller wrote: > From: Matt Mackall <[EMAIL PROTECTED]> > Date: Tue, 6 Sep 2005 20:08:10 -0700 > > > Think upon the kgdb-over-ethernet case, please. The kernel hits a > > breakpoint, the kgdb stub stops everything, sends a packet to the > > debuggi

Re: neighbour.c and NUD_IN_TIMER (netdev unregister problem fixed!?!)

2005-09-06 Thread Ben Greear
Ben Greear wrote: David S. Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> Date: Tue, 06 Sep 2005 16:03:36 -0700 At any rate, I'll be happy to see this fix go in unless someone finds a problem with it! As Yoshifuji showed, NUD_INCOMPLETE is a part of the bitmask NUD_IN_TIMER, as is NU

Re: neighbour.c and NUD_IN_TIMER (netdev unregister problem fixed!?!)

2005-09-06 Thread Ben Greear
David S. Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> Date: Tue, 06 Sep 2005 16:03:36 -0700 At any rate, I'll be happy to see this fix go in unless someone finds a problem with it! As Yoshifuji showed, NUD_INCOMPLETE is a part of the bitmask NUD_IN_TIMER, as is NUD_DELAY and a few oth

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 07:32:38PM -0700, Eugene Surovegin wrote: > On Tue, Sep 06, 2005 at 07:19:21PM -0700, Matt Mackall wrote: > > > or a') make this a per-driver feature (e.g. NETIF_F_NETPOLL_CHALENGED) > > > > > > In this case, even if driver cannot handle being called from IRQ > > > context

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread David S. Miller
From: Matt Mackall <[EMAIL PROTECTED]> Date: Tue, 6 Sep 2005 20:08:10 -0700 > Think upon the kgdb-over-ethernet case, please. The kernel hits a > breakpoint, the kgdb stub stops everything, sends a packet to the > debugging client, waits for a packet back.. This simply can't work if > we delay sen

Re: ieee80211 patches

2005-09-06 Thread Jeff Garzik
James Ketrenos wrote: Jeff Garzik wrote: Jiri Benc wrote: Our patches against latest ieee80211 branch can be found at http://kernel.org/pub/linux/kernel/people/jbenc/ Thanks for your patience. To answer Pavel's question from the other email: I was hoping that Intel would resend their pa

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 07:37:45PM -0700, David S. Miller wrote: > From: Matt Mackall <[EMAIL PROTECTED]> > Date: Tue, 6 Sep 2005 18:03:38 -0700 > > > Option c) is obviously a big project but maybe we can get from here to > > there. One possible step in that direction would be exposing a > > stand

Re: neighbour.c and NUD_IN_TIMER (netdev unregister problem fixed!?!)

2005-09-06 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Tue, 06 Sep 2005 16:03:36 -0700 > At any rate, I'll be happy to see this fix go in unless someone > finds a problem with it! As Yoshifuji showed, NUD_INCOMPLETE is a part of the bitmask NUD_IN_TIMER, as is NUD_DELAY and a few others. So it is actually a

Re: neighbour.c and NUD_IN_TIMER

2005-09-06 Thread David S. Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Wed, 07 Sep 2005 08:36:41 +0900 (JST) > In article <[EMAIL PROTECTED]> (at Tue, 06 Sep 2005 13:05:16 -0700), Ben > Greear <[EMAIL PROTECTED]> says: > > > neigh->nud_state = NUD_INCOMPLETE; > > *** neigh_hol

Re: [patch 1/1] ipw2100: remove by-hand function entry/exit debugging

2005-09-06 Thread Jeff Garzik
David S. Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 06 Sep 2005 21:51:21 -0400 NAK. Rationale: maintainer's choice. Pavel doesn't get to choose the debugger of choice for the driver maintainer. If it makes the driver unreadable and thus harder to maintain, I think such

Re: proto_unregister sleeps while atomic

2005-09-06 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 07 Sep 2005 01:42:48 +0200 > The only other user of proto_list besides proto_register, which > doesn't care, are the seqfs functions. They use the slab pointer, > but in a harmless way: > > proto->slab == NULL ? "no" : "yes"

Re: [PATCH 2.6.13] airo : WE-19 support

2005-09-06 Thread Jeff Garzik
applied WE-19, and all the driver patches you sent (including this one). - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: more ipsec crashes in 2.6.13

2005-09-06 Thread David S. Miller
From: Olaf Hering <[EMAIL PROTECTED]> Date: Wed, 7 Sep 2005 01:56:11 +0200 > This patch from patch-2.6.13-rc2-git3 causes the crash. > > tree abe25ec0577bd95128adb3f38609a09f0a3e2469 > parent 8279dd748f9704b811e528b31304e2fab026abc5 > author Herbert Xu <[EMAIL PROTECTED]> Thu, 07 Jul 2005 03:51:

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread David S. Miller
From: Matt Mackall <[EMAIL PROTECTED]> Date: Tue, 6 Sep 2005 18:03:38 -0700 > Option c) is obviously a big project but maybe we can get from here to > there. One possible step in that direction would be exposing a > standard driver lock that netpoll can see and switching drivers that > have troubl

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 07:19:21PM -0700, Matt Mackall wrote: > > or a') make this a per-driver feature (e.g. NETIF_F_NETPOLL_CHALENGED) > > > > In this case, even if driver cannot handle being called from IRQ > > context, netconsole still can be used, although in a little more > > limited fashi

Re: AES 256 support not announced by IPSec framework?

2005-09-06 Thread Herbert Xu
Ingo Oeser <[EMAIL PROTECTED]> wrote: > > I'm just asking myself, why is AES-256 not announced by the IPsec framework? It should work. Which user-space IPsec daemon are you using? -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://go

Re: more ipsec crashes in 2.6.13

2005-09-06 Thread Herbert Xu
Olaf Hering <[EMAIL PROTECTED]> wrote: > > The patch 'p' which was posted by Herbert today doesnt fix it. Can you please double check? That bug would cause exactly what you're seeing here since it'll clobber the skb's shared section which contains the nr_frags. Thanks, -- Visit Openswan at http

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 06:37:40PM -0700, Eugene Surovegin wrote: > On Tue, Sep 06, 2005 at 06:03:38PM -0700, Matt Mackall wrote: > > On Tue, Sep 06, 2005 at 04:01:24PM -0700, David S. Miller wrote: > > > So you cannot call into these drivers with HW interrupts disabled or > > > even worse from HW

Re: Patch for link detection for R8169

2005-09-06 Thread Jeff Garzik
Francois Romieu wrote: Miroslaw Mieszczak <[EMAIL PROTECTED]> : There is a patch to driver of RLT8169 network card. This match make possible detection of the link status even if network interface is down. This is usefull for laptop users. (side note: there is maintainer entry for the r8169

Re: [patch 1/1] ipw2100: remove by-hand function entry/exit debugging

2005-09-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Pavel Machek <[EMAIL PROTECTED]> This removes debug prints from entry/exit of functions. Such level of debugging should probably be done by gdb or similar. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: "James P. Ketrenos"

[PATCH Linus Git] README.ipw2200 does not contain firmware information.

2005-09-06 Thread Alejandro Bonilla Beeche
Hi, The kconfig from net/wireless says to look at the README.ipw2200 for further installation of the firmware file. We have that information unde INSTALL not under README.ipw2200, still I just added a part that talks about installing the firmware file. This because README.ipw2200 is alread

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 06:03:38PM -0700, Matt Mackall wrote: > On Tue, Sep 06, 2005 at 04:01:24PM -0700, David S. Miller wrote: > > So you cannot call into these drivers with HW interrupts disabled or > > even worse from HW interrupt context. These drivers use locking > > strategies which are per

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 04:01:24PM -0700, David S. Miller wrote: > So you cannot call into these drivers with HW interrupts disabled or > even worse from HW interrupt context. These drivers use locking > strategies which are perfectly legal and work until you add netpoll. And again, I agree. Wha

RE: Fw: [Bugme-new] [Bug 5194] New: IPSec related OOps in 2.6.13

2005-09-06 Thread Matt LaPlante
Patch worked like a charm here, no more kernel panics! Excellent work, many thanks for the quick fix...more people should have such a work ethic. Cheers, Matt > -Original Message- > From: [EMAIL PROTECTED] [mailto:linux-kernel- > [EMAIL PROTECTED] On Behalf Of Herbert Xu > Sent: Tuesday,

Re: more ipsec crashes in 2.6.13

2005-09-06 Thread Olaf Hering
On Tue, Sep 06, Olaf Hering wrote: > > This happens after: > > ssh [EMAIL PROTECTED] "rcipsec restart" > ssh [EMAIL PROTECTED] "rcipsec restart" > > ssh [EMAIL PROTECTED] "ping -i 0.01 -s 4096 g167.suse.de" > > The patch 'p' which was posted by Herbert today doesnt fix it. > > put_page gets

Re: proto_unregister sleeps while atomic

2005-09-06 Thread Patrick McHardy
David S. Miller wrote: From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 07 Sep 2005 01:02:01 +0200 You're right, good catch. This patch fixes it by moving the lock down to the list-operation which it is supposed to protect. I think we need to unlink from the list first if you're going t

Re: neighbour.c and NUD_IN_TIMER

2005-09-06 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 06 Sep 2005 13:05:16 -0700), Ben Greear <[EMAIL PROTECTED]> says: > neigh->nud_state = NUD_INCOMPLETE; > *** neigh_hold(neigh, NDRK_NEIGH_TIMER); > neigh->timer.expires = now + 1; >

Re: [patch 2.6.13 2/2] 3c59x: add option for using memory-mapped PCI I/O resources

2005-09-06 Thread Andrew Morton
"John W. Linville" <[EMAIL PROTECTED]> wrote: > > On Tue, Sep 06, 2005 at 03:15:46PM -0700, Andrew Morton wrote: > > "John W. Linville" <[EMAIL PROTECTED]> wrote: > > > > > > I fully intend to have have a flag in the private data set based on > > > the PCI ID when I accumulate some data on which d

Re: proto_unregister sleeps while atomic

2005-09-06 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 07 Sep 2005 01:02:01 +0200 > You're right, good catch. This patch fixes it by moving the lock > down to the list-operation which it is supposed to protect. I think we need to unlink from the list first if you're going to do it this way. Otherw

Re: neighbour.c and NUD_IN_TIMER (netdev unregister problem fixed!?!)

2005-09-06 Thread Ben Greear
David S. Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> Date: Tue, 06 Sep 2005 14:37:26 -0700 I'm also attaching a patch that just fixes the problem, with no debugging info. (Compiled but not tested by itself.) Signed-off-by Ben Greear <[EMAIL PROTECTED]> Thanks for tracking this down

Re: proto_unregister sleeps while atomic

2005-09-06 Thread Patrick McHardy
Daniele Orlandi wrote: I'm looking at proto_unregister() in linux-2.6.13: Il calls kmem_cache_destroy() while holding proto_list_lock: void proto_unregister(struct proto *prot) { write_lock(&proto_list_lock); if (prot->slab != NULL) { kmem_cache_destroy(prot->sl

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread David S. Miller
From: Matt Mackall <[EMAIL PROTECTED]> Date: Tue, 6 Sep 2005 15:50:25 -0700 > > So we try to spit out netconsole messages in hw IRQ context and stuff > > like that, as you stated. The tg3 driver is susceptible to the > > problem you mention, as is bnx2, because they use purely software > > interr

Re: [patch 2.6.13 2/2] 3c59x: add option for using memory-mapped PCI I/O resources

2005-09-06 Thread John W. Linville
On Tue, Sep 06, 2005 at 03:15:46PM -0700, Andrew Morton wrote: > "John W. Linville" <[EMAIL PROTECTED]> wrote: > > > > I fully intend to have have a flag in the private data set based on > > the PCI ID when I accumulate some data on which devices support this > > and which don't. So far I've onl

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 03:42:07PM -0700, David S. Miller wrote: > Mentioning the latency of the serial console, in support of > netpoll's interrupt disabling, is quite a straw man. No, it's exactly to the point: latency is a secondary concern when we're printing an oops or other diagnostic. Other

Re: [PATCH] ip: reassembly trim not clearing CHECKSUM_HW

2005-09-06 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 6 Sep 2005 13:26:15 -0700 > This was found by inspection while looking for checksum problems > with the skge driver that sets CHECKSUM_HW. It did not fix the > problem, but it looks like it is needed. > > If IP reassembly is trimming an overl

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 03:36:27PM -0700, David S. Miller wrote: > From: Eugene Surovegin <[EMAIL PROTECTED]> > Date: Tue, 6 Sep 2005 15:04:17 -0700 > > > David, correct me if I'm wrong, but I think there is a major problem > > with current netconsole/netpoll approach. > > You're preaching to the

Re: [PATCH] skb_get/set_timestamp use const

2005-09-06 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 6 Sep 2005 14:01:17 -0700 > The new timestamp get/set routines should have const attribute > on parameters (helps to indicate direction). > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks Stephen. - To unsubscribe fro

Re: neighbour.c and NUD_IN_TIMER (netdev unregister problem fixed!?!)

2005-09-06 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Tue, 06 Sep 2005 14:37:26 -0700 > I'm also attaching a patch that just fixes the problem, > with no debugging info. (Compiled but not tested by > itself.) > > Signed-off-by Ben Greear <[EMAIL PROTECTED]> Thanks for tracking this down, I'll review it mo

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread David S. Miller
From: Matt Mackall <[EMAIL PROTECTED]> Date: Tue, 6 Sep 2005 15:32:50 -0700 > Unfortunately, netpoll fundamentally requires everything to work with > interrupts off. This can't be changed. It could be called from the > context of an oops, or worse, by the kgdb stub at a breakpoint. If > drivers re

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 03:36:27PM -0700, David S. Miller wrote: > From: Eugene Surovegin <[EMAIL PROTECTED]> > Date: Tue, 6 Sep 2005 15:04:17 -0700 > > > David, correct me if I'm wrong, but I think there is a major problem > > with current netconsole/netpoll approach. > > You're preaching to the

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread David S. Miller
From: Eugene Surovegin <[EMAIL PROTECTED]> Date: Tue, 6 Sep 2005 15:04:17 -0700 > David, correct me if I'm wrong, but I think there is a major problem > with current netconsole/netpoll approach. You're preaching to the choir. I think the whole netpoll implementation is fundamentally flawed, and

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Matt Mackall
On Tue, Sep 06, 2005 at 02:47:14PM -0700, David S. Miller wrote: > From: Eugene Surovegin <[EMAIL PROTECTED]> > Date: Tue, 6 Sep 2005 00:40:01 -0700 > > > According to Documentation/networking/netdevices.txt > > dev->hard_start_xmit must be called with interrupts *enabled*. > > > > Unfortunately

Re: [patch 2.6.13 2/2] 3c59x: add option for using memory-mapped PCI I/O resources

2005-09-06 Thread Andrew Morton
"John W. Linville" <[EMAIL PROTECTED]> wrote: > > I fully intend to have have a flag in the private data set based on > the PCI ID when I accumulate some data on which devices support this > and which don't. So far I've only got a short list... Do you think > such a flag should be based on whi

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 02:47:14PM -0700, David S. Miller wrote: > From: Eugene Surovegin <[EMAIL PROTECTED]> > Date: Tue, 6 Sep 2005 00:40:01 -0700 > > > According to Documentation/networking/netdevices.txt > > dev->hard_start_xmit must be called with interrupts *enabled*. > > > > Unfortunately

Re: AES 256 support not announced by IPSec framework?

2005-09-06 Thread David S. Miller
From: Ingo Oeser <[EMAIL PROTECTED]> Date: Tue, 6 Sep 2005 16:57:41 +0200 > I'm just asking myself, why is AES-256 not announced by the IPsec framework? > The kernel crypto-API seems to support a keysize of 256. > Or is the blocksize (of 256 bits) meant by AES-256? > > I'm a bit lost on this one.

Re: [PATCH] make sure l_linger is unsigned to avoid negative timeouts

2005-09-06 Thread David S. Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Tue, 06 Sep 2005 16:11:19 +0200 > I dont know if it's safe to change l_linger to 'unsigned int' in the include > file (It might be defined as int in ABI specs) > > So I believe this patch is needed : > > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread David S. Miller
From: Eugene Surovegin <[EMAIL PROTECTED]> Date: Tue, 6 Sep 2005 00:40:01 -0700 > According to Documentation/networking/netdevices.txt > dev->hard_start_xmit must be called with interrupts *enabled*. > > Unfortunately, current netconsole code always calls netpoll with local > interrupts disable

Re: [PATCH] make use of ->private_data in sockfd_lookup

2005-09-06 Thread David S. Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Tue, 06 Sep 2005 01:51:16 +0200 > Avoid touching file->f_dentry on sockets, since file->private_data directly > gives us the socket pointer. > > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> Applied, thanks Eric. - To unsubscribe from this list: se

Re: neighbour.c and NUD_IN_TIMER (netdev unregister problem fixed!?!)

2005-09-06 Thread Ben Greear
Ben Greear wrote: If my debugging code is correct, I've tracked down the leaked neighbour structure as being referenced here: if (!(neigh->nud_state & (NUD_STALE | NUD_INCOMPLETE))) { if (neigh->parms->mcast_probes + neigh->parms->app_probes) { atomic_set(&neigh->probes,

Re: [PATCH] skb_get/set_timestamp use const

2005-09-06 Thread Arnaldo Carvalho de Melo
On 9/6/05, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > The new timestamp get/set routines should have const attribute > on parameters (helps to indicate direction). > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> I'm using t

Re: [patch 2.6.13 2/2] 3c59x: add option for using memory-mapped PCI I/O resources

2005-09-06 Thread Andrew Morton
Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > On Tue, Sep 06, 2005 at 04:44:00PM -0400, John W. Linville wrote: > > Add module option to enable 3c59x driver to use memory-mapped PCI I/O > > resources. This may improve performance for those devices so equipped. > > > > Add "use_mmio=1" to the 3

Re: more ipsec crashes in 2.6.13

2005-09-06 Thread Olaf Hering
On Tue, Sep 06, Olaf Hering wrote: > > This happens after: > > ssh [EMAIL PROTECTED] "rcipsec restart" > ssh [EMAIL PROTECTED] "rcipsec restart" > > ssh [EMAIL PROTECTED] "ping -i 0.01 -s 4096 g167.suse.de" > > The patch 'p' which was posted by Herbert today doesnt fix it. > > put_page gets

[PATCH] skb_get/set_timestamp use const

2005-09-06 Thread Stephen Hemminger
The new timestamp get/set routines should have const attribute on parameters (helps to indicate direction). Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: skge-2.6.13/include/linux/skbuff.h === --- skge-2.6.13.orig/incl

Re: [patch 2.6.13 2/2] 3c59x: add option for using memory-mapped PCI I/O resources

2005-09-06 Thread Christoph Hellwig
On Tue, Sep 06, 2005 at 04:44:00PM -0400, John W. Linville wrote: > Add module option to enable 3c59x driver to use memory-mapped PCI I/O > resources. This may improve performance for those devices so equipped. > > Add "use_mmio=1" to the 3c59x module options in order to enable this > functionali

[patch 2.6.13 2/2] 3c59x: add option for using memory-mapped PCI I/O resources

2005-09-06 Thread John W. Linville
Add module option to enable 3c59x driver to use memory-mapped PCI I/O resources. This may improve performance for those devices so equipped. Add "use_mmio=1" to the 3c59x module options in order to enable this functionality. Signed-off-by: John W. Linville <[EMAIL PROTECTED]> --- Ideally this op

[patch 2.6.13 1/2] 3c59x: convert to use of pci_iomap API

2005-09-06 Thread John W. Linville
Convert 3c59x driver to use pci_iomap API. This makes it easier to enable the use of memory-mapped PCI I/O resources. Signed-off-by: John W. Linville <[EMAIL PROTECTED]> --- drivers/net/3c59x.c | 507 ++-- 1 files changed, 260 insertions(+), 247

[PATCH] ip: reassembly trim not clearing CHECKSUM_HW

2005-09-06 Thread Stephen Hemminger
This was found by inspection while looking for checksum problems with the skge driver that sets CHECKSUM_HW. It did not fix the problem, but it looks like it is needed. If IP reassembly is trimming an overlapping fragment, it should reset (or adjust) the hardware checksum flag on the skb. Signed-

neighbour.c and NUD_IN_TIMER

2005-09-06 Thread Ben Greear
If my debugging code is correct, I've tracked down the leaked neighbour structure as being referenced here: if (!(neigh->nud_state & (NUD_STALE | NUD_INCOMPLETE))) { if (neigh->parms->mcast_probes + neigh->parms->app_probes) { atomic_set(&neigh->pro

Re: Question on neighbour reference count in neigh_create

2005-09-06 Thread Ben Greear
David S. Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> Date: Mon, 05 Sep 2005 23:50:45 -0700 In net/core/neighbour.c, method neigh_alloc, the ref-count is set to one near the bottom of the method. I notice in neigh_create, for instance, the ref-count is increased again as the neighbour i

Re: Question on neighbour reference count in neigh_create

2005-09-06 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Mon, 05 Sep 2005 23:50:45 -0700 > In net/core/neighbour.c, method neigh_alloc, the > ref-count is set to one near the bottom of the method. > > I notice in neigh_create, for instance, the ref-count is > increased again as the neighbour is put into the ta

RE: [PATCH] wrong firmware location in IPW2100 Kconfig entry (Was: IPW2100 Kconfig)

2005-09-06 Thread Alejandro Bonilla
> > Who should I send the "patch" to? Or can someone simply change that? Jesper, Thanks. I also had a question. To whom is this patch sent to? Netdev or LK? How does one determine? .Alejandro > > Firmware should go into /lib/firmware, not /etc/firmware. > > Found by Alejandro Bonilla.

[PATCH] wrong firmware location in IPW2100 Kconfig entry (Was: IPW2100 Kconfig)

2005-09-06 Thread Jesper Juhl
On Tuesday 06 September 2005 20:32, Alejandro Bonilla wrote: > Hi, > > I checked the IPW2100 in the current git from linux-2.6 and the > menuconfig > help (Kconfig) says you need to put the firmware in /etc/firmware, it should > be /lib/firmware. > > Who should I send the "patch" to? Or ca

IPW2100 Kconfig

2005-09-06 Thread Alejandro Bonilla
Hi, I checked the IPW2100 in the current git from linux-2.6 and the menuconfig help (Kconfig) says you need to put the firmware in /etc/firmware, it should be /lib/firmware. Who should I send the "patch" to? Or can someone simply change that? Thanks, .Alejandro - To unsubscribe from t

[AX.25] Make ax2asc thread-proof

2005-09-06 Thread Ralf Baechle
Ax2asc was still using a static buffer for all invocations which isn't exactly SMP-safe. Change ax2asc to take an additional result buffer as the argument. Change all callers to provide such a buffer. Signed-off-by: Ralf Baechle DL5RB <[EMAIL PROTECTED]> include/net/ax25.h |2 +- net/a

Re: Possible neighbour reference leak in net/ipv4/xfrm4_policy.c

2005-09-06 Thread Ben Greear
Patrick McHardy wrote: Ben Greear wrote: Patrick McHardy wrote: dst_prev is newly allocated in the loop a couple of lines above. Ok, that makes sense now. I also did not find a single neigh_put in the entire xfrm4_policy.c file. Should include/net/xfrm.h's method: xfrm_dst_destroy rele

Re: Possible neighbour reference leak in net/ipv4/xfrm4_policy.c

2005-09-06 Thread Patrick McHardy
Ben Greear wrote: Patrick McHardy wrote: dst_prev is newly allocated in the loop a couple of lines above. Ok, that makes sense now. I also did not find a single neigh_put in the entire xfrm4_policy.c file. Should include/net/xfrm.h's method: xfrm_dst_destroy release the neighbour? Not n

Re: Possible neighbour reference leak in net/ipv4/xfrm4_policy.c

2005-09-06 Thread Ben Greear
Patrick McHardy wrote: Ben Greear wrote: /* Copy neighbout for reachability confirmation */ dst_prev->neighbour= neigh_clone(rt->u.dst.neighbour) This code in the method xfrm4_bundle_create appears to over-write the dst_prev->neighbour member without ever checking to see if

Re: Modifying Cryptography Code

2005-09-06 Thread Aidas Kasparas
Alaa Dalghan wrote: > imposes too much processing overhead on the linux VPN gateway. The > required behavior is that the VPN gateway just RELAYS encrypted data > (ESP envelopes) without decrypting them. This is impossible in the > current ipsec implementation since"the end of a tunnel HAS ALWAYS

Re: Modifying Cryptography Code

2005-09-06 Thread Martijn van Oosterhout
On Tue, Sep 06, 2005 at 01:56:56PM +, Alaa Dalghan wrote: > Hello everyone, > I need to modify some CRYPTOGRAPHY code in Linux Kernel to get a specific > VPN behavior, but I don't know where to start. > Each packet sent from a given client to the other get processed 4 times > (encryption a

Re: [PATCH] sunrpc: add endian annotations

2005-09-06 Thread viro
On Tue, Sep 06, 2005 at 12:21:05PM +0400, Alexey Dobriyan wrote: > * usual s/u32/__be32/. > * add svc_getnl(): > Take network-endian value from buffer, convert to host-endian > one and return it. > * add svc_putnl(): > Take host-endian value, convert to network-endian one and put

AES 256 support not announced by IPSec framework?

2005-09-06 Thread Ingo Oeser
Hi there, I'm just asking myself, why is AES-256 not announced by the IPsec framework? The kernel crypto-API seems to support a keysize of 256. Or is the blocksize (of 256 bits) meant by AES-256? I'm a bit lost on this one. Regards Ingo Oeser - To unsubscribe from this list: send the line "un

Re: more ipsec crashes in 2.6.13

2005-09-06 Thread Olaf Hering
On Tue, Sep 06, Olaf Hering wrote: > put_page gets NULL. >dar: bdf20d2efc7304a2 No, it is garbage. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] make sure l_linger is unsigned to avoid negative timeouts

2005-09-06 Thread Eric Dumazet
One of my x86_64 (linux 2.6.13) server log is filled with : schedule_timeout: wrong timeout value ff06 from 802e63ca schedule_timeout: wrong timeout value ff06 from 802e63ca schedule_timeout: wrong timeout value ff06 from 802e63ca schedu

more ipsec crashes in 2.6.13

2005-09-06 Thread Olaf Hering
This happens after: ssh [EMAIL PROTECTED] "rcipsec restart" ssh [EMAIL PROTECTED] "rcipsec restart" ssh [EMAIL PROTECTED] "ping -i 0.01 -s 4096 g167.suse.de" The patch 'p' which was posted by Herbert today doesnt fix it. put_page gets NULL. Welcome to SUSE LINUX 10.0 (PPC) - Kernel 2.6.13-pp

Modifying Cryptography Code

2005-09-06 Thread Alaa Dalghan
Hello everyone, I need to modify some CRYPTOGRAPHY code in Linux Kernel to get a specific VPN behavior, but I don't know where to start. The situation is the following: I have a VPN gateway (Linux kernel 2.6.10 with Openswan 2.3.1 installed). I have only installed the user land tools from ope

Re: Fw: [Bugme-new] [Bug 5194] New: IPSec related OOps in 2.6.13

2005-09-06 Thread Krzysztof Oledzki
On Tue, 6 Sep 2005, Herbert Xu wrote: On Tue, Sep 06, 2005 at 04:08:56AM -0700, Andrew Morton wrote: Problem Description: Oops: [#1] PREEMPT Modules linked in: CPU:0 EIP:0060:[]Not tainted VLI EFLAGS: 00010216 (2.6.13) EIP is at sha1_update+0x7c/0x160 Thanks for the rep

Re: ieee80211 patches

2005-09-06 Thread Jiri Benc
On Thu, 01 Sep 2005 19:16:05 +0100, Pedro Ramalhais wrote: > > Of > > course you may sometimes want to force reassociation manually - and > > there should be some call available for this. (Maybe setting BSSID while > > the card is running should force reassociation?) > > That's the kind of hackis

Re: RTL8169 freezes under load

2005-09-06 Thread Kyle Brantley
Francois Romieu wrote: >Kyle Brantley <[EMAIL PROTECTED]> : >[...] > > >>I recently bought three rtl8169 gigabit cards, along with a gigabit >>switch. Trouble is, the computers keep freezing up once the NIC comes >>under and "decent" amount of load. Let me lay this out for you a bit: >> >>Comput

Re: [PATCH] cleanup ieee80211_crypto.c

2005-09-06 Thread Christoph Hellwig
On Mon, Sep 05, 2005 at 12:48:45PM -0400, Jeff Garzik wrote: > >>I understand removing the NULL pointers, but .name is actually a string > >>"NULL".. Leaving it to be NULL is not a very good idea. This "NULL" > >>algorithm was designed for cases where there is default algorithm for > >>encryption a

Re: ieee80211 patches

2005-09-06 Thread Jiri Benc
On Mon, 05 Sep 2005 16:24:41 +0200, Henrik Brix Andersen wrote: > Only a very early version of the ieee80211 header was included in > 2.6.13. This header is not compatible with the ones needed to compile > the current external drivers which depend on ieee80211. This makes it > hard to properly supp

Re: Fw: [Bugme-new] [Bug 5194] New: IPSec related OOps in 2.6.13

2005-09-06 Thread Herbert Xu
On Tue, Sep 06, 2005 at 04:08:56AM -0700, Andrew Morton wrote: > > Problem Description: > > Oops: [#1] > PREEMPT > Modules linked in: > CPU:0 > EIP:0060:[]Not tainted VLI > EFLAGS: 00010216 (2.6.13) > EIP is at sha1_update+0x7c/0x160 Thanks for the report. Matt LaPlante had e

Re: [PATCH 8/8] orinoco: New driver - spectrum_cs.

2005-09-06 Thread Christoph Hellwig
> +#ifdef __IN_PCMCIA_PACKAGE__ > +#include > +#endif /* __IN_PCMCIA_PACKAGE__ */ this doesn't make sense for a 2.6 driver. > +/* > + * If SPECTRUM_FW_INCLUDED is defined, the firmware is hardcoded into > + * the driver. Use get_symbol_fw script to generate spectrum_fw.h and > + * copy it to t

Fw: [Bugme-new] [Bug 5194] New: IPSec related OOps in 2.6.13

2005-09-06 Thread Andrew Morton
Begin forwarded message: Date: Tue, 6 Sep 2005 03:49:57 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 5194] New: IPSec related OOps in 2.6.13 http://bugzilla.kernel.org/show_bug.cgi?id=5194 Summary: IPSec related OOps in 2.6.13 Kernel Version: 2.

Re: Possible neighbour reference leak in net/ipv4/xfrm4_policy.c

2005-09-06 Thread Patrick McHardy
Ben Greear wrote: /* Copy neighbout for reachability confirmation */ dst_prev->neighbour= neigh_clone(rt->u.dst.neighbour) This code in the method xfrm4_bundle_create appears to over-write the dst_prev->neighbour member without ever checking to see if it needed to release the

[PATCH] sunrpc: add endian annotations

2005-09-06 Thread Alexey Dobriyan
* usual s/u32/__be32/. * add svc_getnl(): Take network-endian value from buffer, convert to host-endian one and return it. * add svc_putnl(): Take host-endian value, convert to network-endian one and put it into a buffer. * convert to svc_getnl(), svc_putnl(). Signe

  1   2   >