Re: [PATCH 0/8] Intel I/O Acceleration Technology (I/OAT)

2006-03-05 Thread Andrew Morton
Chris Leech [EMAIL PROTECTED] wrote: Patch #2 didn't make it. Too big for the list? Could be, it's the largest of the series. I've attached the gziped patch. I can try and split this up for the future. .. [I/OAT] Driver for the Intel(R) I/OAT DMA engine Adds a new ioatdma driver

Re: [PATCH 8/8] [I/OAT] TCP recv offload to I/OAT

2006-03-05 Thread Andrew Morton
Chris Leech [EMAIL PROTECTED] wrote: +#ifdef CONFIG_NET_DMA +tp-ucopy.dma_chan = NULL; +if ((len sysctl_tcp_dma_copybreak) !(flags MSG_PEEK) !sysctl_tcp_low_latency __get_cpu_var(softnet_data.net_dma)) +dma_lock_iovec_pages(msg-msg_iov, len,

Discourage duplicate symbols in the kernel? [Was: Intel I/O Acc...]

2006-03-05 Thread Sam Ravnborg
On Sun, Mar 05, 2006 at 12:09:33AM -0800, Andrew Morton wrote: + +static inline u8 read_reg8(struct cb_device *device, unsigned int offset) +{ + return readb(device-reg_base + offset); +} These are fairly generic-sounding names. In fact the as-yet-unmerged tiacx wireless driver is

Re: [PATCH 8/8] [I/OAT] TCP recv offload to I/OAT

2006-03-05 Thread David S. Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Sun, 5 Mar 2006 00:45:34 -0800 The __get_cpu_var() here will run smp_processor_id() from preemptible context. You'll get a big warning if the correct debug options are set. The reason for this is that preemption could cause this code to hop

Re: [PATCH 2/3] forcedeth: Add support for 64bit rings

2006-03-05 Thread Manfred Spraul
Hi Ayaz, sorry for the slow reply: Ayaz Abdulla wrote: This forcedeth patch adds high dma support for tx/rx rings. @@ -2529,7 +2548,14 @@ printk(KERN_INFO forcedeth: 64-bit DMA failed, using 32-bit addressing for device %s.\n,

Re: [PATCH 8/8] [I/OAT] TCP recv offload to I/OAT

2006-03-05 Thread Pavel Machek
Hi! --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -262,6 +262,9 @@ #include net/tcp.h #include net/xfrm.h #include net/ip.h +#ifdef CONFIG_NET_DMA +#include net/netdma.h +#endif Remove the ifdefs, move them inside .h if needed. diff --git a/net/ipv4/tcp_input.c

Re: [PATCH] [IPV6]: fix ipv6_saddr_score struct element

2006-03-05 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Tue, 28 Feb 2006 15:03:31 -0500), Brian Haley [EMAIL PROTECTED] says: The scope element in the ipv6_saddr_score struct used in ipv6_dev_get_saddr() is an unsigned integer, but __ipv6_addr_src_scope() returns a signed integer (and can return -1).

slab corruption in tg3_alloc_rx_skb in 2.6.16-rc5-git2

2006-03-05 Thread Olaf Hering
No idea if tg3 is to blame. Its a JS20, root on ext3 on raid0 on qla23xx fibrechannel 16 hours uptime, it did some package building, no special workload, some ftp download, some nfs upload. Slab corruption: start=ca7c4e60, len=2048 Redzone: 0x5a2cf071/0x5a2cf071. Last user:

de2104x: interrupts before interrupt handler is registered

2006-03-05 Thread Martin Michlmayr
We have three independent reports about problems with de2104x involving interrupts. Alan Stern suggested that it sure looks as though the ethernet interface is generating an interrupt request before the de2104x driver has registered its interrupt handler. The three reports are: - de2104x does

Please pull bcm43xx softmac-upstream and dscape-upstream branches

2006-03-05 Thread Michael Buesch
Hi John, It took a little longer than promised, but a broken harddisk in my server delayed my plans. ;) Please pull branches softmac-upstream and dscape-upstream from my repository at: git://bu3sch.de/wireless-2.6.git This introduces the following changesets: Michael Buesch:

Fw: [Bugme-new] [Bug 6167] New: tg3 oops from tg3_rx

2006-03-05 Thread Andrew Morton
Begin forwarded message: Date: Sun, 5 Mar 2006 08:11:23 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6167] New: tg3 oops from tg3_rx http://bugzilla.kernel.org/show_bug.cgi?id=6167 Summary: tg3 oops from tg3_rx Kernel Version: 2.6.15

Re: bcm43xx dma and txb's

2006-03-05 Thread Michael Buesch
On Monday 06 March 2006 00:09, you wrote: Hi, Michael: It seems to me that the today's wireless-2.6 git contains bcm43xx which does not free txb's correctly, if I understand it right. Consider a situation where a txb with two skb's is sent down. The dma_tx_fragment will save the pointer

RE: [PATCH 2/3] forcedeth: Add support for 64bit rings

2006-03-05 Thread Ayaz Abdulla
I had treated these two dma masks as dependent. Yes, they should be independent. Thanks, Ayaz -Original Message- From: Manfred Spraul [mailto:[EMAIL PROTECTED] Sent: Sunday, March 05, 2006 3:45 AM To: Ayaz Abdulla Cc: netdev@vger.kernel.org; Jeff Garzik Subject: Re: [PATCH 2/3]

Re: [PATCH] net: drop duplicate assignment in request_sock

2006-03-05 Thread Arnaldo Carvalho de Melo
Looks fine but I haven't fully verified if not setting tail to NULL is really OK, now I'm going to bed, tomorrow I'll take a look, but for reference this is the cset where this function was introduced, where we can see that the original code was indeed setting tail to NULL:

remove useless test in ip6_append_data

2006-03-05 Thread Dave Jones
We've already dereferenced 'np' a dozen times at this point, so it's safe to say it's not null. Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6.15.noarch/net/ipv6/ip6_output.c~ 2006-03-06 02:22:05.0 -0500 +++ linux-2.6.15.noarch/net/ipv6/ip6_output.c 2006-03-06

Re: remove useless test in ip6_append_data

2006-03-05 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Mon, 6 Mar 2006 02:34:16 -0500), Dave Jones [EMAIL PROTECTED] says: We've already dereferenced 'np' a dozen times at this point, so it's safe to say it's not null. Signed-off-by: Dave Jones [EMAIL PROTECTED] Agreed. --yoshfuji - To unsubscribe from this

Re: SLAB corruption with sungem

2006-03-05 Thread Olaf Hering
On Mon, Mar 06, Benjamin Herrenschmidt wrote: On Fri, 2006-03-03 at 09:06 +0100, Olaf Hering wrote: the RX errors I'm seeing every once in a while are still there in 2.6.16rc5. Maybe they happen if there is some IO load on the IDE disks, just upgraded openoffice.rpm Which machine is