[PATCH][NET_SCHED] sch_prio: class statistics printing enabled

2007-01-30 Thread Jarek Poplawski
Hello, This patch adds a dump_stats callback to enable printing of basic statistics of prio classes. Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]> --- diff -Nurp linux-2.6.20-rc6-/net/sched/sch_prio.c linux-2.6.20-rc6/net/sched/sch_prio.c --- linux-2.6.20-rc6-/net/sched/sch_prio.c 20

[PATCH] [v3] PA Semi PWRficient Ethernet driver

2007-01-30 Thread Olof Johansson
Driver for the PA Semi PWRficient on-chip Ethernet (1/10G) Basic enablement, will be complemented with performance enhancements over time. PHY support will be added as well. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- Further improvements based on comments: * Added remove function *

Re: [Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

2007-01-30 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 21 Feb 2007 23:51:45 -0500), weidong <[EMAIL PROTECTED]> says: > Thanks for your patch. I think maybe we checking oif first is better, > and WARN_ON in function rt6_score_route(). Please remove WARN_ON. Otherwise, I'm fine with it. --yoshfuji - To

Re: [PATCH] PA Semi PWRficient Ethernet driver

2007-01-30 Thread Olof Johansson
On Tue, Jan 30, 2007 at 10:45:18PM +0100, Francois Romieu wrote: > Olof Johansson <[EMAIL PROTECTED]> : > > On Mon, Jan 29, 2007 at 11:35:06PM +0100, Francois Romieu wrote: > [...] > > > - The driver does not contain a single SMP locking instruction but > > > http://www.pasemi.com claims the plat

Re: [Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

2007-01-30 Thread weidong
Hello, Mr yoshfuji Thanks for your patch. I think maybe we checking oif first is better, and WARN_ON in function rt6_score_route(). The following is my patch Signed-off-by: Wei Dong <[EMAIL PROTECTED]> diff -ruN old/net/ipv6/route.c new/net/ipv6/route.c --- old/net/ipv6/route.c200

RE: [PATCH 2.6.20 1/5] s2io: Making LRO and UFO as module loadable parameter.

2007-01-30 Thread Sivakumar Subramani
Hi Jeff, Where you able to apply the patches. Please let me the known if you have any issues. Thanks, ~Siva -Original Message- From: Sivakumar Subramani Sent: Monday, January 29, 2007 11:36 AM To: netdev@vger.kernel.org; 'Jeff Garzik' Cc: Leonid Grossman; Ananda Raju; Sreenivasa Honnur

[PATCH 3/10] cxgb3 - remove SW Tx credits coalescing

2007-01-30 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Remove tx credit coalescing done in SW. The HW is caring care of it already. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/sge.c | 75 +-- 1 files changed, 14 insertions(+), 61 deletions(-

[PATCH 4/10] cxgb3 - bogus status error string

2007-01-30 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Remove a status error string from the pci-x context and add it where it belongs - the pci-e context. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dri

[PATCH 6/10] cxgb3 - white space to tabs

2007-01-30 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Use tabs in comments. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/net/cxgb3/t3_hw.c b/drivers/net/cxgb3/t3_hw.c

[PATCH 1/10] cxgb3 - FW versioning

2007-01-30 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Clean up FW version checking. The supported FW version is now 3.1. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 15 --- drivers/net/cxgb3/firmware_exports.h | 27 +++ drive

[PATCH 9/10] cxgb3 - Add

2007-01-30 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Include in adapter.h Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/cxgb3/adapter.h b/drivers/net/cxgb3/adapter.h index 8902007..97e35c8 10

[PATCH 8/10] cxgb3 - Unmap offload packets when they are freed.

2007-01-30 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Offload packets may be DMAed long after their SGE Tx descriptors are done so they must remain mapped until they are freed rather than until their descriptors are freed. Unmap such packets through an skb destructor. Signed-off-by: Divy Le Ray <[EMAIL PROTECTE

[PATCH 10/10] cxgb3 - Add dual licensing

2007-01-30 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Dual licensing, needed for OFED 1.2 Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h | 33 +++ drivers/net/cxgb3/ael1002.c | 34 +++- drivers/net/cxgb3/common.h

[PATCH 7/10] cxgb3 - Remove BUG_ON from t3b_intr_napi

2007-01-30 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> In some cases, SG_DATA_INTR won't clear on read and the following interrupt may cause us to assert because NAPI is already scheduled. Remove the assertion, NAPI can handle attempts to rearm it while it's already scheduled. Signed-off-by: Divy Le Ray <[EMAIL

[PATCH 2/10] cxgb3 - bind qsets on multiport adapter

2007-01-30 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Inform FW about the queue set->interface mapping. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h|2 + drivers/net/cxgb3/cxgb3_main.c | 68 ++-- drivers/net/cxgb3/sge.c|

[PATCH 5/10] cxgb3 - Clean up HW init routine

2007-01-30 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Clean up the tp_config() routine. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c | 16 +--- 1 files changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/net/cxgb3/t3_hw.c b/drivers/net/cxgb3/t3_hw.c ind

[PATCH 0/10] cxgb3 - Chelsio T3 1G/10G driver updates

2007-01-30 Thread Divy Le Ray
Jeff, I'm sending a series of incremental patches updating the cxgb3 driver. These patches are built against netdev#upstream. Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.

Re: [RFC] rfkill - Add support for input key to control wireless radio

2007-01-30 Thread Stephen Hemminger
Hope you will be resubmitting this. > +/* > + * rfkill key structure. > + */ > +struct rfkill_key { > + /* > + * For sysfs representation. > + */ > + struct class_device *cdev; > + > + /* > + * Pointer to rfkill structure > + * that was filled in by key driver. > +

Re: Hidden SSID's

2007-01-30 Thread Larry Finger
Jouni Malinen wrote: > On Tue, Jan 30, 2007 at 01:08:29AM -0600, Larry Finger wrote: > >> Any AP with a hidden SSID will only respond to probe requests that specify >> its SSID, and will ignore >> any other probes. In addition, the response will have an empty SSID field. >> These responses are t

Re: buggy IFB driver change

2007-01-30 Thread Joe Perches
On Tue, 2007-01-30 at 14:12 -0800, David Miller wrote: > > > Therefore we must decrement "i" twice before the first > > > free during the cleanup. One to "undo" the for() loop > > > increment, and one to "skip" the ifb_init_one() case which > > > failed. Perhaps putting the error unwind inside th

Re: [Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

2007-01-30 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 21 Feb 2007 09:57:12 -0500), weidong <[EMAIL PROTECTED]> says: > The following is the figure. : > Host eth0: fe80::200:ff:fe00:100 > Router eth0: fe80::20c:29ff:fe24:fa0a > Router eth1: fe80::20c:29ff:fe24:fa14 Other network | | eth1 ++--

Re: sky2 problems on Intel Mac Mini

2007-01-30 Thread Chris Lightfoot
On Tue, Jan 30, 2007 at 11:15:20AM -0800, Stephen Hemminger wrote: > a) hardware flow control problems >look at ethtool -S eth0 statistics, are there flow control packets >showing up? on yeti (machine from which i quoted the first log output), [EMAIL PROTECTED] /root]# /root/ethtool -S et

Re: [Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

2007-01-30 Thread weidong
Hello, Mr yoshfuji: Thanks for your reply. The following is the figure. || || | Router | |||---| | |--|

Re: sky2 problems on Intel Mac Mini

2007-01-30 Thread Tino Keitel
On Tue, Jan 30, 2007 at 15:21:50 -0800, Stephen Hemminger wrote: > On Tue, 30 Jan 2007 10:40:33 +0100 > Tino Keitel <[EMAIL PROTECTED]> wrote: [...] > > Hi, > > > > I found my machine with a freezed desktop tomorrow morning. I don't use > > anything UDP specific, just a lot of TCP traffic. I the

Re: sky2 problems on Intel Mac Mini

2007-01-30 Thread Stephen Hemminger
On Tue, 30 Jan 2007 10:40:33 +0100 Tino Keitel <[EMAIL PROTECTED]> wrote: > On Tue, Jan 30, 2007 at 08:39:19 +, Chris Lightfoot wrote: > > On Mon, Jan 29, 2007 at 04:01:17PM -0800, Stephen Hemminger wrote: > > > On Mon, 29 Jan 2007 23:57:32 + > > > Chris Lightfoot <[EMAIL PROTECTED]> wrote

Re: Hidden SSID's

2007-01-30 Thread Jouni Malinen
On Sun, Jan 28, 2007 at 04:18:01PM -0600, Larry Finger wrote: > Is there something funny about Cisco APs with hidden SSID? Yes, there is.. Or well, "hidden SSID" is funny concept in itself, but anyway.. Some APs set the SSID IE to an array of 0x00 octets with the length of the original SSID when

Re: Hidden SSID's

2007-01-30 Thread Jouni Malinen
On Tue, Jan 30, 2007 at 01:08:29AM -0600, Larry Finger wrote: > Any AP with a hidden SSID will only respond to probe requests that specify > its SSID, and will ignore > any other probes. In addition, the response will have an empty SSID field. > These responses are the > only ones in which a sub

Re: New list for wireless dev discussions

2007-01-30 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 30 Jan 2007 17:36:04 -0500 > John W. Linville wrote: > > At the wireless summit in London, we collectively decided to move > > day-to-day wireless development discussions to our own list. I am > > hosting a list for this purpose: > > > > http:

Re: New list for wireless dev discussions

2007-01-30 Thread Jeff Garzik
John W. Linville wrote: At the wireless summit in London, we collectively decided to move day-to-day wireless development discussions to our own list. I am hosting a list for this purpose: http://lists.tuxdriver.org/mailman/listinfo/wireless If you are interested in Linux wireless deve

Re: [PATCH 1/1] [SCTP]: Force update of the rto when processing HB-ACK

2007-01-30 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Tue, 30 Jan 2007 14:32:51 -0800 > [SCTP]: Force update of the rto when processing HB-ACK > > When processing a HEARTBEAT-ACK it's possible that the transport rto > timers will not be updated because a prior T3-RTX processing would > have cleared t

[PATCH 1/1] [SCTP]: Force update of the rto when processing HB-ACK

2007-01-30 Thread Sridhar Samudrala
[SCTP]: Force update of the rto when processing HB-ACK When processing a HEARTBEAT-ACK it's possible that the transport rto timers will not be updated because a prior T3-RTX processing would have cleared the rto_pending flag on the transport. However, if we received a valid HEARTBEAT-ACK, we want

Re: [patch]IPv6:fix BUG of ndisc_send_redirect()

2007-01-30 Thread David Miller
From: lyw <[EMAIL PROTECTED]> Date: Mon, 29 Jan 2007 18:16:36 +0800 > Mr David: > >I have submitted a patch to fix the ndisc_send_resirect(), and this > patch has been agreed by Mr yoshifuji. But you have not applied yet. > The following is Mr yoshifuji's reply, and I submitted the patch agai

Re: spidernet: add improved phy support in sungem_phy.c

2007-01-30 Thread Linas Vepstas
On Sat, Jan 27, 2007 at 12:38:09AM +0100, Francois Romieu wrote: > Jens Osterkamp <[EMAIL PROTECTED]> : > > > Index: linux-2.6.20-rc5/drivers/net/sungem_phy.c > === > --- linux-2.6.20-rc5.orig/drivers/net/sungem_phy.c > +++ linux-2.6.

Re: [PATCH] IPv6: Fix up some CONFIG typos

2007-01-30 Thread David Miller
From: Neil Horman <[EMAIL PROTECTED]> Date: Tue, 30 Jan 2007 11:04:11 -0500 > Hey- > Noticed some typos in some configurable options while going through the > IPv6 code. Patch attached to clean them up. > > Thanks & Regards > Neil > > > Signed-off-by: Neil Horman <[EMAIL PROTECTED]> Go

Re: TCP_DEFER_ACCEPT brokenness?

2007-01-30 Thread Julian Anastasov
Hello, On Tue, 30 Jan 2007, dean gaudet wrote: > > which is a bit confusing because it talks both about seconds and > > "attempts". (and doesn't mention what happens when the timeout finishes > > -- i could see dropping the socket or passing it to userland anyhow as > > possibilities...

Re: buggy IFB driver change

2007-01-30 Thread David Miller
From: Linus Torvalds <[EMAIL PROTECTED]> Date: Tue, 30 Jan 2007 14:13:14 -0800 (PST) > On Tue, 30 Jan 2007, Jeff Garzik wrote: > > > > I'm about to crash, can you or Linus handle the correction? > > Reverted, pushed out. > > Davem, if you have any other issues, just push me any fixes. I'm going

Re: buggy IFB driver change

2007-01-30 Thread Linus Torvalds
On Tue, 30 Jan 2007, Jeff Garzik wrote: > > I'm about to crash, can you or Linus handle the correction? Reverted, pushed out. Davem, if you have any other issues, just push me any fixes. I'm going to do a final -rc7 today (way too many changes for me to be happy releasing a 2.6.20 without a

Re: buggy IFB driver change

2007-01-30 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 30 Jan 2007 16:52:27 -0500 > David Miller wrote: > > Jeff, please revert: 0c0b3ae68ec93b1db5c637d294647d1cca0df763 > > > > It's wrong. We had a lengthy analysis of this piece of code > > several months ago, and it is correct. > > > > Consider, if

Re: buggy IFB driver change

2007-01-30 Thread Jeff Garzik
David Miller wrote: Jeff, please revert: 0c0b3ae68ec93b1db5c637d294647d1cca0df763 It's wrong. We had a lengthy analysis of this piece of code several months ago, and it is correct. Consider, if we run the loop and we get an error the following happens: 1) attempt of ifb_init_one(i) fails, the

Re: [PATCH] PA Semi PWRficient Ethernet driver

2007-01-30 Thread Francois Romieu
Olof Johansson <[EMAIL PROTECTED]> : > On Mon, Jan 29, 2007 at 11:35:06PM +0100, Francois Romieu wrote: [...] > > - The driver does not contain a single SMP locking instruction but > > http://www.pasemi.com claims the platform to be multicore. > > Is the driver really designed to be lockless ?

New list for wireless dev discussions

2007-01-30 Thread John W. Linville
At the wireless summit in London, we collectively decided to move day-to-day wireless development discussions to our own list. I am hosting a list for this purpose: http://lists.tuxdriver.org/mailman/listinfo/wireless If you are interested in Linux wireless development, please subscribe

Re: [PATCH 1/2] NetXen: Added ethtool support for user level tools

2007-01-30 Thread Francois Romieu
Amit S. Kale <[EMAIL PROTECTED]> : [...] > diff --git a/drivers/net/netxen/netxen_nic_ethtool.c > b/drivers/net/netxen/netxen_nic_ethtool.c > index 3404461..49b3b4c 100644 > --- a/drivers/net/netxen/netxen_nic_ethtool.c > +++ b/drivers/net/netxen/netxen_nic_ethtool.c [...] > static void > @@ -445

buggy IFB driver change

2007-01-30 Thread David Miller
Jeff, please revert: 0c0b3ae68ec93b1db5c637d294647d1cca0df763 It's wrong. We had a lengthy analysis of this piece of code several months ago, and it is correct. Consider, if we run the loop and we get an error the following happens: 1) attempt of ifb_init_one(i) fails, therefore we should n

Re: [PATCH] PA Semi PWRficient Ethernet driver

2007-01-30 Thread Olof Johansson
On Mon, Jan 29, 2007 at 09:34:06PM -0500, Jeff Garzik wrote: > Olof Johansson wrote: > >Right now it's guaranteed that the interrupts will not be shared. They're > >fixed for the on-chip devices, and no other driver should be binding to > >the same channels (and thus irqs). > > > >If it changes in

Re: sky2 problems on Intel Mac Mini

2007-01-30 Thread Stephen Hemminger
There are a couple problems here: 1) the transmitter is getting hung. 2) the recovery logic doesn't work. If I can reproduce hang, then maybe the recovery code could be fixable. Let's address the transmitter hang first. The transmitter has multiple stages so it could be either: a) hardware flo

Re: [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n)

2007-01-30 Thread Patrick McHardy
Adrian Bunk wrote: > On Sun, Jan 28, 2007 at 04:04:42PM -0800, David Miller wrote: > >>From: Adrian Bunk <[EMAIL PROTECTED]> >>Date: Mon, 29 Jan 2007 01:00:11 +0100 >> >>>"depends on IPV6" would fix the bug - but it would also make >>>NF_CONNTRACK_H323 unavailable for all people without IPV6 supp

Re: [RFC] rfkill - Add support for input key to control wireless radio

2007-01-30 Thread Ivo van Doorn
Well it's been a while, but here is an updated version of rfkill. The changes since the version that was originally send are: Spelling fixes (Thanks to Randy Dunlap) THIS_MODULE is now a field in the rkfill_master (Suggested by Christoph Hellwig) Move to the new Workqueue API The open_count has

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-30 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 30 Jan 2007 08:02:08 -0500), Neil Horman <[EMAIL PROTECTED]> says: > > I do not think we should copy neighbor information from (one of) > > default routers, but use temporary neigh entry (or neigh in new state) > > for such datagrams in stead. We should aw

[PATCH] IPv6: Fix up some CONFIG typos

2007-01-30 Thread Neil Horman
Hey- Noticed some typos in some configurable options while going through the IPv6 code. Patch attached to clean them up. Thanks & Regards Neil Signed-off-by: Neil Horman <[EMAIL PROTECTED]> addrconf.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ip

Re: [PATCH] PA Semi PWRficient Ethernet driver

2007-01-30 Thread Olof Johansson
On Tue, Jan 30, 2007 at 10:03:58AM +, Christoph Hellwig wrote: > On Mon, Jan 29, 2007 at 12:08:52AM -0600, Olof Johansson wrote: > > Driver for the PA Semi PWRficient on-chip Ethernet (1/10G) > > > > Basic enablement, will be complemented with performance enhancements > > over time. PHY suppor

[PATCH 2/2] NetXen: Firmware crb init changes

2007-01-30 Thread Amit S. Kale
NetXen: firmware crb init changes. Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> --- netxen_nic.h |2 +- netxen_nic_init.c | 12 +--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/netxen/netxen_nic.h b/drivers/net/netxen/netxen_nic.h index f188b

Re: [PATCH] PA Semi PWRficient Ethernet driver

2007-01-30 Thread Olof Johansson
On Tue, Jan 30, 2007 at 10:06:49AM +, Christoph Hellwig wrote: > On Mon, Jan 29, 2007 at 07:41:16PM -0600, Olof Johansson wrote: > > Maybe a bit of introduction could be useful (also regarding the > > pci_map/alloc comments below). > > > > Our devices are on-chip, and while they're not on a PC

[PATCH 1/2] NetXen: Added ethtool support for user level tools

2007-01-30 Thread Amit S. Kale
Added ethtool support for user level firmware management utilities. Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> --- netxen_nic.h | 16 ++- netxen_nic_ethtool.c | 87 +--- netxen_nic_init.c| 268 ++- 3 files changed

[PATCH 0/2] NetXen: NetXen 1G/10G Ethernet Driver updates

2007-01-30 Thread Amit S. Kale
Hi All, I will be sending NetXen: 1G/10G Ethernet Driver updates in subsequent emails. Thanks, --Amit - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

PC300too alternative WAN driver

2007-01-30 Thread Krzysztof Halasa
The attached patch adds an alternative driver "pc300too" for PCI WAN cards PC300/RSV and PC300/X21 made by Cyclades Corp. (now Avocent Corp). Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig index 21f76f5..f07aec3 100644 --- a/driv

Re: [Fwd: Re: wan/pc300 bug found]

2007-01-30 Thread Krzysztof Halasa
Hi, Jeff Garzik <[EMAIL PROTECTED]> writes: >> I have a driver for PC300/RSV (dual V.35 + V.24) for years. I'm told >> it works with X.21 version too. If someone has a spare T1/E1 card >> (non-returnable donation only) I can try to add support as well. >> T1/E1 is too complicated to maintain with

Re: igmp: possible NULL dereference after GFP_ATOMIC allocation?

2007-01-30 Thread Alexey Dobriyan
On Tue, Jan 30, 2007 at 03:34:18AM -0800, David Stevens wrote: > I think you're correct-- looks like it needs: > > if (!skb) > return NULL; > > just before the skb_put(), since an allocation (and failure) > could occur in either the igmpv3_newpack() call or in add_gr

[git patches] net driver fixes

2007-01-30 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/82596.c |7 +++-- drivers/net/b44.c | 52 ++-- drivers/net

Re: [PATCH 2.6.20-rc5 1/4] atl1: unconditionally enable MSI

2007-01-30 Thread Jeff Garzik
Jay Cliburn wrote: From: Luca Tettamanti <[EMAIL PROTECTED]> Unconditionally enable MSI in atl1 driver. Also remove some useless #ifdef since pci_{en,dis}able_msi() are no-op when MSI support is not configured in. Signed-off-by: Luca Tettamanti <[EMAIL PROTECTED]> Signed-off-by: Jay Cliburn <[E

Re: [PATCH -FIX] e100: fix irq leak on suspend/resume

2007-01-30 Thread Jeff Garzik
Auke Kok wrote: e100: fix irq leak on suspend/resume From: Frederik Deweerdt <[EMAIL PROTECTED]> The e100_resume() function should be calling netif_device_detach and free_irq. This fixes multiple irq's being allocated after resume. Signed-off-by: Frederik Deweerdt <[EMAIL PROTECTED]> Signed-of

Re: [PATCH 2.6.20-rc6 1/2] ehea: Fixed wrong jumbo frames status query

2007-01-30 Thread Jeff Garzik
Thomas Klein wrote: This patch fixes the wrong query and logging of the per interface jumbo frames enabled/disabled status. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> applied 1-2 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROT

Re: [PATCH 4/6] d80211: don't display name of invisible network device

2007-01-30 Thread Jan Kiszka
2007/1/30, Johannes Berg <[EMAIL PROTECTED]>: On Mon, 2007-01-29 at 18:48 +0100, Jiri Benc wrote: > Invisible master interface does not have meaningful name. Display the wiphy > identifier in kernel messages instead. > > Also, remove the allocation of master interface name as it is purposeless >

Re: [PATCH 4/6] d80211: don't display name of invisible network device

2007-01-30 Thread Johannes Berg
On Mon, 2007-01-29 at 18:48 +0100, Jiri Benc wrote: > Invisible master interface does not have meaningful name. Display the wiphy > identifier in kernel messages instead. > > Also, remove the allocation of master interface name as it is purposeless > now. If the master netdev no longer has a name

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-30 Thread Neil Horman
On Tue, Jan 30, 2007 at 07:25:36AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > In article <[EMAIL PROTECTED]> (at Mon, 29 Jan 2007 16:30:13 -0500), Neil > Horman <[EMAIL PROTECTED]> says: > > > Quick reality check here. In thinking about how best to go about this > > redirection of frames to the de

Re: igmp: possible NULL dereference after GFP_ATOMIC allocation?

2007-01-30 Thread David Stevens
Alexey, I think you're correct-- looks like it needs: if (!skb) return NULL; just before the skb_put(), since an allocation (and failure) could occur in either the igmpv3_newpack() call or in add_grhead(). Also, similar code in net/ipv6/mcast..c. W

igmp: possible NULL dereference after GFP_ATOMIC allocation?

2007-01-30 Thread Alexey Dobriyan
igmpv3_newpack() uses alloc_skb() with GFP_ATOMIC. It fails, igmpv3_newpack() returns NULL. add_grhead(), sees NULL, returns NULL. At one place add_grhead() return value fed into skb_put() which dereferences it. net/ipv4/igmp.c: 454 if (first) { 455

Re: [RFC] Alternative hidden netwirk device interface

2007-01-30 Thread Christoph Hellwig
On Mon, Jan 29, 2007 at 02:09:58PM -0800, Stephen Hemminger wrote: > Change to allow register_netdevice() to be called with a blank name. > If name is blank, it is not put in name hash list, and doesn't > show up in /sys or /proc That sounds even better indeed! Of course register_netdevice should

Re: [RFC PATCH 1/6] invisible network devices

2007-01-30 Thread Christoph Hellwig
On Mon, Jan 29, 2007 at 10:28:14AM -0800, Stephen Hemminger wrote: > Maybe code would be cleaner if you just could do: > register_netdevice(mydev); > > cloak_netdevice(mydev); > > > And cloak_netdevice() just removed the network device from the > name table. I would rather keep it

Re: [PATCH] PA Semi PWRficient Ethernet driver

2007-01-30 Thread Christoph Hellwig
On Mon, Jan 29, 2007 at 07:41:16PM -0600, Olof Johansson wrote: > Maybe a bit of introduction could be useful (also regarding the > pci_map/alloc comments below). > > Our devices are on-chip, and while they're not on a PCI(e) bus internally, > they do have config headers and will show up as device

Re: [PATCH] PA Semi PWRficient Ethernet driver

2007-01-30 Thread Christoph Hellwig
On Mon, Jan 29, 2007 at 12:08:52AM -0600, Olof Johansson wrote: > Driver for the PA Semi PWRficient on-chip Ethernet (1/10G) > > Basic enablement, will be complemented with performance enhancements > over time. PHY support will be added as well. > > This patch still uses the numerical PCI vendor

Re: sky2 problems on Intel Mac Mini

2007-01-30 Thread Tino Keitel
On Tue, Jan 30, 2007 at 08:39:19 +, Chris Lightfoot wrote: > On Mon, Jan 29, 2007 at 04:01:17PM -0800, Stephen Hemminger wrote: > > On Mon, 29 Jan 2007 23:57:32 + > > Chris Lightfoot <[EMAIL PROTECTED]> wrote: > > > > > [ please cc: me on any reply ] > > > > > > I'm seeing lots of probl

Re: TCP_DEFER_ACCEPT brokenness?

2007-01-30 Thread dean gaudet
ping. i received no response on this one.. thanks -dean On Sat, 30 Dec 2006, dean gaudet wrote: > hi... i'm having troubles matching up the tcp(7) man page description of > TCP_DEFER_ACCEPT versus some comments in the kernel (2.6.20-rc2) versus > how the kernel actually acts. > > the man pag

Re: sky2 problems on Intel Mac Mini

2007-01-30 Thread Chris Lightfoot
On Mon, Jan 29, 2007 at 04:01:17PM -0800, Stephen Hemminger wrote: > On Mon, 29 Jan 2007 23:57:32 + > Chris Lightfoot <[EMAIL PROTECTED]> wrote: > > > [ please cc: me on any reply ] > > > > I'm seeing lots of problems with the sky2 driver on Mac > > Minis. Based on the suggestions in, > >

Re: [Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

2007-01-30 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 30 Jan 2007 16:55:12 +0900), "Wei Dong" <[EMAIL PROTECTED]> says: > Hello, Mr yoshfuji > Take ping6 for example. Asumming there is a router which has 2 NICs. > eth0 on router has ipv6 addr fe80::20c:29ff:fe24:fa0a, eth1 on router has > ipv6 addr fe80: