Re: [irda-users] [2.6.20-rt8] Neighbour table overflow.

2007-03-26 Thread Guennadi Liakhovetski
On Sat, 24 Mar 2007, Samuel Ortiz wrote: On Fri, Mar 23, 2007 at 01:14:43PM +0100, Guennadi Liakhovetski wrote: Below is a patch that fixes ONE sk_buff leak (maintainer added to cc: hi, Paul:-)). Still investigating if there are more there. Are you still seeing the skb cache growing with

net-2.6.22 rebased...

2007-03-26 Thread David Miller
I build this tree by cloning the current bug fix net-2.6 tree then merging in all of the net-2.6.22 stuff on top, in the usual spot: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.22.git I merged in a few of the small oh shit type bug fix patches into the changeset that caused the

Re: [PATCH] fib_hash removal

2007-03-26 Thread Robert Olsson
Paul E. McKenney writes: Those of use who dive into networking only occasionally would much appreciate this. ;-) No problem here... Cheers --ro Acked-by: Robert Olsson [EMAIL PROTECTED] Signed-off-by: Paul E. McKenney [EMAIL PROTECTED] (but

[PATCH] Correct accept(2) recovery after sock_attach_fd()

2007-03-26 Thread Alexey Dobriyan
* d_alloc() in sock_attach_fd() fails leaving -f_dentry of new file NULL * bail out to out_fd label, doing fput()/__fput() on new file * but __fput() assumes valid -f_dentry and dereferences it Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- net/socket.c |7 ++- 1 file changed, 6

[PATCH 0/7] qla3xxx: bugfixes and new PHY support.

2007-03-26 Thread Ron Mercer
Jeff, Of the following 7 patches, the first four are bugfixes that we would like to get into 2.6.21 if possible. The other three add support for a new PHY and change the driver version. We've built and tested this using netdev/upstream 2.6.21-rc3. Ron Mercer Signed-off-by: Ron Mercer [EMAIL

more... iproute2/htb/whatever critical bug ?

2007-03-26 Thread Denys
Hello again one more bug, and seems even more painful, kernel panic... kernel 2.6.20.3 It is kind of complicated setup: Init of shaper on ifb0 device $TC qdisc add dev ifb0 root handle 1: htb default 1000 $TC filter add dev ifb0 parent 1:0 prio 1000 protocol ip u32 match ip dst 0.0.0.0/0

[PATCH 1/7] qla3xxx: bugfix: Add tx control block memset.

2007-03-26 Thread Ron Mercer
This was removed in a previous patch to increase performance, but caused a transmit error for the 4032 chip. Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/qla3xxx.c

[PATCH 2/7] qla3xxx: bugfix: Multi segment sends were getting whacked.

2007-03-26 Thread Ron Mercer
The proper header length was not being used. Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index f645a0d..85850d1 100755 ---

[PATCH 3/7] qla3xxx: bugfix: Dropping interrupt under heavy network load.

2007-03-26 Thread Ron Mercer
Update the rx queue pointer when exiting NAPI poll rather than at the end of each iteration. Remove unnecessary PCI flushes that occurred after every write. Now write all regs and flush once. Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c | 71

[PATCH 5/7] qla3xxx: Add ethtool get_pauseparam for improved bonding support.

2007-03-26 Thread Ron Mercer
Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index 9947a8d..631bf9f 100755 --- a/drivers/net/qla3xxx.c +++ b/drivers/net/qla3xxx.c @@

[PATCH 7/7] qla3xxx: Bumping driver version number to v2.03.00-k4

2007-03-26 Thread Ron Mercer
Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index 3a49fc9..2967c89 100755 --- a/drivers/net/qla3xxx.c +++ b/drivers/net/qla3xxx.c @@ -39,7 +39,7 @@

[PATCH 4/7] qla3xxx: bugfix: Jumbo frame handling.

2007-03-26 Thread Ron Mercer
Fixed rx checksum bits. Turn on TCP processing for rx checksum. Fixed max frame length register write. It wasn't getting set in multi-port system. Set rx buffer queue length properly for jumbo frames. Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c | 29

[PATCH 6/7] qla3xxx: Adding support for the Agere PHY (ET1011C)

2007-03-26 Thread Ron Mercer
This PHY support patch was written by Benjamin Li. Signed-off-by: Benjamin Li [EMAIL PROTECTED] Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c | 347 +++-- drivers/net/qla3xxx.h | 33 +- 2 files changed, 335 insertions(+),

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-26 Thread Joy Latten
On Thu, 2007-03-22 at 20:56 -0400, James Morris wrote: On Thu, 22 Mar 2007, Joy Latten wrote: Perhaps a better semantic would be to fail the entire flush operation if one of the security checks failed. e.g. loop through for permissions first, then if all ok, loop through for deletion.

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-26 Thread James Morris
On Mon, 26 Mar 2007, Joy Latten wrote: Signed-off-by: Joy Latten[EMAIL PROTECTED] This looks ok to me, although I have a couple of minor issues (which should probably not stop it being merged): + if ((err = security_xfrm_policy_delete(pol)) != 0) { The value of 'err' is

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-26 Thread James Morris
On Mon, 26 Mar 2007, James Morris wrote: On Mon, 26 Mar 2007, Joy Latten wrote: Signed-off-by: Joy Latten[EMAIL PROTECTED] This looks ok to me, although I have a couple of minor issues (which should probably not stop it being merged): + if ((err =

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-26 Thread Eric Paris
On Mon, 2007-03-26 at 13:39 -0600, Joy Latten wrote: + if ((err = security_xfrm_policy_delete(pol)) != 0) { + xfrm_audit_log(audit_info-loginuid, +audit_info-secid, +

[PATCH 1/7] qla3xxx: bugfix: Add tx control block memset.

2007-03-26 Thread Ron Mercer
This was removed in a previous patch to increase performance, but caused a transmit error for the 4032 chip. Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/qla3xxx.c

[PATCH 2/7] qla3xxx: bugfix: Multi segment sends were getting whacked.

2007-03-26 Thread Ron Mercer
The proper header length was not being used. Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index f645a0d..85850d1 100755 ---

[PATCH 3/7] qla3xxx: bugfix: Dropping interrupt under heavy network load.

2007-03-26 Thread Ron Mercer
Update the rx queue pointer when exiting NAPI poll rather than at the end of each iteration. Remove unnecessary PCI flushes that occurred after every write. Now write all regs and flush once. Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c | 71

[PATCH 4/7] qla3xxx: bugfix: Jumbo frame handling.

2007-03-26 Thread Ron Mercer
Fixed rx checksum bits. Turn on TCP processing for rx checksum. Fixed max frame length register write. It wasn't getting set in multi-port system. Set rx buffer queue length properly for jumbo frames. Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c | 29

[PATCH 7/7] qla3xxx: Bumping driver version number to v2.03.00-k4

2007-03-26 Thread Ron Mercer
Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index 3a49fc9..2967c89 100755 --- a/drivers/net/qla3xxx.c +++ b/drivers/net/qla3xxx.c @@ -39,7 +39,7 @@

[PATCH 6/7] qla3xxx: Adding support for the Agere PHY (ET1011C)

2007-03-26 Thread Ron Mercer
This PHY support patch was written by Benjamin Li. Signed-off-by: Benjamin Li [EMAIL PROTECTED] Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c | 347 +++-- drivers/net/qla3xxx.h | 33 +- 2 files changed, 335 insertions(+),

[PATCH 5/7] qla3xxx: Add ethtool get_pauseparam for improved bonding support.

2007-03-26 Thread Ron Mercer
Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index 9947a8d..631bf9f 100755 --- a/drivers/net/qla3xxx.c +++ b/drivers/net/qla3xxx.c @@

Re: [PATCH 7/7] qla3xxx: Bumping driver version number to v2.03.00-k4

2007-03-26 Thread Andrew Vasquez
BTW: this patchset was sent twice to netdev. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/7] qla3xxx: Bumping driver version number to v2.03.00-k4

2007-03-26 Thread Ron Mercer
The zeroeth patch was visable on my browser, but the seven patches didn't show up. I thought there was a problem with sendmail so turned debug on and retried. Forget the second set as they are identical patches. On Mon, Mar 26, 2007 at 01:47:30PM -0700, Andrew Vasquez wrote: BTW: this

Problem with sockets an 2.6.21-rc5 kernel

2007-03-26 Thread Jose Alberto Reguero
I had two python programs, server.py and client.py(attached) With server.py in a kernel 2.6.21-rc5 x86_64 and client.py in the same machine, server.py get the message. With server.py in a kerner 2.6.21-rc5 x86_64 and client.py in another machine, server.py don't get the message. The same

RE: [PATCH] NAPI support for Sibyte MAC

2007-03-26 Thread Mark E Mason
Hello, -Original Message- From: Sergei Shtylyov [mailto:[EMAIL PROTECTED] Sent: Saturday, March 24, 2007 12:49 PM To: Mark E Mason Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org Subject: Re: [PATCH] NAPI support for Sibyte MAC [snip] @@ -2075,12 +2143,52 @@ */

Re: [PATCH]: SAD sometimes has double SAs.

2007-03-26 Thread Eric Paris
On Fri, 2007-03-23 at 16:58 -0600, Joy Latten wrote: @@ -710,11 +713,20 @@ static struct xfrm_state *__find_acq_cor switch (family) { case AF_INET: + if (x-id.daddr.a4 == saddr-a4 + x-props.saddr.a4 == daddr-a4) +

Re: [RFC PATCHv5 1/5] [TCP]: Add highest_sack seqno, points to globally highest SACK

2007-03-26 Thread Ilpo Järvinen
On Sun, 25 Mar 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Mon, 26 Mar 2007 00:55:57 +0300 (EEST) On Sat, 24 Mar 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] It is guaranteed to be valid only when !tp-sacked_out. In most cases

Re: [PATCH]: SAD sometimes has double SAs.

2007-03-26 Thread David Miller
From: Eric Paris [EMAIL PROTECTED] Date: Mon, 26 Mar 2007 17:34:59 -0400 I'm not at all able to speak on the correctness or validity of the solution, Neither am I yet :) but shouldn't the ipv6 case be a not an || like the ipv4 case? Isn't this going to match all sorts of things? Did you

Re: [PATCH] Correct accept(2) recovery after sock_attach_fd()

2007-03-26 Thread David Miller
From: Alexey Dobriyan [EMAIL PROTECTED] Date: Mon, 26 Mar 2007 19:34:31 +0400 * d_alloc() in sock_attach_fd() fails leaving -f_dentry of new file NULL * bail out to out_fd label, doing fput()/__fput() on new file * but __fput() assumes valid -f_dentry and dereferences it Signed-off-by:

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-26 Thread Joy Latten
I have made improvements based on James' and Eric's comments. Regards, Joy Signed-off-by: Joy Latten[EMAIL PROTECTED] diff -urpN linux-2.6.20.orig/include/net/xfrm.h linux-2.6.20.patch/include/net/xfrm.h --- linux-2.6.20.orig/include/net/xfrm.h2007-03-23 11:01:48.0 -0500 +++

[PATCH] NET: Remove dead net/sched/Makefile entry for sch_hpfq.o.

2007-03-26 Thread Robert P. J. Day
Remove the worthless net/sched/Makefile entry for the non-existent source file sch_hpfq.c. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] --- diff --git a/net/sched/Makefile b/net/sched/Makefile index ff2d6e5..020767a 100644 --- a/net/sched/Makefile +++ b/net/sched/Makefile @@ -17,7 +17,6

[PATCH/RFC] e1000: Check for hw type before enabling ipv6 TSO

2007-03-26 Thread Sridhar Samudrala
I think the check for hw type is missing in e1000_set_tso() before enabling ipv6 TSO. e1000_probe() makes sure that NETIF_F_TSO6 is set only if hw.mac_type e1000_82547_rev_2. But this is not done in e1000_set_tso() that gets called when trying to enable TSO using ethtool. I noticed this problem

Re: [PATCH] NET: Remove dead net/sched/Makefile entry for sch_hpfq.o.

2007-03-26 Thread David Miller
From: Robert P. J. Day [EMAIL PROTECTED] Date: Mon, 26 Mar 2007 19:10:03 -0400 (EDT) Remove the worthless net/sched/Makefile entry for the non-existent source file sch_hpfq.c. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Applied, thanks Robert. I wonder how cruft like this is able

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-26 Thread Joy Latten
Sending again since one of the email addresses was incorrect. Ok, I have made improvements based on James' and Eric's comments. Regards, Joy Signed-off-by: Joy Latten[EMAIL PROTECTED] diff -urpN linux-2.6.20.orig/include/net/xfrm.h linux-2.6.20.patch/include/net/xfrm.h ---

Re: [PATCH]: SAD sometimes has double SAs.

2007-03-26 Thread Joy Latten
On Mon, 2007-03-26 at 17:34 -0400, Eric Paris wrote: On Fri, 2007-03-23 at 16:58 -0600, Joy Latten wrote: @@ -710,11 +713,20 @@ static struct xfrm_state *__find_acq_cor switch (family) { case AF_INET: + if (x-id.daddr.a4 == saddr-a4 +

Re: [PATCH/RFC] e1000: Check for hw type before enabling ipv6 TSO

2007-03-26 Thread Kok, Auke
Sridhar Samudrala wrote: I think the check for hw type is missing in e1000_set_tso() before enabling ipv6 TSO. e1000_probe() makes sure that NETIF_F_TSO6 is set only if hw.mac_type e1000_82547_rev_2. But this is not done in e1000_set_tso() that gets called when trying to enable TSO using

[PATCH 0/3] [PATCHSET] fib_rules: goto/nop action, flag for detached rules

2007-03-26 Thread Thomas Graf
Patches to the fib rules code, not directly connected, see description of each patch. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] [NET] fib_rules: goto rule action

2007-03-26 Thread Thomas Graf
This patch adds a new rule action FR_ACT_GOTO which allows to skip a set of rules by jumping to another rule. The rule to jump to is specified via the FRA_GOTO attribute which carries a rule preference. Referring to a rule which doesn't exists is explicitely allowed. Such goto rules are marked

[PATCH 2/3] [NET] fib_rules: Mark rules detached from the device

2007-03-26 Thread Thomas Graf
Rules which match against device names in their selector can remain while the device itself disappears, in fact the device doesn't have to present when the rule is added in the first place. The device name is resolved by trying when the rule is added and later by listening to

[PATCH 3/3] [NET] fib_rules: Add no-operation action

2007-03-26 Thread Thomas Graf
The use of nop rules simplifies the usage of goto rules and adds more flexibility as they allow targets to remain while the actual content of the branches can change easly. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/include/linux/fib_rules.h

[PATCH] iproute2: support for goto/nop action and detached flag

2007-03-26 Thread Thomas Graf
Stephen, Patch to support the new fib rules features I just posted on netdev. Index: iproute2.git/include/linux/fib_rules.h === --- iproute2.git.orig/include/linux/fib_rules.h 2007-03-25 22:26:33.0 +0200 +++

Re: [PATCH 1/3] [NET] fib_rules: goto rule action

2007-03-26 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Tue, 27 Mar 2007 01:54:51 +0200 This patch adds a new rule action FR_ACT_GOTO which allows to skip a set of rules by jumping to another rule. The rule to jump to is specified via the FRA_GOTO attribute which carries a rule preference. Referring to

Re: [PATCH 2/3] [NET] fib_rules: Mark rules detached from the device

2007-03-26 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Tue, 27 Mar 2007 01:54:52 +0200 Rules which match against device names in their selector can remain while the device itself disappears, in fact the device doesn't have to present when the rule is added in the first place. The device name is resolved

Re: [PATCH 3/3] [NET] fib_rules: Add no-operation action

2007-03-26 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Tue, 27 Mar 2007 01:54:53 +0200 The use of nop rules simplifies the usage of goto rules and adds more flexibility as they allow targets to remain while the actual content of the branches can change easly. Signed-off-by: Thomas Graf [EMAIL PROTECTED]

Re: [PATCH] LVS: Send ICMP unreachable responses to end-users when real-servers are removed

2007-03-26 Thread David Miller
From: Horms [EMAIL PROTECTED] Date: Sun, 11 Feb 2007 12:04:43 +0900 Hi, this is a small patch by Janusz Krzysztofik to ip_route_output_slow() that allows VIP-less LVS linux director to generate packets originating From VIP if sysctl_ip_nonlocal_bind is set. In a nutshell, the intention

Re: [PATCH]: SAD sometimes has double SAs.

2007-03-26 Thread Joy Latten
On Mon, 2007-03-26 at 14:48 -0700, David Miller wrote: From: Eric Paris [EMAIL PROTECTED] Date: Mon, 26 Mar 2007 17:34:59 -0400 I'm not at all able to speak on the correctness or validity of the solution, Neither am I yet :) but shouldn't the ipv6 case be a not an || like the ipv4

Re: [PATCH] net: tun/tap: fixed hw address handling

2007-03-26 Thread Ahmed S. Darwish
On Sun, Mar 25, 2007 at 01:29:29AM -0700, Brian Braunstein wrote: From: Brian Braunstein [EMAIL PROTECTED] No need for this line. This line is used when you _forward_ another patch from others. Signed-off-by is enough Signed-off-by: Brian Braunstein [EMAIL PROTECTED] --- Kernel

Re: [PATCH] net: tun/tap: fixed hw address handling

2007-03-26 Thread Ahmed S. Darwish
On Mon, Mar 26, 2007 at 10:55:11PM +0200, ahmed wrote: On Sun, Mar 25, 2007 at 01:29:29AM -0700, Brian Braunstein wrote: --- linux-2.6.20.4-ORIG/drivers/net/tun.c 2007-03-23 12:52:51.0 -0700 +++ linux-2.6.20.4/drivers/net/tun.c2007-03-25 00:44:20.0 -0700 @@

Re: [PATCH] net: tun/tap: fixed hw address handling

2007-03-26 Thread Chuck Ebbert
Brian Braunstein wrote: From: Brian Braunstein [EMAIL PROTECTED] Fixed tun/tap driver's handling of hw addresses. The hw address is stored in both the net_device.dev_addr and tun.dev_addr fields. These fields were not kept synchronized, and in fact weren't even initialized to the same

[1/5] 2.6.21-rc5: known regressions

2007-03-26 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-26 Thread James Morris
On Mon, 26 Mar 2007, Joy Latten wrote: Sending again since one of the email addresses was incorrect. Ok, I have made improvements based on James' and Eric's comments. Acked-by: James Morris [EMAIL PROTECTED] + if (xfrm_id_proto_match(x-id.proto,

Re: [PATCH 1/3] [NET] fib_rules: goto rule action

2007-03-26 Thread Stephen Hemminger
David Miller wrote: From: Thomas Graf [EMAIL PROTECTED] Date: Tue, 27 Mar 2007 01:54:51 +0200 This patch adds a new rule action FR_ACT_GOTO which allows to skip a set of rules by jumping to another rule. The rule to jump to is specified via the FRA_GOTO attribute which carries a rule

[NET]: Allow partial checksums to be forwarded

2007-03-26 Thread Herbert Xu
Hi Dave: Looks like I forgot to finish the checksum stuff for Xen last time around. [NET]: Allow partial checksums to be forwarded Right now Xen has a horrible hack that lets it forward packets with partial checksums. One of the reasons that CHECKSUM_PARTIAL was added is so that we can get rid

Re: [NET]: Allow partial checksums to be forwarded

2007-03-26 Thread Stephen Hemminger
Herbert Xu wrote: Hi Dave: Looks like I forgot to finish the checksum stuff for Xen last time around. [NET]: Allow partial checksums to be forwarded Right now Xen has a horrible hack that lets it forward packets with partial checksums. One of the reasons that CHECKSUM_PARTIAL was added is so

Re: [NET]: Allow partial checksums to be forwarded

2007-03-26 Thread Herbert Xu
On Tue, Mar 27, 2007 at 02:36:48PM +1000, Herbert Xu wrote: Looks like I forgot to finish the checksum stuff for Xen last time around. [NET]: Allow partial checksums to be forwarded Hang on, this only gets rid of half the hack. Let me change this first so that we can get rid of them all :)

[NET]: Allow ip_summed to be forwarded as is

2007-03-26 Thread Herbert Xu
Hi Dave: [NET]: Allow ip_summed to be forwarded as is Right now Xen has a horrible hack that lets it forward packets with partial checksums. One of the reasons that CHECKSUM_PARTIAL and CHECKSUM_COMPLETE were added is so that we can get rid of this hack (where it creates two extra bits in the

Re: [NET]: Allow ip_summed to be forwarded as is

2007-03-26 Thread Herbert Xu
On Tue, Mar 27, 2007 at 03:22:43PM +1000, Herbert Xu wrote: [NET]: Allow ip_summed to be forwarded as is Nevermind, that one is broken too. I forgot to update the complete checksums when forwarding. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

[NET]: Allow forwarding of ip_summed except CHECKSUM_COMPLETE

2007-03-26 Thread Herbert Xu
Hi Dave: [NET]: Allow forwarding of ip_summed except CHECKSUM_COMPLETE Right now Xen has a horrible hack that lets it forward packets with partial checksums. One of the reasons that CHECKSUM_PARTIAL and CHECKSUM_COMPLETE were added is so that we can get rid of this hack (where it creates two

[patch 01/10] 8139too: force media setting cleanup

2007-03-26 Thread akpm
From: Bernard Lee [EMAIL PROTECTED] Setting bit 4 5 alone in 8139too module media option does not really force 100Mbps full-duplex mode. When media option bit 0-3 is cleared, 8139too module does not force media setting. Therefore, bit 0-3 requires to be set for bit 4 5 to take effect. The

[patch 07/10] SUN3/3X Lance trivial fix improved

2007-03-26 Thread akpm
From: Cyrill V. Gorcunov [EMAIL PROTECTED] This patch adds checking for allocated DVMA memory and granted IRQ line. Signed-off-by: Cyrill V. Gorcunov [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/sun3lance.c | 16 +++- 1 file changed, 15

[patch 08/10] forcedeth: fix nic poll

2007-03-26 Thread akpm
From: Ayaz Abdulla [EMAIL PROTECTED] The nic poll routine was missing the call to the optimized irq routine. This patch adds the missing call for the optimized path. See http://bugzilla.kernel.org/show_bug.cgi?id=7950 for more information. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED]

[patch 09/10] forcedeth: fix tx timeout

2007-03-26 Thread akpm
From: Ayaz Abdulla [EMAIL PROTECTED] The tx timeout routine was waking the tx queue conditionally. However, it must call it unconditionally since the dev_watchdog has halted the tx queue before calling the timeout function. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] Signed-off-by: Andrew

[patch 05/10] remove unused header file: drivers/net/skfp/h/lnkstat.h

2007-03-26 Thread akpm
From: Robert P. J. Day [EMAIL PROTECTED] Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/skfp/h/lnkstat.h | 84 - 1 file changed, 84 deletions(-) diff -puN

[patch 04/10] baycom_ser_fdx: also allow i/o ports = 0x1000 and enhanced failure logging

2007-03-26 Thread akpm
From: Folkert van Heusden [EMAIL PROTECTED] The baycom_ser_fdx driver did not allow i/o ports = 0x1000. Now that there are pci cards (with rs232 ports) which use for example 0xb800 this limit should not exists. Also, for non kernel coders find the cause of problems was challenging so I added

[patch 03/10] strlcpy is smart enough

2007-03-26 Thread akpm
From: Jean Delvare [EMAIL PROTECTED] strlcpy already accounts for the trailing zero in its length computation, so there is no need to substract one to the buffer size. Signed-off-by: Jean Delvare [EMAIL PROTECTED] Cc: Jan-Bernd Themann [EMAIL PROTECTED] Cc: Thomas Klein [EMAIL PROTECTED]

[patch 10/10] forcedeth: work around NULL skb dereference crash

2007-03-26 Thread akpm
From: Ingo Molnar [EMAIL PROTECTED] work around a NULL skb dereference crash that occurs during high load. Signed-off-by: Ingo Molnar [EMAIL PROTECTED] Cc: Ayaz Abdulla [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---

[patch 4/7] net: tun/tap: fixed hw address handling

2007-03-26 Thread akpm
From: Brian Braunstein [EMAIL PROTECTED] Fixed tun/tap driver's handling of hw addresses. The hw address is stored in both the net_device.dev_addr and tun.dev_addr fields. These fields were not kept synchronized, and in fact weren't even initialized to the same value. Now during both init and

[patch 2/7] Delete unused header file linux/sdla_fr.h.

2007-03-26 Thread akpm
From: Robert P. J. Day [EMAIL PROTECTED] Delete the unreferenced header file include/linux/sdla_fr.h. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- include/linux/sdla_fr.h | 638 -- 1 file changed, 638

[patch 3/7] Delete unused header file linux/if_wanpipe_common.h

2007-03-26 Thread akpm
From: Robert P. J. Day [EMAIL PROTECTED] Delete the unreferenced header file include/linux/if_wanpipe_common.h, as well as the reference to it in the Doc file. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Cc: Krzysztof Halasa [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED]

[patch 1/7] fix irq problem with NAPI + NETPOLL

2007-03-26 Thread akpm
From: Atsushi Nemoto [EMAIL PROTECTED] This patch is to make netif_receive_skb() robust on NAPI+NETPOLL case. 1. netpoll_send_skb() calls netpoll_poll() with interrupt disabled. 2. netpoll_poll() calls poll_napi(). 3. poll_napi() calls dev-poll(). 4. dev-poll() (for example rtl8139_poll()) calls

[patch 7/7] iPhase: 64bit cleanup

2007-03-26 Thread akpm
From: Alan Cox [EMAIL PROTECTED] Signed-off-by: Alan Cox [EMAIL PROTECTED] Date: Thu, 09 Nov 2006 16:12:30 -0800 (PST) From: David Miller [EMAIL PROTECTED] This fixes the most obvious 64-bit problems, but it is still very very broken in other aspects. It is bad enough that I feel irresponsible

[patch 5/7] bonding: replace system timer with work queue

2007-03-26 Thread akpm
From: Jaroslav Kysela [EMAIL PROTECTED] Replace system timer with work queue in monitor functions. The reason for this change is that bonding handlers calls various sleeping functions from the timer handler which is not allowed. Because we cannot share the main workqueue threads (rtnl_lock is

[patch 06/10] tulip: fix shutdown DMA/irq race

2007-03-26 Thread akpm
From: Grant Grundler [EMAIL PROTECTED] IRQs are racing with tulip_down(). DMA can be restarted by the interrupt handler _after_ we call tulip_stop_rxtx() and the DMA buffers are unmapped. The result is an MCA (hard crash on ia64) because of an IO TLB miss. The long-term fix is to make the

[patch 6/7] drivers/net/bonding/bond_main.c:make 3 functions static

2007-03-26 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] This patch makes the following needlessly global functions static: - bond_mode_name() - bond_sethwaddr() - bond_mii_monitor() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/bonding/bond_main.c |

Re: [patch 7/7] iPhase: 64bit cleanup

2007-03-26 Thread Andrew Morton
I have a note here that this patch needs additional work. I forget what it was, there has since been no followup and hence I shall now drop this patch. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch 5/7] bonding: replace system timer with work queue

2007-03-26 Thread Andrew Morton
On Mon, 26 Mar 2007 21:50:01 -0800 [EMAIL PROTECTED] wrote: Replace system timer with work queue in monitor functions. The reason for this change is that bonding handlers calls various sleeping functions from the timer handler which is not allowed. Because we cannot share the main workqueue

Re: [PATCH 1/3] [NET] fib_rules: goto rule action

2007-03-26 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 26 Mar 2007 21:13:07 -0700 Do we have to worry about self inflicted infinite loops? Shouldn't there be some way to some basic validation? We do, and there is. You obviously didn't read Thomas's patch. He prevents loops by only allowing

Re: [NET]: Allow forwarding of ip_summed except CHECKSUM_COMPLETE

2007-03-26 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 27 Mar 2007 15:38:21 +1000 [NET]: Allow forwarding of ip_summed except CHECKSUM_COMPLETE Right now Xen has a horrible hack that lets it forward packets with partial checksums. One of the reasons that CHECKSUM_PARTIAL and CHECKSUM_COMPLETE were

Re: [patch 5/7] bonding: replace system timer with work queue

2007-03-26 Thread Jay Vosburgh
Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 26 Mar 2007 21:50:01 -0800 [EMAIL PROTECTED] wrote: Replace system timer with work queue in monitor functions. The reason for this change is that bonding handlers calls various sleeping functions from the timer handler which is not allowed.