From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Tue, 19 Jun 2007 01:25:57 +0300
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED]
SACK processing code has been sort of russian roulette as no
validation of SACK blocks is previously attempted. It is not
very clear what all kinds of broken
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Tue, 19 Jun 2007 01:25:58 +0300
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED]
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
Adding this MIB item is perfectly fine, patch applied.
-
To unsubscribe from this list: send the line
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Tue, 19 Jun 2007 01:25:56 +0300
Do you have some plans regarding tcp-2.6?
It is sort-of stuck in the mud until some real performance analysis of
the RB-Tree stuff can be done.
I'm currently knee-deep in working on support for some virtualization
disk
From: PJ Waskiewicz [EMAIL PROTECTED]
Date: Mon, 18 Jun 2007 11:42:29 -0700
+
+ /* The TX queue control structures */
+ struct net_device_subqueue *egress_subqueue;
+ int egress_subqueue_count;
Since every net device will have at least one
From: David Howells [EMAIL PROTECTED]
Date: Mon, 18 Jun 2007 12:52:36 +0100
Return the number of bytes buffered in rxrpc_send_data().
Signed-off-by: David Howells [EMAIL PROTECTED]
Patch applied, thanks a lot David.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the
From: Olaf Kirch [EMAIL PROTECTED]
Make skb_seq_read unmap the last fragment
Having walked through the entire skbuff, skb_seq_read would leave the
last fragment mapped. As a consequence, the unwary caller would leak
kmaps, and proceed with preempt_count off by one. The only (kind of
Removed 3 buffer mode support from driver - unused feature
Signed-off-by: Veena Parat [EMAIL PROTECTED]
---
diff -urpN patch_2/drivers/net/s2io.c patch_3/drivers/net/s2io.c
--- patch_2/drivers/net/s2io.c 2007-05-21 15:15:11.0 +0530
+++ patch_3/drivers/net/s2io.c 2007-06-07
Hello Satyam,
First, I'm sorry I couldn't reply to your comments.
I'm so appreciate for your comments.
I will fix my patches following your advices.
But, I have some questions on the another patches. So, I want to ask you
some questions and answer your questions.
+static int
Hello Satyam,
Sorry, but we're not covering from the error condition fully here. Note
that later you merge the temporary modify_target_list entirely back
into the target_list ... which would still contain these erroneous
nodes. A full cleanup (kobject_unregister the entry, and then list_del
Hello Satyam,
and this is why we have to use the dual-list mechanism to react to the net
device rename. This isn't so obvious, a comment at the point where you
declare modify_target_list would be nice? (BTW temporary_list would be
a better name for that, IMO)
All right, my patches are short
Hello Satyam,
*ugh*. I was wondering what a show-stopper this particular patch
was -- introduces a couple of ioctl()'s, exports a new structure to
userspace, adds a hitherto-unneeded header file, brings in
tty_struct/tty_operations and ends up adding so much complexity/
bloat to netconsole.c.
Implementation of review comments
1. Incorporated Jeff Garzik's comments on coding standards.
2. Incorporated Andreas Schwab's comments on redundant condition check.
Signed-off-by: Veena Parat [EMAIL PROTECTED]
---
diff -urpN patch_3/drivers/net/s2io.c patch_4/drivers/net/s2io.c
---
1.Removed MSI support from driver - unused feature
2.Removed pci_request_regions call to allocate bar2 as it is not used in driver
3.Removed pci_release_regions since pci_request_regions is not done
Signed-off-by: Veena Parat [EMAIL PROTECTED]
---
diff -urpN patch_1/drivers/net/s2io.c
Adding checks to check the return value of pci mapping function
Signed-off-by: Veena Parat [EMAIL PROTECTED]
---
diff -urpN org/drivers/net/s2io.c patch_1/drivers/net/s2io.c
--- org/drivers/net/s2io.c 2007-05-17 20:35:39.0 +0530
+++ patch_1/drivers/net/s2io.c 2007-05-17
Kok, Auke wrote:
Wolfgang Nothdurft wrote:
Hi,
with the new e1000 driver version 7.3.20 the onboard gigabit nic 82547EI
(8086:1019) doesn't work correctly.
After transferring about 100 megabytes over a gigabit link the transfer
stopped and I have to reinit the link either by doing a
Out of curiousity, does it work if you just do a single read (ie
RTL_R8(TxPoll);) of the register before writing to it? That would clear
things up if it is a PCI posting problem.
Hi Ben,
I tried your suggestion but it didn't seem to make any difference :(
I tried the following
Hi,
This is the second submission of the network driver for PS3.
This version have been updated to address issues raised in the review.
Please apply for 2.6.23.
From: Masakazu Mokuno [EMAIL PROTECTED]
Add Gigabit Ethernet support for the PS3 game console. The module will
be called ps3_gelic.
On Mon, 2007-06-18 at 11:01 -0400, jamal wrote:
Ok, by inspection (sorry, still dont have much time) - your kernel code
is sending to group 1; i.e
genlmsg_multicast(skb, 0, 1, GFP_ATOMIC);
you need to change that to send to your assigned id, i.e:
genlmsg_multicast(skb, 0,
David Miller wrote:
From: Patrick McHardy [EMAIL PROTECTED]
Date: Mon, 18 Jun 2007 18:09:11 +0200
[XFRM]: Fix MTU calculation for non-ESP SAs
My IPsec MTU optimization patch introduced a regression in MTU calculation
for non-ESP SAs, the SA's header_len needs to be subtracted from the MTU
These patches add a rewritten version of Ben's macvlan driver, which
allows to create virtual ethernet devices. The underlying device is
put in promiscous mode and packets are demuxed based on MAC address.
It behaves similar to bridge devices in that packets are visible on
the real device before
[ETHERNET]: Validate new address in eth_mac_addr
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
---
commit c92ac42cd3badaf120e97223ac4798abf5226424
tree 824d080a4748fcd6f025bbe7b9466feee46e3303
parent 45da27ba265dba3c740c45d47f584c30d7066f82
author Patrick McHardy [EMAIL PROTECTED] Mon, 18 Jun
Hi all,
The network namespace patchset has been ported to 2.6.21-mm2.
They are still some issues but we are on it, for this reason the
patchset is named netns1-beta1.
The patchset can be found here :
http://lxc.sourceforge.net/patches/2.6.21/2.6.21-mm2-netns1-beta1/
Documentation can be
On Tue, Jun 19, 2007 at 05:21:48PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED])
wrote:
Simple test included test - desktop and vice versa traffic with 128 and
4096 block size in netperf-2.4.3 setup.
I.e. it is not pktgen, but usual userspace application, which should not
use new batch methods.
Hi.
On Thu, Jun 07, 2007 at 07:43:49AM -0400, jamal ([EMAIL PROTECTED]) wrote:
Folks, we need help. Please run this on different hardware. Evgeniy, i
thought this kind of stuff excites you, no? ;- (wink, wink).
Only the sender needs the patch but the receiver must be a more powerful
machine
Hi Keiichi,
On 6/19/07, Keiichi KII [EMAIL PROTECTED] wrote:
Hello Satyam,
Sorry, but we're not covering from the error condition fully here. Note
that later you merge the temporary modify_target_list entirely back
into the target_list ... which would still contain these erroneous
nodes. A
On Tue, Jun 19, 2007 at 06:00:39PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED])
wrote:
On Tue, Jun 19, 2007 at 05:33:33PM +0400, Evgeniy Polyakov ([EMAIL
PROTECTED]) wrote:
On Tue, Jun 19, 2007 at 05:21:48PM +0400, Evgeniy Polyakov ([EMAIL
PROTECTED]) wrote:
Simple test included test -
Hi,
On 6/19/07, Keiichi KII [EMAIL PROTECTED] wrote:
Hello Satyam,
and this is why we have to use the dual-list mechanism to react to the net
device rename. This isn't so obvious, a comment at the point where you
declare modify_target_list would be nice? (BTW temporary_list would be
a
These patches contain some cleanup in net/sched related to estimators
(removal of the NET_ESTIMATOR config option, unnecessary stats_lock
pointers in multiple structures and the HTB estimator reimplementation)
and additionally remove lots of unnecessary includes.
Please apply, thanks.
[NET_SCHED]: Remove CONFIG_NET_ESTIMATOR option
The generic estimator is always built in anways and all the config options
does is prevent including a minimal amount of code for setting it up.
Additionally the option is already automatically selected for most cases.
Signed-off-by: Patrick
[NET_SCHED]: Remove unnecessary stats_lock pointers
Remove stats_lock pointers from qdisc-internal structures, in all cases
it points to dev-queue_lock. The only case where it is necessary is for
top-level qdiscs, where it might also point to dev-ingress_lock in case
of the ingress qdisc. Also
[NET_SCHED]: sch_htb: use generic estimator
Use the generic estimator instead of reimplementing (parts of) it.
For compatibility always create a default estimator for new classes.
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
---
commit f18cfcd1e11aabd3c0b606c7f3265634b5261e88
tree
[NET_SCHED]: Remove unnecessary includes
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
---
commit ca29df065c5d0caa69cde99f9cf1775d63b3468d
tree 102917a89c4c3e63f9ba1d586bd112614f8c6614
parent f18cfcd1e11aabd3c0b606c7f3265634b5261e88
author Patrick McHardy [EMAIL PROTECTED] Tue, 19 Jun 2007
On Tue, 05 Jun 2007 22:23:02 +1100 Konstantin Sharlaimov wrote:
Prevent mppe_decompress() from generating osize too small errors when
checking
for output buffer size. When receiving a packet of mru size the output buffer
for decrypted data is 1 byte too small since mppe_decompress() tries to
Hello,
Suppose a routing cache entry is added as a consequence of
a redirect to host ICMP message.
There is in include/linux.h two flags , one for entry which
is created and one for an entry which is modified because of a redirect:
#define RTF_DYNAMIC 0x0010 /* created dyn. (by
On Tue, 2007-19-06 at 10:12 +0800, Zhu Yi wrote:
Mine was much simpler. We don't need to
consider the wireless dynamic priority change case at this time. Just
tell me what you suppose the driver to do (stop|start queue) when the
hardware PHL is full but PHH is empty?
I already responded to
On Tue, 19 Jun 2007 15:08:41 +0200 (MEST)
Patrick McHardy [EMAIL PROTECTED] wrote:
These patches add a rewritten version of Ben's macvlan driver, which
allows to create virtual ethernet devices. The underlying device is
put in promiscous mode and packets are demuxed based on MAC address.
It
On Mon, 2007-18-06 at 20:58 -0700, David Miller wrote:
From: Krishna Kumar2 [EMAIL PROTECTED]
Date: Tue, 19 Jun 2007 09:05:28 +0530
Dave, does it make sense to add this to 2.6.23 ? Herbert and Peter
had earlier reviewed Patch 2/2 and said they were OK with it.
What does Jamal think of
On Tue, 2007-19-06 at 17:21 +0400, Evgeniy Polyakov wrote:
I've ran several simple tests with desktop e1000 adapter I managed to
find.
Mucho gracias Evgeniy.
Test machine is amd athlon64 3500+ with 1gb of ram.
Another point is dektop core duo 3.4 ghz with 2 gb of ram and sky2
driver.
On Tue, 2007-19-06 at 18:00 +0400, Evgeniy Polyakov wrote:
pktgen reults are quite poor:
batch (changed from default script: count reduced, clone increased to 10k)
241319pps 115Mb/sec
mainline (the same script, on start it wrote about unsupported batch_low
parameter:
497520pps 238Mb/sec
On Tue, Jun 19, 2007 at 12:28:49PM -0400, jamal ([EMAIL PROTECTED]) wrote:
On Tue, 2007-19-06 at 18:00 +0400, Evgeniy Polyakov wrote:
pktgen reults are quite poor:
batch (changed from default script: count reduced, clone increased to 10k)
241319pps 115Mb/sec
mainline (the same
On Tue, Jun 19, 2007 at 12:28:49PM -0400, jamal ([EMAIL PROTECTED]) wrote:
In my case, I have:
# CONFIG_TICK_ONESHOT is not set
# CONFIG_NO_HZ is not set
# CONFIG_HIGH_RES_TIMERS is not set
$ cat ./.config | egrep
CONFIG_TICK_ONESHOT|CONFIG_NO_HZ|CONFIG_HIGH_RES_TIMERS
$
I will try to turn
From: PJ Waskiewicz [EMAIL PROTECTED]
Date: Mon, 18 Jun 2007 11:42:29 -0700
+
+ /* The TX queue control structures */
+ struct net_device_subqueue *egress_subqueue;
+ int egress_subqueue_count;
Since every net device will have at least one
On Tue, Jun 19, 2007 at 12:32:48PM -0400, jamal ([EMAIL PROTECTED]) wrote:
pktgen reults are quite poor:
batch (changed from default script: count reduced, clone increased to 10k)
241319pps 115Mb/sec
BTW, dont turn on the cloning - leave it as 1 so we can have every
packet alloced so
jamal writes:
What is your kernel config in regards to HRES timers? Robert mentioned
to me that the clock source maybe causing issues with pktgen (maybe even
qos). Robert, insights?
pktgen heavily uses gettimeofday. I was using tsc as clock source with
our opterons in the lab. In late
On Tue, 2007-19-06 at 19:35 +0200, Robert Olsson wrote:
But Evgeniy is most likely using the same clocksource both for the mainline
and batch tests so there must be something different...
Iam curious though which one, from my notes on my laptop for that test
machine:
# cat
Stephen Hemminger wrote:
On Wed, 13 Jun 2007 21:36:30 -0700
Jay Vosburgh [EMAIL PROTECTED] wrote:
The following patch (based on a patch from Stephen Hemminger
[EMAIL PROTECTED]) removes use after free conditions in
the unregister path for the bonding master. Without this patch, an
On Tue, Jun 19, 2007 at 01:48:20PM -0400, jamal ([EMAIL PROTECTED]) wrote:
On Tue, 2007-19-06 at 19:35 +0200, Robert Olsson wrote:
But Evgeniy is most likely using the same clocksource both for the
mainline
and batch tests so there must be something different...
Iam curious though
On 6/19/07, Patrick McHardy [EMAIL PROTECTED] wrote:
[NET_SCHED]: sch_htb: use generic estimator
Use the generic estimator instead of reimplementing (parts of) it.
For compatibility always create a default estimator for new classes.
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
---
commit
The following patch (based on a patch from Stephen Hemminger
[EMAIL PROTECTED]) removes use after free conditions in
the unregister path for the bonding master. Without this patch, an
operation of the form echo -bond0 /sys/class/net/bonding_masters
would trigger a NULL pointer
More and more people are reporting this error message:
Jun 18 19:54:33 loki kernel: NETDEV WATCHDOG: eth0: transmit timed out
Jun 18 19:54:33 loki kernel: eth0: transmit timed out, tx_status 00 status 8601.
Jun 18 19:54:33 loki kernel: diagnostics: net 0ccc media 8880 dma 003a
fifo
On 6/19/07, Stephen Hemminger [EMAIL PROTECTED] wrote:
Looks good. I have some changes to allow devices with multiple MAC addresses
(never finished). This device could use that.
Stephen,
Is this patch available somewhere? I'd be interested in taking a look at it.
- Chris
-
To unsubscribe
From: PJ Waskiewicz [EMAIL PROTECTED]
Date: Mon, 18 Jun 2007 11:42:29 -0700
+
+ /* The TX queue control structures */
+ struct net_device_subqueue *egress_subqueue;
+ int egress_subqueue_count;
Since every net device will have at least one
On Tue, 19 Jun 2007 21:02:53 +0200
Olaf Hering [EMAIL PROTECTED] wrote:
What happend to __ucmpdi2 from David Woodhouse?
google has a few hits about stuff like this on 32bit powerpc with gcc 4.1.2:
ERROR: __ucmpdi2 [drivers/net/s2io.ko] undefined!
using the drivers/net/s2io* files from
From: Florian Westphal [EMAIL PROTECTED]
The tipc netlink config handler uses the nlmsg_pid from the
request header as destination for its reply. If the application
initialized nlmsg_pid to 0, the reply is looped back to the kernel,
causing hangup. Fix: use nlmsg_pid of the skb that triggered the
On Tue, Jun 19, Stephen Hemminger wrote:
On Tue, 19 Jun 2007 21:02:53 +0200
Olaf Hering [EMAIL PROTECTED] wrote:
What happend to __ucmpdi2 from David Woodhouse?
google has a few hits about stuff like this on 32bit powerpc with gcc 4.1.2:
ERROR: __ucmpdi2 [drivers/net/s2io.ko]
Stephen Hemminger wrote:
Looks good. I have some changes to allow devices with multiple MAC addresses
(never finished). This device could use that.
How would the driver do that? I was thinking about using dev_add_mc,
but wasn't sure if that would work with all drivers for non-multicast
Ranjit Manomohan wrote:
On 6/19/07, Patrick McHardy [EMAIL PROTECTED] wrote:
[NET_SCHED]: sch_htb: use generic estimator
Use the generic estimator instead of reimplementing (parts of) it.
For compatibility always create a default estimator for new classes.
+
Thanks for pointing this out. It seems that we would need to allocate
this extra byte somewhere in kernel ppp code.
However, I am not very familiar with that part of the code yet, and
I'll appreciate any help with finding parts of code where obuffer for
mppe_decompress is allocated.
On 6/20/07,
Florian Westphal wrote:
From: Florian Westphal [EMAIL PROTECTED]
The tipc netlink config handler uses the nlmsg_pid from the
request header as destination for its reply. If the application
initialized nlmsg_pid to 0, the reply is looped back to the kernel,
causing hangup. Fix: use nlmsg_pid
From: Robert Olsson [EMAIL PROTECTED]
Date: Tue, 19 Jun 2007 19:35:45 +0200
pktgen heavily uses gettimeofday. I was using tsc as clock source with
our opterons in the lab. In late 2.6.20 gettimeofday was changed so tsc
couldn't be used on opterons (pktgen at least).
To give you an
On Tue, 19 Jun 2007 23:14:21 +0200
Patrick McHardy [EMAIL PROTECTED] wrote:
Stephen Hemminger wrote:
Looks good. I have some changes to allow devices with multiple MAC addresses
(never finished). This device could use that.
How would the driver do that? I was thinking about using
From: Waskiewicz Jr, Peter P [EMAIL PROTECTED]
Date: Tue, 19 Jun 2007 13:01:18 -0700
I've been thinking about this more today, so please bear with me if I'm
missing something. Right now, with how qdisc_restart() is running, we'd
definitely call netif_subqueue_stopped(dev, skb-queue_mapping)
From: Patrick McHardy [EMAIL PROTECTED]
Date: Tue, 19 Jun 2007 23:14:21 +0200
Stephen Hemminger wrote:
Looks good. I have some changes to allow devices with multiple MAC addresses
(never finished). This device could use that.
How would the driver do that? I was thinking about using
On Mon, 18 Jun 2007, David Miller wrote:
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Tue, 19 Jun 2007 01:25:57 +0300
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED]
SACK processing code has been sort of russian roulette as no
validation of SACK blocks is previously
It's not being allocated at compile time, it's being
allocated linearly into one block of ram in order to avoid
pointer derefs but it's still dynamic in that the size
isn't known until the alloc_netdev() call.
We do this trick all over the networking, TCP sockets are 3
or 4 different
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Wed, 20 Jun 2007 02:09:44 +0300 (EEST)
For sure you're curious enough - have a nice day with the negations... ;-)
...Seriously, double verification of that pkt_len part wouldn't hurt
considering it's complexity.
Thanks for explaining everything,
On Thu, 03 May 2007 19:09:41 -0400
jamal [EMAIL PROTECTED] wrote:
Stephen,
Use this patch instead of the one i sent yesterday.
As before, you will need to pull include/linux/xfrm.h from
net-2.6 once Dave applies the kernel patch.
cheers,
jamal
Using current xfrm.h from kernel headers,
On Mon, 18 Jun 2007 11:16:42 +0900 (JST)
Yasuyuki KOZAKAI [EMAIL PROTECTED] wrote:
tc-pbfifo.8 does not exist because it was moved to tc-bfifo.8.
Signed-off-by: Yasuyuki Kozakai [EMAIL PROTECTED]
---
Makefile |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git
David Miller wrote:
From: Patrick McHardy [EMAIL PROTECTED]
Date: Tue, 19 Jun 2007 23:14:21 +0200
Stephen Hemminger wrote:
Looks good. I have some changes to allow devices with multiple MAC addresses
(never finished). This device could use that.
How would the driver do that?
69 matches
Mail list logo
