Re: [PATCH -mm 2/2] 3c59x MAINTAINERS

2007-09-04 Thread Steffen Klassert
On Tue, Sep 04, 2007 at 03:52:50AM +0530, Satyam Sharma wrote: Remove duplicate entry for the same driver. This is -mm specific. Andrew did not remove the add-3c59x-maintainer patch after pushing it to mainline. This can be fixed just by removing the add-3c59x-maintainer patch from -mm. - To

Re: af_packet: don't enable global timestamps

2007-09-04 Thread Eric Dumazet
On Tue, 4 Sep 2007 06:35:25 +0100 Stephen Hemminger [EMAIL PROTECTED] wrote: Andi mentioned he did something like this already, but never submitted it. The dhcp client application uses AF_PACKET with a packet filter to receive data. The application doesn't even use timestamps, but because

[PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c

2007-09-04 Thread Micah Gruber
This patch fixes a potential null dereference bug where we dereference dev before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah Gruber [EMAIL PROTECTED] --- --- a/drivers/net/tulip/uli526x.c +++ b/drivers/net/tulip/uli526x.c @@ -663,7 +663,7

[CORRECTION][PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c

2007-09-04 Thread Micah Gruber
This patch fixes a potential null dereference bug where we dereference dev before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah Gruber [EMAIL PROTECTED] --- --- a/drivers/net/tulip/uli526x.c +++ b/drivers/net/tulip/uli526x.c @@ -663,7 +663,7

Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-04 Thread Steffen Klassert
On Tue, Sep 04, 2007 at 03:45:55AM +0530, Satyam Sharma wrote: drivers/net/3c59x.c: In function 'vortex_up': drivers/net/3c59x.c:1495: warning: 'err' may be used uninitialized in this function This came in with the recently applied 3c59x-check-return-of-pci_enable_device patch from Mark

Re: [PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c

2007-09-04 Thread Satyam Sharma
Hi Micah, On Tue, 4 Sep 2007, Micah Gruber wrote: This patch fixes a potential null dereference bug where we dereference dev before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah Gruber [EMAIL PROTECTED] --- ---

Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-04 Thread Satyam Sharma
Hi Steffen, On Tue, 4 Sep 2007, Steffen Klassert wrote: On Tue, Sep 04, 2007 at 03:45:55AM +0530, Satyam Sharma wrote: drivers/net/3c59x.c: In function 'vortex_up': drivers/net/3c59x.c:1495: warning: 'err' may be used uninitialized in this function This came in with the recently

Re: [PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c

2007-09-04 Thread Satyam Sharma
On Tue, 4 Sep 2007, Satyam Sharma wrote: Hi Micah, On Tue, 4 Sep 2007, Micah Gruber wrote: This patch fixes a potential null dereference bug where we dereference dev before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah

Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-04 Thread Mark Hindley
On Tue, Sep 04, 2007 at 02:09:47PM +0530, Satyam Sharma wrote: Hi Steffen, On Tue, 4 Sep 2007, Steffen Klassert wrote: On Tue, Sep 04, 2007 at 03:45:55AM +0530, Satyam Sharma wrote: drivers/net/3c59x.c: In function 'vortex_up': drivers/net/3c59x.c:1495: warning: 'err' may be

Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-04 Thread Steffen Klassert
On Tue, Sep 04, 2007 at 09:53:31AM +0100, Mark Hindley wrote: On Tue, Sep 04, 2007 at 02:09:47PM +0530, Satyam Sharma wrote: Hi Steffen, On Tue, 4 Sep 2007, Steffen Klassert wrote: On Tue, Sep 04, 2007 at 03:45:55AM +0530, Satyam Sharma wrote: drivers/net/3c59x.c: In

Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-04 Thread Mark Hindley
On Tue, Sep 04, 2007 at 11:17:57AM +0200, Steffen Klassert wrote: The only warning that I was able to trigger with gcc 4.2 is in the case of a .config without PCI support. In this case I get drivers/net/3c59x.c: In function 'vortex_up': drivers/net/3c59x.c:1672: warning: 'err' is used

Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-04 Thread Steffen Klassert
On Tue, Sep 04, 2007 at 10:35:10AM +0100, Mark Hindley wrote: On Tue, Sep 04, 2007 at 11:17:57AM +0200, Steffen Klassert wrote: The only warning that I was able to trigger with gcc 4.2 is in the case of a .config without PCI support. In this case I get drivers/net/3c59x.c: In

Re: some weird corruption in net-2.6.24

2007-09-04 Thread Thomas Graf
* Herbert Xu [EMAIL PROTECTED] 2007-09-04 07:05 Thomas Graf [EMAIL PROTECTED] wrote: I've been trying to reproduce this, what happens on my system is that when the ISAKMP SA lifetime is exceeded the rekeying fails and my connection dies. I can reproduce this back to 2.6.22 and it

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-04 Thread jamal
On Mon, 2007-03-09 at 20:20 -0700, Mandeep Singh Baines wrote: I didn't see much saving in interrupts on my machine (too fast, I guess). You could try the idea suggested by Dave earlier and just turn interupts for every nth packet. That should cut down the numbers. I did see a significant

[NET] sgiseeq: replace use of dma_cache_wback_inv

2007-09-04 Thread Ralf Baechle
The sgiseeq driver is one of the few remaining users of the ancient cache banging DMA API. Replaced with the modern days DMA API. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/sgiseeq.c b/drivers/net/sgiseeq.c index 0fb74cb..eb67b02 100644 --- a/drivers/net/sgiseeq.c

RE: Ethernet weirdness on 82xx

2007-09-04 Thread Rune Torgersen
-Original Message- From: Denys [mailto:[EMAIL PROTECTED] Sent: Sunday, September 02, 2007 6:12 AM To: Rune Torgersen; [EMAIL PROTECTED]; netdev@vger.kernel.org Subject: Re: Ethernet weirdness on 82xx Thats normal. Check arp_filter sysctl : arp_filter - BOOLEAN Thank you, that

Re: [PATCH] Massive net driver stats cleanup

2007-09-04 Thread Jeremy Fitzhardinge
Jeff Garzik wrote: drivers/net/xen-netfront.c | 26 +++ Hey, look, its identical to the patch I have here. Acked-by: Jeremy Fitzhardinge [EMAIL PROTECTED] J - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

RE: 82557/8/9 Ethernet Pro 100 interrupt mitigation support

2007-09-04 Thread Brandeburg, Jesse
Kok, Auke wrote: Marc Sigler wrote: Hello everyone, I have several systems with three integrated Intel 82559 (I *think*). Does someone know if these boards support hardware interrupt mitigation? I.e. is it possible to configure them to raise an IRQ only if their hardware buffer is full

Re: [PATCH 1/2]: [NET_SCHED]: Make all rate based scheduler work with TSO.

2007-09-04 Thread Patrick McHardy
Bill Fink wrote: On Sat, 1 Sep 2007, Jesper Dangaard Brouer wrote: On Sat, 1 Sep 2007, Patrick McHardy wrote: It still won't work properly with TSO (TBF for example already drops oversized packets during -enqueue), but its a good cleanup anyway. Then lets call it a cleanup of the L2T macros.

Re: [PATCH 2/2]: [NET_SCHED]: Making rate table lookups more flexible.

2007-09-04 Thread Patrick McHardy
Jesper Dangaard Brouer wrote: On Sun, 2007-09-02 at 23:16 +0200, Patrick McHardy wrote: Jesper Dangaard Brouer wrote: On Sun, 2 Sep 2007, Patrick McHardy wrote: Lets focus on the general case, where the functionality actually is needed right away. In the general case: - The rate table

Re: 82557/8/9 Ethernet Pro 100 interrupt mitigation support

2007-09-04 Thread John Sigler
Jesse Brandeburg wrote: Auke Kok wrote: Marc Sigler wrote: I have several systems with three integrated Intel 82559 (I *think*). Does someone know if these boards support hardware interrupt mitigation? I.e. is it possible to configure them to raise an IRQ only if their hardware buffer is

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-04 Thread Daniele Venzano
- Message d'origine - De: Mandeep Singh Baines [EMAIL PROTECTED] Date: Mon, 3 Sep 2007 20:20:36 -0700 Sujet: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition Hi Daniele, Attached is a patch for converting the sis900 driver to NAPI. Please take a look at let me know

Re: [PATCH] Fix e100 on systems that have cache incoherent DMA

2007-09-04 Thread Kok, Auke
David Acker wrote: On the systems that have cache incoherent DMA, including ARM, there is a race condition between software allocating a new receive buffer and hardware writing into a buffer. The two race on touching the last Receive Frame Descriptor (RFD). It has its el-bit set and its next

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-04 Thread Mandeep Baines
On 9/4/07, jamal [EMAIL PROTECTED] wrote: On Mon, 2007-03-09 at 20:20 -0700, Mandeep Singh Baines wrote: I didn't see much saving in interrupts on my machine (too fast, I guess). You could try the idea suggested by Dave earlier and just turn interupts for every nth packet. That should cut

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-04 Thread Mandeep Baines
Cool. I'll try to see if I can clock my pc lower and run the experiments again. I'll measure cpu utilization also this time around. That should be useful for extrapolating. Regards, Mandeep On 9/4/07, Daniele Venzano [EMAIL PROTECTED] wrote: - Message d'origine - De: Mandeep Singh

Re: [PATCH 1/2]: [NET_SCHED]: Make all rate based scheduler work with TSO.

2007-09-04 Thread Bill Fink
On Tue, 04 Sep 2007, Patrick McHardy wrote: Bill Fink wrote: On Sat, 1 Sep 2007, Jesper Dangaard Brouer wrote: On Sat, 1 Sep 2007, Patrick McHardy wrote: It still won't work properly with TSO (TBF for example already drops oversized packets during -enqueue), but its a good cleanup

Re: 2.6.23-rc4-mm1

2007-09-04 Thread Zach Carter
+ioc3-program-uart-predividers.patch +sky2-fe-chip-support.patch +sky2-use-debugfs-rename.patch +sky2-document-gphy_ctrl-bits.patch +sky2-dont-restrict-config-space-access.patch +sky2-advanced-error-reporting.patch +sky2-use-pci_config-access-functions.patch

Re: r8169: slow samba performance

2007-09-04 Thread john
On Mon, 3 Sep 2007, Francois Romieu wrote: [EMAIL PROTECTED] [EMAIL PROTECTED] : [...] I have had abysmal performance trying to remotely run X apps via ssh on a computer with a RTL8111 NIC. Saw this message and decided to give this patch a try --- success! Much, much better. Can you give

[PATCH] [RFC] allow admin/users to specify rto_min in milliseconds rather than jiffies

2007-09-04 Thread Rick Jones
Build upon David Miller's initial patches to set the per-route rto_min so users can specify the rto_min in the same units (milliseconds) in which they are displayed. This is desirable because asking users to convert to and from jiffies themselves, when there can be different values of HZ from

RE: 82557/8/9 Ethernet Pro 100 interrupt mitigation support

2007-09-04 Thread Brandeburg, Jesse
John Sigler wrote: Jesse Brandeburg wrote: Auke Kok wrote: Marc Sigler wrote: I have several systems with three integrated Intel 82559 (I *think*). Does someone know if these boards support hardware interrupt mitigation? I.e. is it possible to configure them to raise an IRQ only

Re: r8169: slow samba performance

2007-09-04 Thread Francois Romieu
[EMAIL PROTECTED] [EMAIL PROTECTED] : [...] 20070903-2.6.23-rc5-r8169-test.patch applied against 2.6.23-rc5 works fine. Performance is acceptable. Does acceptable mean that there is a noticeable difference when compared to the patch based on a busy-waiting loop ? Would you like me to *just*

Re: r8169: slow samba performance

2007-09-04 Thread john
On Tue, 4 Sep 2007, Francois Romieu wrote: [EMAIL PROTECTED] [EMAIL PROTECTED] : [...] 20070903-2.6.23-rc5-r8169-test.patch applied against 2.6.23-rc5 works fine. Performance is acceptable. Does acceptable mean that there is a noticeable difference when compared to the patch based on a

Re: r8169: slow samba performance

2007-09-04 Thread Bruce Cole
Francois Romieu wrote: Does acceptable mean that there is a noticeable difference when compared to the patch based on a busy-waiting loop ? Would you like me to *just* try patches 1 2, to help narrow down anything? I expect patch #2 alone to be enough to enhance the performance. If

SO_BINDTODEVICE mismatch with man page comments.

2007-09-04 Thread Ben Greear
According to the comment in the net/core/sock.c code (in 2.6.20), I should be able to pass a zero optlen to the setsockopt method for SO_BINDTODEVICE: case SO_BINDTODEVICE: { char devname[IFNAMSIZ]; /* Sorry... */

Re: [PATCH] spidernet: fix interrupt reason recognition

2007-09-04 Thread Linas Vepstas
On Fri, Aug 31, 2007 at 06:46:17AM -0400, Jeff Garzik wrote: Ishizaki Kou wrote: This patch solves a problem that the spidernet driver sometimes fails to handle IRQ. The problem happens because, - In Cell architecture, interrupts may arrive at an interrupt controller, even if they are

[PATCH] Remove unneeded pointer iph from ipcomp6_input() in net/ipv6/ipcomp6.c

2007-09-04 Thread Micah Gruber
This trivial patch removes the unneeded pointer iph, which is never used. Signed-off-by: Micah Gruber [EMAIL PROTECTED] --- --- a/net/ipv6/ipcomp6.c2007-09-04 23:18:43.0 +0800 +++ b/net/ipv6/ipcomp6.c2007-09-05 00:48:05.0 +0800 @@ -65,7 +65,6 @@ static int

[PATCH] Remove unneeded pointer newdp from dccp_v4_request_recv_sock() in net/dccp/ipv4.c

2007-09-04 Thread Micah Gruber
This trivial patch removes the unneeded pointer newdp, which is never used. Signed-off-by: Micah Gruber [EMAIL PROTECTED] --- --- a/net/dccp/ipv4.c 2007-09-04 23:18:42.0 +0800 +++ b/net/dccp/ipv4.c 2007-09-05 00:49:54.0 +0800 @@ -381,7 +381,6 @@ { struct