Re: e100 problems in .23rc8 ?

2007-09-27 Thread Herbert Xu
Kok, Auke [EMAIL PROTECTED] wrote: Dave Jones wrote: Last night, I hit this bug during boot up.. http://www.codemonkey.org.uk/junk/e100-2.jpg This morning, I got a mail from a Fedora user of the same .23-rc8 based kernel that has seen a different trace also implicating e100..

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-27 Thread Jeff Garzik
FUJITA Tomonori wrote: Yeah, we could nicely handle lld's restrictions (especially with stacking devices). But iommu code needs only max_segment_size and seg_boundary_mask, right? If so, the first simple approach to add two values to device structure is not so bad, I think. (replying to

[PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Herbert Xu
Hi: [PKT_SCHED]: Add stateless NAT Stateless NAT is useful in controlled environments where restrictions are placed on through traffic such that we don't need connection tracking to correctly NAT protocol-specific data. In particular, this is of interest when the number of flows or the number

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-27 Thread Benjamin Herrenschmidt
On Thu, 2007-09-27 at 03:31 -0400, Jeff Garzik wrote: A key problem I was hoping would be solved with your work here was the elimination of that post dma_map_sg() split. If I understood James and Ben correctly, one of the key problems was always in communicating libata's segment boundary

Re: [PATCH 1/4] net: Dynamically allocate the per cpu counters for the loopback device.

2007-09-27 Thread Eric W. Biederman
David Miller [EMAIL PROTECTED] writes: From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 26 Sep 2007 17:53:40 -0600 This patch add support for dynamically allocating the statistics counters for the loopback device and adds appropriate device methods for allocating and freeing the

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-27 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: On Thu, 2007-09-27 at 03:31 -0400, Jeff Garzik wrote: A key problem I was hoping would be solved with your work here was the elimination of that post dma_map_sg() split. If I understood James and Ben correctly, one of the key problems was always in

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-27 Thread FUJITA Tomonori
CC'ed Jens, James, and linux-scsi. On Thu, 27 Sep 2007 03:31:55 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: FUJITA Tomonori wrote: Yeah, we could nicely handle lld's restrictions (especially with stacking devices). But iommu code needs only max_segment_size and seg_boundary_mask, right? If

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-27 Thread Benjamin Herrenschmidt
On Thu, 2007-09-27 at 03:49 -0400, Jeff Garzik wrote: Benjamin Herrenschmidt wrote: On Thu, 2007-09-27 at 03:31 -0400, Jeff Garzik wrote: A key problem I was hoping would be solved with your work here was the elimination of that post dma_map_sg() split. If I understood James and Ben

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-27 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: On Thu, 2007-09-27 at 03:49 -0400, Jeff Garzik wrote: Benjamin Herrenschmidt wrote: On Thu, 2007-09-27 at 03:31 -0400, Jeff Garzik wrote: A key problem I was hoping would be solved with your work here was the elimination of that post dma_map_sg() split. If I

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-27 Thread Jeff Garzik
FUJITA Tomonori wrote: CC'ed Jens, James, and linux-scsi. On Thu, 27 Sep 2007 03:31:55 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: FUJITA Tomonori wrote: Yeah, we could nicely handle lld's restrictions (especially with stacking devices). But iommu code needs only max_segment_size and

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-27 Thread FUJITA Tomonori
CC'ed Jens, James, and linux-scsi again. On Thu, 27 Sep 2007 04:22:15 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Benjamin Herrenschmidt wrote: On Thu, 2007-09-27 at 03:49 -0400, Jeff Garzik wrote: Benjamin Herrenschmidt wrote: On Thu, 2007-09-27 at 03:31 -0400, Jeff Garzik wrote: A key

Re: [PATCH] net: Add network namespace clone unshare support.

2007-09-27 Thread Cedric Le Goater
Eric W. Biederman wrote: This patch allows you to create a new network namespace using sys_clone, or sys_unshare. As the network namespace is still experimental and under development clone and unshare support is only made available when CONFIG_NET_NS is selected at compile time. As this

Re: [PATCH] sky2: sky2 FE+ receive status workaround

2007-09-27 Thread Jochen Voß
Hi Stephen, On 27 Sep 2007, at 01:58, Stephen Hemminger wrote: + /* This chip has hardware problems that generates bogus status. +* So do only marginal checking and expect higher level protocols +* to handle crap frames. +*/ + if (sky2-hw-chip_id ==

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Evgeniy Polyakov
Hi Herbert. On Thu, Sep 27, 2007 at 03:34:47PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: Hi: [PKT_SCHED]: Add stateless NAT Stateless NAT is useful in controlled environments where restrictions are placed on through traffic such that we don't need connection tracking to correctly NAT

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Herbert Xu
On Thu, Sep 27, 2007 at 01:25:12PM +0400, Evgeniy Polyakov wrote: Couple of comments below. Thanks Evgeniey :) --- a/net/sched/Kconfig +++ b/net/sched/Kconfig @@ -447,6 +447,17 @@ config NET_ACT_IPT To compile this code as a module, choose M here: the module will be

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Evgeniy Polyakov
On Thu, Sep 27, 2007 at 05:33:58PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: +config NET_ACT_NAT +tristate Stateless NAT +depends on NET_CLS_ACT +select NETFILTER Argh... People usually do not understand such jokes :) What about not using netfilter

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Herbert Xu
On Thu, Sep 27, 2007 at 02:07:53PM +0400, Evgeniy Polyakov wrote: It forces all inpuit/pre/post/forward hooks to be enbled not as a direct function call, but as additional lookups. And unability to remove netfilter from config. And just because of couple of checksum helpers... I'm certainly

Re: [PATCH 3/4] net ipv4: When possible test for IFF_LOOPBACK and not dev == loopback_dev

2007-09-27 Thread Daniel Lezcano
Eric W. Biederman wrote: Now that multiple loopback devices are becoming possible it makes the code a little cleaner and more maintainable to test if a deivice is th a loopback device by testing dev-flags IFF_LOOPBACK instead of dev == loopback_dev. Signed-off-by: Eric W. Biederman [EMAIL

[PATCH] fixed broken bootp compilation

2007-09-27 Thread Denis V. Lunev
Compilation fix. Extra bracket removed. Broken by [NET]: Wrap netdevice hardware header creation from Stephen Hemminger [EMAIL PROTECTED] Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- ./net/ipv4/ipconfig.c.compile 2007-09-27 13:32:35.0 +0400 +++ ./net/ipv4/ipconfig.c

Re: Linux networking implementation and packet capture

2007-09-27 Thread Alan Menegotto
Gaurav Aggarwal escreveu: Hi, I am trying to understand the implementation of linux 2.4 and linux 2.6's networking (IPV4) . Can anyone give me some idea/pointers about some of the good resources/whitepapers available in the market to understand the same. If there is any document that mention

ax88796: add 93cx6 eeprom support

2007-09-27 Thread Magnus Damm
ax88796: add 93cx6 eeprom support This patch hooks up the 93cx6 eeprom code to the ax88796 driver and modifies the ax88796 driver to read out the mac address from the eeprom. We need this for the ax88796 on certain SuperH boards. The pin configuration used to connect the eeprom to the ax88796 on

Re: 2.6.23-rc8-mm2 - drivers/net/ibm_newemac/mal - broken

2007-09-27 Thread Kamalesh Babulal
Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ Hi Andrew, The drivers/net/ibm_newemac/mal seems to be broken with 2.6.23-rc8-mm2 also, it was reported on 2.6.23-rc8-mm1 (http://lkml.org/lkml/2007/9/25/173). -- Thanks Regards,

Re: [Devel] [PATCH 4/4] net: Make the loopback device per network namespace

2007-09-27 Thread Denis V. Lunev
Eric W. Biederman wrote: This patch makes loopback_dev per network namespace. Adding code to create a different loopback device for each network namespace and adding the code to free a loopback device when a network namespace exits. This patch modifies all users the loopback_dev so they

[PATCH] proper comment for loopback initialization order

2007-09-27 Thread Denis V. Lunev
Loopback device is special. It should be initialized at the very beginning. Initialization order has been changed by Eric W. Biederman [EMAIL PROTECTED] and this change is non-obvious and important enough to add proper comment. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] ---

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread jamal
On Thu, 2007-27-09 at 16:41 +0400, Evgeniy Polyakov wrote: I've attached simple patch which moves checksum helpers out of CONFIG_NETFILTER option but still in the same linux/netfilter.h header. This should be enough for removing 'select NETFILTER' in your patch. Is there any point in keeping

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Evgeniy Polyakov
On Thu, Sep 27, 2007 at 08:52:03AM -0400, jamal ([EMAIL PROTECTED]) wrote: On Thu, 2007-27-09 at 16:41 +0400, Evgeniy Polyakov wrote: I've attached simple patch which moves checksum helpers out of CONFIG_NETFILTER option but still in the same linux/netfilter.h header. This should be

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Herbert Xu
On Thu, Sep 27, 2007 at 08:39:45AM -0400, jamal wrote: Do you have plans to do the iproute bits? If you do it will be nice to also update the doc/examples with some simple example(s). Oh yes, I didn't test this by poking bits in the kernel you know :) Here are the iproute bits. Cheers, --

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Herbert Xu
On Thu, Sep 27, 2007 at 08:39:45AM -0400, jamal wrote: You also need to p-tcf_qstats.drops++ for all packets that get shot. I was rather hoping that my packets wouldn't get shot :) But yeah let's increment the drops counter for consistency. [PKT_SCHED]: Add stateless NAT Stateless NAT is

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Evgeniy Polyakov
On Thu, Sep 27, 2007 at 08:45:15PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: On Thu, Sep 27, 2007 at 04:41:21PM +0400, Evgeniy Polyakov wrote: I've attached simple patch which moves checksum helpers out of CONFIG_NETFILTER option but still in the same linux/netfilter.h header. This

RTL8111 PCI Express Gigabit driver r8169 produces slow file transfers

2007-09-27 Thread Achim Frase
Dear Linux r8169 crew, I have got your e-mail address from the modinfo of the r8196 module. I am not sure if this is the right way to contact you, but I hope you could help me. The current driver in Kernel 2.6.22 produces very bad network speeds. I only geht 100 kb/s. Maybe you could take a

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread jamal
On Thu, 2007-27-09 at 21:01 +0800, Herbert Xu wrote: On Thu, Sep 27, 2007 at 08:39:45AM -0400, jamal wrote: Do you have plans to do the iproute bits? If you do it will be nice to also update the doc/examples with some simple example(s). Oh yes, I didn't test this by poking bits in the

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Patrick McHardy
Evgeniy Polyakov wrote: +static inline void nf_csum_replace4(__sum16 *sum, __be32 from, __be32 to) +{ + __be32 diff[] = { ~from, to }; + + *sum = csum_fold(csum_partial((char *)diff, sizeof(diff), ~csum_unfold(*sum))); +} + +static inline void nf_csum_replace2(__sum16 *sum,

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Herbert Xu
On Thu, Sep 27, 2007 at 05:10:08PM +0400, Evgeniy Polyakov wrote: +static inline void nf_proto_csum_replace4(__sum16 *sum, struct sk_buff *skb, + __be32 from, __be32 to, int pseudohdr) +{ + __be32 diff[] = { ~from, to }; + if (skb-ip_summed !=

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Evgeniy Polyakov
On Thu, Sep 27, 2007 at 03:16:48PM +0200, Patrick McHardy ([EMAIL PROTECTED]) wrote: Evgeniy Polyakov wrote: +static inline void nf_proto_csum_replace4(__sum16 *sum, struct sk_buff *skb, + __be32 from, __be32 to, int pseudohdr) +{ + __be32 diff[] = { ~from, to

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Evgeniy Polyakov
On Thu, Sep 27, 2007 at 09:20:37PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: How about putting it in net/core/utils.c? I knew, that was a bad idea to try to fix netfilter dependency :) diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h index 1dd075e..51b5a22 100644 ---

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Patrick McHardy
Evgeniy Polyakov wrote: On Thu, Sep 27, 2007 at 03:16:48PM +0200, Patrick McHardy ([EMAIL PROTECTED]) wrote: These are way too large to get inlined, please move somewhere below net/core. I knew that... :) I'm pretty sure new files called net/core/helpers.c which will host that helper

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Evgeniy Polyakov
On Thu, Sep 27, 2007 at 03:30:12PM +0200, Patrick McHardy ([EMAIL PROTECTED]) wrote: Evgeniy Polyakov wrote: On Thu, Sep 27, 2007 at 03:16:48PM +0200, Patrick McHardy ([EMAIL PROTECTED]) wrote: These are way too large to get inlined, please move somewhere below net/core. I

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread jamal
On Thu, 2007-27-09 at 15:30 +0200, Patrick McHardy wrote: I like Herbert's suggestion of net/core/utils.c better (and without the nf_ prefix please). me too. Evgeniy, you are the man if you finish the whole cow as some wise Africans would say;- cheers, jamal - To unsubscribe from this

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread Patrick McHardy
Evgeniy Polyakov wrote: On Thu, Sep 27, 2007 at 09:20:37PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: How about putting it in net/core/utils.c? I knew, that was a bad idea to try to fix netfilter dependency :) diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h This

[PATCH] various dst_ifdown routines to catch refcounting bugs

2007-09-27 Thread Denis V. Lunev
Moving dst entries into init_net.loopback_dev is not a good thing. This hides obvious and non-obvious ref-counting bugs. This patch uses net_ns loopback instead of init_net loopback. This allowes to catch various bugs like recent one in IPv6 DAD handling. Signed-off-by: Denis V. Lunev [EMAIL

Re: [PATCH] sky2: sky2 FE+ receive status workaround

2007-09-27 Thread Stephen Hemminger
On Thu, 27 Sep 2007 09:14:11 +0100 Jochen Voß [EMAIL PROTECTED] wrote: Hi Stephen, On 27 Sep 2007, at 01:58, Stephen Hemminger wrote: + /* This chip has hardware problems that generates bogus status. +* So do only marginal checking and expect higher level protocols +* to

IPSec on Linux Kernel

2007-09-27 Thread Fabio Souto
Hi, I'm currently doing some research work and I thought that maybe you guys could help me out on this. I'm currently trying to find where can I understand more about the IPSec implementation on the current Linux Kernel (2.6.22). I need to find where the AH calls are made so I can reroute those

Re: TCP Spike

2007-09-27 Thread Stephen Hemminger
On Thu, 27 Sep 2007 11:58:01 +0800 Majumder, Rajib [EMAIL PROTECTED] wrote: Hi, We have observed 40ms latency spikes in TCP connections in burst type of traffic. This affects regular TCP sockets. We observed this issue in kernels of 2.4.21 and kernel 2.6.5. Unfortunately, 2.6.5 is out of

Re: [RFC] af_packet: allow disabling timestamps

2007-09-27 Thread Unai Uribarri
This small modification to Stephen's patch timestamps the skb when needed, so the timestamp can be reused by other af_packet sockets. Signed-off-by: Unai Uribarri [EMAIL PROTECTED] --- a/net/core/sock.c +++ b/net/core/sock.c @@ -259,7 +259,8 @@ static void sock_disable_timestamp(struct sock *sk)

Re: [RFC] af_packet: allow disabling timestamps

2007-09-27 Thread Unai Uribarri
On vie, 2007-09-14 at 12:26 +0200, Stephen Hemminger wrote: On Thu, 13 Sep 2007 14:24:06 +0200 Eric Dumazet [EMAIL PROTECTED] wrote: On Thu, 13 Sep 2007 12:42:53 +0200 Stephen Hemminger [EMAIL PROTECTED] wrote: Currently, af_packet does not allow disabling timestamps. This patch

Re: [PATCH] sky2: sky2 FE+ receive status workaround

2007-09-27 Thread Jochen Voss
Hi, On Thu, Sep 27, 2007 at 06:58:07AM -0700, Stephen Hemminger wrote: On Thu, 27 Sep 2007 09:14:11 +0100 Jochen Voß [EMAIL PROTECTED] wrote: On 27 Sep 2007, at 01:58, Stephen Hemminger wrote: + /* This chip has hardware problems that generates bogus status. + * So do only marginal

Re: IPSec on Linux Kernel

2007-09-27 Thread Rami Rosen
Hi,Fabio, - Assuming that you intend to deal with IPV4, I suggest that you will start by looking at the ah4.ko module sources, which are in net/ipv4/ah.c, especially at the ah_output() and the ah_input() methods. (for ipv6 there are the ah6.c in net/ipv6). - May I ask: are you aware that the

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-27 Thread Eric W. Biederman
Urs Thuermann [EMAIL PROTECTED] writes: This patch adds the virtual CAN bus (vcan) network driver. The vcan device is just a loopback device for CAN frames, no real CAN hardware is involved. I'm trying to wrap my head around the CAN use of IFF_LOOPBACK. 6.2 loopback As described in

Re: [PATCH 3/4] net ipv4: When possible test for IFF_LOOPBACK and not dev == loopback_dev

2007-09-27 Thread Eric W. Biederman
Daniel Lezcano [EMAIL PROTECTED] writes: Eric W. Biederman wrote: Now that multiple loopback devices are becoming possible it makes the code a little cleaner and more maintainable to test if a deivice is th a loopback device by testing dev-flags IFF_LOOPBACK instead of dev == loopback_dev.

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-27 Thread Eric W. Biederman
I guess in particular IFF_LOOPBACK means that all packets from a device will come right back to the current machine, and go nowhere else. That usage sounds completely different then the CAN usage which appears to mean. Broadcast packets will be returned to this machine as well as being sent out

Re: [PATCH] various dst_ifdown routines to catch refcounting bugs

2007-09-27 Thread Eric W. Biederman
Denis V. Lunev [EMAIL PROTECTED] writes: Moving dst entries into init_net.loopback_dev is not a good thing. This hides obvious and non-obvious ref-counting bugs. Acked-by: Eric W. Biederman [EMAIL PROTECTED] To be clear using init_net.loopback is currently safe because we don't have any

Re: [Devel] [PATCH 4/4] net: Make the loopback device per network namespace

2007-09-27 Thread Eric W. Biederman
Denis V. Lunev [EMAIL PROTECTED] writes: Eric W. Biederman wrote: This patch makes loopback_dev per network namespace. Adding code to create a different loopback device for each network namespace and adding the code to free a loopback device when a network namespace exits. This patch

Re: RTL8111 PCI Express Gigabit driver r8169 produces slow file transfers

2007-09-27 Thread Francois Romieu
Achim Frase [EMAIL PROTECTED] : [...] but I hope you could help me. Yes. Please try any of: - current 2.6.23-git - 2.6.23-rc8 + patch below diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index b85ab4a..c921ec3 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -1228,7

Re: [PATCH] net: Add network namespace clone unshare support.

2007-09-27 Thread Eric W. Biederman
Cedric Le Goater [EMAIL PROTECTED] writes: diff --git a/include/linux/sched.h b/include/linux/sched.h index a01ac6d..e10a0a8 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -27,6 +27,7 @@ #define CLONE_NEWUTS0x0400 /* New utsname group? */

Re: [RFC/PATCH 0/3] UDP memory usage accounting

2007-09-27 Thread Hideo AOKI
Hello, Apologies for late response. Evgeniy Polyakov wrote: Hi. On Fri, Sep 21, 2007 at 09:18:07PM +0900, Satoshi OSHIMA ([EMAIL PROTECTED]) wrote: This patch set try to introduce memory usage accounting for UDP(currently ipv4 only). Currently, memory usage of UDP can be observed as the

Re: [PATCH 1/4] net: Dynamically allocate the per cpu counters for the loopback device.

2007-09-27 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 27 Sep 2007 01:48:00 -0600 I'm not doing get_cpu/put_cpu so does the comment make sense in relationship to per_cpu_ptr? It is possible. But someone would need to go check for sure. - To unsubscribe from this list: send the line

Re: [RFC/PATCH 2/3] UDP memory usage accounting: accounting unit and variable

2007-09-27 Thread Hideo AOKI
Hello, I apologize for not replying sooner. Andi Kleen wrote: Satoshi OSHIMA [EMAIL PROTECTED] writes: This patch introduces global variable for UDP memory accounting. The unit is page. The global variable doesn't seem to be very MP scalable, especially if you change it for each packet.

RE: [ofa-general] [PATCH v3] iw_cxgb3: Support iwarp-only interfacesto avoid 4-tuple conflicts.

2007-09-27 Thread Kanevsky, Arkady
Sean, What is the model on how client connects, say for iSCSI, when client and server both support, iWARP and 10GbE or 1GbE, and would like to setup most performant connection for ULP? Thanks, Arkady Kanevsky email: [EMAIL PROTECTED] Network Appliance Inc.

Re: [ofa-general] [PATCH v3] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts.

2007-09-27 Thread Sean Hefty
The sysadmin creates for iwarp use only alias interfaces of the form devname:iw* where devname is the native interface name (eg eth0) for the iwarp netdev device. The alias label can be anything starting with iw. The iw immediately after the ':' is the key used by the iw_cxgb3 driver. I'm

Re: [PATCH] fixed broken bootp compilation

2007-09-27 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Thu, 27 Sep 2007 14:46:22 +0400 Compilation fix. Extra bracket removed. Broken by [NET]: Wrap netdevice hardware header creation from Stephen Hemminger [EMAIL PROTECTED] Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] Applied, thanks Denis. - To

Re: [PATCH] proper comment for loopback initialization order

2007-09-27 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Thu, 27 Sep 2007 16:25:27 +0400 Subject: [PATCH] proper comment for loopback initialization order From: Denis V. Lunev [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED], [EMAIL PROTECTED], netdev@vger.kernel.org, [EMAIL

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Thu, 27 Sep 2007 08:39:45 -0400 nice work. I like the egress flag idea;- and who would have thunk stateless nat could be written in such a few lines ;- I would have put the checksum as a separate action but it is fine the way you did it since it simplifies

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-27 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 27 Sep 2007 10:16:37 -0600 I guess in particular IFF_LOOPBACK means that all packets from a device will come right back to the current machine, and go nowhere else. That usage sounds completely different then the CAN usage which

Re: [ofa-general] [PATCH v3] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts.

2007-09-27 Thread Steve Wise
Sean Hefty wrote: The sysadmin creates for iwarp use only alias interfaces of the form devname:iw* where devname is the native interface name (eg eth0) for the iwarp netdev device. The alias label can be anything starting with iw. The iw immediately after the ':' is the key used by the

[PATCH] Added Ethernet PHY support for the Realtek 821x

2007-09-27 Thread ljd015
From: Joe D'Abbraccio [EMAIL PROTECTED] The MPC837xERDB platform uses the RTL8211B Ethernet PHY on the WAN port (on eth0). Also added the kernel configuration options for selecting the PHY. Signed-off-by: Johnson Leung [EMAIL PROTECTED] Signed-off-by: Kevin Lam [EMAIL PROTECTED] Signed-off-by:

RE: [ofa-general] [PATCH v3] iw_cxgb3: Support iwarp-onlyinterfacesto avoid 4-tuple conflicts.

2007-09-27 Thread Sean Hefty
What is the model on how client connects, say for iSCSI, when client and server both support, iWARP and 10GbE or 1GbE, and would like to setup most performant connection for ULP? For the most performance connection, the ULP would use IB, and all these problems go away. :) This proposal is for

[PATCH 1/2] sky2: FE+ vlan workaround

2007-09-27 Thread Stephen Hemminger
The FE+ workaround means the driver can no longer trust the status register to indicate VLAN tagged frames. The fix for this is to just disable VLAN acceleration for that chip version. Tested and works fine. This patch applies to 2.6.23-rc8 after yesterday's patch: sky2 FE+ receive status

Re: TCP Spike

2007-09-27 Thread Ilpo Järvinen
On Thu, 27 Sep 2007, Majumder, Rajib wrote: We have observed 40ms latency spikes in TCP connections in burst type of traffic. This affects regular TCP sockets. Are segments being sent full-sized, or is there perhaps some Nagle component in it as well? I.e., are the applications using

[PATCH 2/2] sky2: fix transmit state on resume

2007-09-27 Thread Stephen Hemminger
This should fix http://bugzilla.kernel.org/show_bug.cgi?id=8667 After resume, driver has reset the chip so the current state of transmit checksum offload state machine and DMA state machine will be undefined. The fix is to set the state so that first Tx will set MSS and offset values. Patch is

Re: [PATCH] various dst_ifdown routines to catch refcounting bugs

2007-09-27 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 27 Sep 2007 10:27:43 -0600 Denis V. Lunev [EMAIL PROTECTED] writes: Moving dst entries into init_net.loopback_dev is not a good thing. This hides obvious and non-obvious ref-counting bugs. Acked-by: Eric W. Biederman [EMAIL

Re: [PATCH] net: Add network namespace clone unshare support.

2007-09-27 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 27 Sep 2007 11:14:33 -0600 Thanks for pointing this out, it's on my todo list to look into, and ensure we resolve. I'm confused because my notes have 0x8000 for the pid namespace, and 0x4000 for the time namespace. Eric, pick

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 27 Sep 2007 20:58:01 +0800 On Thu, Sep 27, 2007 at 08:39:45AM -0400, jamal wrote: You also need to p-tcf_qstats.drops++ for all packets that get shot. I was rather hoping that my packets wouldn't get shot :) But yeah let's increment the drops

Re: [PKT_SCHED]: Add stateless NAT

2007-09-27 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 27 Sep 2007 15:39:34 +0200 Evgeniy Polyakov wrote: On Thu, Sep 27, 2007 at 09:20:37PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: How about putting it in net/core/utils.c? I knew, that was a bad idea to try to fix netfilter

RE: [ofa-general] [PATCH v3] iw_cxgb3: Supportiwarp-onlyinterfacesto avoid 4-tuple conflicts.

2007-09-27 Thread Kanevsky, Arkady
Sean, IB aside, it looks like an ULP which is capable of being both RDMA aware and RDMA not-aware, like iSER and iSCSI, NFS-RDMA and NFS, SDP and sockets, will be treated as two separete ULPs. Each has its own IP address, since there is a different IP address for iWARP port and regular Ethernet

RE: [ofa-general] [PATCH v3] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts.

2007-09-27 Thread Sean Hefty
It is ok to block while holding a mutex, yes? It's okay, I just didn't try to trace through the code to see if it ever tries to acquire the same mutex in the thread that needs to signal the event. - Sean - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH 1/4] net: Dynamically allocate the per cpu counters for the loopback device.

2007-09-27 Thread Eric W. Biederman
David Miller [EMAIL PROTECTED] writes: From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 27 Sep 2007 01:48:00 -0600 I'm not doing get_cpu/put_cpu so does the comment make sense in relationship to per_cpu_ptr? It is possible. But someone would need to go check for sure. Verified.

Re: [PATCH 1/4] net: Dynamically allocate the per cpu counters for the loopback device.

2007-09-27 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 27 Sep 2007 14:44:37 -0600 David Miller [EMAIL PROTECTED] writes: From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 27 Sep 2007 01:48:00 -0600 I'm not doing get_cpu/put_cpu so does the comment make sense in relationship to

[PATCH] rfkill: Move rfkill_switch_all out of global header

2007-09-27 Thread Ivo van Doorn
rfkill_switch_all shouldn't be called by drivers directly, instead they should send a signal over the input device. To prevent confusion for driver developers, move the function into a rfkill private header. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff --git a/include/linux/rfkill.h

Re: [PATCH] rfkill: Move rfkill_switch_all out of global header

2007-09-27 Thread David Miller
From: Ivo van Doorn [EMAIL PROTECTED] Date: Fri, 28 Sep 2007 00:07:41 +0200 rfkill_switch_all shouldn't be called by drivers directly, instead they should send a signal over the input device. To prevent confusion for driver developers, move the function into a rfkill private header.

Re: ax88796: add 93cx6 eeprom support

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 19:51:19 +0900 Magnus Damm [EMAIL PROTECTED] wrote: ax88796: add 93cx6 eeprom support This patch hooks up the 93cx6 eeprom code to the ax88796 driver and modifies the ax88796 driver to read out the mac address from the eeprom. We need this for the ax88796 on certain

Re: Please pull 'upstream-davem' branch of wireless-2.6 (2007-09-27)

2007-09-27 Thread Jeff Garzik
John W. Linville wrote: Dave Jeff, Here are some more wireless stack and driver updates for 2.6.24. Please pull at your earliest convenience. ACK (I presume davem will pull) it looks like this includes my adm feedback, thanks! - To unsubscribe from this list: send the line unsubscribe

[RFC] Make TCP prequeue configurable

2007-09-27 Thread Eric Dumazet
Hi all I am sure some of you are going to tell me that prequeue is not all black :) Thank you [RFC] Make TCP prequeue configurable The TCP prequeue thing is based on old facts, and has drawbacks. 1) It adds 48 bytes per 'struct tcp_sock' 2) It adds some ugly code in hot paths 3) It has a

[PATCH] netns: CLONE_NEWNET don't use the same clone flag as the pid namespace.

2007-09-27 Thread Eric W. Biederman
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- include/linux/sched.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index e10a0a8..d82c1f7 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -27,7

[PATCH] Bring comments in loopback.c uptodate.

2007-09-27 Thread Eric W. Biederman
A hint as to why it is safe to use per cpu variables, and note that we actually can have multiple instances of the loopback device now. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- drivers/net/loopback.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

Re: [RFC] Zero-length write() does not generate a datagram on connected socket

2007-09-27 Thread Stephen Hemminger
On Thu, 27 Sep 2007 13:53:34 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 24 Sep 2007 15:34:35 -0700 The bug http://bugzilla.kernel.org/show_bug.cgi?id=5731 describes an issue where write() can't be used to generate a zero-length

Re: [RFC] Make TCP prequeue configurable

2007-09-27 Thread Stephen Hemminger
On Fri, 28 Sep 2007 00:08:33 +0200 Eric Dumazet [EMAIL PROTECTED] wrote: Hi all I am sure some of you are going to tell me that prequeue is not all black :) Thank you [RFC] Make TCP prequeue configurable The TCP prequeue thing is based on old facts, and has drawbacks. 1) It adds

Re: [PATCH] net: Add network namespace clone unshare support.

2007-09-27 Thread Eric W. Biederman
David Miller [EMAIL PROTECTED] writes: Eric, pick an appropriate new non-conflicting number NOW. Done. My apologies for the confusion. I thought the way Cedric and the IBM guys were testing someone would have shouted at me long before now. This adds unnecessary extra work for Andrew Morton,

Re: [RFC] Make TCP prequeue configurable

2007-09-27 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 28 Sep 2007 00:08:33 +0200 1) It adds 48 bytes per 'struct tcp_sock' 2) It adds some ugly code in hot paths 3) It has a small hit ratio on typical servers using many sockets 4) It may have a high hit ratio on UP machines running one process,

Re: [RFC] Make TCP prequeue configurable

2007-09-27 Thread John Heffner
Stephen Hemminger wrote: On Fri, 28 Sep 2007 00:08:33 +0200 Eric Dumazet [EMAIL PROTECTED] wrote: Hi all I am sure some of you are going to tell me that prequeue is not all black :) Thank you [RFC] Make TCP prequeue configurable The TCP prequeue thing is based on old facts, and has

Re: [PATCH] netns: CLONE_NEWNET don't use the same clone flag as the pid namespace.

2007-09-27 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 27 Sep 2007 16:40:31 -0600 Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Please pull 'upstream-davem' branch of wireless-2.6 (2007-09-27)

2007-09-27 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Thu, 27 Sep 2007 18:21:54 -0400 John W. Linville wrote: Dave Jeff, Here are some more wireless stack and driver updates for 2.6.24. Please pull at your earliest convenience. ACK (I presume davem will pull) it looks like this includes my

Re: [PATCH] Bring comments in loopback.c uptodate.

2007-09-27 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 27 Sep 2007 16:39:53 -0600 A hint as to why it is safe to use per cpu variables, and note that we actually can have multiple instances of the loopback device now. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] Applied. - To

Re: [PATCH] net: Add network namespace clone unshare support.

2007-09-27 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 27 Sep 2007 17:00:23 -0600 I will gladly do what I can, to help. Working against 3 trees development at the moment is a bit of a development challenge. Andrew has to work against 30 or so, so multiply your pain by 10 to understand what he

Re: [PATCH] net: Add network namespace clone unshare support.

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 17:10:53 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: I will gladly do what I can, to help. Working against 3 trees development at the moment is a bit of a development challenge. Andrew has to work against 30 or so I wish! A remerge presently involves pulling

2.6.23-rc8 network problem. Mem leak? ip1000a?

2007-09-27 Thread linux
Uniprocessor Althlon 64, 64-bit kernel, 2G ECC RAM, 2.6.23-rc8 + linuxpps (5.0.0) + ip1000a driver. (patch from http://marc.info/?l=linux-netdevm=118980588419882) After a few hours of operation, ntp loses the ability to send packets. sendto() returns -EAGAIN to everything, including the 24-byte

Re: [PATCH] net: Add network namespace clone unshare support.

2007-09-27 Thread Eric W. Biederman
Andrew Morton [EMAIL PROTECTED] writes: On Thu, 27 Sep 2007 17:10:53 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: I will gladly do what I can, to help. Working against 3 trees development at the moment is a bit of a development challenge. Andrew has to work against 30 or so I

[git patches] net driver fixes

2007-09-27 Thread Jeff Garzik
And an e1000 id patch. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/e1000/e1000_ethtool.c |1 + drivers/net/e1000/e1000_hw.c |1 +

Re: [PATCH] net: Add network namespace clone unshare support.

2007-09-27 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 27 Sep 2007 21:28:45 -0600 David, Andrew thanks you both are really are good upstream maintainers to work with. Just keep the coffee flowing :-) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver

2007-09-27 Thread Grant Grundler
On Thu, Sep 27, 2007 at 11:36:58PM -0400, Jeff Garzik wrote: Zang Roy-r61911 wrote: From: Roy Zang [EMAIL PROTECTED] Clean up redundant PHY write line for ULi526x Ethernet Driver. Signed-off-by: Roy Zang [EMAIL PROTECTED] --- drivers/net/tulip/uli526x.c |1 - 1 files changed, 0

Re: e1000 tcp checksum incorrect, x86 64b

2007-09-27 Thread Herbert Xu
Jon Smirl [EMAIL PROTECTED] wrote: App is writing seven bytes to the socket. Socket write timeout expires and the seven bytes are sent. The checksum is not getting inserted into the packet. It is set to a constant 0x8389 instead of the right value. App is gmpc 0.15.4.95, Revision: 6794

  1   2   >