RE: [PATCH] Disable TSO for non standard qdiscs

2008-02-01 Thread Waskiewicz Jr, Peter P
...But, on the other hand, in this case the realization seems to be wrong: probably still all locally created packets will be treated the same - or I miss something? Jarek P. The TCP layer will generate TSO packets based on the kernel socket features associated with the flow. So if you

Re: [PATCH] Disable TSO for non standard qdiscs

2008-02-01 Thread Patrick McHardy
Waskiewicz Jr, Peter P wrote: Indeed. As an example of an unknowing user, this discussion made me check whether my cablemodem device (on which I'm using HFSC) uses TSO :) The TSO defer logic is based on your congestion window and current window size. So the actual frame sizes hitting your

RE: [PATCH] Disable TSO for non standard qdiscs

2008-02-01 Thread Waskiewicz Jr, Peter P
Indeed. As an example of an unknowing user, this discussion made me check whether my cablemodem device (on which I'm using HFSC) uses TSO :) The TSO defer logic is based on your congestion window and current window size. So the actual frame sizes hitting your NIC attached to your DSL

oops with ipcomp

2008-02-01 Thread Beschorner Daniel
One more issue with 2.6.24, some hours after I reactivated ipcomp with Herb's 2 patches. The httpd log shows a http request per esp tunnel at oops time. Don't know whether it is for network or compression guys, so I started posting here. Daniel Unable to handle kernel paging request at

[PATCH] ieee80211: fix section mismatch warning

2008-02-01 Thread Sam Ravnborg
Fix the following warnings: WARNING: net/built-in.o(.init.text+0xd6c0): Section mismatch in reference from the function ieee80211_init() to the function .exit.text:rc80211_simple_exit() WARNING: net/built-in.o(.init.text+0xd6c5): Section mismatch in reference from the function ieee80211_init()

Re: [PATCH] Disable TSO for non standard qdiscs

2008-02-01 Thread jamal
On Fri, 2008-01-02 at 10:56 +0100, Patrick McHardy wrote: We don't want to disable TSO for cases where it makes sense, but who is using TBF on 10GbE? The point is that most users of qdiscs which are incapable of dealing with TSO without hacks or special configuration probably don't care, and

[PATCH for 2.6.25 2/2] [NET] ucc_geth: add support for netpoll

2008-02-01 Thread Anton Vorontsov
This patch adds netpoll support for the QE UCC Gigabit Ethernet driver. Tested using netconsole and KGDBoE. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- Just resending this. drivers/net/ucc_geth.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff

Re: Slow OOM in netif_RX function

2008-02-01 Thread Eric Dumazet
Ivan Dichev a écrit : Arnaldo Carvalho de Melo wrote: Em Fri, Jan 25, 2008 at 02:21:08PM +0100, Andi Kleen escreveu: Ivan H. Dichev [EMAIL PROTECTED] writes: What could happen if I put different Lan card in every slot? In ex. to-private - 3com to-inet- VIA

[patch 0/7] s390: ctc patches for 2.6.25

2008-02-01 Thread Ursula Braun
-- Jeff, the following patches are intended for 2.6.25. Besides clean-ups they replace the old ctc driver by a reworked ctcm driver. This ctcm driver supports the channel-to-channel connections of the old ctc driver plus an additional MPC protocol to provide SNA connectivity. Patch 1/7:

[PATCH] ehea: fix sysfs link compile problem

2008-02-01 Thread Jan-Bernd Themann
Due to changes in the struct device_driver there is no direct access to its kobj any longer. The kobj was used to create sysfs links between eHEA ethernet devices and the driver. This patch removes the affected sysfs links to resolve the build problems. Signed-off-by: Jan-Bernd Themann [EMAIL

netdev share of section mismatch warnings...

2008-02-01 Thread Sam Ravnborg
Can we please get the following warnings fixed in mainline soonish. I get the below list with a x86 64bit allyesconfig build and I expect anyone to see roughly the same list. It would be great to say that both net/ and drivers/net/ were warning free in this respect. If you have questions let me

Re: [PATCH] ieee80211: fix section mismatch warning

2008-02-01 Thread Johannes Berg
On Fri, 2008-02-01 at 12:52 +0100, Sam Ravnborg wrote: Fix the following warnings: WARNING: net/built-in.o(.init.text+0xd6c0): Section mismatch in reference from the function ieee80211_init() to the function .exit.text:rc80211_simple_exit() WARNING: net/built-in.o(.init.text+0xd6c5):

[PATCH RESEND] [XFRM]: Speed up xfrm_policy and xfrm_state walking

2008-02-01 Thread Timo Teräs
Change xfrm_policy and xfrm_state walking algorithm from O(n^2) to O(n). This is achieved adding the entries to one more list which is used solely for walking the entries. This also fixes some races where the dump can have duplicate or missing entries when the SPD/SADB is modified during an

Re: Lots of BUG eth1 code -5 qlen 0 messages in 2.6.24

2008-02-01 Thread Erik Mouw
On Tue, Jan 29, 2008 at 06:08:28PM -0500, jamal wrote: On Tue, 2008-29-01 at 22:45 +0100, Erik Mouw wrote: The driver seems buggy. Make it return NETDEV_TX_BUSY instead of -EIO in xircom_start_xmit() and the messages will go away. Like this? Indeed. I've changed the -EIO into

[patch 1/7] ctc / netiucv: consolidate fsm_action_nop

2008-02-01 Thread Ursula Braun
From: Peter Tiedemann [EMAIL PROTECTED] move fsm_action_nop to fsm.h to avoid duplicate definitions in both drivers ctc and netiucv. Signed-off-by: Peter Tiedemann [EMAIL PROTECTED] Signed-off-by: Ursula Braun [EMAIL PROTECTED] --- drivers/s390/net/ctcmain.c |8

kernel panic on 2.6.24 with esfq patch applied

2008-02-01 Thread Denys Fedoryshchenko
Hi Probably bug related to ESFQ, now i will unload module and will test more. But probably not related, so if not difficult, please take a look. Feb 1 09:08:50 SERVER [12380.067104] BUG: unable to handle kernel NULL pointer dereference Feb 1 09:08:50 SERVER at virtual address 0008 Feb 1

Re: Slow OOM in netif_RX function

2008-02-01 Thread Ivan Dichev
Arnaldo Carvalho de Melo wrote: Em Fri, Jan 25, 2008 at 02:21:08PM +0100, Andi Kleen escreveu: Ivan H. Dichev [EMAIL PROTECTED] writes: What could happen if I put different Lan card in every slot? In ex. to-private - 3com to-inet- VIA to-dmz - rtl8139 And then

[PATCH for 2.6.25 1/2] [NET] ucc_geth: fix module removal

2008-02-01 Thread Anton Vorontsov
- uccf should be set to NULL to not double-free memory on subsequent calls; - ind_hash_q and group_hash_q lists should be initialized in the probe() function, instead of struct_init() (called by open()), otherwise there will be an oops if ucc_geth_driver removed prior 'ifconfig ethX up'; -

Protocol handler for Marvell DSA EtherType packets

2008-02-01 Thread Jesper Dangaard Brouer
Hi Netdev I writing a new protocol handler using dev_add_pack(). (For a Marvell switch chip handling DSA (Distributed Switch Architecture) Ethertype packets). My protocol handler works and I get the skb. But I want to remove the DSA Headers and send the packet back for normal processing on a

Re: Slow OOM in netif_RX function

2008-02-01 Thread Andi Kleen
On Fri, Feb 01, 2008 at 02:51:40PM +0200, Ivan Dichev wrote: Arnaldo Carvalho de Melo wrote: Em Fri, Jan 25, 2008 at 02:21:08PM +0100, Andi Kleen escreveu: Ivan H. Dichev [EMAIL PROTECTED] writes: What could happen if I put different Lan card in every slot? In ex. to-private -

[patch 3/7] ctcm: infrastructure for replaced ctc driver

2008-02-01 Thread Ursula Braun
From: Peter Tiedemann [EMAIL PROTECTED] establish base stuff for the replaced ctc driver, i.e. Kconfig and Makefile adaptions arch/s390/defconfig drivers/s390/net/Kconfig drivers/s390/net/Makefile Signed-off-by: Peter Tiedemann [EMAIL PROTECTED] Signed-off-by: Ursula Braun [EMAIL

Re: [PATCH] Disable TSO for non standard qdiscs

2008-02-01 Thread Andi Kleen
The TSO defer logic is based on your congestion window and current window size. So the actual frame sizes hitting your NIC attached to your DSL probably aren't anywhere near 64KB, but probably more in line with whatever your window size is for DSL. DSL windows can be quite large because a

[PATCH 1/6] e1000e: make a function static

2008-02-01 Thread Auke Kok
From: Adrian Bunk [EMAIL PROTECTED] This patch makes the needlessly global reg_pattern_test_array() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000e/ethtool.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[PATCH 6/6] igb: remove unneeded declaration shadowing earlier one

2008-02-01 Thread Auke Kok
This removes a sparse warning. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/igb/igb_main.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c index f3c144d..d4eb8e2 100644 --- a/drivers/net/igb/igb_main.c

[PATCH 5/6] e1000e: tweak irq allocation messages

2008-02-01 Thread Auke Kok
From: Andy Gospodarek [EMAIL PROTECTED] There's too much noise on systems that don't support MSI. Let's get rid of a few and make the real error message more specific. Signed-off-by: Andy Gospodarek [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000e/netdev.c |

[PATCH 3/6] e100: Fix iomap mem accesses

2008-02-01 Thread Auke Kok
From: Jiri Slaby [EMAIL PROTECTED] writeX functions are not permitted on iomap-ped space change to iowriteX, also pci_unmap pci_map-ped space on exit (instead of iounmap). Signed-off-by: Jiri Slaby [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e100.c |4 ++--

[2.6 patch] rtnetlink.c: remove no longer used functions

2008-02-01 Thread Adrian Bunk
On Wed, Jan 30, 2008 at 09:04:33PM +0100, Patrick McHardy wrote: Adrian Bunk wrote: This patch #if 0's the following no longer used functions: - rtattr_parse() - rtattr_strlcpy() - __rtattr_parse_nested_compat() Please remove them instead. Updated patch below. cu Adrian -- snip --

[RFC PATCH]: TCP + SACK + skb processing latency

2008-02-01 Thread Ilpo Järvinen
Hi all, Here's an attempt to reduce amount of skb cleanup work TCP with TSO has to do after SACKs have arrived. I'm not on very familiar grounds with TSOed skbs so there likely is much I just couldn't take into account. I probably should at least check some flag somewhere? (=NETIF_F_SG?).

[PATCH] drivers/base: export (un)register_memory_notifier

2008-02-01 Thread Jan-Bernd Themann
Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- Comment: eHEA patches that exploit these functions will follow drivers/base/memory.c |2 ++

[PATCH 0/2] rtnetlink locking and notification fixes

2008-02-01 Thread Laszlo Attila Toth
Hi Dave, These two patches remove unnecessary locks from rtnetlink, it was managed in an inconsistent way, and change notification. The latter is always sent if anything is changed but for compatibility the old nofification is also kept. Regards, Attila -- To unsubscribe from this list: send

[PATCH 1/2] Remove unnecessary locks from rtnetlink

2008-02-01 Thread Laszlo Attila Toth
The do_setlink() function is protected by rtnl, additional locks are unnecessary. and the set_operstate() function is called from protected parts. Locks removed from both functions. The set_operstate() is also called from rtnl_create_link() and from no other places. In rtnl_create_link() none

[PATCH 2/2] rtnetlink: send a single notification on device state changes

2008-02-01 Thread Laszlo Attila Toth
In do_setlink() a single notification is sent at the end of the function if any modification occured. If the address has been changed, another notification is sent. Both of them is required because originally only the NETDEV_CHANGEADDR notification was sent and although device state change

Re: Slow OOM in netif_RX function

2008-02-01 Thread Ivan Dichev
I understand you dont want to tell us exact firewall rules you have. Maybe you could post at least following infos : # cat /proc/slabinfo # lsmod I have changed slab with slub. firewall # cat /sys/slab/kmalloc-2048/alloc_calls 1 add_sect_attrs+0x57/0x120 age=20565254 pid=1115

[2.6 patch] remove obsolete tokenring maintainer information

2008-02-01 Thread Adrian Bunk
- Peter's email address is bouncing - the project webpage no longer exists - neither Peter nor Mike had a single patch included in the kernel since 2.6.12-rc2 (when the git history begins) Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- MAINTAINERS | 23 --- 1 file

[PATCH 2/6] e1000: make e1000_dump_eeprom() static

2008-02-01 Thread Auke Kok
From: Adrian Bunk [EMAIL PROTECTED] This patch makes the needlessly global e1000_dump_eeprom() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH 4/6] e100: fix spelling errors

2008-02-01 Thread Auke Kok
From: Andreas Mohr [EMAIL PROTECTED] Signed-off-by: Andreas Mohr [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e100.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/e100.c b/drivers/net/e100.c index

[patch 2/7] drivers/s390/net: Kconfig brush up

2008-02-01 Thread Ursula Braun
From: Peter Tiedemann [EMAIL PROTECTED] From: Ursula Braun [EMAIL PROTECTED] adapt drivers/s390/net/Kconfig to current IBM wording and further cosmetics Signed-off-by: Peter Tiedemann [EMAIL PROTECTED] Signed-off-by: Ursula Braun [EMAIL PROTECTED] --- drivers/s390/net/Kconfig | 43

Re: [PATCH] drivers/base: export (un)register_memory_notifier

2008-02-01 Thread Badari Pulavarty
On Fri, 2008-02-01 at 17:16 +0100, Jan-Bernd Themann wrote: Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- Comment: eHEA patches that

Re: [PATCH] Disable TSO for non standard qdiscs

2008-02-01 Thread Stephen Hemminger
On Fri, 1 Feb 2008 15:34:21 +0100 Andi Kleen [EMAIL PROTECTED] wrote: The TSO defer logic is based on your congestion window and current window size. So the actual frame sizes hitting your NIC attached to your DSL probably aren't anywhere near 64KB, but probably more in line with

[PATCH] [POWERPC][NET][SERIAL] UCCs: replace device-id with cell-index (was: Re: [PATCH] [POWERPC] get rid of `model = UCC' in the ucc nodes)

2008-02-01 Thread Anton Vorontsov
On Fri, Feb 01, 2008 at 09:32:38AM -0600, Kumar Gala wrote: On Feb 1, 2008, at 9:01 AM, Anton Vorontsov wrote: It isn't used anywhere, so remove it. If we'll ever need something like this, we'll use compatible property instead. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] ---

RE: [Bugme-new] [Bug 9808] New: system hung with htb QoS

2008-02-01 Thread Brandeburg, Jesse
Andrew Morton wrote: On Thu, 24 Jan 2008 03:03:11 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9808 Summary: system hung with htb QoS Product: Networking Version: 2.5 KernelVersion: 2.6.23.9 Platform: All

Re: [PATCH] [POWERPC][NET][SERIAL] UCCs: replace device-id with cell-index

2008-02-01 Thread Jeff Garzik
Anton Vorontsov wrote: On Fri, Feb 01, 2008 at 09:32:38AM -0600, Kumar Gala wrote: On Feb 1, 2008, at 9:01 AM, Anton Vorontsov wrote: It isn't used anywhere, so remove it. If we'll ever need something like this, we'll use compatible property instead. Signed-off-by: Anton Vorontsov [EMAIL

Re: [IPV4 0/9] TRIE performance patches

2008-02-01 Thread Robert Olsson
Hello, finally got some time to test... Table w. 214k routes with full rDoS on two intrefaces on 2 x AMD64 processors, speed 2814.43 MHz. Profiled with CPU_CLK_UNHALTED and rtstat w/o latest patch fib_trie pathes. Tput ~233 kpps samples %symbol name 109925 14.4513

Re: [PATCH 1/5] ehea: fix ehea.h checkpatch complaints

2008-02-01 Thread Jeff Garzik
Doug Maxey wrote: Cc: Jan-Bernd Themann [EMAIL PROTECTED] Signed-off-by: Doug Maxey [EMAIL PROTECTED] --- drivers/net/ehea/ehea.h|3 +++ drivers/net/ehea/ehea_hw.h |8 2 files changed, 7 insertions(+), 4 deletions(-) applied 1-5 -- To unsubscribe from this list: send

Re: [PATCH for 2.6.25 1/2] [NET] ucc_geth: fix module removal

2008-02-01 Thread Jeff Garzik
Anton Vorontsov wrote: - uccf should be set to NULL to not double-free memory on subsequent calls; - ind_hash_q and group_hash_q lists should be initialized in the probe() function, instead of struct_init() (called by open()), otherwise there will be an oops if ucc_geth_driver removed

Re: [PATCH] ehea: fix sysfs link compile problem

2008-02-01 Thread Jeff Garzik
Jan-Bernd Themann wrote: Due to changes in the struct device_driver there is no direct access to its kobj any longer. The kobj was used to create sysfs links between eHEA ethernet devices and the driver. This patch removes the affected sysfs links to resolve the build problems. Signed-off-by:

Re: NET: AX88796 use dev_dbg() instead of printk()

2008-02-01 Thread Jeff Garzik
applied -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] via-rhine.c:rhine_hw_init() must be __devinit

2008-02-01 Thread Jeff Garzik
applied the net driver portion of these patches... -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: rtl8150: use default MTU of 1500

2008-02-01 Thread Jeff Garzik
Lennert Buytenhek wrote: The RTL8150 driver uses an MTU of 1540 by default, which causes a bunch of problems -- it prevents booting from NFS root, for one. Signed-off-by: Lennert Buytenhek [EMAIL PROTECTED] Cc: Petko Manolov [EMAIL PROTECTED] ---

Re: [PATCH] macb: Fix section mismatch and shrink runtime footprint

2008-02-01 Thread Jeff Garzik
Haavard Skinnemoen wrote: macb devices are only found integrated on SoCs, so they can't be hotplugged. Thus, the probe() and exit() functions can be __init and __exit, respectively. By using platform_driver_probe() instead of platform_driver_register(), there won't be any references to the

Re: [PATCH 2.6.24] e1000e: add new wakeup cababilities

2008-02-01 Thread Jeff Garzik
Mitch Williams wrote: Ethtool supports wake-on-ARP and wake-on-link, and so does the hardware supported by e1000e. This patch just introduces the two. Signed-off-by: Mitch Williams [EMAIL PROTECTED] applied -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH] PHYLIB: Add BCM5482 PHY support

2008-02-01 Thread Jeff Garzik
Nate Case wrote: This Broadcom PHY is similar to other bcm54xx devices. Signed-off-by: Nate Case [EMAIL PROTECTED] --- drivers/net/phy/broadcom.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) applied -- To unsubscribe from this list: send the line

Re: [Patch 2.6.24 1/3]S2io: Support for vlan_rx_kill_vid entry point

2008-02-01 Thread Jeff Garzik
Sreenivasa Honnur wrote: - Added s2io_vlan_rx_kill_vid entry point function for unregistering vlan. - Fix to aggregate vlan packets. IP offset is incremented by 4 bytes if the packet contains vlan header. Signed-off-by: Surjit Reang [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL

Re: [PATCH 1/3] pasemi_mac: Add support for changing mac address

2008-02-01 Thread Jeff Garzik
Olof Johansson wrote: Straightforward. It used to be hardcoded and impossible to override with ifconfig. Signed-off-by: Olof Johansson [EMAIL PROTECTED] applied 1-3 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 1/6] e1000e: make a function static

2008-02-01 Thread Jeff Garzik
applied 1-6 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] remove obsolete tokenring maintainer information

2008-02-01 Thread Jeff Garzik
Adrian Bunk wrote: - Peter's email address is bouncing - the project webpage no longer exists - neither Peter nor Mike had a single patch included in the kernel since 2.6.12-rc2 (when the git history begins) Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- MAINTAINERS | 23

Re: [PATCH 1/5] ehea: fix ehea.h checkpatch complaints

2008-02-01 Thread Jeff Garzik
Jeff Garzik wrote: Doug Maxey wrote: Cc: Jan-Bernd Themann [EMAIL PROTECTED] Signed-off-by: Doug Maxey [EMAIL PROTECTED] --- drivers/net/ehea/ehea.h|3 +++ drivers/net/ehea/ehea_hw.h |8 2 files changed, 7 insertions(+), 4 deletions(-) applied 1-5 BTW please do not

[BUILD FAILURE]2.6.24-git10 section type conflict

2008-02-01 Thread Sudhir Kumar
Hi All, I found the following kernel build failure for 2.6.24-git10 on my machine: CC [M] drivers/scsi/lpfc/lpfc_attr.o drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: *** [drivers/net/sis190.o] Error 1 make[1]: *** [drivers/net] Error 2 make[1]: ***

RE: [PATCH] Disable TSO for non standard qdiscs

2008-02-01 Thread Waskiewicz Jr, Peter P
Right - Essentially it is a usability issue: People who know how to use TSO (Peter for example) will be clueful enough to turn it on. Which means the default should be to protect the clueless and turn it off. On Andis approach: Turning TSO off at netdev registration time with a warning

Re: [BUILD FAILURE]2.6.24-git10 section type conflict

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 11:56:27PM +0530, Sudhir Kumar wrote: Hi All, I found the following kernel build failure for 2.6.24-git10 on my machine: CC [M] drivers/scsi/lpfc/lpfc_attr.o drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: ***

Re: [patch 0/7] s390: ctc patches for 2.6.25

2008-02-01 Thread Jeff Garzik
This patchset breaks git-bisect, by creating interim unbuildable states... -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: Lots of BUG eth1 code -5 qlen 0 messages in 2.6.24

2008-02-01 Thread Waskiewicz Jr, Peter P
I've changed the -EIO into NETDEV_TX_BUSY and so far I can't trigger the bug anymore. It was quite easy to trigger within minutes with rsync, but I can't trigger it anymore. Should I send a patch, and if so: to who? The tulip/xircom_cb driver seems to be orphaned. Perhaps Jeff Garzik is a

Re: Typo in net/netfilter/xt_iprange.c (git tree)

2008-02-01 Thread Frans Pop
Forward to netdev list. --- Forwarded message (begin) Subject: Typo in net/netfilter/xt_iprange.c (git tree) From: Jiri Moravec ... Date: Fri, 01 Feb 2008 15:50:15 +0100 Function iprange_mt4 belong to IPv4 family - AF_INET. Right? .name = iprange, .revision =

Re: [PATCH 4/5] ehea: fix phyp checkpatch complaints

2008-02-01 Thread Scott Wood
On Thu, Jan 31, 2008 at 08:20:50PM -0600, Doug Maxey wrote: /* input param R5 */ -#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11) -#define H_ALL_RES_QP_QPP EHEA_BMASK_IBM(12, 12) -#define H_ALL_RES_QP_RQR EHEA_BMASK_IBM(13, 15) -#define H_ALL_RES_QP_EQEG

Re: [RFC PATCH]: TCP + SACK + skb processing latency

2008-02-01 Thread Ilpo Järvinen
On Fri, 1 Feb 2008, Ilpo Järvinen wrote: @@ -1322,6 +1324,206 @@ static int tcp_sacktag_one(struct sk_buff *skb, struct sock *sk, return flag; } +/* Attempts to shift up to shiftlen worth of bytes from prev to skb. + * Returns number bytes shifted. + * + * TODO: in case the

Re: e1000 full-duplex TCP performance well below wire speed

2008-02-01 Thread Carsten Aulbert
Hi all Rick Jones wrote: 2) use the aforementioned burst TCP_RR test. This is then a single netperf with data flowing both ways on a single connection so no issue of skew, but perhaps an issue of being one connection and so one process on each end. Since our major gaol is to establish a

R8101 driver link issue

2008-02-01 Thread Switact - Thomas Roes
L.S. I'm using linux primaliry through Novell ZEN as part of it's imaging system. A standard problem is arrival of new network cards. Procedures to add new drivers to the boot image are well documented. Recently I got problems with a new motherbord using the Realtek RTL8101E PCI Express

[PATCH 3/3] Generic HDLC - use random_ether_addr()

2008-02-01 Thread Krzysztof Halasa
Generic HDLC now uses random_ether_addr() for generating MAC addresse for Ethernet-alike interfaces. Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED] diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c index 071a64c..7926842 100644 --- a/drivers/net/wan/hdlc_fr.c +++

Re: [PATCH] Disable TSO for non standard qdiscs

2008-02-01 Thread Jarek Poplawski
On Fri, Feb 01, 2008 at 01:28:15AM -0800, Waskiewicz Jr, Peter P wrote: ... The TCP layer will generate TSO packets based on the kernel socket features associated with the flow. So if you have two devices, one supporting TSO, the other not, then the flows associated with the non-TSO device

Re: [PATCH] Disable TSO for non standard qdiscs

2008-02-01 Thread Rick Jones
Does this also imply that JumboFrames interacts badly with these qdiscs? Or IPoIB with its 65000ish byte MTU? Correct. Of course it is always relative to the link speed. So if your link is 10x faster and your packets 10x bigger you can get similarly smooth shaping. If the later-in-thread

[PATCH 2/3] Generic HDLC - remove now unneeded hdlc_device_desc

2008-02-01 Thread Krzysztof Halasa
Removes now unneeded struct hdlc_device_desc Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED] diff --git a/drivers/net/wan/hdlc.c b/drivers/net/wan/hdlc.c index d553e6f..39951d0 100644 --- a/drivers/net/wan/hdlc.c +++ b/drivers/net/wan/hdlc.c @@ -1,7 +1,7 @@ /* * Generic HDLC support

[WAN] Generic HDLC - three patches

2008-02-01 Thread Krzysztof Halasa
Hi Jeff, Three patches - the first one fixes kernel panic in Frame Relay mode (regression present in 2.6.23 and 2.6.24, noticed only recently). The second one removes now unneeded struct proliferation. The third one - Ethernet encapsulations now use random_ether_addr() instead of my old

[PATCH 1/3] Generic HDLC - fix kernel panic

2008-02-01 Thread Krzysztof Halasa
Fixes kernel panic in Frame Relay mode Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED] diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c index 7926842..327b218 100644 --- a/drivers/net/wan/hdlc_fr.c +++ b/drivers/net/wan/hdlc_fr.c @@ -135,6 +135,10 @@ typedef struct

[PATCH 5/5] [IPV6]: Reorg struct ifmcaddr6 to save some bytes

2008-02-01 Thread acme
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] /home/acme/git/net-2.6/net/ipv6/mcast.c: struct ifmcaddr6 | -8 1 struct changed igmp6_group_dropped | -6 add_grec | -3 mld_ifc_timer_expire | -18 ip6_mc_add_src | -3 ip6_mc_del_src | -3

[PATCH 2/5] [INET6]: Reorganize struct inet6_dev to save 8 bytes

2008-02-01 Thread acme
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] And make it a multiple of a 64 bytes, reducing cacheline trashing: Before: [EMAIL PROTECTED] net-2.6]$ pahole -C inet6_dev net/dccp/ipv6.o struct inet6_dev { SNIP long unsigned int mc_maxdelay; /*48 8 */

[PATCH 3/5] [DCCP]: Reorganize struct dccp_sock to save 8 bytes

2008-02-01 Thread acme
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] /home/acme/git/net-2.6/net/dccp/ipv6.c: struct dccp_sock | -8 struct dccp6_sock | -8 2 structs changed Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- include/linux/dccp.h |2 +- 1 files changed, 1 insertions(+), 1

[PATCHES 0/5]: Add hashinfo member to struct proto and get net/ structs back on a diet

2008-02-01 Thread acme
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25 There are many more structs that have holes, they seem to crop up, even on DCCP! People should use some paholing 8-) I'll prepare another round after carnival, and also

[PATCH 4/5] [INET_TIMEWAIT_SOCK]: Reorganize struct inet_timewait_sock to save some bytes

2008-02-01 Thread acme
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] /home/acme/git/net-2.6/net/ipv6/tcp_ipv6.c: struct inet_timewait_sock | -8 struct tcp_timewait_sock | -8 2 structs changed tcp_v6_rcv| -6 1 function changed, 6 bytes removed, diff: -6 Signed-off-by: Arnaldo Carvalho

[PATCH 1/5] [SOCK] proto: Add hashinfo member to struct proto

2008-02-01 Thread acme
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] This way we can remove TCP and DCCP specific versions of sk-sk_prot-get_port: both v4 and v6 use inet_csk_get_port sk-sk_prot-hash: inet_hash is directly used, only v6 need a specific version to deal with mapped sockets

Re: [PATCH] Disable TSO for non standard qdiscs

2008-02-01 Thread Jarek Poplawski
jamal wrote, On 02/01/2008 01:06 PM: On Fri, 2008-01-02 at 10:56 +0100, Patrick McHardy wrote: We don't want to disable TSO for cases where it makes sense, but who is using TBF on 10GbE? The point is that most users of qdiscs which are incapable of dealing with TSO without hacks or special

pull request: wireless-2.6 'fixes' 2008-02-01

2008-02-01 Thread John W. Linville
Dave, Here are some more fixes suitable for 2.6.25. Also there is a patch that includes the mac80211 alignment warning as a configurable option, which should stop it from annoying normal users. Let me know if there are problems! Thanks, John --- Individual patches are available here:

Re: R8101 driver link issue

2008-02-01 Thread Francois Romieu
Switact - Thomas Roes [EMAIL PROTECTED] : [...] Recently I got problems with a new motherbord using the Realtek RTL8101E PCI Express Fast Ethernet controller. This card is recognised by the r8169 driver but it always gives me link down. Can you send the output of 'lspci -vvxxx' and the

Re: Still oopsing in nf_nat_move_storage()

2008-02-01 Thread Chuck Ebbert
On 01/31/2008 01:03 PM, Chuck Ebbert wrote: On 01/29/2008 12:18 PM, Patrick McHardy wrote: Chuck Ebbert wrote: nf_nat_move_storage(): /usr/src/debug/kernel-2.6.23/linux-2.6.23.i686/net/ipv4/netfilter/nf_nat_core.c:612 87: f7 47 64 80 01 00 00testl $0x180,0x64(%edi)

Re: [PATCH 1/1]: Add support for aes-ctr to ipsec

2008-02-01 Thread Herbert Xu
On Thu, Jan 31, 2008 at 10:59:28AM -0600, Joy Latten wrote: Very sorry, re-posting as first patch was incomplete. The below patch allows IPsec to use CTR mode with AES encryption algorithm. Tested this using setkey in ipsec-tools. regards, Joy Signed-off-by: Joy Latten [EMAIL

[PATCH 1/8] ixgbe: remove obsolete irq_sem, add driver state checking code

2008-02-01 Thread Auke Kok
From: Ayyappan Veeraiyan [EMAIL PROTECTED] After testing we confirmed that the irq_sem can safely be removed from ixgbe. Add strict state checking code to various ethtool parts to properly protect against races between various driver reset paths. Signed-off-by: Ayyappan Veeraiyan [EMAIL

[PATCH 2/8] ixbge: remove TX lock and redo TX accounting.

2008-02-01 Thread Auke Kok
From: Ayyappan Veeraiyan [EMAIL PROTECTED] This ports Herbert Xu's maybe_stop_tx code and removes the tx_lock which is not needed. Signed-off-by: Ayyappan Veeraiyan [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/ixgbe/ixgbe.h |2 -

[PATCH 4/8] ixgbe: Fix pause code for ethtool

2008-02-01 Thread Auke Kok
From: Ayyappan Veeraiyan [EMAIL PROTECTED] Signed-off-by: Ayyappan Veeraiyan [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/ixgbe/ixgbe_ethtool.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c

[PATCH 5/8] ixgbe: Fix FW init/release, make this code a function

2008-02-01 Thread Auke Kok
From: Ayyappan Veeraiyan [EMAIL PROTECTED] A gap was left in the FW release/grab code in up/down path. Fix it by making the release/grab code a function and calling it in appropriate locations. Signed-off-by: Ayyappan Veeraiyan [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] ---

[PATCH 6/8] ixgbe: properly return CHECKSUM_NONE, cleanup csum code

2008-02-01 Thread Auke Kok
From: Ayyappan Veeraiyan [EMAIL PROTECTED] We were not returning CHECKSUM_NONE in a lot of cases which is wrong. Move common exit points in this function and error code up before the actual work in this function. Signed-off-by: Ayyappan Veeraiyan [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL

[PATCH 3/8] ixbge: Make ethtool code account for media types

2008-02-01 Thread Auke Kok
From: Ayyappan Veeraiyan [EMAIL PROTECTED] The i82598 can support various media types but this ethtool code only was coded for fiber just yet. Signed-off-by: Ayyappan Veeraiyan [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/ixgbe/ixgbe_ethtool.c | 52

[PATCH 7/8] ixgbe: fix several counter register errata

2008-02-01 Thread Auke Kok
From: Ayyappan Veeraiyan [EMAIL PROTECTED] Several counters behave differently on 82598 causing them to display incorrect values. Adjust the accounting so the reported numbers make sense and do not double count or represent the wrong item. Signed-off-by: Ayyappan Veeraiyan [EMAIL PROTECTED]

[PATCH 8/8] ixgbe: add real-time traffic counters

2008-02-01 Thread Auke Kok
From: Ayyappan Veeraiyan [EMAIL PROTECTED] Just like our other drivers before we can switch ixgbe to provide real-time packet/byte counters to the stack easily. Signed-off-by: Ayyappan Veeraiyan [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/ixgbe/ixgbe_main.c |

why does DCCP SO_REUSEADDR have to be SOL_DCCP?

2008-02-01 Thread Rick Jones
Hi - I'm tweaking the netperf omni tests to be able to run over DCCP. I've run across a not-unorecedented problem with getaddrinfo() not groking either SOCK_DCCP or IPPROTO_DCCP in the hints, and that I can more or less live with - I had to do a kludge for getaddrinfo() for IPPROTO_SCTP

linux-2.6.24 compile error in drivers/net/b44.c

2008-02-01 Thread Li Zefan
drivers/net/b44.c: In function 'b44_remove_one': drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' make[2]: *** [drivers/net/b44.o] Error 1 make[1]: *** [drivers/net] Error 2 I think it is caused by: CONFIG_SSB_PCIHOST=n CONFIG_B44=y -- To

RE: [PATCH] Disable TSO for non standard qdiscs

2008-02-01 Thread Waskiewicz Jr, Peter P
I totally disagree with these POVs: - 10G cards should be treated by default as 10G cards - not DSL modems, and common users shouldn't have to read any warnings or configs to see this. - tc with TBF or HTB are professional tools; there should be added some warnings to manuals.

Re: why does DCCP SO_REUSEADDR have to be SOL_DCCP?

2008-02-01 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 01, 2008 at 05:42:23PM -0800, Rick Jones escreveu: Hi - I'm tweaking the netperf omni tests to be able to run over DCCP. I've run across a not-unorecedented problem with getaddrinfo() not groking either SOCK_DCCP or IPPROTO_DCCP in the hints, and that I can more or less live

Re: why does DCCP SO_REUSEADDR have to be SOL_DCCP?

2008-02-01 Thread Arnaldo Carvalho de Melo
Em Sat, Feb 02, 2008 at 12:52:59AM -0200, Arnaldo Carvalho de Melo escreveu: If instead you pass SOL_DCCP we'll go down the rabbit hole till do_dccp_setsockopt() and SO_REUSEADDR, that is equal to 2, will be interpreted as DCCP_SOCKOPT_SERVICE, that is also equal to 2, so you'll be setting the

Re: [PATCH] Disable TSO for non standard qdiscs

2008-02-01 Thread Andi Kleen
On Fri, Feb 01, 2008 at 01:58:30PM -0800, Rick Jones wrote: Does this also imply that JumboFrames interacts badly with these qdiscs? Or IPoIB with its 65000ish byte MTU? Correct. Of course it is always relative to the link speed. So if your link is 10x faster and your packets 10x bigger

Re: [Bugme-new] [Bug 9873] New: BUG at net/ipv4/icmp.c:874

2008-02-01 Thread Andrew Morton
On Fri, 1 Feb 2008 17:21:34 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9873 Summary: BUG at net/ipv4/icmp.c:874 Product: Networking Version: 2.5 KernelVersion: 2.6.24-06481-gaa62999 Platform: All

Re: [PATCH 4/5] ehea: fix phyp checkpatch complaints

2008-02-01 Thread Doug Maxey
On Fri, 01 Feb 2008 13:23:45 CST, Scott Wood wrote: On Thu, Jan 31, 2008 at 08:20:50PM -0600, Doug Maxey wrote: /* input param R5 */ -#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11) ... +#define H_ALL_RES_QP_EQPOEHEA_BMASK_IBM(9, 11) ... This was better the way it was

  1   2   >