Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-29 Thread Jiri Pirko
Thu, May 28, 2015 at 05:35:05PM CEST, john.fastab...@gmail.com wrote: On 05/28/2015 02:42 AM, Jiri Pirko wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Date: Sun, 17 May 2015 16:42:05 -0700 On most systems where you can offload

Re: [PATCH net-next] bpf: allow BPF programs access skb-skb_iif and skb-dev-ifindex fields

2015-05-29 Thread Daniel Borkmann
On 05/29/2015 05:43 AM, David Miller wrote: From: Alexei Starovoitov a...@plumgrid.com Date: Thu, 28 May 2015 20:40:44 -0700 ... btw, Daniel, your ack appeared on the mailing list, but didn't make it into patchwork... Same issue as I was having. I noticed when I send email via gmail web

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-29 Thread Jiri Pirko
Thu, May 21, 2015 at 07:46:54AM CEST, sfel...@gmail.com wrote: On Tue, May 19, 2015 at 1:28 PM, David Miller da...@davemloft.net wrote: From: Andy Gospodarek go...@cumulusnetworks.com Date: Tue, 19 May 2015 15:47:32 -0400 Are you actually saying that if users complain loudly enough about the

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-29 Thread Jiri Pirko
Thu, May 28, 2015 at 05:40:11PM CEST, sfel...@gmail.com wrote: On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko j...@resnulli.us wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Date: Sun, 17 May 2015 16:42:05 -0700 On most systems

Re: Possible issue in iproute2 package

2015-05-29 Thread Vadim Kochan
Hi Jose, On Thu, May 28, 2015 at 09:12:15PM +, Guzman Mosqueda, Jose R wrote: Hi all I'm Jose Guzman from a security team at Intel. We're using iproute2 in a GNU-Linux project and I'm analyzing the code to try to find possible issues/gaps/risks. Since I'm not too familiar with the

Re: [PATCH 2/4] netfilter: default CONFIG_NETFILTER_INGRESS to y

2015-05-29 Thread Jan Engelhardt
On Friday 2015-05-29 01:44, Pablo Neira Ayuso wrote: Useful to compile-test all options. --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -3,6 +3,7 @@ menu Core Netfilter Configuration config NETFILTER_INGRESS bool Netfilter ingress support + default y select

RE: [Xen-devel] [RFC PATCH 00/13] Persistent grant maps for xen net drivers

2015-05-29 Thread Yuzhou (C)
Hi, About rx zerocopy, I have a question: If some application make a socket, then listen and accept, the client sends packets to it, but it doesn't recv from this socket right now, all persistent grant page would be in used. So other application cannot receive any packets. Is

pull-request: mac80211-next 2015-05-29

2015-05-29 Thread Johannes Berg
Hi Dave, It's been a while since I sent anything for -next, but with the merge window getting closer I wanted to send a few more things, mostly fixes. Of course I expect that tomorrow somebody will send an important fix, but hey :-) johannes The following changes since commit

[PATCH net 1/1] sfc: free multiple Rx buffers when required

2015-05-29 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com When Rx packet data must be dropped, all the buffers associated with that Rx packet must be freed. Extend and rename efx_free_rx_buffer() to efx_free_rx_buffers() and loop through all the fragments. By doing so this patch fixes a possible memory leak.

[PATCH iproute2] ss: speedup resolve_service()

2015-05-29 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com Lets implement a full cache with proper hash table, memory got cheaper these days. Before : $ time ss -t | wc -l 529678 real0m22.708s user0m19.591s sys 0m2.969s After : $ time ss -t | wc -l 528291 real0m5.078s user0m4.099s sys

[RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-05-29 Thread Stephen Rothwell
Nothing in asm/io.h uses anything from vmalloc.h, so remove the include and fix up the build problems in an allmodconfig (64 bit and 32 bit) build. This may be the place where x86 builds get vmalloc.h implicitly included and that tends to hide places where vmalloc() et al are added to files but

[PATCH net-next 14/14] sfc: leak vports if a VF is assigned during PF unload

2015-05-29 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com If any VF is assigned as the PF is unloaded, do not attempt to remove its vport or the vswitch. These will be removed if the driver binds to the PF again, as an entity reset occurs during probe. A 'force' flag is added to efx_ef10_pci_sriov_disable()

[PATCH net-next 13/14] sfc: force removal of VF and vport on driver removal

2015-05-29 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com When the driver unloads, force the unbind and removal of any VFs in the host with the PF. The PF cannot remove vports and vswitches if they are still being used by a VF driver, and when unloading the sfc driver the removal order is not guaranteed, so

[PATCH net-next 12/14] sfc: do not allow VFs to be destroyed if assigned to guests

2015-05-29 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com Signed-off-by: Shradha Shah ss...@solarflare.com --- drivers/net/ethernet/sfc/ef10_sriov.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/sfc/ef10_sriov.c b/drivers/net/ethernet/sfc/ef10_sriov.c index

Re: Connection tracking and soft lockups with certain field values

2015-05-29 Thread Andrey Korolyov
On Thu, May 28, 2015 at 10:41 PM, Andrey Korolyov and...@xdel.ru wrote: Hi, I am currently playing with SYNPROXY target to optimize SYN filtering performance and by occasion found that TCP SYN packets containing port 0 can result in a soft lockup when conntrack is enabled just by itself,

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Daniel Borkmann
On 05/29/2015 01:04 PM, Eric Dumazet wrote: ... I doubt TCP_CA_NAME_MAX will ever change in the kernel : 16 bytes. Its typically cubic and less than 8 bytes. Using 8 bytes to point to a malloc(8) is a waste. Please remove the memory allocation, or store the pointer, since tcp_show_info() does

pull request: batman-adv 2015-05-29

2015-05-29 Thread Antonio Quartulli
Hello David, after quite some time of silence (mostly due to me being rather busy and not because we did not have any active development) here you have my first batch intended for net-next/linux-4.1. In this patchset you have quite some code cleanup and style fixes. A big chunk of the cleanup

Re: [PATCH 2/4] netfilter: default CONFIG_NETFILTER_INGRESS to y

2015-05-29 Thread Pablo Neira Ayuso
On Fri, May 29, 2015 at 08:19:35AM +0200, Jan Engelhardt wrote: On Friday 2015-05-29 01:44, Pablo Neira Ayuso wrote: Useful to compile-test all options. --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -3,6 +3,7 @@ menu Core Netfilter Configuration config NETFILTER_INGRESS

[PATCH net-next 06/14] sfc: display vadaptor statistics for all interfaces

2015-05-29 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com All interfaces will display vadaptor statistics, so set all the relevant bits in the stats bitmask. Only functions with the LINKCTRL flag will see other stats, including (per-port) MAC stats. The vadaptor stats are from rx_unicast to tx_overflow.

[PATCH net-next 11/14] sfc: don't update stats on VF when called in atomic context

2015-05-29 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com The ifenslave command to set up a bond runs in an atomic context, and it queries the stats on the devices that are being enslaved. A VF needs to make an MCDI call to update its stats, which is not allowed in atomic context. The releasing of the

[PATCH net-next 09/14] sfc: suppress ENOENT error messages from MC_CMD_MAC_STATS

2015-05-29 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com MC_CMD_MAC_STATS can be called on a function before a vadaptor has been created, as the kernel can call into this through ndo_get_stats/ndo_get_stats64. If MC_CMD_MAC_STATS is called before the DMA queues have been setup, so that a vadaptor has not

[PATCH net-next 07/14] sfc: DMA the VF stats only when requested

2015-05-29 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com Firmware does not support a periodic DMA of vadaptor-stats on VFs, so only update the stats buffer when stats are requested (when running ethtool -S or an ip/ifconfig command that reports stats). Signed-off-by: Shradha Shah ss...@solarflare.com ---

[PATCH net-next 08/14] sfc: update netdevice statistics to use vadaptor stats

2015-05-29 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com The netdevice statistics (in /proc/net/dev) are per-function stats so they must use the vadaptor stats. Change the use of MAC stats to vadaptor stats, and remove any statistics that can only be measured per-port. All stats that are removed will be

[PATCH net-next 04/14] sfc: add port_ prefix to MAC stats

2015-05-29 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com The MAC stats are per-port and will only be displayed on the PF with control of the link (one per physical port). Vadapter stats will also be displayed for this PF, so distinguish the MAC stats by adding a prefix of port_. Signed-off-by: Shradha Shah

[PATCH iproute2] configure: Check for libmnl

2015-05-29 Thread Vadim Kochan
From: Vadim Kochan vadi...@gmail.com Indicate existence of libmnl which is required by tipc. Signed-off-by: Vadim Kochan vadi...@gmail.com --- configure | 16 1 file changed, 16 insertions(+) diff --git a/configure b/configure index f1325df..1605464 100755 --- a/configure +++

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Daniel Borkmann
Hi Vadim, On 05/29/2015 12:30 PM, Vadim Kochan wrote: From: Vadim Kochan vadi...@gmail.com Use strdup instead of malloc, and get rid of bad strcpy. Signed-off-by: Vadim Kochan vadi...@gmail.com Please also Cc the reporter (done here), and add a: Fixes: 8250bc9ff4e5 (ss: Unify inet sockets

[PATCH 06/16] batman-adv: tvlv realloc, move error handling into if block

2015-05-29 Thread Antonio Quartulli
From: Markus Pargmann m...@pengutronix.de Instead of hiding the normal function flow inside an if block, we should just put the error handling into the if block. Signed-off-by: Markus Pargmann m...@pengutronix.de Signed-off-by: Marek Lindner mareklind...@neomailbox.ch Signed-off-by: Antonio

[PATCH 05/16] batman-adv: debugfs, avoid compiling for !DEBUG_FS

2015-05-29 Thread Antonio Quartulli
From: Markus Pargmann m...@pengutronix.de Normally the debugfs framework will return error pointer with -ENODEV for function calls when DEBUG_FS is not set. batman does not notice this error code and continues trying to create debugfs files and executes more code. We can avoid this code

[PATCH 11/16] batman-adv: Use safer default config for optional features

2015-05-29 Thread Antonio Quartulli
From: Sven Eckelmann s...@narfation.org The current default settings for optional features in batman-adv seems to be based around the idea that the user only compiles what he requires. They will automatically enabled when they are compiled in. For example the network coding part of batman-adv is

Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-05-29 Thread Ingo Molnar
* Stephen Rothwell s...@canb.auug.org.au wrote: Nothing in asm/io.h uses anything from vmalloc.h, so remove the include and fix up the build problems in an allmodconfig (64 bit and 32 bit) build. This may be the place where x86 builds get vmalloc.h implicitly included and that tends to

[PATCH 12/16] batman-adv: checkpatch - comparison to NULL could be rewritten

2015-05-29 Thread Antonio Quartulli
From: Marek Lindner mareklind...@neomailbox.ch Signed-off-by: Marek Lindner mareklind...@neomailbox.ch Signed-off-by: Antonio Quartulli anto...@meshcoding.com --- net/batman-adv/soft-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/soft-interface.c

[PATCH 02/16] batman-adv: update copyright years for 2015

2015-05-29 Thread Antonio Quartulli
From: Sven Eckelmann s...@narfation.org Signed-off-by: Sven Eckelmann s...@narfation.org Signed-off-by: Marek Lindner mareklind...@neomailbox.ch Signed-off-by: Antonio Quartulli anto...@meshcoding.com --- net/batman-adv/Makefile| 2 +- net/batman-adv/bat_algo.h | 2

[PATCH 01/16] batman-adv: Start new development cycle

2015-05-29 Thread Antonio Quartulli
From: Simon Wunderlich s...@simonwunderlich.de Signed-off-by: Simon Wunderlich s...@simonwunderlich.de Signed-off-by: Antonio Quartulli anto...@meshcoding.com --- net/batman-adv/main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/main.h

[PATCH 04/16] batman-adv: Use only queued fragments when merging

2015-05-29 Thread Antonio Quartulli
From: Sven Eckelmann s...@narfation.org The fragment queueing code now validates the total_size of each fragment, checks when enough fragments are queued to allow to merge them into a single packet and if the fragments have the correct size. Therefore, it is not required to have any other

[PATCH net-next 10/14] sfc: suppress vadaptor stats when EVB is not present

2015-05-29 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com The raw_mask array is not initialised, so it needs to be explicitly set to zero in the 'else' branch. If the EVB capability is not present, a port cannot have multiple functions so the per-port MAC stats are correct and should match the corresponding

[PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Vadim Kochan
From: Vadim Kochan vadi...@gmail.com Use strdup instead of malloc, and get rid of bad strcpy. Signed-off-by: Vadim Kochan vadi...@gmail.com --- misc/ss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 347e3a1..a719466 100644 --- a/misc/ss.c +++

Re: [Xen-devel] xen-netfront sets partial checksum at wrong offset

2015-05-29 Thread Jan Beulich
On 11.05.15 at 19:25, venkat.x.venkatsu...@oracle.com wrote: Please CC the maintainers of the driver. You can get that from 'scripts/get_maintainer.pl' I've done that for you. Thanks, Konrad. I am copying Wei too who had fixed the below problem earlier. It fixed the incorrect

Re: [Xen-devel] xen-netfront sets partial checksum at wrong offset

2015-05-29 Thread Wei Liu
On Fri, May 29, 2015 at 11:34:07AM +0100, Jan Beulich wrote: On 11.05.15 at 19:25, venkat.x.venkatsu...@oracle.com wrote: Please CC the maintainers of the driver. You can get that from 'scripts/get_maintainer.pl' I've done that for you. Thanks, Konrad. I am copying Wei too

[PATCH 16/16] batman-adv: Use common declaration order in *_send_skb_(packet|unicast)

2015-05-29 Thread Antonio Quartulli
From: Antonio Quartulli anto...@open-mesh.com Signed-off-by: Antonio Quartulli anto...@open-mesh.com Signed-off-by: Antonio Quartulli anto...@meshcoding.com --- net/batman-adv/send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c

[PATCH 07/16] batman-adv: Makefile, Sort alphabetically

2015-05-29 Thread Antonio Quartulli
From: Markus Pargmann m...@pengutronix.de The whole Makefile is sorted, just the multicast rule is not at the right position. Signed-off-by: Markus Pargmann m...@pengutronix.de Signed-off-by: Marek Lindner mareklind...@neomailbox.ch Signed-off-by: Antonio Quartulli anto...@meshcoding.com ---

[PATCH 14/16] batman-adv: iv_ogm_can_aggregate, code readability

2015-05-29 Thread Antonio Quartulli
From: Markus Pargmann m...@pengutronix.de This patch tries to increase code readability by negating the first if block and rearranging some of the other conditional blocks. This way we save an indentation level, we also save some allocation that is not necessary for one of the conditions.

[PATCH net-next 00/14] sfc: ndo_get_phys_port_id, vadaptor stats and PF unload when Vf's assigned to guest

2015-05-29 Thread Shradha Shah
This is the third and last instalment of SRIOV for EF10 patches. This patch set includes implementation of ndo_get_phys_port_id and changes to the MAC statistics code in order to support vadaptor statistics. It also includes code to deal with PF unload when Vf's are still assigned to the guest.

[PATCH net-next 01/14] sfc: Add sysfs entry for physical port

2015-05-29 Thread Shradha Shah
In the case where we have multiple functions (PFs and VFs), this sysfs entry is useful to identify the physical port corresponding to the function we are interested in. Signed-off-by: Shradha Shah ss...@solarflare.com --- drivers/net/ethernet/sfc/ef10.c | 35 ---

RE: [PATCH net-next 02/14] sfc: Add sysfs entry for flags (link control and primary)

2015-05-29 Thread David Laight
From: Shradha Shah Sent: 29 May 2015 11:01 On every adapter there will be one primary PF per adaptor and one link control PF per port. ... + return sprintf(buf, %d\n, +((efx-mcdi-fn_flags) + (1 MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_LINKCTRL)) +

Re: [Xen-devel] xen-netfront sets partial checksum at wrong offset

2015-05-29 Thread Jan Beulich
On 29.05.15 at 12:39, wei.l...@citrix.com wrote: On Fri, May 29, 2015 at 11:34:07AM +0100, Jan Beulich wrote: On 11.05.15 at 19:25, venkat.x.venkatsu...@oracle.com wrote: Please CC the maintainers of the driver. You can get that from 'scripts/get_maintainer.pl' I've done that for

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Eric Dumazet
On Fri, 2015-05-29 at 13:30 +0300, Vadim Kochan wrote: From: Vadim Kochan vadi...@gmail.com Use strdup instead of malloc, and get rid of bad strcpy. Signed-off-by: Vadim Kochan vadi...@gmail.com --- misc/ss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 15/16] batman-adv: iv_ogm_orig_update, remove unnecessary brackets

2015-05-29 Thread Antonio Quartulli
From: Markus Pargmann m...@pengutronix.de Remove these unnecessary brackets inside a condition. Signed-off-by: Markus Pargmann m...@pengutronix.de Signed-off-by: Marek Lindner mareklind...@neomailbox.ch Signed-off-by: Antonio Quartulli anto...@meshcoding.com --- net/batman-adv/bat_iv_ogm.c | 2

[PATCH 10/16] batman-adv: iv_ogm_send_to_if, declare char* as const

2015-05-29 Thread Antonio Quartulli
From: Markus Pargmann m...@pengutronix.de This string pointer is later assigned to a constant string, so it should be defined constant at the beginning. Signed-off-by: Markus Pargmann m...@pengutronix.de Signed-off-by: Marek Lindner mareklind...@neomailbox.ch Signed-off-by: Antonio Quartulli

[PATCH 09/16] batman-adv: iv_ogm_aggr_packet, bool return value

2015-05-29 Thread Antonio Quartulli
From: Markus Pargmann m...@pengutronix.de This function returns bool values, so it should be defined to return them instead of the whole int range. Signed-off-by: Markus Pargmann m...@pengutronix.de Signed-off-by: Marek Lindner mareklind...@neomailbox.ch Signed-off-by: Antonio Quartulli

[PATCH 13/16] batman-adv: checkpatch - spaces preferred around that '*'

2015-05-29 Thread Antonio Quartulli
From: Marek Lindner mareklind...@neomailbox.ch Signed-off-by: Marek Lindner mareklind...@neomailbox.ch Signed-off-by: Antonio Quartulli anto...@meshcoding.com --- net/batman-adv/main.h | 2 +- net/batman-adv/network-coding.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH 03/16] batman-adv: Check total_size when queueing fragments

2015-05-29 Thread Antonio Quartulli
From: Sven Eckelmann s...@narfation.org The fragmentation code was replaced in 610bfc6bc99bc83680d190ebc69359a05fc7f605 (batman-adv: Receive fragmented packets and merge) by an implementation which handles the queueing+merging of fragments based on their size and the total_size of the

[PATCH 08/16] batman-adv: iv_ogm_iface_enable, direct return values

2015-05-29 Thread Antonio Quartulli
From: Markus Pargmann m...@pengutronix.de Directly return error values. No need to use a return variable. Signed-off-by: Markus Pargmann m...@pengutronix.de Signed-off-by: Marek Lindner mareklind...@neomailbox.ch Signed-off-by: Antonio Quartulli anto...@meshcoding.com ---

[PATCH net-next 02/14] sfc: Add sysfs entry for flags (link control and primary)

2015-05-29 Thread Shradha Shah
On every adapter there will be one primary PF per adaptor and one link control PF per port. Signed-off-by: Shradha Shah ss...@solarflare.com --- drivers/net/ethernet/sfc/ef10.c | 62 ++--- 1 file changed, 52 insertions(+), 10 deletions(-) diff --git

[PATCH net-next 03/14] sfc: Implement ndo_gets_phys_port_id() for EF10 VFs

2015-05-29 Thread Shradha Shah
Signed-off-by: Shradha Shah ss...@solarflare.com --- drivers/net/ethernet/sfc/ef10.c | 11 +++ drivers/net/ethernet/sfc/ef10_sriov.c | 14 ++ drivers/net/ethernet/sfc/ef10_sriov.h | 3 +++ drivers/net/ethernet/sfc/efx.c| 1 +

[PATCH net-next 05/14] sfc: set the port-id when calling MC_CMD_MAC_STATS

2015-05-29 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com The port-id must be known so that the RMON level can be set for the collection of vadapter stats. Signed-off-by: Shradha Shah ss...@solarflare.com --- drivers/net/ethernet/sfc/mcdi_port.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-05-29 Thread Stephen Rothwell
Hi Ingo, On Fri, 29 May 2015 11:21:05 +0200 Ingo Molnar mi...@kernel.org wrote: Good idea. Acked-by: Ingo Molnar mi...@kernel.org Thanks. Please also test x86 allnoconfig and defconfig 32/64, that tends to unearth the remaining places. People doing randconfig testing will find the

Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-05-29 Thread Takashi Iwai
At Fri, 29 May 2015 19:18:47 +1000, Stephen Rothwell wrote: Nothing in asm/io.h uses anything from vmalloc.h, so remove the include and fix up the build problems in an allmodconfig (64 bit and 32 bit) build. This may be the place where x86 builds get vmalloc.h implicitly included and that

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Vadim Kochan
On Fri, May 29, 2015 at 04:04:05AM -0700, Eric Dumazet wrote: On Fri, 2015-05-29 at 13:30 +0300, Vadim Kochan wrote: From: Vadim Kochan vadi...@gmail.com Use strdup instead of malloc, and get rid of bad strcpy. Signed-off-by: Vadim Kochan vadi...@gmail.com --- misc/ss.c | 3 +--

[PATCH iproute2 -next] tc: {f,m}_bpf: add tail call support for parser

2015-05-29 Thread Daniel Borkmann
Kernel commit 04fd61ab36ec (bpf: allow bpf programs to tail-call other bpf programs) added support for tail calls, this patch here adds tc front end parts for the object parser to prepopulate a given eBPF prog array before the root prog is pushed down for classifier creation. The prepopulation

[PATCH iproute2] ss: do not bindly dump two families

2015-05-29 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com ss currently dumps IPv4 sockets, then IPv6 sockets from the kernel, even if -4 or -6 option was given. Filtering in user space then has to drop all sockets of wrong family. Such a waste of time... Before : $ time ss -tn -4 | wc -l 251659 real0m1.241s

Re: [PATCH net-next 02/14] sfc: Add sysfs entry for flags (link control and primary)

2015-05-29 Thread Edward Cree
On 29/05/15 11:48, David Laight wrote: From: Shradha Shah Sent: 29 May 2015 11:01 On every adapter there will be one primary PF per adaptor and one link control PF per port. ... +return sprintf(buf, %d\n, + ((efx-mcdi-fn_flags) +(1

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-29 Thread Neil Horman
On Thu, May 28, 2015 at 11:46:29AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 10:27:32AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: On Wed,

Re: [PATCH net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-05-29 Thread Toshiaki Makita
On 15/05/28 (木) 21:02, Eric Dumazet wrote: On Thu, 2015-05-28 at 20:17 +0900, Toshiaki Makita wrote: Currently packets with non-hardware-accelerated vlan cannot be handled by GRO. This causes low performance for 802.1ad and stacked vlan, as their vlan tags are currently not stripped by

Re: Fw: [Bug 99161] New: 2.6.32.66 PPC Oops in tcp_send_fin

2015-05-29 Thread Willy Tarreau
Hi Eric, On Fri, May 29, 2015 at 08:52:11AM -0700, Eric Dumazet wrote: On Fri, 2015-05-29 at 08:12 -0700, Stephen Hemminger wrote: I think 2.6.32 is so old no one will care. A few will still, but at least we must ensure the old guy finishes his days nicely :-) (...) I guess a backport went

Re: Request for advice on where to put Root Complex fix up code for downstream device

2015-05-29 Thread Bjorn Helgaas
Hi Casey, Sorry, this one slipped through and I forgot to respond earlier. On Thu, May 07, 2015 at 11:31:58PM +, Casey Leedom wrote: | From: Bjorn Helgaas [bhelg...@google.com] | Sent: Thursday, May 07, 2015 4:04 PM | | There are a lot of fixups in drivers/pci/quirks.c. For things that

Re: netlink and user namespaces

2015-05-29 Thread Eric W. Biederman
Alexander Larsson al...@redhat.com writes: Now that I'm using a non-privileged user namespace for my desktop sandboxing system all kind of network status things are breaking. The reason for this is that they use netlink to enumerated interfaces, and to verify that the replies are from the

Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo

2015-05-29 Thread Or Gerlitz
On Fri, May 29, 2015 at 6:38 PM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: Hi, - On May 29, 2015, at 11:24 AM, Or Gerlitz gerlitz...@gmail.com wrote: On Fri, May 29, 2015 at 12:37 AM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: @@ -854,7 +922,9 @@ int

RE: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Guzman Mosqueda, Jose R
Hi Daniel and Vadim Thanks for your prompt response and for the patch. Also, what about the other one? Do you think it is an issue or not? File: tc/tc_util.c Function: void print_rate(char *buf, int len, __u64 rate) Line: ~264 In the case that user inputs a high value for rate, the for loop

[PATCH net-next v2 2/3] net: systemport: rewrite bcm_sysport_rx_refill

2015-05-29 Thread Florian Fainelli
Currently, bcm_sysport_desc_rx() calls bcm_sysport_rx_refill() at the end of Rx packet processing loop, after the current Rx packet has already been passed to napi_gro_receive(). However, bcm_sysport_rx_refill() might fail to allocate a new Rx skb, thus leaving a hole on the Rx queue where no

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-29 Thread Marcelo Ricardo Leitner
On Fri, May 29, 2015 at 09:17:26AM -0400, Neil Horman wrote: On Thu, May 28, 2015 at 11:46:29AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 10:27:32AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: On Thu,

[PATCH net-next v2 0/3] net: systemport: misc. improvements

2015-05-29 Thread Florian Fainelli
Hi David, These patches are highly inspired by changes from Petri on bcmgenet, last patch is a misc fix that I had pending for a while, but is not a candidate for 'net' at this point. Changes in v2: - added Petri's reviewed-by tag for patches 1 and 2 - reworked patch 2 to remove a now stale

[PATCH net-next v2 1/3] net: systemport: Pre-calculate and utilize cb-bd_addr

2015-05-29 Thread Florian Fainelli
There is a 1:1 mapping between the software maintained control block in priv-rx_cbs and the buffer address in priv-rx_bds, such that there is no need to keep computing the buffer address when refiling a control block. Reviewed-by: Petri Gynther pgynt...@google.com Signed-off-by: Florian Fainelli

[PATCH net-next v2 3/3] net: systemport: Add a check for oversized packets

2015-05-29 Thread Florian Fainelli
Occasionnaly we may get oversized packets from the hardware which exceed the nomimal 2KiB buffer size we allocate SKBs with. Add an early check which drops the packet to avoid invoking skb_over_panic() and move on to processing the next packet. Reviewed-by: Petri Gynther pgynt...@google.com

Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo

2015-05-29 Thread Or Gerlitz
On Fri, May 29, 2015 at 12:37 AM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: @@ -854,7 +922,9 @@ int dsa_slave_create(struct dsa_switch *ds, struct device *parent, if (slave_dev == NULL) return -ENOMEM; - slave_dev-features =

Re: [RFC 0/3] DSA and Marvell 88E6352 802.1q support

2015-05-29 Thread Vivien Didelot
Hi Scott, On May 29, 2015, at 1:02 AM, Scott Feldman sfel...@gmail.com wrote: On Thu, May 28, 2015 at 2:37 PM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: This RFC is based on v4.1-rc3. It is meant to get a glance to the commits responsible to implement the necessary NDOs

[PATCH net] xen: netback: read hotplug script once at start of day.

2015-05-29 Thread Ian Campbell
When we come to tear things down in netback_remove() and generate the uevent it is possible that the xenstore directory has already been removed (details below). In such cases netback_uevent() won't be able to read the hotplug script and will write a xenstore error node. A recent change to the

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-29 Thread Jiri Pirko
Fri, May 29, 2015 at 05:12:35PM CEST, sfel...@gmail.com wrote: On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko j...@resnulli.us wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Date: Sun, 17 May 2015 16:42:05 -0700 On most systems

Re: Fw: [Bug 99161] New: 2.6.32.66 PPC Oops in tcp_send_fin

2015-05-29 Thread Eric Dumazet
On Fri, 2015-05-29 at 08:12 -0700, Stephen Hemminger wrote: I think 2.6.32 is so old no one will care. Begin forwarded message: Date: Fri, 29 May 2015 09:12:45 + From: bugzilla-dae...@bugzilla.kernel.org bugzilla-dae...@bugzilla.kernel.org To: shemmin...@linux-foundation.org

Re: Request for advice on where to put Root Complex fix up code for downstream device

2015-05-29 Thread Bjorn Helgaas
On Fri, May 29, 2015 at 11:46 AM, Casey Leedom lee...@chelsio.com wrote: Thanks Bjorn and no issues at all about the delay -- I definitely understand how busy we all are. I'll go ahead and submit a PCI Quirk. As part of this, would you like me to also commit a new PCI-E routine to find

Re: [Xen-devel] [RFC PATCH 00/13] Persistent grant maps for xen net drivers

2015-05-29 Thread Joao Martins
On 29 May 2015, at 08:53, Yuzhou (C) vitas.yuz...@huawei.com wrote: Hi, About rx zerocopy, I have a question: If some application make a socket, then listen and accept, the client sends packets to it, but it doesn't recv from this socket right now, all persistent grant page

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Eric Dumazet
On Fri, 2015-05-29 at 15:53 +0300, Vadim Kochan wrote: Thanks! Should I put you in From tag or in Signed-off-by ? Or your diff might be used from this email thread ? Don't worry, just submit the patch officially on your own ;) Thanks. -- To unsubscribe from this list: send the line

Re: [PATCH] xen: netback: fix error printf format string.

2015-05-29 Thread Wei Liu
On Fri, May 29, 2015 at 05:22:04PM +0100, Ian Campbell wrote: drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’: drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=]

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-05-29 Thread Daniel Borkmann
On 05/29/2015 06:17 PM, Guzman Mosqueda, Jose R wrote: Hi Daniel and Vadim Thanks for your prompt response and for the patch. Also, what about the other one? Do you think it is an issue or not? File: tc/tc_util.c Function: void print_rate(char *buf, int len, __u64 rate) Line: ~264 In the

Re: Hardware support for devices using the driver file,dm9000.c

2015-05-29 Thread Andrew Ruder
On 05/29/2015 09:23 AM, nick wrote: Greetings All, I am wondering if anything is still using the Davicom DM9000 driver recently as the code base states its from the late 1990s. Furthermore I see no reason to keep it around if something recent i.e. last 10 years is using it that is based

Fw: [Bug 99161] New: 2.6.32.66 PPC Oops in tcp_send_fin

2015-05-29 Thread Stephen Hemminger
I think 2.6.32 is so old no one will care. Begin forwarded message: Date: Fri, 29 May 2015 09:12:45 + From: bugzilla-dae...@bugzilla.kernel.org bugzilla-dae...@bugzilla.kernel.org To: shemmin...@linux-foundation.org shemmin...@linux-foundation.org Subject: [Bug 99161] New: 2.6.32.66 PPC

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-29 Thread Scott Feldman
On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko j...@resnulli.us wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Date: Sun, 17 May 2015 16:42:05 -0700 On most systems where you can offload routes to hardware, doing routing in

Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-05-29 Thread Stephen Rothwell
Hi Takashi, On Fri, 29 May 2015 14:43:14 +0200 Takashi Iwai ti...@suse.de wrote: For the sound bits, Acked-by: Takashi Iwai ti...@suse.de Thanks, noted. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgp0duKaM_eov.pgp Description: OpenPGP digital signature

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-29 Thread Scott Feldman
On Fri, May 29, 2015 at 12:50 AM, Jiri Pirko j...@resnulli.us wrote: Thu, May 21, 2015 at 07:46:54AM CEST, sfel...@gmail.com wrote: On Tue, May 19, 2015 at 1:28 PM, David Miller da...@davemloft.net wrote: From: Andy Gospodarek go...@cumulusnetworks.com Date: Tue, 19 May 2015 15:47:32 -0400

Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo

2015-05-29 Thread Vivien Didelot
Hi, - On May 29, 2015, at 11:24 AM, Or Gerlitz gerlitz...@gmail.com wrote: On Fri, May 29, 2015 at 12:37 AM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: @@ -854,7 +922,9 @@ int dsa_slave_create(struct dsa_switch *ds, struct device *parent, if (slave_dev == NULL)

[PATCH] xen: netback: fix error printf format string.

2015-05-29 Thread Ian Campbell
drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’: drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=] (txreq.offset~PAGE_MASK) + txreq.size); ^ txreq.offset

Re: [PATCH net] xen: netback: read hotplug script once at start of day.

2015-05-29 Thread David Vrabel
On 29/05/15 17:24, Ian Campbell wrote: --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -235,6 +235,7 @@ static int netback_remove(struct xenbus_device *dev) kobject_uevent(dev-dev.kobj, KOBJ_OFFLINE);

RE: Request for advice on where to put Root Complex fix up code for downstream device

2015-05-29 Thread Casey Leedom
Thanks Bjorn and no issues at all about the delay -- I definitely understand how busy we all are. I'll go ahead and submit a PCI Quirk. As part of this, would you like me to also commit a new PCI-E routine to find the Root Complex Port for a given PCI Device? It seem like it might prove

Re: [PATCH] xfrm6: Do not use xfrm_local_error for path MTU issues in tunnels

2015-05-29 Thread Alexander Duyck
On 05/28/2015 12:15 PM, Alexander Duyck wrote: On 05/28/2015 01:40 AM, Steffen Klassert wrote: On Thu, May 28, 2015 at 12:18:51AM -0700, Alexander Duyck wrote: On 05/27/2015 10:36 PM, Steffen Klassert wrote: On Wed, May 27, 2015 at 10:40:32AM -0700, Alexander Duyck wrote: This change makes it

RE: [PATCH 3/7] net: dsa: ar8xxx: add regmap support

2015-05-29 Thread Mathieu Olivari
Alternatively, we could have something similar to what happens for the phy in the wireless subsystems. Wireless PHYs are not registered as net_device but they can still be listed, queried or configured through netlink. Just thinking out loud here. Thanks, Mathieu -Original Message- From:

[PATCH] vti6: Add pmtu handling to vti6_xmit.

2015-05-29 Thread Alexander Duyck
From: Steffen Klassert steffen.klass...@secunet.com We currently rely on the PMTU discovery of xfrm. However if a packet is localy sent, the PMTU mechanism of xfrm tries to to local socket notification what might not work for applications like ping that don't check for this. So add pmtu handling

Re: [PATCH 0/7] net: dsa: add QCA AR8xxx switch family support\

2015-05-29 Thread Mathieu Olivari
On Fri, May 29, 2015 at 04:00:01AM +0200, Andrew Lunn wrote: FYI: I have patches which allow DSA to use two cpu interfaces. Seems to work on my DIR665 with a Marvell Switch. I will post the patches as an RFC. Andrew Does it require the switch CPU ports to support LAG or is it generic

Re: [PATCH net-next v2 2/3] net: systemport: rewrite bcm_sysport_rx_refill

2015-05-29 Thread Petri Gynther
On Fri, May 29, 2015 at 9:42 AM, Florian Fainelli f.faine...@gmail.com wrote: Currently, bcm_sysport_desc_rx() calls bcm_sysport_rx_refill() at the end of Rx packet processing loop, after the current Rx packet has already been passed to napi_gro_receive(). However, bcm_sysport_rx_refill()

Re: [PATCH 3/7] net: dsa: ar8xxx: add regmap support

2015-05-29 Thread Andrew Lunn
On Fri, May 29, 2015 at 10:36:49AM -0700, Mathieu Olivari wrote: Alternatively, we could have something similar to what happens for the phy in the wireless subsystems. Wireless PHYs are not registered as net_device but they can still be listed, queried or configured through netlink. It is a

[PATCH net] tcp: fix child sockets to use system default congestion control if not set

2015-05-29 Thread Neal Cardwell
Linux 3.17 and earlier are explicitly engineered so that if the app doesn't specifically request a CC module on a listener before the SYN arrives, then the child gets the system default CC when the connection is established. See tcp_init_congestion_control() in 3.17 or earlier, which says if no

Re: [PATCH net] net: dsa: Properly propagate errors from dsa_switch_setup_one

2015-05-29 Thread Andrew Lunn
On Fri, May 29, 2015 at 10:29:46AM -0700, Florian Fainelli wrote: While shuffling some code around, dsa_switch_setup_one() was introduced, and it was modified to return either an error code using ERR_PTR() or a NULL pointer when running out of memory or failing to setup a switch. This is a

  1   2   >