Re: e1000e: hard system lockup on Linux 4.2

On Mon, Oct 12, 2015 at 12:58:09PM +0200, Jason A. Donenfeld wrote: > > On Oct 12, 2015 8:59 AM, "Avargil, Raanan" wrote: > > > > Your analysis is correct. > > Commit 37b12910dd11d9ab969f2c310dc9160b7f3e3405 fixes the lockup issue, and > according to my last check it is

[PATCH net-next V17 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversion. Uses double nested encap attributes to represent double tagged vlan. Inner TPID encoded along with ctci in nested attributes. Signed-off-by: Thomas F

[PATCH net-next V17 0/3] openvswitch: Add support for 802.1ad

V17,V16: Implement reviewer's comments. V15: Implement reviewer comments. V14: Add outer tpid to flow_key V13: Fix incorrect encoding and decoding of netlink to/from key attributes. V12: Fix some problems and issues pointed out by reviewers. When parsing netlink attributes Ether types other

[PATCH net-next V17 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

Signed-off-by: Thomas F Herbert --- include/linux/if_vlan.h | 16 1 file changed, 16 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 67ce5bd..d2494b5 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h

[PATCH net-next V17 1/3] openvswitch: 802.1ad uapi changes.

openvswitch: Add support for 8021.AD Change the description of the VLAN tpid field. Signed-off-by: Thomas F Herbert --- include/uapi/linux/openvswitch.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH 1/3] net: wireless: rsi: Coding Spaces

Removed space before that ',' Signed-off-by: Paul McQuade --- drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 2 +- drivers/net/wireless/rsi/rsi_mgmt.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 3/3] net: wireless: b43: statics Don't init to 0

Don't turn statics to 0 or NULL Signed-off-by: Paul McQuade --- drivers/net/wireless/b43/main.c | 2 +- drivers/net/wireless/b43/phy_lp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/b43/main.c

Re: Soft lockup issue in Linux 4.1.9

On Sat, Oct 03, 2015 at 09:14:16PM +0200, Thomas D. wrote: > Hi, > > Holger Hoffstätte wrote: > > Greg, any chance you can drop this into the pending 4.1.10? Otherwise people > > will get another broken release. > > For me it looks like the request was too late, the patch is not included > in

Re: [PATCH 3.19 and earlier] fib_rules: Fix dump_rules() not to exit early

On Mon, Oct 05, 2015 at 10:29:28AM -0700, Roland Dreier wrote: > From: Roland Dreier > > Backports of 41fc014332d9 ("fib_rules: fix fib rule dumps across > multiple skbs") introduced a regression in "ip rule show" - it ends up > dumping the first rule over and over and

Re: linux 3.4.43 : kernel crash at __nf_conntrack_confirm

Hi guys, Coming back to this crash, I see something interesting in the conntrack code in linux 3.4.109 (a supported kernel version). I see that the hash table manipulations are protected by a spinlock. Also lookups/reads are protected by RCU. However allocation and deallocation of conntrack

[PATCH 2/3] net: wireless: b43: Fixed Pointer issue

Moved around pointer to avoid ERROR Signed-off-by: Paul McQuade --- drivers/net/wireless/b43/dma.h | 14 +++--- drivers/net/wireless/b43/main.c | 6 +++--- drivers/net/wireless/b43/main.h | 2 +- drivers/net/wireless/b43/xmit.h | 2 +- 4 files changed, 12

[PATCH] ipv6 route: Aggregate table getting code

These lines could be aggregated to one line because fib6_new_table() calls fib6_get_table() inside on both cases CONFIG_IPV6_MULTIPLE_TABLES is enabled or not. Signed-off-by: Masashi Honma --- net/ipv6/route.c | 11 +-- 1 file changed, 1 insertion(+), 10

Re: [PATCH 2/7] tty: Remove ASYNC_CLOSING checks in open()/hangup() methods

On Sat, Oct 10, 2015 at 04:00:52PM -0400, Peter Hurley wrote: > > Note: The ASYNC_CLOSING flag state is still maintained since several > bitrotting drivers use it for (dubious) other purposes. I think we should drop it, it's pointless and no one ever actually does anything with it. thanks,

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

On Sat, 17 Oct 2015, Andrew Lunn wrote: > > Sure, will try to debug. It looks like phydev->attached_dev is valid, but > > phydev->attached_dev->dev.of_node is NULL. > > Humm > > phydev->attached_dev is a net_device, so should be the mac. What > device is phydev->attached_dev->dev? Is it not

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

On 10/17/15 5:28 AM, Daniel Borkmann wrote: Anyway, another idea I've been brainstorming with Hannes today a bit is about the following: We register two major numbers, one for eBPF maps (X), one for eBPF progs (Y). A user can either via cmdline call something like ... mknod

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

2015-10-17 8:06 GMT-07:00 Dinh Nguyen : > On Sat, 17 Oct 2015, Dinh Nguyen wrote: > >> On Fri, 16 Oct 2015, Andrew Lunn wrote: >> >> > On Fri, Oct 16, 2015 at 05:58:41PM -0500, Dinh Nguyen wrote: >> > > On Fri, 16 Oct 2015, Andrew Lunn wrote: >> > > >> > > > Commit

Re: [PATCHv2 net] openvswitch: Scrub skb between namespaces

On 10/16/15 at 11:08am, Joe Stringer wrote: > If OVS receives a packet from another namespace, then the packet should > be scrubbed. However, people have already begun to rely on the behaviour > that skb->mark is preserved across namespaces, so retain this one field. > > This is mainly to address

[PATCH 1/2] NFC: delete null dereference

The exit label performs device_unlock(>dev);, which will fail when dev is NULL, and nfc_put_device(dev);, which is not useful when dev is NULL, so just exit the function immediately. Problem found using scripts/coccinelle/null/deref_null.cocci Signed-off-by: Julia Lawall

[PATCH 0/2] delete null dereference

These patches delete NULL dereferences, as detected by scripts/coccinelle/null/deref_null.cocci. --- drivers/media/pci/netup_unidvb/netup_unidvb_spi.c |6 ++ net/nfc/netlink.c |6 ++ 2 files changed, 4 insertions(+), 8 deletions(-) -- To

[PATCH 28/35] netfilter: make nf_queue_entry_get_refs return void

From: Florian Westphal We don't care if module is being unloaded anymore since hook unregister handling will destroy queue entries using that hook. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso ---

[PATCH 35/35] netfilter: ipv4: whitespace around operators

From: Ian Morris This patch cleanses whitespace around arithmetical operators. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/ipv4/netfilter/ipt_CLUSTERIP.c | 8

[PATCH 20/35] netfilter: ipv6: code indentation

From: Ian Morris Use tabs instead of spaces to indent code. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/ipv6/netfilter/ip6_tables.c | 4 ++--

[PATCH 18/35] netfilter: ip6_tables: label placement

From: Ian Morris Whitespace cleansing: Labels should not be indented. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/ipv6/netfilter/ip6_tables.c | 2 +- 1 file changed, 1

[PATCH 30/35] netfilter: turn NF_HOOK into an inline function

From: Arnd Bergmann A recent change to the dst_output handling caused a new warning when the call to NF_HOOK() is the only used of a local variable passed as 'dev', and CONFIG_NETFILTER is disabled: net/ipv6/ip6_output.c: In function 'ip6_output': net/ipv6/ip6_output.c:135:21:

[PATCH 34/35] netfilter: ipv4: code indentation

From: Ian Morris Use tabs instead of spaces to indent code. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/ipv4/netfilter/ip_tables.c| 6 +++---

[PATCH 33/35] netfilter: ipv4: function definition layout

From: Ian Morris Use tabs instead of spaces to indent second line of parameters in function definitions. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso ---

[PATCH 27/35] netfilter: remove hook owner refcounting

From: Florian Westphal since commit 8405a8fff3f8 ("netfilter: nf_qeueue: Drop queue entries on nf_unregister_hook") all pending queued entries are discarded. So we can simply remove all of the owner handling -- when module is removed it also needs to unregister all its hooks.

[PATCH 31/35] netfilter: ipv4: label placement

From: Ian Morris Whitespace cleansing: Labels should not be indented. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/ipv4/netfilter/arp_tables.c | 2 +-

[PATCH 03/35] netfilter: rename nfnetlink_queue_core.c to nfnetlink_queue.c

Now that we have integrated the ct glue code into nfnetlink_queue without introducing dependencies with the conntrack code. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/Makefile | 1 - net/netfilter/{nfnetlink_queue_core.c =>

[PATCH 01/35] ipvs: Don't protect ip_vs_addr_is_unicast with CONFIG_SYSCTL

From: "Eric W. Biederman" I arranged the code so that the compiler can remove the unecessary bits in ip_vs_leave when CONFIG_SYSCTL is unset, and removed an explicit CONFIG_SYSCTL. Unfortunately when rebasing my work on top of that of Alex Gartrell I missed the fact that

[PATCH 00/35] Netfilter/IPVS updates for net-next

Hi David, The following patchset contains Netfilter/IPVS updates for your net-next tree. Most relevantly, updates for the nfnetlink_log to integrate with conntrack, fixes for cttimeout and improvements for nf_queue core, they are: 1) Remove useless ifdef around static inline function in IPVS,

[PATCH 04/35] netfilter: nfnetlink_queue: use y2038 safe timestamp

The __build_packet_message function fills a nfulnl_msg_packet_timestamp structure that uses 64-bit seconds and is therefore y2038 safe, but it uses an intermediate 'struct timespec' which is not. This trivially changes the code to use 'struct timespec64' instead, to correct the result on 32-bit

[PATCH 02/35] netfilter: nfnetlink_queue: get rid of nfnetlink_queue_ct.c

The original intention was to avoid dependencies between nfnetlink_queue and conntrack without ifdef pollution. However, we can achieve this by moving the conntrack dependent code into ctnetlink and keep some glue code to access the nfq_ct indirection from nfqueue. After this patch, the nfq_ct

Re: [PATCH v2 net-next] RDS: fix rds-ping deadlock over TCP transport

On 10/16/2015 10:13 PM, Santosh Shilimkar wrote: But because of above recursive lock hang with RDS TCP, the send work from rds_send_pong() needs to deferred to worker to avoid lock up. Given RDS ping is more of connectivity test than performance critical path, its should be ok even for

[PATCH 11/35] ipvs: Remove possibly unused variables from ip_vs_conn_net_{init,cleanup}

From: Simon Horman If CONFIG_PROC_FS is undefined then the arguments of proc_create() and remove_proc_entry() are unused. As a result the net variables of ip_vs_conn_net_{init,cleanup} are unused. net/netfilter/ipvs//ip_vs_conn.c: In function ‘ip_vs_conn_net_init’:

Re: [PATCHv2 net 3/3] openvswitch: Serialize nested ct actions if provided

On 10/16/15 at 11:08am, Joe Stringer wrote: > If userspace provides a ct action with no nested mark or label, then the > storage for these fields is zeroed. Later when actions are requested, > such zeroed fields are serialized even though userspace didn't > originally specify them. Fix the

Re: [PATCHv2 net 2/3] openvswitch: Treat IP_CT_RELATED as new

On 10/16/15 at 11:08am, Joe Stringer wrote: > New, related connections are marked as such as part of ovs_ct_lookup(), > but they are not marked as "new" if the commit flag is used. Make this > consistent by treating IP_CT_RELATED as new as well. > > Reported-by: Jarno Rajahalme

[PATCH 06/35] netfilter: nfnetlink_queue: rename related to nfqueue attaching conntrack info

From: Ken-ichirou MATSUZAWA The idea of this series of patch is to attach conntrack information to nflog like nfqueue has already done. nfqueue conntrack info attaching basis is generic, rename those names to generic one, glue. Signed-off-by: Ken-ichirou MATSUZAWA

[PATCH 13/35] netfilter: conntrack: fix crash on timeout object removal

The object and module refcounts are updated for each conntrack template, however, if we delete the iptables rules and we flush the timeout database, we may end up with invalid references to timeout object that are just gone. Resolve this problem by setting the timeout reference to NULL when the

[PATCH 15/35] netfilter: bridge: avoid unused label warning

From: Arnd Bergmann With the ARM mini2440_defconfig, the bridge netfilter code gets built with both CONFIG_NF_DEFRAG_IPV4 and CONFIG_NF_DEFRAG_IPV6 disabled, which leads to a harmless gcc warning: net/bridge/br_netfilter_hooks.c: In function 'br_nf_dev_queue_xmit':

[PATCH 12/35] netfilter: xt_CT: don't put back reference to timeout policy object

On success, this shouldn't put back the timeout policy object, otherwise we may have module refcount overflow and we allow deletion of timeout that are still in use. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/xt_CT.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH 10/35] ipvs: Remove possibly unused variable from ip_vs_out

From: David Ahern Eric's net namespace changes in 1b75097dd7a26 leaves net unreferenced if CONFIG_IP_VS_IPV6 is not enabled: ../net/netfilter/ipvs/ip_vs_core.c: In function ‘ip_vs_out’: ../net/netfilter/ipvs/ip_vs_core.c:1177:14: warning: unused variable ‘net’

[PATCH 22/35] netfilter: ip6_tables: ternary operator layout

From: Ian Morris Correct whitespace layout of ternary operators in the netfilter-ipv6 code. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/ipv6/netfilter/ip6_tables.c | 4

[PATCH 21/35] netfilter: ipv6: whitespace around operators

From: Ian Morris This patch cleanses whitespace around arithmetical operators. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c | 4

[PATCH 24/35] netfilter: ipv6: pointer cast layout

From: Ian Morris Correct whitespace layout of a pointer casting. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/ipv6/netfilter/nf_conntrack_reasm.c | 2 +- 1 file changed,

[PATCH 07/35] netfilter: Kconfig rename QUEUE_CT to GLUE_CT

From: Ken-ichirou MATSUZAWA Conntrack information attaching infrastructure is now generic and update it's name to use `glue' in previous patch. This patch updates Kconfig symbol name and adding NF_CT_NETLINK dependency. Signed-off-by: Ken-ichirou MATSUZAWA

[PATCH 16/35] netfilter: nfnetlink_log: autoload nf_conntrack_netlink module NFQA_CFG_F_CONNTRACK config flag

From: Ken-ichirou MATSUZAWA This patch enables to load nf_conntrack_netlink module if NFULNL_CFG_F_CONNTRACK config flag is specified. Signed-off-by: Ken-ichirou MATSUZAWA Signed-off-by: Pablo Neira Ayuso ---

[PATCH 26/35] netfilter: nfnetlink_log: validate dependencies to avoid breaking atomicity

From: Pablo Neira Check that dependencies are fulfilled before updating the logger instance, otherwise we can leave things in intermediate state on errors in nfulnl_recv_config(). [ Ken-ichirou reports that this is also fixing missing instance refcnt drop on error

[PATCH 25/35] netfilter: nfnetlink_log: consolidate check for instance in nfulnl_recv_config()

This patch consolidates the check for valid logger instance once we have passed the command handling: The config message that we receive may contain the following info: 1) Command only: We always get a valid instance pointer if we just created it. In case that the instance is being destroyed

[PATCH 14/35] nfnetlink_cttimeout: add rcu_barrier() on module removal

Make sure kfree_rcu() released objects before leaving the module removal exit path. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nfnetlink_cttimeout.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/nfnetlink_cttimeout.c

Re: [PATCH net] tunnels: Don't require remote endpoint or ID during creation.

On 10/16/15 at 04:36pm, Jesse Gross wrote: > Before lightweight tunnels existed, it really didn't make sense to > create a tunnel that was not fully specified, such as without a > destination IP address - the resulting packets would go nowhere. > However, with lightweight tunnels, the opposite is

Re: [PATCHv2 net 1/3] openvswitch: Reject ct_state masks for unknown bits

On 10/16/15 at 11:08am, Joe Stringer wrote: > Currently, 0-bits are generated in ct_state where the bit position is > undefined, and matches are accepted on these bit-positions. If userspace > requests to match the 0-value for this bit then it may expect only a > subset of traffic to match this

Re: [PATCH v3] netfilter: ipset: Fix sleeping memory allocation in atomic context

On Fri, Oct 16, 2015 at 01:58:55PM +0200, Jozsef Kadlecsik wrote: > The patch is applied in the ipset package tree. Thanks! Applied to the nf tree, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH 05/35] netfilter: remove dead code

From: Flavio Leitner Remove __nf_conntrack_find() from headers. Fixes: dcd93ed4cd1 ("netfilter: nf_conntrack: remove dead code") Signed-off-by: Flavio Leitner Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_conntrack.h

[PATCH 19/35] netfilter: ip6_tables: function definition layout

From: Ian Morris Use tabs instead of spaces to indent second line of parameters in function definitions. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso ---

[PATCH 09/35] netfilter: nfnetlink_log: allow to attach conntrack

From: Ken-ichirou MATSUZAWA This patch enables to include the conntrack information together with the packet that is sent to user-space via NFLOG, then a user-space program can acquire NATed information by this NFULA_CT attribute. Including the conntrack information is

[PATCH 29/35] netfilter: nf_queue: remove rcu_read_lock calls

From: Florian Westphal All verdict handlers make use of the nfnetlink .call_rcu callback so rcu readlock is already held. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_queue.c | 16

[PATCH 32/35] netfilter: ipv4: ternary operator layout

From: Ian Morris Correct whitespace layout of ternary operators in the netfilter-ipv4 code. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/ipv4/netfilter/arp_tables.c | 4

[PATCH 23/35] netfilter: ip6_tables: improve if statements

From: Ian Morris Correct whitespace layout of if statements. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/ipv6/netfilter/ip6_tables.c | 6 +++--- 1 file changed, 3

[PATCH 08/35] netfilter: ctnetlink: add const qualifier to nfnl_hook.get_ct

From: Ken-ichirou MATSUZAWA get_ct as is and will not update its skb argument, and users of nfnl_ct_hook is currently only nfqueue, we can add const qualifier. Signed-off-by: Ken-ichirou MATSUZAWA --- include/linux/netfilter.h| 2 +-

[PATCH 17/35] netfilter: nfqueue: don't use prev pointer

From: Florian Westphal Usage of -prev seems buggy. While packet was out our hook cannot be removed but we have no way to know if the previous one is still valid. So better not use ->prev at all. Since NF_REPEAT just asks to invoke same hook function again, just do so, and

Re: [PATCH net] net: add pfmemalloc check in sk_add_backlog()

From: Eric Dumazet Date: Fri, 16 Oct 2015 08:38:38 -0700 > On Tue, 2015-09-29 at 21:56 -0700, David Miller wrote: >> From: Eric Dumazet >> Date: Tue, 29 Sep 2015 18:52:25 -0700 >> >> > From: Eric Dumazet >> > >> > Greg

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

On 10/17/2015 04:43 AM, Alexei Starovoitov wrote: On 10/16/15 4:44 PM, Eric W. Biederman wrote: Alexei Starovoitov writes: We can argue about api for 2nd, whether it's mount with fd=1234 string or else, but for the first mount style doesn't make sense. Why does mount not

Re: [PATCH 00/35] Netfilter/IPVS updates for net-next

On Sat, Oct 17, 2015 at 06:07:43AM -0700, David Miller wrote: > From: Pablo Neira Ayuso > Date: Sat, 17 Oct 2015 13:32:35 +0200 > > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git HEAD > > Pablo, this gives merge conflicts. > > This is the second or

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

On Fri, 16 Oct 2015, Andrew Lunn wrote: > On Fri, Oct 16, 2015 at 05:58:41PM -0500, Dinh Nguyen wrote: > > On Fri, 16 Oct 2015, Andrew Lunn wrote: > > > > > Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not > > > the bus' parent." broke finding PHY properties in the MAC

Re: [net-next 01/17] i40e: Lock for VSI's MAC filter list

From: Jeff Kirsher Date: Fri, 16 Oct 2015 22:28:15 -0700 > > + WARN(!spin_is_locked(>mac_filter_list_lock), > + "Missing mac_filter_list_lock\n"); > + spin_is_locked() is, generally speaking, completely inappropriate to use in assertions. Because, on

Re: [PATCH 00/35] Netfilter/IPVS updates for net-next

From: Pablo Neira Ayuso Date: Sat, 17 Oct 2015 13:32:35 +0200 > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git HEAD Pablo, this gives merge conflicts. This is the second or third time in the past few pulls from you that there have been merge conflicts,

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

On 10/17/2015 2:54 AM, Andrew Lunn wrote: Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not the bus' parent." broke finding PHY properties in the MAC device tree You probably forgot to run checkpatch.pl on this patch, else it would have complained about the commit

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

On 10/17/2015 2:54 AM, Andrew Lunn wrote: Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not the bus' parent." broke finding PHY properties in the MAC device tree You probably forgot to run checkpatch.pl on this patch, else it would have complained about the commit

[PATCH] intel: i40e: fix confused code

This code is pretty confused. The variable name 'bytes_not_copied' clearly indicates that the programmer knew the semantics of copy_{to,from}_user, but then the return value is checked for being negative and used as a -Exxx return value. I'm not sure this is the proper fix, but at least we get

[PATCH] net: wireless: rt2x00: Fixed Spacing issues

Removed empty spaces before/after parenthesis Signed-off-by: Paul McQuade --- drivers/net/wireless/rt2x00/rt61pci.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/rt2x00/rt61pci.h

[PATCH nf-next 3/4] netfilter: ipv6: in-place replacement of last skb

openvswitch attempts to morph the reassembled skb with the currently processed one. But this looks broken -- the currently processed skb is part of the reassembled skbs frag_list. IOW, we morph an element of reasms frag_list into reasm itself, then free said frag_list element. This allows

[PATCH nf-next 1/4] netfilter: ipv6: remove extra clone/free operations

commit 6aafeef03b9d9ecf ("netfilter: push reasm skb through instead of original frag skbs") changed ipv6 defrag to not use the original skbs anymore. So rather than keeping the original skbs around just to discard them afterwards just use the original skbs directly for the fraglist of the newly

[PATCH nf-next 4/4] netfilter: ipv6: avoid nf_iterate recursion

The previous patch changed nf_ct_frag6_gather() to morph reassembled skb with the previous one. This means that the return value is always NULL or the skb argument. So change it to an err value. Instead of invoking NF_HOOK recursively with threshold to skip already-called hooks we can now just

[PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag

[ CC netdev since patch #2 isn't nf-specific. Dave, if you want I can resubmit that one after the next nf-pull request; let me know if you would prefer that ]. Openvswitch seems broken wrt. to defragmentation, it doesn't call nf_ct_frag6_consume_orig to free the original fragments.

[PATCH nf-next 2/4] inet: kill obsolete skb_free op

The only user was removed in preceeding commit. Signed-off-by: Florian Westphal --- include/net/inet_frag.h | 1 - net/ieee802154/6lowpan/reassembly.c | 1 - net/ipv4/inet_fragment.c| 10 +- net/ipv4/ip_fragment.c | 1 -

[PATCH] net: wireless: rt2x00: statics code style

Do not initialise statics to 0 or NULL Also use tabs where possible Signed-off-by: Paul McQuade --- drivers/net/wireless/rt2x00/rt61pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/rt2x00/rt61pci.c

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

> Sure, will try to debug. It looks like phydev->attached_dev is valid, but > phydev->attached_dev->dev.of_node is NULL. Humm phydev->attached_dev is a net_device, so should be the mac. What device is phydev->attached_dev->dev? Is it not the dev embedded in the platform_device passed to

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

On Sat, 17 Oct 2015, Dinh Nguyen wrote: > On Fri, 16 Oct 2015, Andrew Lunn wrote: > > > On Fri, Oct 16, 2015 at 05:58:41PM -0500, Dinh Nguyen wrote: > > > On Fri, 16 Oct 2015, Andrew Lunn wrote: > > > > > > > Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not > > > > the

Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device

> I've also tried creating a separate phy node in the DTS and have the EMAC > point the PHY with a 'phy = <>;', but that also didn't seem to work with > your patch. Do you have the phy node as a child of the mdio node? Picking a random example arch/arm/boot/dts/kirkwood-rd88f6192.dts {

Re: [PATCH net] net: add pfmemalloc check in sk_add_backlog()

On Sat, 2015-10-17 at 05:02 -0700, David Miller wrote: > Sorry I've been meaning to go back and apply it properly. I'll do that right > now... > > There, done and properly queued up for -stable too. :) > Perfect, thanks a lot David. -- To unsubscribe from this list: send the line

[PATCH 1/3] net: wireless: rt2x00: Space issue

Removed empty spaces before/after parenthesis Signed-off-by: Paul McQuade --- drivers/net/wireless/rt2x00/rt2x00.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/rt2x00/rt2x00.h

[PATCH 2/3] net: wireless: rt2x00: Pointer issue

Code Style: pointer is declared wrong Signed-off-by: Paul McQuade --- drivers/net/wireless/rt2x00/rt2x00.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h index

[PATCH 3/3] net: wireless: rt2x00: Space Required

Space needed before open parenthesis Signed-off-by: Paul McQuade # --- drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c

[PATCH 3/3] net: wireless: rt2x00: Space Required

Space needed before open parenthesis Signed-off-by: Paul McQuade --- drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c

[PATCH net] net: bcmgenet: Fix early link interrupt enabling

From: Florian Fainelli Link interrupts are enabled in init_umac(), which is too early for us to process them since we do not yet have a valid PHY device pointer. On BCM7425 chips for instance, we will crash calling phy_mac_interrupt() because phydev is NULL. Fix this by