[PATCH net] sctp: fix the transports round robin issue when init is retransmitted

2016-03-09 Thread Xin Long
prior to this patch, at the beginning if we have two paths in one assoc, they may have the same params other than the last_time_heard, it will try the paths like this: 1st cycle try trans1 fail. then trans2 is selected.(cause it's last_time_heard is after trans1). 2nd cycle: try trans2

Re: [PATCH V4 0/3] basic busy polling support for vhost_net

2016-03-09 Thread Michael Rapoport
Hi Greg, > Greg Kurz wrote on 03/09/2016 09:26:45 PM: > > On Fri, 4 Mar 2016 06:24:50 -0500 > > Jason Wang wrote: > > > This series tries to add basic busy polling for vhost net. The idea is > > simple: at the end of tx/rx processing, busy

Re: Hung up was occurred after v4.4-rc1 during IPv6 Ready Logo Conformance Test

2016-03-09 Thread Martin KaFai Lau
On Thu, Mar 10, 2016 at 01:21:05PM +0900, Yuki Machida wrote: > Hi all, > > Hung up was occurred at Linux Kernel after v4.4-rc1 during IPv6 Ready Logo > Conformance Test. > Not Fix a bug in v4.5-rc7 yet. > > Currently, it is under investigation. > > The following are the details: I think you

Re: [PATCH net-next] bpf: bpf_stackmap_copy depends on CONFIG_PERF_EVENTS

2016-03-09 Thread David Miller
From: Alexei Starovoitov Date: Wed, 9 Mar 2016 18:56:49 -0800 > 0-day bot reported build error: > kernel/built-in.o: In function `map_lookup_elem': >>> kernel/bpf/.tmp_syscall.o:(.text+0x329b3c): undefined reference to >>> `bpf_stackmap_copy' > when CONFIG_BPF_SYSCALL is set and

Re: [PATCH net-next] bpf: avoid copying junk bytes in bpf_get_current_comm()

2016-03-09 Thread David Miller
From: Alexei Starovoitov Date: Wed, 9 Mar 2016 20:02:33 -0800 > Lots of places in the kernel use memcpy(buf, comm, TASK_COMM_LEN); but > the result is typically passed to print("%s", buf) and extra bytes > after zero don't cause any harm. > In bpf the result of

Re: [PATCH net-next 0/3] validate variable length ll headers

2016-03-09 Thread David Miller
From: Willem de Bruijn Date: Wed, 9 Mar 2016 23:22:59 -0500 > On Wed, Mar 9, 2016 at 10:13 PM, David Miller wrote: >> From: Willem de Bruijn >> Date: Wed, 9 Mar 2016 21:58:31 -0500 >> >>> Allow

Re: [PATCH net-next 0/3] validate variable length ll headers

2016-03-09 Thread Willem de Bruijn
On Wed, Mar 9, 2016 at 10:13 PM, David Miller wrote: > From: Willem de Bruijn > Date: Wed, 9 Mar 2016 21:58:31 -0500 > >> Allow device-specific validation of link layer headers. Existing >> checks drop all packets shorter than

Hung up was occurred after v4.4-rc1 during IPv6 Ready Logo Conformance Test

2016-03-09 Thread Yuki Machida
Hi all, Hung up was occurred at Linux Kernel after v4.4-rc1 during IPv6 Ready Logo Conformance Test. Not Fix a bug in v4.5-rc7 yet. Currently, it is under investigation. The following are the details: IPv6 Ready Logo https://www.ipv6ready.org/ I ran the IPv6 Ready Logo Core Conformance Test

[PATCH net-next] bpf: avoid copying junk bytes in bpf_get_current_comm()

2016-03-09 Thread Alexei Starovoitov
Lots of places in the kernel use memcpy(buf, comm, TASK_COMM_LEN); but the result is typically passed to print("%s", buf) and extra bytes after zero don't cause any harm. In bpf the result of bpf_get_current_comm() is used as the part of map key and was causing spurious hash map mismatches. Use

Re: [PATCH nf-next v9 8/8] openvswitch: Interface with NAT.

2016-03-09 Thread Joe Stringer
Hi Jarno, Thanks for working on this. Mostly just a few style things around #ifdefs below. On 9 March 2016 at 15:10, Jarno Rajahalme wrote: > Extend OVS conntrack interface to cover NAT. New nested > OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. > A bare

Re: [PATCH] bpf: make bpf_stackmap_copy conditionally called

2016-03-09 Thread Alexei Starovoitov
On Thu, Mar 10, 2016 at 02:43:42AM +0100, Arnd Bergmann wrote: > Changing the bpf syscall to use the new bpf_stackmap_copy() helper for > BPF_MAP_TYPE_STACK_TRACE causes a link error when CONFIG_PERF_EVENTS > is disabled: > > kernel/built-in.o: In function `map_lookup_elem': > :(.text+0x7fca4):

[PATCH] bpf: make bpf_stackmap_copy conditionally called

2016-03-09 Thread Arnd Bergmann
Changing the bpf syscall to use the new bpf_stackmap_copy() helper for BPF_MAP_TYPE_STACK_TRACE causes a link error when CONFIG_PERF_EVENTS is disabled: kernel/built-in.o: In function `map_lookup_elem': :(.text+0x7fca4): undefined reference to `bpf_stackmap_copy' This patch simply avoids

Re: [PATCH net-next 0/3] validate variable length ll headers

2016-03-09 Thread David Miller
From: Willem de Bruijn Date: Wed, 9 Mar 2016 21:58:31 -0500 > Allow device-specific validation of link layer headers. Existing > checks drop all packets shorter than hard_header_len. For variable > length protocols, such packets can be valid. > > patch 1 adds

[PATCH net-next 3/3] packet: validate variable length ll headers

2016-03-09 Thread Willem de Bruijn
From: Willem de Bruijn Replace link layer header validation check ll_header_truncate with more generic dev_validate_header. Validation based on hard_header_len incorrectly drops valid packets in variable length protocols, such as AX25. dev_validate_header calls

[PATCH net-next 2/3] ax25: add link layer header validation function

2016-03-09 Thread Willem de Bruijn
From: Willem de Bruijn As variable length protocol, AX25 fails link layer header validation tests based on a minimum length. header_ops.validate allows protocols to validate headers that are shorter than hard_header_len. Implement this callback for AX25. See also

[PATCH net-next 1/3] net: validate variable length ll headers

2016-03-09 Thread Willem de Bruijn
From: Willem de Bruijn Netdevice parameter hard_header_len is variously interpreted both as an upper and lower bound on link layer header length. The field is used as upper bound when reserving room at allocation, as lower bound when validating user input in PF_PACKET.

[PATCH net-next 0/3] validate variable length ll headers

2016-03-09 Thread Willem de Bruijn
From: Willem de Bruijn Allow device-specific validation of link layer headers. Existing checks drop all packets shorter than hard_header_len. For variable length protocols, such packets can be valid. patch 1 adds header_ops.validate and dev_validate_header patch 2 implements

[PATCH net-next] bpf: bpf_stackmap_copy depends on CONFIG_PERF_EVENTS

2016-03-09 Thread Alexei Starovoitov
0-day bot reported build error: kernel/built-in.o: In function `map_lookup_elem': >> kernel/bpf/.tmp_syscall.o:(.text+0x329b3c): undefined reference to >> `bpf_stackmap_copy' when CONFIG_BPF_SYSCALL is set and CONFIG_PERF_EVENTS is not. Add weak definition to resolve it. This code path in

[RFC PATCH 1/1] net namespace: dynamically configure new net namespace inherit net config

2016-03-09 Thread Zhu Yanjun
Sometimes the system engineer and application expect a new net namespace to inherit config from the base net config. Sometimes the current net config is expected by the system engineer and application. So it is necessary that the system engineer and application can choose a new net namespace to

Re: [PATCH nf-next v9 7/8] openvswitch: Delay conntrack helper call for new connections.

2016-03-09 Thread Joe Stringer
On 9 March 2016 at 15:10, Jarno Rajahalme wrote: > There is no need to help connections that are not confirmed, so we can > delay helping new connections to the time when they are confirmed. > This change is needed for NAT support, and having this as a separate > patch will make

Re: [PATCH nf-next v9 5/8] openvswitch: Find existing conntrack entry after upcall.

2016-03-09 Thread Joe Stringer
On 9 March 2016 at 15:10, Jarno Rajahalme wrote: > Add a new function ovs_ct_find_existing() to find an existing > conntrack entry for which this packet was already applied to. This is > only to be called when there is evidence that the packet was already > tracked and committed,

Re: [PATCH v6 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2016-03-09 Thread Yuchung Cheng
On Wed, Mar 9, 2016 at 5:45 PM, Jonas Markussen wrote: > >> On 10 Mar 2016, at 01:20, Yuchung Cheng wrote: >> >> PS. I don't understand how (old) RDB can masquerade the losses by >> skipping DUPACKs. Perhaps an example helps. Suppose we send 4 packets >>

Re: [ovs-dev] [PATCH nf-next v9 4/8] openvswitch: Update the CT state key only after nf_conntrack_in().

2016-03-09 Thread Joe Stringer
On 9 March 2016 at 15:10, Jarno Rajahalme wrote: > Only a successful nf_conntrack_in() call can effect a connection state > change, so if suffices to update the key only after the > nf_conntrack_in() returns. "it" suffices to update... > This change is needed for the later NAT

Re: [PATCH v6 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2016-03-09 Thread Jonas Markussen
> On 10 Mar 2016, at 01:20, Yuchung Cheng wrote: > > PS. I don't understand how (old) RDB can masquerade the losses by > skipping DUPACKs. Perhaps an example helps. Suppose we send 4 packets > and the last 3 were (s)acked. We perform RDB to send a packet that has > previous 4

[PATCH net] net: hns: bug fix about ping6

2016-03-09 Thread Kejian Yan
The current upstreaming code fails to ping other IPv6 net device, because the enet receives the multicast packets with the src mac addr whick is the same as its mac addr. These packets need to be dropped. Signed-off-by: Kejian Yan ---

[patch net 2/2] net: hns: fixes a bug of RSS

2016-03-09 Thread Kejian Yan
If trying to get receive flow hash indirection table by ethtool, it needs to call .get_rxnfc to get ring number first. So this patch implements the .get_rxnfc of ethtool. And the data type of rss_indir_table is u32, it has to be multiply by the width of data type when using memcpy. Signed-off-by:

[patch net 0/2] net: hns: get and set RSS indirection table by using ethtool

2016-03-09 Thread Kejian Yan
When we use ethtool to retrieves or configure the receive flow hash indirection table, ethtool needs to call .get_rxnfc to get the ring number so this patchset implements the .get_rxnfc and fixes the bug that we can not get the tatal table each time. Kejian Yan (2): net: hns: fix return value

[patch net 1/2] net: hns: fix return value of the function about rss

2016-03-09 Thread Kejian Yan
Both .get_rxfh and .get_rxfh are always return 0, it should return result from hardware when getting or setting rss. And the rss function should return the correct data type. Signed-off-by: Kejian Yan --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 2 +-

Re: [PATCH net-next v3] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-09 Thread Martin KaFai Lau
On Wed, Mar 09, 2016 at 03:11:50PM -0800, Yuchung Cheng wrote: > On Wed, Mar 9, 2016 at 10:43 AM, Martin KaFai Lau wrote: > > diff --git a/include/net/tcp.h b/include/net/tcp.h > > index e90db85..24557a8 100644 > > --- a/include/net/tcp.h > > +++ b/include/net/tcp.h > > @@ -1816,4

Re: [net-next PATCH] csum: Update csum_block_add to use rotate instead of byteswap

2016-03-09 Thread Tom Herbert
On Wed, Mar 9, 2016 at 4:18 PM, Joe Perches wrote: > On Wed, 2016-03-09 at 08:08 -0800, Alexander Duyck wrote: >> On Tue, Mar 8, 2016 at 10:31 PM, Tom Herbert wrote: >> > I took a look inlining these. >> > >> > #define rol32(V, X) ({

Re: [ovs-dev] [PATCH net-next] ovs: allow nl 'flow set' to use ufid without flow key

2016-03-09 Thread pravin shelar
On Wed, Mar 9, 2016 at 4:25 PM, Samuel Gauthier wrote: > Sorry, I missed that. Thank you for pointing it out. > > Although, set command is also used to reset the flow statistics, and the > action attribute seems optional. Would you find acceptable to make the key >

Re: [PATCH v6 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2016-03-09 Thread Yuchung Cheng
On Thu, Mar 3, 2016 at 10:06 AM, Bendik Rønning Opstad wrote: > > Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing > the latency for applications sending time-dependent data. > Latency-sensitive applications or services, such as online games and > remote

Re: [net-next PATCH] csum: Update csum_block_add to use rotate instead of byteswap

2016-03-09 Thread Joe Perches
On Wed, 2016-03-09 at 08:08 -0800, Alexander Duyck wrote: > On Tue, Mar 8, 2016 at 10:31 PM, Tom Herbert wrote: > > I took a look inlining these. > > > > #define rol32(V, X) ({  \ > > int word = V;   \ > > if

Re: [PATCH next 3/3] net: Use l3_dev instead of skb->dev for L3 processing

2016-03-09 Thread Cong Wang
On Tue, Mar 8, 2016 at 10:42 AM, Mahesh Bandewar wrote: >> The more subsystems involves, the more struct net pointers you >> potentially need to touch, the less likely you can make it correct >> by just switching skb->dev. > > Please drop that prejudice and read the patch-set

RE: [net PATCH 1/2] e1000: Do not overestimate descriptor counts in Tx pre-check

2016-03-09 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Alexander Duyck > Sent: Wednesday, March 2, 2016 1:16 PM > To: netdev@vger.kernel.org; jogre...@redhat.com; intel-wired- > l...@lists.osuosl.org; Kirsher, Jeffrey T ; >

RE: [Intel-wired-lan] [net PATCH 2/2] e1000: Double Tx descriptors needed check for 82544

2016-03-09 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Wednesday, March 2, 2016 1:16 PM > To: netdev@vger.kernel.org; jogre...@redhat.com; intel-wired- > l...@lists.osuosl.org; Kirsher, Jeffrey T ; >

Re: [PATCH] rxrpc: Replace all unsigned with unsigned int

2016-03-09 Thread David Howells
David Howells wrote: > Replace all "unsigned" types with "unsigned int" types. > > Reported-by: David Miller > Signed-off-by: David Howells This is aimed at net-next. David

[PATCH] rxrpc: Replace all unsigned with unsigned int

2016-03-09 Thread David Howells
Replace all "unsigned" types with "unsigned int" types. Reported-by: David Miller Signed-off-by: David Howells --- net/rxrpc/af_rxrpc.c |2 +- net/rxrpc/ar-ack.c| 12 ++-- net/rxrpc/ar-call.c |4 ++--

Re: [PATCH nf-next v8 3/8] openvswitch: Add commentary to conntrack.c

2016-03-09 Thread Jarno Rajahalme
Sergei, Just found this from my junk mail box, sorry. Will fix spelling, but I just sent v9 and will wait for other reviews before re-posting. Jarno > On Mar 9, 2016, at 5:50 AM, Sergei Shtylyov > wrote: > > Hello. > > On 3/9/2016 3:24 AM, Jarno

Re: [PATCH net-next v3] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-09 Thread Yuchung Cheng
On Wed, Mar 9, 2016 at 10:43 AM, Martin KaFai Lau wrote: > > Per RFC4898, they count segments sent/received > containing a positive length data segment (that includes > retransmission segments carrying data). Unlike > tcpi_segs_out/in, tcpi_data_segs_out/in excludes segments >

[PATCH nf-next v9 4/8] openvswitch: Update the CT state key only after nf_conntrack_in().

2016-03-09 Thread Jarno Rajahalme
Only a successful nf_conntrack_in() call can effect a connection state change, so if suffices to update the key only after the nf_conntrack_in() returns. This change is needed for the later NAT patches. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 7 ---

[PATCH nf-next v9 6/8] openvswitch: Handle NF_REPEAT in conntrack action.

2016-03-09 Thread Jarno Rajahalme
Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN packet re-opening an existing TCP connection. Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer --- net/openvswitch/conntrack.c | 10 -- 1 file changed, 8

Re: [PATCH nf-next v8 8/8] openvswitch: Interface with NAT.

2016-03-09 Thread Jarno Rajahalme
rno-Rajahalme/netfilter-Remove-IP_CT_NEW_REPLY-definition/20160309-083126 > base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next master > config: i386-randconfig-x0-03091344 (attached as .config) > reproduce: ># save the attached .config to linux build tree >make

[PATCH nf-next v9 8/8] openvswitch: Interface with NAT.

2016-03-09 Thread Jarno Rajahalme
Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested attributes, new

[PATCH nf-next v9 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.

2016-03-09 Thread Jarno Rajahalme
Remove the definition of IP_CT_NEW_REPLY from the kernel as it does not make sense. This allows the definition of IP_CT_NUMBER to be simplified as well. Signed-off-by: Jarno Rajahalme --- include/uapi/linux/netfilter/nf_conntrack_common.h | 12 +---

[PATCH nf-next v9 2/8] netfilter: Allow calling into nat helper without skb_dst.

2016-03-09 Thread Jarno Rajahalme
NAT checksum recalculation code assumes existence of skb_dst, which becomes a problem for a later patch in the series ("openvswitch: Interface with NAT."). Simplify this by removing the check on skb_dst, as the checksum will be dealt with later in the stack. Suggested-by: Pravin Shelar

[PATCH nf-next v9 7/8] openvswitch: Delay conntrack helper call for new connections.

2016-03-09 Thread Jarno Rajahalme
There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT patch a bit easier to review. Signed-off-by: Jarno

[PATCH nf-next v9 3/8] openvswitch: Add commentary to conntrack.c

2016-03-09 Thread Jarno Rajahalme
This makes the code easier to understand and the following patches more focused. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/conntrack.c

[PATCH nf-next v9 5/8] openvswitch: Find existing conntrack entry after upcall.

2016-03-09 Thread Jarno Rajahalme
Add a new function ovs_ct_find_existing() to find an existing conntrack entry for which this packet was already applied to. This is only to be called when there is evidence that the packet was already tracked and committed, but we lost the ct reference due to an userspace upcall.

Re: [RFC PATCH net-next 1/2] net: bridge: add switchdev attr for port bridging

2016-03-09 Thread Vivien Didelot
Hi Ido, Ido Schimmel writes: > Wed, Mar 09, 2016 at 07:42:47PM IST, vivien.dide...@savoirfairelinux.com > wrote: >>Add a new SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF switchdev attribute which is >>set before adding a port to a bridge and deleting a port from a bridge. >> >>The

Re: [PATCH] inet: set `error' value not under lock_sock().

2016-03-09 Thread Weongyo Jeong
On 03/09/2016 12:37 PM, David Miller wrote: From: Weongyo Jeong Date: Wed, 9 Mar 2016 10:22:21 -0800 A trivial patch to set `error' variable while not holding lock_sock(). Signed-off-by: Weongyo Jeong Deferring the assignment means gcc

Re: [RFC PATCH net-next 2/2] net: dsa: support SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF

2016-03-09 Thread Vivien Didelot
Hi Jiri, Jiri Pirko writes: > Wed, Mar 09, 2016 at 07:32:13PM CET, and...@lunn.ch wrote: >>Hi Vivien >> >>> -static bool dsa_slave_dev_check(struct net_device *dev) >>> -{ >>> - return dev->netdev_ops == _slave_netdev_ops; >>> -} >> >>Where is the equivalent of this

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2016-03-09 Thread Tilman Schmidt
Am 07.03.2016 um 09:48 schrieb Paul Bolle: > On za, 2016-03-05 at 14:08 +0100, Tilman Schmidt wrote: >> As a consequence, owners of HiSAX type adapters are in fact stuck with >> the old hisax driver if they want to continue using i4l userspace >> tools. > > Do you know whether or not mISDN tools

Re: [net-next PATCH 2/7] mlx4: use napi_consume_skb API to get bulk free operations

2016-03-09 Thread Alexander Duyck
On Wed, Mar 9, 2016 at 1:47 PM, Jesper Dangaard Brouer wrote: > On Wed, 9 Mar 2016 13:43:59 -0800 > Alexander Duyck wrote: > >> On Wed, Mar 9, 2016 at 1:36 PM, Jesper Dangaard Brouer >> wrote: >> > On Wed, 09 Mar 2016 16:03:20

[PATCH next v2 7/7] ipvlan: Implement L3-symmetric mode.

2016-03-09 Thread Mahesh Bandewar
From: Mahesh Bandewar Current packet processing from IPtables perspective is asymmetric for IPvlan L3 mode. On egress path, packets hit LOCAL_OUT and POST_ROUTING hooks in slave-ns as well as master's ns however during ingress path, LOCAL_IN and PRE_ROUTING hooks are hit only

[PATCH next v2 4/7] ipv6: Use l3_dev for L3 ingress processing

2016-03-09 Thread Mahesh Bandewar
From: Mahesh Bandewar Use the in-dev passed by the packet dispatcher for the L3 phase. If there are places where code uses skb->dev, use the netif_get_l3_dev() helper to get l3_dev. Signed-off-by: Mahesh Bandewar CC: Eric Dumazet

[PATCH next v2 6/7] xfrm: Use l3_dev for xfrm policy checks.

2016-03-09 Thread Mahesh Bandewar
From: Mahesh Bandewar IPsec, whether it's tunnel mode or transport mode, is still a function of L3 so all the decisions should be based on the L3 device. Signed-off-by: Mahesh Bandewar CC: Eric Dumazet CC: Tim Hockin

[PATCH next v2 5/7] raw: Use l3_dev for L3 ingress raw packet delivery

2016-03-09 Thread Mahesh Bandewar
From: Mahesh Bandewar Use the in-dev passed by the packet dispatcher for the L3 phase. If there are places where code uses skb->dev, use the netif_get_l3_dev() helper to get l3_dev. Signed-off-by: Mahesh Bandewar CC: Eric Dumazet

[PATCH next v2 3/7] ipv4: Use l3_dev for L3 ingress processing

2016-03-09 Thread Mahesh Bandewar
From: Mahesh Bandewar Use the in-dev passed by the packet dispatcher for the L3 phase. If there are places where code uses skb->dev, use the netif_get_l3_dev() helper to get l3_dev. Signed-off-by: Mahesh Bandewar CC: Eric Dumazet

[PATCH next v2 1/7] dev: Add netif_get_l3_dev() helper

2016-03-09 Thread Mahesh Bandewar
From: Mahesh Bandewar This patch adds a l3_dev to net_device struct and a helper function to retrieve it. During L3 ingress packet processing, this device will be used and should serve the current purpose of skb->dev. Since l3_dev is initialized to self; l3_dev should be

[PATCH next v2 0/7] Introduce l3_dev pointer for L3 processing

2016-03-09 Thread Mahesh Bandewar
From: Mahesh Bandewar One of the major request (for enhancement) that I have received from various users of IPvlan in L3 mode is its inability to handle IPtables. While looking at the code and how we handle ingress, the problem can be attributed to the asymmetry in the way

[PATCH next v2 2/7] dev: Update packet dispatcher to pass l3_dev as an input device

2016-03-09 Thread Mahesh Bandewar
From: Mahesh Bandewar netif_receive_skb_core() dispatcher uses skb->dev device as an input device to all packet-handlers (e.g. ip_rcv, ipv6_rcv etc) These packet handlers use this device reference to start processing L3 phase of the packet-processing. This includes IPT hooks,

Re: [net-next PATCH 3/4] vxlan: Enforce IP ID verification on outer headers

2016-03-09 Thread Alexander Duyck
On Wed, Mar 9, 2016 at 1:02 PM, David Miller wrote: > From: Jesse Gross > Date: Mon, 7 Mar 2016 15:42:59 -0800 > >> On Mon, Mar 7, 2016 at 3:06 PM, Alex Duyck wrote: >>> On Mon, Mar 7, 2016 at 11:09 AM, David Miller

Re: [net-next PATCH 2/7] mlx4: use napi_consume_skb API to get bulk free operations

2016-03-09 Thread Jesper Dangaard Brouer
On Wed, 9 Mar 2016 13:43:59 -0800 Alexander Duyck wrote: > On Wed, Mar 9, 2016 at 1:36 PM, Jesper Dangaard Brouer > wrote: > > On Wed, 09 Mar 2016 16:03:20 -0500 (EST) > > David Miller wrote: > > > >> From: Alexander Duyck

Re: [PATCH net] r8169:Remove unnecessary phy reset for pcie nic when setting link spped.

2016-03-09 Thread Francois Romieu
Hau : [...] > Unless pcie nic has bug, pcie nic does not need to reset phy to let phy link > on. > > There is a counter for phy speed down. If phy is in link down state, this > counter will start to count down. When it count to 0, phy will speed down. > Reset phy will reset

Re: [net-next PATCH 2/7] mlx4: use napi_consume_skb API to get bulk free operations

2016-03-09 Thread Alexander Duyck
On Wed, Mar 9, 2016 at 1:36 PM, Jesper Dangaard Brouer wrote: > On Wed, 09 Mar 2016 16:03:20 -0500 (EST) > David Miller wrote: > >> From: Alexander Duyck >> Date: Wed, 9 Mar 2016 08:47:58 -0800 >> >> > On Wed, Mar 9, 2016 at

Re: [RFC PATCH net-next 1/2] net: bridge: add switchdev attr for port bridging

2016-03-09 Thread Ido Schimmel
Hi Vivien, Wed, Mar 09, 2016 at 07:42:47PM IST, vivien.dide...@savoirfairelinux.com wrote: >Add a new SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF switchdev attribute which is >set before adding a port to a bridge and deleting a port from a bridge. > >The main purpose for this attribute is to provide

Re: [PATCH v2 net-next 00/13] kcm: Kernel Connection Multiplexor (KCM)

2016-03-09 Thread David Miller
From: Tom Herbert Date: Mon, 7 Mar 2016 14:10:59 -0800 > Kernel Connection Multiplexor (KCM) is a facility that provides a > message based interface over TCP for generic application protocols. ... I've decided to apply this as-is. If there are any issues we can fix it

Re: [net-next PATCH 2/7] mlx4: use napi_consume_skb API to get bulk free operations

2016-03-09 Thread Jesper Dangaard Brouer
On Wed, 09 Mar 2016 16:03:20 -0500 (EST) David Miller wrote: > From: Alexander Duyck > Date: Wed, 9 Mar 2016 08:47:58 -0800 > > > On Wed, Mar 9, 2016 at 3:00 AM, Jesper Dangaard Brouer > > wrote: > >> Passing the budget down

Re: [ovs-dev] [PATCH net-next] ovs: allow nl 'flow set' to use ufid without flow key

2016-03-09 Thread pravin shelar
On Wed, Mar 9, 2016 at 9:05 AM, Samuel Gauthier wrote: > When we want to change a flow using netlink, we have to identify it to > be able to perform a lookup. Both the flow key and unique flow ID > (ufid) are valid identifiers, but we always have to specify the flow >

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-09 Thread Cyrill Gorcunov
On Wed, Mar 09, 2016 at 04:10:38PM -0500, David Miller wrote: > > > > and here we call for NETDEV_DOWN, which then hits masq_device_event > > and go further to conntrack code. > > Yes that's where the notifier comes from, which happens with or without > my patch. Thanks for explanation, Dave!

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-09 Thread David Miller
From: Cyrill Gorcunov Date: Wed, 9 Mar 2016 23:57:47 +0300 > Aha! So in your patch __inet_del_ifa bypass first blocking_notifier_call_chain > > __inet_del_ifa > ... > if (in_dev->dead) > goto no_promotions; > > // First call to NETDEV_DOWN >

Re: [net-next PATCH 2/7] mlx4: use napi_consume_skb API to get bulk free operations

2016-03-09 Thread David Miller
From: Alexander Duyck Date: Wed, 9 Mar 2016 08:47:58 -0800 > On Wed, Mar 9, 2016 at 3:00 AM, Jesper Dangaard Brouer > wrote: >> Passing the budget down was Alex'es design. Axel any thoughts? > > I'd say just use dev_consume_skb_any in the bulk

Re: [net-next PATCH 3/4] vxlan: Enforce IP ID verification on outer headers

2016-03-09 Thread David Miller
From: Jesse Gross Date: Mon, 7 Mar 2016 15:42:59 -0800 > On Mon, Mar 7, 2016 at 3:06 PM, Alex Duyck wrote: >> On Mon, Mar 7, 2016 at 11:09 AM, David Miller wrote: >>> From: Or Gerlitz >>> Date: Mon, 7 Mar 2016

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-09 Thread Cyrill Gorcunov
On Wed, Mar 09, 2016 at 03:47:25PM -0500, David Miller wrote: > From: Cyrill Gorcunov > Date: Wed, 9 Mar 2016 23:41:58 +0300 > > > On Wed, Mar 09, 2016 at 03:27:30PM -0500, David Miller wrote: > >> > > >> > Yes. I can drop it off for a while and run tests without it, > >> >

Re: [PATCH net 0/3] validate variable length ll headers

2016-03-09 Thread David Miller
From: Willem de Bruijn Date: Fri, 4 Mar 2016 15:44:14 -0500 > From: Willem de Bruijn > > Allow device-specific validation of link layer headers. Existing > checks drop all packets shorter than hard_header_len. For variable > length

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-09 Thread David Miller
From: Cyrill Gorcunov Date: Wed, 9 Mar 2016 23:41:58 +0300 > On Wed, Mar 09, 2016 at 03:27:30PM -0500, David Miller wrote: >> > >> > Yes. I can drop it off for a while and run tests without it, >> > then turn it back and try again. Would you like to see such >> > numbers? >>

Kreditfinanzierung . Kontaktieren Sie uns für weitere Informationen.

2016-03-09 Thread EuroFinance Group
Guten Tag Wir möchten Sie informieren, dass wir GeschäftDarlehen, Projektfinanzierung, Immobilienfinanzierung bei 1% Jahreszinssatz bieten. Für weitere Informationen kontaktieren Sie uns über folgende e-Mail: eurofinanc...@gmail.com. Senden Sie Ihren Darlehensantrag einschließlich Ihren

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-09 Thread Cyrill Gorcunov
On Wed, Mar 09, 2016 at 03:27:30PM -0500, David Miller wrote: > > > > Yes. I can drop it off for a while and run tests without it, > > then turn it back and try again. Would you like to see such > > numbers? > > That would be very helpful, yes. Just sent out. Take a look please. Indeed it sits

Re: [PATCH] inet: set `error' value not under lock_sock().

2016-03-09 Thread David Miller
From: Weongyo Jeong Date: Wed, 9 Mar 2016 10:22:21 -0800 > A trivial patch to set `error' variable while not holding > lock_sock(). > > Signed-off-by: Weongyo Jeong Deferring the assignment means gcc doesn't have to potentially put it on the

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-09 Thread David Miller
From: Cyrill Gorcunov Date: Wed, 9 Mar 2016 20:53:07 +0300 > On Wed, Mar 09, 2016 at 12:24:00PM -0500, David Miller wrote: > ... >> We asked you for numbers without a lot of features enabled, it'll >> help us diagnose which subsystem still causes a lot of overhead >> much

Re: [PATCH 0/3] net: macb: Fix coding style issues

2016-03-09 Thread David Miller
From: Michal Simek Date: Wed, 9 Mar 2016 18:29:01 +0100 > On 9.3.2016 18:22, David Miller wrote: >> From: Michal Simek >> Date: Wed, 9 Mar 2016 17:29:39 +0100 >> >>> On 7.3.2016 18:13, Nicolas Ferre wrote: Le 07/03/2016 17:17, Moritz

Re: [RFC PATCH net-next 2/2] net: dsa: support SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF

2016-03-09 Thread Andrew Lunn
On Wed, Mar 09, 2016 at 02:32:05PM -0500, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > >> -static bool dsa_slave_dev_check(struct net_device *dev) > >> -{ > >> - return dev->netdev_ops == _slave_netdev_ops; > >> -} > > > > Where is the equivalent of this

pull-request: wireless-drivers-next 2016-03-09

2016-03-09 Thread Kalle Valo
Hi Dave, here's a pull request for 4.6. I'm planning to send one more but I'm not sure if it will make it in time, we'll see. Here notable changes are refactoring in bcma to create a common flash driver, brcmfmac platform data improvements in include/linux and beginning of AHB bus support for

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-09 Thread Cyrill Gorcunov
On Wed, Mar 09, 2016 at 08:53:07PM +0300, Cyrill Gorcunov wrote: > On Wed, Mar 09, 2016 at 12:24:00PM -0500, David Miller wrote: > ... > > We asked you for numbers without a lot of features enabled, it'll > > help us diagnose which subsystem still causes a lot of overhead > > much more clearly. >

Re: [RFC PATCH net-next 2/2] net: dsa: support SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF

2016-03-09 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> -static bool dsa_slave_dev_check(struct net_device *dev) >> -{ >> -return dev->netdev_ops == _slave_netdev_ops; >> -} > > Where is the equivalent of this happening? Where do we check that the > interface added to the bridge is part of the

Re: [RFC PATCH net-next 1/2] net: bridge: add switchdev attr for port bridging

2016-03-09 Thread Sergei Shtylyov
Hello. On 03/09/2016 08:42 PM, Vivien Didelot wrote: Add a new SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF switchdev attribute which is set before adding a port to a bridge and deleting a port from a bridge. The main purpose for this attribute is to provide switchdev users a simple and common way to

Re: [PATCH V4 0/3] basic busy polling support for vhost_net

2016-03-09 Thread Greg Kurz
On Fri, 4 Mar 2016 06:24:50 -0500 Jason Wang wrote: > This series tries to add basic busy polling for vhost net. The idea is > simple: at the end of tx/rx processing, busy polling for new tx added > descriptor and rx receive socket for a while. The maximum number of > time

Re: [RFC PATCH net-next 2/2] net: dsa: support SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF

2016-03-09 Thread Jiri Pirko
Wed, Mar 09, 2016 at 07:32:13PM CET, and...@lunn.ch wrote: >Hi Vivien > >> -static bool dsa_slave_dev_check(struct net_device *dev) >> -{ >> -return dev->netdev_ops == _slave_netdev_ops; >> -} > >Where is the equivalent of this happening? Where do we check that the >interface added to the

Re: Unexpected tcpv6 connection resets since linux 4.4

2016-03-09 Thread Andreas Messer
On Mon, Mar 7, 2016 at 15:58, Cong Wang wrote: > On Sun, Mar 6, 2016 at 7:10 AM, Andreas Messer wrote: > > i have updated two of my machines in the last weeks to linux 4.4.1 and > > linux 4.4.3. It seems that since then i get unexpected TCPv6

[PATCH net-next v3] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-09 Thread Martin KaFai Lau
Per RFC4898, they count segments sent/received containing a positive length data segment (that includes retransmission segments carrying data). Unlike tcpi_segs_out/in, tcpi_data_segs_out/in excludes segments carrying no data (e.g. pure ack). The patch also updates the segs_in in

Re: [RFC PATCH net-next 2/2] net: dsa: support SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF

2016-03-09 Thread Andrew Lunn
Hi Vivien > -static bool dsa_slave_dev_check(struct net_device *dev) > -{ > - return dev->netdev_ops == _slave_netdev_ops; > -} Where is the equivalent of this happening? Where do we check that the interface added to the bridge is part of the switch? > -int dsa_slave_netdevice_event(struct

[PATCH] inet: set `error' value not under lock_sock().

2016-03-09 Thread Weongyo Jeong
A trivial patch to set `error' variable while not holding lock_sock(). Signed-off-by: Weongyo Jeong --- net/ipv4/inet_connection_sock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv4/inet_connection_sock.c

Re: [PATCH (net.git) 0/2] stmmac: MDIO fixes

2016-03-09 Thread Frank Schäfer
Am 09.03.2016 um 10:00 schrieb Giuseppe Cavallaro: > These two patches are to fix the recent regressions raised > when test the stmmac on some platforms. > Please I kindly ask you to give me the feedback if it actually > covers all the cases and if the stmmac runs fine on the boxes. > I have

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-09 Thread Cyrill Gorcunov
On Wed, Mar 09, 2016 at 12:24:00PM -0500, David Miller wrote: ... > We asked you for numbers without a lot of features enabled, it'll > help us diagnose which subsystem still causes a lot of overhead > much more clearly. > > So please do so. Sure. Gimme some time and I'll back with numbers. >

[RFC PATCH net-next 2/2] net: dsa: support SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF

2016-03-09 Thread Vivien Didelot
Add a new dsa_slave_bridge_if function to handle the SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF switchdev attribute. Thus remove the code related to the netdev notifier block. Signed-off-by: Vivien Didelot --- net/dsa/dsa.c | 7 net/dsa/dsa_priv.h | 2 -

[RFC PATCH net-next 1/2] net: bridge: add switchdev attr for port bridging

2016-03-09 Thread Vivien Didelot
Add a new SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF switchdev attribute which is set before adding a port to a bridge and deleting a port from a bridge. The main purpose for this attribute is to provide switchdev users a simple and common way to retrieve bridging information, instead of implementing

[RFC PATCH net-next 0/2] net: switchdev: add attribute for port bridging

2016-03-09 Thread Vivien Didelot
Current switchdev users implement notifier blocks to filter global netdev events, in order to correctly offload bridging to their hardware ports. Such code could be replaced with the support of a simple switchdev attribute set when adding/deleting a port to/from a bridge. Also, we can imagine a

gretap default MTU question

2016-03-09 Thread Jonathan Thibault
Hello good people of netdev, When setting up gretap devices like so: ip link add mydev type gretap remote 1.1.1.1 local 2.2.2.2 nopmtudisc I'm observing two different behavior: - On system A, the MTU of 'mydev' is set to the MTU of the 'parent' interface (currently 1600) minus 38. All other

Re: Linux netfilter IPT_SO_SET_REPLACE memory corruption

2016-03-09 Thread Ben Hawkes
Small correction: IPT_SO_SET_REPLACE is reached via setsockopt, not ioctl. On Wed, Mar 9, 2016 at 9:25 AM, Ben Hawkes wrote: > N.B. I was redirected to this list by secur...@kernel.org. I'm told > that networking related issues such as this are handled on the public > netdev

  1   2   >