Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

2016-03-15 Thread Alexey Kardashevskiy
On 03/16/2016 04:10 PM, Eli Cohen wrote: On Wed, Mar 16, 2016 at 01:07:58PM +1100, Alexey Kardashevskiy wrote: So with v4.5 as a host, there is no actual distro available today to use as a guest in the next 6 months (or whatever it takes to backport this partucular patch back there). You

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

2016-03-15 Thread Eli Cohen
On Wed, Mar 16, 2016 at 01:07:58PM +1100, Alexey Kardashevskiy wrote: > > So with v4.5 as a host, there is no actual distro available today to > use as a guest in the next 6 months (or whatever it takes to > backport this partucular patch back there). > > You could have added a module parameter

Re: [RFC v2 -next 0/2] virtio-net: Advised MTU feature

2016-03-15 Thread Pankaj Gupta
> > The following series adds the ability for a hypervisor to set an MTU on the > guest during feature negotiation phase. This is useful for VM orchestration > when, for instance, tunneling is involved and the MTU of the various systems > should be homogenous. > > The first patch adds the

RE: When will net-next merge with linux-next?

2016-03-15 Thread Dexuan Cui
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, March 16, 2016 10:41 > To: Dexuan Cui > Cc: David Miller ; netdev@vger.kernel.org; KY > Srinivasan ; Haiyang Zhang >

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2016-03-15 Thread David Miller
From: Robert Jarzmik Date: Tue, 15 Mar 2016 23:56:58 +0100 > Robert Jarzmik writes: > >> Fabio Estevam writes: >>> Tested-by: Fabio Estevam >> >> Thanks Fabio for the test. >> >> I also tried with a

Re: When will net-next merge with linux-next?

2016-03-15 Thread gre...@linuxfoundation.org
On Wed, Mar 16, 2016 at 01:58:50AM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, March 15, 2016 23:06 > > To: Dexuan Cui > > Cc: David Miller ; netdev@vger.kernel.org; KY > >

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

2016-03-15 Thread Alexey Kardashevskiy
On 03/15/2016 09:40 PM, Or Gerlitz wrote: On Tue, Mar 15, 2016 at 12:19 PM, Alexey Kardashevskiy wrote: This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. Without this revert, POWER "pseries" KVM guests with a VF passed to a guest using VFIO fail to bring the driver

RE: When will net-next merge with linux-next?

2016-03-15 Thread Dexuan Cui
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, March 15, 2016 23:06 > To: Dexuan Cui > Cc: David Miller ; netdev@vger.kernel.org; KY > Srinivasan ; Haiyang Zhang >

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

2016-03-15 Thread Alexey Kardashevskiy
On 03/16/2016 02:29 AM, Christoph Hellwig wrote: On Tue, Mar 15, 2016 at 04:23:33PM +0200, Or Gerlitz wrote: Let us check. I was under (the maybe wrong) impression, that before this patch both PF/VF drivers were not operative on some systems, so on those systems it's fair to require the VF

linux-next: manual merge of the rdma tree with the net-next tree

2016-03-15 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the rdma tree got a conflict in: drivers/net/ethernet/mellanox/mlx5/core/fs_core.c between commit: 60ab4584f5bf ("net/mlx5_core: Set flow steering dest only for forward rules") from the net-next tree and commit: b3638e1a7664 ("net/mlx5_core:

[PATCH net-next 0/3] Minor BPF follow-ups

2016-03-15 Thread Daniel Borkmann
Some minor last follow-ups I still had in my queue. The first one adds readability support for __sk_buff's tc_classid member, the remaining two are some minor cleanups. For details please see individual patches. Thanks! Daniel Borkmann (3): bpf: make skb->tc_classid also readable bpf, dst:

[PATCH net-next 2/3] bpf, dst: add and use dst_tclassid helper

2016-03-15 Thread Daniel Borkmann
We can just add a small helper dst_tclassid() for retrieving the dst->tclassid value. It makes the code a bit better in that we can get rid of the ifdef from filter.c by moving this into the header. Signed-off-by: Daniel Borkmann --- include/net/dst.h | 12

[PATCH net-next 3/3] ip_tunnels, bpf: define IP_TUNNEL_OPTS_MAX and use it

2016-03-15 Thread Daniel Borkmann
eBPF defines this as BPF_TUNLEN_MAX and OVS just uses the hard-coded value inside struct sw_flow_key. Thus, add and use IP_TUNNEL_OPTS_MAX for this, which makes the code a bit more generic and allows to remove BPF_TUNLEN_MAX from eBPF code. Signed-off-by: Daniel Borkmann

[PATCH net-next 1/3] bpf: make skb->tc_classid also readable

2016-03-15 Thread Daniel Borkmann
Currently, the tc_classid from eBPF skb context is write-only, but there's no good reason for tc programs to limit it to write-only. For example, it can be used to transfer its state via tail calls where the resulting tc_classid gets filled gradually. Signed-off-by: Daniel Borkmann

Re: [ethtool PATCH v4 10/11] ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls

2016-03-15 Thread David Decotigny
Please note that v5 patch depends on Ben Hutchings' http://patchwork.ozlabs.org/patch/596879/ to make any sense. On Tue, Mar 15, 2016 at 4:42 PM, David Decotigny wrote: > Just sent v5 of the series: now only this patch left. Applied all your > suggestions. > > Many thanks for

Re: [ethtool PATCH v4 10/11] ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls

2016-03-15 Thread David Decotigny
Just sent v5 of the series: now only this patch left. Applied all your suggestions. Many thanks for the 2 bugs you caught, path was not covered by my tests. v5 was tested on a 10G nic with: ethtool -s eth1 msglvl 0x15 speed 1 duplex full On Sun, Mar 13, 2016 at 6:32 PM, Ben Hutchings

[ethtool PATCH v5] ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls

2016-03-15 Thread David Decotigny
From: David Decotigny More info with kernel commit 8d3f2806f8fb ("Merge branch 'ethtool-ksettings'"). Signed-off-by: David Decotigny --- ethtool.c | 681 - internal.h | 67 ++

Re: [ethtool PATCH v4 11/11] ethtool.c: support absence of v4 sockets

2016-03-15 Thread Ben Hutchings
On Tue, 2016-03-15 at 16:19 -0700, David Decotigny wrote: > will send a v5 shortly without this patch: question below. > > about this patch: this is in prevision of a world where INET can be > compiled out. So it is not something that matters today with current > kernels. OK. > Now, as you

Re: [ethtool PATCH v4 11/11] ethtool.c: support absence of v4 sockets

2016-03-15 Thread David Decotigny
will send a v5 shortly without this patch: question below. about this patch: this is in prevision of a world where INET can be compiled out. So it is not something that matters today with current kernels. Now, as you mentioned in another patch, the only socket that survives various reasonable

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2016-03-15 Thread Robert Jarzmik
Robert Jarzmik writes: > Fabio Estevam writes: >> Tested-by: Fabio Estevam > > Thanks Fabio for the test. > > I also tried with a different different approach. > > I built the different platforms (imx v6, etc ...) : > - one

[PATCH 1/2] lan78xx: handle statistics counter rollover

2016-03-15 Thread Woojung.Huh
From: Woojung Huh Update to handle statistics counter rollover. Check statistics counter periodically and compensate it when counter value rolls over at max (20 or 32bits). Simple mechanism adjusts monitoring timer to allow USB auto suspend. Signed-off-by: Woojung

[PATCH 0/2] lan78xx: patch series

2016-03-15 Thread Woojung.Huh
From: Woojung Huh Woojung Huh (2): lan78xx: handle statistics counter rollover lan78xx: add ndo_get_stats64 drivers/net/usb/lan78xx.c | 301 -- 1 file changed, 288 insertions(+), 13 deletions(-) -- 2.7.0

[PATCH 2/2] lan78xx: add ndo_get_stats64

2016-03-15 Thread Woojung.Huh
From: Woojung Huh Add lan78xx_get_stats64 of ndo_get_stats64 to report all statistics counters including errors from HW statistics. Read from HW when auto suspend is disabled, use saved counter when auto suspend is enabled because periodic call to ndo_get_stats64

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-15 Thread David Miller
From: Bjørn Mork Date: Tue, 15 Mar 2016 13:27:03 +0100 > Schemmel Hans-Christoph writes: > >> If you are not the intended recipient of this message, please delete it and >> notify the sender. > > OK. Deleted. I've also deleted it and

[PATCH] net: mvneta: bm: clarify dependencies

2016-03-15 Thread Arnd Bergmann
MVNETA_BM has a dependency on MVNETA, so we can only select the former if the latter is enabled. However, the code dependency is the reverse: The mvneta module can call into the mvneta_bm module, so mvneta cannot be a built-in if mvneta_bm is a module, or we get a link error:

[PATCH net-next] cls_bpf: reset class and reuse major in da

2016-03-15 Thread Daniel Borkmann
There are two issues with the current code. First one is that we need to set res->class to 0 in case we use non-default classid matching. This is important for the case where cls_bpf was initially set up with an optional binding to a default class with tcf_bind_filter(), where the underlying

Re: [RFC v2 -next 0/2] virtio-net: Advised MTU feature

2016-03-15 Thread Rick Jones
On 03/15/2016 02:04 PM, Aaron Conole wrote: The following series adds the ability for a hypervisor to set an MTU on the guest during feature negotiation phase. This is useful for VM orchestration when, for instance, tunneling is involved and the MTU of the various systems should be homogenous.

[RFC v2 -next 1/2] virtio: Start feature MTU support

2016-03-15 Thread Aaron Conole
This commit adds the feature bit and associated mtu device entry for the virtio network device. Future commits will make use of these bits to support negotiated MTU. Signed-off-by: Aaron Conole --- v2: * No change include/uapi/linux/virtio_net.h | 3 +++ 1 file changed, 3

[RFC v2 -next 0/2] virtio-net: Advised MTU feature

2016-03-15 Thread Aaron Conole
The following series adds the ability for a hypervisor to set an MTU on the guest during feature negotiation phase. This is useful for VM orchestration when, for instance, tunneling is involved and the MTU of the various systems should be homogenous. The first patch adds the feature bit as

[RFC v2 -next 2/2] virtio_net: Read the advised MTU

2016-03-15 Thread Aaron Conole
This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it exists, read the advised MTU and use it. No proper error handling is provided for the case where a user changes the negotiated MTU. A future commit will add proper error handling. Instead, a warning is emitted if the guest

Re: [RFC -next 2/2] virtio_net: Read and use the advised MTU

2016-03-15 Thread Aaron Conole
Sergei Shtylyov writes: > Hello. Hi Sergei, > On 03/10/2016 05:28 PM, Aaron Conole wrote: > >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is provided

Re: [RFC -next 2/2] virtio_net: Read and use the advised MTU

2016-03-15 Thread Aaron Conole
Paolo Abeni writes: > On Thu, 2016-03-10 at 09:28 -0500, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is provided for the case where a user changes

Re: [PATCH v2 net-next] rds-tcp: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-15 Thread Sowmini Varadhan
On (03/15/16 10:47), Tom Herbert wrote: > Both sshd and nfsd and allow configurable listener port numbers. Any > listener service will allow a configurable port number. An IANA port > number is good as a default, but there are many reasons why people > want or need to use a different port number.

Re: [PATCH net-next v3 2/2] RDS: TCP: Remove unused constant

2016-03-15 Thread santosh shilimkar
On 3/15/2016 11:53 AM, Sowmini Varadhan wrote: RDS_TCP_DEFAULT_BUFSIZE has been unused since commit 1edd6a14d24f ("RDS-TCP: Do not bloat sndbuf/rcvbuf in rds_tcp_tune"). Signed-off-by: Sowmini Varadhan --- v3: review comments from Santosh Shilimkar net/rds/tcp.c

Re: [PATCH net-next v3 1/2] RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-15 Thread santosh shilimkar
On 3/15/2016 11:53 AM, Sowmini Varadhan wrote: Add per-net sysctl tunables to set the size of sndbuf and rcvbuf on the kernel tcp socket. The tunables are added at /proc/sys/net/rds/tcp/rds_tcp_sndbuf and /proc/sys/net/rds/tcp/rds_tcp_rcvbuf. Since these values must be set before accept() or

Re: [PATCH net-next] ethtool: Set cmd field in ETHTOOL_GLINKSETTINGS response to wrong nwords

2016-03-15 Thread david decotigny
Ben Hutchings decadent.org.uk> writes: > > When the ETHTOOL_GLINKSETTINGS implementation finds that userland is > using the wrong number of words of link mode bitmaps (or is trying to > find out the right numbers) it sets the cmd field to 0 in the response > structure. > > This is inconsistent

[PATCH net-next v3 1/2] RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-15 Thread Sowmini Varadhan
Add per-net sysctl tunables to set the size of sndbuf and rcvbuf on the kernel tcp socket. The tunables are added at /proc/sys/net/rds/tcp/rds_tcp_sndbuf and /proc/sys/net/rds/tcp/rds_tcp_rcvbuf. Since these values must be set before accept() or connect(), and there may be an arbitrary number of

[PATCH net-next v3 0/2] RDS: TCP: tunable socket buffer parameters

2016-03-15 Thread Sowmini Varadhan
Patch 1 uses sysctl to create tunable socket buffer size parameters. Patch 2 removes an unuused constant. Changes since v2: review comments from Santosh Shilimkar, Eric Dumazet Sowmini Varadhan (2): RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket RDS: TCP: Remove unused

[PATCH net-next v3 2/2] RDS: TCP: Remove unused constant

2016-03-15 Thread Sowmini Varadhan
RDS_TCP_DEFAULT_BUFSIZE has been unused since commit 1edd6a14d24f ("RDS-TCP: Do not bloat sndbuf/rcvbuf in rds_tcp_tune"). Signed-off-by: Sowmini Varadhan --- v3: review comments from Santosh Shilimkar net/rds/tcp.c |2 -- 1 files changed, 0 insertions(+), 2

Re: [PATCH v2 8/9] clk: rockchip: associate SCLK_MAC_PLL and disable reparenting on rk3036

2016-03-15 Thread Stephen Boyd
On 03/13, Caesar Wang wrote: > From: Heiko Stuebner > > The emac needs constant and very specific rate but the possible PLL-sources > are very limited, so we expect the PLL source to be set manually on per > board and don't want it to get changed in an automatic way later. > So

Re: [PATCH v2 6/9] clk: rockchip: associate the rk3036 HCLK_EMAC clock-id

2016-03-15 Thread Stephen Boyd
On 03/13, Caesar Wang wrote: > From: Xing Zheng > > Associate the new clock id the clock. > > Signed-off-by: Xing Zheng > Signed-off-by: Caesar Wang > --- Acked-by: Stephen Boyd -- Qualcomm

[PATCH net-next v2 3/4] ldmvsw: Add ldmvsw.c driver code

2016-03-15 Thread Aaron Young
From: Aaron Young Add ldmvsw.c driver Details: The ldmvsw driver very closely follows the sunvnet.c code and makes use of the sunvnet_common.c code for core functionality. A significant difference between sunvnet and ldmvsw driver is sunvnet creates a

[PATCH net-next v2 2/4] ldmvsw: Make sunvnet_common compatible with ldmvsw

2016-03-15 Thread Aaron Young
From: Aaron Young Modify sunvnet common code and data structures to be compatible with both sunvnet and ldmvsw drivers. Details: Sunvnet operates on "vnet-port" nodes which appear in the Machine Description (MD) in a guest domain. Ldmvsw operates on

[PATCH net-next v2 1/4] ldmvsw: Split sunvnet driver into common code

2016-03-15 Thread Aaron Young
From: Aaron Young Split sunvnet.c into sunvnet.c and sunvnet_common.c. Details: Since the sunvnet and ldmvsw drivers will both use common sunvnet code, move the functions (and support functions) anticipated to be common code from sunvnet.c to

[PATCH net-next v2 4/4] ldmvsw: Checkpatch sunvnet.c and sunvnet_common.c

2016-03-15 Thread Aaron Young
From: Aaron Young Checkpatch updates for sunvnet.c and sunvnet_common.c. Signed-off-by: Aaron Young Signed-off-by: Rashmi Narasimhan Reviewed-by: Sowmini Varadhan

[PATCH net-next v2 0/4] ldmvsw: Add ldmvsw driver

2016-03-15 Thread Aaron Young
From: Aaron Young This series adds a new Logical Domains vSwitch (ldmvsw) driver. The ldmvsw driver code will live in the drivers/net/ethernet/sun/ directory and will operate on Oracle systems running SPARC Linux in a Logical Domains environment (typically in the control

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-03-15 Thread Matt Wilson
On Tue, Mar 15, 2016 at 01:19:07PM -0500, Dan Williams wrote: > On Tue, 2016-03-15 at 12:50 +0200, Netanel Belgazal wrote: > > + > > +The ENA driver supports industry standard TCP/IP offload features > > such > > +as checksum offload and TCP transmit segmentation offload (TSO). > > + > >

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-03-15 Thread Dan Williams
On Tue, 2016-03-15 at 12:50 +0200, Netanel Belgazal wrote: > This is a driver for the Amazon ethernet ENA family. > The driver operates variety of ENA adapters through > feature negotiation with the adapter and upgradable commands set. > ENA driver handles PCI Physical and Virtual ENA functions. >

Re: [PATCH v2 net-next] rds-tcp: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-15 Thread Sowmini Varadhan
On (03/15/16 11:09), Eric Dumazet wrote: > > You said "just as user-space SO_SNDBUF allows ridiculous values > for buffer size.." > > So I understood you believe SOCK_MIN_SNDBUF and/or SOCK_MIN_RCVBUF are > ridiculous ;) No, no! I was saying that as a clueless user-space app, I can SO_SNDBUF to

Re: [PATCH v6 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-03-15 Thread Yuchung Cheng
On Mon, Mar 14, 2016 at 6:04 PM, Rick Jones wrote: > > On 03/14/2016 02:15 PM, Eric Dumazet wrote: >> >> On Thu, 2016-03-03 at 19:06 +0100, Bendik Rønning Opstad wrote: >>> >>> Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing >>> the latency for

Re: [PATCH v2 net-next] rds-tcp: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-15 Thread Eric Dumazet
On Tue, 2016-03-15 at 13:30 -0400, Sowmini Varadhan wrote: > On (03/15/16 10:18), Eric Dumazet wrote: > > > > Look at SO_SNDBUF and SO_RCVBUF implementation. > > > > sk->sk_sndbuf = max_t(u32, val * 2, SOCK_MIN_SNDBUF); > > > > sk->sk_rcvbuf = max_t(u32, val * 2, SOCK_MIN_RCVBUF); > > > >

Re: [PATCH] sctp: consolidate local_bh_disable/enable + spin_lock/unlock to _bh variant

2016-03-15 Thread Marcelo Ricardo Leitner
On Sun, Mar 13, 2016 at 11:48:24AM +0100, Nicholas Mc Guire wrote: > local_bh_disable() + spin_lock() is equivalent to spin_lock_bh(), same for > the unlock/enable case, so replace the calls by the appropriate wrappers. > > Signed-off-by: Nicholas Mc Guire Acked-by: Marcelo

[PATCH net] bnx2x: Prevent false warning for lack of FC NPIV

2016-03-15 Thread Yuval Mintz
Not all adapters have FC-NPIV configured. If bnx2fc is used with such an adapter, driver would read irrelevant data from the the nvram and log "FC-NPIV table with bad length..." In system logs. Simply accept that reading '0' as the feature offset in nvram indicates the feature isn't there and

Re: [PATCH v2 net-next] rds-tcp: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-15 Thread Tom Herbert
On Tue, Mar 15, 2016 at 10:34 AM, Sowmini Varadhan wrote: > On (03/15/16 10:30), Tom Herbert wrote: >> I still don't understand why you won't consider using netlink. sndbuf >> and rcvbuf seem like just two of many arbitrary parameters that a user >> might want to

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-03-15 Thread Matt Wilson
On Tue, Mar 15, 2016 at 12:50:06PM +0200, Netanel Belgazal wrote: [...] > diff --git a/drivers/net/ethernet/amazon/Kconfig > b/drivers/net/ethernet/amazon/Kconfig > new file mode 100644 > index 000..bc4f240d > --- /dev/null > +++ b/drivers/net/ethernet/amazon/Kconfig > @@ -0,0 +1,27 @@ > +# >

Re: [PATCH v2 net-next] rds-tcp: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-15 Thread Sowmini Varadhan
On (03/15/16 10:30), Tom Herbert wrote: > I still don't understand why you won't consider using netlink. sndbuf > and rcvbuf seem like just two of many arbitrary parameters that a user > might want to configure. > I would think that being able to configure > the listener port (currently a fixed

Re: [PATCH v2 net-next] rds-tcp: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-15 Thread Tom Herbert
On Tue, Mar 15, 2016 at 8:12 AM, Sowmini Varadhan wrote: > > Add per-net sysctl tunables to set the size of sndbuf and > rcvbuf on the kernel tcp socket. > > The tunables are added at /proc/sys/net/rds/tcp/rds_tcp_sndbuf > and /proc/sys/net/rds/tcp/rds_tcp_rcvbuf. > >

Re: [PATCH v2 net-next] rds-tcp: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-15 Thread Sowmini Varadhan
On (03/15/16 10:18), Eric Dumazet wrote: > > Look at SO_SNDBUF and SO_RCVBUF implementation. > > sk->sk_sndbuf = max_t(u32, val * 2, SOCK_MIN_SNDBUF); > > sk->sk_rcvbuf = max_t(u32, val * 2, SOCK_MIN_RCVBUF); > > kernel definitely has some logic here. Ok, I can do the same thing (and we do

Re: [PATCH v2 net-next] rds-tcp: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-15 Thread Eric Dumazet
On Tue, 2016-03-15 at 12:58 -0400, Sowmini Varadhan wrote: > On (03/15/16 09:38), santosh shilimkar wrote: > > >+ if (rtn->sndbuf_size > 0) { > > So value of 1 is allowed as well. There should be some > > minimum default or multiple of it. Of course above check > > can remain as is as long as you

Re: [PATCH net] ravb: fix result value overwrite

2016-03-15 Thread Sergei Shtylyov
Hello. On 03/15/2016 06:52 PM, Yoshihiro Kaneko wrote: The result value is overwritten by a return value of ravb_ptp_interrupt(). Signed-off-by: Yoshihiro Kaneko --- Acked-by: Sergei Shtylyov [...] diff --git

Re: [PATCH v7 net-next] ravb: Add dma queue interrupt support

2016-03-15 Thread Sergei Shtylyov
Hello. On 03/15/2016 06:03 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (timestamp, error, gPTP) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx,

Re: [PATCH net-next repost] openvswitch: allow output of MPLS packets on tunnel vports

2016-03-15 Thread Jesse Gross
On Mon, Mar 14, 2016 at 8:00 PM, Simon Horman wrote: > Currently output of MPLS packets on tunnel vports is not allowed by Open > vSwitch. This is because historically encapsulation was done in such a way > that the inner_protocol field of the skb needed to hold the

Re: [PATCH v2 net-next] rds-tcp: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-15 Thread Sowmini Varadhan
On (03/15/16 09:38), santosh shilimkar wrote: > >+if (rtn->sndbuf_size > 0) { > So value of 1 is allowed as well. There should be some > minimum default or multiple of it. Of course above check > can remain as is as long as you validate the user input > in handlers. yes, just as user-space

Re: [PATCH v2 net-next] rds-tcp: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-15 Thread santosh shilimkar
Hi Sowmini, $subject s/rds-tcp: /RDS: TCP: On 3/15/2016 8:12 AM, Sowmini Varadhan wrote: Add per-net sysctl tunables to set the size of sndbuf and rcvbuf on the kernel tcp socket. The tunables are added at /proc/sys/net/rds/tcp/rds_tcp_sndbuf and /proc/sys/net/rds/tcp/rds_tcp_rcvbuf. These

Re: [PATCH] af_unix: closed SOCK_SEQPACKET socketpair must get SIGPIPE

2016-03-15 Thread Alexander Potapenko
On Tue, Mar 15, 2016 at 2:46 PM, David Laight wrote: > From: Alexander Potapenko >> Sent: 15 March 2016 09:04 >> According to IEEE Std 1003.1, 2013, sending data to a SOCK_SEQPACKET >> socketpair with MSG_NOSIGNAL flag set must result in a SIGPIPE if the >> socket is no

Re: [PATCHv3 (net.git) 2/2] stmmac: fix MDIO settings

2016-03-15 Thread Giuseppe CAVALLARO
Hi Andreas On 3/15/2016 1:54 AM, Andreas Färber wrote: Hi Peppe, Am 11.03.2016 um 14:33 schrieb Giuseppe Cavallaro: Initially the phy_bus_name was added to manipulate the driver name but It was recently just used to manage the "it" fixed-link and then to take some decision at run-time

[PATCH net] ravb: fix result value overwrite

2016-03-15 Thread Yoshihiro Kaneko
The result value is overwritten by a return value of ravb_ptp_interrupt(). Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's networking tree. drivers/net/ethernet/renesas/ravb_main.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

2016-03-15 Thread Christoph Hellwig
On Tue, Mar 15, 2016 at 04:23:33PM +0200, Or Gerlitz wrote: > Let us check. I was under (the maybe wrong) impression, that before this > patch both PF/VF drivers were not operative on some systems, so on those > systems it's fair to require the VF driver to be patched too. To me it sounds like

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-03-15 Thread Matt Wilson
Hi Netanel, Looks like the last round of internal review went to {lkml,netdev,etc}, so this should be considered a RFC patch. The description still needs work. On Tue, Mar 15, 2016 at 12:50:06PM +0200, Netanel Belgazal wrote: > This is a driver for the Amazon ethernet ENA family. ethernet ->

[PATCH v2 net-next] rds-tcp: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-15 Thread Sowmini Varadhan
Add per-net sysctl tunables to set the size of sndbuf and rcvbuf on the kernel tcp socket. The tunables are added at /proc/sys/net/rds/tcp/rds_tcp_sndbuf and /proc/sys/net/rds/tcp/rds_tcp_rcvbuf. These values must be set before accept() or connect(), and there may be an arbitrary number of

Re: When will net-next merge with linux-next?

2016-03-15 Thread gre...@linuxfoundation.org
On Tue, Mar 15, 2016 at 11:11:34AM +, Dexuan Cui wrote: > I'm wondering whether (and when) step 2 will happen in the next 2 weeks, > that is, before the tag 4.6-rc1 is made. > If not, I guess I'll miss 4.6? You missed 4.6 as your patch was not in any of our trees a few days before 4.5 was

Re: [PATCH v7 net-next] ravb: Add dma queue interrupt support

2016-03-15 Thread Yoshihiro Kaneko
Hi, 2016-03-15 5:48 GMT+09:00 Sergei Shtylyov : > Hello. > > > On 03/13/2016 09:11 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple

Re: [PATCH] ARC: axs10x - add Ethernet PHY description in .dts

2016-03-15 Thread Alexey Brodkin
Hi Sergei, On Tue, 2016-03-15 at 17:38 +0300, Sergei Shtylyov wrote: > Hello. > > On 3/15/2016 12:29 PM, Alexey Brodkin wrote: > > > > > Following commit broke DW GMAC functionality on AXS10x boards: > >

[patch iproute2 2/2] add devlink tool

2016-03-15 Thread Jiri Pirko
From: Jiri Pirko Add new tool called devlink which is userspace counterpart of devlink Netlink socket. Signed-off-by: Jiri Pirko --- Makefile | 2 +- devlink/Makefile | 20 + devlink/devlink.c | 979

[patch iproute2 1/2] include: add linked list implementation from kernel

2016-03-15 Thread Jiri Pirko
From: Jiri Pirko Rename hlist.h to list.h while adding it to be aligned with kernel Signed-off-by: Jiri Pirko --- include/hlist.h | 56 include/list.h | 112

Re: [PATCH] ARC: axs10x - add Ethernet PHY description in .dts

2016-03-15 Thread Sergei Shtylyov
Hello. On 3/15/2016 12:29 PM, Alexey Brodkin wrote: Following commit broke DW GMAC functionality on AXS10x boards: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763 That's what happens on eth0 up:

Re: [PATCH] af_unix: closed SOCK_SEQPACKET socketpair must get SIGPIPE

2016-03-15 Thread Alexander Potapenko
On Tue, Mar 15, 2016 at 2:20 PM, Eric Dumazet wrote: > On Tue, 2016-03-15 at 10:03 +0100, Alexander Potapenko wrote: >> According to IEEE Std 1003.1, 2013, sending data to a SOCK_SEQPACKET >> socketpair with MSG_NOSIGNAL flag set must result in a SIGPIPE if the >> socket

RE: [PATCH v3] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-15 Thread Ramesh Shanmugasundaram
Hi Marc, > Subject: Re: [PATCH v3] can: rcar_canfd: Add Renesas R-Car CAN FD driver > > On 03/15/2016 10:48 AM, Ramesh Shanmugasundaram wrote: > > This patch adds support for the CAN FD controller found in Renesas > > R-Car SoCs. The controller operates in CAN FD only mode by default. > > > >

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

2016-03-15 Thread Or Gerlitz
On Tue, Mar 15, 2016 at 2:18 PM, Christoph Hellwig wrote: > On Tue, Mar 15, 2016 at 12:40:06PM +0200, Or Gerlitz wrote: >> "[..] Regarding backward compatibility in SR-IOV, if hypervisor has >> this new code, the virtual OS must be updated. [...]" > Which is broken, we can't

Re: [PATCH net-next v2 3/3] macsec: introduce IEEE 802.1AE driver

2016-03-15 Thread Johannes Berg
Hi, > +struct macsec_rx_sa_stats { > + __u32 InPktsOK; > + __u32 InPktsInvalid; > + __u32 InPktsNotValid; > + __u32 InPktsNotUsingSA; > + __u32 InPktsUnusedSA; > +}; > + > +struct macsec_tx_sa_stats { > + __u32 OutPktsProtected; > + __u32 OutPktsEncrypted; > +}; Just

RE: [PATCH] af_unix: closed SOCK_SEQPACKET socketpair must get SIGPIPE

2016-03-15 Thread David Laight
From: Alexander Potapenko > Sent: 15 March 2016 09:04 > According to IEEE Std 1003.1, 2013, sending data to a SOCK_SEQPACKET > socketpair with MSG_NOSIGNAL flag set must result in a SIGPIPE if the > socket is no longer connected. ... > Without the below patch the behavior is as follows: > > $

Re: [PATCH] af_unix: closed SOCK_SEQPACKET socketpair must get SIGPIPE

2016-03-15 Thread Eric Dumazet
On Tue, 2016-03-15 at 10:03 +0100, Alexander Potapenko wrote: > According to IEEE Std 1003.1, 2013, sending data to a SOCK_SEQPACKET > socketpair with MSG_NOSIGNAL flag set must result in a SIGPIPE if the > socket is no longer connected. I find this sentence slightly confusing ? If MSG_NOSIGNAL

Re: [PATCH v3] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-15 Thread Marc Kleine-Budde
On 03/15/2016 10:48 AM, Ramesh Shanmugasundaram wrote: > This patch adds support for the CAN FD controller found in Renesas R-Car > SoCs. The controller operates in CAN FD only mode by default. > > CAN FD mode supports both Classical CAN & CAN FD frame formats. The > controller supports ISO

Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

2016-03-15 Thread Giuseppe CAVALLARO
Hello Tomeu On 3/15/2016 8:23 AM, Tomeu Vizoso wrote: Thanks. Btw, I have rebased on top of 4.5 this morning and I have noticed that 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression") got in there, so I guess we have now a bunch of boards with broken network on that release:( This

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-15 Thread Bjørn Mork
Schemmel Hans-Christoph writes: > If you are not the intended recipient of this message, please delete it and > notify the sender. OK. Deleted. Bjørn

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-03-15 Thread kbuild test robot
Hi Netanel, [auto build test ERROR on net-next/master] [also build test ERROR on v4.5 next-20160315] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Netanel-Belgazal/net-ena-Add-a-driver

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

2016-03-15 Thread Christoph Hellwig
On Tue, Mar 15, 2016 at 12:40:06PM +0200, Or Gerlitz wrote: > "[..] Regarding backward compatibility in SR-IOV, if hypervisor has > this new code, the virtual OS must be updated. [...]" Which is broken, we can't break user or guest VM ABIs ever.

[PATCH] rtnetlink.7: add missing RTA_* attributes

2016-03-15 Thread Jan Moskyto Matejka
Used Bird's source code, kernel source code, iproute2 source code and iproute2 manpages to find meanings of these new attributes. Signed-off-by: Jan Moskyto Matejka --- man7/rtnetlink.7 | 61 ++-- 1 file changed, 55 insertions(+),

[ANNOUNCE] NetDev 1.1 videos now available

2016-03-15 Thread Pablo Neira Ayuso
Hi, Today we're releasing the NetDev 1.1 videos, you can find them at: https://www.youtube.com/channel/UCribHdOMgiD5R3OUDgx2qTg Regarding papers: Quick reminder to talk presenters that didn't sent us yet your paper, we have extended submission deadline to *31th March 2016*. You only

[PATCH net 1/1] qlge: Fix receive packets drop.

2016-03-15 Thread Manish Chopra
When running small packets [length < 256 bytes] traffic, packets were being dropped due to invalid data in those packets which were delivered by the driver upto the stack. Using pci_dma_sync_single_for_cpu ensures copying latest and updated data into skb from the receive buffer. Signed-off-by:

RE: When will net-next merge with linux-next?

2016-03-15 Thread Dexuan Cui
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, March 15, 2016 0:22 > To: Dexuan Cui > Cc: David Miller ; netdev@vger.kernel.org; KY > Srinivasan ; Haiyang Zhang >

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

2016-03-15 Thread Or Gerlitz
On Tue, Mar 15, 2016 at 12:19 PM, Alexey Kardashevskiy wrote: > This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. > > Without this revert, POWER "pseries" KVM guests with a VF passed to a guest > using VFIO fail to bring the driver up: > > mlx4_core: Mellanox ConnectX

[RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

2016-03-15 Thread Alexey Kardashevskiy
This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. Without this revert, POWER "pseries" KVM guests with a VF passed to a guest using VFIO fail to bring the driver up: mlx4_core: Mellanox ConnectX core driver v2.2-1 (Feb, 2014) mlx4_core: Initializing :00:00.0 mlx4_core

Re: [PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t

2016-03-15 Thread Joe Perches
On Tue, 2016-03-15 at 11:03 +0100, Arnd Bergmann wrote: > A recent change to the mbus driver added a warning printk that > prints a phys_addr_t using the %x format string, which fails in > case we build with 64-bit phys_addr_t: Hey Arnd. This is a bad patch subject, %pad is for a dma_addr_t. The

[PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t

2016-03-15 Thread Arnd Bergmann
A recent change to the mbus driver added a warning printk that prints a phys_addr_t using the %x format string, which fails in case we build with 64-bit phys_addr_t: drivers/bus/mvebu-mbus.c: In function 'mvebu_mbus_get_dram_win_info': drivers/bus/mvebu-mbus.c:975:9: error: format '%x' expects

[PATCH v3] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-15 Thread Ramesh Shanmugasundaram
This patch adds support for the CAN FD controller found in Renesas R-Car SoCs. The controller operates in CAN FD only mode by default. CAN FD mode supports both Classical CAN & CAN FD frame formats. The controller supports ISO 11898-1:2015 CAN FD format only. This controller supports two

[PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-15 Thread Schemmel Hans-Christoph
Added support for Cinterion's PHxx WWAN interfaces by adding QMI_FIXED_INTF with Cinterion's VID and PID. PHxx can have 2 RmNet Interfaces (PID 0x0082) or 1 RmNet + 1 USB Audio interface (PID 0x0083). Signed-off-by: Hans-Christoph Schemmel --- patch is

[PATCH] ARC: axs10x - add Ethernet PHY description in .dts

2016-03-15 Thread Alexey Brodkin
Following commit broke DW GMAC functionality on AXS10x boards: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763 That's what happens on eth0 up: --->8 libphy: PHY stmmac-0: not

Re: [PATCH] SOCK_SEQPACKET socketpair must get SIGPIPE in AF_UNIX if one end is closed

2016-03-15 Thread Alexander Potapenko
Done, thanks for your response! On Mon, Mar 14, 2016 at 8:19 PM, David Miller wrote: > From: Alexander Potapenko > Date: Wed, 9 Mar 2016 15:10:23 +0100 > >> According to IEEE Std 1003.1, 2013, sending data to a SOCK_SEQPACKET >> socketpair with

[PATCH] af_unix: closed SOCK_SEQPACKET socketpair must get SIGPIPE

2016-03-15 Thread Alexander Potapenko
According to IEEE Std 1003.1, 2013, sending data to a SOCK_SEQPACKET socketpair with MSG_NOSIGNAL flag set must result in a SIGPIPE if the socket is no longer connected. I used the following program to check the kernel behavior: /*/ #include #include #include #include

  1   2   >