Re: [PATCH net] netfilter: nf_conntrack: Use net_mutex for helper unregistration.

2016-05-16 Thread Joe Stringer
On 6 May 2016 at 04:03, Pablo Neira Ayuso wrote: > Hi Joe, > > On Thu, May 05, 2016 at 03:50:37PM -0700, Joe Stringer wrote: >> diff --git a/net/netfilter/nf_conntrack_helper.c >> b/net/netfilter/nf_conntrack_helper.c >> index 3b40ec575cd5..6860b19be406 100644 >> ---

[PATCH] asix: Fix offset calculation in asix_rx_fixup() causing slow transmissions

2016-05-16 Thread John Stultz
In testing with HiKey, we found that since commit 3f30b158eba5 ("asix: On RX avoid creating bad Ethernet frames"), we're seeing lots of noise during network transfers: [ 239.027993] asix 1-1.1:1.0 eth0: asix_rx_fixup() Data Header synchronisation was lost, remaining 988 [ 239.037310] asix

[PATCH 2/2] net: Fix coding style warnings and errors.

2016-05-16 Thread Amit Ghadge
Clean up checkpatch warnings and errors: * WARNING: Block comments use * on subsequent lines * WARNING: Missing a blank line after declarations * WARNING: networking block comments don't use an empty /* line, use /* * ERROR: code indent should use tabs where possible * WARNING: please, no space

RE: [PATCH v11 net-next 0/1] introduce Hyper-V VM Sockets(hv_sock)

2016-05-16 Thread Dexuan Cui
> From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, May 16, 2016 1:16 > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com;

Re: [PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY

2016-05-16 Thread Lorenzo Colitti
On Tue, May 17, 2016 at 11:24 AM, David Ahern wrote: > As I mentioned we can print the unsupported once or per socket matched and > with the socket params. e.g., > > + } else if (errno == EOPNOTSUPP) { > + printf("Operation not

[net-next 1/2] ixgbe: use correct mask when enabling sriov

2016-05-16 Thread Jeff Kirsher
From: Emil Tantilov Swap the parameters in GENMASK in order to generate the correct mask. This change fixes Tx hangs when enabling SRIOV. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers Signed-off-by: Jeff

[net-next 0/2][pull request] 10GbE Intel Wired LAN Driver Updates 2016-05-16

2016-05-16 Thread Jeff Kirsher
This series contains 2 fixes to ixgbe only. Emil fixes transmit hangs when enabling SRIOV by swapping the parameters in GENMASK in order to generate the correct mask. Alex fixes his previous patch b83e30104bd9 ("ixgbe/ixgbevf: Add support for GSO partial") where he somehow transposed the

[net-next 2/2] ixgbe: Fix VLAN features error

2016-05-16 Thread Jeff Kirsher
From: Alexander Duyck It looks like at some point I somehow transposed the location of setting the VLAN features in netdev->features and the configuration of the vlan_features. As a result the driver is now generating a warning about vlan_features being setup incorrectly.

Re: [PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY

2016-05-16 Thread David Ahern
On 5/16/16 8:04 PM, Lorenzo Colitti wrote: Given that the filter can specify a number of sockets, some of which can and some of which can't be closed, and that whether a given socket can be closed is only known at the time we attempt to close it, there is a choice between two bad outcomes: 1.

Re: [PATCH 1/2] net: ethernet: fec-mpc52xx: use phydev from struct net_device

2016-05-16 Thread David Miller
From: Philippe Reynes Date: Tue, 17 May 2016 00:32:33 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one

Re: [PATCH 2/2] net: ethernet: fec-mpc52xx: use phy_ethtool_{get|set}_link_ksettings

2016-05-16 Thread David Miller
From: Philippe Reynes Date: Tue, 17 May 2016 00:32:34 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH net-next] bpf, doc: fix typo on bpf_asm descriptions

2016-05-16 Thread David Miller
From: Daniel Borkmann Date: Mon, 16 May 2016 23:06:53 +0200 > Fix description of some of the bpf_asm tool related jump instructions > and generally move them to format A k. > > Reported-by: Sebastian Amend > Signed-off-by: Daniel Borkmann

Re: [PATCH] stmmac: hardware TX COE doesn't work when force_thresh_dma_mode is set

2016-05-16 Thread David Miller
From: Ezequiel Garcia Date: Mon, 16 May 2016 12:41:07 -0300 > Commit f748be531d70 ("stmmac: support new GMAC4") reverted a previous fix > by mistake. This commit re-applies said fix: > > commit dec2165ff38a99f937fe61875d102c6c8596c815 > Author: Sonic Zhang

Re: [PATCH 2/2] net: ethernet: fs-enet: use phy_ethtool_{get|set}_link_ksettings

2016-05-16 Thread David Miller
From: Philippe Reynes Date: Mon, 16 May 2016 16:52:37 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: fs-enet: use phydev from struct net_device

2016-05-16 Thread David Miller
From: Philippe Reynes Date: Mon, 16 May 2016 16:52:36 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one

Re: BUG: use-after-free in netlink_dump

2016-05-16 Thread David Miller
From: Herbert Xu Date: Mon, 16 May 2016 17:28:16 +0800 > Subject: netlink: Fix dump skb leak/double free > > When we free cb->skb after a dump, we do it after releasing the > lock. This means that a new dump could have started in the time > being and we'll end up

Re: [PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY

2016-05-16 Thread Lorenzo Colitti
On Tue, May 17, 2016 at 10:52 AM, David Ahern wrote: > code is not setup to handle that. Only option seems to be at least dump an > error message, but the message can not relate any of the specifics about the > filter. So something like this though it dumps the message

[PATCH 3.14 14/17] VSOCK: do not disconnect socket when peer has shutdown SEND only

2016-05-16 Thread Greg Kroah-Hartman
3.14-stable review patch. If anyone has any objections, please let me know. -- From: Ian Campbell [ Upstream commit dedc58e067d8c379a15a8a183c5db318201295bb ] The peer may be expecting a reply having sent a request and then done a shutdown(SHUT_WR),

Re: [PATCH net-next] tipc: check nl sock before parsing nested attributes

2016-05-16 Thread David Miller
From: Richard Alpe Date: Mon, 16 May 2016 11:14:54 +0200 > Make sure the socket for which the user is listing publication exists > before parsing the socket netlink attributes. > > Prior to this patch a call without any socket caused a NULL pointer > dereference in

Re: [PATCH net-next] fq_codel: fix memory limitation drift

2016-05-16 Thread David Miller
From: Eric Dumazet Date: Sun, 15 May 2016 18:16:38 -0700 > From: Eric Dumazet > > memory_usage must be decreased in dequeue_func(), not in > fq_codel_dequeue(), otherwise packets dropped by Codel algo > are missing this decrease. > > Also we need

[PATCH 4.4 31/73] VSOCK: do not disconnect socket when peer has shutdown SEND only

2016-05-16 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Ian Campbell [ Upstream commit dedc58e067d8c379a15a8a183c5db318201295bb ] The peer may be expecting a reply having sent a request and then done a shutdown(SHUT_WR), so

Re: [PATCH 1/2] net: ethernet: gianfar: use phydev from struct net_device

2016-05-16 Thread David Miller
From: Philippe Reynes Date: Mon, 16 May 2016 01:30:08 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one

Re: [PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY

2016-05-16 Thread David Ahern
On 5/16/16 7:20 PM, Lorenzo Colitti wrote: On Tue, May 17, 2016 at 10:14 AM, David Ahern wrote: For example, EOPNOTSUPP can just mean "this socket can't be closed because it's a timewait or NEW_SYN_RECV socket". In hindsight it might have been better to return EBADFD

Re: [PATCH 1/2] net: ethernet: ftgmac100: use phydev from struct net_device

2016-05-16 Thread David Miller
From: Philippe Reynes Date: Mon, 16 May 2016 01:35:13 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one

Re: [PATCH 2/2] net: ethernet: ftgmac100: use phy_ethtool_{get|set}_link_ksettings

2016-05-16 Thread David Miller
From: Philippe Reynes Date: Mon, 16 May 2016 01:35:14 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Regarding vxlan unicast configuration

2016-05-16 Thread Ajith Adapa
Hi, I am trying vxlan unicast configuration on a back to back connected interfaces of VM1 and VM2 running fedora 23 with 4.2 version of kernel. Below is my configuration VM1 ip address add 100.1.1.1/24 dev enp0s8 ifconfig enp0s8 up ip link add name vxlan42 type vxlan id 42 dev enp0s8 remote

Re: [PATCH 2/2] net: ethernet: gianfar: use phy_ethtool_{get|set}_link_ksettings

2016-05-16 Thread David Miller
From: Philippe Reynes Date: Mon, 16 May 2016 01:30:09 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH net-next] tuntap: introduce tx skb ring

2016-05-16 Thread Jason Wang
On 2016年05月16日 16:08, Michael S. Tsirkin wrote: On Mon, May 16, 2016 at 03:52:11PM +0800, Jason Wang wrote: On 2016年05月16日 12:23, Michael S. Tsirkin wrote: On Mon, May 16, 2016 at 09:17:01AM +0800, Jason Wang wrote: We used to queue tx packets in sk_receive_queue, this is less efficient

[PATCH 4.5 036/101] VSOCK: do not disconnect socket when peer has shutdown SEND only

2016-05-16 Thread Greg Kroah-Hartman
4.5-stable review patch. If anyone has any objections, please let me know. -- From: Ian Campbell [ Upstream commit dedc58e067d8c379a15a8a183c5db318201295bb ] The peer may be expecting a reply having sent a request and then done a shutdown(SHUT_WR), so

Re: [PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY

2016-05-16 Thread Lorenzo Colitti
On Tue, May 17, 2016 at 10:14 AM, David Ahern wrote: >> >> For example, EOPNOTSUPP can just mean "this socket can't be closed >> because it's a timewait or NEW_SYN_RECV socket". In hindsight it might >> have been better to return EBADFD in those cases, but that still >>

Re: [PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY

2016-05-16 Thread David Ahern
On 5/16/16 7:01 PM, Lorenzo Colitti wrote: On Tue, May 17, 2016 at 8:53 AM, David Ahern wrote: @@ -2264,7 +2264,7 @@ static int show_one_inet_sock(const struct sockaddr_nl *addr, if (!(diag_arg->f->families & (1 << r->idiag_family))) return 0;

Re: [PATCH] net: diag: Tell user if support for destroying TCP sockets is not enabled

2016-05-16 Thread David Ahern
On 5/16/16 6:49 PM, Lorenzo Colitti wrote: On Tue, May 17, 2016 at 8:53 AM, David Ahern wrote: +#else +static int tcp_diag_destroy(struct sk_buff *in_skb, + const struct inet_diag_req_v2 *req) +{ + return -EOPNOTSUPP; +} #endif I

Re: [PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY

2016-05-16 Thread Lorenzo Colitti
On Tue, May 17, 2016 at 8:53 AM, David Ahern wrote: > @@ -2264,7 +2264,7 @@ static int show_one_inet_sock(const struct sockaddr_nl > *addr, > if (!(diag_arg->f->families & (1 << r->idiag_family))) > return 0; > if (diag_arg->f->kill &&

Re: [PATCH] net: diag: Tell user if support for destroying TCP sockets is not enabled

2016-05-16 Thread Lorenzo Colitti
On Tue, May 17, 2016 at 8:53 AM, David Ahern wrote: > +#else > +static int tcp_diag_destroy(struct sk_buff *in_skb, > + const struct inet_diag_req_v2 *req) > +{ > + return -EOPNOTSUPP; > +} > #endif I don't understand why you need this.

linux-next: manual merge of the net-next tree with the arm64 tree

2016-05-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: arch/arm64/Kconfig between commit: 8ee708792e1c ("arm64: Kconfig: remove redundant HAVE_ARCH_TRANSPARENT_HUGEPAGE definition") from the arm64 tree and commit: 606b5908 ("bpf: split HAVE_BPF_JIT into cBPF and

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-16 Thread John Stultz
On Wed, May 11, 2016 at 3:00 PM, Dean Jenkins wrote: > > Your observations are consistent with missing URBs from the USB host > controller. > > Here is a summary of what I think is happening in your case: > > Good case: > URB #1: 1514 octets of 1514 Ethernet frame (A) >

[PATCH v2 net-next] bpf: arm64: remove callee-save registers use for tmp registers

2016-05-16 Thread Yang Shi
In the current implementation of ARM64 eBPF JIT, R23 and R24 are used for tmp registers, which are callee-saved registers. This leads to variable size of JIT prologue and epilogue. The latest blinding constant change prefers to constant size of prologue and epilogue. AAPCS reserves R9 ~ R15 for

Re: [PATCH v6 net-next 14/14] ip4ip6: Support for GSO/GRO

2016-05-16 Thread Alexander Duyck
On Mon, May 16, 2016 at 2:33 PM, Tom Herbert wrote: > Signed-off-by: Tom Herbert > --- > include/net/inet_common.h | 5 + > net/ipv4/af_inet.c| 12 +++- > net/ipv6/ip6_offload.c| 33 - >

[PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY

2016-05-16 Thread David Ahern
Silent failures are not friendly to the user. If a command is not supported tell the user about it. Signed-off-by: David Ahern --- misc/ss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index 23fff19d9199..bd7214c85938

[PATCH] net: diag: Tell user if support for destroying TCP sockets is not enabled

2016-05-16 Thread David Ahern
Commit c1e64e298b8c added support for destroying TCP sockets but it is wrapped in a config option. If the option is not enabled the user is given no feedback and ss for example just exits 0 which is not a friendly UI: $ ss -4 state established sport = :22 Netid Recv-Q Send-Q Local

Re: [PATCH v6 net-next 13/14] ip6ip6: Support for GSO/GRO

2016-05-16 Thread Alexander Duyck
On Mon, May 16, 2016 at 2:33 PM, Tom Herbert wrote: > Signed-off-by: Tom Herbert > --- > net/ipv6/ip6_offload.c | 24 +--- > net/ipv6/ip6_tunnel.c | 3 +++ > 2 files changed, 24 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH net-next] bpf: arm64: remove callee-save registers use for tmp registers

2016-05-16 Thread Shi, Yang
On 5/16/2016 4:45 PM, Z Lim wrote: Hi Yang, On Mon, May 16, 2016 at 4:09 PM, Yang Shi wrote: In the current implementation of ARM64 eBPF JIT, R23 and R24 are used for tmp registers, which are callee-saved registers. This leads to variable size of JIT prologue and

Re: [ethtool 0/3][pull request] Intel Wired LAN Driver Updates 2016-05-03

2016-05-16 Thread Jeff Kirsher
On Wed, 2016-05-04 at 09:44 -0700, Jeff Kirsher wrote: > This series contains updates to ixgbe in ethtool. > > Preethi adds missing device IDs and mac_type definitions, also updated > the display registers for x550, x550em_x/a.  Cleaned up the format string > storage by taking advantage of "for"

Re: [PATCH net-next] bpf: arm64: remove callee-save registers use for tmp registers

2016-05-16 Thread Z Lim
Hi Yang, On Mon, May 16, 2016 at 4:09 PM, Yang Shi wrote: > In the current implementation of ARM64 eBPF JIT, R23 and R24 are used for > tmp registers, which are callee-saved registers. This leads to variable size > of JIT prologue and epilogue. The latest blinding constant

[PATCH net-next] bpf: arm64: remove callee-save registers use for tmp registers

2016-05-16 Thread Yang Shi
In the current implementation of ARM64 eBPF JIT, R23 and R24 are used for tmp registers, which are callee-saved registers. This leads to variable size of JIT prologue and epilogue. The latest blinding constant change prefers to constant size of prologue and epilogue. AAPCS reserves R9 ~ R15 for

Re: [PATCH v2] r8169: default to 64-bit DMA on recent PCIe chips

2016-05-16 Thread Francois Romieu
Ard Biesheuvel : [...] > This is a followup to 'r8169: default to 64-bit DMA on systems without memory > below 4 GB' [1]. At the request of Francois, this version bases the decision > whether to use 64-bit DMA by default on whether the device is PCIe and > sufficiently

Re: [PATCH v6 net-next 09/14] ip6_tun: Add infrastructure for doing encapsulation

2016-05-16 Thread Alexander Duyck
On Mon, May 16, 2016 at 3:37 PM, Tom Herbert wrote: > On Mon, May 16, 2016 at 3:25 PM, Alexander Duyck > wrote: >> On Mon, May 16, 2016 at 2:33 PM, Tom Herbert wrote: >>> Add encap_hlen and ip_tunnel_encap structure to

Re: task_diag: add a new interface to get information about processes

2016-05-16 Thread Andrew Vagin
On Wed, May 04, 2016 at 08:39:51PM -0700, Andy Lutomirski wrote: > > Linus, this is Yet Another Credential Fuckup, except that it hasn't > happened yet, so it's okay. The tl;dr is that Andrey wants to add an > interface to ask a pidns some questions, and netlink looks natural, > except that

Re: [PATCH v6 net-next 09/14] ip6_tun: Add infrastructure for doing encapsulation

2016-05-16 Thread Tom Herbert
On Mon, May 16, 2016 at 3:25 PM, Alexander Duyck wrote: > On Mon, May 16, 2016 at 2:33 PM, Tom Herbert wrote: >> Add encap_hlen and ip_tunnel_encap structure to ip6_tnl. Add functions >> for getting encap hlen, setting up encap on a tunnel,

[PATCH] net: don't lose features in netdev_add_tso_features()

2016-05-16 Thread Dimitris Michailidis
The goal of netdev_add_tso_features() is to enable all TSO features but it unintentionally loses NETIF_F_ALL_FOR_ALL features. This is because the netdev_increment_features() it calls clears any NETIF_F_ALL_FOR_ALL bits that aren't included in the incremental features and none of them are included

[PATCH 1/2] net: ethernet: fec-mpc52xx: use phydev from struct net_device

2016-05-16 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes ---

[PATCH 2/2] net: ethernet: fec-mpc52xx: use phy_ethtool_{get|set}_link_ksettings

2016-05-16 Thread Philippe Reynes
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/freescale/fec_mpc52xx.c | 26 ++ 1 files changed, 2

RE: [Intel-wired-lan] [PATCH] e1000e: prevent division by zero if TIMINCA is zero

2016-05-16 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Denys Vlasenko > Sent: Friday, May 6, 2016 12:42 PM > To: Kirsher, Jeffrey T > Cc: intel-wired-...@lists.osuosl.org; Denys Vlasenko > ; LKML

Re: [PATCH v6 net-next 09/14] ip6_tun: Add infrastructure for doing encapsulation

2016-05-16 Thread Alexander Duyck
On Mon, May 16, 2016 at 2:33 PM, Tom Herbert wrote: > Add encap_hlen and ip_tunnel_encap structure to ip6_tnl. Add functions > for getting encap hlen, setting up encap on a tunnel, performing > encapsulation operation. > > Signed-off-by: Tom Herbert >

[Patch net] net_sched: close another race condition in tcf_mirred_release()

2016-05-16 Thread Cong Wang
We saw the following extra refcount release on veth device: kernel: [7957821.463992] unregister_netdevice: waiting for mesos50284 to become free. Usage count = -1 Since we heavily use mirred action to redirect packets to veth, I think this is caused by the following race condition: CPU0:

Re: [PATCH net-next] bpf, doc: fix typo on bpf_asm descriptions

2016-05-16 Thread Alexei Starovoitov
On Mon, May 16, 2016 at 11:06:53PM +0200, Daniel Borkmann wrote: > Fix description of some of the bpf_asm tool related jump instructions > and generally move them to format A k. > > Reported-by: Sebastian Amend > Signed-off-by: Daniel Borkmann

[PATCH v6 net-next 01/14] gso: Remove arbitrary checks for unsupported GSO

2016-05-16 Thread Tom Herbert
In several gso_segment functions there are checks of gso_type against a seemingly arbitrary list of SKB_GSO_* flags. This seems like an attempt to identify unsupported GSO types, but since the stack is the one that set these GSO types in the first place this seems unnecessary to do. If a

[PATCH v6 net-next 10/14] fou: Add encap ops for IPv6 tunnels

2016-05-16 Thread Tom Herbert
This patch add a new fou6 module that provides encapsulation operations for IPv6. Signed-off-by: Tom Herbert --- include/net/fou.h | 2 +- net/ipv6/Makefile | 1 + net/ipv6/fou6.c | 140 ++ 3 files changed, 142

[PATCH v6 net-next 11/14] ip6_gre: Add support for fou/gue encapsulation

2016-05-16 Thread Tom Herbert
Add netlink and setup for encapsulation Signed-off-by: Tom Herbert --- net/ipv6/ip6_gre.c | 79 +++--- 1 file changed, 75 insertions(+), 4 deletions(-) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index

[PATCH v6 net-next 03/14] ipv6: Fix nexthdr for reinjection

2016-05-16 Thread Tom Herbert
In ip6_input_finish the nexthdr protocol is retrieved from the next header offset that is returned in the cb of the skb. This method does not work for UDP encapsulation that may not even have a concept of a nexthdr field (e.g. FOU). This patch checks for a final protocol (INET6_PROTO_FINAL) when

[PATCH v6 net-next 14/14] ip4ip6: Support for GSO/GRO

2016-05-16 Thread Tom Herbert
Signed-off-by: Tom Herbert --- include/net/inet_common.h | 5 + net/ipv4/af_inet.c| 12 +++- net/ipv6/ip6_offload.c| 33 - net/ipv6/ip6_tunnel.c | 3 +++ 4 files changed, 47 insertions(+), 6 deletions(-) diff

[PATCH v6 net-next 06/14] fou: Call setup_udp_tunnel_sock

2016-05-16 Thread Tom Herbert
Use helper function to set up UDP tunnel related information for a fou socket. Signed-off-by: Tom Herbert --- net/ipv4/fou.c | 50 -- 1 file changed, 16 insertions(+), 34 deletions(-) diff --git a/net/ipv4/fou.c

[PATCH v6 net-next 07/14] fou: Split out {fou,gue}_build_header

2016-05-16 Thread Tom Herbert
Create __fou_build_header and __gue_build_header. These implement the protocol generic parts of building the fou and gue header. fou_build_header and gue_build_header implement the IPv4 specific functions and call the __*_build_header functions. Signed-off-by: Tom Herbert

[PATCH v6 net-next 08/14] fou: Support IPv6 in fou

2016-05-16 Thread Tom Herbert
This patch adds receive path support for IPv6 with fou. - Add address family to fou structure for open sockets. This supports AF_INET and AF_INET6. Lookups for fou ports are performed on both the port number and family. - In fou and gue receive adjust tot_len in IPv4 header or payload_len

[PATCH v6 net-next 09/14] ip6_tun: Add infrastructure for doing encapsulation

2016-05-16 Thread Tom Herbert
Add encap_hlen and ip_tunnel_encap structure to ip6_tnl. Add functions for getting encap hlen, setting up encap on a tunnel, performing encapsulation operation. Signed-off-by: Tom Herbert --- include/net/ip6_tunnel.h | 58

[PATCH v6 net-next 12/14] ip6_tunnel: Add support for fou/gue encapsulation

2016-05-16 Thread Tom Herbert
Add netlink and setup for encapsulation Signed-off-by: Tom Herbert --- net/ipv6/ip6_tunnel.c | 72 +++ 1 file changed, 72 insertions(+) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index ec53612..8076c7a 100644

[PATCH v6 net-next 13/14] ip6ip6: Support for GSO/GRO

2016-05-16 Thread Tom Herbert
Signed-off-by: Tom Herbert --- net/ipv6/ip6_offload.c | 24 +--- net/ipv6/ip6_tunnel.c | 3 +++ 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c index 787e55f..332d6a0 100644 ---

[PATCH v6 net-next 05/14] net: Cleanup encap items in ip_tunnels.h

2016-05-16 Thread Tom Herbert
Consolidate all the ip_tunnel_encap definitions in one spot in the header file. Also, move ip_encap_hlen and ip_tunnel_encap from ip_tunnel.c to ip_tunnels.h so they call be called without a dependency on ip_tunnel module. Similarly, move iptun_encaps to ip_tunnel_core.c. Signed-off-by: Tom

[PATCH v6 net-next 02/14] net: define gso types for IPx over IPv4 and IPv6

2016-05-16 Thread Tom Herbert
This patch defines two new GSO definitions SKB_GSO_IPXIP4 and SKB_GSO_IPXIP6 along with corresponding NETIF_F_GSO_IPXIP4 and NETIF_F_GSO_IPXIP6. These are used to described IP in IP tunnel and what the outer protocol is. The inner protocol can be deduced from other GSO types (e.g. SKB_GSO_TCPV4

[PATCH v6 net-next 04/14] ipv6: Change "final" protocol processing for encapsulation

2016-05-16 Thread Tom Herbert
When performing foo-over-UDP, UDP packets are processed by the encapsulation handler which returns another protocol to process. This may result in processing two (or more) protocols in the loop that are marked as INET6_PROTO_FINAL. The actions taken for hitting a final protocol, in particular the

[PATCH v6 net-next 00/14] ipv6: Enable GUEoIPv6 and more fixes for v6 tunneling

2016-05-16 Thread Tom Herbert
This patch set: - Fixes GRE6 to process translate flags correctly from configuration - Adds support for GSO and GRO for ip6ip6 and ip4ip6 - Add support for FOU and GUE in IPv6 - Support GRE, ip6ip6 and ip4ip6 over FOU/GUE - Fixes ip6_input to deal with UDP encapsulations - Some other

[PATCH net-next] bpf, doc: fix typo on bpf_asm descriptions

2016-05-16 Thread Daniel Borkmann
Fix description of some of the bpf_asm tool related jump instructions and generally move them to format A k. Reported-by: Sebastian Amend Signed-off-by: Daniel Borkmann --- Documentation/networking/filter.txt | 16 1 file

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-16 Thread Jeff Kirsher
On Fri, 2016-05-13 at 14:56 +0900, Ethan Zhao wrote: > Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less > CPUs were assigned. especially when DCB is enabled, so we should take > num_online_cpus() as top limit, and aslo to make sure every TC has > at least one queue, take the

Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional

2016-05-16 Thread Dan Murphy
On 05/16/2016 01:52 PM, Alexander Graf wrote: > If you compile without OF_MDIO support in an RGMII configuration, we fail > to configure the dp83867 phy today by writing garbage into its configuration > registers. > > On the other hand if you do compile with OF_MDIO and the phy gets loaded via >

Re: [PATCH v5 net-next 09/14] ip6_tun: Add infrastructure for doing encapsulation

2016-05-16 Thread Alexander Duyck
On Mon, May 16, 2016 at 12:28 PM, Tom Herbert wrote: > On Mon, May 16, 2016 at 12:24 PM, Alexander Duyck > wrote: >> On Sun, May 15, 2016 at 4:42 PM, Tom Herbert wrote: >>> Add encap_hlen and ip_tunnel_encap structure to

Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional

2016-05-16 Thread Andrew Lunn
On Mon, May 16, 2016 at 08:52:43PM +0200, Alexander Graf wrote: > If you compile without OF_MDIO support in an RGMII configuration, we fail > to configure the dp83867 phy today by writing garbage into its configuration > registers. > > On the other hand if you do compile with OF_MDIO and the phy

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

2016-05-16 Thread Roman Yeryomin
On 16 May 2016 at 19:04, Dave Taht wrote: > On Mon, May 16, 2016 at 1:14 AM, Roman Yeryomin wrote: >> On 16 May 2016 at 01:34, Roman Yeryomin wrote: >>> On 6 May 2016 at 22:43, Dave Taht wrote: On Fri,

[PATCH] i40e: Fix errors resulted while turning off TSO

2016-05-16 Thread Tushar Dave
On systems with 128 CPUs, turning off TSO results in errors, i40e :03:00.0: failed to get tracking for 1 vectors for VSI 400, err=-12 i40e :03:00.0: Couldn't create FDir VSI i40e :03:00.0: i40e_ptp_init: PTP not supported on eth0 i40e :03:00.0: couldn't add VEB, err

i40e: Errors while turning off TSO

2016-05-16 Thread tndave
On systems with 128 CPUs, turning off TSO results in errors. Errors: i40e :03:00.0: failed to get tracking for 1 vectors for VSI 400, err=-12 i40e :03:00.0: Couldn't create FDir VSI i40e :03:00.0: i40e_ptp_init: PTP not supported on eth0 i40e :03:00.0: couldn't add VEB, err

Re: [PATCH v5 net-next 09/14] ip6_tun: Add infrastructure for doing encapsulation

2016-05-16 Thread Tom Herbert
On Mon, May 16, 2016 at 12:24 PM, Alexander Duyck wrote: > On Sun, May 15, 2016 at 4:42 PM, Tom Herbert wrote: >> Add encap_hlen and ip_tunnel_encap structure to ip6_tnl. Add functions >> for getting encap hlen, setting up encap on a tunnel,

Re: [PATCH v5 net-next 09/14] ip6_tun: Add infrastructure for doing encapsulation

2016-05-16 Thread Alexander Duyck
On Sun, May 15, 2016 at 4:42 PM, Tom Herbert wrote: > Add encap_hlen and ip_tunnel_encap structure to ip6_tnl. Add functions > for getting encap hlen, setting up encap on a tunnel, performing > encapsulation operation. > > Signed-off-by: Tom Herbert >

Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional

2016-05-16 Thread Florian Fainelli
On 05/16/2016 11:52 AM, Alexander Graf wrote: > If you compile without OF_MDIO support in an RGMII configuration, we fail > to configure the dp83867 phy today by writing garbage into its configuration > registers. > > On the other hand if you do compile with OF_MDIO and the phy gets loaded via >

[PATCH v2 2/2] phy dp83867: Make rgmii parameters optional

2016-05-16 Thread Alexander Graf
If you compile without OF_MDIO support in an RGMII configuration, we fail to configure the dp83867 phy today by writing garbage into its configuration registers. On the other hand if you do compile with OF_MDIO and the phy gets loaded via device tree, you have to have the properties set in the

[PATCH v2 1/2] phy dp83867: Fix compilation with CONFIG_OF_MDIO=m

2016-05-16 Thread Alexander Graf
When CONFIG_OF_MDIO is configured as module, the #define for it really is CONFIG_OF_MDIO_MODULE, not CONFIG_OF_MDIO. So if we are compiling it as module, the dp83867 doesn't see that OF_MDIO was selected and doesn't read the dt rgmii parameters. The fix is simple: Use IS_ENABLED(). It checks for

Re: [ANNOUNCE] Netdev 1.2 conference

2016-05-16 Thread Stephen Hemminger
On Tue, 17 May 2016 00:36:58 +0900 Hajime Tazaki wrote: > Following the last successful Netdev 0.1 in Ottawa, Canada and > 1.1 in Seville, Spain. We are happy to announce the third Netdev conference: > Netdev 1.2 (year 1, conference 2) from 5th to 7th October 2016 in Tokyo,

linux-4.6/net/kcm/kcmsock.c:1508: bad if test ?

2016-05-16 Thread David Binderman
Hello there, linux-4.6/net/kcm/kcmsock.c:1508]: (style) Checking if unsigned variable 'copied' is less than zero. Source code is if (copied < 0) { but size_t copied; Suggest code rework. Regards David Binderman

Re: [PATCH v5 net-next 03/14] ipv6: Fix nexthdr for reinjection

2016-05-16 Thread Tom Herbert
On Mon, May 16, 2016 at 11:19 AM, Shmulik Ladkani wrote: > Hi, > > On Sun, 15 May 2016 16:42:24 -0700 Tom Herbert wrote: >> In ip6_input_finish the nexthdr protocol is retrieved from the >> next header offset that is returned in the cb of the skb.

Re: [PATCH v5 net-next 02/14] net: define gso types for IPx over IPv4 and IPv6

2016-05-16 Thread Alexander Duyck
On Mon, May 16, 2016 at 11:28 AM, Tom Herbert wrote: > On Mon, May 16, 2016 at 11:13 AM, Alexander Duyck > wrote: >> On Mon, May 16, 2016 at 11:07 AM, Tom Herbert wrote: >>> On Mon, May 16, 2016 at 9:32 AM, Alexander Duyck

Re: [PATCH iproute2] ip link: Add support for kernel side filtering

2016-05-16 Thread David Ahern
On 5/16/16 12:27 PM, David Ahern wrote: In general older kernels do not parse the attributes appended to the get request. sorry, wrong wording: the attributes are parsed but ignored. I just checked an older 3.4 kernel tree and that is true there as well as prior to the kernel commit for this

Re: [PATCH v5 net-next 02/14] net: define gso types for IPx over IPv4 and IPv6

2016-05-16 Thread Tom Herbert
On Mon, May 16, 2016 at 11:13 AM, Alexander Duyck wrote: > On Mon, May 16, 2016 at 11:07 AM, Tom Herbert wrote: >> On Mon, May 16, 2016 at 9:32 AM, Alexander Duyck >> wrote: >>> On Sun, May 15, 2016 at 4:42 PM, Tom

Re: [PATCH iproute2] ip link: Add support for kernel side filtering

2016-05-16 Thread David Ahern
On 5/16/16 12:19 PM, Stephen Hemminger wrote: On Wed, 11 May 2016 06:51:58 -0700 David Ahern wrote: Kernel gained support for filtering link dumps with commit dc599f76c22b ("net: Add support for filtering link dump by master device and kind"). Add support to ip link

Re: [PATCH] phy dp83867: depend on CONFIG_OF_MDIO

2016-05-16 Thread Dan Murphy
Alex On 05/16/2016 12:57 PM, Alexander Graf wrote: > Hi Dan, > > On 16.05.16 15:38, Dan Murphy wrote: >> Alexander >> >> On 05/16/2016 06:28 AM, Alexander Graf wrote: >>> The DP83867 phy driver doesn't actually work when CONFIG_OF_MDIO isn't >>> enabled. >>> It simply passes the device tree

Re: [PATCH iproute2 -next] ingress, clsact: don't add TCA_OPTIONS to nl msg

2016-05-16 Thread Stephen Hemminger
On Sun, 15 May 2016 18:36:03 +0200 Daniel Borkmann wrote: > In ingress and clsact qdisc TCA_OPTIONS are ignored, since it's > parameterless. In tc, we add an empty addattr_l(... TCA_OPTIONS, > NULL, 0) to the netlink message nevertheless. This has the > side effect that

Re: [iproute2 net-next repost 1/2] devlink: implement shared buffer support

2016-05-16 Thread Stephen Hemminger
On Sat, 14 May 2016 15:21:01 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > Implement kernel devlink shared buffer interface. Introduce new object > "sb" and allow to browse the shared buffer parameters and also change > configuration. > > Signed-off-by:

Re: [PATCH iproute2] ip link: Add support for kernel side filtering

2016-05-16 Thread Stephen Hemminger
On Wed, 11 May 2016 06:51:58 -0700 David Ahern wrote: > Kernel gained support for filtering link dumps with commit dc599f76c22b > ("net: Add support for filtering link dump by master device and kind"). > Add support to ip link command. If a user passes master device or

Re: [PATCH v5 net-next 03/14] ipv6: Fix nexthdr for reinjection

2016-05-16 Thread Shmulik Ladkani
Hi, On Sun, 15 May 2016 16:42:24 -0700 Tom Herbert wrote: > In ip6_input_finish the nexthdr protocol is retrieved from the > next header offset that is returned in the cb of the skb. > This method does not work for UDP encapsulation that may not > even have a concept of a

Re: [iproute2 PATCH 1/1] tc fix ife late binding

2016-05-16 Thread Stephen Hemminger
On Sun, 8 May 2016 11:28:49 -0400 Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > following late action binding didn't work: > > sudo tc actions add action ife encode \ > type 0xDEAD allow mark dst 02:15:15:15:15:15 index 1 > > sudo tc filter add

Re: iwlwifi: mvm: add reorder buffer per queue

2016-05-16 Thread Dave Taht
I can't even describe how much I hate the concept of the reorder buffer in general. Ordering is the endpoints problem. Someday, after we get fq_codeled, short queues again, I'll be able to show why. On Mon, May 16, 2016 at 4:41 AM, Luca Coelho wrote: > On Fri, 2016-05-13 at

Re: [PATCH v5 net-next 02/14] net: define gso types for IPx over IPv4 and IPv6

2016-05-16 Thread Alexander Duyck
On Mon, May 16, 2016 at 11:07 AM, Tom Herbert wrote: > On Mon, May 16, 2016 at 9:32 AM, Alexander Duyck > wrote: >> On Sun, May 15, 2016 at 4:42 PM, Tom Herbert wrote: >>> This patch defines two new GSO definitions

Re: pull-request: wireless-drivers-next 2016-05-13

2016-05-16 Thread Coelho, Luciano
On Mon, 2016-05-16 at 17:08 +0300, Kalle Valo wrote: > Kalle Valo writes: > > > > > Kalle Valo writes: > > > > > > > > The following changes since commit > > > ede00a5ceb4d903a8c137a52bb77d574baaef8bd: > > > > > >   Merge tag

  1   2   >