Re: [alsa-devel] [very-RFC 0/8] TSN driver for the kernel

2016-06-20 Thread Takashi Iwai
On Mon, 20 Jun 2016 17:21:26 +0200, Richard Cochran wrote: > > On Mon, Jun 20, 2016 at 02:31:48PM +0200, Richard Cochran wrote: > > Where is this "audio_time" program of which you speak? > > Never mind, found it in alsa-lib. > > I still would appreciate an answer to my other questions,

Re: [PATCH v10 08/22] IB/hns: Add icm support

2016-06-20 Thread Wei Hu (Xavier)
On 2016/6/20 21:04, Leon Romanovsky wrote: On Mon, Jun 20, 2016 at 05:48:15PM +0800, Wei Hu (Xavier) wrote: On 2016/6/20 17:27, Leon Romanovsky wrote: On Mon, Jun 20, 2016 at 03:49:24PM +0800, Wei Hu (Xavier) wrote: On 2016/6/20 14:06, Leon Romanovsky wrote: On Mon, Jun 20, 2016 at

more fallout from sch locking changes?

2016-06-20 Thread David Ahern
I just updated to top of next-net tree (697666eac66) and still seeing an occasional lockdep splat. It is not reliable to the point I would attempt a git bisect. 2 splats -- 1 for ipv4 (first login to VM after boot) and ipv6 (second login to VM after boot). Perhaps it is more fallout of the

Re: [PATCH] net: vrf: replace hard tab with space in assignment

2016-06-20 Thread David Ahern
On 6/20/16 9:39 PM, Chris Packham wrote: The assignment of rth->dst.output in vrf_rt6_create() and vrf_rtable_create() used a hard tab before the '='. The neighboring assignments did not. Make the assignment of rth->dst.output consistent with the surrounding code. Signed-off-by: Chris Packham

[PATCH net-next 05/19] net: hns: Remove unnecessary device resource free

2016-06-20 Thread Yisen Zhuang
From: Qianqian Xie The driver uses devm_ioremap_resource, it will unmap the map automatically, remove the unnecessary the resource free. Signed-off-by: Qianqian Xie Reported-by: Kefeng Wang Signed-off-by: Yisen Zhuang

[PATCH net-next 06/19] net: hns: fix the error info when dma_set_mask_and_coherent fail

2016-06-20 Thread Yisen Zhuang
From: Qianqian Xie The error info should be printed as "set mask to 64bit fail!" instead of "set mask to 32bit fail!" in dma_set_mask_and_coherent(). Signed-off-by: Qianqian Xie Signed-off-by: Yisen Zhuang ---

[PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable

2016-06-20 Thread Yisen Zhuang
From: Jun He When hns_nic_poll_rx_skb alloc skb fail, it will break receive cycle and read new fbd_num to start new receive cycle. It recomputes cycle num is fbd_num minus clean_count, actually this cycle num is too big because it drop out receive cycle. It brings about the

[PATCH net-next 04/19] net: hns: typo fix of annotation info for hns_nic_reset_subtask()

2016-06-20 Thread Yisen Zhuang
From: Qianqian Xie The annotation info for hns_nic_reset_subtask() should be "for resetting subtask" instead of "for resetting suntask". Signed-off-by: Qianqian Xie Signed-off-by: Yisen Zhuang ---

[PATCH net-next 08/19] net: hns: fix ethtool loopback fail bug

2016-06-20 Thread Yisen Zhuang
From: Kejian Yan When run ethtool cmd(ethtool -t ethx) again and again for a long time, it will be probabilistically fail. The PHYs' registers may be on different pages, so it must be switch to the right page before setting PHYs' registers. And __lb_up() calls phy_start()

[PATCH net-next 19/19] net: hns: bug fix about TSO on|off when there is traffic

2016-06-20 Thread Yisen Zhuang
From: Daode Huang When enable/disable tso, the driver tries to access the hardware register, but this operation will cause the port unavalible when there is traffic. This patch tries to enable TSO when initialize, then control tso through TSE bit in transmit descriptor.

[PATCH net-next 03/19] net: hns: add skb_reset_mac_header() after skb being alloc

2016-06-20 Thread Yisen Zhuang
From: Kejian Yan HNS receives a packet without doing anything, but it should call skb_reset_mac_header() to initialize the header before using eth_hdr(). Fixes: 0d6b425a3773c3445b0f51b2f333821beaacb619 Signed-off-by: Kejian Yan Signed-off-by: Yisen

[PATCH net-next 02/19] net: hns: fix hns dsaf v1 dont support tx_pause close

2016-06-20 Thread Yisen Zhuang
From: Qianqian Xie For service port, hns dsaf v1 support to close tx_pause. However, the port will be invalid when it run command ethtool to close tx_pause. This patch will fix it. Signed-off-by: Qianqian Xie Signed-off-by: Yisen Zhuang

[PATCH net-next 17/19] net: hns: fix sbm default parameters config error

2016-06-20 Thread Yisen Zhuang
From: Daode Huang The default sbm config parameter leaves little buffer when there is heavy traffic, which will cause packets drop. This patch changes them to make enough buffers for handling packets. Signed-off-by: Daode Huang Signed-off-by:

[PATCH net-next 15/19] net: hns: bug fix about led control logic when link down

2016-06-20 Thread Yisen Zhuang
From: Daode Huang The default driver sets anchor led bit to 0 when link down, actually, the anchor bit should be set to 1, so fixes it when link status is down. Secondly, change the return value of cpld_set_led_id to 0, which means leave the cpld to control led blink

[PATCH net-next 12/19] net: hns: fix bug of getting the wrong tcam data

2016-06-20 Thread Yisen Zhuang
From: Daode Huang The current driver stores the high bit value of tcam data register to the tcam data low element, stores the low bit value of tcam data register to tcam data high element, this patch fixes this bug. Signed-off-by: Daode Huang

[PATCH] net: vrf: replace hard tab with space in assignment

2016-06-20 Thread Chris Packham
The assignment of rth->dst.output in vrf_rt6_create() and vrf_rtable_create() used a hard tab before the '='. The neighboring assignments did not. Make the assignment of rth->dst.output consistent with the surrounding code. Signed-off-by: Chris Packham ---

[PATCH net-next 14/19] net: hns: delete redundancy ring enable operations

2016-06-20 Thread Yisen Zhuang
From: Daode Huang When network interface is enabled, the ring enable operation is conducted twice. This patch deletes the redundancy code of ring enable, and integrates hnae_ae_ops.toggle_queue_status other functions to hns_ae_start. Signed-off-by: Daode Huang

[PATCH net-next 00/19] net: hns: fix some bugs in hns driver

2016-06-20 Thread Yisen Zhuang
This series includes some bugs fixed. All these patches needs to be applied after the patchset about ACPI support, so this series is floated to net-next list. The patches are: > from Daode, fixes about pfc pause frame, getting coaslesce, led control logic, TSO on|off and tcam table

[PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

2016-06-20 Thread Yisen Zhuang
From: Daode Huang For SoC hip06, PFC pause handled in dsaf, while hip05 in XGMAC, so change the statistics of pfc pause in dsaf and remove the old pfc pause frame statistics. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang

[PATCH net-next 13/19] net: hns: add get_coalesce_range api for hns

2016-06-20 Thread Yisen Zhuang
From: Daode Huang This patch adds get_coalesce_range api for hns, it shows range of coalesce usecs and frames that can be set on this interface. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang ---

[PATCH net-next 09/19] net: hns: fix the wrong speed for bond

2016-06-20 Thread Yisen Zhuang
From: Qianqian Xie For debug-ports,there are two non-synchronized processes: Speed-Auto-Negotiation and Link-Update-Status. The two processes are towed by two different state machines. Bond reads the speed when link up, but the speed maybe not update the right value at

[PATCH net-next 18/19] net: hns: change the default coalesce usecs

2016-06-20 Thread Yisen Zhuang
From: Daode Huang The default coalesce timeout is 3us, which is will cause CPU usage is too high. This patch change it to 50us in order to reduce CPU usage and the value makes sure network latency also meets requirement. Signed-off-by: Daode Huang

[PATCH net-next 01/19] net: hns: bug fix of ge reset sequence

2016-06-20 Thread Yisen Zhuang
From: Qianqian Xie The bit fileds of PPE reset register are different between HNS v1 and HNS v2, but the current procedure just only match HNS v1. Here is a patch to fix it. Signed-off-by: Kejian Yan Signed-off-by: Qianqian Xie

[PATCH net-next 11/19] net: hns: add spin lock for tcam table operation

2016-06-20 Thread Yisen Zhuang
From: Daode Huang This patch adds spin lock for tcam table operation, there maybe a race condition happens when more than one thread try to change the tcam talbe entries. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang

[PATCH net-next 07/19] net: hns: select Hilink before serdes loopback for HNS V2

2016-06-20 Thread Yisen Zhuang
From: Kejian Yan As Hilink3 and Hilink4 use the same xge training and xge u adaptor for HNSv2, it needs to select which Hilink to be set before relative serdes being configed. The hilink_access_sel is the register to do that. Signed-off-by: Kejian Yan

Re: r8169 regression: UDP packets dropped intermittantly

2016-06-20 Thread Jonathan Woithe
Hi all On Wed, Jun 01, 2016 at 10:01:23AM +0930, Jonathan Woithe wrote: > On Wed, May 18, 2016 at 04:21:37PM +0930, Jonathan Woithe wrote: > > On Thu, Apr 07, 2016 at 12:14:18PM +0930, Jonathan Woithe wrote: > > > On Mon, Feb 08, 2016 at 01:03:19PM +1030, Jonathan Woithe wrote: > > > > On Wed,

Re: [PATCH 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround

2016-06-20 Thread Shawn Guo
On Thu, Jun 16, 2016 at 05:47:26PM +0200, Arnd Bergmann wrote: > On Wednesday, June 1, 2016 5:29:42 PM CEST Lucas Stach wrote: > > +/* > > + * i.MX6 Q/DL has an erratum (ERR006687) that prevents the FEC from waking > > the > > + * CPUs when they are in wait(unclocked) state. As the hardware

Re: [very-RFC 0/8] TSN driver for the kernel

2016-06-20 Thread Takashi Sakamoto
On 2016年06月20日 18:06, Henrik Austad wrote: On Sun, Jun 19, 2016 at 11:45:47PM +0900, Takashi Sakamoto wrote: (remove C.C. to lkml. This is not so major feature.) On Jun 19 2916 07:45, Henrik Austad wrote: snip 802.1Q gives you low latency through the network, but more importantly, no dropped

Re: [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-20 Thread Simon Horman
[Cc Jiri Benc] On Sat, Jun 18, 2016 at 06:38:54PM -0700, pravin shelar wrote: > On Thu, Jun 16, 2016 at 10:53 PM, Simon Horman > wrote: > > On Tue, Jun 07, 2016 at 03:45:27PM -0700, pravin shelar wrote: > >> On Mon, Jun 6, 2016 at 8:08 PM, Simon Horman

Re: [PATCH net-next 12/18] IB/mlx5: Add kernel offload flow-tag

2016-06-20 Thread Alexei Starovoitov
On Sat, Jun 18, 2016 at 01:31:26AM +0300, Saeed Mahameed wrote: > > We simply want to selectively be able to see RoCE/RDMA ETH standard > traffic in tcpdump, for diagnostic purposes. > so in order to not overwhelm the kernel TCP/IP stack with this > traffic, this patch in particular > configures

Re: [PATCH net-next] net: dsa: b53: Fix statistics readings

2016-06-20 Thread Andrew Lunn
On Mon, Jun 20, 2016 at 06:26:53PM -0700, Florian Fainelli wrote: > Due to a typo we would always be using the MIB counter width of the > first element of the counter array instead of the current element, and > we would always be accessing the register statistics with a 64-bits > read, while some

[PATCH net-next] openvswitch: Only set mark and labels when commiting a connection.

2016-06-20 Thread Jarno Rajahalme
Only allow setting conntrack mark or labels when the commit flag is specified. This makes sure we can not set them before the connection has been persisted, as in that case the mark and labels would be lost in an event of an userspace upcall. OVS userspace already requires the commit flag to

Re: [PATCH net-next] of_mdio: Enable fixed PHY support if driver is a module

2016-06-20 Thread Florian Fainelli
Le 20/06/2016 17:17, Ben Hutchings a écrit : > The fixed_phy driver doesn't have to be built-in, and it's > important that of_mdio supports it even if it's a module. > > Signed-off-by: Ben Hutchings Acked-by: Florian Fainelli -- Florian

linux-next: manual merge of the net-next tree with the arm-soc tree

2016-06-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got conflicts in: arch/arm64/boot/dts/broadcom/ns2-svk.dts arch/arm64/boot/dts/broadcom/ns2.dtsi between commits: 97b1504a30b3 ("arm64: dts: enable pinctrl for Broadcom NS2 SoC") 5dcc9c7618df ("arm64: dts: NS2: Add CCI-400 PMU

[PATCH net-next] net: dsa: b53: Fix statistics readings

2016-06-20 Thread Florian Fainelli
Due to a typo we would always be using the MIB counter width of the first element of the counter array instead of the current element, and we would always be accessing the register statistics with a 64-bits read, while some could be 32-bits. This got unnoticed in testing with MDIO and SRAB which

Re: [PATCH net-next] openvswitch: Only set mark and labels when commiting a connection.

2016-06-20 Thread Jarno Rajahalme
The title should have been: openvswitch: Only set mark and labels with a commit flag. This reflects the fact that modifying the mark and/or labels of an existing connection is allowed. The commit flag is still required to do that, though. Jarno > On Jun 20, 2016, at 5:19 PM, Jarno Rajahalme

[patch net-next 08/23] mlxsw: spectrum: Centralize VLAN-aware bridge ref counting

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel We hold a reference count on the number of ports member in the VLAN-aware bridge, as we only support one. Instead of always incrementing / decrementing the reference count after joining / leaving the bridge, simply do this accounting in the join / leave

Re: [PATCH 0/3] *** Mesh Path Selection Metric Calculation ***

2016-06-20 Thread Peter Oh
where is 2/3 ? On 06/20/2016 06:00 AM, Maxim Altshul wrote: > Hi All, > This patch series focuses on metric calculation that > occurs during the path selection phase of a mesh network. > > During the path selection phase, the mesh hwmp module > performs metric calculations, that take as parameters

[PATCH net-next] of_mdio: Enable fixed PHY support if driver is a module

2016-06-20 Thread Ben Hutchings
The fixed_phy driver doesn't have to be built-in, and it's important that of_mdio supports it even if it's a module. Signed-off-by: Ben Hutchings --- Re-sending with the proper subject prefix. Ben. --- a/drivers/of/of_mdio.c +++ b/drivers/of/of_mdio.c @@ -274,7

[PATCH net-next] ti_cpsw: Check for disabled child nodes

2016-06-20 Thread Ben Hutchings
Dual MAC devices don't necessarily have both MACs wired up, so ignore those that are disabled. Signed-off-by: Ben Hutchings --- --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -2023,7 +2023,7 @@ static int cpsw_probe_dt(struct cpsw_pri

of_mdio: Enable fixed PHY support if driver is a module

2016-06-20 Thread Ben Hutchings
The fixed_phy driver doesn't have to be built-in, and it's important that of_mdio supports it even if it's a module. Signed-off-by: Ben Hutchings --- --- a/drivers/of/of_mdio.c +++ b/drivers/of/of_mdio.c @@ -274,7 +274,7 @@ struct phy_device *of_phy_attach(struct

Re: [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

2016-06-20 Thread Michael Ellerman
On Sun, 2016-06-19 at 23:06 +0530, Naveen N. Rao wrote: > On 2016/06/17 10:53PM, Michael Ellerman wrote: > > On Tue, 2016-07-06 at 13:32:23 UTC, "Naveen N. Rao" wrote: > > > diff --git a/arch/powerpc/net/bpf_jit_comp64.c > > > b/arch/powerpc/net/bpf_jit_comp64.c > > > new file mode 100644 > > >

[PATCH net] netem: fix a use after free

2016-06-20 Thread Eric Dumazet
From: Eric Dumazet If the packet was dropped by lower qdisc, then we must not access it later. Save qdisc_pkt_len(skb) in a temp variable. Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Signed-off-by: Eric Dumazet Cc: WANG Cong

Re: [PATCH net] netem: fix a use after free

2016-06-20 Thread Cong Wang
On Mon, Jun 20, 2016 at 3:00 PM, Eric Dumazet wrote: > From: Eric Dumazet > > If the packet was dropped by lower qdisc, then we must not > access it later. > > Save qdisc_pkt_len(skb) in a temp variable. > > Fixes: 2f5fb43f ("net_sched: update

[patch net-next 00/23] mlxsw: Preparation for IPv4 router

2016-06-20 Thread Jiri Pirko
From: Jiri Pirko Ido says: This series prepares the driver for IPv4 router support. The router follow-up patches are available at: https://github.com/jpirko/linux_mlxsw/tree/net-next_queue Patches 1-9 simplify the netdevice notification block and also add several checks

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-06-20 Thread Francois Romieu
Netanel Belgazal : [...] > > diff --git a/drivers/net/ethernet/amazon/ena/ena_com.h > > b/drivers/net/ethernet/amazon/ena/ena_com.h > > new file mode 100644 > > index 000..e49ba43 > > --- /dev/null > > [...] > > +static inline void ena_com_update_intr_reg(struct

[Patch net 1/2] act_ife: only acquire tcf_lock for existing actions

2016-06-20 Thread Cong Wang
Alexey reported that we have GFP_KERNEL allocation when holding the spinlock tcf_lock. Actually we don't have to take that spinlock for all the cases, especially for the new one we just create. To modify the existing actions, we still need this spinlock to make sure the whole update is atomic.

Re: [PATCH net-next] tcp: reduce cpu usage when SO_SNDBUF is set

2016-06-20 Thread Eric Dumazet
On Mon, 2016-06-20 at 17:23 -0400, Jason Baron wrote: > From: Jason Baron > > When SO_SNDBUF is set and we are under tcp memory pressure, the effective > write buffer space can be much lower than what was set using SO_SNDBUF. For > example, we may have set the buffer to 100kb,

Re: [PATCH 1/2] NET: PHY: Add PHY LED control binding.

2016-06-20 Thread Hauke Mehrtens
On 06/09/2016 10:13 PM, Hauke Mehrtens wrote: > On 06/09/2016 08:12 AM, John Crispin wrote: >> >> >> On 09/06/2016 08:06, Alexander Stein wrote: >>> On Wednesday 08 June 2016 14:30:08, Rob Herring wrote: > diff --git a/Documentation/devicetree/bindings/phy/phy-leds.txt >

[patch net-next 17/23] mlxsw: spectrum: Use per-FID struct for the VLAN-aware bridge

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel In a very similar way to the vFIDs, make the first 4K FIDs - used in the VLAN-aware bridge - use the new FID struct. Upon first use of the FID by any of the ports do the following: 1) Create the FID 2) Setup a matching flooding entry 3) Create a mapping

[patch net-next 06/23] mlxsw: spectrum: Make unlinking functions return void

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel When responding to unlinking CHANGEUPPER notifications we shouldn't return any value, as it's not checked by upper layers. In addition, there's nothing the driver can do in case of failure, so it should simply continue and try to free as much resources as

[PATCH net] netem: fix a use after free

2016-06-20 Thread Eric Dumazet
From: Eric Dumazet If the packet was dropped by lower qdisc, then we must not access it later. Save qdisc_pkt_len(skb) in a temp variable. Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Signed-off-by: Eric Dumazet Cc: WANG Cong

[patch net-next 11/23] mlxsw: spectrum: Use only one function to create vFIDs

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel Simplify the code and use only one function for vFID creation / destruction. Unlike before, the function receives a FID index as its argument and not a vFID index. Instead of passing 0, now one would need to pass 4K, which is the first vFID. This is the

Re: [net-next PATCH v3 00/17] Future-proof tunnel offload handlers

2016-06-20 Thread Hannes Frederic Sowa
On 20.06.2016 12:27, Tom Herbert wrote: >> Do we? >> >> We look up the socket in a proper way, inclusive the namespace belonging >> to the device we received the packet on. That said, I don't see a >> problem with that right now. But maybe I miss something? >> > When we so the socket lookup in

Re: [net-next PATCH v3 00/17] Future-proof tunnel offload handlers

2016-06-20 Thread Tom Herbert
On Mon, Jun 20, 2016 at 2:36 PM, Hannes Frederic Sowa wrote: > On 20.06.2016 12:27, Tom Herbert wrote: >>> Do we? >>> >>> We look up the socket in a proper way, inclusive the namespace belonging >>> to the device we received the packet on. That said, I don't see a >>>

[Patch net 2/2] act_ife: acquire ife_mod_lock before reading ifeoplist

2016-06-20 Thread Cong Wang
Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/act_ife.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c index e407659..ea4a2fe 100644 --- a/net/sched/act_ife.c

[PATCH net-next] tcp: reduce cpu usage when SO_SNDBUF is set

2016-06-20 Thread Jason Baron
From: Jason Baron When SO_SNDBUF is set and we are under tcp memory pressure, the effective write buffer space can be much lower than what was set using SO_SNDBUF. For example, we may have set the buffer to 100kb, but we may only be able to write 10kb. In this scenario

[patch net-next 05/23] mlxsw: spectrum: Use WARN_ON() return value

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel Instead of checking for a condition and then issue the warning, just do it in one go and simplify the code. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c

[patch net-next 22/23] mlxsw: spectrum: Free resources upon vPort destruction

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel There are situations in which a vPort is destroyed while still holding references to device's resources such as FIDs and FDB records. This can happen, for example, when a VLAN device is deleted while still being bridged. Instead of trying to make sure

[patch net-next 21/23] mlxsw: spectrum: Refactor FDB flushing logic

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel FDB entries are learned using {Port / LAG ID, FID} and therefore should be flushed whenever a port (vPort) leaves its FID (vFID). However, when the bridge port is a LAG device (or a VLAN device on top), then FDB flushing is conditional. Ports removed from

[patch net-next 19/23] mlxsw: spectrum: Add FID get / set functions

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel As previously explained, not all vPorts will be assigned FIDs, so instead of returning the FID index of a vPort, return a pointer to its FID struct. This will allow us to know whether it's legal to access the vPort's FID parameters such as index and

[patch net-next 10/23] mlxsw: spectrum: Remove redundant function argument

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel In all call sites 'only_uc' is set to false, so strip it. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 12 +---

[patch net-next 20/23] mlxsw: spectrum: Don't count on FID being present

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel Not all vPorts will have FIDs assigned to them, so make sure functions first test for FID presence. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c

[patch net-next 16/23] mlxsw: spectrum: Remove unused function argument

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

[patch net-next 07/23] mlxsw: spectrum: Remove unnecessary function argument

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel The argument 'br_dev' is never used, so remove it. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 7 +++ 1 file changed, 3 insertions(+), 4

[patch net-next 09/23] mlxsw: spectrum: Use DECLARE_BITMAP() macro

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel There is a macro to do this kind of declarations, so use it. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 8 1 file changed, 4 insertions(+),

[patch net-next 12/23] mlxsw: spectrum: Create a function to map vPort's FID

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel A FID used by a vPort (vFID, but also rFID later in the series) is always mapped using {Port, VID} and not only VID as with the 4K FIDs of the VLAN-aware bridge. Instead of specifying all the arguments each time, just wrap this operation using a dedicated

[patch net-next 01/23] mlxsw: spectrum: Use notifier_from_errno() in notifier block

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel Instead of checking the error value and returning NOTIFY_BAD, just use notifier_from_errno() and simplify the code. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko ---

[patch net-next 02/23] mlxsw: spectrum: Sanitize port netdev upper devices

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel We currently only support the following upper devices for port netdevs: 1) Bridge 2) LAG (bond / team) 3) VLAN Any other device is forbidden, so return an error. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko

[patch net-next 13/23] mlxsw: spectrum: Use FID instead of vFID to setup flooding

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel Use a FID index instead of vFID and ease the transition towards a generic FID struct. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 15

[patch net-next 23/23] mlxsw: spectrum: Add debug prints

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel For debug purposes, it's useful to know the order in which the driver responds to changes in the topology of its upper devices. Add debug prints to signal these events. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko

[patch net-next 15/23] mlxsw: spectrum: Use join / leave functions for vFID operations

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel When a vPort is created or when it joins a bridge we always do the same set of operations: 1) Create the vFID, if not already created 2) Setup flooding for the vFID 3) Map the {Port, VID} to the vFID When a vPort is destroyed or when it leaves a bridge

[patch net-next 18/23] mlxsw: spectrum: Check if port is vPort using its VID

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel When L3 interfaces will be introduced a vPort won't necessarily have a FID assigned to it. This can happen if it's not member in a bridge (in which case it's assigned a vFID) or doesn't have an IP address (in which case it's assigned an rFID). Therefore,

[patch net-next 14/23] mlxsw: spectrum: Make vFID struct generic

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel Up until now we had a dedicated struct only for vFIDs, but before introducing support for L3 interfaces we need to make it generic and use it for all three types of FIDs: 1) FIDs - 0..4K-1, used for the VLAN-aware bridge 2) vFIDs - 4K..15K-1, used for

[patch net-next 04/23] mlxsw: spectrum: Remove unnecessary checks from event processing

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel When upper device of a VLAN device changes we already made sure it's a bridge device in PRECHANGEUPPER, so no need to check it's a master device in CHANGEUPPER. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko

[patch net-next 03/23] mlxsw: spectrum: Forbid LAG slave from having VLAN uppers

2016-06-20 Thread Jiri Pirko
From: Ido Schimmel When a port netdev is put under LAG it cannot have VLAN upper devices, so forbid that. The LAG device itself can have VLAN upper devices. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko ---

[Patch net 0/2] net_sched: bug fixes for ife action

2016-06-20 Thread Cong Wang
Cong Wang (2): act_ife: only acquire tcf_lock for existing actions act_ife: acquire ife_mod_lock before reading ifeoplist include/net/tc_act/tc_ife.h | 6 ++--- net/sched/act_ife.c | 53 ++--- 2 files changed, 34 insertions(+), 25 deletions(-)

Re: [net-next,v4] openvswitch: Add packet len info to upcall.

2016-06-20 Thread pravin shelar
On Mon, Jun 20, 2016 at 7:26 AM, William Tu wrote: > The commit f2a4d086ed4c ("openvswitch: Add packet truncation support.") > introduces packet truncation before sending to userspace upcall receiver. > This patch passes up the skb->len before truncation so that the upcall >

Re: rcu locking issue in mpls output code?

2016-06-20 Thread Stephen Hemminger
> ifconfig tons 172.16.20.20 netmask 255.255.255.0 Really, still using ifconfig?

Re: [net-next PATCH v3 00/17] Future-proof tunnel offload handlers

2016-06-20 Thread Tom Herbert
> Do we? > > We look up the socket in a proper way, inclusive the namespace belonging > to the device we received the packet on. That said, I don't see a > problem with that right now. But maybe I miss something? > When we so the socket lookup in udp_rcv this is done after IP layer and packet has

Re: [PATCH] ppc: Fix BPF JIT for ABIv2

2016-06-20 Thread Thadeu Lima de Souza Cascardo
On Sun, Jun 19, 2016 at 11:19:14PM +0530, Naveen N. Rao wrote: > On 2016/06/17 10:00AM, Thadeu Lima de Souza Cascardo wrote: > > On Fri, Jun 17, 2016 at 10:53:21PM +1000, Michael Ellerman wrote: > > > On Tue, 2016-07-06 at 13:32:23 UTC, "Naveen N. Rao" wrote: > > > > diff --git

Re: [PATCH] [v5] net: emac: emac gigabit ethernet controller driver

2016-06-20 Thread Timur Tabi
Rob Herring wrote: >+ interrupt-parent = <>; >+ #interrupt-cells = <1>; >+ interrupts = <0 1>; >+ interrupt-map-mask = <0x>; >+ interrupt-map = <0 0 76 0 >+1 0 80 0>; Why? This looks unnecessary. It may

Re: [PATCH v4 net-next v4 14/14] net: dsa: mv88e6xxx: abstract switch registers accesses

2016-06-20 Thread kbuild test robot
Hi, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Vivien-Didelot/net-dsa-mv88e6xxx-probe-compatible/20160621-020115 config: m68k-allyesconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 4.9.0 reproduce: wget

Re: [PATCH v4 net-next v4 14/14] net: dsa: mv88e6xxx: abstract switch registers accesses

2016-06-20 Thread kbuild test robot
Hi, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Vivien-Didelot/net-dsa-mv88e6xxx-probe-compatible/20160621-020115 config: sparc64-allyesconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205 reproduce:

Re: rcu locking issue in mpls output code?

2016-06-20 Thread Lennert Buytenhek
On Mon, Jun 20, 2016 at 10:38:39AM -0600, David Ahern wrote: > > OK, patch coming up. Thanks! > > can you build a kernel with rcu debugging enabled as well and run > it through your tests? git HEAD with CONFIG_DEBUG_RT_MUTEXES=y CONFIG_DEBUG_SPINLOCK=y CONFIG_DEBUG_MUTEXES=y

Re: [PATCH v4 net-next v4 14/14] net: dsa: mv88e6xxx: abstract switch registers accesses

2016-06-20 Thread kbuild test robot
Hi, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Vivien-Didelot/net-dsa-mv88e6xxx-probe-compatible/20160621-020115 config: tile-allyesconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2 reproduce: wget

Re: [net-next PATCH v3 00/17] Future-proof tunnel offload handlers

2016-06-20 Thread Hannes Frederic Sowa
Hello, On 20.06.2016 10:05, Tom Herbert wrote: >> And finally, he added a big comment explaining that new tunnel types >> should not be added to the tunnel type list, and those that exist >> should only be used for RX. >> >> Therefore, this isn't openning the door for new random offloads, quite

Re: [PATCH] [v5] net: emac: emac gigabit ethernet controller driver

2016-06-20 Thread Timur Tabi
Shanker Donthineni wrote: /* Set dma_mask and coherent_dma_mask to 64-bits, * if xHC supports 64-bit addressing */ if (HCC_64BIT_ADDR(xhci->hcc_params) && !dma_set_mask(dev, DMA_BIT_MASK(64))) { xhci_dbg(xhci, "Enabling 64-bit

[PATCH] mpls: Add missing RCU-bh read side critical section locking in output path

2016-06-20 Thread Lennert Buytenhek
From: David Barroso When locally originated IP traffic hits a route that says to push MPLS labels, we'll get a call chain dst_output() -> lwtunnel_output() -> mpls_output() -> neigh_xmit() -> ___neigh_lookup_noref() where the last function in this chain accesses a RCU-bh

Re: [PATCH] mpls: Add missing RCU-bh read side critical section locking in output path

2016-06-20 Thread David Ahern
On 6/20/16 12:05 PM, Lennert Buytenhek wrote: From: David Barroso When locally originated IP traffic hits a route that says to push MPLS labels, we'll get a call chain dst_output() -> lwtunnel_output() -> mpls_output() -> neigh_xmit() -> ___neigh_lookup_noref() where the

Re: [PATCH] [v5] net: emac: emac gigabit ethernet controller driver

2016-06-20 Thread Shanker Donthineni
Timur, I think, the device driver is responsible for setting the right DMA_MASK based on the underlying hardware capability if your driver wants to support 64bit DMA. Example code in drivers/usb/host/xhci.c: /* Set dma_mask and coherent_dma_mask to 64-bits, * if xHC

Re: [PATCH] [v5] net: emac: emac gigabit ethernet controller driver

2016-06-20 Thread Timur Tabi
Rob Herring wrote: >+ dma-ranges = <0 0 0x>; I believe dma-ranges is supposed to be in the bus (parent) node. Maybe I'm just going to be perpetually confused by dma-ranges, but how can I specify that the emac has a different DMA range from another SOC device, if dma-ranges

[PATCH v5 net-next v5 00/14] net: dsa: mv88e6xxx: probe compatible

2016-06-20 Thread Vivien Didelot
This patchset factorizes the legacy and new SMI probing and abstracts the switch register accesses. This simplifies adding support for new chips or alternative register accesses. This will allow us to use a compatible chip info to describe how to access the SMI device and its switch ID register

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-06-20 Thread Netanel Belgazal
On 06/18/2016 12:11 AM, Francois Romieu wrote: > Netanel Belgazal : > [...] > > More stuff below. > >> diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c >> b/drivers/net/ethernet/amazon/ena/ena_com.c >> new file mode 100644 >> index 000..357e10f >> ---

[PATCH v5 net-next v5 01/14] net: dsa: mv88e6xxx: fix style issues

2016-06-20 Thread Vivien Didelot
This patch fixes 5 style problems reported by checkpatch: WARNING: suspect code indent for conditional statements (8, 24) #492: FILE: drivers/net/dsa/mv88e6xxx.c:492: + if (phydev->link) + reg |= PORT_PCS_CTRL_LINK_UP; CHECK: Logical continuations should

[PATCH v5 net-next v5 04/14] net: dsa: mv88e6xxx: do not increment bus refcount

2016-06-20 Thread Vivien Didelot
The MDIO device probe and remove functions are respectively incrementing and decrementing the bus refcount themselves. Since these bus level actions are out of the device scope, remove them. Signed-off-by: Vivien Didelot Acked-by: Andrew Lunn

[PATCH v5 net-next v5 10/14] net: dsa: mv88e6xxx: add SMI init helper

2016-06-20 Thread Vivien Didelot
Add an helper function to isolate SMI specific assignments and checks. This function will later help choosing the different SMI accesses based of the compatible info. Since the chip structure is already allocated in the legacy probe, use the mv88e6xxx_reg_read access routine instead of

[PATCH v5 net-next v5 07/14] net: dsa: mv88e6xxx: remove table args in info lookup

2016-06-20 Thread Vivien Didelot
The mv88e6xxx_table array and the mv88e6xxx_lookup_info function are static, so remove the table and size arguments from the lookup function. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 16

[PATCH v5 net-next v5 08/14] net: dsa: mv88e6xxx: rename smi_mutex to reg_lock

2016-06-20 Thread Vivien Didelot
The chip smi_mutex mutex is used to protect the access to the internal switch registers, not only the Multi-chip Addressing Mode, as commented. Since we will isolate SMI-specific pieces of code, avoid the confusion now by renaming smi_mutex to reg_lock. No functional changes here. Signed-off-by:

[PATCH v5 net-next v5 12/14] net: dsa: mv88e6xxx: pass compatible info

2016-06-20 Thread Vivien Didelot
After allocating the chip structure, pass it a compatible info pointer. The compatible info structure will be used later to describe how to access the switch registers and where to read the switch ID. For the standard MDIO probe, get it from the device node data. For the legacy DSA driver

  1   2   3   >