Re: next-20160816 build: 1 failures 2 warnings (next-20160816)

2016-08-16 Thread Leon Romanovsky
On Tue, Aug 16, 2016 at 05:38:41PM +0100, Mark Brown wrote: > On Tue, Aug 16, 2016 at 10:37:20AM +0100, Build bot for Mark Brown wrote: > > Today's -next fails to build an ARM allmodconfig due to: > > > arm-allmodconfig > > ../drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:300:61: error:

Re: [PATCH v3 2/5] net: ethernet: ti: davinci_cpdma: fix locking while ctrl_stop

2016-08-16 Thread Mugunthan V N
On Tuesday 16 August 2016 04:55 AM, Ivan Khoronzhuk wrote: > The interrupts shouldn't be disabled while receiving skb, but while > ctrl_stop, the channels are stopped and all remaining packets are > handled with netif_receive_skb(): > > lock_irq_save > cpdma_ctlr_stop >cpdma_chan_top

Re: [PATCH iproute2] ip route: restore_handler should check tb[RTA_PREFSRC] for local networks

2016-08-16 Thread Xin Long
Hi, Stephen any update on this ?

Re: [PATCH 2/5] net: add bind/listen ranges to net cgroup

2016-08-16 Thread Alexei Starovoitov
On Mon, Aug 15, 2016 at 12:05:40PM -0700, Mahesh Bandewar wrote: > On Fri, Aug 12, 2016 at 9:29 PM, Alexei Starovoitov > wrote: > [...] > >> +static bool range_in_ranges(struct net_range *r, struct net_ranges *rs) > >> +{ > >> + int ri; > >> + > >> + for (ri

Re: [PATCH v2] Bluetooth: Add LED triggers for HCI frames tx and rx

2016-08-16 Thread Guodong Xu
On 16 August 2016 at 20:33, Marcel Holtmann wrote: > > Hi Guodong, > > >>> Two LED triggers are added into hci_dev: tx_led and rx_led. Upon ACL/SCO > >>> packets available in tx or rx, the LEDs will blink. > >>> > >>> For each hci registration, two triggers are added into LED

Re: DSA + Marvell embedded switch question

2016-08-16 Thread John Fleming
On Tue, Aug 16, 2016 at 2:17 PM, Andrew Lunn wrote: > On Mon, Aug 15, 2016 at 08:17:24PM -0400, John Fleming wrote: >> Hi all, I have a embedded appliance I bought from a vendor and i'm >> being told to file a RFE for this. >> >> The issue i have is the device has a embedded

[lkp] [net/netpolicy] 19e7d15d66: EIP: [] netpolicy_unregister+0x23a/0x28a SS:ESP 0068:ceb19d94

2016-08-16 Thread kernel test robot
FYI, we noticed the following commit: https://github.com/0day-ci/linux kan-liang-intel-com/net-introduce-NET-policy/20160805-034810 commit 19e7d15d66de8b17e3f2706b786fdc36932bbdbb ("net/netpolicy: limit the total record number") in testcase: boot on test machine: 2 threads qemu-system-i386

linux-next: manual merge of the net-next tree with the net tree

2016-08-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/dsa/mv88e6xxx/chip.c between commit: 601bbae0bc10 ("dsa: mv88e6xxx: hide unused functions") from the net tree and commit: 9c93829c014f ("net: dsa: mv88e6xxx: use the new PHY API") from the net-next

Re: [PATCH net] sctp: linearize early if it's not GSO

2016-08-16 Thread Marcelo Ricardo Leitner
On Wed, Aug 17, 2016 at 12:59:17AM +0200, Daniel Borkmann wrote: > On 08/17/2016 12:35 AM, Marcelo Ricardo Leitner wrote: > > Because otherwise when crc computation is still needed it's way more > > expensive than on a linear buffer to the point that it affects > > performance. > > > > It's so

Re: [PATCH net] sctp: linearize early if it's not GSO

2016-08-16 Thread Daniel Borkmann
On 08/17/2016 12:35 AM, Marcelo Ricardo Leitner wrote: Because otherwise when crc computation is still needed it's way more expensive than on a linear buffer to the point that it affects performance. It's so expensive that netperf test gives a perf output as below: Overhead Shared Object

[PATCH 4/5] driver core: set up ownership of class devices in sysfs

2016-08-16 Thread Dmitry Torokhov
Plumb in get_ownership() callback for devices belonging to a class so that they can be created with uid/gid different from global root. This will allow network devices in a container to belong to container's root and not global root. Signed-off-by: Dmitry Torokhov ---

[PATCH 0/5] Make /sys/class/net per net namespace objects belong to container

2016-08-16 Thread Dmitry Torokhov
There are objects in /sys hierarchy (/sys/class/net/) that logically belong to a namespace/container. Unfortunately all sysfs objects start their life belonging to global root, and while we could change ownership manually, keeping tracks of all objects that come and go is cumbersome. It would be

[PATCH 1/5] kernfs: allow creating kernfs objects with arbitrary uid/gid

2016-08-16 Thread Dmitry Torokhov
This change allows creating kernfs files and directories with arbitrary uid/gid instead of always using GLOBAL_ROOT_UID/GID by extending kernfs_create_dir_ns() and kernfs_create_file_ns() with uid/gid arguments. The "simple" kernfs_create_file() and kernfs_create_dir() are left alone and always

[PATCH net] sctp: linearize early if it's not GSO

2016-08-16 Thread Marcelo Ricardo Leitner
Because otherwise when crc computation is still needed it's way more expensive than on a linear buffer to the point that it affects performance. It's so expensive that netperf test gives a perf output as below: Overhead Shared ObjectSymbol 69,44% [kernel] [k]

[PATCH 5/5] net-sysfs: make sure objects belong to contrainer's owner

2016-08-16 Thread Dmitry Torokhov
When creating various objects in /sys/class/net/... make sure that they belong to container's owner instead of global root (if they belong to a container/namespace). Signed-off-by: Dmitry Torokhov --- net/core/net-sysfs.c | 44

[PATCH 3/5] kobject: kset_create_and_add() - fetch ownership info from parent

2016-08-16 Thread Dmitry Torokhov
This change implements get_ownership() for ksets created with kset_create_and_add() call by fetching ownership data from parent kobject. This is done mostly for benefit of "queues" attribute of net devices so that corresponding directory belongs to container's root instead of global root for

[PATCH 2/5] sysfs, kobject: allow creating kobject belonging to arbitrary users

2016-08-16 Thread Dmitry Torokhov
Normally kobjects and their sysfs representation belong to global root, however it is not necessarily the case for objects in separate namespaces. For example, objects in separate network namespace logically belong to the container's root and not global root. This change lays groundwork for

[PATCH 2/2] net: sched: avoid duplicates in qdisc dump

2016-08-16 Thread Jiri Kosina
From: Jiri Kosina tc_dump_qdisc() performs dumping of the per-device qdiscs in two phases; first, the "standard" dev->qdisc is being dumped. Second, if there is/are ingress queue(s), they are being dumped as well. After conversion of netdevice's qdisc linked-list into

[PATCH 1/2] net: sched: fix handling of singleton qdiscs with qdisc_hash

2016-08-16 Thread Jiri Kosina
From: Jiri Kosina qdisc_match_from_root() is now iterating over per-netdevice qdisc hashtable instead of going through a linked-list of qdiscs (independently on the actual underlying netdev), which was the case before the switch to hashtable for qdiscs. For singleton qdiscs,

[PATCH next-next 0/2] qdisc-hashtable fixes

2016-08-16 Thread Jiri Kosina
The following two patches fix all the issues that have been reported against the conversion of qdisc linked list to hashtable (currently in net-next) so far. First patch adjusts handling of singleton qdiscs to the new semantics, and is rather straightforward. The second patch, which fixes

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

2016-08-16 Thread Timur Tabi
Al Stone wrote: Does the ACPI portion of the driver*have* to know about the PHY? In general, the ACPI assumption on ARM [**] is that those have all been set up before we get to the kernel. So, does it need to be visible to the ACPI part of the driver at all? Yes, the driver supports both

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

2016-08-16 Thread Al Stone
On 08/16/2016 07:39 AM, Timur Tabi wrote: > Rob Herring wrote: > >>> In ACPI, the equivalent to a compatible string is the HID, which is QCOM8070 >>> for the EMAC. The problem is that it's very difficult, if not impossible, >>> to create new HIDs for different versions of the same device. >> >>

pls merge net to net-next

2016-08-16 Thread Stephen Hemminger
Since Vitaly's changes to hyperv drivers went into net it makes it harder to submit other changes for net-next since they will invariably cause conflicts.

[net 6/6] i40e: check for and deal with non-contiguous TCs

2016-08-16 Thread Jeff Kirsher
From: Dave Ertman The i40e driver was causing a kernel panic when non-contiguous Traffic Classes, or Traffic Classes not starting with TC0, were configured on a link partner switch. i40e does not support non-contiguous TCs. To fix this, the patch changes the logic when

[net 5/6] ixgbe: Re-enable ability to toggle VLAN filtering

2016-08-16 Thread Jeff Kirsher
From: Alexander Duyck Back when I submitted the GSO code I messed up and dropped the support for disabling the VLAN tag filtering via the feature bit. This patch re-enables the use of the NETIF_F_HW_VLAN_CTAG_FILTER to enable/disable the VLAN filtering independent

[net 4/6] ixgbe: Force VLNCTRL.VFE to be set in all VMDq paths

2016-08-16 Thread Jeff Kirsher
From: Alexander Duyck When I was adding the code for enabling VLAN promiscuous mode with SR-IOV enabled I had inadvertently left the VLNCTRL.VFE bit unchanged as I has assumed there was code in another path that was setting it when we enabled SR-IOV. This wasn't the

[net 3/6] e1000e: fix PTP on e1000_pch_lpt variants

2016-08-16 Thread Jeff Kirsher
From: Jarod Wilson I've got reports that the Intel I-218V NIC in Intel NUC5i5RYH systems used as a PTP slave experiences random ~10 hour clock jumps, which are resolved if the same workaround for the 82574 and 82583 is employed, so set the appropriate flag2 in

[net 1/6] igb: fix adjusting PTP timestamps for Tx/Rx latency

2016-08-16 Thread Jeff Kirsher
From: Kshitiz Gupta Fix PHY delay compensation math in igb_ptp_tx_hwtstamp() and igb_ptp_rx_rgtstamp. Add PHY delay compensation in igb_ptp_rx_pktstamp(). In the IGB driver, there are two functions that retrieve timestamps received by the PHY - igb_ptp_rx_rgtstamp() and

[net 0/6][pull request] Intel Wired LAN Driver Updates 2016-08-16

2016-08-16 Thread Jeff Kirsher
This series contains fixes to e1000e, igb, ixgbe and i40e. Kshitiz Gupta provides a fix for igb to resolve the PHY delay compensation math in several functions. Jarod Wilson provides a fix for e1000e which had to broken up into 2 patches, first is prepares the driver for expanding the list of

[net 2/6] e1000e: factor out systim sanitization

2016-08-16 Thread Jeff Kirsher
From: Jarod Wilson This is prepatory work for an expanding list of adapter families that have occasional ~10 hour clock jumps when being used for PTP. Factor out the sanitization function and convert to using a feature (bug) flag, per suggestion from Jesse Brandeburg.

Re: Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

2016-08-16 Thread Cong Wang
On Tue, Aug 16, 2016 at 1:27 PM, Eric Dumazet wrote: > And tcp_add_write_queue_tail() looks like : > > > static inline void tcp_add_write_queue_tail(struct sock *sk, struct sk_buff > *skb) > { > __tcp_add_write_queue_tail(sk, skb); > > /* Queue it,

[PATCH] net: thunderx: Fix OOPs with ethtool --register-dump

2016-08-16 Thread David Daney
From: David Daney The ethtool_ops .get_regs function attempts to read the nonexistent register NIC_QSET_SQ_0_7_CNM_CHG, which produces a "bus error" type OOPs. Fix by not attempting to read, and removing the definition of, NIC_QSET_SQ_0_7_CNM_CHG. A zero is written into

Re: Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

2016-08-16 Thread Eric Dumazet
On Tue, 2016-08-16 at 13:27 -0700, Eric Dumazet wrote: > > Look at skb_entail() : It calls tcp_add_write_queue_tail() > > And tcp_add_write_queue_tail() looks like : > > > static inline void tcp_add_write_queue_tail(struct sock *sk, struct sk_buff > *skb) > { >

Re: Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

2016-08-16 Thread Eric Dumazet
On Tue, 2016-08-16 at 13:19 -0700, Cong Wang wrote: > On Tue, Aug 16, 2016 at 11:39 AM, Eric Dumazet wrote: > > On Tue, 2016-08-16 at 08:39 -0700, Eric Dumazet wrote: > >> On Tue, 2016-08-16 at 12:45 +0200, Greg KH wrote: > >> > For some reason Marco's emails can't make it

Re: Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

2016-08-16 Thread Cong Wang
On Tue, Aug 16, 2016 at 11:39 AM, Eric Dumazet wrote: > On Tue, 2016-08-16 at 08:39 -0700, Eric Dumazet wrote: >> On Tue, 2016-08-16 at 12:45 +0200, Greg KH wrote: >> > For some reason Marco's emails can't make it to netdev, so I'm >> > forwarding this on. Please cc: him

Re: [PATCH] net: macb: add phy-handle support for the macb

2016-08-16 Thread Andrew Lunn
> Agree with you my intention is if there is a MDIO bus on the device-tree > The MAC driver should create PHY/MDIO devices using of_mdiobus_register(). What you suggest is better, and is similar to what other drivers use. In order to keep backwards compatibility with phy nodes in the MAC node,

Re: kernel panic in qdisc_match_from_root starting openvswitch

2016-08-16 Thread David Ahern
On 8/16/16 1:51 PM, Jiri Kosina wrote: > On Tue, 16 Aug 2016, Jiri Kosina wrote: > >>> I am hitting a kernel panic with '/etc/init.d/openvswitch-switch >>> restart' Stack trace below. Reverting 59cc1f61f09c ("net: sched: convert >>> qdisc linked list to hashtable") clears the problem. >> >>

Re: kernel panic in qdisc_match_from_root starting openvswitch

2016-08-16 Thread Jiri Kosina
On Tue, 16 Aug 2016, Jiri Kosina wrote: > > I am hitting a kernel panic with '/etc/init.d/openvswitch-switch > > restart' Stack trace below. Reverting 59cc1f61f09c ("net: sched: convert > > qdisc linked list to hashtable") clears the problem. > > Thanks a lot for the report. Could you please

Re: Microsemi VSC 8531/41 PHY Driver

2016-08-16 Thread Andrew Lunn
On Fri, Aug 05, 2016 at 05:54:21PM +0530, Nagaraju Lakkaraju wrote: > Hello, > > I added all review comments and re-sending for review. You should also take a look at the output of scripts/checkpatch.pl: total: 9 errors, 82 warnings, 1 checks, 179 lines checked Andrew

Re: Microsemi VSC 8531/41 PHY Driver

2016-08-16 Thread Andrew Lunn
On Fri, Aug 05, 2016 at 05:54:21PM +0530, Nagaraju Lakkaraju wrote: > Hello, > > I added all review comments and re-sending for review. > > >From a5017f5878a92d2acec86a6a29b1498c457cb73a Mon Sep 17 00:00:00 2001 > From: Nagaraju Lakkaraju > Date: Wed, 3 Aug 2016

Re: kernel panic in qdisc_match_from_root starting openvswitch

2016-08-16 Thread Jiri Kosina
On Tue, 16 Aug 2016, David Ahern wrote: > Jiri: > > I am hitting a kernel panic with '/etc/init.d/openvswitch-switch > restart' Stack trace below. Reverting 59cc1f61f09c ("net: sched: convert > qdisc linked list to hashtable") clears the problem. Thanks a lot for the report. Could you please

Re: [PATCH net] sctp: fix a success return may hide an error

2016-08-16 Thread Marcelo Ricardo Leitner
On Tue, Aug 16, 2016 at 03:33:30PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Aug 17, 2016 at 02:24:19AM +0800, Xin Long wrote: > > >> > This err returns back to sctp_sendmsg, there sctp will abort asoc. > > > > > > That's not right I think. sctp_sendmsg will only free the asoc if it was > >

Re: kernel panic in qdisc_match_from_root starting openvswitch

2016-08-16 Thread Cong Wang
On Tue, Aug 16, 2016 at 11:27 AM, David Ahern wrote: > Jiri: > > I am hitting a kernel panic with '/etc/init.d/openvswitch-switch restart' > Stack trace below. Reverting 59cc1f61f09c ("net: sched: convert qdisc linked > list to hashtable") clears the problem. > Jiri

Re: Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

2016-08-16 Thread Eric Dumazet
On Tue, 2016-08-16 at 08:39 -0700, Eric Dumazet wrote: > On Tue, 2016-08-16 at 12:45 +0200, Greg KH wrote: > > For some reason Marco's emails can't make it to netdev, so I'm > > forwarding this on. Please cc: him on responses. > > Thanks for the report Greg and Marco. > > My first guess is this

Re: [PATCH net] sctp: fix a success return may hide an error

2016-08-16 Thread Marcelo Ricardo Leitner
On Wed, Aug 17, 2016 at 02:24:19AM +0800, Xin Long wrote: > >> > This err returns back to sctp_sendmsg, there sctp will abort asoc. > > > > That's not right I think. sctp_sendmsg will only free the asoc if it was > > created to send that specific chunk. And in this case, this change > > should

kernel panic in qdisc_match_from_root starting openvswitch

2016-08-16 Thread David Ahern
Jiri: I am hitting a kernel panic with '/etc/init.d/openvswitch-switch restart' Stack trace below. Reverting 59cc1f61f09c ("net: sched: convert qdisc linked list to hashtable") clears the problem. [ 30.664503] BUG: unable to handle kernel NULL pointer dereference at 0418

Re: [PATCH net] sctp: fix a success return may hide an error

2016-08-16 Thread Xin Long
>> > This err returns back to sctp_sendmsg, there sctp will abort asoc. > > That's not right I think. sctp_sendmsg will only free the asoc if it was > created to send that specific chunk. And in this case, this change > should have no effect as it can't have sctp_outq_flush() touching > several

Re: DSA + Marvell embedded switch question

2016-08-16 Thread Andrew Lunn
On Mon, Aug 15, 2016 at 08:17:24PM -0400, John Fleming wrote: > Hi all, I have a embedded appliance I bought from a vendor and i'm > being told to file a RFE for this. > > The issue i have is the device has a embedded Marvell switch (88E1514 > ?). Hi John 1514 is probably a PHY, not a switch.

Re: [PATCH net] bnx2x: don't reset chip on cleanup if PCI function is offline

2016-08-16 Thread Guilherme G. Piccoli
On 08/10/2016 10:28 AM, Guilherme G. Piccoli wrote: On 08/10/2016 04:59 AM, Yuval Mintz wrote: Why would the published resume() from pci_error_handlers be called in this scenario? It isn't. That's why I specifically commented on commit message: "There are two cases though that another path

Re: [PATCH net] sctp: fix a success return may hide an error

2016-08-16 Thread Marcelo Ricardo Leitner
On Tue, Aug 16, 2016 at 04:01:50PM +, David Laight wrote: > From: Xin Long > > Sent: 16 August 2016 12:34 > > > > >> Both sctp_outq_flush_rtx and sctp_packet_transmit can ONLY > > >> return one error (-ENOMEM), as sctp_outq_flush_rtx also calls > > >> sctp_packet_transmit. > > > > > > What is

Re: [PATCH RFC 1/1] xfrm: dst lookup doesn't account for fwmark

2016-08-16 Thread Doug Applegate
If route table includes routing based on fwmark, xfrm will not take it into account when routing ipsec traffic. We address this issue by adding fwmark information before calling route lookup. Also simplify lookup by passing the entire flow struct rather than tos, oif, and fwmark as individual

Re: [PATCH RFC 0/1] xfrm: dst lookup doesn't account for fwmark

2016-08-16 Thread Doug Applegate
Shortly I will post an updated patch. Please ignore the 'onlink' on those routes. It is irrelevant. The particular use case is load balancing by using fwmark. Consider if we don't define any routes except load balancing based on fwmarks. The only requirement is that the traffic must exit the

Re: linux-next: Tree for Aug 16 (mellanox/mlx5 & sound/oss/)

2016-08-16 Thread Saeed Mahameed
On Tue, Aug 16, 2016 at 6:26 PM, Randy Dunlap wrote: > On 08/15/16 21:01, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20160815: >> > > on i386: > > sound/built-in.o:(.data+0x5c): multiple definition of `dev_list' > drivers/built-in.o:(.data+0x6aee8): first

Re: [PATCH v6 3/3] net: phy: Add gmiitorgmii converter support

2016-08-16 Thread Andrew Lunn
> +static int xgmiitorgmii_read_status(struct phy_device *phydev) > +{ > + struct gmii2rgmii *priv = phydev->priv; > + u16 val = 0; > + > + priv->phy_drv->read_status(phydev); This can return an error, in which case phydev->speed should not be trusted. I've not thought locking all

Re: next-20160816 build: 1 failures 2 warnings (next-20160816)

2016-08-16 Thread Mark Brown
On Tue, Aug 16, 2016 at 10:37:20AM +0100, Build bot for Mark Brown wrote: Today's -next fails to build an ARM allmodconfig due to: > arm-allmodconfig > ../drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:300:61: error: 'outb' > undeclared (first use in this function) which appears to be

Re: [PATCHv3] net: ethernet: macb: Add support for rx_clk

2016-08-16 Thread Nicolas Ferre
Le 15/08/2016 à 21:44, Shubhrajyoti Datta a écrit : > Some of the platforms like zynqmp ultrascale+ has a > separate clock gate for the rx clock. Add an optional > rx_clk so that the clock can be enabled. > > Signed-off-by: Shubhrajyoti Datta Fine with me:

Re: [PATCH] samples/bpf: Add tunnel set/get tests.

2016-08-16 Thread Alexei Starovoitov
On Tue, Aug 16, 2016 at 07:03:01AM -0700, William Tu wrote: > The patch creates sample code exercising bpf_skb_{set,get}_tunnel_key, > and bpf_skb_{set,get}_tunnel_opt for GRE, VXLAN, and GENEVE. A native > tunnel device is created in a namespace to interact with a lwtunnel > device out of the

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-16 Thread David Ahern
On 8/16/16 9:21 AM, Lorenzo Colitti wrote: > I also don't see how the VRF behaviour where sk_bound_dev_if sets the > master interface and pktinto selects the slave interface" can be made > to work at all in the presence of scoped addresses. I don't see any > way to support a socket bound to

RE: [patch net-next v6 2/3] net: core: add SW stats to if_stats_msg

2016-08-16 Thread Nogah Frankel
> -Original Message- > From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] > Sent: Wednesday, August 10, 2016 9:09 AM > To: Jiri Pirko > Cc: netdev@vger.kernel.org; da...@davemloft.net; Nogah Frankel > ; Ido Schimmel ; Elad >

Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

2016-08-16 Thread Andrew Lunn
> > https://github.com/lunn/linux/commit/03d375489ceb56e171056f44d0fe9c34ca > > 5a098e > > > > Notice the > > > > Not-Signed-off-by: Andrew Lunn > > > > and the Copyright i added? > > > > In various emails i gave you the basic idea how this should be done, a > > framework > >

RE: [PATCH net] sctp: fix a success return may hide an error

2016-08-16 Thread David Laight
From: Xin Long > Sent: 16 August 2016 12:34 > > >> Both sctp_outq_flush_rtx and sctp_packet_transmit can ONLY > >> return one error (-ENOMEM), as sctp_outq_flush_rtx also calls > >> sctp_packet_transmit. > > > > What is the effect of the error? > > If it is 'just' equivalent to a lost ethernet

[PATCH net-next 2/2] tipc: ensure that link congestion and wakeup use same criteria

2016-08-16 Thread Jon Maloy
When a link is attempted woken up after congestion, it uses a different, more generous criteria than when it was originally declared congested. This has the effect that the link, and the sending process, sometimes will be woken up unnecessarily, just to immediately return to congestion when it

[PATCH net-next 1/2] tipc: make bearer packet filtering generic

2016-08-16 Thread Jon Maloy
In commit 5b7066c3dd24 ("tipc: stricter filtering of packets in bearer layer") we introduced a method of filtering out messages while a bearer is being reset, to avoid that links may be re-created and come back in working state while we are still in the process of shutting them down. This

[PATCH net-next 0/2] tipc: bearer and link improvements

2016-08-16 Thread Jon Maloy
The first commit makes it possible to set and check the 'blocked' state of a bearer from the generic bearer layer. The second commit is a small improvement to the link congestion mechanism. Jon Maloy (2): tipc: make bearer packet filtering generic tipc: ensure that link congestion and wakeup

[PATCH net] qede: Fix Tx timeout due to xmit_more

2016-08-16 Thread Yuval Mintz
Driver uses netif_tx_queue_stopped() to make sure the xmit_more indication will be honored, but that only checks for DRV_XOFF. At the same time, it's possible that during transmission the DQL will close the transmission queue with STACK_XOFF indication. In re-configuration flows, when the

Re: Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

2016-08-16 Thread Eric Dumazet
On Tue, 2016-08-16 at 12:45 +0200, Greg KH wrote: > For some reason Marco's emails can't make it to netdev, so I'm > forwarding this on. Please cc: him on responses. Thanks for the report Greg and Marco. My first guess is this is caused by d41a69f1d390 tcp: make tcp_sendmsg() aware of socket

[PATCH net-next 3/3] qed: Add support for NCSI statistics.

2016-08-16 Thread Sudarsana Reddy Kalluru
The patch adds driver support for sending the NCSI statistics to the MFW. This is an asynchronous request from MFW. Upon receiving this, driver populates the required data and send it to MFW. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz

[PATCH net-next 1/3] qede: Add support for capturing additional stats in ethtool-stats display.

2016-08-16 Thread Sudarsana Reddy Kalluru
The patch adds driver support for capturing stats ttl0_discard and packet_too_big_discard in "ethtool -S" display. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede.h | 2 ++

[PATCH net-next 0/3] qed*: Add support for additional statistics.

2016-08-16 Thread Sudarsana Reddy Kalluru
The patch series adds qed/qede support for new statistics. Patch (1) adds couple of statistcs for "ethtool -S" display. Patch (2) adds support for per-queue statistics to ethtool display. Patch (3) adds qed support for NCSI statistics. Please consider applying this to 'net-next' branch.

[PATCH net-next 2/3] qede: Add support for per-queue stats.

2016-08-16 Thread Sudarsana Reddy Kalluru
Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede.h | 3 ++ drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 63 -

Re: linux-next: Tree for Aug 16 (mellanox/mlx5 & sound/oss/)

2016-08-16 Thread Randy Dunlap
On 08/15/16 21:01, Stephen Rothwell wrote: > Hi all, > > Changes since 20160815: > on i386: sound/built-in.o:(.data+0x5c): multiple definition of `dev_list' drivers/built-in.o:(.data+0x6aee8): first defined here ld: Warning: size of symbol `dev_list' changed from 8 in drivers/built-in.o to 16

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-16 Thread Lorenzo Colitti
On Mon, Aug 15, 2016 at 4:39 PM, YOSHIFUJI Hideaki wrote: > > > and then in the various sendmsg functions: > > > > if (!inet_check_bound_oif(sk, oif)) > > return -EINVAL; > > > > Yes, something like that. There's another complication.

Re: [PATCH linux-firmware] qed: Add firmware 8.10.10.0

2016-08-16 Thread Kyle McMartin
On Tue, Aug 16, 2016 at 05:33:10PM +0300, Yuval Mintz wrote: > This new firmware for the qed* adpaters fixes several issues: > - Better blocking of malicious VFs. > - After FLR, Tx-switching [internal routing] of packets might >be incorrect. > - Deletion of unicast MAC filters would

Re: [PATCH] samples/bpf: Add tunnel set/get tests.

2016-08-16 Thread Daniel Borkmann
On 08/16/2016 04:03 PM, William Tu wrote: The patch creates sample code exercising bpf_skb_{set,get}_tunnel_key, and bpf_skb_{set,get}_tunnel_opt for GRE, VXLAN, and GENEVE. A native tunnel device is created in a namespace to interact with a lwtunnel device out of the namespace, with metadata

Re: [PATCH net-next 5/6] net: dsa: mv88e6xxx: describe PHY page and SerDes

2016-08-16 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > On Mon, Aug 15, 2016 at 05:19:01PM -0400, Vivien Didelot wrote: >> +static int mv88e6xxx_phy_page_read(struct mv88e6xxx_chip *chip, int phy, >> + u8 page, int reg, u16 *val) >> +{ >> +int err; >> + >> +/*

[PATCH] net: ipconfig: Fix more use after free

2016-08-16 Thread Thierry Reding
s still required. Move the call to ic_close_devs() to the very end of the function. Signed-off-by: Thierry Reding <tred...@nvidia.com> --- This applies on top of next-20160816. net/ipv4/ipconfig.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/ipv4/ipconfig.c

[PULL] vhost: fixes for 4.8

2016-08-16 Thread Michael S. Tsirkin
The following changes since commit 3b2fbb3f06efe5bd2dfdce2a1db703e23c1a78af: virtio/s390: deprecate old transport (2016-08-09 13:42:41 +0300) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

Re: [PATCH] net: sched: fix handling of singleton qdiscs with qdisc_hash

2016-08-16 Thread Jiri Kosina
On Tue, 16 Aug 2016, Jiri Kosina wrote: > From: Jiri Kosina > > qdisc_match_from_root() is now iterating over per-netdevice qdisc > hashtable instead of going through a linked-list of qdiscs (independently > on the actual underlying netdev), which used to be the case before

[PATCH iproute2 4/4] ila: show usage even if the module is not available

2016-08-16 Thread Sabrina Dubroca
Currently, the `ip ila` command tries to initialize a genl context even when we just want to see the help for the command, which doesn't require to talk to the kernel at all. Delay genl initialization, which can fail if the module isn't loaded, until the point where we will actually need it.

[PATCH iproute2 3/4] fou: show usage even if the module is not available

2016-08-16 Thread Sabrina Dubroca
Currently, the `ip fou` command tries to initialize a genl context even when we just want to see the help for the command, which doesn't require to talk to the kernel at all. Delay genl initialization, which can fail if the module isn't loaded, until the point where we will actually need it.

[PATCH iproute2 2/4] macsec: show usage even if the module is not available

2016-08-16 Thread Sabrina Dubroca
Currently, the `ip macsec` command tries to initialize a genl context even when we just want to see the help for the command, which doesn't require to talk to the kernel at all. Delay genl initialization, which can fail if the module isn't loaded, until the point where we will actually need it.

[PATCH iproute2 1/4] libgenl: introduce genl_init_handle

2016-08-16 Thread Sabrina Dubroca
All users of genl have the same code to open a genl socket and resolve the family for their specific protocol. Introduce a helper to intialize the handle, and use it in all the genl code. Signed-off-by: Sabrina Dubroca --- include/libgenl.h | 2 ++ ip/ipfou.c| 12

[PATCH iproute2 0/4] improve initialization of genl handle

2016-08-16 Thread Sabrina Dubroca
This patchset fixes several issues for users of genetlink: - Duplicated code for initialization of a genl handle. All users of genl must open a socket and resolve the family, and use the same code to do that. Solution: add a library function. - genl family resolution fails when the

Re: [PATCH 1/3] net: dt-bindings: Document the new Meson8b and GXBB DWMAC bindings

2016-08-16 Thread Rob Herring
On Mon, Aug 15, 2016 at 06:40:58PM +0200, Martin Blumenstingl wrote: > This patch adds the documentation for the DWMAC ethernet controller > found in Amlogic Meson 8b (S805) and GXBB (S905) SoCs. > The main difference between the Meson6 glue is that different registers > (with different layout)

[iproute PATCH] ip-link: add missing {min,max}_tx_rate to help text

2016-08-16 Thread Phil Sutter
These vf options are described in man page already, they're just missing in help output. Signed-off-by: Phil Sutter --- ip/iplink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ip/iplink.c b/ip/iplink.c index f9a7e0909747c..6b1db18a6135d 100644 --- a/ip/iplink.c +++

RE: [PATCH] net: phy: Update copyright info

2016-08-16 Thread Appana Durga Kedareswara Rao
Hi Andrew > > On Tue, Aug 16, 2016 at 11:58:29AM +0530, Kedareswara rao Appana wrote: > > For implementing this driver most of the inputs is provided by Andrew > > Lunn. > > > > Updating the driver with Andrew Copy right. > > > > Signed-off-by: Kedareswara rao Appana > >

[PATCH] samples/bpf: Add tunnel set/get tests.

2016-08-16 Thread William Tu
The patch creates sample code exercising bpf_skb_{set,get}_tunnel_key, and bpf_skb_{set,get}_tunnel_opt for GRE, VXLAN, and GENEVE. A native tunnel device is created in a namespace to interact with a lwtunnel device out of the namespace, with metadata enabled. The bpf_skb_set_* program is

[PATCH 2/2] ipv6: fixup RTF_* flags when restoring RTPROT_RA route from rtnetlink

2016-08-16 Thread Andrew Yourtchenko
Fix the flags for RA-derived routes that were saved via "ip -6 route save" and and subsequently restored via "ip -6 route restore", allowing the incoming router advertisements to update them, rather than complain about inability to do so. Upon the restore of RA-derived saved routes, set the

[PATCH 0/2] ipv6: fix stuck RA-derived route in container after migration with criu

2016-08-16 Thread Andrew Yourtchenko
This patchset fixes the connectivity problem for containers with RA-derived default route, after they were migrated using criu: the default routes would lose their "expires" value and become stuck forever. The corresponding criu issue with the discussion is at

[PATCH 1/2] ipv6: save route expiry in RTA_EXPIRES if RTF_EXPIRES set

2016-08-16 Thread Andrew Yourtchenko
This allows "ip -6 route save" to save the expiry for the routes that have it, such that it can be correctly restored later by "ip -6 route restore". If a route has RTF_EXPIRES set, generate RTA_EXPIRES value which will be used to restore the flag and expiry value by already existing code in

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

2016-08-16 Thread Timur Tabi
Rob Herring wrote: In ACPI, the equivalent to a compatible string is the HID, which is QCOM8070 for the EMAC. The problem is that it's very difficult, if not impossible, to create new HIDs for different versions of the same device. Different versions are different devices IMO. Not that I

[PATCH] smc91c92_cs : add a spinlock to avoid race condition

2016-08-16 Thread Pavel Andrianov
smc_reset may be executed in parallel with timer function media_check. To avoid data race in smc_set_xcvr a spinlock was added. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Pavel Andrianov --- drivers/net/ethernet/smsc/smc91c92_cs.c | 3 +++

Re: [PATCH] net: phy: Update copyright info

2016-08-16 Thread Andrew Lunn
On Tue, Aug 16, 2016 at 11:58:29AM +0530, Kedareswara rao Appana wrote: > For implementing this driver most of the inputs is > provided by Andrew Lunn. > > Updating the driver with Andrew Copy right. > > Signed-off-by: Kedareswara rao Appana O.K, so this is a start in

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

2016-08-16 Thread Rob Herring
On Mon, Aug 15, 2016 at 3:06 PM, Timur Tabi wrote: > + Rafael and Al, for ACPI help. > > Rob Herring wrote: >>> >>> >+Optional properties: >>> >+- phy-version : the version of the integrated emac phy, either 1 or 2. > > >> Sounds like 2 different h/w. The compatible property

RE: [Patch net v3 5/5] net_sched: convert tcf_exts from list to pointer array

2016-08-16 Thread David Laight
From: Jamal Hadi Salim > Sent: 13 August 2016 12:34 > > Just minor comment below: > > On 16-08-11 08:41 PM, Cong Wang wrote: > > > > +static inline void > > +tcf_exts_to_list(const struct tcf_exts *exts, struct list_head *actions) > > +{ > > to: > static inline void tcf_exts_to_list(const

Re: [PATCH v2] Bluetooth: Add LED triggers for HCI frames tx and rx

2016-08-16 Thread Marcel Holtmann
Hi Guodong, >>> Two LED triggers are added into hci_dev: tx_led and rx_led. Upon ACL/SCO >>> packets available in tx or rx, the LEDs will blink. >>> >>> For each hci registration, two triggers are added into LED subsystem: >>> [hdev->name]-tx and [hdev-name]-rx. >>> Refer to

[PATCH] mwifiex: fix missing break on IEEE80211_STYPE_ACTION case

2016-08-16 Thread Colin King
From: Colin Ian King The IEEE80211_STYPE_ACTION case is missing a break in the switch statement, causing it to fall through to the default case that reports a debug message about an unknown frame subtype. Fix this by adding in the missing break statement.

Re: [PATCH 1/1] ppp: Fix one deadlock issue of PPP when send frame

2016-08-16 Thread Feng Gao
Hi Paul, The v1 patch does not handle the recursive lock case. It could cause unlock multiple times. So I send the v2 patch as one update. Best Regards Feng On Tue, Aug 16, 2016 at 7:05 PM, wrote: > From: Gao Feng > > PPP channel holds one spinlock before

[PATCH v2 1/1] ppp: Fix one deadlock issue of PPP when send frame

2016-08-16 Thread fgao
From: Gao Feng PPP channel holds one spinlock before send frame. But the skb may select the same PPP channel with wrong route policy. As a result, the skb reaches the same channel path. It tries to get the same spinlock which is held before. Bang, the deadlock comes out. Now

Re: [PATCH net] sctp: fix a success return may hide an error

2016-08-16 Thread Xin Long
>> >> [1] >> Both sctp_outq_flush_rtx and sctp_packet_transmit can ONLY >> return one error (-ENOMEM), as sctp_outq_flush_rtx also calls >> sctp_packet_transmit. > > What is the effect of the error? > If it is 'just' equivalent to a lost ethernet packet (and the skb (etc) > is freed) then the

  1   2   >