Re: [PATCH net-next 1/2] tcp: measure rwnd-limited time

2016-09-06 Thread Soheil Hassas Yeganeh
On Tue, Sep 6, 2016 at 9:32 PM, Francis Y. Yan wrote: > This patch measures the total time when TCP transmission is limited > by receiver's advertised window (rwnd), and exports it in tcp_info as > tcpi_rwnd_limited. > > The rwnd-limited time is defined as the period when

Re: [PATCH net-next 2/2] tcp: put a TLV list of TCP stats in error queue

2016-09-06 Thread Soheil Hassas Yeganeh
On Tue, Sep 6, 2016 at 9:32 PM, Francis Y. Yan wrote: > > To export useful TCP statistics along with timestamps, such as > rwnd-limited time and min RTT, we enqueue a TLV list in error queue > immediately when a timestamp is generated. > > Specifically, if user space

Re: [PATCH v4 2/6] cgroup: add support for eBPF programs

2016-09-06 Thread kbuild test robot
Hi Daniel, [auto build test ERROR on net-next/master] [also build test ERROR on next-20160906] [cannot apply to linus/master linux/master v4.8-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --b

Re: [PATCH v4 2/6] cgroup: add support for eBPF programs

2016-09-06 Thread Rami Rosen
Hi, + * __cgroup_bpf_update() - Update the pinned program of a cgroup, and + * propagate the change to descendants + * @cgrp: The cgroup which descendants to traverse Missing here is @parent + * @prog: A new program to pin + * @type: Type of pinning operation

Re: [PATCH net-next v2] netlink: don't forget to release a rhashtable_iter structure

2016-09-06 Thread Herbert Xu
On Tue, Sep 06, 2016 at 09:31:17PM -0700, Andrei Vagin wrote: > This bug was detected by kmemleak: > unreferenced object 0x8804269cc3c0 (size 64): > comm "criu", pid 1042, jiffies 4294907360 (age 13.713s) > hex dump (first 32 bytes): > a0 32 cc 2c 04 88 ff ff 00 00 00 00 00 00 00 00

[PATCH net-next] net: diag: make udp_diag_destroy work for mapped addresses.

2016-09-06 Thread Lorenzo Colitti
udp_diag_destroy does look up the IPv4 UDP hashtable for mapped addresses, but it gets the IPv4 address to look up from the beginning of the IPv6 address instead of the end. Tested: https://android-review.googlesource.com/269874 Fixes: 5d77dca82839 ("net: diag: support SOCK_DESTROY for UDP

[PATCH net-next v2] netlink: don't forget to release a rhashtable_iter structure

2016-09-06 Thread Andrei Vagin
This bug was detected by kmemleak: unreferenced object 0x8804269cc3c0 (size 64): comm "criu", pid 1042, jiffies 4294907360 (age 13.713s) hex dump (first 32 bytes): a0 32 cc 2c 04 88 ff ff 00 00 00 00 00 00 00 00 .2., 00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de

Re: [net:master 29/33] drivers/net/ethernet/cadence/macb.c:1385:2-8: preceding lock on line 1372

2016-09-06 Thread Julia Lawall
The lock acquired on line 1372 is still held when leaving the function at line 1385. Is this intentional? thanks, julia Le 07.09.2016 11:11, kbuild test robot a écrit : CC: kbuild-...@01.org CC: netdev@vger.kernel.org TO: Helmut Buchsbaum tree:

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

2016-09-06 Thread kbuild test robot
Hi Jamal, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jamal-Hadi-Salim/net_sched-Introduce-skbmod-action/20160907-095338 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__

[PATCH net-next] MAINTAINERS: Update CPMAC email address

2016-09-06 Thread Florian Fainelli
Signed-off-by: Florian Fainelli --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9a1783547baf..5ec858e61ddb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3277,7 +3277,7 @@ S:Maintained F:

linux-next: manual merge of the net-next tree with the net tree

2016-09-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/qlogic/qed/qed_dcbx.c between commit: 561ed23331df ("qed: fix kzalloc-simple.cocci warnings") from the net tree and commit: 2591c280c375 ("qed: Remove OOM messages") from the net-next tree.

Re: [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field

2016-09-06 Thread hejianet
Hi Marcelo Thanks for the suggestion Will consider that B.R. Jia On 9/6/16 8:44 PM, Marcelo Ricardo Leitner wrote: On Tue, Sep 06, 2016 at 10:30:03AM +0800, Jia He wrote: ... v2: - 1/6 fix bug in udplite statistics. - 1/6 snmp_seq_show is split into 2 parts Jia He (6): proc: Reduce

Re: [RFC PATCH v2 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show

2016-09-06 Thread hejianet
On 9/7/16 6:57 AM, David Miller wrote: From: Jia He Date: Tue, 6 Sep 2016 10:30:04 +0800 +#define MAX(a, b) ((u32)(a) >= (u32)(b) ? (a) : (b)) Thanks B.R. Jia Please do not define private min/max macros, use the existing max_t() or similar as needed.

Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

2016-09-06 Thread Joe Perches
On Wed, 2016-09-07 at 02:00 +, ronnie.ku...@microchip.com wrote: > Microchip's internal convention is for register (offset) definitions > to be capitalized (i.e.: MY_REGISTER). Our convention for bits > (position) definitions within a register is to carry as a prefix the > name of the register

RE: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

2016-09-06 Thread Ronnie.Kunin
Microchip's internal convention is for register (offset) definitions to be capitalized (i.e.: MY_REGISTER). Our convention for bits (position) definitions within a register is to carry as a prefix the name of the register and suffix it with the bit name and adding a trailing underscore (i.e.

Re: [PATCH] net: hns: declare function as static

2016-09-06 Thread Kefeng Wang
On 2016/9/7 7:20, David Miller wrote: > From: Kefeng Wang > Date: Tue, 6 Sep 2016 19:53:11 +0800 > >> Declare function as static to kill warning about missing-prototypes. >> >> Cc: Yisen Zhuang >> Cc: Kejian Yan >>

Re: [PATCH v4 1/4] soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API

2016-09-06 Thread Andy Gross
On Tue, Sep 06, 2016 at 03:18:29PM -0700, Bjorn Andersson wrote: > Stub the wcnss_ctrl API to allow compile testing wcnss function drivers. > > Cc: Marcel Holtmann > Signed-off-by: Bjorn Andersson > --- > > There are no other pending changes

[PATCH net-next 2/2] tcp: put a TLV list of TCP stats in error queue

2016-09-06 Thread Francis Y. Yan
To export useful TCP statistics along with timestamps, such as rwnd-limited time and min RTT, we enqueue a TLV list in error queue immediately when a timestamp is generated. Specifically, if user space requests SOF_TIMESTAMPING_TX_* timestamps and sets SOF_TIMESTAMPING_OPT_STATS, the kernel will

[PATCH net-next 1/2] tcp: measure rwnd-limited time

2016-09-06 Thread Francis Y. Yan
This patch measures the total time when TCP transmission is limited by receiver's advertised window (rwnd), and exports it in tcp_info as tcpi_rwnd_limited. The rwnd-limited time is defined as the period when the next segment to send by TCP cannot fit into rwnd. To measure it, we record the last

Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

2016-09-06 Thread Joe Perches
On Tue, 2016-09-06 at 23:19 +, woojung@microchip.com wrote: > > Joe Perches (2): > >   lan78xx: Remove locally defined trailing underscores from defines and uses > >   microchipphy.h and uses: Remove trailing underscores from defines and > > uses > > > >  drivers/net/phy/microchip.c |

Re: vlan aware bridge doesn't propagate mac changes to vlans on top of it

2016-09-06 Thread Toshiaki Makita
On 2016/09/07 6:59, Michal Soltys wrote: > Consider following scenario: > > - create vlan aware bridge (say br0) > - setup br0's vlans, e.g. > > bridge vlan add dev br0 vid 10 self > > This will add necessary fdb entries directing appropriate traffic to the > bridge itself. > > - create

Re: [PATCH net-next] netlink: don't forget to release a rhashtable_iter structure

2016-09-06 Thread David Miller
From: Andrei Vagin Date: Tue, 6 Sep 2016 11:23:39 -0700 > This bug was detected by kmemleak: > unreferenced object 0x8804269cc3c0 (size 64): > comm "criu", pid 1042, jiffies 4294907360 (age 13.713s) > hex dump (first 32 bytes): > a0 32 cc 2c 04 88 ff ff 00 00 00

Re: XPS configuration question (on tg3)

2016-09-06 Thread Eric Dumazet
On Tue, 2016-09-06 at 23:00 +0200, Michal Soltys wrote: > On 2016-09-06 22:21, Alexander Duyck wrote: > > On Tue, Sep 6, 2016 at 11:46 AM, Michal Soltys wrote: > >> Hi, > >> > >> I've been testing different configurations and I didn't manage to get XPS > >> to "behave" correctly

[PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec

2016-09-06 Thread Subash Abhinov Kasiviswanathan
proc_dointvec limits the values to INT_MAX in u32 sysctl entries. proc_douintvec allows to write upto UINT_MAX. Signed-off-by: Subash Abhinov Kasiviswanathan --- net/xfrm/xfrm_sysctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] ptp: ixp46x: remove NO_IRQ handling

2016-09-06 Thread David Miller
From: Arnd Bergmann Date: Tue, 6 Sep 2016 21:20:36 +0200 > gpio_to_irq does not return NO_IRQ but instead returns a negative > error code on failure. Returning NO_IRQ from the function has no > negative effects as we only compare the result to the expected > interrupt number, but

Re: Minimum MTU Mess

2016-09-06 Thread David Miller
From: Jarod Wilson Date: Fri, 2 Sep 2016 13:07:42 -0400 > In any case, the number of "mtu < 68" and "#define FOO_MIN_MTU 68", or > variations thereof, under drivers/net/ is kind of crazy. Agreed, we can have a default and let the different cases provide overrides. Mostly what

[ethtool PATCH v1] ethtool: Document ethtool advertised speeds for 1G/10G

2016-09-06 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Man page update to include updated advertised speeds for 1G/10G Signed-off-by: Vidya Sagar Ravipati --- ethtool.8.in | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in index

Re: [PATCH net-next] sfc: check MTU against minimum threshold

2016-09-06 Thread David Miller
From: Bert Kenward Date: Tue, 6 Sep 2016 17:50:00 +0100 > Reported-by: Ma Yuying > Suggested-by: Jarod Wilson > Signed-off-by: Bert Kenward Applied.

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

2016-09-06 Thread David Miller
From: Jamal Hadi Salim Date: Tue, 6 Sep 2016 09:54:28 -0400 > On 16-09-06 09:37 AM, Jamal Hadi Salim wrote: >> From: Jamal Hadi Salim >> >> This action is intended to be an upgrade from a usability perspective >> from pedit (as well as operational

Re: [PATCH] net: hns: declare function as static

2016-09-06 Thread David Miller
From: Kefeng Wang Date: Tue, 6 Sep 2016 19:53:11 +0800 > Declare function as static to kill warning about missing-prototypes. > > Cc: Yisen Zhuang > Cc: Kejian Yan > Signed-off-by: Kefeng Wang

RE: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

2016-09-06 Thread Woojung.Huh
> Joe Perches (2): > lan78xx: Remove locally defined trailing underscores from defines and uses > microchipphy.h and uses: Remove trailing underscores from defines and > uses > > drivers/net/phy/microchip.c |4 +- > drivers/net/usb/lan78xx.c| 368 +++ >

Re: [PATCH v4 1/4] soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API

2016-09-06 Thread Marcel Holtmann
Hi Bjorn, > Stub the wcnss_ctrl API to allow compile testing wcnss function drivers. > > Cc: Marcel Holtmann > Signed-off-by: Bjorn Andersson > --- > > There are no other pending changes colliding with this, so if Andy is okay > with > this it

[PATCH 1/2] lan78xx: Remove locally defined trailing underscores from defines and uses

2016-09-06 Thread Joe Perches
Macro defines with trailing underscore are hard to read. These locally defined ones with trailing underscores are all unique without the trailing underscore, so remove them from the defines and uses. Global defines that start with LAN88XX_ that are excluded. Done with: $ perl -p -i -e

[PATCH 2/2] microchipphy.h and uses: Remove trailing underscores from defines and uses

2016-09-06 Thread Joe Perches
Macro defines with trailing underscore are hard to read. These uses with trailing underscores are all unique to this .h file, so remove them from the defines and uses. Done with: $ sed -r -i -e 's/\b([A-Z0-9_][A-Za-z0-9_]+)_\b/\U\1\E/g' \ include/linux/microchipphy.h \

[PATCH 0/2] lan78xx: Remove trailing underscores from macros

2016-09-06 Thread Joe Perches
Joe Perches (2): lan78xx: Remove locally defined trailing underscores from defines and uses microchipphy.h and uses: Remove trailing underscores from defines and uses drivers/net/phy/microchip.c |4 +- drivers/net/usb/lan78xx.c| 368 +++ drivers/net/usb/lan78xx.h|

Re: [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static

2016-09-06 Thread David Miller
From: Baoyou Xie Date: Tue, 6 Sep 2016 16:11:59 +0800 > We get 1 warning when building kernel with W=1: > drivers/net/vmxnet3/vmxnet3_drv.c:1643:1: warning: no previous prototype for > 'vmxnet3_rq_destroy_all_rxdataring' [-Wmissing-prototypes] > > In fact, this function

Re: [PATCH] lan78xx: mark symbols static where possible

2016-09-06 Thread David Miller
From: Baoyou Xie Date: Tue, 6 Sep 2016 16:19:02 +0800 > We get a few warnings when building kernel with W=1: > drivers/net/usb/lan78xx.c:1182:6: warning: no previous prototype for > 'lan78xx_defer_kevent' [-Wmissing-prototypes] > drivers/net/usb/lan78xx.c:1409:5:

Re: [PATCH] net: arc_emac: mark arc_mdio_reset() static

2016-09-06 Thread David Miller
From: Baoyou Xie Date: Tue, 6 Sep 2016 16:21:56 +0800 > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/arc/emac_mdio.c:107:5: warning: no previous prototype > for 'arc_mdio_reset' [-Wmissing-prototypes] > > In fact, this function is only used in

Re: [RFC PATCH v2 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show

2016-09-06 Thread David Miller
From: Jia He Date: Tue, 6 Sep 2016 10:30:04 +0800 > +#define MAX(a, b) ((u32)(a) >= (u32)(b) ? (a) : (b)) Please do not define private min/max macros, use the existing max_t() or similar as needed.

Re: PROBLEM: TPROXY and DNAT broken (bisected to 079096f103fa)

2016-09-06 Thread Florian Westphal
Brandon Cazander wrote: [ cc netfilter-devel ] > Sorry to resurrect this so much later—I just got back from holidays and this > was still on my desk. > > Will anyone have another chance to look at this? It appears that the DIVERT > rule is not working in our

Re: [RFC Patch net-next 1/6] net_sched: use RCU for action hash table

2016-09-06 Thread Cong Wang
On Tue, Sep 6, 2016 at 5:47 AM, Jamal Hadi Salim wrote: > On 16-09-02 01:57 AM, Cong Wang wrote: >> >> We already free tc actions in a RCU callback, so here >> we just need to convert the hash table operations to >> RCU API's. >> >> Cc: Jamal Hadi Salim >>

Re: [RFC Patch net-next 2/6] net_sched: introduce tcf_hash_replace()

2016-09-06 Thread Cong Wang
On Tue, Sep 6, 2016 at 5:52 AM, Jamal Hadi Salim wrote: > On 16-09-02 01:57 AM, Cong Wang wrote: > >> Cc: Jamal Hadi Salim >> Signed-off-by: Cong Wang >> --- >> include/net/act_api.h | 2 ++ >> net/sched/act_api.c | 20

[PATCH v4 2/4] wcn36xx: Transition driver to SMD client

2016-09-06 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson --- Changes since v3: - Made

[PATCH v4 3/4] wcn36xx: Implement firmware assisted scan

2016-09-06 Thread Bjorn Andersson
Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson --- Changes since v3: - None Changes since v2: - Match

[PATCH v4 1/4] soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API

2016-09-06 Thread Bjorn Andersson
Stub the wcnss_ctrl API to allow compile testing wcnss function drivers. Cc: Marcel Holtmann Signed-off-by: Bjorn Andersson --- There are no other pending changes colliding with this, so if Andy is okay with this it could be merged through

[PATCH v4 4/4] wcn36xx: Implement print_reg indication

2016-09-06 Thread Bjorn Andersson
Some firmware versions sends a "print register indication", handle this by printing out the content. Cc: Nicolas Dechesne Signed-off-by: Bjorn Andersson --- Changes since v3: - Rebased separate patch onto this series

vlan aware bridge doesn't propagate mac changes to vlans on top of it

2016-09-06 Thread Michal Soltys
Consider following scenario: - create vlan aware bridge (say br0) - setup br0's vlans, e.g. bridge vlan add dev br0 vid 10 self This will add necessary fdb entries directing appropriate traffic to the bridge itself. - create appropriate vlan interfaces on top of it, for example: ip li add

Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-09-06 Thread Robert Foss
On 2016-09-06 12:41 PM, Grant Grundler wrote: On Thu, Sep 1, 2016 at 10:02 AM, Eric Dumazet wrote: On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote: I'm not quite sure how the first From line was added, it should not have been. Grant Grundler is most definitely

[PATCH v5 6/6] net: stmmac: update the module description of the dwmac-meson driver

2016-09-06 Thread Martin Blumenstingl
The dwmac-meson glue driver supports Meson6 and Meson8 SoCs. Newer SoCs are supported by the dwmac-meson8b driver. Signed-off-by: Martin Blumenstingl --- drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v5 2/6] clk: gxbb: expose MPLL2 clock for use by DT

2016-09-06 Thread Martin Blumenstingl
This exposes the MPLL2 clock as this is one of the input clocks of the ethernet controller's internal mux. Signed-off-by: Martin Blumenstingl --- drivers/clk/meson/gxbb.h | 2 +- include/dt-bindings/clock/gxbb-clkc.h | 1 + 2 files changed, 2

[PATCH v5 0/6] meson: Meson8b and GXBB DWMAC glue driver

2016-09-06 Thread Martin Blumenstingl
This adds a DWMAC glue driver for the PRG_ETHERNET registers found in Meson8b and GXBB SoCs. Based on the "old" meson6b-dwmac glue driver the register layout is completely different. Thus I introduced a separate driver. Changes since v4: - DWMAC_MESON now depends on COMMON_CLK because the new

[PATCH v5 1/6] net: dt-bindings: Document the new Meson8b and GXBB DWMAC bindings

2016-09-06 Thread Martin Blumenstingl
This patch adds the documentation for the DWMAC ethernet controller found in Amlogic Meson 8b (S805) and GXBB (S905) SoCs. The main difference between the Meson6 glue is that different registers (with different layout) are used. Signed-off-by: Martin Blumenstingl

[PATCH v5 4/6] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC

2016-09-06 Thread Martin Blumenstingl
The Ethernet controller available in Meson8b and GXBB SoCs is a Synopsys DesignWare MAC IP core which is already supported by the stmmac driver. In addition to the standard stmmac driver some Meson8b / GXBB specific registers have to be configured for the PHY clocks. These SoC specific registers

[PATCH v5 3/6] stmmac: introduce get_stmmac_bsp_priv() helper

2016-09-06 Thread Martin Blumenstingl
From: Joachim Eastwood Create a helper to retrieve dwmac private data from a dev pointer. This is useful in PM callbacks and driver remove. Signed-off-by: Joachim Eastwood Tested-by: Martin Blumenstingl Acked-by:

[PATCH v5 5/6] ARM64: dts: meson-gxbb: use the new GXBB DWMAC glue driver

2016-09-06 Thread Martin Blumenstingl
The Amlogic reference driver uses the "mc_val" devicetree property to configure the PRG_ETHERNET_ADDR0 register. Unfortunately it uses magic values for this configuration. According to the datasheet the PRG_ETHERNET_ADDR0 register is at address 0xc8834108. However, the reference driver uses

Re: [PATCH net-next] sfc: check MTU against minimum threshold

2016-09-06 Thread Jarod Wilson
On Tue, Sep 06, 2016 at 05:50:00PM +0100, Bert Kenward wrote: > Reported-by: Ma Yuying > Suggested-by: Jarod Wilson > Signed-off-by: Bert Kenward Works for me, until we can get some dialog going about possible centralization (or not)

Re: [PATCH net-next 0/3] qed*: Debug data collection

2016-09-06 Thread David Miller
From: Tomer Tayar Date: Mon, 5 Sep 2016 14:35:09 +0300 > This patch series adds the support of debug data collection in the qed driver, > and the means to extract it in the qede driver via the get_regs operation. ... > Please consider applying this to 'net-next'. There

Re: [PATCH] ipv6: addrconf: fix dev refcont leak when DAD failed

2016-09-06 Thread David Miller
From: Wei Yongjun Date: Mon, 5 Sep 2016 16:06:31 +0800 > In general, when DAD detected IPv6 duplicate address, ifp->state > will be set to INET6_IFADDR_STATE_ERRDAD and DAD is stopped by a > delayed work, the call tree should be like this: > > ndisc_recv_ns > ->

Re: [PATCH repost net-next] bnx2x: Add support for segmentation of tunnels with outer checksums

2016-09-06 Thread David Miller
From: Yuval Mintz Date: Mon, 5 Sep 2016 13:26:33 +0300 > From: Alexander Duyck > > Signed-off-by: Alexander Duyck > Tested-by: Yuval Mintz Applied.

[PATCH] smsc95xx: Remove trailing underscores from macros and uses

2016-09-06 Thread Joe Perches
Make the #defines a bit more sensible to read. Done with: $ sed -r -i -e 's/\b([A-Z0-9_][A-Za-z0-9_]+)_\b/\U\1\E/g' \ drivers/net/usb/smsc95xx.[ch] and a little editing of the .h file to realign tabstop define values. There are 3 [RT]x_COE_ defines that were also uppercased. No change in

Re: XPS configuration question (on tg3)

2016-09-06 Thread Michal Soltys
On 2016-09-06 22:21, Alexander Duyck wrote: > On Tue, Sep 6, 2016 at 11:46 AM, Michal Soltys wrote: >> Hi, >> >> I've been testing different configurations and I didn't manage to get XPS to >> "behave" correctly - so I'm probably misunderstanding or forgetting >> something. The

Re: [PATCH net] bnxt_en: Fix TX push operation on ARM64.

2016-09-06 Thread David Miller
From: Michael Chan Date: Mon, 5 Sep 2016 01:57:35 -0400 > There is a code path where we are calling __iowrite64_copy() on > an address that is not 64-bit aligned. This causes an exception on > some architectures such as arm64. Fix that code path by using >

Re: [PATCH] tcp: cwnd does not increase in TCP YeAH

2016-09-06 Thread David Miller
From: Artem Germanov Date: Sun, 4 Sep 2016 21:03:27 -0700 > Commit 76174004a0f19785a328f40388e87e982bbf69b9 > (tcp: do not slow start when cwnd equals ssthresh ) > introduced regression in TCP YeAH. Using 100ms delay 1% loss virtual > ethernet link kernel 4.2 shows

Re: [PATCH v2] net: Don't delete routes in different VRFs

2016-09-06 Thread David Miller
From: Mark Tomlinson Date: Mon, 5 Sep 2016 10:20:20 +1200 > When deleting an IP address from an interface, there is a clean-up of > routes which refer to this local address. However, there was no check to > see that the VRF matched. This meant that deletion

Re: [net-next PATCH V2] qed: Remove OOM messages

2016-09-06 Thread David Miller
From: Joe Perches Date: Sun, 4 Sep 2016 14:24:03 -0700 > These messages are unnecessary as OOM allocation failures already do > a dump_stack() giving more or less the same information. > > $ size drivers/net/ethernet/qlogic/qed/built-in.o* (defconfig x86-64) >text

Re: [PATCH net-next 0/9] rxrpc: Small fixes

2016-09-06 Thread David Miller
From: David Howells Date: Sun, 04 Sep 2016 22:02:24 +0100 > > Here's a set of small fix patches: > > (1) Fix some uninitialised variables. > > (2) Set the client call state before making it live by attaching it to the > conn struct. > > (3) Randomise the epoch

Re: [PATCH v2] net: smsc: remove build warning of duplicate definition

2016-09-06 Thread David Miller
From: Sudip Mukherjee Date: Sun, 4 Sep 2016 23:02:21 +0530 > The build of m32r was giving warning: > > In file included from drivers/net/ethernet/smsc/smc91x.c:92:0: > drivers/net/ethernet/smsc/smc91x.h:448:0: warning: "SMC_inb" redefined > #define SMC_inb(ioaddr,

Re: [PATCH v3] net: macb: initialize checksum when using checksum offloading

2016-09-06 Thread David Miller
From: Helmut Buchsbaum Date: Sun, 4 Sep 2016 18:09:47 +0200 > I'm still struggling to get this fix right.. > > Changes since v2: > - do not blindly modify SKB contents according to Dave's legitimate >objection > > Changes since v1: > - dropped disabling HW

Re: [PATCH] vxlan: Update tx_errors statistics if vxlan_build_skb return err.

2016-09-06 Thread David Miller
From: Haishuang Yan Date: Sun, 4 Sep 2016 18:52:51 +0800 > If vxlan_build_skb return err < 0, tx_errors should be also increased. > > Signed-off-by: Haishuang Yan Applied to net-next.

Re: [PATCH v2] net/mlx4_en: protect ring->xdp_prog with rcu_read_lock

2016-09-06 Thread David Miller
From: Brenden Blanco Date: Sat, 3 Sep 2016 21:29:58 -0700 > Depending on the preempt mode, the bpf_prog stored in xdp_prog may be > freed despite the use of call_rcu inside bpf_prog_put. The situation is > possible when running in PREEMPT_RCU=y mode, for instance, since

Re: [ethtool PATCH v1 0/2] ethtool: add support for 1000BaseX and missing 10G link mode

2016-09-06 Thread Vidya Sagar Ravipati
Will send out man page fix. Missed it. On Tue, Sep 6, 2016 at 1:32 PM, Vidya Sagar Ravipati wrote: > Will send out man page fix too. Missed it. > > On Tue, Sep 6, 2016 at 1:16 PM, John W. Linville > wrote: >> >> On Sun, Aug 28, 2016 at

Re: [PATCH net-next v5 0/2] net: ethernet: mediatek: add enhancements to RX path

2016-09-06 Thread David Miller
From: Date: Sat, 3 Sep 2016 17:59:25 +0800 > Changes since v1: > - fix message typos and add coverletter > > Changes since v2: > - split from the previous series for submitting add enhancements as > a series targeting 'net-next' and add indents before comments. > >

Re: [ethtool PATCH v1 0/2] ethtool: add support for 1000BaseX and missing 10G link mode

2016-09-06 Thread John W. Linville
On Sun, Aug 28, 2016 at 11:56:48PM -0700, Vidya Sagar Ravipati wrote: > From: Vidya Sagar Ravipati > > This patchset enhances ethtool link mode bitmap to include > missing interface modes for 1G/10G speeds > > Vidya Sagar Ravipati (2): > ethtool-copy.h:sync with net

Re: [PATCH 0/2] hso: neatening

2016-09-06 Thread David Miller
From: Joe Perches Date: Fri, 2 Sep 2016 15:58:00 -0700 > This seems to be the only code in the kernel that uses > macro defines with a trailing underscore. Fix that. Series applied, thanks.

Re: [PATCH net-next 0/3] smsc95xx: patch serises

2016-09-06 Thread David Miller
From: Date: Fri, 2 Sep 2016 20:34:17 + > From: Woojung Huh Series applied, thanks.

Re: [PATCH net-next 2/3] smsc95xx: Add register define

2016-09-06 Thread David Miller
From: Joe Perches Date: Fri, 02 Sep 2016 13:40:01 -0700 > On Fri, 2016-09-02 at 20:34 +, woojung@microchip.com wrote: >> From: Woojung Huh >> >> Add STRAP_STATUS defines. > [] >> diff --git a/drivers/net/usb/smsc95xx.h

RE

2016-09-06 Thread Easy Loan
Are you need of Loan offer? We here to meet your need Contact us Jim Elssin --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: XPS configuration question (on tg3)

2016-09-06 Thread Alexander Duyck
On Tue, Sep 6, 2016 at 11:46 AM, Michal Soltys wrote: > Hi, > > I've been testing different configurations and I didn't manage to get XPS to > "behave" correctly - so I'm probably misunderstanding or forgetting > something. The nic in question (under tg3 driver - BCM5720 and

Re: [PATCH net-next v2 0/3] net: dsa: mv88e6xxx: isolate Global2 support

2016-09-06 Thread David Miller
From: Vivien Didelot Date: Fri, 2 Sep 2016 14:45:31 -0400 > Registers of Marvell chips are organized in internal SMI devices. > > One of them at address 0x1C is called Global2. It provides an extended > set of registers, used for interrupt control, EEPROM

Re: ipv6: release dst in ping_v6_sendmsg

2016-09-06 Thread David Miller
From: Dave Jones Date: Fri, 2 Sep 2016 14:39:50 -0400 > Neither the failure or success paths of ping_v6_sendmsg release > the dst it acquires. This leads to a flood of warnings from > "net/core/dst.c:288 dst_release" on older kernels that > don't have

Re: [PATCH 00/29] Netfilter updates for net-next

2016-09-06 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 5 Sep 2016 12:58:15 +0200 > Hi David, > > The following patchset contains Netfilter updates for your net-next > tree. Most relevant updates are the removal of per-conntrack timers to > use a workqueue/garbage collection approach instead

[PATCH v2] ptp: ixp46x: remove NO_IRQ handling

2016-09-06 Thread Arnd Bergmann
gpio_to_irq does not return NO_IRQ but instead returns a negative error code on failure. Returning NO_IRQ from the function has no negative effects as we only compare the result to the expected interrupt number, but it's better to return a proper failure code for consistency, and we should remove

Re: [PATCH] ptp: ixp46x: remove NO_IRQ handling

2016-09-06 Thread Arnd Bergmann
On Tuesday, September 6, 2016 6:39:10 PM CEST Richard Cochran wrote: > On Tue, Sep 06, 2016 at 04:28:30PM +0200, Arnd Bergmann wrote: > > gpio_to_irq does not return NO_IRQ but instead returns a negative > > error code on failure. Returning NO_IRQ from the function has no > > negative effects as

Re: ipv6: release dst in ping_v6_sendmsg

2016-09-06 Thread Dave Jones
On Tue, Sep 06, 2016 at 10:52:43AM -0700, Eric Dumazet wrote: > > > @@ -126,8 +126,10 @@ static int ping_v6_sendmsg(struct sock *sk, struct > > > msghdr *msg, size_t len) > > > rt = (struct rt6_info *) dst; > > > > > > np = inet6_sk(sk); > > > -if (!np) > > > -

XPS configuration question (on tg3)

2016-09-06 Thread Michal Soltys
Hi, I've been testing different configurations and I didn't manage to get XPS to "behave" correctly - so I'm probably misunderstanding or forgetting something. The nic in question (under tg3 driver - BCM5720 and BCM5719 models) was configured to 3 tx and 4 rx queues. 3 irqs were shared (tx and

Re: [RFC PATCH kernel] PCI: Enable access to custom VPD for Chelsio devices (cxgb3)

2016-09-06 Thread Alexander Duyck
On Tue, Sep 6, 2016 at 8:48 AM, Bjorn Helgaas wrote: > Hi Alexey, > > On Thu, Aug 11, 2016 at 08:03:29PM +1000, Alexey Kardashevskiy wrote: >> There is at least one Chelsio 10Gb card which uses VPD area to store >> some custom blocks (example below). However pci_vpd_size()

[PATCH net-next] netlink: don't forget to release a rhashtable_iter structure

2016-09-06 Thread Andrei Vagin
This bug was detected by kmemleak: unreferenced object 0x8804269cc3c0 (size 64): comm "criu", pid 1042, jiffies 4294907360 (age 13.713s) hex dump (first 32 bytes): a0 32 cc 2c 04 88 ff ff 00 00 00 00 00 00 00 00 .2., 00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de

Re: ipv6: release dst in ping_v6_sendmsg

2016-09-06 Thread Eric Dumazet
On Tue, 2016-09-06 at 10:36 -0700, Martin KaFai Lau wrote: > On Fri, Sep 02, 2016 at 02:39:50PM -0400, Dave Jones wrote: > > Neither the failure or success paths of ping_v6_sendmsg release > > the dst it acquires. This leads to a flood of warnings from > > "net/core/dst.c:288 dst_release" on

Re: ipv6: release dst in ping_v6_sendmsg

2016-09-06 Thread Martin KaFai Lau
On Fri, Sep 02, 2016 at 02:39:50PM -0400, Dave Jones wrote: > Neither the failure or success paths of ping_v6_sendmsg release > the dst it acquires. This leads to a flood of warnings from > "net/core/dst.c:288 dst_release" on older kernels that > don't have

Re: [PATCH v4 2/6] cgroup: add support for eBPF programs

2016-09-06 Thread Daniel Borkmann
On 09/06/2016 03:46 PM, Daniel Mack wrote: This patch adds two sets of eBPF program pointers to struct cgroup. One for such that are directly pinned to a cgroup, and one for such that are effective for it. To illustrate the logic behind that, assume the following example cgroup hierarchy. A

Re: [PATCH v3 5/6] net: core: run cgroup eBPF egress programs

2016-09-06 Thread Daniel Borkmann
On 09/05/2016 04:22 PM, Daniel Mack wrote: On 08/30/2016 12:03 AM, Daniel Borkmann wrote: On 08/26/2016 09:58 PM, Daniel Mack wrote: diff --git a/net/core/dev.c b/net/core/dev.c index a75df86..17484e6 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -141,6 +141,7 @@ #include

Re: PROBLEM: TPROXY and DNAT broken (bisected to 079096f103fa)

2016-09-06 Thread Brandon Cazander
Sorry to resurrect this so much later—I just got back from holidays and this was still on my desk. Will anyone have another chance to look at this? It appears that the DIVERT rule is not working in our case, and I wonder if it is possible to fix the TPROXY target as well as the socket target

[PATCH net-next] sfc: check MTU against minimum threshold

2016-09-06 Thread Bert Kenward
Reported-by: Ma Yuying Suggested-by: Jarod Wilson Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/efx.c| 12 +++- drivers/net/ethernet/sfc/net_driver.h | 3 +++ 2 files changed, 14 insertions(+), 1

Re: [RFC PATCH 2/2] macb: Enable 1588 support in SAMA5D2 platform.

2016-09-06 Thread Richard Cochran
On Fri, Sep 02, 2016 at 02:53:37PM +0200, Andrei Pistirica wrote: > Hardware time stamp on the PTP Ethernet packets are received using the > SO_TIMESTAMPING API. Timers are obtained from the PTP event/peer > gem registers. > > Signed-off-by: Andrei Pistirica > ---

Re: [PATCH] ptp: ixp46x: remove NO_IRQ handling

2016-09-06 Thread Richard Cochran
On Tue, Sep 06, 2016 at 04:28:30PM +0200, Arnd Bergmann wrote: > gpio_to_irq does not return NO_IRQ but instead returns a negative > error code on failure. Returning NO_IRQ from the function has no > negative effects as we only compare the result to the expected > interrupt number, but it's better

Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-09-06 Thread Grant Grundler
On Thu, Sep 1, 2016 at 10:02 AM, Eric Dumazet wrote: > On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote: > >> I'm not quite sure how the first From line was added, it >> should not have been. >> Grant Grundler is most definitely the author. >> >> Would you like me to

Re: [PATCH net-next V2 3/6] net/mlx5e: Read ETS settings directly from firmware

2016-09-06 Thread Or Gerlitz
On Tue, Sep 6, 2016 at 7:04 PM, Saeed Mahameed wrote: > From: Huy Nguyen > > Issue description: > Current implementation saves the ETS settings from user in > a temporal soft copy and returns this settings when user > queries the ETS settings. > > With the

Re: [PATCH net-next V2 6/6] net/mlx5: Add handling for port module event

2016-09-06 Thread Joe Perches
On Tue, 2016-09-06 at 19:04 +0300, Saeed Mahameed wrote: > From: Huy Nguyen [] > +void mlx5_port_module_event(struct mlx5_core_dev *dev, struct mlx5_eqe *eqe) > +{ > > + struct mlx5_eqe_port_module *module_event_eqe; > > + u8 module_status; > > + u8 module_num; > > +

Re: [patch net-next RFC 1/2] fib: introduce fib notification infrastructure

2016-09-06 Thread Hannes Frederic Sowa
On Tue, Sep 6, 2016, at 17:49, Jiri Pirko wrote: > Tue, Sep 06, 2016 at 05:11:11PM CEST, d...@cumulusnetworks.com wrote: > >On 9/6/16 8:44 AM, Jiri Pirko wrote: > >> Tue, Sep 06, 2016 at 04:32:12PM CEST, d...@cumulusnetworks.com wrote: > >>> On 9/6/16 6:01 AM, Jiri Pirko wrote: > From: Jiri

[PATCH net-next V2 3/6] net/mlx5e: Read ETS settings directly from firmware

2016-09-06 Thread Saeed Mahameed
From: Huy Nguyen Issue description: Current implementation saves the ETS settings from user in a temporal soft copy and returns this settings when user queries the ETS settings. With the new DCBX firmware, the ETS settings can be changed by firmware when the DCBX is in

  1   2   >