Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-13 Thread Leon Romanovsky
On Tue, Sep 13, 2016 at 08:44:06AM +, Ram Amrani wrote: > Hi Jason, > I see that "include/uapi/rdma" contains API that is common. > The qedr_user.h, that I assume you are referring to, is a qedr specific API. > For example, we issue the ib_copy_to_udata() on structures defined in the > file. >

Re: [RFC 02/11] Add RoCE driver framework

2016-09-13 Thread Leon Romanovsky
On Tue, Sep 13, 2016 at 07:18:01AM +, Mintz, Yuval wrote: > >> >> +uint debug; > >> >> +module_param(debug, uint, 0); > > >>> +MODULE_PARM_DESC(debug, "Default debug msglevel"); > >> > >> >Why are you adding this as a module parameter? > >> > >> I believe this is mostly to follow same line as

[PATCH net-next] alx: fix error handling in __alx_open

2016-09-13 Thread Tobias Regnery
In commit 9ee7b683ea63 we moved the enablement of msi interrupts earlier in alx_init_intr. If there is an error in alx_alloc_rings, __alx_open returns with an error but msi (or msi-x) interrupts stays enabled. Add a new error label to disable msi (or msi-x) interrupts. Fixes: 9ee7b683ea63 ("alx: r

RE: [RFC 02/11] Add RoCE driver framework

2016-09-13 Thread Ram Amrani
Thanks for your comments. See my replies in line with [Ram]. -Original Message- From: Mark Bloch [mailto:ma...@mellanox.com] Sent: Monday, September 12, 2016 9:44 PM To: Ram Amrani ; dledf...@redhat.com; David Miller Cc: Yuval Mintz ; Ariel Elior ; Michal Kalderon ; Rajesh Borundia

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

2016-09-13 Thread John Crispin
On 13/09/2016 03:23, Andrew Lunn wrote: > So lets see if i have this right. > > Port 0 has no internal phy. > Port 1 has an internal PHY at MDIO address 0. > Port 2 has an internal PHY at MDIO address 1. > ... > Port 5 has an internal PHY ad MDIO address 4. > Port 6 has no internal PHY. Hi Andr

Re: icmpv6: issue with routing table entries from link local addresses

2016-09-13 Thread Andreas Hübner
On Mon, Sep 12, 2016 at 01:17:24PM -0600, David Ahern wrote: > v4.4 and on there are fib6 tracepoints that show the lookup result. > May provide some insights. > > perf record -a -e fib6:* > perf script Thanks for the hint, didn't now that something like this exists. Following up on my earlier ma

Re: [PATCH 0/9] Move runnable code (tests) from Documentation to selftests

2016-09-13 Thread Jani Nikula
On Sat, 10 Sep 2016, Jonathan Corbet wrote: > On Fri, 9 Sep 2016 16:22:41 -0600 > Shuah Khan wrote: > >> Move runnable code (tests) from Documentation to selftests and update >> Makefiles to work under selftests. >> >> Jon Corbet and I discussed this in an email thread and as per that >> discus

RE: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-13 Thread Ram Amrani
Hi Jason, I see that "include/uapi/rdma" contains API that is common. The qedr_user.h, that I assume you are referring to, is a qedr specific API. For example, we issue the ib_copy_to_udata() on structures defined in the file. So per my understanding it is in place. Thanks, Ram -Original Mes

Re: [PATCH net-next 0/7] cxgb4: add support for offloading TC u32 filters

2016-09-13 Thread Rahul Lakkireddy
On Monday, September 09/12/16, 2016 at 13:42:33 +0530, Rahul Lakkireddy wrote: > This series of patches add support to offload TC u32 filters onto > Chelsio NICs. > > Patch 1 moves current common filter code to separate files > in order to provide a common api for performing packet classification

[PATCH 1/4] netfilter: nf_tables_trace: fix endiness when dump chain policy

2016-09-13 Thread Pablo Neira Ayuso
From: Liping Zhang NFTA_TRACE_POLICY attribute is big endian, but we forget to call htonl to convert it. Fortunately, this attribute is parsed as big endian in libnftnl. Signed-off-by: Liping Zhang Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_trace.c | 2 +- 1 file changed, 1

[PATCH 0/4] Netfilter fixes for net

2016-09-13 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter fixes for your net tree, they are: 1) Endianess fix for the new nf_tables netlink trace infrastructure, NFTA_TRACE_POLICY endianess was not correct, patch from Liping Zhang. 2) Fix broken re-route after userspace queueing in nf_tables route

[PATCH 2/4] netfilter: nft_chain_route: re-route before skb is queued to userspace

2016-09-13 Thread Pablo Neira Ayuso
From: Liping Zhang Imagine such situation, user add the following nft rules, and queue the packets to userspace for further check: # ip rule add fwmark 0x0/0x1 lookup eth0 # ip rule add fwmark 0x1/0x1 lookup eth1 # nft add table filter # nft add chain filter output {type route hook output

[PATCH 4/4] netfilter: synproxy: Check oom when adding synproxy and seqadj ct extensions

2016-09-13 Thread Pablo Neira Ayuso
From: Gao Feng When memory is exhausted, nfct_seqadj_ext_add may fail to add the synproxy and seqadj extensions. The function nf_ct_seqadj_init doesn't check if get valid seqadj pointer by the nfct_seqadj. Now drop the packet directly when fail to add seqadj extension to avoid dereference NULL p

[PATCH 3/4] netfilter: nf_nat: handle NF_DROP from nfnetlink_parse_nat_setup()

2016-09-13 Thread Pablo Neira Ayuso
nf_nat_setup_info() returns NF_* verdicts, so convert them to error codes that is what ctnelink expects. This has passed overlook without having any impact since this nf_nat_setup_info() has always returned NF_ACCEPT so far. Since 870190a9ec90 ("netfilter: nat: convert nat bysrc hash to rhashtable"

RE: [RFC 03/11] Add support for RoCE HW init

2016-09-13 Thread Ram Amrani
Thanks Mark. This will be fixed in next version. Ram -Original Message- From: Mark Bloch [mailto:ma...@mellanox.com] Sent: Monday, September 12, 2016 9:58 PM To: Ram Amrani ; dledf...@redhat.com; David Miller Cc: Yuval Mintz ; Ariel Elior ; Michal Kalderon ; Rajesh Borundia ; linux-

RE: OUTLOOK WEB NOTICE

2016-09-13 Thread O'Malley, Mary
From: O'Malley, Mary Sent: Tuesday, September 13, 2016 1:24 AM Subject: OUTLOOK WEB NOTICE Your password Will Expire In {2} Days Current Faculty and Staff Should Log On To IT WEBSITE To Validate Your E-m

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

2016-09-13 Thread John Crispin
On 13/09/2016 02:40, Andrew Lunn wrote: >> > +static int >> > +qca8k_get_eee(struct dsa_switch *ds, int port, >> > +struct ethtool_eee *e) >> > +{ >> > + struct qca8k_priv *priv = qca8k_to_priv(ds); >> > + struct ethtool_eee *p = &priv->port_sts[qca8k_phy_to_port(port)].eee; >> > + u32

[PATCHv2 net-next] cxgb4vf: don't offload Rx checksums for IPv6 fragments

2016-09-13 Thread Hariprasad Shenai
The checksum provided by the device doesn't include the L3 headers, as IPv6 expects Signed-off-by: Hariprasad Shenai --- V2: Fixed compilation issue reported by kbuild bot drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drive

Re: [PATCH net-next] cxgb4vf: don't offload Rx checksums for IPv6 fragments

2016-09-13 Thread kbuild test robot
Hi Hariprasad, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Hariprasad-Shenai/cxgb4vf-don-t-offload-Rx-checksums-for-IPv6-fragments/20160913-151500 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705

RE: [v11, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

2016-09-13 Thread Y.B. Lu
> -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Scott Wood > Sent: Tuesday, September 13, 2016 7:25 AM > To: Y.B. Lu; linux-...@vger.kernel.org; ulf.hans...@linaro.org; Arnd > Bergmann > Cc: linuxppc-...@lists.ozlabs.org;

Re: [RFC 02/11] Add RoCE driver framework

2016-09-13 Thread Mintz, Yuval
>> >> +uint debug; >> >> +module_param(debug, uint, 0); > >>> +MODULE_PARM_DESC(debug, "Default debug msglevel"); >> >> >Why are you adding this as a module parameter? >> >> I believe this is mostly to follow same line as qede which also defines > > 'debug' module parameter for allowing easy user

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-13 Thread Mintz, Yuval
>> While this might work, I personally dislike it as I find it >> counter-intuitive when going over the code - >> I don't expect driver to locally modify the inclusion path. >> Besides, we're going to [eventually] a whole suite of drivers based >> on the qed module, some of which would reside under

[PATCH net-next] cxgb4vf: don't offload Rx checksums for IPv6 fragments

2016-09-13 Thread Hariprasad Shenai
The checksum provided by the device doesn't include the L3 headers, as IPv6 expects Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/sge.c b/drivers/net

Re: [PATCH net-next] ipv4: accept u8 in IP_TOS ancillary data

2016-09-13 Thread Jesper Dangaard Brouer
On Thu, 08 Sep 2016 06:31:14 -0700 Eric Dumazet wrote: > On Thu, 2016-09-08 at 11:15 +0200, Jesper Dangaard Brouer wrote: > > On Wed, 07 Sep 2016 21:52:56 -0700 > > Eric Dumazet wrote: > > > > > From: Eric Dumazet > > > > > > In commit f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified

[PATCH net-next 0/2] mvneta xmit_more and bql support

2016-09-13 Thread Marcin Wojtas
Hi, This short patchset introduces two enhancements to mvneta driver TX packets concatenation support using xmit_more mechanism and also byte queue limit in order to decrease latency on saturated links. Any comments or feedback would be welcome. Best regards, Marcin Marcin Wojtas (1): net: mv

[PATCH net-next 1/2] net: mvneta: add xmit_more support

2016-09-13 Thread Marcin Wojtas
From: Simon Guinot Basing on xmit_more flag of the skb, TX descriptors can be concatenated before flushing. This commit delay Tx descriptor flush if the queue is running and if there is more skb's to send. Signed-off-by: Simon Guinot --- drivers/net/ethernet/marvell/mvneta.c | 11 ---

[PATCH net-next 2/2] net: mvneta: add BQL support

2016-09-13 Thread Marcin Wojtas
Tests showed that when whole bandwidth is consumed, the latency for various kind of traffic can reach high values. With saturated link (e.g. with iperf from target to host) simple ping could take significant amount of time. BQL proved to improve this situation when implemented in mvneta driver. Mea

<    1   2   3