Re: [PATCH net-next 0/4] rxrpc: Support IPv6

2016-09-15 Thread David Miller
From: David Howells Date: Tue, 13 Sep 2016 23:41:31 +0100 > > Here is a set of patches that add IPv6 support. They need to be applied on > top of the just-posted miscellaneous fix patches. They are: > > (1) Make autobinding of an unconnected socket work when sendmsg()

Re: [PATCH net-next 00/10] rxrpc: Miscellaneous fixes

2016-09-15 Thread David Miller
From: David Howells Date: Tue, 13 Sep 2016 23:20:56 +0100 > > Here's a set of miscellaneous fix patches. There are a couple of points of > note: > > (1) There is one non-fix patch that adjusts the call ref tracking > tracepoint to make kernel API-held refs on calls

Re: [PATCH] MAINTAINERS: Remove myself from PA Semi entries

2016-09-15 Thread David Miller
From: Michael Ellerman Date: Wed, 14 Sep 2016 18:57:55 +1000 > Olof Johansson writes: > >> Jean, Dave, >> >> I was hoping to have Michael merge this since the bulk of the platform is >> under him, >> cc:ing you mostly to be aware that I am orphaning a

Re: pull-request: mac80211 2016-09-13

2016-09-15 Thread David Miller
From: Johannes Berg Date: Tue, 13 Sep 2016 22:03:23 +0200 > We found a few more issues, I'm sending you small fixes here. The diffstat > would be even shorter, but one of Felix's patches has to move about 30 lines > of code, which makes it seem much bigger than it

Re: [PATCH net-next 3/4] samples/bpf: extend test_tunnel_bpf.sh with IPIP test

2016-09-15 Thread William Tu
Hi Alexei, Is there a corresponding patch for iproute2? I tested this patch but fails at: + ip link add dev ipip11 type ipip external because my ip command does not support "external". Thanks William On Thu, Sep 15, 2016 at 1:00 PM, Alexei Starovoitov wrote: > extend existing

Re: [PATCH] mwifiex: fix null pointer deference when adapter is null

2016-09-15 Thread Kalle Valo
kbuild test robot <l...@intel.com> writes: > url: > https://github.com/0day-ci/linux/commits/Colin-King/mwifiex-fix-null-pointer-deference-when-adapter-is-null/20160915-231625 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git

Re: [PATCHv3 next 3/3] ipvlan: Introduce l3s mode

2016-09-15 Thread David Ahern
On 9/15/16 6:14 PM, Mahesh Bandewar wrote: > diff --git a/drivers/net/ipvlan/ipvlan.h b/drivers/net/ipvlan/ipvlan.h > index 695a5dc9ace3..371f4548c42d 100644 > --- a/drivers/net/ipvlan/ipvlan.h > +++ b/drivers/net/ipvlan/ipvlan.h > @@ -23,11 +23,13 @@ > #include > #include > #include >

Re: [PATCH V3 1/3] Documentation: devicetree: add qca8k binding

2016-09-15 Thread Florian Fainelli
On 09/15/2016 07:26 AM, John Crispin wrote: > Add device-tree binding for ar8xxx switch families. > > Cc: devicet...@vger.kernel.org > Signed-off-by: John Crispin Reviewed-by: Florian Fainelli -- Florian

Re: Modification to skb->queue_mapping affecting performance

2016-09-15 Thread Michael Ma
2016-09-14 10:46 GMT-07:00 Michael Ma : > 2016-09-13 22:22 GMT-07:00 Eric Dumazet : >> On Tue, 2016-09-13 at 22:13 -0700, Michael Ma wrote: >> >>> I don't intend to install multiple qdisc - the only reason that I'm >>> doing this now is to leverage MQ to

Re: [net-next PATCH 00/11] iw_cxgb4,cxgbit: remove duplicate code

2016-09-15 Thread David Miller
From: Varun Prakash Date: Tue, 13 Sep 2016 21:23:55 +0530 > This patch series removes duplicate code from > iw_cxgb4 and cxgbit by adding common function > definitions in libcxgb. > > Please review. Series applied, thanks.

Re: [PATCH net-next] openvswitch: avoid deferred execution of recirc actions

2016-09-15 Thread David Miller
From: Lance Richardson Date: Tue, 13 Sep 2016 10:08:54 -0400 > The ovs kernel data path currently defers the execution of all > recirc actions until stack utilization is at a minimum. > This is too limiting for some packet forwarding scenarios due to > the small size of the

Re: [PATCH net-next V2 0/3] net/sched: cls_flower: Add ports masks

2016-09-15 Thread David Miller
From: Or Gerlitz Date: Thu, 15 Sep 2016 15:28:21 +0300 > This series adds the ability to specify tcp/udp ports masks > for TC/flower filter matches. > > I also removed an unused fields from the flower keys struct > and clarified the format of the recently added vlan

Re: [PATCH net-next v2 2/5] cxgb4: add common api support for configuring filters

2016-09-15 Thread David Miller
From: Rahul Lakkireddy Date: Tue, 13 Sep 2016 17:12:26 +0530 > +/* Fill up default masks for set match fields. */ > +static void fill_default_mask(struct ch_filter_specification *fs) > +{ > + unsigned int i; > + unsigned int lip = 0, lip_mask = 0; > +

Re: [PATCH net-next] alx: fix error handling in __alx_open

2016-09-15 Thread David Miller
From: Tobias Regnery Date: Tue, 13 Sep 2016 12:06:57 +0200 > In commit 9ee7b683ea63 we moved the enablement of msi interrupts earlier in > alx_init_intr. If there is an error in alx_alloc_rings, __alx_open returns > with an error but msi (or msi-x) interrupts stays

[PATCHv3 next 0/3] IPvlan introduce l3s mode

2016-09-15 Thread Mahesh Bandewar
From: Mahesh Bandewar Same old problem with new approach especially from suggestions from earlier patch-series. First thing is that this is introduced as a new mode rather than modifying the old (L3) mode. So the behavior of the existing modes is preserved as it is and the

[PATCHv3 next 2/3] net: Add _nf_(un)register_hooks symbols

2016-09-15 Thread Mahesh Bandewar
From: Mahesh Bandewar Add _nf_register_hooks() and _nf_unregister_hooks() calls which allow caller to hold RTNL mutex. Signed-off-by: Mahesh Bandewar CC: Pablo Neira Ayuso --- include/linux/netfilter.h | 2 ++ net/netfilter/core.c

[PATCHv3 next 1/3] ipv6: Export p6_route_input_lookup symbol

2016-09-15 Thread Mahesh Bandewar
From: Mahesh Bandewar Make ip6_route_input_lookup available outside of ipv6 the module similar to ip_route_input_noref in the IPv4 world. Signed-off-by: Mahesh Bandewar --- include/net/ip6_route.h | 3 +++ net/ipv6/route.c| 7 --- 2 files

[PATCHv3 next 3/3] ipvlan: Introduce l3s mode

2016-09-15 Thread Mahesh Bandewar
From: Mahesh Bandewar In a typical IPvlan L3 setup where master is in default-ns and each slave is into different (slave) ns. In this setup egress packet processing for traffic originating from slave-ns will hit all NF_HOOKs in slave-ns as well as default-ns. However same is

cdc_ncm driver padding problem (WAS: Question about CDC_NCM_FLAG_NDP_TO_END)

2016-09-15 Thread Enrico Mioso
Hello guys. Some very good people managed to detect there is a problem with some Huawei firmwares and NCM padding. I actually don't think I have the hardware to test btw. On Wed, 14 Sep 2016, Marek Brudka wrote: Sorry Marek - I forwarded this message without asking for your consent. Let me

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-15 Thread David Ahern
On 9/15/16 4:48 PM, Eric Dumazet wrote: > On Fri, 2016-09-16 at 00:01 +0300, Cyrill Gorcunov wrote: > >> Here I get kicked off the server. Login back >> >> [cyrill@uranus ~] ssh root@pcs7 >> Last login: Thu Sep 15 23:20:42 2016 from gateway >> [root@pcs7 ~]# cd /home/iproute2/ >> [root@pcs7

Re: [PATCH 0/5] Make /sys/class/net per net namespace objects belong to container

2016-09-15 Thread Eric W. Biederman
Dmitry Torokhov writes: > On Mon, Aug 29, 2016 at 5:38 AM, Eric W. Biederman > wrote: >> David Miller writes: >> >>> From: Dmitry Torokhov >>> Date: Tue, 16 Aug 2016 15:33:10 -0700 >>> There

Re: [PATCHv2 net-next] cxgb4vf: don't offload Rx checksums for IPv6 fragments

2016-09-15 Thread David Miller
From: Hariprasad Shenai Date: Tue, 13 Sep 2016 13:39:24 +0530 > The checksum provided by the device doesn't include the L3 headers, > as IPv6 expects > > Signed-off-by: Hariprasad Shenai > --- > V2: Fixed compilation issue reported by kbuild bot

Re: [PATCH v2 2/2] openvswitch: use percpu flow stats

2016-09-15 Thread Thadeu Lima de Souza Cascardo
On Thu, Sep 15, 2016 at 04:09:26PM -0700, Eric Dumazet wrote: > On Thu, 2016-09-15 at 19:11 -0300, Thadeu Lima de Souza Cascardo wrote: > > Instead of using flow stats per NUMA node, use it per CPU. When using > > megaflows, the stats lock can be a bottleneck in scalability. > > > > On a E5-2690

Re: [PATCH v6 net-next 1/1] net_sched: Introduce skbmod action

2016-09-15 Thread David Miller
From: Jamal Hadi Salim Date: Mon, 12 Sep 2016 20:13:09 -0400 > From: Jamal Hadi Salim > > This action is intended to be an upgrade from a usability perspective > from pedit (as well as operational debugability). > Compare this: > > sudo tc filter add dev

Re: [PATCH v3 net 1/1] net sched actions: fix GETing actions

2016-09-15 Thread David Miller
From: Jamal Hadi Salim Date: Mon, 12 Sep 2016 19:07:38 -0400 > From: Jamal Hadi Salim > > With the batch changes that translated transient actions into > a temporary list lost in the translation was the fact that > tcf_action_destroy() will eventually

Re: [PATCH net-next 0/2] Misc cls_bpf/act_bpf improvements

2016-09-15 Thread David Miller
From: Daniel Borkmann Date: Mon, 12 Sep 2016 23:38:41 +0200 > Two minor improvements to {cls,act}_bpf. For details please see > individual patches. Series applied.

RE: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes regardless of skb or not

2016-09-15 Thread Brown, Aaron F
> > [ cut here ] > > WARNING: CPU: 1 PID: 0 at net/sched/sch_generic.c:316 > dev_watchdog+0x1c2/0x1d0 > > NETDEV WATCHDOG: eth1 (e1000): transmit queue 0 timed out > > Thanks a lot for the tests! Really appreciate it. np, I needed to get my old compatibility systems back

Re: [PATCH net-next 0/5] mlx4 misc fixes and improvements

2016-09-15 Thread David Miller
From: Tariq Toukan Date: Mon, 12 Sep 2016 16:20:11 +0300 > This patchset contains some bug fixes, a cleanup, and small improvements > from the team to the mlx4 Eth and core drivers. > > Series generated against net-next commit: > 02154927c115 "net: dsa: bcm_sf2: Get

[PATCH net-next] pkt_sched: fq: use proper locking in fq_dump_stats()

2016-09-15 Thread Eric Dumazet
From: Eric Dumazet When fq is used on 32bit kernels, we need to lock the qdisc before copying 64bit fields. Otherwise "tc -s qdisc ..." might report bogus values. Fixes: afe4fd062416 ("pkt_sched: fq: Fair Queue packet scheduler") Signed-off-by: Eric Dumazet

Re: [PATCH net-next] net/sched: act_tunnel_key: Remove rcu_read_lock protection

2016-09-15 Thread David Miller
From: Hadar Hen Zion Date: Mon, 12 Sep 2016 15:19:21 +0300 > Remove rcu_read_lock protection from tunnel_key_dump and use > rtnl_dereference, dump operation is protected by rtnl lock. > > Also, remove rcu_read_lock from tunnel_key_release and use >

Re: [PATCH] test_bpf: fix the dummy skb after dissector changes

2016-09-15 Thread David Miller
From: Jakub Kicinski Date: Mon, 12 Sep 2016 13:04:57 +0100 > Commit d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan > info from skb->vlan_tci") made flow dissector look at vlan_proto > when vlan is present. Since test_bpf sets skb->vlan_tci to ~0 >

Re: [PATCH][V2] atm: iphase: fix newline escape and minor tweak to source formatting

2016-09-15 Thread David Miller
From: Colin King Date: Mon, 12 Sep 2016 13:01:50 +0100 > From: Colin Ian King > > The newline escape is incorrect and needs fixing. Also adjust source > formatting / indentation and add { } to trailing else. > > Signed-off-by: Colin Ian King

Re: [PATCH v2 2/2] openvswitch: use percpu flow stats

2016-09-15 Thread Eric Dumazet
On Thu, 2016-09-15 at 19:11 -0300, Thadeu Lima de Souza Cascardo wrote: > Instead of using flow stats per NUMA node, use it per CPU. When using > megaflows, the stats lock can be a bottleneck in scalability. > > On a E5-2690 12-core system, usual throughput went from ~4Mpps to > ~15Mpps when

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-15 Thread Eric Dumazet
On Fri, 2016-09-16 at 00:01 +0300, Cyrill Gorcunov wrote: > Here I get kicked off the server. Login back > > [cyrill@uranus ~] ssh root@pcs7 > Last login: Thu Sep 15 23:20:42 2016 from gateway > [root@pcs7 ~]# cd /home/iproute2/ > [root@pcs7 iproute2]# misc/ss -A raw > State Recv-Q Send-Q

Re: MDB offloading of local ipv4 multicast groups

2016-09-15 Thread Andrew Lunn
On Thu, Sep 15, 2016 at 08:58:50PM +0200, John Crispin wrote: > Hi, > > While adding MDB support to the qca8k dsa driver I found that ipv4 mcast > groups don't always get propagated to the dsa driver. In my setup there > are 2 clients connected to the switch, both running a mdns client. The >

[PATCH v2 2/2] openvswitch: use percpu flow stats

2016-09-15 Thread Thadeu Lima de Souza Cascardo
Instead of using flow stats per NUMA node, use it per CPU. When using megaflows, the stats lock can be a bottleneck in scalability. On a E5-2690 12-core system, usual throughput went from ~4Mpps to ~15Mpps when forwarding between two 40GbE ports with a single flow configured on the datapath.

[PATCH v2 1/2] openvswitch: fix flow stats accounting when node 0 is not possible

2016-09-15 Thread Thadeu Lima de Souza Cascardo
On a system with only node 1 as possible, all statistics is going to be accounted on node 0 as it will have a single writer. However, when getting and clearing the statistics, node 0 is not going to be considered, as it's not a possible node. Tested that statistics are not zero on a system with

Re: [RFC v3 03/22] bpf,landlock: Add a new arraymap type to deal with (Landlock) handles

2016-09-15 Thread Mickaël Salaün
On 15/09/2016 01:28, Alexei Starovoitov wrote: > On Thu, Sep 15, 2016 at 01:22:49AM +0200, Mickaël Salaün wrote: >> >> On 14/09/2016 20:51, Alexei Starovoitov wrote: >>> On Wed, Sep 14, 2016 at 09:23:56AM +0200, Mickaël Salaün wrote: This new arraymap looks like a set and brings new

Re: [RFC v3 07/22] landlock: Handle file comparisons

2016-09-15 Thread Mickaël Salaün
On 15/09/2016 01:24, Alexei Starovoitov wrote: > On Thu, Sep 15, 2016 at 01:02:22AM +0200, Mickaël Salaün wrote: >>> >>> I would suggest for the next RFC to do minimal 7 patches up to this point >>> with simple example that demonstrates the use case. >>> I would avoid all unpriv stuff and all of

[PATCH v2 net-next 4/7] ila: Call library function alloc_bucket_locks

2016-09-15 Thread Tom Herbert
To allocate the array of bucket locks for the hash table we now call library function alloc_bucket_spinlocks. Signed-off-by: Tom Herbert --- net/ipv6/ila/ila_xlat.c | 36 +--- 1 file changed, 5 insertions(+), 31 deletions(-) diff --git

[PATCH v2 net-next 2/7] spinlock: Add library function to allocate spinlock buckets array

2016-09-15 Thread Tom Herbert
Add two new library functions alloc_bucket_spinlocks and free_bucket_spinlocks. These are use to allocate and free an array of spinlocks that are useful as locks for hash buckets. The interface specifies the maximum number of spinlocks in the array as well as a CPU multiplier to derive the number

[PATCH v2 net-next 6/7] net: Generic resolver backend

2016-09-15 Thread Tom Herbert
This patch implements the backend of a resolver, specifically it provides a means to track unresolved addresses and to time them out. The resolver is mostly a frontend to an rhashtable where the key of the table is whatever address type or object is tracked. A resolver instance is created by

[PATCH v2 net-next 0/7] net: ILA resolver and generic resolver backend

2016-09-15 Thread Tom Herbert
This patch set implements an ILA host side resolver. This uses LWT to implement the hook to a userspace resolver and tracks pending unresolved address using the backend net resolver. This patch set contains: - An new library function to allocate an array of spinlocks for use with locking hash

[PATCH v2 net-next 5/7] rhashtable: abstract out function to get hash

2016-09-15 Thread Tom Herbert
Split out most of rht_key_hashfn which is calculating the hash into its own function. This way the hash function can be called separately to get the hash value. Acked-by: Thomas Graf Signed-off-by: Tom Herbert --- include/linux/rhashtable.h | 28

[PATCH v2 net-next 1/7] lwt: Add net to build_state argument

2016-09-15 Thread Tom Herbert
Users of LWT need to know net if they want to have per net operations in LWT. Signed-off-by: Tom Herbert --- include/net/lwtunnel.h| 14 +++--- net/core/lwtunnel.c | 11 +++ net/ipv4/fib_semantics.c | 7 --- net/ipv4/ip_tunnel_core.c | 12

[PATCH v2 net-next 3/7] rhashtable: Call library function alloc_bucket_locks

2016-09-15 Thread Tom Herbert
To allocate the array of bucket locks for the hash table we now call library function alloc_bucket_spinlocks. This function is based on the old alloc_bucket_locks in rhashtable and should produce the same effect. Acked-by: Thomas Graf Signed-off-by: Tom Herbert

[PATCH v2 net-next 7/7] ila: Resolver mechanism

2016-09-15 Thread Tom Herbert
Implement an ILA resolver. This uses LWT to implement the hook to a userspace resolver and tracks pending unresolved address using the backend net resolver. The idea is that the kernel sets an ILA resolver route to the SIR prefix, something like: ip route add ::/64 encap ila-resolve \

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-15 Thread Cyrill Gorcunov
On Thu, Sep 15, 2016 at 02:54:57PM -0600, David Ahern wrote: > On 9/15/16 2:22 PM, Cyrill Gorcunov wrote: > >> ss -K is not working. Socket lookup fails to find a match due to a > >> protocol mismatch. > >> > >> haven't had time to track down why there is a mismatch since the kill uses > >> the

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-15 Thread David Ahern
On 9/15/16 2:22 PM, Cyrill Gorcunov wrote: >> ss -K is not working. Socket lookup fails to find a match due to a protocol >> mismatch. >> >> haven't had time to track down why there is a mismatch since the kill uses >> the socket returned >> from the dump. Won't have time to come back to this

[PATCH net 2/2] bna: fix crash in bnad_get_strings()

2016-09-15 Thread Ivan Vecera
Commit 6e7333d "net: add rx_nohandler stat counter" added the new entry rx_nohandler into struct rtnl_link_stats64. Unfortunately the bna driver foolishly depends on the structure. It uses part of it for ethtool statistics and it's not bad but the driver assumes its size is constant as it defines

[PATCH net 1/2] bna: add missing per queue ethtool stat

2016-09-15 Thread Ivan Vecera
Commit ba5ca784 "bna: check for dma mapping errors" added besides other things a statistic that counts number of DMA buffer mapping failures per each Rx queue. This counter is not included in ethtool stats output. Fixes: ba5ca784 "bna: check for dma mapping errors" Signed-off-by: Ivan Vecera

[PATCH 3/3] l2tp: constify net_device_ops structures

2016-09-15 Thread Julia Lawall
Check for net_device_ops structures that are only stored in the netdev_ops field of a net_device structure. This field is declared const, so net_device_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows:

[PATCH 1/3] hisilicon: constify net_device_ops structures

2016-09-15 Thread Julia Lawall
Check for net_device_ops structures that are only stored in the netdev_ops field of a net_device structure. This field is declared const, so net_device_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows:

Re: MDB offloading of local ipv4 multicast groups

2016-09-15 Thread Ido Schimmel
On Thu, Sep 15, 2016 at 08:58:50PM +0200, John Crispin wrote: > Hi, > > While adding MDB support to the qca8k dsa driver I found that ipv4 mcast > groups don't always get propagated to the dsa driver. In my setup there > are 2 clients connected to the switch, both running a mdns client. The >

[PATCH 2/3] dwc_eth_qos: constify net_device_ops structures

2016-09-15 Thread Julia Lawall
Check for net_device_ops structures that are only stored in the netdev_ops field of a net_device structure. This field is declared const, so net_device_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows:

[PATCH 0/3] constify net_device_ops structures

2016-09-15 Thread Julia Lawall
Constify net_device_ops structures. --- drivers/net/ethernet/hisilicon/hip04_eth.c |2 +- drivers/net/ethernet/synopsys/dwc_eth_qos.c |2 +- net/l2tp/l2tp_eth.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-15 Thread David Ahern
On 9/15/16 2:36 PM, Eric Dumazet wrote: > On Thu, 2016-09-15 at 14:25 -0600, David Ahern wrote: >> On 9/15/16 2:22 PM, Cyrill Gorcunov wrote: ss -K is not working. Socket lookup fails to find a match due to a protocol mismatch. haven't had time to track down why there is a

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-15 Thread Eric Dumazet
On Thu, 2016-09-15 at 14:25 -0600, David Ahern wrote: > On 9/15/16 2:22 PM, Cyrill Gorcunov wrote: > >> ss -K is not working. Socket lookup fails to find a match due to a > >> protocol mismatch. > >> > >> haven't had time to track down why there is a mismatch since the kill uses > >> the socket

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-15 Thread David Ahern
On 9/15/16 2:22 PM, Cyrill Gorcunov wrote: >> ss -K is not working. Socket lookup fails to find a match due to a protocol >> mismatch. >> >> haven't had time to track down why there is a mismatch since the kill uses >> the socket returned >> from the dump. Won't have time to come back to this

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-15 Thread Cyrill Gorcunov
On Thu, Sep 15, 2016 at 01:53:13PM -0600, David Ahern wrote: > On 9/13/16 11:19 AM, Cyrill Gorcunov wrote: > > In criu we are actively using diag interface to collect sockets > > present in the system when dumping applications. And while for > > unix, tcp, udp[lite], packet, netlink it works as

Re: [PATCHv4 net-next 00/15] BPF hardware offload (cls_bpf for now)

2016-09-15 Thread Alexei Starovoitov
On Thu, Sep 15, 2016 at 08:12:20PM +0100, Jakub Kicinski wrote: > In the last year a lot of progress have been made on offloading > simpler TC classifiers. There is also growing interest in using > BPF for generic high-speed packet processing in the kernel. > It seems beneficial to tie those two

Re: [PATCHv4 net-next 07/15] bpf: recognize 64bit immediate loads as consts

2016-09-15 Thread Alexei Starovoitov
On Thu, Sep 15, 2016 at 08:12:27PM +0100, Jakub Kicinski wrote: > When running as parser interpret BPF_LD | BPF_IMM | BPF_DW > instructions as loading CONST_IMM with the value stored > in imm. The verifier will continue not recognizing those > due to concerns about search space/program complexity

Re: [PATCHv4 net-next 06/15] bpf: enable non-core use of the verfier

2016-09-15 Thread Alexei Starovoitov
On Thu, Sep 15, 2016 at 08:12:26PM +0100, Jakub Kicinski wrote: > Advanced JIT compilers and translators may want to use > eBPF verifier as a base for parsers or to perform custom > checks and validations. > > Add ability for external users to invoke the verifier > and provide callbacks to be

Re: [PATCHv4 net-next 05/15] bpf: expose internal verfier structures

2016-09-15 Thread Alexei Starovoitov
On Thu, Sep 15, 2016 at 08:12:25PM +0100, Jakub Kicinski wrote: > Move verifier's internal structures to a header file and > prefix their names with bpf_ to avoid potential namespace > conflicts. Those structures will soon be used by external > analyzers. > > Signed-off-by: Jakub Kicinski

[PATCH net-next 2/4] ip6_tunnel: add collect_md mode to IPv6 tunnels

2016-09-15 Thread Alexei Starovoitov
Similar to gre, vxlan, geneve tunnels allow IPIP6 and IP6IP6 tunnels to operate in 'collect metadata' mode. Unlike ipv4 code here it's possible to reuse ip6_tnl_xmit() function for both collect_md and traditional tunnels. bpf_skb_[gs]et_tunnel_key() helpers and ovs (in the future) are the users.

[PATCH net-next 3/4] samples/bpf: extend test_tunnel_bpf.sh with IPIP test

2016-09-15 Thread Alexei Starovoitov
extend existing tests for vxlan, geneve, gre to include IPIP tunnel. It tests both traditional tunnel configuration and dynamic via bpf helpers. Signed-off-by: Alexei Starovoitov --- samples/bpf/tcbpf2_kern.c | 58 ++

[PATCH net-next 0/4] ip_tunnel: add collect_md mode to IPv4/IPv6 tunnels

2016-09-15 Thread Alexei Starovoitov
Similar to geneve, vxlan, gre tunnels implement 'collect metadata' mode in ipip, ipip6, ip6ip6 tunnels. Alexei Starovoitov (4): ip_tunnel: add collect_md mode to IPIP tunnel ip6_tunnel: add collect_md mode to IPv6 tunnels samples/bpf: extend test_tunnel_bpf.sh with IPIP test samples/bpf:

[PATCH net-next 4/4] samples/bpf: add comprehensive ipip, ipip6, ip6ip6 test

2016-09-15 Thread Alexei Starovoitov
the test creates 3 namespaces with veth connected via bridge. First two namespaces simulate two different hosts with the same IPv4 and IPv6 addresses configured on the tunnel interface and they communicate with outside world via standard tunnels. Third namespace creates collect_md tunnel that is

[PATCH net-next 1/4] ip_tunnel: add collect_md mode to IPIP tunnel

2016-09-15 Thread Alexei Starovoitov
Similar to gre, vxlan, geneve tunnels allow IPIP tunnels to operate in 'collect metadata' mode. bpf_skb_[gs]et_tunnel_key() helpers can make use of it right away. ovs can use it as well in the future (once appropriate ovs-vport abstractions and user apis are added). Note that just like in other

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-15 Thread David Ahern
On 9/13/16 11:19 AM, Cyrill Gorcunov wrote: > In criu we are actively using diag interface to collect sockets > present in the system when dumping applications. And while for > unix, tcp, udp[lite], packet, netlink it works as expected, > the raw sockets do not have. Thus add it. > > v2: > - add

Re: [RFC v3 18/22] cgroup,landlock: Add CGRP_NO_NEW_PRIVS to handle unprivileged hooks

2016-09-15 Thread Mickaël Salaün
On 15/09/2016 06:48, Alexei Starovoitov wrote: > On Wed, Sep 14, 2016 at 09:38:16PM -0700, Andy Lutomirski wrote: >> On Wed, Sep 14, 2016 at 9:31 PM, Alexei Starovoitov >> wrote: >>> On Wed, Sep 14, 2016 at 09:08:57PM -0700, Andy Lutomirski wrote: On Wed, Sep

Re: [RFC v3 18/22] cgroup,landlock: Add CGRP_NO_NEW_PRIVS to handle unprivileged hooks

2016-09-15 Thread Mickaël Salaün
On 15/09/2016 03:25, Andy Lutomirski wrote: > On Wed, Sep 14, 2016 at 3:11 PM, Mickaël Salaün wrote: >> >> On 14/09/2016 20:27, Andy Lutomirski wrote: >>> On Wed, Sep 14, 2016 at 12:24 AM, Mickaël Salaün wrote: Add a new flag CGRP_NO_NEW_PRIVS for each

[PATCHv4 net-next 15/15] nfp: bpf: add offload of TC direct action mode

2016-09-15 Thread Jakub Kicinski
Add offload of TC in direct action mode. We just need to provide appropriate checks in the verifier and a new outro block to translate the exit codes to what data path expects Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_bpf.h |

[PATCHv4 net-next 03/15] net: cls_bpf: add support for marking filters as hardware-only

2016-09-15 Thread Jakub Kicinski
Add cls_bpf support for the TCA_CLS_FLAGS_SKIP_SW flag. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann --- net/sched/cls_bpf.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git

[PATCHv4 net-next 14/15] nfp: bpf: add support for legacy redirect action

2016-09-15 Thread Jakub Kicinski
Data path has redirect support so expressing redirect to the port frame came from is a trivial matter of setting the right result code. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_bpf.h | 1 +

[PATCHv4 net-next 01/15] net: cls_bpf: add hardware offload

2016-09-15 Thread Jakub Kicinski
This patch adds hardware offload capability to cls_bpf classifier, similar to what have been done with U32 and flower. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann --- v3: - s/filter/prog/ in struct tc_cls_bpf_offload. v2: - drop

[PATCHv4 net-next 00/15] BPF hardware offload (cls_bpf for now)

2016-09-15 Thread Jakub Kicinski
Hi! Dave, this set depends on bitfield.h which is sitting in the pull request from Kalle. I'm expecting buildbot to complain about patch 8, please pull wireless-drivers-next before applying. v4: - rename parser -> analyzer; - reorganize the analyzer patches a bit; - use bitfield.h directly.

[PATCHv4 net-next 13/15] net: act_mirred: allow statistic updates from offloaded actions

2016-09-15 Thread Jakub Kicinski
Implement .stats_update() callback. The implementation is generic and can be reused by other simple actions if needed. Signed-off-by: Jakub Kicinski --- net/sched/act_mirred.c | 8 1 file changed, 8 insertions(+) diff --git a/net/sched/act_mirred.c

[PATCHv4 net-next 08/15] nfp: add BPF to NFP code translator

2016-09-15 Thread Jakub Kicinski
Add translator for JITing eBPF to operations which can be executed on NFP's programmable engines. Signed-off-by: Jakub Kicinski --- v4: - use bitfield.h directly. v3: - don't clone the program for the verifier (no longer needed); - temporarily add a local copy of

[PATCHv4 net-next 06/15] bpf: enable non-core use of the verfier

2016-09-15 Thread Jakub Kicinski
Advanced JIT compilers and translators may want to use eBPF verifier as a base for parsers or to perform custom checks and validations. Add ability for external users to invoke the verifier and provide callbacks to be invoked for every intruction checked. For now only add most basic callback for

[PATCHv4 net-next 11/15] nfp: bpf: allow offloaded filters to update stats

2016-09-15 Thread Jakub Kicinski
Periodically poll stats and call into offloaded actions to update them. Signed-off-by: Jakub Kicinski --- v3: - add missing hunk with ethtool stats. --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 19 +++

[PATCHv4 net-next 09/15] nfp: bpf: add hardware bpf offload

2016-09-15 Thread Jakub Kicinski
Add hardware bpf offload on our smart NICs. Detect if capable firmware is loaded and use it to load the code JITed with just added translator onto programmable engines. This commit only supports offloading cls_bpf in legacy mode (non-direct action). Signed-off-by: Jakub Kicinski

[PATCHv4 net-next 12/15] nfp: bpf: add packet marking support

2016-09-15 Thread Jakub Kicinski
Add missing ABI defines and eBPF instructions to allow mark to be passed on and extend prepend parsing on the RX path to pick it up from packet metadata. Signed-off-by: Jakub Kicinski --- v3: - change metadata format. ---

[PATCHv4 net-next 05/15] bpf: expose internal verfier structures

2016-09-15 Thread Jakub Kicinski
Move verifier's internal structures to a header file and prefix their names with bpf_ to avoid potential namespace conflicts. Those structures will soon be used by external analyzers. Signed-off-by: Jakub Kicinski --- v4: - separate from adding the analyzer; -

[PATCHv4 net-next 02/15] net: cls_bpf: limit hardware offload by software-only flag

2016-09-15 Thread Jakub Kicinski
Add cls_bpf support for the TCA_CLS_FLAGS_SKIP_HW flag. Unlike U32 and flower cls_bpf already has some netlink flags defined. Create a new attribute to be able to use the same flag values as the above. Unlike U32 and flower reject unknown flags. Signed-off-by: Jakub Kicinski

[PATCHv4 net-next 04/15] bpf: don't (ab)use instructions to store state

2016-09-15 Thread Jakub Kicinski
Storing state in reserved fields of instructions makes it impossible to run verifier on programs already marked as read-only. Allocate and use an array of per-instruction state instead. While touching the error path rename and move existing jump target. Suggested-by: Alexei Starovoitov

[PATCHv4 net-next 10/15] net: cls_bpf: allow offloaded filters to update stats

2016-09-15 Thread Jakub Kicinski
Call into offloaded filters to update stats. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann --- include/net/pkt_cls.h | 1 + net/sched/cls_bpf.c | 11 +++ 2 files changed, 12 insertions(+) diff --git

[PATCHv4 net-next 07/15] bpf: recognize 64bit immediate loads as consts

2016-09-15 Thread Jakub Kicinski
When running as parser interpret BPF_LD | BPF_IMM | BPF_DW instructions as loading CONST_IMM with the value stored in imm. The verifier will continue not recognizing those due to concerns about search space/program complexity increase. Signed-off-by: Jakub Kicinski

MDB offloading of local ipv4 multicast groups

2016-09-15 Thread John Crispin
Hi, While adding MDB support to the qca8k dsa driver I found that ipv4 mcast groups don't always get propagated to the dsa driver. In my setup there are 2 clients connected to the switch, both running a mdns client. The .port_mdb_add() callback is properly called for 33:33:00:00:00:FB but

Re: XDP user interface confusions

2016-09-15 Thread Brenden Blanco
On Thu, Sep 15, 2016 at 08:14:02PM +0200, Jesper Dangaard Brouer wrote: > Hi Brenden, > > I don't quite understand the semantics of the XDP userspace interface. > > We allow XDP programs to be (unconditionally) exchanged by another > program, this avoids taking the link down+up and avoids

XDP user interface confusions

2016-09-15 Thread Jesper Dangaard Brouer
Hi Brenden, I don't quite understand the semantics of the XDP userspace interface. We allow XDP programs to be (unconditionally) exchanged by another program, this avoids taking the link down+up and avoids reallocating RX ring resources (which is great). We have two XDP samples programs in

XDP user interface conclusions

2016-09-15 Thread Jesper Dangaard Brouer
Hi Brenden, I don't quite understand the semantics of the XDP userspace interface. We allow XDP programs to be (unconditionally) exchanged by another program, this avoids taking the link down+up and avoids reallocating RX ring resources (which is great). We have two XDP samples programs in

[PATCH next] sctp: make use of WORD_TRUNC macro

2016-09-15 Thread Marcelo Ricardo Leitner
No functional change. Just to avoid the usage of '&~3'. Also break the line to make it easier to read. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/chunk.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/sctp/chunk.c

[PATCH net] sctp: fix SSN comparision

2016-09-15 Thread Marcelo Ricardo Leitner
This function actually operates on u32 yet its paramteres were declared as u16, causing integer truncation upon calling. Note in patch context that ADDIP_SERIAL_SIGN_BIT is already 32 bits. Signed-off-by: Marcelo Ricardo Leitner --- This issue exists since before git

Re: [PATCH net-next] tcp: prepare skbs for better sack shifting

2016-09-15 Thread Yuchung Cheng
On Thu, Sep 15, 2016 at 9:33 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > With large BDP TCP flows and lossy networks, it is very important > to keep a low number of skbs in the write queue. > > RACK and SACK processing can perform a linear scan

[PATCH] llc: switch type to bool as the timeout is only tested versus 0

2016-09-15 Thread Alan
(As asked by Dave in Februrary) Signed-off-by: Alan Cox --- net/llc/af_llc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c index 8ae3ed9..db916cf 100644 --- a/net/llc/af_llc.c +++ b/net/llc/af_llc.c @@ -38,7

Re: [PATCH] mwifiex: fix memory leak on regd when chan is zero

2016-09-15 Thread Colin Ian King
On 15/09/16 18:10, Kalle Valo wrote: > Colin King writes: > >> From: Colin Ian King >> >> When chan is zero mwifiex_create_custom_regdomain does not kfree >> regd and we have a memory leak. Fix this by freeing regd before >> the return. >> >>

[PATCH net-next] net: l3mdev: Remove netif_index_is_l3_master

2016-09-15 Thread David Ahern
No longer used after e0d56fdd73422 ("net: l3mdev: remove redundant calls") Signed-off-by: David Ahern --- include/net/l3mdev.h | 24 1 file changed, 24 deletions(-) diff --git a/include/net/l3mdev.h b/include/net/l3mdev.h index

Re: [PATCH net-next 1/7] lwt: Add net to build_state argument

2016-09-15 Thread Roopa Prabhu
On 9/14/16, 4:22 PM, Tom Herbert wrote: > Users of LWT need to know net if they want to have per net operations > in LWT. > > Signed-off-by: Tom Herbert > --- > Acked-by: Roopa Prabhu

[PATCH net-next] net: vrf: Remove RT_FL_TOS

2016-09-15 Thread David Ahern
No longer used after d66f6c0a8f3c0 ("net: ipv4: Remove l3mdev_get_saddr") Signed-off-by: David Ahern --- drivers/net/vrf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 55674b0e65b7..85c271c70d42 100644 ---

  1   2   >