Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

From: Shmulik Ladkani Date: Thu, 22 Sep 2016 16:21:52 +0300 > From: Shmulik Ladkani > > Up until now, 'action mirred' supported only egress actions (either > TCA_EGRESS_REDIR or TCA_EGRESS_MIRROR). > > This patch implements the

Re: [PATCH nf-next] netfilter: xt_osf: Use explicit member assignment to avoid implicit no padding rule

Hi Feng, 2016-09-27 12:39 GMT+08:00 : > From: Gao Feng > > Current xt_osf codes use memcmp to check if two user fingers are same, > so it depends on that the struct xt_osf_user_finger is no padding. > It is one implicit rule, and is not good to maintain. > >

Re: [PATCH v2 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

> When you need to make changes to patches that are part of a series, > you must resubmit the entire series, I imagine that will happen when the patch review time passed by a bit more as Paul Bolle requested it yesterday. > not just the things that are changes. Thanks for your reminder.

Re: ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

>> Memory was not released (as it would be expected) when one call >> of further resource reservations failed. > > This was the only thing in this series that triggered more than a, > very uninspired, "meh" on first read. Will it matter here if the function "kfree" will be called for the data

Re: ISDN-Gigaset: Fine-tuning for three function implementations

>> Use kmalloc_array() in two functions >> Improve another size determination in gigaset_initcs() >> Delete an error message for a failed memory allocation >> Release memory in gigaset_initcs() after an allocation failure > > Which "static source code analysis" was used for that

[PATCH nf-next] netfilter: xt_osf: Use explicit member assignment to avoid implicit no padding rule

From: Gao Feng Current xt_osf codes use memcmp to check if two user fingers are same, so it depends on that the struct xt_osf_user_finger is no padding. It is one implicit rule, and is not good to maintain. Now use zero memory and assign the members explicitly. Signed-off-by:

Re: [PATCH v3 2/2] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates

Hi Vishwanath, 2016-09-23 0:43 GMT+08:00 Vishwanath Pai : > > /* Precision saver. */ > -static u32 user2credits(u32 user) > +static u64 user2credits(u64 user, int revision) > { > - /* If multiplying would overflow... */ > - if (user > 0x /

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Mon, Sep 26, 2016 at 9:53 AM, Jiri Benc wrote: > Reviving a very old thread, sorry. Simon handed this over to me, I'm > preparing v12. > > On Fri, 15 Jul 2016 14:07:37 -0700, pravin shelar wrote: >> I am not sure if you can use only mac_len to detect L3 packet. This >> does

[PATCH] igb: Realign bad indentation

Statements should start on tabstops. Use a single statement and test instead of multiple tests. Signed-off-by: Joe Perches --- drivers/net/ethernet/intel/igb/e1000_mac.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git

[PATCH] i40e: Make struct i40e_stats const

Move some data to text $ size drivers/net/ethernet/intel/i40e/i40e_ethtool.o* textdata bss dec hex filename 25012 0 32 2504461d4 drivers/net/ethernet/intel/i40e/i40e_ethtool.o.new 228682120 32 2502061bc

Re: [PATCH v4 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval'

> Is seconds granular enough? The only reason why one would ever want to go into fractions of seconds would be some sort of unittesting with very low delays. In any normal environment the max is going to be tens if not hundreds or thousands of seconds. Also note that the delay and interval (ie.

Re: [PATCH v2 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited

On 27 September 2016 at 11:23, Maciej Żenczykowski wrote: >> Given that some of this patch checks for == -1, and some of it checks >> for != 0... is it possible that setting the value to something >> unexpected like -3 will cause any issues to the stack? (Other than >>

Re: [PATCH v2 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited

> Given that some of this patch checks for == -1, and some of it checks > for != 0... is it possible that setting the value to something > unexpected like -3 will cause any issues to the stack? (Other than > just rendering IPv6 unusable on this interface, which seems like a > given.) You

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

On 9/26/16 11:02 AM, Jiri Benc wrote: > On Mon, 26 Sep 2016 17:56:22 +0200, Jiri Benc wrote: >> After push_mpls, network_header points to the start of MPLS headers. >> Which I understand was the point of this patch. However, push_mpls also >> calls invalidate_flow_key. Meaning that, depending on

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

On 9/26/16 4:38 PM, Cyrill Gorcunov wrote: > Something like > > Index: linux-ml.git/include/uapi/linux/inet_diag.h > === > --- linux-ml.git.orig/include/uapi/linux/inet_diag.h2016-09-11 > 20:56:18.191584145 +0300 > +++

Re: [PATCH v2] fs/select: add vmalloc fallback for select(2)

On Mon, 2016-09-26 at 17:01 -0700, Andrew Morton wrote: > I don't share Eric's concerns about performance here. If the vmalloc() > is called, we're about to write to that quite large amount of memory > which we just allocated, and the vmalloc() overhead will be relatively > low. I did not care

Re: [PATCH] net: tg3: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 25 Sep 2016 23:31:24 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied, thanks.

Re: [PATCH v2 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

When you need to make changes to patches that are part of a series, you must resubmit the entire series, not just the things that are changes.

Re: [PATCH v2] fs/select: add vmalloc fallback for select(2)

On Thu, 22 Sep 2016 18:43:59 +0200 Vlastimil Babka wrote: > The select(2) syscall performs a kmalloc(size, GFP_KERNEL) where size grows > with the number of fds passed. We had a customer report page allocation > failures of order-4 for this allocation. This is a costly order, so

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

On Wed, Sep 21, 2016 at 12:13:43AM +0300, Cyrill Gorcunov wrote: > On Fri, Sep 16, 2016 at 11:07:22PM +0300, Cyrill Gorcunov wrote: > > > It may well be a ss bug / problem. As I mentioned I am always seeing 255 > > > for the protocol which > > > > It is rather not addressed in ss. I mean, look,

Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

On Sat, Sep 24, 2016 at 04:21:24PM -0700, Adit Ranadive wrote: > MAINTAINERS|9 + > drivers/infiniband/Kconfig |1 + > drivers/infiniband/hw/Makefile |1 + > drivers/infiniband/hw/pvrdma/Kconfig |7 +

[PATCH resend] sh_eth: add R8A7743/5 support

Add support for the first two members of the Renesas RZ/G family, RZ/G1M/E (also known as R8A7743/5). The Ether core is the same as in the R-Car gen2 SoCs, so will share the code/data with them... Signed-off-by: Sergei Shtylyov --- The patch is against the

Re: [PATCH] net: trivial: fix fsl fec_main mdio write return value

Hello. On 09/26/2016 10:11 PM, Albert ARIBAUD (3ADEV) wrote: If the MDIO enf-of-transfer wait loop does not time out, 0 should be returned to the caller through ret, but ret was not reset to 0 after receiving the return value of pm_runtime_get_sync(). Reset ret when no time out occurred.

[PATCH] sh_eth: add R8A7743/5 support

Add support for the first two members of the Renesas RZ/G family, RZ/G1M/E (also known as R8A7743/5). The Ether core is the same as in the R-Car gen2 SoCs, so will share the code/data with them... Signed-off-by: Sergei Shtylyov --- The patch is against the

[PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

From: Chris Roth Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller (Vendor=04b4 ProdID=3610). Patch verified on x64 linux kernel 4.7.4 system with the Kensington SD4600P USB-C Universal Dock with Power, which uses the Cypress GX3 SuperSpeed to

Re: [PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

I'm not sure what I'm doing wrong: I'm trying to get the from statement to read original author (Allan Chou) first, and then me (Chris Roth) second. I've used the following two commands: git format-patch -o /tmp/ --subject-prefix="PATCH v2" --from="Allan Chou " HEAD^ and git

[PATCH] brcmfmac: proto: add callback for queuing TX data

From: Rafał Miłecki So far our core code was calling brcmf_fws_process_skb which wasn't a proper thing to do. If case of devices using msgbuf protocol fwsignal shouldn't be used. It was an unnecessary extra layer simply calling a protocol specifix txdata function. Please note

Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

On Mon, Sep 26, 2016 at 14:07:24PM -0700, Jason Gunthorpe wrote: > On Mon, Sep 26, 2016 at 01:40:10PM -0700, Adit Ranadive wrote: > > > Wouldnt they be some overlap between the user-space and kernel driver? Or is > > it expected that the common structures (even device specific ones) be moved > >

Re: [PATCH v3 net-next 0/3] net: bcmgenet: only use new api ethtool_{get|set}_link_ksettings

On 09/26/2016 01:31 PM, Philippe Reynes wrote: > Some times ago, a serie of patches were committed : > - commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from struct > net_device") > - commit 6b352ebccbcf ("net: ethernet: broadcom: bcmgenet: use new api >

Re: [PATCH 4/5] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

Markus, On Mon, 2016-09-26 at 17:43 +0200, SF Markus Elfring wrote: > Memory was not released (as it would be expected) when one call > of further resource reservations failed. This was the only thing in this series that triggered more than a, very uninspired, "meh" on first read. > * Split a

Re: [PATCH] net: trivial: fix fsl fec_main mdio write return value

Hi Fabio, You are correct -- I'd rebased my patch as part of a series, and I did not notice that the fix was already there. Apologies and thanks for pointing it out. Le Mon, 26 Sep 2016 18:00:32 -0300, Fabio Estevam a écrit : > Hi Albert, > > On Mon, Sep 26, 2016 at 4:11

Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

On Mon, Sep 26, 2016 at 01:40:10PM -0700, Adit Ranadive wrote: > Wouldnt they be some overlap between the user-space and kernel driver? Or is > it expected that the common structures (even device specific ones) be moved to > the ABI file? Yes, even device specific structures must be in the abi

Re: [PATCH] net: trivial: fix fsl fec_main mdio write return value

Hi Albert, On Mon, Sep 26, 2016 at 4:11 PM, Albert ARIBAUD (3ADEV) wrote: > If the MDIO enf-of-transfer wait loop does not time out, > 0 should be returned to the caller through ret, but ret > was not reset to 0 after receiving the return value of >

Re: 答复: [PATCH] sunrpc: queue work on system_power_efficient_wq

Hi, I took a second look at the patch and it still looks okay to me. It's in my git tree for 4.9. Thanks, Anna On 09/19/2016 10:33 PM, Ke Wang (王科) wrote: > May I have any comments for this patch? > or > This patch can be merged directly into next release? > > Thanks, > Ke >

Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

On Mon, Sep 26, 2016 at 10:51:04AM -0600, Jason Gunthorpe wrote: > On Sun, Sep 25, 2016 at 10:25:12PM -0700, Adit Ranadive wrote: > > > As Jason said, you need a very good reason to split and create number of > > > files per-driver in UAPI folder. > > > > I can move the pvrdma-uapi.h back to the

Re: [PATCH 0/5] ISDN-Gigaset: Fine-tuning for three function implementations

On Mon, 2016-09-26 at 17:37 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 26 Sep 2016 17:27:17 +0200 > > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5): >   Use kmalloc_array() in

Re: [PATCH net-next] net/sched: pkt_cls: change tc actions order to be as the user sets

On Sun, Sep 25, 2016 at 11:02 PM, Hadar Hen Zion wrote: > On Mon, Sep 26, 2016 at 7:31 AM, Cong Wang wrote: >> On Sun, Sep 25, 2016 at 7:39 AM, Jamal Hadi Salim wrote: >>> On 16-09-25 10:08 AM, Hadar Hen Zion wrote:

[PATCH v3 net-next 2/3] Revert "net: ethernet: bcmgenet: use phydev from struct net_device"

From: Florian Fainelli This reverts commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from struct net_device") because it causes GENETv1/2/3 adapters to expose the following behavior after an ifconfig down/up sequence: PING fainelli-linux (10.112.156.244): 56 data

[PATCH v3 net-next 1/3] Revert "net: ethernet: bcmgenet: use new api ethtool_{get|set}_link_ksettings"

This reverts commit 6b352ebccbcf ("net: ethernet: broadcom: bcmgenet: use new api ethtool_{get|set}_link_ksettings"). We needs to revert the commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from struct net_device"), because this commit add a regression. As the commit 6b352ebccbcf ("net:

[PATCH v3 net-next 3/3] net: bcmgenet: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH v3 net-next 0/3] net: bcmgenet: only use new api ethtool_{get|set}_link_ksettings

Some times ago, a serie of patches were committed : - commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from struct net_device") - commit 6b352ebccbcf ("net: ethernet: broadcom: bcmgenet: use new api ethtool_{get|set}_link_ksettings") The first patch add a regression on this driver, so

Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces

On Mon, 2016-09-26 at 14:52 +0200, SF Markus Elfring wrote: > Would it eventually make sense to move this "if" (behind an "else") > to a separate line and increase the indentation for the corresponding > code one level then? No. Paul Bolle

Re: [PATCH] net: trivial: fix fsl fec_main mdio write return value

... and of course I only see the typo /now/... Le Mon, 26 Sep 2016 21:11:40 +0200, "Albert ARIBAUD (3ADEV)" a écrit : > If the MDIO enf-of-transfer wait loop does not time out, ~~~ Make that "end-of-transfer". Should I post a v2?

[PATCH] net: trivial: fix fsl fec_main mdio write return value

If the MDIO enf-of-transfer wait loop does not time out, 0 should be returned to the caller through ret, but ret was not reset to 0 after receiving the return value of pm_runtime_get_sync(). Reset ret when no time out occurred. Signed-off-by: Albert ARIBAUD (3ADEV) ---

[PATCH v4 2/2] libxt_hashlimit: Create revision 2 of xt_hashlimit to support higher pps rates

v2: * Added two tests for 100pps support to libxt_hashlimit.t * cfg_copy returns -EINVAL and all callers of cfg_copy will look for the error value v3: Reorder mode, avg and burst in hashlimit_cfg2 to avoid padding v4: XT_HASHLIMIT_SCALE for rev2 is now XT_HASHLIMIT_SCALE_v2 --

[PATCH v4 1/2] libxt_hashlimit: Prepare libxt_hashlimit.c for revision 2

v4: Do not rename XT_HASHLIMIT_SCALE to XT_HASHLIMIT_SCALE_v1 this will break userspace, instead rename XT_HASHLIMIT_SCALE for v2 as XT_HASHLIMIT_SCALE_v2 -- I am planning to add a revision 2 for the hashlimit xtables module to support higher packets per second rates. This patch renames all the

Re: [PATCH v2 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

> Don't resubmit one single patch of a series (within hours!) > as you did here. I hope that I could reduce the confusion a bit which I introduced with a change in the last step of my questionable update suggestion. > I hope to have a look at your series within a few days. > Show some patience.

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

On Mon, 2016-09-26 at 21:37 +0300, Kalle Valo wrote: > I talked with Jouni and we concluded marking this fully obsolete is the > best (so removing the "Maintained" part completelo the shmoo list > is not used anymore, that can be removed. Well, it would be best if Jouni submitted something.

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

Joe Perches writes: > On Mon, 2016-09-26 at 21:01 +0300, Kalle Valo wrote: >> hostap is an obsolete driver, it's waste of time doing style fixes to it >> as nobody maintains it anymore. > > Dunno know if Jouni is still maintaining this at all > but maybe a MAINTAINERS update to

Re: [PATCH 3/3] net: fec: align IP header in hardware

Hi David, On 09/26/2016 02:26 AM, David Laight wrote: > From: Eric Nelson >> Sent: 24 September 2016 15:42 >> The FEC receive accelerator (RACC) supports shifting the data payload of >> received packets by 16-bits, which aligns the payload (IP header) on a >> 4-byte boundary, which is, if not

Re: ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

Where did the [PATCH 5/5] part of the subject go? You didn't drop it, did you? Because that's surprisingly annoying. Paul Bolle

Re: [PATCH v2 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

On Mon, 2016-09-26 at 19:44 +0200, SF Markus Elfring wrote: > v2: Position the desired closing parenthesis behind the variable name for > a character buffer. Please wait a reasonable amount of time (say a week or two) to collect all feedback on all patches of a series. If there's feedback you

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

On Mon, 2016-09-26 at 21:01 +0300, Kalle Valo wrote: > hostap is an obsolete driver, it's waste of time doing style fixes to it > as nobody maintains it anymore. Dunno know if Jouni is still maintaining this at all but maybe a MAINTAINERS update to mark it obsolete so checkpatch warns on

Re: [PATCH v5 13/16] IB/pvrdma: Add the main driver module for PVRDMA

On Mon, Sep 26, 2016 at 00:27:40AM -0700, Yuval Shaia wrote: > On Sat, Sep 24, 2016 at 04:21:37PM -0700, Adit Ranadive wrote: > > + > > + /* Currently, the driver only supports RoCE mode. */ > > + if (dev->dsr->caps.mode != PVRDMA_DEVICE_MODE_ROCE) { > > + dev_err(>dev, "unsupported

Re: [PATCH v5 08/16] IB/pvrdma: Add device command support

On Mon, Sep 26, 2016 at 00:16:01AM -0700, Yuval Shaia wrote: > Minor question/suggestion inline. > (sorry for missing it till now). > > Yuval <...> > > +int > > +pvrdma_cmd_post(struct pvrdma_dev *dev, union pvrdma_cmd_req *req, > > + union pvrdma_cmd_resp *resp, unsigned resp_code) >

Re: [PATCH v2 net-next 3/3] net: bcmgenet: use new api ethtool_{get|set}_link_ksettings

On 09/25/2016 09:29 AM, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes > --- > drivers/net/ethernet/broadcom/genet/bcmgenet.c | 24 >

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

> hostap is an obsolete driver, it's waste of time doing style fixes to it > as nobody maintains it anymore. Thanks for another bit of your software development attention and this information. Is it easier to understand than the previous response "Reason: The benefit is not clear."? Regards,

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

SF Markus Elfring writes: >> 9291771 [2/3] hostap: Delete an unnecessary jump label in >> prism2_ioctl_priv_hostapd() >> 9291775 [3/3] hostap: Delete unnecessary initialisations for the variable >> "ret" >> >> Reason: The benefit is not clear. > > How do you

Re: ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

>> @@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const >> unsigned char *msg, >> { >> unsigned char outbuf[80]; >> unsigned char c; >> -size_t space = sizeof outbuf - 1; >> +size_t space = sizeof(outbuf - 1); > >What?! Does that compile? Yes, of course.

Re: [PATCH v3] bpf: Set register type according to is_valid_access()

On Mon, Sep 26, 2016 at 04:49:17PM +0200, Daniel Borkmann wrote: > On 09/24/2016 08:01 PM, Mickaël Salaün wrote: > >This prevent future potential pointer leaks when an unprivileged eBPF > >program will read a pointer value from its context. Even if > >is_valid_access() returns a pointer type, the

Re: brcmfmac: drop unused fields from struct brcmf_pub

Rafał Miłecki wrote: > From: Rafał Miłecki > > They seem to be there from the first day. We calculate these values but > never use them. > > Signed-off-by: Rafał Miłecki Patch applied to wireless-drivers-next.git, thanks. 2df86ad959c9 brcmfmac: drop unused

Re: brcmfmac: fix memory leak in brcmf_fill_bss_param

Rafał Miłecki wrote: > From: Rafał Miłecki > > This function is called from get_station callback which means that every > time user space was getting/dumping station(s) we were leaking 2 KiB. > > Signed-off-by: Rafał Miłecki > Fixes: 1f0dc59a6de ("brcmfmac:

Re: [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled

Hi all, On Tue, 2016-01-12 at 21:30 +0100, Uwe Kleine-König wrote: > Hello, > > On Tue, Jan 12, 2016 at 05:04:44PM +0100, Lothar Waßmann wrote: > > > > > > > > On Tue, Jan 12, 2016 at 04:17:54PM +0100, Lothar Waßmann wrote: > > > > > > > > This patchset fixes a regression introduced by > > >

[PATCH v2 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

From: Markus Elfring Date: Mon, 26 Sep 2016 19:34:27 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" can point information out like the following. WARNING: sizeof … should be sizeof(…)

Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

Hello. On 09/26/2016 06:44 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Mon, 26 Sep 2016 17:03:56 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" can point information out

Re: [PATCH v5 02/16] IB/pvrdma: Add user-level shared functions

On Sun, Sep 25, 2016 at 23:13:38PM -0700, Leon Romanovsky wrote: > On Sun, Sep 25, 2016 at 09:22:11PM -0700, Adit Ranadive wrote: >> On Sun, Sep 25 2016 at 10:26:24AM +0300, Leon Romanovsky wrote: > > > > On Sat, Sep 24, 2016 at 04:21:26PM -0700, Adit Ranadive wrote: > > > > We share some common

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

On Mon, 26 Sep 2016 17:56:22 +0200, Jiri Benc wrote: > After push_mpls, network_header points to the start of MPLS headers. > Which I understand was the point of this patch. However, push_mpls also > calls invalidate_flow_key. Meaning that, depending on actions, we may > end up calling key_extract

Re: [PATCH] net: tg3: use new api ethtool_{get|set}_link_ksettings

On Sun, Sep 25, 2016 at 2:31 PM, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Looks good to me. Thanks. Acked-by: Michael Chan

Re: [PATCH] ath10k: fix system hang at qca99x0 probe on x86 platform (DMA32 issue)

On 07/20/2016 10:02 AM, Adrian Chadd wrote: Hi, The "right" way for the target CPU to interact with host CPU memory (and vice versa, for mostly what it's worth) is to have the copy engine copy (ie, "DMA") the pieces between them. This may be for diagnostic purposes, but it's not supposed to be

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

Reviving a very old thread, sorry. Simon handed this over to me, I'm preparing v12. On Fri, 15 Jul 2016 14:07:37 -0700, pravin shelar wrote: > I am not sure if you can use only mac_len to detect L3 packet. This > does not work with MPLS packets, mac_len is used to account MPLS > headers pushed on

Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

On Sun, Sep 25, 2016 at 10:25:12PM -0700, Adit Ranadive wrote: > > As Jason said, you need a very good reason to split and create number of > > files per-driver in UAPI folder. > > I can move the pvrdma-uapi.h back to the pvrdma driver folder. Just don't copy any of the content into your user

Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

On Mon, 26 Sep 2016, SF Markus Elfring wrote: > >>> @@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const > >>> unsigned char *msg, > >>> { > >>> unsigned char outbuf[80]; > >>> unsigned char c; > >>> - size_t space = sizeof outbuf - 1; > >>> + size_t space =

Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

>>> @@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const >>> unsigned char *msg, >>> { >>> unsigned char outbuf[80]; >>> unsigned char c; >>> - size_t space = sizeof outbuf - 1; >>> + size_t space = sizeof(outbuf - 1); > >> wrong ... >> think that is 7 instead of

Re: [PATCH nf-next 2/2] nf_set_hooks_head: acommodate different kconfig

Florian Westphal writes: > Aaron Conole wrote: >> When CONFIG_NETFILTER_INGRESS is unset (or no), we need to handle >> the request for registration properly by dropping the hook. This >> releases the entry during the set. >> >> Signed-off-by: Aaron Conole

Re: [PATCH nf-next 2/2] nf_set_hooks_head: acommodate different kconfig

Aaron Conole wrote: > When CONFIG_NETFILTER_INGRESS is unset (or no), we need to handle > the request for registration properly by dropping the hook. This > releases the entry during the set. > > Signed-off-by: Aaron Conole > --- > net/netfilter/core.c

Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

On Mon, 2016-09-26 at 16:00 +, David Laight wrote: > From: SF Markus Elfring Sent: 26 September 2016 16:45 > > The script "checkpatch.pl" can point information out like the following. > > WARNING: sizeof … should be sizeof(…) > [] > > diff --git a/drivers/isdn/gigaset/common.c

[PATCH nf-next 0/2] fixes for recent nf_compact hooks

Two possible error conditions were caught during an extended testing session, and by a build robot. These patches fix the two issues (a missing handler when config is changed, and a potential NULL dereference). Aaron Conole (2): netfilter: Fix potential null pointer dereference

[PATCH nf-next 2/2] nf_set_hooks_head: acommodate different kconfig

When CONFIG_NETFILTER_INGRESS is unset (or no), we need to handle the request for registration properly by dropping the hook. This releases the entry during the set. Signed-off-by: Aaron Conole --- net/netfilter/core.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH nf-next 1/2] netfilter: Fix potential null pointer dereference

It's possible for nf_hook_entry_head to return NULL if two nf_unregister_net_hook calls happen simultaneously with a single hook entry in the list. This fix ensures that no null pointer dereference could occur when such a race happens. Signed-off-by: Aaron Conole ---

RE: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

From: SF Markus Elfring > Sent: 26 September 2016 16:45 ... > The script "checkpatch.pl" can point information out like the following. > > WARNING: sizeof … should be sizeof(…) ... > --- > drivers/isdn/gigaset/common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

> 9291771 [2/3] hostap: Delete an unnecessary jump label in > prism2_ioctl_priv_hostapd() > 9291775 [3/3] hostap: Delete unnecessary initialisations for the variable > "ret" > > Reason: The benefit is not clear. How do you think about to reduce the source code a bit at these places? Regards,

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

On Wed, 24 Aug 2016 10:37:51 -0600, David Ahern wrote: > Something like this should be able to handle multiple labels. The > inner network header is set once and the outer one pointing to MPLS > is adjusted each time a label is pushed: > > diff --git a/net/openvswitch/actions.c

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

On 09/26/2016 05:12 PM, Hannes Frederic Sowa wrote: [...] I would just care that we sometimes reschedule and don't do everything in one stack so we don't corrupt the machine and an admin has still a chance to solve the problem. Sounds reasonable to me, and which is what dev_forward_skb() is

[PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

From: Markus Elfring Date: Mon, 26 Sep 2016 17:03:56 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" can point information out like the following. WARNING: sizeof … should be sizeof(…)

RE: [RFC v3 00/11] QLogic RDMA Driver (qedr) RFC

> The series adds on top of RFC v2: > * fix licensing header to dual license > * remove 'debug' module paramter and make use of pr_debug > * relocation of qedr user API to include/rdma/uapi/ > * use the __u32/64 in uapi and include types.h > * advance ABI version (since shifting to __u32/64

[PATCH 4/5] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

From: Markus Elfring Date: Mon, 26 Sep 2016 16:30:50 +0200 Memory was not released (as it would be expected) when one call of further resource reservations failed. * Split a condition check for memory allocation failures so that each pointer from these function

[PATCH 3/5] ISDN-Gigaset: Delete an error message for a failed memory allocation

From: Markus Elfring Date: Mon, 26 Sep 2016 15:35:47 +0200 Omit an extra message for a memory allocation failure in this function. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring

[PATCH 2/5] ISDN-Gigaset: Improve another size determination in gigaset_initcs()

From: Markus Elfring Date: Sun, 25 Sep 2016 22:32:14 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/5] ISDN-Gigaset: Use kmalloc_array() in two functions

From: Markus Elfring Date: Sun, 25 Sep 2016 22:22:04 +0200 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kmalloc_array". This issue was

[PATCH 0/5] ISDN-Gigaset: Fine-tuning for three function implementations

From: Markus Elfring Date: Mon, 26 Sep 2016 17:27:17 +0200 Some update suggestions were taken into account from static source code analysis. Markus Elfring (5): Use kmalloc_array() in two functions Improve another size determination in gigaset_initcs()

Re: [PATCH v2 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited

On Sun, Sep 25, 2016 at 6:59 PM, Maciej Żenczykowski wrote: > + ifp->idev->cnf.rtr_solicits != 0 && Given that some of this patch checks for == -1, and some of it checks for != 0... is it possible that setting the value to something unexpected like -3 will

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

Hi, On Mon, 26 Sep 2016 16:43:16 +0200 Hannes Frederic Sowa wrote: > On 26.09.2016 03:35, Florian Westphal wrote: > > > > Yes, but I think we get same issue when we deal with stacked > > interfaces, and redirect is to e.g. vlan on top of physical device. > > We

Re: [2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 20 Aug 2016 18:21:29 +0200 > > Remove a jump label which is unneeded in this function at the end. > > Signed-off-by: Markus Elfring 2

Re: [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

On Mon, Sep 26, 2016 at 07:18:25PM +0530, Raju Lakkaraju wrote: > Hi, > > Thank you for review the code and valuable comments. > Summary of changes: > V1: Initial version of Edge-rate driver add by using IOCTL. > V2: Changed edge-rate parameter to Device Tree with magic number. >

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

On 26.09.2016 16:53, Daniel Borkmann wrote: > On 09/26/2016 04:43 PM, Hannes Frederic Sowa wrote: >> On 26.09.2016 03:35, Florian Westphal wrote: >>> Jamal Hadi Salim wrote: On 16-09-25 02:31 PM, Florian Westphal wrote: > Shmulik Ladkani

RE: [PATCH v2] fs/select: add vmalloc fallback for select(2)

From: Vlastimil Babka > Sent: 26 September 2016 11:02 > On 09/23/2016 03:35 PM, David Laight wrote: > > From: Vlastimil Babka > >> Sent: 23 September 2016 10:59 > > ... > >> > I suspect that fdt->max_fds is an upper bound for the highest fd the > >> > process has open - not the RLIMIT_NOFILE

[PATCH net-next] bnx2x: free the mac filter group list before freeing the cmd

The group list must be freed prior to freeing the command otherwise we have a use-after-free. Signed-off-by: Jason Baron Cc: Yuval Mintz Cc: Ariel Elior --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 2 +- 1 file

Re: [PATCH] brcmfmac: implement more accurate skb tracking

On Mon, 2016-09-26 at 14:13 +0200, Rafał Miłecki wrote: > On 26 September 2016 at 13:46, Arend Van Spriel > wrote: > > > > On 26-9-2016 12:23, Rafał Miłecki wrote: > > > > > > From: Rafał Miłecki > > > > > > We need to track 802.1x packets to

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

On 09/26/2016 04:43 PM, Hannes Frederic Sowa wrote: On 26.09.2016 03:35, Florian Westphal wrote: Jamal Hadi Salim wrote: On 16-09-25 02:31 PM, Florian Westphal wrote: Shmulik Ladkani wrote: We can later address any loop-detection improvements

Re: [PATCH v3] bpf: Set register type according to is_valid_access()

On 09/24/2016 08:01 PM, Mickaël Salaün wrote: This prevent future potential pointer leaks when an unprivileged eBPF program will read a pointer value from its context. Even if is_valid_access() returns a pointer type, the eBPF verifier replace it with UNKNOWN_VALUE. The register value that

  1   2   3   >