Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

2016-10-10 Thread Linus Torvalds
On Mon, Oct 10, 2016 at 10:39 PM, Linus Torvalds wrote: > > I guess I will have to double-check that the slub corruption is gone > still with that fixed. So I'm not getting any warnings now from SLUB debugging. So the original bug seems to not have re-surfaced, and

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

2016-10-10 Thread Linus Torvalds
On Sun, Oct 9, 2016 at 8:41 PM, Linus Torvalds wrote: > This COMPLETELY UNTESTED patch tries to fix the nf_hook_entry code to do this. > > I repeat: it's ENTIRELY UNTESTED. Gaah. That patch was subtle garbage. The "add to list" thing did this:

Re: kernel v4.8: iptables logs are truncated with the 4.8 kernel?

2016-10-10 Thread Liping Zhang
2016-10-11 11:57 GMT+08:00 Chris Caputo : > I have tested the above patch with 4.8.1, with and without nflog-size > defined in an iptables configuration, and it works well. > > The ulogd-2.0.5 segfaults no longer happen when nflog-size is not present > in a target. > > I recommend

[PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

2016-10-10 Thread Tom Herbert
I am hitting this in mlx5: drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c: In function ‘reclaim_pages_cmd.clone.0’: drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c:346: error: call to ‘__compiletime_assert_346’ declared with attribute error: BUILD_BUG_ON failed:

Re: [PATCH kernel v2] PCI: Enable access to custom VPD for Chelsio devices (cxgb3)

2016-10-10 Thread Alexey Kardashevskiy
On 11/10/16 02:23, Alexander Duyck wrote: > On Wed, Sep 28, 2016 at 10:21 PM, Alexey Kardashevskiy wrote: >> There is at least one Chelsio 10Gb card which uses VPD area to store >> some custom blocks (example below). However pci_vpd_size() returns >> the length of the first block

Re: BUILD_BUG_ON error in mlx5/core/pagealloc.c

2016-10-10 Thread Tom Herbert
On Mon, Oct 10, 2016 at 8:17 PM, Saeed Mahameed wrote: > > > On Tuesday, October 11, 2016, Tom Herbert wrote: >> >> On Mon, Oct 10, 2016 at 4:41 PM, Tom Herbert wrote: >> > I am hitting this in mlx5 >> > >> >

Re: kernel v4.8: iptables logs are truncated with the 4.8 kernel?

2016-10-10 Thread Chris Caputo
On Tue, 11 Oct 2016, Liping Zhang wrote: > Yes, thanks for clarifying this. There's a bug in kernel, can you try > this patch: > > diff --git a/net/netfilter/xt_NFLOG.c b/net/netfilter/xt_NFLOG.c > index 018eed7..8c069b4 100644 > --- a/net/netfilter/xt_NFLOG.c > +++ b/net/netfilter/xt_NFLOG.c >

RFH: problems with adjacency graph

2016-10-10 Thread David Ahern
Jiri / Veaceslav: As author's of the adjacency tracking code in dev.c I am hoping you can help with suggested patches for a couple of problems. The start point needs to include commit 93409033ae65 which resolved a different problem from what I am seeing now. At the moment I have 2 cases both

Re: [PATCH net] net: add recursion limit to GRO

2016-10-10 Thread Hannes Frederic Sowa
Hi, On Mon, Oct 10, 2016, at 16:03, Eric Dumazet wrote: > On Mon, 2016-10-10 at 15:43 +0200, Sabrina Dubroca wrote: > > Currently, GRO can do unlimited recursion through the gro_receive > > handlers. This was fixed for tunneling protocols by limiting tunnel GRO > > to one level with encap_mark,

Re: kernel v4.8: iptables logs are truncated with the 4.8 kernel?

2016-10-10 Thread Liping Zhang
2016-10-11 2:33 GMT+08:00 Chris Caputo : >> >> What numbers did you specify after --nflog-size option? >> --nflog-size 0 or ...? If you want log the whole packet to >> the ulogd, please do not specify this nflog-size option. > > Not specifying nflog-size does not appear to log the

Re: slab corruption with current -git

2016-10-10 Thread Linus Torvalds
On Mon, Oct 10, 2016 at 5:30 PM, David Miller wrote: > > Linus can you add some extra info to that: Sure. I made it a WARN_ON_ONCE(), but then always just printed the pf/hooknum. It's all over the map: reg->pf=2 and reg->hooknum=4 reg->pf=2 and reg->hooknum=2 reg->pf=2

Re: slab corruption with current -git

2016-10-10 Thread David Miller
From: Linus Torvalds Date: Mon, 10 Oct 2016 12:05:17 -0700 > David - I think that also explains what was wrong with the old code. > In the old code, this loop: > > while (hooks_entry && nf_entry_dereference(hooks_entry->next)) { > > would exit with

[PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-10 Thread Lawrence Brakmo
The purpose of this patch is to help balance flows across paths. A new sysctl "tcp_retrans_txhash_prob" specifies the probability (0-100) that the txhash (IPv6 flowlabel) will be changed after a non-RTO retransmit. A probability is used in order to control how many flows are moved during a

Re: BUILD_BUG_ON error in mlx5/core/pagealloc.c

2016-10-10 Thread Tom Herbert
On Mon, Oct 10, 2016 at 4:41 PM, Tom Herbert wrote: > I am hitting this in mlx5 > > drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c: In function > ‘reclaim_pages_cmd.clone.0’: > drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c:346: error: call > to

BUILD_BUG_ON error in mlx5/core/pagealloc.c

2016-10-10 Thread Tom Herbert
I am hitting this in mlx5 drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c: In function ‘reclaim_pages_cmd.clone.0’: drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c:346: error: call to ‘__compiletime_assert_346’ declared with attribute error: BUILD_BUG_ON failed:

Re: [PATCH 10/10] net: mdio-sam: Add device tree documentation for SAM MDIO

2016-10-10 Thread Peter Rosin
On 2016-10-07 17:18, Pantelis Antoniou wrote: > From: Georgi Vlaev > > Add device tree bindings document for the SAM MDIO block > present in Juniper's SAM FPGA. > > Signed-off-by: Georgi Vlaev > [Ported from Juniper kernel] > Signed-off-by: Pantelis

RE: Accelerated receive flow steering (aRFS) for UDP

2016-10-10 Thread Chopra, Manish
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Monday, October 10, 2016 10:38 PM > To: Rick Jones > Cc: Chopra, Manish ; netdev@vger.kernel.org; > ma...@mellanox.com; t...@herbertland.com > Subject: Re:

Re: [PATCH net-next] sctp: remove the old ttl expires policy

2016-10-10 Thread Marcelo Ricardo Leitner
On Sat, Oct 08, 2016 at 11:40:16AM +0800, Xin Long wrote: > The prsctp polices include ttl expires policy already, we should remove > the old ttl expires codes, and just adjust the new polices' codes to be > compatible with the old one for users. > > This patch is to remove all the old expires

Re: [PATCH 2/4] mfd: ptxpmb-ext-cpld: Add documentation for PTXPMB extended CPLD

2016-10-10 Thread Rob Herring
On Fri, Oct 07, 2016 at 06:19:32PM +0300, Pantelis Antoniou wrote: > From: Georgi Vlaev > > Add DT bindings document for the PTXPMB extended CPLD device. > > Signed-off-by: Georgi Vlaev > [Ported from Juniper kernel] > Signed-off-by: Pantelis Antoniou

Re: [PATCH 4/4] gpio: ptxpmb-ext-cpld: Document bindings of PTXPMB extended CPLD

2016-10-10 Thread Rob Herring
On Fri, Oct 07, 2016 at 06:19:34PM +0300, Pantelis Antoniou wrote: > From: Georgi Vlaev > > Add device tree bindings document for the GPIO driver of > Juniper's PTXPMB extended CPLD. > > Signed-off-by: Georgi Vlaev > [Ported from Juniper kernel] >

Re: [PATCH 08/10] mtd: flash-sam: Bindings for Juniper's SAM FPGA flash

2016-10-10 Thread Rob Herring
gOn Fri, Oct 07, 2016 at 06:18:36PM +0300, Pantelis Antoniou wrote: > From: Georgi Vlaev > > Add binding document for Junipers Flash IP block present > in the SAM FPGA on PTX series of routers. > > Signed-off-by: Georgi Vlaev > [Ported from Juniper

Re: [PATCH net 1/3] openvswitch: vlan: remove wrong likely statement

2016-10-10 Thread Pravin Shelar
On Mon, Oct 10, 2016 at 8:02 AM, Jiri Benc wrote: > This code is called whenever flow key is being extracted from the packet. > The packet may be as likely vlan tagged as not. > > Fixes: 018c1dda5ff1 ("openvswitch: 802.1AD Flow handling, actions, vlan > parsing, netlink

Re: [PATCH net 2/3] openvswitch: fix vlan subtraction from packet length

2016-10-10 Thread Pravin Shelar
On Mon, Oct 10, 2016 at 8:02 AM, Jiri Benc wrote: > When the packet has its vlan tag in skb->vlan_tci, the length of the VLAN > header is not counted in skb->len. It doesn't make sense to subtract it. > > Fixes: 018c1dda5ff1 ("openvswitch: 802.1AD Flow handling, actions, vlan >

Re: [PATCH net 3/3] openvswitch: add NETIF_F_HW_VLAN_STAG_TX to internal dev

2016-10-10 Thread Pravin Shelar
On Mon, Oct 10, 2016 at 8:02 AM, Jiri Benc wrote: > The internal device does support 802.1AD offloading since 018c1dda5ff1 > ("openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink > attributes"). > > Signed-off-by: Jiri Benc Acked-by: Pravin B

Re: [PATCH 06/10] gpio: sam: Document bindings of SAM FPGA GPIO block

2016-10-10 Thread Rob Herring
On Fri, Oct 07, 2016 at 06:18:34PM +0300, Pantelis Antoniou wrote: > From: Georgi Vlaev > > Add device tree bindings document for the GPIO driver of > Juniper's SAM FPGA. > > Signed-off-by: Georgi Vlaev > [Ported from Juniper kernel] > Signed-off-by:

Re: [PATCH net-next] sctp: reuse sent_count to avoid retransmitted chunks for RTT measurements

2016-10-10 Thread Marcelo Ricardo Leitner
On Mon, Oct 10, 2016 at 02:48:25PM -0300, Marcelo Ricardo Leitner wrote: > On Sat, Oct 08, 2016 at 11:36:05AM +0800, Xin Long wrote: > > Now sctp uses chunk->resent to record if a chunk is retransmitted, for > > RTT measurements with retransmitted DATA chunks. chunk->sent_count was > > introduced

Re: [PATCH 04/10] i2c: i2c-sam: Add device tree bindings

2016-10-10 Thread Rob Herring
On Fri, Oct 07, 2016 at 06:18:32PM +0300, Pantelis Antoniou wrote: > From: Georgi Vlaev > > Add binding document for the i2c driver of SAM FPGA. > > Signed-off-by: Georgi Vlaev > [Ported from Juniper kernel] > Signed-off-by: Pantelis Antoniou

Re: [PATCH 02/10] mfd: sam: Add documentation for the SAM FPGA

2016-10-10 Thread Rob Herring
On Fri, Oct 07, 2016 at 06:18:30PM +0300, Pantelis Antoniou wrote: > From: Georgi Vlaev > > Add DT bindings document for the SAM MFD device. > > Signed-off-by: Georgi Vlaev > [Ported from Juniper kernel] > Signed-off-by: Pantelis Antoniou

Re: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

2016-10-10 Thread Julia Cartwright
Hello Mathias- On Fri, Oct 07, 2016 at 08:58:08AM +, Koehrer Mathias (ETAS/ESW5) wrote: [..] > I modified the in-kernel's igb_main.c (function igb_watchdog_task) to comment > out > the access to the EICS registers: > > --- igb_main.c.orig 2016-10-07 10:43:37.855873754 +0200 > +++

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

2016-10-10 Thread Aaron Conole
Linus Torvalds writes: > On Mon, Oct 10, 2016 at 9:28 AM, Linus Torvalds > wrote: >> >> So as I already answered to Dave, I'm not actually sure that this was >> the buggy code, or that my patch would make any difference at all. > >

[PATCH net] qmi_wwan: add support for Quectel EC21 and EC25

2016-10-10 Thread Bjørn Mork
The Quectel EC21 and EC25 need the same "set DTR" request as devices based on the MDM9230 chipset, but has no USB3 support. Our best guess is that the "set DTR" functionality depends on chipset and/or baseband firmware generation. But USB3 is still an optional feature. Since we cannot enable this

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

2016-10-10 Thread Linus Torvalds
On Mon, Oct 10, 2016 at 9:28 AM, Linus Torvalds wrote: > > So as I already answered to Dave, I'm not actually sure that this was > the buggy code, or that my patch would make any difference at all. My patch does seem to fix things, and in fact the warning about

Redundancy support through PRP?

2016-10-10 Thread Murali Karicheri
All, Wondering if there plan to add PRP driver support, like HSR in Linux? AFAIK, PRP adds trailor to Ethernet frame and is used for Redundancy management like HSR. So wondering why this is not supported. Thanks -- Murali Karicheri Linux Kernel, Keystone

Re: kernel v4.8: iptables logs are truncated with the 4.8 kernel?

2016-10-10 Thread Chris Caputo
On Mon, 10 Oct 2016, Liping Zhang wrote: > 2016-10-10 15:02 GMT+08:00 Chris Caputo : > > Program received signal SIGSEGV, Segmentation fault. > > 0x765fd18a in _interp_iphdr (pi=0x617f50, len=0) at > > ulogd_raw2packet_BASE.c:720 > > > > 715 static int

HSR status queries from user space

2016-10-10 Thread Murali Karicheri
Hi Arvid, I am investigating the HSR implementation in Linux and wondering if there is a tool that I can use to query the status of the HSR nodes. Especially data related to HSR_C_GET_NODE_STATUS and HSR_C_GET_NODE_LIST commands. I am able to setup hsr interface using two Ethernet slave

Re: [PATCH net-next] sctp: reuse sent_count to avoid retransmitted chunks for RTT measurements

2016-10-10 Thread Marcelo Ricardo Leitner
On Sat, Oct 08, 2016 at 11:36:05AM +0800, Xin Long wrote: > Now sctp uses chunk->resent to record if a chunk is retransmitted, for > RTT measurements with retransmitted DATA chunks. chunk->sent_count was > introduced to record how many times one chunk has been sent for prsctp > RTX policy before.

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-10 Thread Alexander Duyck
On Mon, Oct 10, 2016 at 10:00 AM, Nikita Yushchenko wrote: > Hi Alexander > > Thanks for your explanation. > >> The main reason why this isn't a concern for the igb driver is because >> we currently pass the page up as read-only. We don't allow the stack >> to

[RFC] net: phy: smsc: Disable auto-negotiation on startup

2016-10-10 Thread Kyle Roeschley
Because the SMSC PHY completes auto-negotiation before the driver is ready to handle interrupts, the PHY state machine never realizes that we have a link. Clear the ANENABLE bit on initialization, which lets genphy_config_aneg do its thing when that code is hit later. While this patch does fix

[PATCH v6 2/4] mac80211: filter multicast data packets on AP / AP_VLAN

2016-10-10 Thread Michael Braun
This patch adds filtering for multicast data packets on AP_VLAN interfaces that have no authorized station connected and changes filtering on AP interfaces to not count stations assigned to AP_VLAN interfaces. This saves airtime and avoids waking up other stations currently authorized in this

[PATCH v6 4/4] mac80211: multicast to unicast conversion

2016-10-10 Thread Michael Braun
This patch adds support for sending multicast data packets with ARP, IPv4 and IPv6 payload (possible 802.1q tagged) as 802.11 unicast frames to all stations. IEEE 802.11 multicast has well known issues, among them: 1. packets are not acked and hence not retransmitted, resulting in decreased

[PATCH v6 3/4] cfg80211: configure multicast to unicast for AP interfaces

2016-10-10 Thread Michael Braun
This add a userspace toggle to configure multicast to unicast. Signed-off-by: Michael Braun -- v6: - clarify documentation - fix policy for NL80211_ATTR_MULTICAST_TO_UNICAST_ENABLED --- include/net/cfg80211.h | 6 ++ include/uapi/linux/nl80211.h | 18

[PATCH v6 1/4] mac80211: remove unnecessary num_mcast_sta user

2016-10-10 Thread Michael Braun
Checking for num_mcast_sta in __ieee80211_request_smps_ap() is unnecessary, as sta list will be empty in this case anyway, so list_for_each_entry(sta, ...) will exit immediately. Signed-off-by: Michael Braun --- net/mac80211/cfg.c | 7 --- 1 file changed, 7

Re: Accelerated receive flow steering (aRFS) for UDP

2016-10-10 Thread Eric Dumazet
On Mon, 2016-10-10 at 09:23 -0700, Rick Jones wrote: > On 10/10/2016 09:08 AM, Rick Jones wrote: > > On 10/09/2016 03:33 PM, Eric Dumazet wrote: > >> OK, I am adding/CC Rick Jones, netperf author, since it seems a netperf > >> bug, not a kernel one. > >> > >> I believe I already mentioned fact

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-10 Thread Nikita Yushchenko
Hi Alexander Thanks for your explanation. > The main reason why this isn't a concern for the igb driver is because > we currently pass the page up as read-only. We don't allow the stack > to write into the page by keeping the page count greater than 1 which > means that the page is shared. It

[PATCH iproute2 1/1] tc filters: add support to get individual filters by handle

2016-10-10 Thread Jamal Hadi Salim
From: Jamal Hadi Salim sudo $TC filter add dev $ETH parent : prio 2 protocol ip \ u32 match u32 0 0 flowid 1:1 \ action ok sudo $TC filter add dev $ETH parent : prio 1 protocol ip \ u32 match ip protocol 1 0xff flowid 1:10 \ action ok now dump to see all rules.. $TC

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

2016-10-10 Thread Linus Torvalds
On Mon, Oct 10, 2016 at 6:49 AM, Aaron Conole wrote: > > Okay, I'm looking it over. Sorry for the mess. So as I already answered to Dave, I'm not actually sure that this was the buggy code, or that my patch would make any difference at all. I never got a good reproducer for

Re: Accelerated receive flow steering (aRFS) for UDP

2016-10-10 Thread Rick Jones
On 10/10/2016 09:08 AM, Rick Jones wrote: On 10/09/2016 03:33 PM, Eric Dumazet wrote: OK, I am adding/CC Rick Jones, netperf author, since it seems a netperf bug, not a kernel one. I believe I already mentioned fact that "UDP_STREAM -- -N" was not doing a connect() on the receiver side. I

Re: [PATCH net] net: add recursion limit to GRO

2016-10-10 Thread Sabrina Dubroca
Hi Eric, 2016-10-10, 07:03:56 -0700, Eric Dumazet wrote: > On Mon, 2016-10-10 at 15:43 +0200, Sabrina Dubroca wrote: > > Currently, GRO can do unlimited recursion through the gro_receive > > handlers. This was fixed for tunneling protocols by limiting tunnel GRO > > to one level with encap_mark,

Re: slab corruption with current -git

2016-10-10 Thread Linus Torvalds
On Mon, Oct 10, 2016 at 1:24 AM, David Miller wrote: > > So I've been reviewing this patch and it looks fine, but I also want > to figure out what is actually causing the OOPS and I can't spot it > yet. Yeah, I'm not actually sure the old linked list implementation is buggy

Re: Accelerated receive flow steering (aRFS) for UDP

2016-10-10 Thread Rick Jones
On 10/09/2016 03:33 PM, Eric Dumazet wrote: OK, I am adding/CC Rick Jones, netperf author, since it seems a netperf bug, not a kernel one. I believe I already mentioned fact that "UDP_STREAM -- -N" was not doing a connect() on the receiver side. I can confirm that the receive side of the

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-10 Thread Sergey Senozhatsky
return -EINVAL; > } > > to ieee80211_aes_ccm_decrypt() given the following backtrace > > WARNING: CPU: 5 PID: 252 at net/mac80211/aes_ccm.c:77 > ieee80211_aes_ccm_decrypt+0xc8/0x197 > CPU: 5 PID: 252 Comm: irq/29-iwlwifi Tainted: GW > 4.8.0-next-20161010-dbg-7-g79797e9-di

Re: [PATCH net 2/2] conntrack: enable to tune gc parameters

2016-10-10 Thread Nicolas Dichtel
Le 10/10/2016 à 16:04, Florian Westphal a écrit : > Nicolas Dichtel wrote: >> After commit b87a2f9199ea ("netfilter: conntrack: add gc worker to remove >> timed-out entries"), netlink conntrack deletion events may be sent with a >> huge delay. It could be interesting to

Re: [PATCH kernel v2] PCI: Enable access to custom VPD for Chelsio devices (cxgb3)

2016-10-10 Thread Alexander Duyck
On Wed, Sep 28, 2016 at 10:21 PM, Alexey Kardashevskiy wrote: > There is at least one Chelsio 10Gb card which uses VPD area to store > some custom blocks (example below). However pci_vpd_size() returns > the length of the first block only assuming that there can be only > one VPD

Re: [PATCH v4 03/10] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-10-10 Thread Rob Herring
On Mon, Oct 10, 2016 at 02:30:23PM +0200, Maxime Ripard wrote: > On Fri, Oct 07, 2016 at 10:25:50AM +0200, Corentin Labbe wrote: > > This patch adds documentation for Device-Tree bindings for the > > Allwinner sun8i-emac driver. > > > > Signed-off-by: Corentin Labbe >

Re: [PATCH v4 03/10] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-10-10 Thread Rob Herring
On Fri, Oct 07, 2016 at 10:25:50AM +0200, Corentin Labbe wrote: > This patch adds documentation for Device-Tree bindings for the > Allwinner sun8i-emac driver. > > Signed-off-by: Corentin Labbe > --- > .../bindings/net/allwinner,sun8i-emac.txt | 70 >

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-10 Thread Alexander Duyck
On Mon, Oct 10, 2016 at 5:27 AM, Nikita Yushchenko wrote: >>> Hmm... I'm not about device writing to memory. >> >> This absolutely is about whether the device wrote into the >> area or not. > > Not only. > >>> Sequence in igb driver is: >>> >>> dma_map(full_page)

[mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-10 Thread Sergey Senozhatsky
+0xc8/0x197 CPU: 5 PID: 252 Comm: irq/29-iwlwifi Tainted: GW 4.8.0-next-20161010-dbg-7-g79797e9-dirty #88 c9413638 811ff0e3 c9413678 8103fe91 004d01c8 192826d3 88040fc526d8 0008

[PATCH net 2/3] openvswitch: fix vlan subtraction from packet length

2016-10-10 Thread Jiri Benc
When the packet has its vlan tag in skb->vlan_tci, the length of the VLAN header is not counted in skb->len. It doesn't make sense to subtract it. Fixes: 018c1dda5ff1 ("openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes") Signed-off-by: Jiri Benc ---

[PATCH net 3/3] openvswitch: add NETIF_F_HW_VLAN_STAG_TX to internal dev

2016-10-10 Thread Jiri Benc
The internal device does support 802.1AD offloading since 018c1dda5ff1 ("openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes"). Signed-off-by: Jiri Benc --- net/openvswitch/vport-internal_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH net 1/3] openvswitch: vlan: remove wrong likely statement

2016-10-10 Thread Jiri Benc
This code is called whenever flow key is being extracted from the packet. The packet may be as likely vlan tagged as not. Fixes: 018c1dda5ff1 ("openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes") Signed-off-by: Jiri Benc --- net/openvswitch/flow.c

[PATCH net 0/3] openvswitch: vlan fixes

2016-10-10 Thread Jiri Benc
Fix three issues introduced by the 802.1AD patchset. Jiri Benc (3): openvswitch: vlan: remove wrong likely statement openvswitch: fix vlan subtraction from packet length openvswitch: add NETIF_F_HW_VLAN_STAG_TX to internal dev net/openvswitch/flow.c | 2 +-

[PATCH net-next v10 0/1] net: phy: Cleanup the Edge-Rate feature in Microsemi PHYs.

2016-10-10 Thread Allan W. Nielsen
Hi All, Yet another iteration on the edge rate. Included in this iteration: - vdd and slowdown is removed from private structure - rate_magic added to private structure - devicetree settings is read and validated in probe instead of init - unused reference in device-tree doc removed Please

[PATCH net-next v10 1/1] net: phy: Cleanup the Edge-Rate feature in Microsemi PHYs.

2016-10-10 Thread Allan W. Nielsen
Edge-Rate cleanup include the following: - Updated device tree bindings documentation for edge-rate - The edge-rate is now specified as a "slowdown", meaning that it is now being specified as positive values instead of negative (both documentation and implementation wise). - Only explicitly

[PATCH v2] qed: Fix to use list_for_each_entry_safe() when delete items

2016-10-10 Thread Wei Yongjun
From: Wei Yongjun Since we will remove items off the list using list_del() we need to use a safe version of the list_for_each_entry() macro aptly named list_for_each_entry_safe(). Signed-off-by: Wei Yongjun Acked-by: Yuval Mintz

Re: [PATCH net 2/2] conntrack: enable to tune gc parameters

2016-10-10 Thread Florian Westphal
Nicolas Dichtel wrote: > After commit b87a2f9199ea ("netfilter: conntrack: add gc worker to remove > timed-out entries"), netlink conntrack deletion events may be sent with a > huge delay. It could be interesting to let the user tweak gc parameters > depending on its

Re: [PATCH net] net: add recursion limit to GRO

2016-10-10 Thread Eric Dumazet
On Mon, 2016-10-10 at 15:43 +0200, Sabrina Dubroca wrote: > Currently, GRO can do unlimited recursion through the gro_receive > handlers. This was fixed for tunneling protocols by limiting tunnel GRO > to one level with encap_mark, but both VLAN and TEB still have this > problem. Thus, the

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-10 Thread Luca Coelho
Hi, On Mon, 2016-10-10 at 02:19 -0500, Chris Rorvick wrote: > Commit bcb079a14d75 ("iwlwifi: pcie: retrieve and parse ACPI power > limitations") looks for a specific structure in the ACPI tables for > setting the default power limit. The data returned for at least some > dual band chipsets is not

Re: [PATCH net 1/2] conntrack: remove obsolete sysctl (nf_conntrack_events_retry_timeout)

2016-10-10 Thread Florian Westphal
Nicolas Dichtel wrote: > This entry has been removed in commit 9500507c6138. > > Fixes: 9500507c6138 ("netfilter: conntrack: remove timer from ecache > extension") > Signed-off-by: Nicolas Dichtel Acked-by: Florian Westphal

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

2016-10-10 Thread Aaron Conole
Linus Torvalds writes: > On Sun, Oct 9, 2016 at 7:49 PM, Linus Torvalds > wrote: >> >> There is one *correct* way to remove an entry from a singly linked >> list, and it looks like this: >> >> struct entry **pp, *p; >> >> pp

Re: [PATCH] doc: fix wrongly referencing dev->skb_mark

2016-10-10 Thread Ido Schimmel
Hi, On Mon, Oct 10, 2016 at 08:15:39PM +0900, Ryota Ozaki wrote: > Section "Flooding L2 domain" says, to avoid duplicated flooding, if > skb->offload_fwd_mark is matched with dev->skb_mark, the kernel will > drop the packet. However, the relevant code in __dev_queue_xmit > compares

[PATCH net] net: add recursion limit to GRO

2016-10-10 Thread Sabrina Dubroca
Currently, GRO can do unlimited recursion through the gro_receive handlers. This was fixed for tunneling protocols by limiting tunnel GRO to one level with encap_mark, but both VLAN and TEB still have this problem. Thus, the kernel is vulnerable to a stack overflow, if we receive a packet

Re: [PATCH v3 1/4] net: phy: dp83867: Add documentation for optional impedance control

2016-10-10 Thread Rob Herring
On Thu, Oct 06, 2016 at 10:43:52AM +0530, Mugunthan V N wrote: > Add documention of ti,impedance-control which can be used to Needs updating. > correct MAC impedance mismatch using phy extended registers. > > Signed-off-by: Mugunthan V N > --- >

Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result

2016-10-10 Thread Jamal Hadi Salim
On 16-10-09 11:25 PM, Eric Dumazet wrote: From: Eric Dumazet There are two ways to get tc filters from kernel to user space. 1) Full dump (tc_dump_tfilter()) 2) RTM_GETTFILTER to get one precise filter, reducing overhead. The second operation is unfortunately

Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig

2016-10-10 Thread Jean-Francois Moine
On Mon, 10 Oct 2016 14:35:11 +0200 LABBE Corentin wrote: > On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard wrote: > > On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > > > Enable the sun8i-emac driver in the multi_v7 default configuration > > >

Re: [PATCH v8 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-10 Thread Rob Herring
On Wed, Oct 05, 2016 at 05:09:38PM +0530, Raju Lakkaraju wrote: > From: Raju Lakkaraju > > Edge-rate: > As system and networking speeds increase, a signal's output transition, > also know as the edge rate or slew rate (V/ns), takes on greater importance > because

Re: [PATCH v4 04/10] ARM: dts: sun8i-h3: Add dt node for the syscon control module

2016-10-10 Thread Jean-Francois Moine
On Mon, 10 Oct 2016 14:31:51 +0200 Maxime Ripard wrote: > Hi, > > On Fri, Oct 07, 2016 at 10:25:51AM +0200, Corentin Labbe wrote: > > This patch add the dt node for the syscon register present on the > > Allwinner H3. > > > > Only two register are present in

Re: [PATCH net-next v3 0/6] openvswitch: make vlan handling consistent

2016-10-10 Thread Jiri Benc
On Fri, 7 Oct 2016 12:59:08 -0700, Pravin Shelar wrote: > On Fri, Oct 7, 2016 at 9:07 AM, Jiri Benc wrote: > > Always keep the first vlan tag "accelerated", i.e. in skb->vlan_tci. > > > > Unfortunately, with all the changes since v2, this patchset no longer has > > the nice

[PATCH] tlan: avoid unused label with PCI=n

2016-10-10 Thread Arnd Bergmann
While build testing with randconfig on x86, I ran into this warning that appears to have been around forever drivers/net/ethernet/ti/tlan.c: In function ‘tlan_probe1’: drivers/net/ethernet/ti/tlan.c:614:1: error: label ‘err_out’ defined but not used [-Werror=unused-label] This can be trivially

Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig

2016-10-10 Thread LABBE Corentin
On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard wrote: > On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > > Enable the sun8i-emac driver in the multi_v7 default configuration > > > > Signed-off-by: Corentin Labbe > > --- > >

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-10 Thread Nikita Yushchenko
>> All the data has been synced > > Non-synced data is write done by CPU executing upper layers of network stack, Upper layers shall never get area that is still dma_map()ed and will be dma_unmap()ed in future. But with igb, this is exactly what happens.

Re: [PATCH v4 04/10] ARM: dts: sun8i-h3: Add dt node for the syscon control module

2016-10-10 Thread Maxime Ripard
Hi, On Fri, Oct 07, 2016 at 10:25:51AM +0200, Corentin Labbe wrote: > This patch add the dt node for the syscon register present on the > Allwinner H3. > > Only two register are present in this syscon and the only one useful is > the one dedicated to EMAC clock. > > Signed-off-by: Corentin

Re: [PATCH v4 03/10] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-10-10 Thread Maxime Ripard
On Fri, Oct 07, 2016 at 10:25:50AM +0200, Corentin Labbe wrote: > This patch adds documentation for Device-Tree bindings for the > Allwinner sun8i-emac driver. > > Signed-off-by: Corentin Labbe > --- > .../bindings/net/allwinner,sun8i-emac.txt | 70 >

Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig

2016-10-10 Thread Maxime Ripard
On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > Enable the sun8i-emac driver in the multi_v7 default configuration > > Signed-off-by: Corentin Labbe > --- > arch/arm/configs/multi_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-10 Thread Nikita Yushchenko
>> Hmm... I'm not about device writing to memory. > > This absolutely is about whether the device wrote into the > area or not. Not only. >> Sequence in igb driver is: >> >> dma_map(full_page) >> >> sync_to_cpu(half_page); >> skb_add_rx_frag(skb, half_page); >> napi_gro_receive(skb); >>

Re: kernel v4.8: iptables logs are truncated with the 4.8 kernel?

2016-10-10 Thread Liping Zhang
Hi Chris, 2016-10-10 15:02 GMT+08:00 Chris Caputo : > On Tue, 4 Oct 2016, Justin Piszcz wrote: >> kernel 4.8 with ulogd-2.0.5- IPs are no longer logged: >> >> Oct 4 17:51:30 atom INPUT_BLOCK IN=eth1 OUT= >> MAC=00:1b:21:9c:3b:fa:3e:94:d5:d2:49:1e:08:00 LEN=0 TOS=00 PREC=0x00 >>

[PATCH] qed: fix old-style function definition

2016-10-10 Thread Arnd Bergmann
The definition of qed_get_rdma_ops() is not a prototype unless we add 'void' here, as indicated by this W=1 warning: drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’: drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style function definition

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-10 Thread David Miller
From: Nikita Yushchenko Date: Mon, 10 Oct 2016 12:51:28 +0300 > Hmm... I'm not about device writing to memory. This absolutely is about whether the device wrote into the area or not. > Sequence in igb driver is: > > dma_map(full_page) > >

Re: tg3 BUG: spinlock lockup suspected

2016-10-10 Thread Siva Reddy Kallam
On Sun, Oct 9, 2016 at 12:35 AM, Meelis Roos wrote: >> > That did not go well - bisect found the following commit but that does >> > not seem to be related at all. So probably the reproducibility is not >> > 100% but more random. >> >> Now I reproduced the bug even with 4.7-rc1 so

[PATCH] doc: fix wrongly referencing dev->skb_mark

2016-10-10 Thread Ryota Ozaki
Section "Flooding L2 domain" says, to avoid duplicated flooding, if skb->offload_fwd_mark is matched with dev->skb_mark, the kernel will drop the packet. However, the relevant code in __dev_queue_xmit compares skb->offload_fwd_mark with dev->offload_fwd_mark, not dev->skb_mark. I guess the text is

Re: [PATCH v5 3/4] cfg80211: configure multicast to unicast for AP interfaces

2016-10-10 Thread Johannes Berg
>   * > + * @NL80211_ATTR_MULTICAST_TO_UNICAST_ENABLED: Multicast packets > should be > + *  send out as unicast to all stations. You should document what type of attribute is expected. You probably wanted a flag attribute, but ... > + [NL80211_ATTR_MULTICAST_TO_UNICAST_ENABLED] = {

[PATCH net 0/2] conntrack update

2016-10-10 Thread Nicolas Dichtel
The first patch is a small documentation fix. The second patch adds more flexibility to configure the conntrack gc. I target it specifically to net and not net-next because the removal of the conntrack timer has just land into net. Documentation/networking/nf_conntrack-sysctl.txt | 35

[PATCH net 1/2] conntrack: remove obsolete sysctl (nf_conntrack_events_retry_timeout)

2016-10-10 Thread Nicolas Dichtel
This entry has been removed in commit 9500507c6138. Fixes: 9500507c6138 ("netfilter: conntrack: remove timer from ecache extension") Signed-off-by: Nicolas Dichtel --- Documentation/networking/nf_conntrack-sysctl.txt | 18 -- 1 file changed, 18

[PATCH net 2/2] conntrack: enable to tune gc parameters

2016-10-10 Thread Nicolas Dichtel
After commit b87a2f9199ea ("netfilter: conntrack: add gc worker to remove timed-out entries"), netlink conntrack deletion events may be sent with a huge delay. It could be interesting to let the user tweak gc parameters depending on its use case. CC: Florian Westphal

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-10 Thread Nikita Yushchenko
>> With this scheme, page used for Rx is completely dma_map()ed at >> allocation time, split into two buffers, and individual buffer is >> sync_to_cpu()ed AND PASSED TO NETWORK STACK via skb_add_rx_frag() - >> while driver driver still uses other buffer. Later, when driver decides >> to no longer

Re: [PATCH net] xen-netback: (re-)create a debugfs node for hash information

2016-10-10 Thread Wei Liu
On Mon, Oct 10, 2016 at 09:30:53AM +0100, Paul Durrant wrote: > From: Paul Durrant > > It is useful to be able to see the hash configuration when running tests. > This patch adds a debugfs node for that purpose. > > The original version of this patch (commit

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-10 Thread David Miller
From: Nikita Yushchenko Date: Mon, 10 Oct 2016 11:52:06 +0300 > With this scheme, page used for Rx is completely dma_map()ed at > allocation time, split into two buffers, and individual buffer is > sync_to_cpu()ed AND PASSED TO NETWORK STACK via skb_add_rx_frag()

Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

2016-10-10 Thread Florian Fainelli
On 10/07/2016 02:14 PM, Zach Brown wrote: > From: Josh Cartwright > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will > create a set of led triggers for each instantiated PHY device. There is > one LED trigger per link-speed, per-phy. > > This allows for

igb driver can cause cache invalidation of non-owned memory?

2016-10-10 Thread Nikita Yushchenko
Hi DMA mapping scheme introduced in commit cbc8e55f6fda ('igb: Map entire page and sync half instead of mapping and unmapping half pages') back in 2012, and used up to now, can probably cause breakage of unrelated code on archs with non-coherent caches. With this scheme, page used for Rx is

[PATCH net] xen-netback: (re-)create a debugfs node for hash information

2016-10-10 Thread Paul Durrant
From: Paul Durrant It is useful to be able to see the hash configuration when running tests. This patch adds a debugfs node for that purpose. The original version of this patch (commit c0c64c152389) was reverted due to build failures caused by a conflict with commit

Re: [PATCH 10/10] net: mdio-sam: Add device tree documentation for SAM MDIO

2016-10-10 Thread Florian Fainelli
On 10/07/2016 08:18 AM, Pantelis Antoniou wrote: > From: Georgi Vlaev > > Add device tree bindings document for the SAM MDIO block > present in Juniper's SAM FPGA. > > Signed-off-by: Georgi Vlaev > [Ported from Juniper kernel] > Signed-off-by: Pantelis

  1   2   >