Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

Sorry, the warning is still there. I'm not sure adding sched_annotate_sleep() does anything, since it's defined as (in case CONFIG_DEBUG_ATOMIC_SLEEP is not set): # define sched_annotate_sleep() do { } while (0) On Sat, Oct 29, 2016 at 8:05 PM, Eric Dumazet wrote: > On

Re: [PATCH net-next] firewire: net: really fix maximum possible MTU

From: Stefan Richter Date: Sat, 29 Oct 2016 22:16:58 +0200 > The maximum unicast datagram size /without/ link fragmentation is > 4096 - 4 = 4092 (max IEEE 1394 async payload size at >= S800 bus speed, > minus unfragmented encapssulation header). Max broadcast datagram

Fw: [GIT] Networking

Sorry, forgot to CC: the lists on this one, doh! --- Begin Message --- Lots of fixes, mostly drivers as is usually the case. 1) Don't treat zero DMA address as invalid in vmxnet3, from Alexey Khoroshilov. 2) Fix element timeouts in netfilter's nft_dynset, from Anders K. Pedersen. 3)

[net:master 113/114] drivers/net/vxlan.c:947:21: warning: unused variable 'sock6'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: fceb9c3e38252992bbf1a3028cc2f7b871211533 commit: c6fcc4fc5f8b592600c7409e769ab68da0fb1eca [113/114] vxlan: avoid using stale vxlan socket. config: i386-randconfig-x012-201644 (attached as .config) compiler: gcc-6

Re: [PATCH net-next] genetlink: Fix generic netlink family unregister

From: Pravin B Shelar Date: Fri, 28 Oct 2016 16:01:41 -0700 > This patch fixes a typo in unregister operation. > > Following crash is fixed by this patch. It can be easily reproduced > by repeating modprobe and rmmod module that uses genetlink. ... > Fixes: 2ae0f17df1c

Re: [PATCH v2 net 2/2] geneve: avoid using stale geneve socket.

From: Pravin B Shelar Date: Fri, 28 Oct 2016 09:59:16 -0700 > This patch is similar to earlier vxlan patch. > Geneve device close operation frees geneve socket. This > operation can race with geneve-xmit function which > dereferences geneve socket. Following patch uses RCU >

Re: [PATCH v2 net 1/2] vxlan: avoid using stale vxlan socket.

From: Pravin B Shelar Date: Fri, 28 Oct 2016 09:59:15 -0700 > When vxlan device is closed vxlan socket is freed. This > operation can race with vxlan-xmit function which > dereferences vxlan socket. Following patch uses RCU > mechanism to avoid this situation. > >

Re: [PATCH net] qede: Fix out-of-bound fastpath memory access

From: Yuval Mintz Date: Sat, 29 Oct 2016 17:04:35 +0300 > Driver allocates a shadow array for transmitted SKBs with X entries; > That means valid indices are {0,...,X - 1}. [X == 8191] > Problem is the driver also uses X as a mask for a > producer/consumer in order to

Re: [PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type

On Fri, Oct 28, 2016 at 5:08 AM, Eric Dumazet wrote: > On Thu, 2016-10-27 at 12:54 -0500, Thomas Falcon wrote: >> On 10/27/2016 10:26 AM, Eric Dumazet wrote: >> > On Wed, 2016-10-26 at 11:09 +1100, Jon Maxwell wrote: >> >> We recently encountered a bug where a few

Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

On Thu, Oct 27, 2016 at 06:07:02PM -0700, Alexei Starovoitov wrote: > On Thu, Oct 27, 2016 at 05:52:04PM +0300, Tariq Toukan wrote: > > Separately manage the two types of TX rings: regular ones, and XDP. > > Upon an XDP set, do not borrow regular TX rings and convert them > > into XDP ones, but

Re: [PATCH net-next 1/1] net: phy: Add support for Microsemi VSC 8530/40 Fast Ethernet PHY

From: "Allan W. Nielsen" Date: Fri, 28 Oct 2016 12:10:11 +0200 > From: Raju Lakkaraju > > Signed-off-by: Raju Lakkaraju > Signed-off-by: Allan W. Nielsen Applied.

Re: pull-request: mac80211-next 2016-10-28

From: Johannes Berg Date: Fri, 28 Oct 2016 09:06:13 +0200 > First update for 4.10 - nothing major, new features as usual (FILS), and > sometimes we deprecate old stuff (WDS). > > I don't have the fixes for the on-stack crypto/SG handling in this tree > (you already

Re: [PATCH] net: phy: dp83848: add dp83822 PHY support

From: Roger Quadros Date: Fri, 28 Oct 2016 12:40:20 +0300 > This PHY has a compatible register set with DP83848x so > add support for it. > > Acked-by: Andrew F. Davis > Signed-off-by: Roger Quadros Applied.

Re: [PATCH net] enic: fix rq disable

From: Govindarajulu Varadarajan Date: Thu, 27 Oct 2016 16:01:03 -0700 > When MTU is changed from 9000 to 1500 while there is burst of inbound 9000 > bytes packets, adaptor sometimes delivers 9000 bytes packets to 1500 bytes > buffers. This causes memory corruption and

Re: [PATCH net 1/1] tipc: fix broadcast link synchronization problem

From: Jon Maloy Date: Thu, 27 Oct 2016 18:51:55 -0400 > In commit 2d18ac4ba745 ("tipc: extend broadcast link initialization > criteria") we tried to fix a problem with the initial synchronization > of broadcast link acknowledge values. Unfortunately that solution is > not

Re: [PATCH net v2 1/2] ibmvnic: Fix releasing of sub-CRQ IRQs in interrupt context

From: Thomas Falcon Date: Thu, 27 Oct 2016 12:28:51 -0500 > Schedule these XPORT event tasks in the shared workqueue > so that IRQs are not freed in an interrupt context when > sub-CRQs are released. > > Signed-off-by: Thomas Falcon >

Re: [PATCH net v1 2/2] ibmvnic: Fix missing brackets in init_sub_crq_irqs

From: Thomas Falcon Date: Thu, 27 Oct 2016 12:28:52 -0500 > Signed-off-by: Thomas Falcon > --- > v1: caught by kbuild bot with -Wmisleading-indentation after > after submitting previous patch Applied.

Re: [patch net-next v2] rocker: set physical device for port netdevice

From: Jiri Pirko Date: Thu, 27 Oct 2016 22:32:22 +0200 > From: Jiri Pirko > > Do this so the sysfs has "device" link correctly set. > > Signed-off-by: Jiri Pirko > --- > v1->v2: > - make pdev non-const as pointerd out by kbuild test

Re: [net 0/4][pull request] Intel Wired LAN Driver Updates 2016-10-27

From: Jeff Kirsher Date: Thu, 27 Oct 2016 14:27:53 -0700 > This series contains fixes to ixgbe and i40e. Pulled, thanks Jeff.

Re: [PATCH net-next] tcp_bbr: add a state transition diagram and accompanying comment

From: Neal Cardwell Date: Thu, 27 Oct 2016 13:26:37 -0400 > Document the possible state transitions for a BBR flow, and also add a > prose summary of the state machine, covering the life of a typical BBR > flow. > > Signed-off-by: Neal Cardwell >

Re: [PATCH net-next v1 04/16] tipc: rename struct tipc_skb_cb member handle to bytes_read

From: Parthasarathy Bhuvaragan Date: Thu, 27 Oct 2016 16:22:25 +0200 > @@ -95,7 +95,7 @@ struct plist; > #define TIPC_MEDIA_INFO_OFFSET 5 > > struct tipc_skb_cb { > - void *handle; > + u32 bytes_read; > struct sk_buff *tail; >

Re: [PATCH v7 0/6] Add eBPF hooks for cgroups

On 10/29/2016 05:34 PM, Lorenzo Colitti wrote: On Sat, Oct 29, 2016 at 3:24 PM, Alexei Starovoitov wrote: it could be solved by swapping the order of cgroup_bpf_run_filter() and NF_INET_POST_ROUTING in patch 5. It was proposed some time back, but the current

Re: [PATCH 00/17] pull request for net-next: batman-adv 2016-10-27

From: Simon Wunderlich Date: Thu, 27 Oct 2016 21:01:33 +0200 > this is our first feature pull request for batman-adv (mostly > containing code cleanup stuff), there are at least two more to come. > > Please pull or let me know of any problem! Pulled, thanks Simon.

Re: [PATCH net 00/10] mlx4 misc fixes for 4.9

From: Tariq Toukan Date: Thu, 27 Oct 2016 16:27:12 +0300 > This patchset contains several bug fixes from the team to the > mlx4 Eth and Core drivers. > > Series generated against net commit: > ecc515d7238f 'sctp: fix the panic caused by route update' Series applied, thanks

Re: [net-next 00/17][pull request] 40GbE Intel Wired LAN Driver Updates 2016-10-28

From: Jeff Kirsher Date: Sat, 29 Oct 2016 00:30:41 -0700 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff.

[PATCH net-next] firewire: net: really fix maximum possible MTU

The maximum unicast datagram size /without/ link fragmentation is 4096 - 4 = 4092 (max IEEE 1394 async payload size at >= S800 bus speed, minus unfragmented encapssulation header). Max broadcast datagram size without fragmentation is 8 bytes less than that (due to GASP header). The maximum

[PATCH 00/15] use permission-specific DEVICE_ATTR variants

Use DEVICE_ATTR_RO etc. for read only attributes etc. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The complete semantic patch is as follows: (http://coccinelle.lip6.fr/) // @ro@ declarer name DEVICE_ATTR; identifier x,x_show; @@

[PATCH 12/15] ptp: use permission-specific DEVICE_ATTR variants

Use DEVICE_ATTR_RO for read only attributes. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @ro@ declarer name DEVICE_ATTR; identifier x,x_show; @@

[PATCH 15/15] solos-pci: use permission-specific DEVICE_ATTR variants

Use DEVICE_ATTR_RW for read-write attributes. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @rw@ declarer name DEVICE_ATTR; identifier x,x_show,x_store;

Re: [PATCH RDS v1] rds: debug messages are enabled by default

From: shamir.rabinovi...@oracle.com Date: Thu, 27 Oct 2016 05:46:38 -0400 > From: shamir rabinovitch > > rds use Kconfig option called "RDS_DEBUG" to enable rds debug messages. > This option cause the rds Makefile to add -DDEBUG to the rds gcc command > line. > >

Re: [PATCH net-next] bpf: Print function name in addition to function id

From: Thomas Graf Date: Thu, 27 Oct 2016 11:23:51 +0200 > The verifier currently prints raw function ids when printing CALL > instructions or when complaining: > > 5: (85) call 23 > unknown func 23 > > print a meaningful function name instead: > > 5: (85) call

Re: pull-request: mac80211 2016-10-27

From: Johannes Berg Date: Thu, 27 Oct 2016 10:05:49 +0200 > Before I go off for LPC and the workshop and everything, I have > two fixes. Neither is very important, but I figured I'd get them > out since I won't have any others soon. > > Let me know if there's any

Re: iproute: ss truncates abstract unix domain socket embedding null

On Thu, Oct 27, 2016 at 1:22 AM, Stephen Hemminger wrote: > Just translating all null characters to @ seems the most consistent and > logical. Also translating other all non-printing characters to something > (maybe '?') > might be wise. It would be nice if all

[PATCH] unix: escape all null bytes in abstract unix domain socket

Abstract unix domain socket may embed null characters, these should be translated to '@' when printed out to proc the same way the null prefix is currently being translated. This helps for tools such as netstat, lsof and the proc based implementation in ss to show all the significant bytes of the

[PATCH] iproute2: ss: escape all null bytes in abstract unix domain socket

Abstract unix domain socket may embed null characters, these should be translated to '@' when printed by ss the same way the null prefix is currently being translated. Signed-off-by: Isaac Boukris --- misc/ss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [PATCH net] ibmvnic: Fix releasing of sub-CRQ IRQs in interrupt context

From: Thomas Falcon Date: Wed, 26 Oct 2016 13:57:38 -0500 > Schedule these XPORT event tasks in the shared workqueue > so that IRQs are not freed in an interrupt context when > sub-CRQs are released. > > Signed-off-by: Thomas Falcon

Re: [PATCH] net: mv643xx_eth: Fetch the phy connection type from DT

From: Jason Gunthorpe Date: Wed, 26 Oct 2016 11:47:02 -0600 > The MAC is capable of RGMII mode and that is probably a more typical > connection type than GMII today (eg it is used by Marvell Reference > designs for several SOCs). Let DT users specify the standard

Re: [PATCH next] flow_dissector: __skb_get_hash_symmetric arg can be const

From: Florian Westphal Date: Wed, 26 Oct 2016 18:49:46 +0200 > Signed-off-by: Florian Westphal Applied, thanks Florian.

Re: [PATCH net-next] tcp/dccp: drop SYN packets if accept queue is full

From: Eric Dumazet Date: Wed, 26 Oct 2016 09:27:57 -0700 > From: Eric Dumazet > > Per listen(fd, backlog) rules, there is really no point accepting a SYN, > sending a SYNACK, and dropping the following ACK packet if accept queue > is full, because

Re: [PATCH net-next] net: phy: at803x: Add a definition for PHY ID mask

From: Fabio Estevam Date: Wed, 26 Oct 2016 14:03:54 -0200 > Add a definition for PHY ID mask for improving code readability. > > Signed-off-by: Fabio Estevam Applied.

Re: [PATCH 0/3] pull request for net: batman-adv 2016-10-26

From: Simon Wunderlich Date: Wed, 26 Oct 2016 17:55:12 +0200 > here are some bugfix patches which we would like to have integrated > into net. > > Please pull or let me know of any problem! Pulled, thanks Simon.

Re: [PATCH net] Revert "hv_netvsc: report vmbus name in ethtool"

From: Stephen Hemminger Date: Wed, 26 Oct 2016 09:27:53 -0700 > From: Stephen Hemminger > > This reverts commit e3f74b841d48 > ("hv_netvsc: report vmbus name in ethtool")' > because of problem introduced by commit f9a56e5d6a0ba > ("Drivers:

[net-next:master 68/93] include/net/raw.h:71:21: error: field 'inet' has incomplete type

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: c778453b138889587eee23e246e231bb12d1e80d commit: 432490f9d455fb842d70219f22d9d2c812371676 [68/93] net: ip, diag -- Add diag interface for raw sockets config: i386-randconfig-x012-201644 (attached as

Re: [PATCH net v2] packet: on direct_xmit, limit tso and csum to supported devices

From: Willem de Bruijn Date: Wed, 26 Oct 2016 11:23:07 -0400 > From: Willem de Bruijn > > When transmitting on a packet socket with PACKET_VNET_HDR and > PACKET_QDISC_BYPASS, validate device support for features requested > in vnet_hdr. > >

Re: [PATCH] net_sched actions: use nla_parse_nested()

From: Johannes Berg Date: Wed, 26 Oct 2016 14:44:33 +0200 > From: Johannes Berg > > Use nla_parse_nested instead of open-coding the call to > nla_parse() with the attribute data/len. > > Signed-off-by: Johannes Berg

Re: [PATCH net-next] switchdev: Remove redundant variable

From: ido...@idosch.org Date: Wed, 26 Oct 2016 12:03:03 +0300 > From: Ido Schimmel > > Instead of storing return value in 'err' and returning, just return > directly. > > Signed-off-by: Ido Schimmel > Reviewed-by: Jiri Pirko

Re: [PATCH net-next] netlink: Add nla_memdup() to wrap kmemdup() use on nlattr

From: Thomas Graf Date: Wed, 26 Oct 2016 10:53:16 +0200 > Wrap several common instances of: > kmemdup(nla_data(attr), nla_len(attr), GFP_KERNEL); > > Signed-off-by: Thomas Graf Applied.

Re: [PATCH net] cxgb4: Fix error handling in alloc_uld_rxqs().

From: Ganesh Goudar Date: Wed, 26 Oct 2016 13:26:38 +0530 > Fix to release resources properly in error handling path of > alloc_uld_rxqs(), This patch also removes unwanted arguments > and avoids calling the same function twice. > > Fixes: 94cdb8bb993a (cxgb4: Add support

Re: [PATCH] [net-next] net: ip, diag: include net/inet_sock.h

From: Arnd Bergmann Date: Tue, 25 Oct 2016 17:53:22 +0200 > The newly added raw_diag.c fails to build in some configurations > unless we include this header: > > In file included from net/ipv4/raw_diag.c:6:0: > include/net/raw.h:71:21: error: field 'inet' has incomplete type >

Re: [PATCH] ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()

From: Eli Cooper Date: Wed, 26 Oct 2016 10:11:09 +0800 > This patch updates skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit() when an > IPv6 header is installed to a socket buffer. > > This is not a cosmetic change. Without updating this value, GSO packets > transmitted through

Re: [PATCH net] bpf: fix samples to add fake KBUILD_MODNAME

From: Daniel Borkmann Date: Wed, 26 Oct 2016 00:37:53 +0200 > Some of the sample files are causing issues when they are loaded with tc > and cls_bpf, meaning tc bails out while trying to parse the resulting ELF > file as program/map/etc sections are not present, which can

Re: [PATCH net-next V3 0/9] liquidio CN23XX VF support

From: Raghu Vatsavayi Date: Tue, 25 Oct 2016 17:57:01 -0700 > 2) As recommended by you removed custom module parameter max_vfs. I feel the same way about num_queues_per_{p,v}f. What's really strange is that there is a reference to num_queues_per_pf in one of the

Re: [PATCH net] net: mangle zero checksum in skb_checksum_help()

Acked-by: Maciej Żenczykowski

[PATCH net] net: mangle zero checksum in skb_checksum_help()

From: Eric Dumazet Sending zero checksum is ok for TCP, but not for UDP. UDPv6 receiver should by default drop a frame with a 0 checksum, and UDPv4 would not verify the checksum and might accept a corrupted packet. Simply replace such checksum by 0x, regardless of

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

Hi Eric, Tested with both patches applied, still seeing the warning. Thanks! On Sat, Oct 29, 2016 at 7:43 PM, Eric Dumazet wrote: > On Sat, 2016-10-29 at 19:06 +0200, Andrey Konovalov wrote: >> Hi Cong, >> >> Tested with your patch, still getting a warning, though it's

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

On Sat, 2016-10-29 at 19:06 +0200, Andrey Konovalov wrote: > Hi Cong, > > Tested with your patch, still getting a warning, though it's a little > different: > > [ cut here ] > WARNING: CPU: 1 PID: 3876 at kernel/sched/core.c:7724 > __might_sleep+0x14c/0x1a0

Re: [PATCH net 2/3] sctp: return back transport in __sctp_rcv_init_lookup

On Sat, Oct 29, 2016 at 5:39 AM, Marcelo Ricardo Leitner wrote: > On Fri, Oct 28, 2016 at 05:42:21PM -0200, Marcelo Ricardo Leitner wrote: >> On Fri, Oct 28, 2016 at 06:10:53PM +0800, Xin Long wrote: >> > Prior to this patch, it used a local variable to save the

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

Hi Cong, Tested with your patch, still getting a warning, though it's a little different: [ cut here ] WARNING: CPU: 1 PID: 3876 at kernel/sched/core.c:7724 __might_sleep+0x14c/0x1a0 kernel/sched/core.c:7719 do not call blocking ops when !TASK_RUNNING; state=1 set at []

Re: Let's do P4

On 16-10-29 07:49 AM, Jakub Kicinski wrote: > On Sat, 29 Oct 2016 09:53:28 +0200, Jiri Pirko wrote: >> Hi all. >> >> The network world is divided into 2 general types of hw: >> 1) network ASICs - network specific silicon, containing things like TCAM >>These ASICs are suitable to be programmed

Re: [PATCH net] inet: Fix missing return value in inet6_hash

From: Craig Gallek Date: Tue, 25 Oct 2016 18:08:49 -0400 > From: Craig Gallek > > As part of a series to implement faster SO_REUSEPORT lookups, > commit 086c653f5862 ("sock: struct proto hash function may error") > added return values to protocol hash

Re: [PATCH v2 net-next] virtio-net: Update the mtu code to match virtio spec

From: Aaron Conole Date: Tue, 25 Oct 2016 16:12:12 -0400 > The virtio committee recently ratified a change, VIRTIO-152, which > defines the mtu field to be 'max' MTU, not simply desired MTU. > > This commit brings the virtio-net device in compliance with VIRTIO-152. > >

Re: [PATCH net] sctp: validate chunk len before actually using it

From: Marcelo Ricardo Leitner Date: Tue, 25 Oct 2016 14:27:39 -0200 > Andrey Konovalov reported that KASAN detected that SCTP was using a slab > beyond the boundaries. It was caused because when handling out of the > blue packets in function sctp_sf_ootb() it was

Re: [PATCH net 00/12] Mellanox 100G mlx5 fixes 2016-10-25

From: Saeed Mahameed Date: Tue, 25 Oct 2016 18:36:23 +0300 > This series contains some bug fixes for the mlx5 core and mlx5e > driver. Series applied, thank you.

Re: [PATCH v7 0/6] Add eBPF hooks for cgroups

On Sat, Oct 29, 2016 at 3:24 PM, Alexei Starovoitov wrote: > it could be solved by swapping the order of cgroup_bpf_run_filter() > and NF_INET_POST_ROUTING in patch 5. It was proposed some time back, but > the current patch, I think, is more symmetrical. > cgroup+bpf

Re: Let's do P4

Sat, Oct 29, 2016 at 04:54:21PM CEST, kubak...@wp.pl wrote: >On Sat, 29 Oct 2016 15:58:55 +0200, Jiri Pirko wrote: >> Sat, Oct 29, 2016 at 02:09:32PM CEST, tg...@suug.ch wrote: >> >On 10/29/16 at 01:28pm, Jiri Pirko wrote: >> >> Sat, Oct 29, 2016 at 01:15:48PM CEST, tg...@suug.ch wrote: >> >>

Re: Let's do P4

Sat, Oct 29, 2016 at 04:49:03PM CEST, kubak...@wp.pl wrote: >On Sat, 29 Oct 2016 09:53:28 +0200, Jiri Pirko wrote: >> Hi all. >> >> The network world is divided into 2 general types of hw: >> 1) network ASICs - network specific silicon, containing things like TCAM >>These ASICs are suitable

Re: Let's do P4

On Sat, 29 Oct 2016 15:58:55 +0200, Jiri Pirko wrote: > Sat, Oct 29, 2016 at 02:09:32PM CEST, tg...@suug.ch wrote: > >On 10/29/16 at 01:28pm, Jiri Pirko wrote: > >> Sat, Oct 29, 2016 at 01:15:48PM CEST, tg...@suug.ch wrote: > >> >So given the SKIP_SW flag, the in-kernel compiler is optional

Re: Let's do P4

On Sat, 29 Oct 2016 09:53:28 +0200, Jiri Pirko wrote: > Hi all. > > The network world is divided into 2 general types of hw: > 1) network ASICs - network specific silicon, containing things like TCAM >These ASICs are suitable to be programmed by P4. > 2) network processors - basically a

Re: [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

Sat, Oct 29, 2016 at 01:46:59PM CEST, s...@narfation.org wrote: >On Samstag, 29. Oktober 2016 12:56:28 CEST Jiri Pirko wrote: >[...] >> >> I strongly believe it is a huge mistake to use sysfs for things like >> >> this. This should be done via generic netlink api. >> > >> >This doesn't change the

[PATCH net] qede: Fix out-of-bound fastpath memory access

Driver allocates a shadow array for transmitted SKBs with X entries; That means valid indices are {0,...,X - 1}. [X == 8191] Problem is the driver also uses X as a mask for a producer/consumer in order to choose the right entry in the array which allows access to entry X which is out of bounds.

Re: Let's do P4

Sat, Oct 29, 2016 at 02:09:32PM CEST, tg...@suug.ch wrote: >On 10/29/16 at 01:28pm, Jiri Pirko wrote: >> Sat, Oct 29, 2016 at 01:15:48PM CEST, tg...@suug.ch wrote: >> >So given the SKIP_SW flag, the in-kernel compiler is optional anyway. >> >Why even risk including a possibly incomplete compiler?

[PATCH 4/4] isdn/eicon: use const strings with format arguments

Functions using a printf format argument do not modify the value of this argument. These functions can therefore use type "const char *" instead of "char *". This patch has only been compile-tested. Signed-off-by: Nicolas Iooss ---

[PATCH 3/4] isdn/eicon: add some __printf attributes

Add __printf attributes to some functions. This helps detecting errors related to printf-formats at compile time. When doing this, gcc reports some issues in debug.c. Fix them. This patch has only been compile-tested. Signed-off-by: Nicolas Iooss ---

[PATCH 2/4] isdn/eicon: fix some message formatting errors

There are some inconsistent debug message formats in message.c. For example, dprintf("XDI CAPI: RC cancelled Id:0x02, Ch:%02x", e->Id, ch); wrongly reports an ID of 2 and prints the entity ID as the channel ID. There are also object pointers which are used instead of the IDs. All these

[PATCH 1/4] isdn/eicon: remove unused argument in DBG_ERR call

diva_um_idi_read() can call DBG_ERR with 3 format arguments but using a format string which only uses 2 of them. Remove the last one. This bug has been found by adding a __printf attribute to myDbgPrint_...() functions. As this addition leads the compiler to report a lot of -Wformat warnings (for

Re: net-next still on 4.8.0?

From: Andrew Lunn Date: Fri, 28 Oct 2016 20:52:36 +0200 > During the merge window, you didn't close net-next. Trying something > new. > > We are now at v4.9-rc2, yet net-next is still based on 4.8.0. Is this > also something new you are trying? Or do you still plan to rebase to

Re: [PATCH net-next] udp: do fwd memory scheduling on dequeue

On Sat, 2016-10-29 at 10:17 +0200, Paolo Abeni wrote: > Thank you for working on this. > > I just gave a very quick look (the WE has started, children are > screaming ;-), overall the implementation seems quite similar to our > one. > > I like the additional argument to ip_cmsg_recv_offset()

Re: Let's do P4

On 10/29/16 at 01:28pm, Jiri Pirko wrote: > Sat, Oct 29, 2016 at 01:15:48PM CEST, tg...@suug.ch wrote: > >So given the SKIP_SW flag, the in-kernel compiler is optional anyway. > >Why even risk including a possibly incomplete compiler? Older kernels > >must be capable of running along newer

Re: [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

On Samstag, 29. Oktober 2016 12:56:28 CEST Jiri Pirko wrote: [...] > >> I strongly believe it is a huge mistake to use sysfs for things like > >> this. This should be done via generic netlink api. > > > >This doesn't change the problem that it is already that way. This patch > >only adds the list

Re: Let's do P4

Sat, Oct 29, 2016 at 01:15:48PM CEST, tg...@suug.ch wrote: >On 10/29/16 at 12:10pm, Jiri Pirko wrote: >> Sat, Oct 29, 2016 at 11:39:05AM CEST, tg...@suug.ch wrote: >> >On 10/29/16 at 09:53am, Jiri Pirko wrote: >> >> 3) Expose the p4ast in-kernel interpreter to userspace >> >>As the easiest way

[PATCH 1/1] ath10k: use the right length of "background"

The word "background" contains 10 characters so the third argument of strncmp() need to be 10 in order to match this prefix correctly. Signed-off-by: Nicolas Iooss Fixes: 855aed1220d2 ("ath10k: add spectral scan feature") ---

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

On 10/28/16 at 08:51pm, Shrijeet Mukherjee wrote: > Generally agree, but SRIOV nics with multiple queues can end up in a bad > spot if each buffer was 4K right ? I see a specific page pool to be used > by queues which are enabled for XDP as the easiest to swing solution that > way the memory

Re: Let's do P4

On 10/29/16 at 12:10pm, Jiri Pirko wrote: > Sat, Oct 29, 2016 at 11:39:05AM CEST, tg...@suug.ch wrote: > >On 10/29/16 at 09:53am, Jiri Pirko wrote: > >> 3) Expose the p4ast in-kernel interpreter to userspace > >>As the easiest way I see in to introduce a new TC classifier cls_p4. > >> > >>

Re: [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

Sat, Oct 29, 2016 at 12:37:07PM CEST, s...@narfation.org wrote: >On Samstag, 29. Oktober 2016 12:33:01 CEST Jiri Pirko wrote: >[...] >> >--- a/Documentation/networking/batman-adv.txt >> >+++ b/Documentation/networking/batman-adv.txt >> >@@ -71,10 +71,11 @@ All mesh wide settings can be found

Re: [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

On Samstag, 29. Oktober 2016 12:33:01 CEST Jiri Pirko wrote: [...] > >--- a/Documentation/networking/batman-adv.txt > >+++ b/Documentation/networking/batman-adv.txt > >@@ -71,10 +71,11 @@ All mesh wide settings can be found in batman's own > >interface > > folder: > > > > # ls

Re: [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

Thu, Oct 27, 2016 at 09:01:36PM CEST, s...@simonwunderlich.de wrote: >From: Sven Eckelmann > >Signed-off-by: Sven Eckelmann >Signed-off-by: Simon Wunderlich >--- > Documentation/networking/batman-adv.txt | 9 + > 1 file

Re: Let's do P4

Sat, Oct 29, 2016 at 11:39:05AM CEST, tg...@suug.ch wrote: >On 10/29/16 at 09:53am, Jiri Pirko wrote: >> Hi all. >> >> The network world is divided into 2 general types of hw: >> 1) network ASICs - network specific silicon, containing things like TCAM >>These ASICs are suitable to be

Re: Let's do P4

On 10/29/16 at 09:53am, Jiri Pirko wrote: > Hi all. > > The network world is divided into 2 general types of hw: > 1) network ASICs - network specific silicon, containing things like TCAM >These ASICs are suitable to be programmed by P4. > 2) network processors - basically a general purpose

Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry

On Fri, Oct 28, 2016 at 04:56:55PM -0400, Jon Mason wrote: > The BCM54810 PHY requires some semi-unique configuration, which results > in some additional configuration in addition to the standard config. > Also, some users of the BCM54810 require the PHY lanes to be swapped. > Since there is no

Re: [PATCH net-next] udp: do fwd memory scheduling on dequeue

On Fri, 2016-10-28 at 10:50 -0700, Eric Dumazet wrote: > On Fri, 2016-10-28 at 10:16 -0700, Eric Dumazet wrote: > > Nice ! > > > > I was working on this as well and my implementation was somewhat > > different. > > This is my WIP > > Note this can be split in two parts. > > 1) One adding

Let's do P4

Hi all. The network world is divided into 2 general types of hw: 1) network ASICs - network specific silicon, containing things like TCAM These ASICs are suitable to be programmed by P4. 2) network processors - basically a general purpose CPUs These processors are suitable to be programmed

Re: [PATCH] add one parameter wro_enable to enable relaxed ordering for IXGBE

On Sat, 2016-10-29 at 15:08 +0800, Mao Wenan wrote: > This patch provides a way to enable relaxed ordering, where it helps with > performance in some architecture. > The default value of wro_enable is 0, if you want to enable relaxed > ordering, please set wro_enable=1. > > Mao Wenan (1): >   add

[net-next 04/17] i40e: Remove unused function i40e_vsi_lookup

From: Alexander Duyck The function is not used so there is no need to carry it forward. I have plans to add a slightly different function that can be inlined to handle the same kind of functionality. Change-ID: Ie2dfcb189dc75e5fbc156bac23003e3b4210ae0f

[net-next 17/17] i40e: Clean up handling of msglevel flags and debug parameter

From: Alexander Duyck So the i40e driver had a really convoluted configuration for how to handle the debug flags contained in msg_level. Part of the issue is that the driver has its own 32 bit mask that it was using to track a separate set of debug features. From

[net-next 11/17] i40e: fix confusing dmesg info for ethtool -L option

From: Lihong Yang Ethtool -L option with the combined parameter is for changing the number of multi-purpose channels of the specified network device. The pre-set maximum for the combined channels is cpu dependent. Currently, for an i40e device, when the user sets a value

[net-next 14/17] i40e: Removal of workaround for simple MAC address filter deletion

From: Filip Sadowski This is code refactoring. This patch removes the workaround which deleted a default MAC filter added by the firmware when the interface was brought up. This filter caused frames to pass disregarding the VLAN tagging. It used to be automatically

[net-next 10/17] i40e: Make struct i40e_stats const

From: Joe Perches Move some data to text $ size drivers/net/ethernet/intel/i40e/i40e_ethtool.o* textdata bss dec hex filename 25012 0 32 2504461d4 drivers/net/ethernet/intel/i40e/i40e_ethtool.o.new 228682120 32 2502061bc

[net-next 08/17] i40e/i40evf: fix interrupt affinity bug

From: Alan Brady There exists a bug in which a 'perfect storm' can occur and cause interrupts to fail to be correctly affinitized. This causes unexpected behavior and has a substantial impact on performance when it happens. The bug occurs if there is heavy traffic, any

[net-next 15/17] i40e/i40evf: Changed version from 1.6.19 to 1.6.21

From: Bimmy Pujari Signed-off-by: Bimmy Pujari Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-

[net-next 03/17] i40e: Bit test mask correction

From: Filip Sadowski Incorrect bit mask was used for testing "get link status" response. Instead of I40E_AQ_LSE_ENABLE (which is actually 0x03) it most probably should be I40E_AQ_LSE_IS_ENABLED (which is defined as 0x01). Change-ID:

  1   2   >