On vr, dec 09, 2016 at 09:09:59 -0800, Cong Wang wrote:
> At most it is used for debugging purpose, but I don't think
> it is even useful for debugging, just remove it.
>
> Cc: Simon Horman
> Signed-off-by: Cong Wang
Thanks, applied.
When event index was enabled, we need to fetch used event from
userspace memory each time. This userspace fetch (with memory
barrier) could be saved sometime when 1) caching used event and 2)
if used event is ahead of new and old to new updating does not cross
it, we're sure there's no need to noti
On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa wrote:
> Souptick Joarder writes:
>
>> We should use dma_pool_zalloc instead of dma_pool_alloc/memset
>>
>> Signed-off-by: Souptick joarder
>> ---
>> drivers/net/wan/ixp4xx_hss.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>>
Hi all,
Today's linux-next merge of the tip tree got a conflict in:
drivers/net/ethernet/ti/Kconfig
between commit:
6246168b4a38 ("net: ethernet: ti: netcp: add support of cpts")
from the net-next tree and commit:
d1cbfd771ce8 ("ptp_clock: Allow for it to be optional")
from the tip tre
On 2016年12月08日 22:25, Michael S. Tsirkin wrote:
On Wed, Dec 07, 2016 at 12:21:22PM +0800, Jason Wang wrote:
On 2016年12月06日 23:41, Michael S. Tsirkin wrote:
virtio_transport_alloc_pkt is only used locally, make it static.
Signed-off-by: Michael S. Tsirkin
---
net/vmw_vsock/virtio_transpo
From: zheng li
There is an inconsistent conditional judgement in __ip_append_data and
ip_finish_output functions, the variable length in __ip_append_data just
include the length of application's payload and udp header, don't include
the length of ip header, but in ip_finish_output use
(skb->len >
Code move only; no functional change intended.
Signed-off-by: David Ahern
---
include/utils.h | 2 ++
ip/ipnetns.c| 34 --
lib/Makefile| 2 +-
lib/exec.c | 40 +
4 files changed, 43 insertions(+), 35 deletions
index of 0 means name is not a valid vrf.
Signed-off-by: David Ahern
---
ip/ip_common.h | 2 +-
ip/iplink_vrf.c | 15 +--
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/ip/ip_common.h b/ip/ip_common.h
index 0147f45a7a31..3162f1ca5b2c 100644
--- a/ip/ip_common.h
+++
Signed-off-by: David Ahern
---
include/bpf_util.h | 3 +++
lib/bpf.c | 21 +
2 files changed, 24 insertions(+)
diff --git a/include/bpf_util.h b/include/bpf_util.h
index 05baeecda57f..b038379684a8 100644
--- a/include/bpf_util.h
+++ b/include/bpf_util.h
@@ -75,6 +75
Based on version in kernel repo, samples/bpf/libbpf.h
Signed-off-by: David Ahern
---
include/bpf_util.h | 179 +
1 file changed, 179 insertions(+)
diff --git a/include/bpf_util.h b/include/bpf_util.h
index 726e3455..5361dab1933d 100644
---
'ip vrf' follows the user semnatics established by 'ip netns'.
The 'ip vrf' subcommand supports 3 usages:
1. Run a command against a given vrf:
ip vrf exec NAME CMD
Uses the recently committed cgroup/sock BPF option. vrf directory
is added to cgroup2 mount. Individual vrfs are creat
Add make_path to recursively call mkdir as needed to create a given
path with the given mode.
Add find_cgroup2_mount to lookup path where cgroup2 is mounted. If it
is not already mounted, cgroup2 is mounted under /var/run/cgroup2 for
use by iproute2.
Signed-off-by: David Ahern
---
include/utils
iplink_vrf has 2 functions used to validate a user given device name is
a VRF device and to return the table id. If the user string is not a
device name ip commands with a vrf keyword show a confusing error
message: "RTNETLINK answers: No such device".
Add a variant of rtnl_talk that does not disp
This series adds support to iproute2 to run a command against a specific
VRF. The user semantics are similar to 'ip netns'.
The 'ip vrf' subcommand supports 3 usages:
1. Run a command against a given vrf:
ip vrf exec NAME CMD
Uses the recently committed cgroup/sock BPF option. vrf dire
Code move only; no functional change intended.
Signed-off-by: David Ahern
---
include/bpf_util.h | 4
lib/bpf.c | 40
2 files changed, 24 insertions(+), 20 deletions(-)
diff --git a/include/bpf_util.h b/include/bpf_util.h
index b038379684a
From: Thomas Graf
Adds support to configure BPF programs as nexthop actions via the LWT
framework.
Example:
ip route add 192.168.253.2/32 \
encap bpf out obj lwt_len_hist_kern.o section len_hist \
dev veth0
Signed-off-by: Thomas Graf
---
include/bpf_api.h | 5 ++
ip/iprout
I would like to solicit your assistance to claim $9 M from my bank and
you will benefit 30% of the fund for assisting me while the remaining
70% will be mine, let know if you are capable so that i can give you
the full details of the transaction.
Regards,
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 65 +--
1 files changed, 37 insertions(+), 28 deletions(-)
diff --git a/drivers/n
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet/chelsio/cxgb/cxgb2.c | 64 +
1 files changed, 37 insertions(+), 27 deletions(-)
diff --git a/drivers/n
Hi Andrew,
Andrew Lunn writes:
> @@ -1804,6 +1807,9 @@ static int mv88e6xxx_port_check_hw_vlan(struct
> dsa_switch *ds, int port,
> chip->ports[port].bridge_dev)
> break; /* same bridge, check next VLAN */
>
> + if (!
On Sun, 2016-12-11 at 23:31 +0800, Jan Wang wrote:
> [net]: Missing init queue tail
>
> Accept queue tail doesn't initialize NULL.
> Though looks like no harm, unify it with reqsk_queue_remove(
> it will initialize tail to NULL when empty).
Well, if having a NULL or not causes no harm, what about
Hi!
> On 09.12.2016 12:21, Pavel Machek wrote:
> > On Fri 2016-12-09 00:19:43, Francois Romieu wrote:
> >> Lino Sanfilippo :
> >> [...]
> >> > OTOH Pavel said that he actually could produce a deadlock. Now I wonder
> >> > if
> >> > this is caused by that locking scheme (in a way I have not figur
A port is not necessarily assigned to a netdev. And a port does not
need to be a member of a bridge. So when iterating over all ports,
check before using the netdev and bridge_dev for a port. Otherwise we
dereference a NULL pointer.
Fixes: da9c359e19f0 ("net: dsa: mv88e6xxx: check hardware VLAN in
On Sun 2016-12-11 14:31:13, David Miller wrote:
> From: Pavel Machek
> Date: Sun, 11 Dec 2016 20:07:50 +0100
>
> > David, ping? Can I get you to apply this one?
> >
> > As you noticed, tx coalescing is completely broken in that driver, and
> > not easy to repair. This is simplest way to disable
Le 12/07/16 à 11:20, Timur Tabi a écrit :
> Instead of having individual PHY drivers set the SUPPORTED_Pause and
> SUPPORTED_Asym_Pause flags, phylib itself should set those flags,
> unless there is a hardware erratum or other special case. During
> autonegotiation, the PHYs will determine whether
From: Pavel Machek
Date: Sun, 11 Dec 2016 20:07:50 +0100
> David, ping? Can I get you to apply this one?
>
> As you noticed, tx coalescing is completely broken in that driver, and
> not easy to repair. This is simplest way to disable it. It can still
> be re-enabled from userspace, so code can b
Hi!
David, ping? Can I get you to apply this one?
As you noticed, tx coalescing is completely broken in that driver, and
not easy to repair. This is simplest way to disable it. It can still
be re-enabled from userspace, so code can be fixed in future.
Best regards,
The timer handling in this driver is broken in several ways:
- corkscrew_open() initializes and arms a timer before requesting the
device interrupt. If the request fails the timer stays armed.
A second call to corkscrew_open will unconditionally reinitialize the
quued timer and arm it again
On Sun, Dec 11, 2016 at 03:50:31PM +0100, Jason A. Donenfeld wrote:
> 3. Add 3 bytes of padding, set to zero, to the encrypted section just
> before the IP header, marked for future use.
> Pros: satisfies IETF mantras, can use those extra bits in the future
> for interesting protocol extensions for
On Sun, Dec 11, 2016 at 4:30 PM, Andrew Lunn wrote:
> I'm not a crypto expert, but does this not give you a helping hand in
> breaking the crypto? You know the plain text value of these bytes, and
> where they are in the encrypted text.
You also know with some probability that there's going to be
[net]: Missing init queue tail
Accept queue tail doesn't initialize NULL.
Though looks like no harm, unify it with reqsk_queue_remove(
it will initialize tail to NULL when empty).
Signed-off-by: Jan Wang
---
net/core/request_sock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/re
> 3. Add 3 bytes of padding, set to zero, to the encrypted section just
> before the IP header, marked for future use.
> Pros: satisfies IETF mantras, can use those extra bits in the future
> for interesting protocol extensions for authenticated peers.
> Cons: lowers MTU, marginally more difficult
On Sun, Dec 11, 2016 at 02:18:00PM +0200, Saeed Mahameed wrote:
> On Wed, Dec 7, 2016 at 4:41 AM, Andrew Lunn wrote:
> > On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote:
> >> Hi Dave,
> >>
> >> This series adds the support for setting device registers from user
> >> space ethtool.
>
On Sunday, December 11, 2016 11:43:59 AM CET Pablo Neira Ayuso wrote:
> Dump and reset doesn't work unless cmpxchg64() is used both from packet
> and control plane paths. This approach is going to be slow though.
> Instead, use a percpu seqcount to fetch counters consistently, then
> subtract bytes
From: Pablo Neira Ayuso
Date: Sun, 11 Dec 2016 11:43:59 +0100
> Dump and reset doesn't work unless cmpxchg64() is used both from packet
> and control plane paths. This approach is going to be slow though.
> Instead, use a percpu seqcount to fetch counters consistently, then
> subtract bytes and p
Hey guys,
Thanks for the extremely detailed answers. The main take-away from
this is that passing unaligned packets to the networking stack kills
kittens. So now it's a question of mitigation. I have three options:
1. Copy the plaintext to three bytes before the start of the cipher
text, overwrit
On Wed, Dec 7, 2016 at 4:57 AM, David Miller wrote:
> From: Andrew Lunn
> Date: Wed, 7 Dec 2016 03:41:43 +0100
>
>> On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote:
>>> Hi Dave,
>>>
>>> This series adds the support for setting device registers from user
>>> space ethtool.
>>
>> Is
On Wed, Dec 7, 2016 at 4:41 AM, Andrew Lunn wrote:
> On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote:
>> Hi Dave,
>>
>> This series adds the support for setting device registers from user
>> space ethtool.
>
> Is this not the start of allowing binary only drivers in user space?
>
I
On Wed, Dec 7, 2016 at 12:45 AM, Stephen Hemminger
wrote:
> On Wed, 7 Dec 2016 00:33:08 +0200
> Saeed Mahameed wrote:
>
>> This simple ethool change will give HW vendors the flexibility to set
>> pure HW configurations (not directly related to netdev resources states
>> and rings), without the n
Willy Tarreau writes:
> Hi Jason,
>
> On Thu, Dec 08, 2016 at 11:20:04PM +0100, Jason A. Donenfeld wrote:
>> Hi David,
>>
>> On Thu, Dec 8, 2016 at 1:37 AM, David Miller wrote:
>> > You really have to land the IP header on a proper 4 byte boundary.
>> >
>> > I would suggest pushing 3 dummy garb
Dump and reset doesn't work unless cmpxchg64() is used both from packet
and control plane paths. This approach is going to be slow though.
Instead, use a percpu seqcount to fetch counters consistently, then
subtract bytes and packets in case a reset was requested.
The cpu that running over the res
On Sat, Dec 10, 2016 at 07:40:08AM -0800, Eric Dumazet wrote:
> On Sat, 2016-12-10 at 15:25 +0100, Pablo Neira Ayuso wrote:
> > On Sat, Dec 10, 2016 at 03:16:55PM +0100, Pablo Neira Ayuso wrote:
> =
> >
> > - nft_counter_fetch(priv, &total, reset);
> > + nft_counter_fetch(priv, &total
On Fri, Dec 9, 2016 at 6:08 AM, Cong Wang wrote:
> On Thu, Dec 8, 2016 at 4:32 PM, Cong Wang wrote:
>> On Thu, Dec 8, 2016 at 9:16 AM, Dmitry Vyukov wrote:
>>> Chain exists of:
>>> Possible unsafe locking scenario:
>>>
>>>CPU0CPU1
>>>-
Hi Jason,
On Thu, Dec 08, 2016 at 11:20:04PM +0100, Jason A. Donenfeld wrote:
> Hi David,
>
> On Thu, Dec 8, 2016 at 1:37 AM, David Miller wrote:
> > You really have to land the IP header on a proper 4 byte boundary.
> >
> > I would suggest pushing 3 dummy garbage bytes of padding at the front
>
44 matches
Mail list logo