Re: [PATCH v2 8/8] crypto/testmgr: Allocate only the required output size for hash tests

2017-01-11 Thread Andy Lutomirski
On Wed, Jan 11, 2017 at 11:47 PM, Herbert Xu wrote: > Andy Lutomirski wrote: >> There are some hashes (e.g. sha224) that have some internal trickery >> to make sure that only the correct number of output bytes are >> generated. If something goes

Re: [PATCH v2 8/8] crypto/testmgr: Allocate only the required output size for hash tests

2017-01-11 Thread Herbert Xu
Andy Lutomirski wrote: > There are some hashes (e.g. sha224) that have some internal trickery > to make sure that only the correct number of output bytes are > generated. If something goes wrong, they could potentially overrun > the output buffer. > > Make the test more robust

[PATCH net-next] cxgb4: Initialize mbox lock and list for mgmt dev

2017-01-11 Thread Ganesh Goudar
Initialize mbox lock and list for mgmt dev to avoid NULL pointer dereference when cxgb_set_vf_mac is called. And also allocate memory for private data while allocating mgmt netdev. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 5 -

[PATCH v2 net-next] Introduce a sysctl that modifies the value of PROT_SOCK.

2017-01-11 Thread Krister Johansen
Add net.ipv4.ip_unprotected_port_start, which is a per namespace sysctl that denotes the first unprotected inet port in the namespace. To disable all protected ports set this to zero. It also checks for overlap with the local port range. The protected and local range may not overlap. The use

[PATCH] can: Fix kernel panic at security_sock_rcv_skb

2017-01-11 Thread Liu ShuoX
From: Zhang Yanmin The patch is for fix the below kernel panic: BUG: unable to handle kernel NULL pointer dereference at (null) IP: [] selinux_socket_sock_rcv_skb+0x65/0x2a0 Call Trace: [] security_sock_rcv_skb+0x4c/0x60 [] sk_filter+0x41/0x210 []

[PATCH net-next] net: core: Make netif_wake_subqueue a wrapper

2017-01-11 Thread Florian Fainelli
netif_wake_subqueue() is duplicating the same thing that netif_tx_wake_queue() does, so make it call it directly after looking up the queue from the index. Signed-off-by: Florian Fainelli --- include/linux/netdevice.h | 14 +- net/core/dev.c| 22

Re: [PATCH v2 2/2] stmmac: rename it to synopsys

2017-01-11 Thread Florian Fainelli
On 01/11/2017 07:44 PM, Jie Deng wrote: > Hi Joao, > > On 2017/1/11 18:35, Joao Pinto wrote: >> Hi Jie, >> >> Às 4:00 AM de 1/11/2017, Jie Deng escreveu: >>> Hi Joao, >>> >>> >>> On 2017/1/10 22:52, Joao Pinto wrote: This patch renames stmicro/stmmac to synopsys/ since it is a standard

[Patch net] atm: switch to the new wait API for vcc_sendmsg()

2017-01-11 Thread Cong Wang
Andrey reported a kernel warning for the blocking ops in between prepare_to_wait() and schedule(), that is alloc_tx(). Of course, the logic itself is suspicious, other sendmsg() could handle skb allocation failure very well, not sure why ATM has to wait for a successful one here. But probably it

[Patch net] atm: remove an unnecessary loop

2017-01-11 Thread Cong Wang
alloc_tx() is already inside a wait loop for a successful skb allocation, this loop inside alloc_tx() is quite unnecessary and actually problematic. Signed-off-by: Cong Wang --- net/atm/common.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-11 Thread Cong Wang
On Wed, Jan 11, 2017 at 11:46 AM, Michal Hocko wrote: > On Wed 11-01-17 20:45:25, Michal Hocko wrote: >> On Wed 11-01-17 09:37:06, Chas Williams wrote: >> > On Mon, 2017-01-09 at 18:20 +0100, Andrey Konovalov wrote: >> > > Hi! >> > > >> > > I've got the following error report

[PATCH v4 03/13] net: ethernet: aquantia: Add ring support code

2017-01-11 Thread Alexander Loktionov
From: David VomLehn Add code to support the transmit and receive ring buffers. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

[PATCH v4 09/13] net: ethernet: aquantia: Atlantic hardware abstraction layer

2017-01-11 Thread Alexander Loktionov
From: David VomLehn Add common functions for Atlantic hardware abstraction layer. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

[PATCH v4 06/13] net: ethernet: aquantia: Atlantic A0 and B0 specific functions.

2017-01-11 Thread Alexander Loktionov
From: David VomLehn Add Atlantic A0 and B0 specific functions. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry

[PATCH v4 08/13] net: ethernet: aquantia: PCI operations

2017-01-11 Thread Alexander Loktionov
From: David VomLehn Add functions that handle the PCI bus interface. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by:

[PATCH v4 12/13] net: ethernet: aquantia: Receive side scaling

2017-01-11 Thread Alexander Loktionov
From: David VomLehn Add definitions that support receive side scaling. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

[PATCH v4 07/13] net: ethernet: aquantia: Vector operations

2017-01-11 Thread Alexander Loktionov
From: David VomLehn Add functions to manululate the vector of receive and transmit rings. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel.Belous

[PATCH v4 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-11 Thread Alexander Loktionov
From: David VomLehn Patches to create the make and configuration files. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

[PATCH v4 10/13] net: ethernet: aquantia: Hardware interface and utility functions

2017-01-11 Thread Alexander Loktionov
From: David VomLehn Add functions to interface with the hardware and some utility functions. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

[PATCH v4 05/13] net: ethernet: aquantia: Support for NIC-specific code

2017-01-11 Thread Alexander Loktionov
From: David VomLehn Add support for code specific to the Atlantic NIC. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

[PATCH v4 13/13] net: ethernet: aquantia: Integrate AQtion 2.5/5 GB NIC driver

2017-01-11 Thread Alexander Loktionov
From: David VomLehn Modify the drivers/net/ethernet/{Makefile,Kconfig} file to make them a part of the network drivers build. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by:

[PATCH v4 11/13] net: ethernet: aquantia: Ethtool support

2017-01-11 Thread Alexander Loktionov
From: David VomLehn Add the driver interfaces required for support by the ethtool utility. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous

[PATCH v4 02/13] net: ethernet: aquantia: Common functions and definitions

2017-01-11 Thread Alexander Loktionov
From: David VomLehn Add files containing the functions and definitions used in common in different functional areas. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel

[PATCH v4 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

2017-01-11 Thread Alexander Loktionov
From: David VomLehn This series introduces the AQtion NIC driver for the aQuantia AQC107/AQC108 network devices. v1: Initial version v2: o Make necessary drivers/net/ethernet changes to integrate software o Drop intermediate atlantic directory o Remove Makefile things

[PATCH net-next v2 01/10] net: dsa: Pass device pointer to dsa_register_switch

2017-01-11 Thread Florian Fainelli
In preparation for allowing dsa_register_switch() to be supplied with device/platform data, pass down a struct device pointer instead of a struct device_node. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 2 +- drivers/net/dsa/mv88e6xxx/chip.c |

Re: [PATCH v2 2/2] stmmac: rename it to synopsys

2017-01-11 Thread Jie Deng
Hi Joao, On 2017/1/11 18:35, Joao Pinto wrote: > Hi Jie, > > Às 4:00 AM de 1/11/2017, Jie Deng escreveu: >> Hi Joao, >> >> >> On 2017/1/10 22:52, Joao Pinto wrote: >>> This patch renames stmicro/stmmac to synopsys/ since it is a standard >>> ethernet software package regarding synopsys ethernet

[PATCH net-next v2 00/10] net: dsa: Support for pdata in dsa2

2017-01-11 Thread Florian Fainelli
Hi all, This is not exactly new, and was sent before, although back then, I did not have an user of the pre-declared MDIO board information, but now we do. Note that I have additional changes queued up to have b53 register platform data for MIPS bcm47xx and bcm63xx. Yes I know that we should

[PATCH net-next v2 05/10] drivers: base: Add device_find_class()

2017-01-11 Thread Florian Fainelli
Add a helper function to lookup a device reference given a class name. This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and make it more generic. Signed-off-by: Florian Fainelli --- drivers/base/core.c| 19 +++ include/linux/device.h

[PATCH net-next v2 04/10] net: dsa: Move ports assignment closer to error checking

2017-01-11 Thread Florian Fainelli
Move the assignment of ports in _dsa_register_switch() closer to where it is checked, no functional change. Re-order declarations to be preserve the inverted christmas tree style. Signed-off-by: Florian Fainelli --- net/dsa/dsa2.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH net-next v2 03/10] net: dsa: Suffix function manipulating device_node with _dn

2017-01-11 Thread Florian Fainelli
Make it clear that these functions take a device_node structure pointer Signed-off-by: Florian Fainelli --- net/dsa/dsa2.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index 6e3675220fef..04ab62251fe3

[PATCH net-next v2 02/10] net: dsa: Make most functions take a dsa_port argument

2017-01-11 Thread Florian Fainelli
In preparation for allowing platform data, and therefore no valid device_node pointer, make most DSA functions takes a pointer to a dsa_port structure whenever possible. While at it, introduce a dsa_port_is_valid() helper function which checks whether port->dn is NULL or not at the moment.

[PATCH net-next v2 06/10] net: dsa: Migrate to device_find_class()

2017-01-11 Thread Florian Fainelli
Now that the base device driver code provides an identical implementation of dev_find_class() utilize device_find_class() instead of our own version of it. Signed-off-by: Florian Fainelli --- net/dsa/dsa.c | 22 ++ 1 file changed, 2 insertions(+), 20

[PATCH net-next v2 07/10] net: Relocate dev_to_net_device() into core

2017-01-11 Thread Florian Fainelli
dev_to_net_device() is moved from net/dsa/dsa.c to net/core/dev.c since it going to be used by net/dsa/dsa2.c and the namespace of the function justifies making it available to other users potentially. Signed-off-by: Florian Fainelli --- include/linux/netdevice.h | 2 ++

[PATCH net-next v2 09/10] net: phy: Allow pre-declaration of MDIO devices

2017-01-11 Thread Florian Fainelli
Allow board support code to collect pre-declarations for MDIO devices by registering them with mdiobus_register_board_info(). SPI and I2C buses have a similar feature, we were missing this for MDIO devices, but this is particularly useful for e.g: MDIO-connected switches which need to provide

[PATCH net-next v2 10/10] ARM: orion: Register DSA switch as a MDIO device

2017-01-11 Thread Florian Fainelli
Utilize the ability to pass board specific MDIO bus information towards a particular MDIO device thus allowing us to provide the per-port switch layout to the Marvell 88E6XXX switch driver. Since we would end-up with conflicting registration paths, do not register the "dsa" platform device

[PATCH net-next v2 08/10] net: dsa: Add support for platform data

2017-01-11 Thread Florian Fainelli
Allow drivers to use the new DSA API with platform data. Most of the code in net/dsa/dsa2.c does not rely so much on device_nodes and can get the same information from platform_data instead. We purposely do not support distributed configurations with platform data, so drivers should be providing

[PATCH net-next] net/mlx5e: Support bpf_xdp_adjust_head()

2017-01-11 Thread Martin KaFai Lau
This patch adds bpf_xdp_adjust_head() support to mlx5e. 1. rx_headroom is added to struct mlx5e_rq. It uses an existing 4 byte hole in the struct. 2. The adjusted data length is checked against MLX5E_XDP_MIN_INLINE and MLX5E_SW2HW_MTU(rq->netdev->mtu). 3. The macro MLX5E_SW2HW_MTU is moved

[PATCH net-next] secure_seq: fix sparse errors

2017-01-11 Thread Eric Dumazet
From: Eric Dumazet Fixes following warnings : net/core/secure_seq.c:125:28: warning: incorrect type in argument 1 (different base types) net/core/secure_seq.c:125:28:expected unsigned int const [unsigned] [usertype] a net/core/secure_seq.c:125:28:got restricted

[PATCH net-next 0/2] More flexible BPF cb access

2017-01-11 Thread Daniel Borkmann
This patch improves BPF's cb access by allowing b/h/w/dw access variants on it. For details, please see individual patches. Thanks! Daniel Borkmann (2): bpf: pass original insn directly to convert_ctx_access bpf: allow b/h/w/dw access for bpf's cb in ctx include/linux/bpf.h

[PATCH net-next 1/2] bpf: pass original insn directly to convert_ctx_access

2017-01-11 Thread Daniel Borkmann
Currently, when calling convert_ctx_access() callback for the various program types, we pass in insn->dst_reg, insn->src_reg, insn->off from the original instruction. This information is needed to rewrite the instruction that is based on the user ctx structure into a kernel representation for the

[PATCH net-next 2/2] bpf: allow b/h/w/dw access for bpf's cb in ctx

2017-01-11 Thread Daniel Borkmann
When structs are used to store temporary state in cb[] buffer that is used with programs and among tail calls, then the generated code will not always access the buffer in bpf_w chunks. We can ease programming of it and let this act more natural by allowing for aligned b/h/w/dw sized access for

[PATCH net-next] liquidio VF: reduce load time of module

2017-01-11 Thread Felix Manlunas
From: Prasad Kanneganti Reduce the load time of the VF driver by decreasing the wait time between iterations of the loop that polls for a mailbox response from the PF. Also change the wait time units from jiffies to milliseconds. Signed-off-by: Prasad Kanneganti

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Kwok, WingMan
> -Original Message- > From: Kwok, WingMan > Sent: Wednesday, January 11, 2017 5:32 PM > To: 'Andrew Lunn'; 'rmk+ker...@arm.linux.org.uk' > Cc: Karicheri, Muralidharan; netdev@vger.kernel.org > Subject: RE: Marvell Phy (1510) issue since v4.7 kernel > > > > > -Original

[PATCH net-next] liquidio: remove unnecessary code

2017-01-11 Thread Felix Manlunas
Remove code that's no longer needed. It used to serve a purpose, which was to fix a link-related bug. For a while now, the NIC firmware has had a more elegant fix for that bug. Signed-off-by: Felix Manlunas Signed-off-by: Derek Chickles

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Andrew Lunn
> Hi Andrew, > > I double checked that ours is actually a 88E1514. According > to Marvell's brief description, it seems that it does support > fiber. > > Reading page 18 reg 30 returns 6. O.K, that is consistent. Looking at the Marvell SDK: phy/Include/madApiDefs.h:#defineMAD_SUB_88E1510

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Kwok, WingMan
> Hi WingMan > > Do you know you really have a 1510? You can see it written on the > chip? > > Please can you read page 18, register 30 and let us know what value > you get. > > Andrew Removed Charles-Antonie from the list since the email address is no longer valid. Hi Andrew, I double

Re: TCP using IPv4-mapped IPv6 address as source

2017-01-11 Thread Jonathan T. Leighton
On 1/11/17 4:47 PM, Eric Dumazet wrote: On Wed, 2017-01-11 at 16:26 -0500, Jonathan T. Leighton wrote: I'm sure I understand what you're saying here. There should be no flow to terminate. I think you figured out that I meant "I'm not sure I understand...". rfc2765 describes a way to use

[PATCH] net: ipv4: fix table id in getroute response

2017-01-11 Thread David Ahern
rtm_table is an 8-bit field while table ids are allowed up to u32. Commit 709772e6e065 ("net: Fix routing tables with id > 255 for legacy software") added the preference to set rtm_table in dumps to RT_TABLE_COMPAT if the table id is > 255. The table id returned on get route requests should do the

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Andrew Lunn
> > So i think the correct question should be, how can we tell the 88E1512 > > from the 88E1510 if they have the same ID in register 3. Hi WingMan Do you know you really have a 1510? You can see it written on the chip? Please can you read page 18, register 30 and let us know what value you get.

Re: [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum

2017-01-11 Thread Stephen Rothwell
Hi Dave, On Tue, 29 Nov 2016 20:07:08 +1100 Stephen Rothwell wrote: > > Hi Jeff, > > On Tue, 29 Nov 2016 10:43:04 +1100 Stephen Rothwell > wrote: > > > > On Mon, 28 Nov 2016 14:26:02 -0800 Jeff Kirsher > > wrote:

[PATCH] xen-netfront: Fix Rx stall during network stress and OOM

2017-01-11 Thread Vineeth Remanan Pillai
During an OOM scenario, request slots could not be created as skb allocation fails. So the netback cannot pass in packets and netfront wrongly assumes that there is no more work to be done and it disables polling. This causes Rx to stall. Fix is to consider the skb allocation failure as an error

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Kwok, WingMan
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Wednesday, January 11, 2017 6:00 PM > To: Kwok, WingMan > Cc: rmk+ker...@arm.linux.org.uk; charles-antoine.cou...@nexvision.fr; > Karicheri, Muralidharan; netdev@vger.kernel.org > Subject: Re: Marvell Phy (1510)

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Andrew Lunn
> looping in Charles-Antoine (author of patch > with commit id 6cfb3bcc) > > Charles-Antoine, > > Do you have the ID of Marvell PHY 88E1512? I suspect that is the wrong question to ask. The Marvell driver is being loaded, so it must be using on of the IDs in the driver. There is no ID in the

[PATCH] tilepro: Fix non-void return from void function

2017-01-11 Thread Joe Perches
commit bc1f44709cf2 ("net: make ndo_get_stats64 a void function") mistakenly used a return value for this void conversion. Fix it. Signed-off-by: Joe Perches cc: stephen hemminger --- drivers/net/ethernet/tile/tilepro.c | 4 1 file changed, 4

[PATCH] [v2] net: qcom/emac: grab a reference to the phydev on ACPI systems

2017-01-11 Thread Timur Tabi
Commit 6ffe1c4cd0a7 ("net: qcom/emac: fix of_node and phydev leaks") fixed the problem with reference leaks on phydev, but the fix is device-tree specific. When the driver unloads, the reference is dropped only on DT systems. Instead, it's cleaner if up grab an reference on ACPI systems. When

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Kwok, WingMan
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Wednesday, January 11, 2017 5:28 PM > To: Kwok, WingMan > Cc: Karicheri, Muralidharan; netdev@vger.kernel.org > Subject: Re: Marvell Phy (1510) issue since v4.7 kernel > > On Wed, Jan 11, 2017 at 10:18:02PM +,

[PATCH] net: lwtunnel: Handle lwtunnel_fill_encap failure

2017-01-11 Thread David Ahern
Handle failure in lwtunnel_fill_encap adding attributes to skb. Fixes: 571e722676fe ("ipv4: support for fib route lwtunnel encap attributes") Fixes: 19e42e451506 ("ipv6: support for fib route lwtunnel encap attributes") Signed-off-by: David Ahern ---

Re: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Andrew Lunn
On Wed, Jan 11, 2017 at 10:18:02PM +, Kwok, WingMan wrote: > > > > -Original Message- > > From: Andrew Lunn [mailto:and...@lunn.ch] > > Sent: Monday, January 09, 2017 8:54 PM > > To: Kwok, WingMan > > Cc: Karicheri, Muralidharan; netdev@vger.kernel.org > > Subject: Re: Marvell Phy

RE: Marvell Phy (1510) issue since v4.7 kernel

2017-01-11 Thread Kwok, WingMan
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Monday, January 09, 2017 8:54 PM > To: Kwok, WingMan > Cc: Karicheri, Muralidharan; netdev@vger.kernel.org > Subject: Re: Marvell Phy (1510) issue since v4.7 kernel > > > From Marvell's brief description >

Re: [PATCH v2 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-11 Thread Rami Rosen
Hi, > +++ b/drivers/net/ethernet/aquantia/Makefile > @@ -0,0 +1,44 @@ ... ... > > +obj-$(CONFIG_AQTION) += atlantic.o > + > +atlantic-objs := aq_main.o \ > + aq_nic.o \ > + aq_pci_func.o \ Why twice aq_nic.o ? it appears two lines earlier: > + aq_nic.o \ > + aq_vec.o \

Re: TCP using IPv4-mapped IPv6 address as source

2017-01-11 Thread Eric Dumazet
On Wed, 2017-01-11 at 16:26 -0500, Jonathan T. Leighton wrote: > I'm sure I understand what you're saying here. There should be no flow > to terminate. rfc2765 describes a way to use IPv4-mapped IPv6 packets on the wire. What I meant by 'terminating' was that it does not tell if an end system

Re: [PATCH v2 2/2] stmmac: rename it to synopsys

2017-01-11 Thread David Miller
From: Florian Fainelli Date: Wed, 11 Jan 2017 13:14:32 -0800 > As mentioned before, although git is able to track renames, git log does > not automatically have --follow, so it can be hard for people to track > down the (new) history of the driver. > > Personally, I don't

Re: [PATCH net v2] netvsc: add rcu_read locking to netvsc callback

2017-01-11 Thread David Miller
From: Stephen Hemminger Date: Wed, 11 Jan 2017 09:16:32 -0800 > The receive callback (in tasklet context) is using RCU to get reference > to associated VF network device but this is not safe. RCU read lock > needs to be held. Found by running with full lockdep

Re: TCP using IPv4-mapped IPv6 address as source

2017-01-11 Thread Jonathan T. Leighton
On 1/11/17 3:43 PM, Eric Dumazet wrote: On Wed, 2017-01-11 at 14:59 -0500, Sowmini Varadhan wrote: I think the RFC states somewhere that you should never ever send out a v4 mapped address on the wire. Can you point the exact RFC ? https://tools.ietf.org/html/rfc2765 seems to allow just

[PATCH] [net] net/mlx5e: fix another -Wmaybe-uninitialized warning

2017-01-11 Thread Arnd Bergmann
As found by Olof's build bot, today's mainline kernel gained a harmless warning about a potential uninitalied variable reference: drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function 'parse_tc_fdb_actions': drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:769:13: warning: 'out_dev' may

Re: [PATCH net-next] net: thunderx: Fix error return code in nicvf_open()

2017-01-11 Thread David Miller
From: Wei Yongjun Date: Wed, 11 Jan 2017 16:32:51 + > From: Wei Yongjun > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 712c31853440 ("net: thunderx: Program

Re: [PATCH v2 2/2] stmmac: rename it to synopsys

2017-01-11 Thread Florian Fainelli
On 01/10/2017 06:52 AM, Joao Pinto wrote: > This patch renames stmicro/stmmac to synopsys/ since it is a standard > ethernet software package regarding synopsys ethernet controllers, supporting > the majority of Synopsys Ethernet IPs. The config IDs remain the same, for > retro-compatibility, only

Re: [PATCH net-next v2] net: thunderx: Make hfunc variable const type in nicvf_set_rxfh()

2017-01-11 Thread David Miller
From: Robert Richter Date: Wed, 11 Jan 2017 18:04:32 +0100 > From struct ethtool_ops: > > int (*set_rxfh)(struct net_device *, const u32 *indir, > const u8 *key, const u8 hfunc); > > Change function arg of hfunc to const type. > >

Re: [PATCH net-next] sfc: efx_get_phys_port_id() can be static

2017-01-11 Thread David Miller
From: Wei Yongjun Date: Wed, 11 Jan 2017 16:16:12 + > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/net/ethernet/sfc/efx.c:2337:5: warning: > symbol 'efx_get_phys_port_id' was not declared. Should it be static? > >

Re: [PATCH net] r8152: fix the sw rx checksum is unavailable

2017-01-11 Thread David Miller
From: Hayes Wang Date: Wed, 11 Jan 2017 16:25:34 +0800 > Fix the hw rx checksum is always enabled, and the user couldn't switch > it to sw rx checksum. > > Note that the RTL_VER_01 only support sw rx checksum only. Besides, > the hw rx checksum for RTL_VER_02 is disabled

Re: [PATCH v2] vxlan: Set ports in flow key when doing route lookups

2017-01-11 Thread David Miller
From: Martynas Pumputis Date: Wed, 11 Jan 2017 15:18:53 + > Otherwise, a xfrm policy with sport/dport being set cannot be matched. > > Signed-off-by: Martynas Pumputis > --- > Changes in v2: > - Set the source port in the flow key. Applied,

[PATCH net-next 2/3] net: mdio-gpio: Convert to use gpiod functions where possible

2017-01-11 Thread Florian Fainelli
From: Guenter Roeck Using gpiod functions lets us use functionality which is not available with gpio functions. There is no gpiod function to match devm_gpio_request_one, so leave it in place and use gpio_to_desc() to convert absolute pin numbers to gpio descriptors.

[PATCH net-next 0/3] net: mdio-gpio: Use modern GPIO helpers

2017-01-11 Thread Florian Fainelli
Hi David, This patch series modernizes the mdio-gpio and makes it switch to the latest and greatest API for manipulating GPIO lines, thus allowing some simplifications in the driver. Thanks! Guenter Roeck (3): net: mdio-gpio: Use devm_gpio_request_one instead of devm_gpio_request net:

[PATCH net-next 3/3] net: mdio-gpio: Use gpio subsystem to handle low-active pins

2017-01-11 Thread Florian Fainelli
From: Guenter Roeck gpiod functions support handling low-active pins, so we can move thos code out of this driver into the gpio subsystem and simplify the code a bit. Signed-off-by: Guenter Roeck Signed-off-by: Florian Fainelli ---

[PATCH net-next 1/3] net: mdio-gpio: Use devm_gpio_request_one instead of devm_gpio_request

2017-01-11 Thread Florian Fainelli
From: Guenter Roeck Using devm_gpio_request_one lets us request gpio pins with initial state in one go. Signed-off-by: Guenter Roeck Signed-off-by: Florian Fainelli --- drivers/net/phy/mdio-gpio.c | 13 ++--- 1 file

Re: TCP using IPv4-mapped IPv6 address as source

2017-01-11 Thread Sowmini Varadhan
On (01/11/17 12:43), Eric Dumazet wrote: > > On Wed, 2017-01-11 at 14:59 -0500, Sowmini Varadhan wrote: > > > I think the RFC states somewhere that you should never ever > > send out a v4 mapped address on the wire. > > Can you point the exact RFC ? > > https://tools.ietf.org/html/rfc2765

Re: TCP using IPv4-mapped IPv6 address as source

2017-01-11 Thread Eric Dumazet
On Wed, 2017-01-11 at 14:59 -0500, Sowmini Varadhan wrote: > I think the RFC states somewhere that you should never ever > send out a v4 mapped address on the wire. Can you point the exact RFC ? https://tools.ietf.org/html/rfc2765 seems to allow just that. Jonathan issue is about terminating

Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better

2017-01-11 Thread Arnd Bergmann
On Wednesday, January 11, 2017 4:06:17 PM CET Johannes Berg wrote: > > Applied. Also fixed the typo in the subject :) Thanks! Unfortunately I now got another warning for the same function, and though I would have expected the patch to fix it, that did not work: In file included from

[PATCH 5/6 net-next] inet: split inet_csk_get_port into two functions

2017-01-11 Thread Josef Bacik
inet_csk_get_port does two different things, it either scans for an open port, or it tries to see if the specified port is available for use. Since these two operations have different rules and are basically independent lets split them into two different functions to make them both more readable.

[PATCH 3/6 net-next] inet: kill smallest_size and smallest_port

2017-01-11 Thread Josef Bacik
In inet_csk_get_port we seem to be using smallest_port to figure out where the best place to look for a SO_REUSEPORT sk that matches with an existing set of SO_REUSEPORT's. However if we get to the logic if (smallest_size != -1) { port = smallest_port; goto have_port; } we will

[PATCH 2/6 net-next] inet: drop ->bind_conflict

2017-01-11 Thread Josef Bacik
The only difference between inet6_csk_bind_conflict and inet_csk_bind_conflict is how they check the rcv_saddr, so delete this call back and simply change inet_csk_bind_conflict to call inet_rcv_saddr_equal. Signed-off-by: Josef Bacik --- include/net/inet6_connection_sock.h | 5

[PATCH 6/6 net-next] inet: reset tb->fastreuseport when adding a reuseport sk

2017-01-11 Thread Josef Bacik
If we have non reuseport sockets on a tb we will set tb->fastreuseport to 0 and never set it again. Which means that in the future if we end up adding a bunch of reuseport sk's to that tb we'll have to do the expensive scan every time. Instead add the ipv4/ipv6 saddr fields to the bind bucket, as

[PATCH 4/6 net-next] inet: don't check for bind conflicts twice when searching for a port

2017-01-11 Thread Josef Bacik
This is just wasted time, we've already found a tb that doesn't have a bind conflict, and we don't drop the head lock so scanning again isn't going to give us a different answer. Instead move the tb->reuse setting logic outside of the found_tb path and put it in the success: path. Then make it

[PATCH 1/6 net-next] inet: collapse ipv4/v6 rcv_saddr_equal functions into one

2017-01-11 Thread Josef Bacik
We pass these per-protocol equal functions around in various places, but we can just have one function that checks the sk->sk_family and then do the right comparison function. I've also changed the ipv4 version to not cast to inet_sock since it is unneeded. Signed-off-by: Josef Bacik

Re: net: ti: cpsw-phy-sel: RGMII is not working on AM335x

2017-01-11 Thread Alex
Hi Teresa On 01/11/2017 07:57 AM, Teresa Remmet wrote: The phy we use is a KSZ9021. And yes we add delays to the phy, as you can see. When looking to the dts documentation I probably need to set the phy-mode to "rgmii-id" instead, as the phy is providing the delays. Before the change I

[PATCH 0/6 net-next][V3] Rework inet_csk_get_port

2017-01-11 Thread Josef Bacik
Sorry the holidays delayed this a bit. I've made the changes requested and I also sat down and wrote a reproducer so everybody could see what was happening. Without my patches my reproducer takes about 50 seconds to run on my 48 CPU devel box. With my patches it takes 8 seconds. V2->V3:

Re: [PATCH net-next 0/2] Move hwmon support out of switch and into PHYs.

2017-01-11 Thread Guenter Roeck
On Wed, Jan 11, 2017 at 08:16:43PM +0100, Andrew Lunn wrote: > > This makes it kind > > of a circular argument (not that the dsa hwmon driver supports the > > new API anyway, but still). > > Actually, the code i posted does. I didn't just move it, i re-wrote it > to use

Re: TCP using IPv4-mapped IPv6 address as source

2017-01-11 Thread Sowmini Varadhan
On (01/11/17 14:48), Jonathan T. Leighton wrote: > > I would say that an IPv6 socket binds to an IPv4-mapped IPv6 > address, but yes - using it to connect to an IPv6 address would be > an application bug. It also think that having connect() spend 2 > minutes sending packets containing an illegal

Re: [PATCH net-next 5/6] bnxt_en: Pass RoCE app priority to firmware.

2017-01-11 Thread Michael Chan
On Wed, Jan 11, 2017 at 10:34 AM, Doug Ledford wrote: > On Wed, 2017-01-11 at 09:17 -0800, Michael Chan wrote: >> On Wed, Jan 11, 2017 at 7:46 AM, David Miller >> wrote: >> > >> > From: Michael Chan >> > Date: Tue, 10 Jan 2017

Re: TCP using IPv4-mapped IPv6 address as source

2017-01-11 Thread Jonathan T. Leighton
On 1/11/17 1:31 PM, Eric Dumazet wrote: On Wed, 2017-01-11 at 12:34 -0500, Jonathan T. Leighton wrote: On 1/11/17 11:20 AM, Eric Dumazet wrote: On Thu, 2017-01-05 at 16:25 -0500, Jonathan T. Leighton wrote: I've observed TCP using an IPv4-mapped IPv6 address as the source address, which I

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-11 Thread Michal Hocko
On Wed 11-01-17 20:45:25, Michal Hocko wrote: > On Wed 11-01-17 09:37:06, Chas Williams wrote: > > On Mon, 2017-01-09 at 18:20 +0100, Andrey Konovalov wrote: > > > Hi! > > > > > > I've got the following error report while running the syzkaller fuzzer. > > > > > > On commit

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-11 Thread Michal Hocko
On Wed 11-01-17 09:37:06, Chas Williams wrote: > On Mon, 2017-01-09 at 18:20 +0100, Andrey Konovalov wrote: > > Hi! > > > > I've got the following error report while running the syzkaller fuzzer. > > > > On commit a121103c922847ba5010819a3f250f1f7fc84ab8 (4.10-rc3). > > > > A reproducer is

Re: [PATCH net-next 0/2] Move hwmon support out of switch and into PHYs.

2017-01-11 Thread Andrew Lunn
> Are not the *_alarm attributes specifically designed to report such > things? See Documentation/hwmon/sysfs-interface Hi Florian Yes it is, and at the moment, userspace needs to poll it. No need for in interrupt. Andrew

Re: [PATCH net-next 0/2] Move hwmon support out of switch and into PHYs.

2017-01-11 Thread Andrew Lunn
> This makes it kind > of a circular argument (not that the dsa hwmon driver supports the > new API anyway, but still). Actually, the code i posted does. I didn't just move it, i re-wrote it to use devm_hwmon_device_register_with_info(). Andrew

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-11 Thread Eric Dumazet
On Tue, 2017-01-10 at 23:47 +0100, Francois Romieu wrote: > Eric Dumazet : > > On Tue, Jan 10, 2017 at 9:35 AM, Cong Wang wrote: > > > On Mon, Jan 9, 2017 at 9:20 AM, Andrey Konovalov > > > wrote: > > > > > > The fix should

Re: [PATCH net-next 5/6] bnxt_en: Pass RoCE app priority to firmware.

2017-01-11 Thread Doug Ledford
On Wed, 2017-01-11 at 09:17 -0800, Michael Chan wrote: > On Wed, Jan 11, 2017 at 7:46 AM, David Miller > wrote: > > > > From: Michael Chan > > Date: Tue, 10 Jan 2017 20:12:38 -0500 > > > > > > > > diff --git

Re: TCP using IPv4-mapped IPv6 address as source

2017-01-11 Thread Eric Dumazet
On Wed, 2017-01-11 at 12:34 -0500, Jonathan T. Leighton wrote: > On 1/11/17 11:20 AM, Eric Dumazet wrote: > > On Thu, 2017-01-05 at 16:25 -0500, Jonathan T. Leighton wrote: > >> I've observed TCP using an IPv4-mapped IPv6 address as the source > >> address, which I believe contradicts > >>

Re: [PATCH v2 7/8] net: Rename TCA*BPF_DIGEST to ..._SHA256

2017-01-11 Thread Andy Lutomirski
On Wed, Jan 11, 2017 at 1:09 AM, Daniel Borkmann wrote: > Hi Andy, > > On 01/11/2017 04:11 AM, Andy Lutomirski wrote: >> >> On Tue, Jan 10, 2017 at 4:50 PM, Daniel Borkmann >> wrote: >>> >>> On 01/11/2017 12:24 AM, Andy Lutomirski wrote:

Re: [Linux-c6x-dev] [PATCH v2 7/7] uapi: export all headers under uapi directories

2017-01-11 Thread Mark Salter
On Fri, 2017-01-06 at 10:43 +0100, Nicolas Dichtel wrote: > Regularly, when a new header is created in include/uapi/, the developer > forgets to add it in the corresponding Kbuild file. This error is usually > detected after the release is out. > > In fact, all headers under uapi directories

Re: [PATCH v2 8/8] crypto/testmgr: Allocate only the required output size for hash tests

2017-01-11 Thread Andy Lutomirski
On Wed, Jan 11, 2017 at 7:13 AM, David Laight wrote: > From: Andy Lutomirski >> Sent: 10 January 2017 23:25 >> There are some hashes (e.g. sha224) that have some internal trickery >> to make sure that only the correct number of output bytes are >> generated. If something

Re: [PATCH net-next 0/2] Move hwmon support out of switch and into PHYs.

2017-01-11 Thread Guenter Roeck
On Wed, Jan 11, 2017 at 06:37:41PM +0100, Andrew Lunn wrote: > > However, at the moment, there is no code to enable interrupts for > temperature alarms. I also don't see any need to add such code, since > there is nowhere in HWMON to actively report such an alarm condition. > That is not

  1   2   3   >