Re: [PATCHv3 net-next 5/7] net: add confirm_neigh method to dst_ops

2017-01-31 Thread Steffen Klassert
On Tue, Jan 31, 2017 at 11:57:05PM +0200, Julian Anastasov wrote: > > static unsigned int ip6_blackhole_mtu(const struct dst_entry *dst) > diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c > index 177e208..c010ee0 100644 > --- a/net/xfrm/xfrm_policy.c > +++ b/net/xfrm/xfrm_policy.c >

[PATCH net-next v2 5/5] bridge: vlan dst_metadata hooks in ingress and egress paths

2017-01-31 Thread Roopa Prabhu
From: Roopa Prabhu - ingress hook: - if port is a tunnel port, use tunnel info in attached dst_metadata to map it to a local vlan - egress hook: - if port is a tunnel port, use tunnel info attached to vlan to set dst_metadata on the skb CC: Nikolay

[PATCH net-next v2 2/5] vxlan: support fdb and learning in COLLECT_METADATA mode

2017-01-31 Thread Roopa Prabhu
From: Roopa Prabhu Vxlan COLLECT_METADATA mode today solves the per-vni netdev scalability problem in l3 networks. It expects all forwarding information to be present in dst_metadata. This patch series enhances collect metadata mode to include the case where only vni

[PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-01-31 Thread Roopa Prabhu
From: Roopa Prabhu High level summary: lwt and dst_metadata have enabled vxlan l3 deployments to use a single vxlan netdev for multiple vnis eliminating the scalability problem with using a single vxlan netdev per vni. This series tries to do the same for vxlan netdevs

[PATCH net-next v2 3/5] bridge: uapi: add per vlan tunnel info

2017-01-31 Thread Roopa Prabhu
From: Roopa Prabhu New nested netlink attribute to associate tunnel info per vlan. This is used by bridge driver to send tunnel metadata to bridge ports in vlan tunnel mode. This patch also adds new per port flag IFLA_BRPORT_VLAN_TUNNEL to enable vlan tunnel mode. off

[PATCH net-next v2 4/5] bridge: per vlan dst_metadata netlink support

2017-01-31 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to attach per vlan tunnel info dst metadata. This enables bridge driver to map vlan to tunnel_info at ingress and egress. It uses the kernel dst_metadata infrastructure. The initial use case is vlan to vni bridging, but the

[PATCH net-next v2 1/5] ip_tunnels: new IP_TUNNEL_INFO_BRIDGE flag for ip_tunnel_info mode

2017-01-31 Thread Roopa Prabhu
From: Roopa Prabhu New ip_tunnel_info flag to represent bridged tunnel metadata. Used by bridge driver later in the series to pass per vlan dst metadata to bridge ports. Signed-off-by: Roopa Prabhu --- include/net/ip_tunnels.h |1 + 1

[PATCH net v2 1/2] mlx4: Fix memory leak after mlx4_en_update_priv()

2017-01-31 Thread Martin KaFai Lau
In mlx4_en_update_priv(), dst->tx_ring[t] and dst->tx_cq[t] are over-written by src->tx_ring[t] and src->tx_cq[t] without first calling kfree. One of the reproducible code paths is by doing 'ethtool -L'. The fix is to do the kfree in mlx4_en_free_resources(). Here is the kmemleak report:

[PATCH net v2 2/2] mlx4: xdp_prog becomes inactive after ethtool '-L' or '-G'

2017-01-31 Thread Martin KaFai Lau
After calling mlx4_en_try_alloc_resources (e.g. by changing the number of rx-queues with ethtool -L), the existing xdp_prog becomes inactive. The bug is that the xdp_prog ptr has not been carried over from the old rx-queues to the new rx-queues Fixes: 47a38e155037 ("net/mlx4_en: add support for

[PATCH net v2 0/2] mlx4: Misc bug fixes after reinitializing queues

2017-01-31 Thread Martin KaFai Lau
This patchset fixes misc bugs after reinitializing queues (e.g. by ethtool -L). v2: * Add another fix to mem leak in tx_ring[t] and tx_cq[t] * In mlx4_en_try_alloc_resources(), move all xdp_prog logic after calling mlx4_en_alloc_resources() Martin KaFai Lau (2): mlx4: Fix memory leak after

Re: [PATCH net-next 00/10] bnxt_en: Add XDP support.

2017-01-31 Thread Alexei Starovoitov
On Tue, Jan 31, 2017 at 9:33 PM, Andy Gospodarek wrote: > On Tue, Jan 31, 2017 at 10:36 AM, Andy Gospodarek wrote: >> On Mon, Jan 30, 2017 at 08:47:47PM -0800, Alexei Starovoitov wrote: >>> On Mon, Jan 30, 2017 at 08:49:25PM -0500, Michael Chan wrote: >>>

RE: [PATCH net-next 1/2] net: Introduce ife encapsulation module

2017-01-31 Thread Yotam Gigi
eX3UPXYxrgYqzc%3D=0 -O ~/bin/make.cross >chmod +x ~/bin/make.cross ># save the attached .config to linux build tree >make.cross ARCH=alpha > >Note: the linux-review/Yotam-Gigi/Extract-IFE-logic-to-module/20170131-222757 >HEAD 236a17de4759e7d4d2927d4a

Re: [PATCH net] mlx4: xdp_prog becomes inactive after ethtool '-L' or '-G'

2017-01-31 Thread Martin KaFai Lau
On Mon, Jan 30, 2017 at 07:18:28PM +0200, Tariq Toukan wrote: > Hi Martin, > > Thanks for your patch. > > It looks good to me, in general. > I just have one small comment below. Thanks for your feedback and sorry for the delay. > > On 28/01/2017 9:40 AM, Martin KaFai Lau wrote: > > If the

Re: [PATCH net v2] be2net: fix initial MAC setting

2017-01-31 Thread Sriharsha Basavapatna
On Wed, Feb 1, 2017 at 12:31 AM, Ivan Vecera wrote: > Recent commit 34393529163a ("be2net: fix MAC addr setting on privileged > BE3 VFs") allows privileged BE3 VFs to set its MAC address during > initialization. Although the initial MAC for such VFs is already > programmed by parent

Re: [PATCH 4.10-rc3 12/13] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Kalle Valo
Russell King writes: > Fix these errors reported by the 0-day builder by replacing the > linux/export.h include with linux/module.h. > > In file included from include/linux/platform_device.h:14:0, > from drivers/net/wireless/ath/ath5k/ahb.c:20: >

Re: [PATCH net-next 00/10] bnxt_en: Add XDP support.

2017-01-31 Thread Andy Gospodarek
On Tue, Jan 31, 2017 at 10:36 AM, Andy Gospodarek wrote: > On Mon, Jan 30, 2017 at 08:47:47PM -0800, Alexei Starovoitov wrote: >> On Mon, Jan 30, 2017 at 08:49:25PM -0500, Michael Chan wrote: >> > The first 8 patches refactor the code (rx/tx code paths and ring logic) >> > and

net: macb: lack of statistics - tx_dropped

2017-01-31 Thread Hyung Jin Jung
macb doesn't maintain statistics of dropped packets when transmitting. so that it's not possible to detect packet loss in user space (sysfs, procfs...) macb_start_xmit should to increase tx_dropped in case of exception - buffer full, dma mapping fail Davy

Re: [RFC PATCH 1/2] af_packet: direct dma for packet ineterface

2017-01-31 Thread John Fastabend
On 17-01-30 05:31 PM, Willem de Bruijn wrote: V3 header formats added bulk polling via socket calls and timers used in the polling interface to return every n milliseconds. Currently, I don't see any way to support this in hardware because we can't know if the hardware is in

Re: [RFC PATCH 0/2] rx zero copy interface for af_packet

2017-01-31 Thread John Fastabend
On 17-01-31 11:39 AM, tndave wrote: > > > On 01/27/2017 01:33 PM, John Fastabend wrote: >> This is an experimental implementation of rx zero copy for af_packet. >> Its a bit rough and likely has errors but the plan is to clean it up >> over the next few months. >> >> And seeing I said I would

Re: [RFC PATCH 1/2] af_packet: direct dma for packet ineterface

2017-01-31 Thread John Fastabend
[...] >>> The ndo operations and new socket option PACKET_RX_DIRECT work by giving a queue_index to run the direct dma operations over. Once setsockopt returns successfully the indicated queue is mapped directly to the requesting application and can not be used for

Re: [RFC PATCH 2/2] ixgbe: add af_packet direct copy support

2017-01-31 Thread John Fastabend
On 17-01-30 06:53 PM, Alexei Starovoitov wrote: > On 1/27/17 1:34 PM, John Fastabend wrote: >> +h2 = page_address(rx_buffer->page) + rx_buffer->page_offset - hdrlen; >> +eth = page_address(rx_buffer->page) + rx_buffer->page_offset, > > I don't think it compiles ;) Well that is what I get

Re: [RFC PATCH 0/2] rx zero copy interface for af_packet

2017-01-31 Thread John Fastabend
On 17-01-31 08:30 AM, Sowmini Varadhan wrote: > On (01/27/17 13:33), John Fastabend wrote: >> >> This is an experimental implementation of rx zero copy for af_packet. >> Its a bit rough and likely has errors but the plan is to clean it up >> over the next few months. >> >> And seeing I said I

Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX

2017-01-31 Thread David Miller
From: Corentin Labbe Date: Tue, 31 Jan 2017 10:11:48 +0100 > The stmmac driver run TX completion under NAPI but without checking > the work done by the TX completion function. The current behavior is correct and completely intentional. A driver should _never_ account

Re: [PATCH net-next 2/5] vxlan: support fdb and learning in COLLECT_METADATA mode

2017-01-31 Thread Roopa Prabhu
On 1/31/17, 3:37 PM, Jonathan Toppins wrote: > On 01/31/2017 12:57 AM, Roopa Prabhu wrote: [snip] >> >> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c >> index 19b1653..b80c405 100644 >> --- a/drivers/net/vxlan.c >> +++ b/drivers/net/vxlan.c >> @@ -57,6 +57,8 @@ >> >> static const u8

Re: [PATCHv2 net-next 1/2] net: dsa: mv88e6xxx: Workaround missing PHY ID on mv88e6390

2017-01-31 Thread Florian Fainelli
On 01/31/2017 06:40 PM, Andrew Lunn wrote: > The internal PHYs of the mv88e6390 do not have a model ID. Trap any > calls to the ID register, and if it is zero, return the ID for the > mv88e6390. The Marvell PHY driver can then bind to this ID. > > Signed-off-by: Andrew Lunn

Re: [PATCHv2 net-next 1/2] net: dsa: mv88e6xxx: Workaround missing PHY ID on mv88e6390

2017-01-31 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > The internal PHYs of the mv88e6390 do not have a model ID. Trap any > calls to the ID register, and if it is zero, return the ID for the > mv88e6390. The Marvell PHY driver can then bind to this ID. > > Signed-off-by: Andrew Lunn

[PATCH net] net: phy: Fix lack of reference count on PHY driver

2017-01-31 Thread Florian Fainelli
From: Mao Wenan There is currently no reference count being held on the PHY driver, which makes it possible to remove the PHY driver module while the PHY state machine is running and polling the PHY. This could cause crashes similar to this one to show up: [ 43.361162]

Re: [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include

2017-01-31 Thread Florian Fainelli
On 01/31/2017 11:17 AM, Russell King - ARM Linux wrote: > Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an > unnecessary dependency for quite a large amount of the kernel. There's > very little which actually requires definitions from phy.h in net/dsa.h > - the include itself

[PATCHv2 net-next 0/2] Work around missing PHY prodcut ID in mv88e6390

2017-01-31 Thread Andrew Lunn
The internal PHYs of the MV88E6390 have a Marvell OUI, but the product ID is zero. Work around this by trapping reads to the ID, and if it is zero, return the MV88E6390 family ID. v2: Move the workaround into the central mdio read function. Enable the temperature sensor, even though it does

[PATCHv2 net-next 2/2] net: phy: Marvell: Add mv88e6390 internal PHY

2017-01-31 Thread Andrew Lunn
The mv88e6390 Ethernet switch has internal PHYs. These PHYs don't have an model ID in the ID2 register. So the MDIO driver in the switch intercepts reads to this register, and returns the switch family ID. Extend the Marvell PHY driver by including this ID, and treat the PHY as a 88E1540.

[PATCHv2 net-next 1/2] net: dsa: mv88e6xxx: Workaround missing PHY ID on mv88e6390

2017-01-31 Thread Andrew Lunn
The internal PHYs of the mv88e6390 do not have a model ID. Trap any calls to the ID register, and if it is zero, return the ID for the mv88e6390. The Marvell PHY driver can then bind to this ID. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 8 1 file

linux-next: manual merge of the net-next tree with the char-misc.current tree

2017-01-31 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/hyperv/netvsc.c between commit: 433e19cf33d3 ("Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()") from the char-misc.current tree and commits: 0b307ebd6834 ("netvsc: remove no longer needed

[PATCH net-next] net: ipv6: add NLM_F_APPEND in notifications when applicable

2017-01-31 Thread David Ahern
IPv6 does not set the NLM_F_APPEND flag in notifications to signal that a NEWROUTE is an append versus a new route or a replaced one. Add the flag if the request has it. Signed-off-by: David Ahern --- sending this one outside of the multipath patch set since it has

Re: [PATCH] net: fix ndo_features_check/ndo_fix_features comment ordering

2017-01-31 Thread Eric Dumazet
On Tue, 2017-01-31 at 16:03 -0800, Dimitris Michailidis wrote: > Commit cdba756f5803a2 ("net: move ndo_features_check() close to > ndo_start_xmit()") inadvertently moved the doc comment for > .ndo_fix_features instead of .ndo_features_check. Fix the comment > ordering. > > Fixes: cdba756f5803a2

[PATCH] net: fix ndo_features_check/ndo_fix_features comment ordering

2017-01-31 Thread Dimitris Michailidis
Commit cdba756f5803a2 ("net: move ndo_features_check() close to ndo_start_xmit()") inadvertently moved the doc comment for .ndo_fix_features instead of .ndo_features_check. Fix the comment ordering. Fixes: cdba756f5803a2 ("net: move ndo_features_check() close to ndo_start_xmit()") Signed-off-by:

Re: [PATCH net-next 1/2] net: Introduce ife encapsulation module

2017-01-31 Thread kbuild test robot
Hi Yotam, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Yotam-Gigi/Extract-IFE-logic-to-module/20170131-222757 config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget

RE: Outlook Web Access

2017-01-31 Thread Anita Patrick
From: Anita Patrick Sent: Tuesday, January 31, 2017 12:50 PM Subject: Outlook Web Access Dear E-mail User Please Log on to OutlookWeb Access to update your outlook account to the new secured version 2017. Thank You

Re: [PATCH net-next 2/5] vxlan: support fdb and learning in COLLECT_METADATA mode

2017-01-31 Thread Jonathan Toppins
On 01/31/2017 12:57 AM, Roopa Prabhu wrote: > From: Roopa Prabhu > > Vxlan COLLECT_METADATA mode today solves the per-vni netdev > scalability problem in l3 networks. It expects all forwarding > information to be present in dst_metadata. This patch series > enhances

Re: [PATCH V3 net-next 02/14] net/ena: fix error handling when probe fails

2017-01-31 Thread Netanel Belgazal
Hi, You are right. I'll remove this patch. Regards, Netanel On 01/28/2017 01:33 AM, Lino Sanfilippo wrote: Hi, On 26.01.2017 23:18, Netanel Belgazal wrote: When driver fails in probe, it will release all resources, including adapter. In case of probe failure, ena_remove should not try to

Re: [PATCH] net: phy: broadcom: rehook BCM54612E specific init

2017-01-31 Thread Florian Fainelli
On 01/31/2017 01:54 PM, Rafał Miłecki wrote: > From: Rafał Miłecki > > This extra BCM54612E code in PHY driver isn't really aneg specific. Even > without it aneg works OK but the problem is no packets pass through PHY. > > Moreover putting this code inside config_aneg callback

Re: [PATCH] r8152: Allocate interrupt buffer as part of struct r8152

2017-01-31 Thread Guenter Roeck
On Tue, Jan 31, 2017 at 02:53:47PM -0500, Alan Stern wrote: > On Tue, 31 Jan 2017, Guenter Roeck wrote: > > > When unloading the r8152 driver using the 'unbind' sysfs attribute > > in a system with KASAN enabled, the following error message is seen > > on a regular basis. > > ... > > > The

Re: [PATCH] r8152: Allocate interrupt buffer as part of struct r8152

2017-01-31 Thread Guenter Roeck
On Tue, Jan 31, 2017 at 11:53:31AM -0800, Eric Dumazet wrote: > On Tue, 2017-01-31 at 11:06 -0800, Guenter Roeck wrote: > > When unloading the r8152 driver using the 'unbind' sysfs attribute > > in a system with KASAN enabled, the following error message is seen > > on a regular basis. > > > >

Re: [PATCH net] bpf: expose netns inode to bpf programs

2017-01-31 Thread David Ahern
On 1/25/17 8:27 PM, Alexei Starovoitov wrote: > in cases where bpf programs are looking at sockets and packets > that belong to different netns, it could be useful to read netns inode, > so that programs can make intelligent decisions. > For example to disallow raw sockets in all non-init netns

Re: [PATCH net] mlx4: xdp_prog becomes inactive after ethtool '-L' or '-G'

2017-01-31 Thread Martin KaFai Lau
On Tue, Jan 31, 2017 at 01:11:40PM -0500, David Miller wrote: > From: Tariq Toukan > Date: Mon, 30 Jan 2017 19:18:28 +0200 > > > It looks good to me, in general. > > I just have one small comment below. > > Martin, please address Tariq's feedback. Sorry for the delay. I am

Re: [Intel-wired-lan] [PATCH] net: intel: e1000e: use new api ethtool_{get|set}_link_ksettings

2017-01-31 Thread Philippe Reynes
Hi Sasha, On 1/31/17, Neftin, Sasha wrote: > > Philippe, > > We will look into and try test this patch. I would like ask question. I > see that this thread has been started from implementation for e1000 > code. Why do you decide shift implementation to e1000e? I've just

[PATCHv3 net-next 6/7] net: use dst_confirm_neigh for UDP, RAW, ICMP, L2TP

2017-01-31 Thread Julian Anastasov
When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. The datagram protocols can use MSG_CONFIRM to confirm the neighbour. When used with MSG_PROBE we do not reach the code where neighbour is confirmed, so we have to do the same slow

[PATCHv3 net-next 4/7] tcp: replace dst_confirm with sk_dst_confirm

2017-01-31 Thread Julian Anastasov
When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. Use the new sk_dst_confirm() helper to propagate the indication from received packets to sock_confirm_neigh(). Reported-by: YueHaibing Reported-by: YueHaibing

[PATCHv3 net-next 3/7] sctp: add dst_pending_confirm flag

2017-01-31 Thread Julian Anastasov
Add new transport flag to allow sockets to confirm neighbour. When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. The flag is propagated from transport to every packet. It is reset when cached dst is reset. Reported-by: YueHaibing

[PATCHv3 net-next 5/7] net: add confirm_neigh method to dst_ops

2017-01-31 Thread Julian Anastasov
Add confirm_neigh method to dst_ops and use it from IPv4 and IPv6 to lookup and confirm the neighbour. Its usage via the new helper dst_confirm_neigh() should be restricted to MSG_PROBE users for performance reasons. Signed-off-by: Julian Anastasov Acked-by: Eric Dumazet

[PATCHv3 net-next 1/7] sock: add sk_dst_pending_confirm flag

2017-01-31 Thread Julian Anastasov
Add new sock flag to allow sockets to confirm neighbour. When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. As not all call paths lock the socket use full word for the flag. Add sk_dst_confirm as replacement for dst_confirm when

[PATCHv3 net-next 0/7] net: dst_confirm replacement

2017-01-31 Thread Julian Anastasov
This patchset addresses the problem of neighbour confirmation where received replies from one nexthop can cause confirmation of different nexthop when using the same dst. Thanks to YueHaibing for tracking the dst->pending_confirm problem. Sockets can obtain

[PATCHv3 net-next 2/7] net: add dst_pending_confirm flag to skbuff

2017-01-31 Thread Julian Anastasov
Add new skbuff flag to allow protocols to confirm neighbour. When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. Add sock_confirm_neigh() helper to confirm the neighbour and use it for IPv4, IPv6 and VRF before dst_neigh_output.

[PATCHv3 net-next 7/7] net: pending_confirm is not used anymore

2017-01-31 Thread Julian Anastasov
When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. As last step, we can remove the pending_confirm flag. Reported-by: YueHaibing Fixes: 5110effee8fd ("net: Do delayed neigh confirmation.") Fixes: f2bb4bedf35d

Re: [PATCH] rtnetlink: Handle IFLA_MASTER parameter when processing rtnl_newlink

2017-01-31 Thread David Ahern
On 1/30/17 4:23 PM, Theuns Verwoerd wrote: > Allow a master interface to be specified as one of the parameters when > creating a new interface via rtnl_newlink. Previously this would > require invoking interface creation, waiting for it to complete, and > then separately binding that new

[PATCH] net: phy: broadcom: rehook BCM54612E specific init

2017-01-31 Thread Rafał Miłecki
From: Rafał Miłecki This extra BCM54612E code in PHY driver isn't really aneg specific. Even without it aneg works OK but the problem is no packets pass through PHY. Moreover putting this code inside config_aneg callback didn't allow resuming PHY correctly. When driver called

Re: [PATCHv2 RFC net-next 0/7] net: dst_confirm replacement

2017-01-31 Thread Julian Anastasov
Hello, On Mon, 30 Jan 2017, David Miller wrote: > From: Julian Anastasov > > > > So, the following solution is to avoid using > > dst->pending_confirm. > > For the most part this series looks good to me, nice work. OK, I'm posting v3 after removing the RFC

[net-next 7/8] net/mlx5e: XDP Tx, no inline copy on ConnectX-5

2017-01-31 Thread Saeed Mahameed
ConnectX-5 and later HW generations will report min inline mode == MLX5_INLINE_MODE_NONE, which means driver is not required to copy packet headers to inline fields of TX WQE. Avoid copy to inline segment in XDP TX routine when HW inline mode doesn't require it. This will improve CPU utilization

[net-next 8/8] net/mlx5e: Bring back bfreg uar map dedicated pointer

2017-01-31 Thread Saeed Mahameed
4K Uar series modified the mlx5e driver to use the new bfreg API, and mistakenly removed the sq->uar_map iomem data path dedicated pointer, which was meant to be read from xmit path for cache locality utilization. Fix that by returning that pointer to the SQ struct. Fixes: 7309cb4ad71e

[net-next 4/8] net/mlx5: TX WQE update

2017-01-31 Thread Saeed Mahameed
Add new TX WQE fields for Connect-X5 vlan insertion support, type and vlan_tci, when type = MLX5_ETH_WQE_INSERT_VLAN the HW will insert the vlan and prio fields (vlan_tci) to the packet. Those bits and the inline header fields are mutually exclusive, and valid only when: MLX5_CAP_ETH(mdev,

[net-next 5/8] net/mlx5e: Calc vlan_tag_present only once on xmit

2017-01-31 Thread Saeed Mahameed
Cache skb_vlan_tag_present(skb) and pass it wherever needed in xmit routines. Signed-off-by: Saeed Mahameed Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 22 -- 1 file changed, 12 insertions(+), 10

[PATCH net-next] liquidio: fix for iq and droq cnts going negative

2017-01-31 Thread Felix Manlunas
From: Satanand Burla Flush the mmio writes before releasing spin locks. if the maintained counts get too high > 2M force writeback of the counts to clear them Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[net-next 3/8] net/mlx5e: Lower bound MPWRQ stride by HCA cacheline

2017-01-31 Thread Saeed Mahameed
From: Daniel Jurgens MPWRQ stride should be at least the HCA cacheline, the current default is 64B which will cause data integrity issues in case HCA_CAP.cach_line_128byte capability is set. Signed-off-by: Daniel Jurgens Signed-off-by: Saeed Mahameed

[net-next 6/8] net/mlx5e: Tx, no inline copy on ConnectX-5

2017-01-31 Thread Saeed Mahameed
ConnectX-5 and later HW generations will report min inline mode == MLX5_INLINE_MODE_NONE, which means driver is not required to copy packet headers to inline fields of TX WQE. When inline is not required, vlan insertion will be handled in the TX descriptor rather than copy to inline. For LSO

[pull request][net-next 0/8] Mellanox mlx5 updates 2017-01-31

2017-01-31 Thread Saeed Mahameed
Hi Dave, This pull request includes two new features and two small fixes for net-next, Details are bleow. Please pull and let me know if there's any problem. Thanks, Saeed. --- The following changes since commit 624374a56419c2d6d428c862f32cc1b20519095d: Merge branch 'bgmac-phy-init'

[net-next 2/8] net/mlx5: Configure cache line size for start and end padding

2017-01-31 Thread Saeed Mahameed
From: Daniel Jurgens There is a hardware feature that will pad the start or end of a DMA to be cache line aligned to avoid RMWs on the last cache line. The default cache line size setting for this feature is 64B. This change configures the hardware to use 128B alignment on

[net-next 1/8] net/mlx5: Fixed static checker warnings

2017-01-31 Thread Saeed Mahameed
From: Or Gerlitz For some reason, sparse doesn't like using an expression of type (!x) with a bitwise | and &. In order to mitigate that, we use a local variable. Since getting a typeof(bitfield) is incorrect, we cast such cases. This removes the following sparse

Re: [PATCH net-next 0/5] bridge: per vlan dst_metadata support

2017-01-31 Thread Roopa Prabhu
On 1/31/17, 8:41 AM, Stephen Hemminger wrote: > On Mon, 30 Jan 2017 21:57:10 -0800 > Roopa Prabhu wrote: > >> From: Roopa Prabhu >> >> High level summary: >> lwt and dst_metadata have enabled vxlan l3 deployments >> to use a single vxlan

Re: [PATCH net-next 5/6] drivers: net: xgene-v2: Add transmit and receive

2017-01-31 Thread kbuild test robot
Hi Iyappan, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Iyappan-Subramanian/drivers-net-xgene-v2-Add-RGMII-based-1G-driver/20170201-034317 config: parisc-allyesconfig (attached as .config) compiler: hppa-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1

Re: [PATCH] rtnetlink: Handle IFLA_MASTER parameter when processing rtnl_newlink

2017-01-31 Thread David Miller
From: David Ahern Date: Tue, 31 Jan 2017 13:25:32 -0700 > On 1/30/17 11:49 PM, Cong Wang wrote: >> On Mon, Jan 30, 2017 at 3:23 PM, Theuns Verwoerd >> wrote: >>> @@ -2653,6 +2653,11 @@ static int rtnl_newlink(struct sk_buff *skb,

Re: [PATCH net-next 5/6] drivers: net: xgene-v2: Add transmit and receive

2017-01-31 Thread kbuild test robot
Hi Iyappan, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Iyappan-Subramanian/drivers-net-xgene-v2-Add-RGMII-based-1G-driver/20170201-034317 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

Re: [PATCH] rtnetlink: Handle IFLA_MASTER parameter when processing rtnl_newlink

2017-01-31 Thread David Ahern
On 1/30/17 11:49 PM, Cong Wang wrote: > On Mon, Jan 30, 2017 at 3:23 PM, Theuns Verwoerd > wrote: >> @@ -2653,6 +2653,11 @@ static int rtnl_newlink(struct sk_buff *skb, struct >> nlmsghdr *nlh) >> if (err < 0) >>

Re: [PATCH net-next 5/6] drivers: net: xgene-v2: Add transmit and receive

2017-01-31 Thread Florian Fainelli
On 01/31/2017 11:03 AM, Iyappan Subramanian wrote: > This patch adds, > - Transmit > - Transmit completion poll > - Receive poll > - NAPI handler > > and enables the driver. > > Signed-off-by: Iyappan Subramanian > Signed-off-by: Keyur Chudgar

Re: [PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver

2017-01-31 Thread Florian Fainelli
On 01/31/2017 11:03 AM, Iyappan Subramanian wrote: > This patch adds, > > - probe, remove, shutdown > - open, close and stats > - create and delete ring > - request and delete irq > > Signed-off-by: Iyappan Subramanian > Signed-off-by: Keyur Chudgar

Re: [PATCH 4.10-rc3 08/13] net: emac: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Timur Tabi
On 01/31/2017 01:19 PM, Russell King wrote: drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:58:12: error: dereferencing pointer to incomplete type 'struct phy_device' Add linux/phy.h to emac-sgmii.c Signed-off-by: Russell King ---

Re: [PATCH net-next 0/6] drivers: net: xgene-v2: Add RGMII based 1G driver

2017-01-31 Thread Andrew Lunn
On Tue, Jan 31, 2017 at 11:03:15AM -0800, Iyappan Subramanian wrote: > This patch set adds support for RGMII based 1GbE hardware which uses a linked > list of DMA descriptor architecture (v2) for APM X-Gene SoCs. Hi Iyappan Should we assume there are more patches to follow adding MDIO bus

Re: [PATCH] net:phy fix driver reference count error when attach and detach phy device

2017-01-31 Thread Florian Fainelli
On 01/23/2017 01:33 AM, maowenan wrote: > > > On 2017/1/6 12:48, Florian Fainelli wrote: >> Le 01/05/17 à 19:39, maowenan a écrit : >>> >>> >>> On 2017/1/6 11:21, Florian Fainelli wrote: +Andrew, Le 01/05/17 à 18:29, maowenan a écrit : >>> @Florian Fainelli, what's your

[PATCH] net: ethernet: ti: cpsw: fix NULL pointer dereference in switch mode

2017-01-31 Thread Grygorii Strashko
In switch mode on struct cpsw_slave->ndev field will be initialized with proper value only for the one cpsw slave port, as result cpsw_get_usage_count() will generate "Unable to handle kernel NULL pointer dereference" exception when first ethernet interface is opening cpsw_ndo_open(). This issue

Re: [PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver

2017-01-31 Thread Andrew Lunn
> + phy_mode = device_get_phy_mode(dev); > + if (phy_mode < 0) { > + dev_err(dev, "Unable to get phy-connection-type\n"); > + return phy_mode; > + } > + pdata->resources.phy_mode = phy_mode; > + > + if (pdata->resources.phy_mode !=

Re: [PATCH] r8152: Allocate interrupt buffer as part of struct r8152

2017-01-31 Thread Eric Dumazet
On Tue, 2017-01-31 at 11:06 -0800, Guenter Roeck wrote: > When unloading the r8152 driver using the 'unbind' sysfs attribute > in a system with KASAN enabled, the following error message is seen > on a regular basis. > > static int alloc_all_mem(struct r8152 *tp) > @@ -1423,10 +1420,6 @@

Re: [PATCH] r8152: Allocate interrupt buffer as part of struct r8152

2017-01-31 Thread Alan Stern
On Tue, 31 Jan 2017, Guenter Roeck wrote: > When unloading the r8152 driver using the 'unbind' sysfs attribute > in a system with KASAN enabled, the following error message is seen > on a regular basis. ... > The two-byte allocation in conjunction with code analysis suggests that > the

Re: [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Anna Schumaker
Hi Russell, On 01/31/2017 02:18 PM, Russell King wrote: > Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc > code: > > net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put': > net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit

Re: [RFC PATCH 0/2] rx zero copy interface for af_packet

2017-01-31 Thread tndave
On 01/27/2017 01:33 PM, John Fastabend wrote: This is an experimental implementation of rx zero copy for af_packet. Its a bit rough and likely has errors but the plan is to clean it up over the next few months. And seeing I said I would post it in another thread a few days back here it is.

Re: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Bart Van Assche
On Tue, 2017-01-31 at 19:19 +, Russell King wrote: > drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration > of function 'try_module_get' [-Werror=implicit-function-declaration] > > Add linux/module.h to iscsi_target_login.c. > > Signed-off-by: Russell King

[PATCH 4.10-rc3 10/13] MIPS: Octeon: Remove unnecessary MODULE_*()

2017-01-31 Thread Russell King
octeon-platform.c can not be built as a module for two reasons: (a) the Makefile doesn't allow it: obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o (b) the multiple *_initcall() statements, each of which are translated to a module_init() call when attempting a module

[PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: expected declaration specifiers or '...' before string constant drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: warning: data definition has no type or storage class drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error:

[PATCH 4.10-rc3 07/13] net: mvneta: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/marvell/mvneta.c:2694:26: error: storage size of 'status' isn't known drivers/net/ethernet/marvell/mvneta.c:2695:26: error: storage size of 'changed' isn't known drivers/net/ethernet/marvell/mvneta.c:2695:9: error: variable 'changed' has initializer but incomplete type

[PATCH 4.10-rc3 04/13] net: lan78xx: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/usb/lan78xx.c:394:33: sparse: expected ; at end of declaration drivers/net/usb/lan78xx.c:394:33: sparse: Expected } at end of struct-union-enum-specifier drivers/net/usb/lan78xx.c:394:33: sparse: got interface drivers/net/usb/lan78xx.c:403:1: sparse: Expected ; at the end of type

[PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration] Add linux/module.h to iscsi_target_login.c. Signed-off-by: Russell King --- drivers/target/iscsi/iscsi_target_login.c

[PATCH 4.10-rc3 02/13] net: cgroups: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
net/core/netprio_cgroup.c:303:16: error: expected declaration specifiers or '...' before string constant MODULE_LICENSE("GPL v2"); ^~~~ Add linux/module.h to fix this. Signed-off-by: Russell King --- net/core/netprio_cgroup.c | 1 + 1

[PATCH 4.10-rc3 05/13] net: bgmac: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/broadcom/bgmac.c:1015:17: error: dereferencing pointer to incomplete type 'struct mii_bus' drivers/net/ethernet/broadcom/bgmac.c:1185:2: error: implicit declaration of function 'phy_start' [-Werror=implicit-function-declaration] drivers/net/ethernet/broadcom/bgmac.c:1198:2:

[PATCH 4.10-rc3 03/13] net: macb: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/cadence/macb.h:862:33: sparse: expected ; at end of declaration drivers/net/ethernet/cadence/macb.h:862:33: sparse: Expected } at end of struct-union-enum-specifier drivers/net/ethernet/cadence/macb.h:862:33: sparse: got phy_interface

[PATCH 4.10-rc3 08/13] net: emac: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:58:12: error: dereferencing pointer to incomplete type 'struct phy_device' Add linux/phy.h to emac-sgmii.c Signed-off-by: Russell King --- drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 1 + 1 file changed, 1

[PATCH 4.10-rc3 12/13] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
Fix these errors reported by the 0-day builder by replacing the linux/export.h include with linux/module.h. In file included from include/linux/platform_device.h:14:0, from drivers/net/wireless/ath/ath5k/ahb.c:20: include/linux/device.h:1463:1: warning: data definition has no

[PATCH 4.10-rc3 06/13] net: fman: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/freescale/fman/fman_memac.c:519:21: error: dereferencing pointer to incomplete type 'struct fixed_phy_status' Add linux/phy_fixed.h to fman_memac.c Signed-off-by: Russell King --- drivers/net/ethernet/freescale/fman/fman_memac.c | 1 + 1 file

[PATCH 4.10-rc3 13/13] net: dsa: remove unnecessary phy*.h includes

2017-01-31 Thread Russell King
Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the declaration of a couple of structures and

[PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc code: net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put': net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration of function 'module_put' [-Werror=implicit-function-declaration]

[PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include

2017-01-31 Thread Russell King - ARM Linux
Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the declaration of a couple of structures and

[PATCH net v2] be2net: fix initial MAC setting

2017-01-31 Thread Ivan Vecera
Recent commit 34393529163a ("be2net: fix MAC addr setting on privileged BE3 VFs") allows privileged BE3 VFs to set its MAC address during initialization. Although the initial MAC for such VFs is already programmed by parent PF the subsequent setting performed by VF is OK, but in certain cases

[PATCH] r8152: Allocate interrupt buffer as part of struct r8152

2017-01-31 Thread Guenter Roeck
When unloading the r8152 driver using the 'unbind' sysfs attribute in a system with KASAN enabled, the following error message is seen on a regular basis. BUG kmalloc-128 (Not tainted): Poison overwritten - INFO:

[PATCH net-next 3/6] drivers: net: xgene-v2: Add ethernet hardware configuration

2017-01-31 Thread Iyappan Subramanian
This patch adds functions to configure ethernet hardware. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/xgene-v2/enet.c | 71 drivers/net/ethernet/apm/xgene-v2/enet.h | 43

  1   2   3   >