Re: [patch] dpaa_eth: small leak on error

2017-02-17 Thread David Miller
From: Dan Carpenter Date: Thu, 16 Feb 2017 12:56:10 +0300 > This should be >= instead of > here. It means that we don't increment > the free count enough so it becomes off by one. > > Fixes: 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet") > Signed-off-by: Dan Carpenter > --- > Applies

Re: [PATCH] net: mvneta: make mvneta_eth_tool_ops static

2017-02-17 Thread David Miller
From: Jisheng Zhang Date: Thu, 16 Feb 2017 17:07:39 +0800 > The mvneta_eth_tool_ops is only used internally in mvneta driver, so > make it static. > > Signed-off-by: Jisheng Zhang Applied to net-next, thanks.

[PATCH net-next] tcp: use page_ref_inc() in tcp_sendmsg()

2017-02-17 Thread Eric Dumazet
From: Eric Dumazet sk_page_frag_refill() allocates either a compound page or an order-0 page. We can use page_ref_inc() which is slightly faster than get_page() Signed-off-by: Eric Dumazet --- net/ipv4/tcp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp.c

Re: [PATCH net-next V4 0/7] net/sched: Reflect HW offload status in classifiers

2017-02-17 Thread David Miller
From: Or Gerlitz Date: Thu, 16 Feb 2017 10:31:09 +0200 > Currently there is no way of querying whether a filter is > offloaded to HW or not when using "both" policy (where none > of skip_sw or skip_hw flags are set by user-space). > > Added two new flags, "in hw" and "not in hw" such that user s

[PATCHv2, 1/1] tcp: accommodate sequence number to a peer's shrunk receive window caused by precision loss in window scaling

2017-02-17 Thread Cui, Cheng
Prevent sending out a left-shifted sequence number from a Linux sender in response to a peer's shrunk receive-window caused by losing least significant bits in window-scaling. Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc: Patrick McHardy Signed-off-by:

Re: [PATCH][CFT] Saner error handling in skb_copy_datagram_iter() et.al.

2017-02-17 Thread Al Viro
On Fri, Feb 17, 2017 at 10:54:20AM -0500, David Miller wrote: > From: Al Viro > Date: Tue, 14 Feb 2017 01:33:06 + > > > OK... Remaining interesting question is whether it adds a noticable > > overhead. Could somebody try it on assorted benchmarks and see if > > it slows the things down? Th

Re: [PATCH] net: oki-semi: pch_gbe: use new api ethtool_{get|set}_link_ksettings

2017-02-17 Thread David Miller
From: Philippe Reynes Date: Thu, 16 Feb 2017 09:10:49 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes

Re: [PATCHv2 1/1] rds:Remove unnecessary ib_ring unalloc

2017-02-17 Thread Santosh Shilimkar
On 2/17/2017 1:16 AM, Zhu Yanjun wrote: In the function rds_ib_xmit_atomic, ib_ring is not allocated successfully. As such, it is not necessary to unalloc it. Cc: Joe Jin Cc: Junxiao Bi Signed-off-by: Zhu Yanjun --- Change from v1 to v2: fix the word errors in the short log. Looks fine. A

Re: [PATCH 1/1] tcp: accommodate sequence number to a peer's shrunk receive window caused by precision loss in window scaling

2017-02-17 Thread David Miller
From: "Cui, Cheng" Date: Fri, 17 Feb 2017 16:44:23 + > Thanks for the comment. This is the patch update. Please make the commit message proper, as it was in your initial posting, explaining what you are doing and how. Don't make it part of your dialogue with the reviewers.

Re: [PATCH 1/1] tcp: accommodate sequence number to a peer's shrunk receive window caused by precision loss in window scaling

2017-02-17 Thread Cui, Cheng
Thanks for the comment. This is the patch update. Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc: Patrick McHardy Signed-off-by: Cheng Cui --- diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 1d5331a..634146c 100644 --- a/net/ipv4/tcp_out

Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write_addr/

2017-02-17 Thread Larry Finger
On 02/17/2017 10:19 AM, Geert Uytterhoeven wrote: Hi Larry, On Fri, Feb 17, 2017 at 5:14 PM, Larry Finger wrote: On 02/17/2017 09:36 AM, Geert Uytterhoeven wrote: As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky register acronym, but a simple misspelling of "write". Signed-

Re: [net-next 06/14] ixgbe: Update driver to make use of DMA attributes in Rx path

2017-02-17 Thread Alexander Duyck
On Thu, Feb 16, 2017 at 11:27 PM, maowenan wrote: > > >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of Jeff Kirsher >> Sent: Thursday, February 16, 2017 8:51 PM >> To: da...@davemloft.net >> Cc: Alexander Duyck; netdev@vger.k

Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write_addr/

2017-02-17 Thread Geert Uytterhoeven
Hi Larry, On Fri, Feb 17, 2017 at 5:14 PM, Larry Finger wrote: > On 02/17/2017 09:36 AM, Geert Uytterhoeven wrote: >> As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky >> register acronym, but a simple misspelling of "write". >> >> Signed-off-by: Geert Uytterhoeven >> Cc: Larry

Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write_addr/

2017-02-17 Thread Larry Finger
On 02/17/2017 09:36 AM, Geert Uytterhoeven wrote: As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky register acronym, but a simple misspelling of "write". Signed-off-by: Geert Uytterhoeven Cc: Larry Finger Cc: Chaoming Li Cc: netdev@vger.kernel.org I'm not sure that it is p

Re: [PATCH v3 net] packet: Do not call fanout_release from atomic contexts

2017-02-17 Thread David Miller
From: Anoob Soman Date: Wed, 15 Feb 2017 20:25:39 + > Commit 6664498280cf ("packet: call fanout_release, while UNREGISTERING a > netdev"), unfortunately, introduced the following issues. ... > To fix the above problems, remove the call to fanout_release() under > rcu_read_lock(). Instead, ca

Re: [PATCH] net: ethernet: ti: cpsw: correct ale dev to cpsw

2017-02-17 Thread David Miller
From: Ivan Khoronzhuk Date: Wed, 15 Feb 2017 19:45:02 +0200 > The ale is a property of cpsw, so change dev to cpsw->dev, > aka pdev->dev, to be consistent. > > Signed-off-by: Ivan Khoronzhuk > --- > Based on net-next/master Applied, thanks.

Re: Autoneg off in TI cpsw driver

2017-02-17 Thread Sriram V
Hi Andrew, The following is the output of the ethtool and iplink. After turning off the autoneg - The Plugin is not detected. Let me know if this is a general behaviour or a bug in cpsw driver. root@am437xevm:/ # ethtool eth1 Settings for eth1: Supported ports: [ TP AUI BNC MII FIBRE ] Supporte

Re: [PATCH 1/1] tcp: accommodate sequence number to a peer's shrunk receive window caused by precision loss in window scaling

2017-02-17 Thread David Miller
From: "Cui, Cheng" Date: Tue, 14 Feb 2017 23:14:59 + > This updates tcp_acceptable_seq(), one of the oldest functions since 2.4.0, by > preventing sending out a left-shifted sequence number from a Linux sender in > response to a peer's shrunk receive-window caused by losing least significant

Re: [PATCH] net: nvidia: forcedeth: use new api ethtool_{get|set}_link_ksettings

2017-02-17 Thread David Miller
From: Philippe Reynes Date: Tue, 14 Feb 2017 23:36:32 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes

Re: [PATCH v2 0/4] PTP attribute handling cleanup

2017-02-17 Thread David Miller
From: Richard Cochran Date: Thu, 16 Feb 2017 21:19:29 +0100 > On Tue, Feb 14, 2017 at 10:23:30AM -0800, Dmitry Torokhov wrote: >> drivers/ptp/ptp_clock.c | 22 +++--- >> drivers/ptp/ptp_private.h | 7 +- >> drivers/ptp/ptp_sysfs.c | 167 >> ++ >

Re: [PATCH v3 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-17 Thread David Miller
From: Eric Dumazet Date: Mon, 13 Feb 2017 11:58:44 -0800 > As mentioned half a year ago, we better switch mlx4 driver to order-0 > allocations and page recycling. > > This reduces vulnerability surface thanks to better skb->truesize > tracking and provides better performance in most cases. > >

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-17 Thread David Miller
From: Eric Dumazet Date: Fri, 10 Feb 2017 04:27:58 -0800 > From: Eric Dumazet > > All rx and rx netdev interrupts are handled by respectively > by mlx4_en_rx_irq() and mlx4_en_tx_irq() which simply schedule a NAPI. > > But mlx4_eq_int() also fires a tasklet to service all items that were > que

Re: [PATCH][CFT] Saner error handling in skb_copy_datagram_iter() et.al.

2017-02-17 Thread David Miller
From: Al Viro Date: Tue, 14 Feb 2017 01:33:06 + > OK... Remaining interesting question is whether it adds a noticable > overhead. Could somebody try it on assorted benchmarks and see if > it slows the things down? The patch in question follows: That's about a 40 byte copy onto the stack f

[PATCH net-next 3/3] sfc: do not device_attach if a reset is pending

2017-02-17 Thread Edward Cree
From: Peter Dunning efx_start_all can return without initialising queues as a reset is pending. This means that when netif_device_attach is called, the kernel can start sending traffic without having an initialised TX queue to send to. This patch avoids this by not calling netif_device_attach i

[PATCH net-next 2/3] sfc: forget filters from sw table if hw replies ENOENT on removing them

2017-02-17 Thread Edward Cree
From: Bert Kenward If the hw doesn't think they exist, we should defer to its authority. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef10.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef1

[PATCH net-next 1/3] sfc: fix filter_id misinterpretation in edge case

2017-02-17 Thread Edward Cree
From: Jon Cooper On EF10, hardware filter IDs are 13 bits, but in some places we store 32-bit "full filter IDs" in which higher order bits encode the filter match-priority. This could cause a filter to have a full filter ID of 0x, which is also the value EFX_EF10_FILTER_ID_INVALID which w

[PATCH net-next 0/3] sfc: misc. fixes

2017-02-17 Thread Edward Cree
Three largely unrelated fixes to increase robustness in rare edge cases. Bert Kenward (1): sfc: forget filters from sw table if hw replies ENOENT on removing them Jon Cooper (1): sfc: fix filter_id misinterpretation in edge case Peter Dunning (1): sfc: do not device_attach if a reset i

Re: [RFC] TCP_NOTSENT_LOWAT behavior

2017-02-17 Thread Eric Dumazet
On Thu, 2017-02-16 at 23:07 -0800, Eric Dumazet wrote: > This adds a cost to fast path. tcp_sendmsg() is insane. > > We have one skb granularity (64KB) already for SO_SNDBUF, regardless of > TCP_NOTSENT_LOWAT being used or not. Note that this granularity is wanted for performance, otherwise our

[PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write_addr/

2017-02-17 Thread Geert Uytterhoeven
As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky register acronym, but a simple misspelling of "write". Signed-off-by: Geert Uytterhoeven Cc: Larry Finger Cc: Chaoming Li Cc: netdev@vger.kernel.org --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 10 +- 1 fil

Re: [PATCH net-next v2 2/2] net: mvneta: Use cacheable memory to store the rx buffer DMA address

2017-02-17 Thread Gregory CLEMENT
Hi Thomas, On ven., févr. 17 2017, Thomas Petazzoni wrote: > Does not make sense, because it's not the SW that refills the RX > descriptors with the address of the RX buffers. It's done by the HW. > > With HWBM, I believe you have no choice but to read the physical > address from the RX descr

[PATCH] vmxnet3: prevent building with 64K pages

2017-02-17 Thread Arnd Bergmann
I got a warning about broken code on ARM64 with 64K pages: drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_init': drivers/net/vmxnet3/vmxnet3_drv.c:1679:29: error: large integer implicitly truncated to unsigned type [-Werror=overflow] rq->buf_info[0][i].len = PAGE_SIZE; 'len' here

[PATCH net-next v2 4/6] net: dsa: mv88e6xxx: move VTU code to its own file

2017-02-17 Thread Vivien Didelot
Move the Global (1) VTU related code to its own file. Use this opportunity to provide a cleaner API for the VTU, by renaming a few underscore prefixed functions, split the data member of the mv88e6xxx_vtu_entry structure into membership (for 802.1q) and port state (for 802.1s) members, and add a m

[PATCH net-next v2 0/6] net: dsa: mv88e6xxx: 88E6390 ATU/VTU

2017-02-17 Thread Vivien Didelot
This series adds support to 88E6390 for the ATU (MAC address databases) and VTU (VLAN databases), as well as providing a cleaner API for both. The 6390 family of Marvell switch chip handles the ATU Move operation differently and has a different usage of the VTU Data registers. v2: remove unsused

[PATCH net-next v2 5/6] net: dsa: mv88e6xxx: add VTU ops

2017-02-17 Thread Vivien Didelot
Because there are several variant of the VTU operations and because checking for the presence of an STU is not enough, add new ops to the info structure to describe the VTU operations that a chip supports. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 58 +

[PATCH net-next v2 3/6] net: dsa: mv88e6xxx: add support for 6390 ATU Move

2017-02-17 Thread Vivien Didelot
The 6390 family of Marvell chips uses 5 bits to describe the ToPort and FromPort values of PortVec in the ATU Move operation, while older switches use 0xf. Add an atu_move_port_mask member in the info structure to describe that. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c

[PATCH net-next v2 6/6] net: dsa: mv88e6xxx: add support for 6390 VTU

2017-02-17 Thread Vivien Didelot
The 6390 family of chips use only 2 of the 3 VTU Data registers to pack the MemberTag and PortState VLAN data. This means that they must be written or read before or after each VTU/STU operations. Implement this variant to add support for VTU with such chips. Signed-off-by: Vivien Didelot --- d

[PATCH net-next v2 1/6] net: dsa: mv88e6xxx: add port mask helper

2017-02-17 Thread Vivien Didelot
Add a mv88e6xxx_port_mask() helper to get the bitmask of ports in a switch chip, that will be used in several features. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 5 + drivers/net/dsa/mv88e6xxx/port.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)

[PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Vivien Didelot
Move the Global (1) ATU related code in its own file, and export the necessary primitives. Use that opportunity to provide a cleaner API for the ATU, by renaming a few underscore prefixed functions, and members of the mv88e6xxx_atu_entry structures. Signed-off-by: Vivien Didelot --- drivers/net

Re: RFC: unit tests for kernel GTP module

2017-02-17 Thread Andreas Schultz
Hi, - On Feb 16, 2017, at 11:08 PM, laforge lafo...@gnumonks.org wrote: > Dear GTP-interested folks, > > I would love to somehow get towards some degree of unit testing (or even > "continuous integration") for teh kernel GTP code. > > We currently have the original code in the kernel, we ha

Re: [PATCH net] sctp: check duplicate node before inserting a new transport

2017-02-17 Thread Xin Long
On Fri, Feb 17, 2017 at 7:19 PM, Neil Horman wrote: > On Fri, Feb 17, 2017 at 04:35:24PM +0800, Xin Long wrote: >> sctp has changed to use rhlist for transport rhashtable since commit >> 7fda702f9315 ("sctp: use new rhlist interface on sctp transport >> rhashtable"). >> >> But rhltable_insert_key

Re: [PATCH net v5] bpf: add helper to compare network namespaces

2017-02-17 Thread Daniel Borkmann
On 02/17/2017 05:01 AM, David Ahern wrote: On 2/16/17 3:08 AM, Daniel Borkmann wrote: Is there anything that speaks against doing the comparison itself outside of the helper? Meaning, the helper would get a buffer passed from stack f.e. struct foo { u64 ns_dev; u64 ns_ino; } and fills both out w

Re: [PATCH net-next v2 2/2] net: mvneta: Use cacheable memory to store the rx buffer DMA address

2017-02-17 Thread Thomas Petazzoni
Hello, On Fri, 17 Feb 2017 14:30:03 +0100, Gregory CLEMENT wrote: > I have just tested it and as I feared, with HWBM enabled, a simple iperf > just doesn't work. And that's expected: the whole point of HWBM is that the buffer into which a RX packet is placed is allocated by the HW, and its addre

Re: [PATCH] net: bgmac: store MAC address directly in netdev->dev_addr

2017-02-17 Thread Jon Mason
On Thu, Feb 16, 2017 at 9:11 AM, Tobias Klauser wrote: > After commit 34a5102c3235 ("net: bgmac: allocate struct bgmac just once > & don't copy it") the mac_addr member of struct bgmac is no longer > necessary to pass the MAC address to bgmac_enet_probe(). Instead it can > directly be stored in ne

Re: [PATCH net-next v2 1/2] net: mvneta: avoid getting status from rx_desc as much as possible

2017-02-17 Thread Gregory CLEMENT
Hi Jisheng, On ven., févr. 17 2017, Jisheng Zhang wrote: > In hot code path mvneta_rx_hwbm(), the rx_desc->status is read twice. > The rx_desc is allocated by dma_alloc_coherent, it's uncacheable if > the device isn't cache-coherent, reading from uncached memory is > fairly slow. So reuse the

Re: [PATCH net-next v2 2/2] net: mvneta: Use cacheable memory to store the rx buffer DMA address

2017-02-17 Thread Gregory CLEMENT
Hi Jisheng, On ven., févr. 17 2017, Jisheng Zhang wrote: > In hot code path such as mvneta_rx_hwbm() and mvneta_rx_swbm, the > buf_phys_addr field of rx_dec is accessed. The rx_desc is allocated by > dma_alloc_coherent, it's uncacheable if the device isn't cache > coherent, reading from uncach

Re: [PATCH 05/21] net-next: stmmac: Add dwmac-sun8i

2017-02-17 Thread Corentin Labbe
On Thu, Feb 16, 2017 at 08:05:24PM +0100, Maxime Ripard wrote: > Hi, > [...] > > + > > +struct emac_variant { > > + u32 default_syscon_value; > > Why do you need a default value? Can't you read it from the syscon > directly? > Why not, but you can see the default value as "value for disabled

[PATCH] net: ethernet: stmmac: dwmac-rk: Add RK3328 gmac support

2017-02-17 Thread David Wu
From: "david.wu" Add constants and callback functions for the dwmac on rk3328 socs. As can be seen, the base structure is the same, only registers and the bits in them moved slightly. Signed-off-by: david.wu --- .../devicetree/bindings/net/rockchip-dwmac.txt | 1 + drivers/net/ethernet/s

[PATCH] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-02-17 Thread Chris Wilson
An error during suspend (e100e_pm_suspend), [ 429.994338] ACPI : EC: event blocked [ 429.994633] e1000e: EEE TX LPI TIMER: 0011 [ 430.955451] pci_pm_suspend(): e1000e_pm_suspend+0x0/0x30 [e1000e] returns -2 [ 430.955454] dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2 [ 430.955458

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-17 Thread Rafael J. Wysocki
On Fri, Feb 17, 2017 at 8:11 AM, Joe Perches wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate > define pr_warning

Re: [PATCH 04/21] ARM: sun8i: dt: Add DT bindings documentation for Allwinner dwmac-sun8i

2017-02-17 Thread Corentin Labbe
On Thu, Feb 16, 2017 at 07:48:18PM +0100, Maxime Ripard wrote: > Hi, > > On Thu, Feb 16, 2017 at 01:48:42PM +0100, Corentin Labbe wrote: > > This patch adds documentation for Device-Tree bindings for the > > Allwinner dwmac-sun8i driver. > > > > Signed-off-by: Corentin Labbe > > --- > > .../dev

Re: [PATCH net] sctp: check duplicate node before inserting a new transport

2017-02-17 Thread Neil Horman
On Fri, Feb 17, 2017 at 04:35:24PM +0800, Xin Long wrote: > sctp has changed to use rhlist for transport rhashtable since commit > 7fda702f9315 ("sctp: use new rhlist interface on sctp transport > rhashtable"). > > But rhltable_insert_key doesn't check the duplicate node when inserting > a node, u

Re: [PATCH net-next v2 0/2] net: mvneta: improve rx performance

2017-02-17 Thread Jisheng Zhang
On Fri, 17 Feb 2017 11:37:21 +0100 Gregory CLEMENT wrote: > Hi Jisheng, > > On ven., févr. 17 2017, Jisheng Zhang wrote: > > > In hot code path such as mvneta_rx_hwbm() and mvneta_rx_swbm(), we may > > access fields of rx_desc. The rx_desc is allocated by > > dma_alloc_coherent, it's uncachea

Re: [PATCH net-next v2 0/2] net: mvneta: improve rx performance

2017-02-17 Thread Gregory CLEMENT
Hi Jisheng, On ven., févr. 17 2017, Jisheng Zhang wrote: > In hot code path such as mvneta_rx_hwbm() and mvneta_rx_swbm(), we may > access fields of rx_desc. The rx_desc is allocated by > dma_alloc_coherent, it's uncacheable if the device isn't cache > coherent, reading from uncached memory is

[PATCH] net/wan: add MODULE_LICENSE for fsl_ucc_hdlc

2017-02-17 Thread Valentin Longchamp
It is required to build it as a module. Signed-off-by: Valentin Longchamp --- drivers/net/wan/fsl_ucc_hdlc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index e38ce4d..1f38c06 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.c +++

Re: [PATCH net-next 5/6] net: dsa: mv88e6xxx: add VTU ops

2017-02-17 Thread kbuild test robot
Hi Vivien, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Vivien-Didelot/net-dsa-mv88e6xxx-88E6390-ATU-VTU/20170217-113559 config: openrisc-allmodconfig (attached as .config) compiler: or32-linux-gcc (GCC) 4.5.1-or32-1.0rc1 reproduce: wget

Re: RFC: unit tests for kernel GTP module

2017-02-17 Thread Ido Schimmel
Hi, On Thu, Feb 16, 2017 at 11:08:01PM +0100, Harald Welte wrote: > Also, if netdev folks have some ideas/pointers about possible > frameworks/tools for this kind of testing [it must exist for at least > some other kernel networking code?]: Please let me know. I'd be > interested to have a look i

Re: [PATCH net-next v2 0/2] net: mvneta: improve rx performance

2017-02-17 Thread Jisheng Zhang
On Fri, 17 Feb 2017 18:02:31 +0800 Jisheng Zhang wrote: > In hot code path such as mvneta_rx_hwbm() and mvneta_rx_swbm(), we may > access fields of rx_desc. The rx_desc is allocated by > dma_alloc_coherent, it's uncacheable if the device isn't cache > coherent, reading from uncached memory is fai

[PATCH net-next v2 1/2] net: mvneta: avoid getting status from rx_desc as much as possible

2017-02-17 Thread Jisheng Zhang
In hot code path mvneta_rx_hwbm(), the rx_desc->status is read twice. The rx_desc is allocated by dma_alloc_coherent, it's uncacheable if the device isn't cache-coherent, reading from uncached memory is fairly slow. So reuse the read out rx_status to avoid the second reading from uncached memory.

[PATCH net-next v2 2/2] net: mvneta: Use cacheable memory to store the rx buffer DMA address

2017-02-17 Thread Jisheng Zhang
In hot code path such as mvneta_rx_hwbm() and mvneta_rx_swbm, the buf_phys_addr field of rx_dec is accessed. The rx_desc is allocated by dma_alloc_coherent, it's uncacheable if the device isn't cache coherent, reading from uncached memory is fairly slow. This patch uses cacheable memory to store th

[PATCH net-next v2 0/2] net: mvneta: improve rx performance

2017-02-17 Thread Jisheng Zhang
In hot code path such as mvneta_rx_hwbm() and mvneta_rx_swbm(), we may access fields of rx_desc. The rx_desc is allocated by dma_alloc_coherent, it's uncacheable if the device isn't cache coherent, reading from uncached memory is fairly slow. patch1 reuses the read out status to getting status fie

[PATCH net-next 0/2] net: mvneta: improve rx performance

2017-02-17 Thread Jisheng Zhang
In hot code path such as mvneta_rx_hwbm() and mvneta_rx_swbm(), we may access fields of rx_desc. The rx_desc is allocated by dma_alloc_coherent, it's uncacheable if the device isn't cache coherent, reading from uncached memory is fairly slow. patch1 reuses the read out status to getting status fie

[PATCH net-next 2/2] net: mvneta: Use cacheable memory to store the rx buffer DMA address

2017-02-17 Thread Jisheng Zhang
In hot code path such as mvneta_rx_hwbm() and mvneta_rx_swbm, the buf_phys_addr field of rx_dec is accessed. The rx_desc is allocated by dma_alloc_coherent, it's uncacheable if the device isn't cache coherent, reading from uncached memory is fairly slow. This patch uses cacheable memory to store th

[PATCH net-next 1/2] net: mvneta: avoid getting status from rx_desc as much as possible

2017-02-17 Thread Jisheng Zhang
In hot code path mvneta_rx_hwbm(), the rx_desc->status is read twice. The rx_desc is allocated by dma_alloc_coherent, it's uncacheable if the device isn't cache-coherent, reading from uncached memory is fairly slow. So reuse the read out rx_status to avoid the second reading from uncached memory.

Re: pull request (net-next): ipsec-next 2017-02-16

2017-02-17 Thread Steffen Klassert
On Thu, Feb 16, 2017 at 10:05:57PM -0500, David Miller wrote: > From: Steffen Klassert > Date: Thu, 16 Feb 2017 13:18:34 +0100 > > > > Please note that this has a merge coflict between commit > > > > 63fca65d0863 ("net: add confirm_neigh method to dst_ops") > > > > from net-next and > > > > 3d

Re: [PATCH net-next] bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure

2017-02-17 Thread Nikolay Aleksandrov
On 16/02/17 20:29, Roopa Prabhu wrote: > From: Roopa Prabhu > > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > Signed-off-by: Roopa Prabhu > --- > net/bridge/br_vlan_tunnel.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/bridge/br_vlan_tunnel.c b/ne

Re: [PATCH net-next] bridge: don't indicate expiry on NTF_EXT_LEARNED fdb entries

2017-02-17 Thread Nikolay Aleksandrov
On 16/02/17 22:38, Roopa Prabhu wrote: > From: Roopa Prabhu > > added_by_external_learn fdb entries are added and expired by > external entities like switchdev driver or external controllers. > ageing is already disabled for such entries. Hence, don't > indicate expiry for such fdb entries. > >

Re: [PATCH net-next] bridge: don't indicate expiry on NTF_EXT_LEARNED fdb entries

2017-02-17 Thread Ido Schimmel
On Thu, Feb 16, 2017 at 01:38:04PM -0800, Roopa Prabhu wrote: > From: Roopa Prabhu > > added_by_external_learn fdb entries are added and expired by > external entities like switchdev driver or external controllers. > ageing is already disabled for such entries. Hence, don't > indicate expiry for

[PATCHv2 1/1] rds:Remove unnecessary ib_ring unalloc

2017-02-17 Thread Zhu Yanjun
In the function rds_ib_xmit_atomic, ib_ring is not allocated successfully. As such, it is not necessary to unalloc it. Cc: Joe Jin Cc: Junxiao Bi Signed-off-by: Zhu Yanjun --- Change from v1 to v2: fix the word errors in the short log. net/rds/ib_send.c | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH 08/21] ARM: dts: sun8i-h3: add dwmac-sun8i rgmii pins

2017-02-17 Thread Corentin Labbe
On Thu, Feb 16, 2017 at 08:06:32PM +0100, Maxime Ripard wrote: > On Thu, Feb 16, 2017 at 01:48:46PM +0100, Corentin Labbe wrote: > > This patch add pinctrl node for dwmac-sun8i on H3. > > > > Signed-off-by: Corentin Labbe > > --- > > arch/arm/boot/dts/sun8i-h3.dtsi | 11 +++ > > 1 file c

Re: [PATCH 20/21] ARM: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig

2017-02-17 Thread Corentin Labbe
On Thu, Feb 16, 2017 at 08:08:27PM +0100, Maxime Ripard wrote: > Hi, > > On Thu, Feb 16, 2017 at 01:48:58PM +0100, Corentin Labbe wrote: > > From: LABBE Corentin > > > > Enable the dwmac-sun8i driver in the sunxi default configuration > > > > Signed-off-by: Corentin Labbe > > --- > > arch/arm

[PATCH 1/1] rds:Remove unnecessary ib_ring unalloc

2017-02-17 Thread Zhu Yanjun
In the function rds_ib_xmit_atomic, ib_ring is not successfully. As such, it is not necessary to unalloc it. Cc: Joe Jin Cc: Junxiao Bi Signed-off-by: Zhu Yanjun --- net/rds/ib_send.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c index 84d90c9..84b34c

Re: [PATCH 20/35] drivers/isdn: Convert remaining uses of pr_warning to pr_warn

2017-02-17 Thread Paul Bolle
On Thu, 2017-02-16 at 23:11 -0800, Joe Perches wrote: > To enable eventual removal of pr_warning > > This makes pr_warn use consistent for drivers/isdn > > Prior to this patch, there were 20 uses of pr_warning and > 3 uses of pr_warn in drivers/isdn > > Signed-off-by: Joe Perches > --- > drive

Re: [patch net-next RFC 1/8] devlink: Support for pipeline debug (dpipe)

2017-02-17 Thread Simon Horman
Hi Jiri, On Thu, Feb 16, 2017 at 04:22:37PM +0100, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > The pipeline debug is used to export the pipeline abstractions > for the main objects - tables, headers and entries. The only support for > set is for changing the counter parameter on specific ta

Re: [BUG] LACP state machine will find nothing and do nothing when link is single passing

2017-02-17 Thread zhou zhengwu
Obviously, in the case of single link, one end of port can receives lacpdu and the lacp configure parameters will not change, eg. port number, port priority and system priority and so on. So lacp state machine will not check the link change and the failed link will not be unselected from the a

Re: [PATCH 04/21] ARM: sun8i: dt: Add DT bindings documentation for Allwinner dwmac-sun8i

2017-02-17 Thread Maxime Ripard
Hi, On Thu, Feb 16, 2017 at 01:48:42PM +0100, Corentin Labbe wrote: > This patch adds documentation for Device-Tree bindings for the > Allwinner dwmac-sun8i driver. > > Signed-off-by: Corentin Labbe > --- > .../devicetree/bindings/net/dwmac-sun8i.txt| 86 > ++ > 1 f

[PATCH net-next] sctp: sctp_transport_dst_check should check if transport pmtu is dst mtu

2017-02-17 Thread Xin Long
Now when sending a packet, sctp_transport_dst_check will check if dst is obsolete by calling ipv4/ip6_dst_check. But they return obsolete only when adding a new cache, after that when the cache's pmtu is updated again, it will not trigger transport->dst/pmtu's update. It can be reproduced by reduc

Re: [PATCH 08/21] ARM: dts: sun8i-h3: add dwmac-sun8i rgmii pins

2017-02-17 Thread Maxime Ripard
On Thu, Feb 16, 2017 at 01:48:46PM +0100, Corentin Labbe wrote: > This patch add pinctrl node for dwmac-sun8i on H3. > > Signed-off-by: Corentin Labbe > --- > arch/arm/boot/dts/sun8i-h3.dtsi | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/

Re: [PATCH 05/21] net-next: stmmac: Add dwmac-sun8i

2017-02-17 Thread Maxime Ripard
Hi, On Thu, Feb 16, 2017 at 01:48:43PM +0100, Corentin Labbe wrote: > The dwmac-sun8i is a heavy hacked version of stmmac hardware by > allwinner. > In fact the only common part is the descriptor management and the first > register function. > > Signed-off-by: Corentin Labbe > --- > drivers/net

Re: [PATCH 20/21] ARM: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig

2017-02-17 Thread Maxime Ripard
Hi, On Thu, Feb 16, 2017 at 01:48:58PM +0100, Corentin Labbe wrote: > From: LABBE Corentin > > Enable the dwmac-sun8i driver in the sunxi default configuration > > Signed-off-by: Corentin Labbe > --- > arch/arm/configs/sunxi_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/

[PATCH net] sctp: check duplicate node before inserting a new transport

2017-02-17 Thread Xin Long
sctp has changed to use rhlist for transport rhashtable since commit 7fda702f9315 ("sctp: use new rhlist interface on sctp transport rhashtable"). But rhltable_insert_key doesn't check the duplicate node when inserting a node, unlike rhashtable_lookup_insert_key. It may cause duplicate assoc/trans

Re: [linux-sunxi] [PATCH 03/21] net-next: stmmac: add optional setup function

2017-02-17 Thread Corentin Labbe
On Thu, Feb 16, 2017 at 09:38:33PM +0100, Peter Korsgaard wrote: > > "Corentin" == Corentin Labbe writes: > > > Instead of ading more ifthen login for adding a new mac_device_info > > s/login/logic/ > > -- > Bye, Peter Korsgaard Thanks, will fix it. Regards Corentin Labbe

Re: [PATCH iproute2 1/1] man page: add page for skbmod action

2017-02-17 Thread Simon Horman
On Fri, Feb 10, 2017 at 06:28:54PM -0500, Lucas Bates wrote: > Signed-off-by: Lucas Bates > Signed-off-by: Jamal Hadi Salim > Signed-off-by: Roman Mashak > --- > man/man8/Makefile| 2 +- > man/man8/tc-skbmod.8 | 137 > +++ > 2 files changed

[PATCH net-next (repost)] nfp: Use PCI_DEVICE_ID_NETRONOME_NFP* defines

2017-02-17 Thread Simon Horman
Use PCI_DEVICE_ID_NETRONOME_NFP*, defined in linux/pci_ids.h, rather than replicating the same values in the NFP driver. Signed-off-by: Simon Horman --- * Reposted with subject and changelog adjusted to be less likely to be flagged as spam --- drivers/net/ethernet/netronome/nfp/nfp_main.c

<    1   2