[PATCH] block: DAC960: fix ifnullfree.cocci warnings

2017-03-10 Thread kbuild test robot
drivers/block/DAC960.c:441:3-19: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. drivers/block/DAC960.c:446:1-17: WARNING: NULL check before

Re: [PATCH v5 01/19] block: DAC960: Replace PCI pool old API

2017-03-10 Thread kbuild test robot
Hi Romain, [auto build test WARNING on scsi/for-next] [also build test WARNING on v4.11-rc1 next-20170310] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Romain-Perier/Replace-PCI-pool-by-DMA

[PATCH net] selftests/bpf: fix broken build

2017-03-10 Thread Alexei Starovoitov
Recent merge of 'linux-kselftest-4.11-rc1' tree broke bpf test build. None of the tests were building and test_verifier.c had tons of compiler errors. Fix it and add #ifdef CAP_IS_SUPPORTED to support old versions of libcap. Tested on centos 6.8 and 7 Signed-off-by: Alexei Starovoitov

[PATCH] netfilter: Force fake conntrack entry to be at least 8 bytes aligned

2017-03-10 Thread Steven Rostedt (VMware)
Since the nfct and nfctinfo have been combined, the nf_conn structure must be at least 8 bytes aligned, as the 3 LSB bits are used for the nfctinfo. But there's a fake nf_conn structure to denote untracked connections, which is created by a PER_CPU construct. This does not guarantee that it will

[PATCH] usbnet: smsc95xx: Reduce logging noise

2017-03-10 Thread Guenter Roeck
An insert/remove stress test generated the following log message sequence. usb 7-1.1: New USB device found, idVendor=0424, idProduct=ec00 usb 7-1.1: New USB device strings: Mfr=0, Product=0, SerialNumber=0 smsc95xx 7-1.1:1.0 (unnamed net_device) (uninitialized):

[net-next sample action optimization 2/3] openvswitch: Refactor recirc key allocation.

2017-03-10 Thread Andy Zhou
The logic of allocating and copy key for each 'exec_actions_level' was specific to execute_recirc(). However, future patches will reuse as well. Refactor the logic into its own function clone_key(). Signed-off-by: Andy Zhou --- net/openvswitch/actions.c | 71

[net-next sample action optimization 0/3]

2017-03-10 Thread Andy Zhou
The sample action can be used for translating Openflow 'clone' action. However its implementation has not been sufficiently optimized for this use case. This series attempts to close the gap. Patch 3 commit message has more details on the specific optimizations implemented. Andy Zhou (3):

[net-next sample action optimization 3/3] openvswitch: Optimize sample action for the clone use cases

2017-03-10 Thread Andy Zhou
With the introduction of open flow 'clone' action, the OVS user space can now translate the 'clone' action into kernel datapath 'sample' action, with 100% probability, to ensure that the clone semantics, which is that the packet seen by the clone action is the same as the packet seen by the action

[net-next sample action optimization 1/3] openvswitch: Deferred fifo API change.

2017-03-10 Thread Andy Zhou
add_deferred_actions() API currently requires actions to be passed in as a fully encoded netlink message. So far both 'sample' and 'recirc' actions happens to carry actions as fully encoded netlink messages. However, this requirement is more restrictive than necessary, future patch will need to

Re: [PATCH net-next v2] net: Add sysctl to toggle early demux for tcp and udp

2017-03-10 Thread Tom Herbert
On Fri, Mar 10, 2017 at 4:22 PM, Eric Dumazet wrote: > On Fri, 2017-03-10 at 08:33 -0800, Tom Herbert wrote: > >> Okay, now I'm confused. You're saying that when early demux was added >> for IPv6 performance improved, but this patch is allowing early demux >> to be

[PATCH] drop_monitor: use setup_timer

2017-03-10 Thread Geliang Tang
Use setup_timer() instead of init_timer() to simplify the code. Signed-off-by: Geliang Tang --- net/core/drop_monitor.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/core/drop_monitor.c b/net/core/drop_monitor.c index fb55327..70ccda2 100644

[PATCH] ambassador: use setup_timer

2017-03-10 Thread Geliang Tang
Use setup_timer() instead of init_timer() to simplify the code. Signed-off-by: Geliang Tang --- drivers/atm/ambassador.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c index 4a61079..906705e

[PATCH] x86-32: fix tlb flushing when lguest clears PGE

2017-03-10 Thread Daniel Borkmann
Fengguang reported [1] random corruptions from various locations on x86-32 after commits d2852a224050 ("arch: add ARCH_HAS_SET_MEMORY config") and 9d876e79df6a ("bpf: fix unlocking of jited image when module ronx not set") that uses the former. While x86-32 doesn't have a JIT like x86_64, the

Re: [PATCH net-next v2] net: Add sysctl to toggle early demux for tcp and udp

2017-03-10 Thread Eric Dumazet
On Fri, 2017-03-10 at 08:33 -0800, Tom Herbert wrote: > Okay, now I'm confused. You're saying that when early demux was added > for IPv6 performance improved, but this patch is allowing early demux > to be disabled on the basis that it hurts performance for unconnected > UDP workloads. While it's

Re: [RFC net-next sample action optimization 3/3] openvswitch: Optimize sample action for the clone use cases

2017-03-10 Thread Joe Stringer
On 10 March 2017 at 14:07, Andy Zhou wrote: > On Thu, Mar 9, 2017 at 11:46 AM, Joe Stringer wrote: >> On 7 March 2017 at 16:15, Andy Zhou wrote: >>> With the introduction of open flow 'clone' action, the OVS user space >>> can now translate the

Re: [PATCH] net: tun: use new api ethtool_{get|set}_link_ksettings

2017-03-10 Thread Eric Dumazet
On Fri, 2017-03-10 at 23:57 +0200, Michael S. Tsirkin wrote: > On Fri, Mar 10, 2017 at 10:18:07PM +0100, Philippe Reynes wrote: > > The ethtool api {get|set}_settings is deprecated. > > We move this driver to new api {get|set}_link_ksettings. > > > > As I don't have the hardware, > > What kind

[PATCH net-next 2/3] vxlan: fix snooping for link-local IPv6 addresses

2017-03-10 Thread Matthias Schiffer
If VXLAN is run over link-local IPv6 addresses, it is necessary to store the ifindex in the FDB entries. Otherwise, the used interface is undefined and unicast communication will most likely fail. Signed-off-by: Matthias Schiffer --- drivers/net/vxlan.c | 20

[PATCH net-next 0/3] VXLAN over IPv6 link-local

2017-03-10 Thread Matthias Schiffer
Running VXLANs over IPv6 link-local addresses allows to use them as a drop-in replacement for VLANs, avoiding to allocate additional outer IP addresses to run the VXLAN over. The first patch is basically a bugfix, not allowing to use link-local addresses without specifying an interface; it

[PATCH net-next 1/3] vxlan: don't allow link-local IPv6 local/remote addresses without interface

2017-03-10 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer --- drivers/net/vxlan.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index e375560cc74e..cc0ace73d02e 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@

[PATCH net-next 3/3] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses

2017-03-10 Thread Matthias Schiffer
As link-local addresses are only valid for a single interface, we can allow to use the same VNI for multiple independent VXLANs, as long as the used interfaces are distinct. This way, VXLANs can always be used as a drop-in replacement for VLANs with greater ID space. This also extends VNI lookup

[PATCH] mpls: Do not decrement alive counter for unregister events

2017-03-10 Thread David Ahern
Multipath routes can be rendered usesless when a device in one of the paths is deleted. For example: $ ip -f mpls ro ls 100 nexthop as to 200 via inet 172.16.2.2 dev virt12 nexthop as to 300 via inet 172.16.3.2 dev br0 101 nexthop as to 201 via inet6 2000:2::2 dev

Re: [RFC net-next sample action optimization 3/3] openvswitch: Optimize sample action for the clone use cases

2017-03-10 Thread Andy Zhou
On Thu, Mar 9, 2017 at 11:46 AM, Joe Stringer wrote: > On 7 March 2017 at 16:15, Andy Zhou wrote: >> With the introduction of open flow 'clone' action, the OVS user space >> can now translate the 'clone' action into kernel datapath 'sample' >> action, with 100%

Re: [PATCH] net: tun: use new api ethtool_{get|set}_link_ksettings

2017-03-10 Thread Michael S. Tsirkin
On Fri, Mar 10, 2017 at 10:18:07PM +0100, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, What kind of hardware? > I'd be very pleased if > someone may test this patch. > >

Re: [RFC net-next sample action optimization 2/3] openvswitch: Refactor recirc key allocation.

2017-03-10 Thread Andy Zhou
On Thu, Mar 9, 2017 at 11:11 AM, Joe Stringer wrote: > On 7 March 2017 at 16:15, Andy Zhou wrote: >> The logic of allocating and copy key for each 'exec_actions_level' >> was specific to execute_recirc(). However, future patches will reuse >> as well. Refactor the

[PATCH net v4] xen-netback: fix race condition on XenBus disconnect

2017-03-10 Thread Igor Druzhinin
In some cases during XenBus disconnect event handling and subsequent queue resource release there may be some TX handlers active on other processors. Use RCU in order to synchronize with them. Signed-off-by: Igor Druzhinin --- v4: * Use READ_ONCE instead of

Re: [PATCH v2] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-10 Thread Pavel Belous
On 10.03.2017 17:47, David Arcari wrote: Hi, On 03/09/2017 05:43 PM, Lino Sanfilippo wrote: Hi, On 09.03.2017 22:03, David Arcari wrote: When the aquantia device mtu is changed the net_device structure is not updated. As a result the ip command does not properly reflect the mtu change.

[PATCH] net: tun: use new api ethtool_{get|set}_link_ksettings

2017-03-10 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/tun.c | 24 +++-

[PATCH net-next v3 2/2] mpls: allow TTL propagation from IP packets to be configured

2017-03-10 Thread Robert Shearman
Allow TTL propagation from IP packets to MPLS packets to be configured. Add a new optional LWT attribute, MPLS_IPTUNNEL_TTL, which allows the TTL to be set in the resulting MPLS packet, with the value of 0 having the semantics of enabling propagation of the TTL from the IP header (i.e. non-zero

[PATCH net-next v3 1/2] mpls: allow TTL propagation to IP packets to be configured

2017-03-10 Thread Robert Shearman
Provide the ability to control on a per-route basis whether the TTL value from an MPLS packet is propagated to an IPv4/IPv6 packet when the last label is popped as per the theoretical model in RFC 3443 through a new route attribute, RTA_TTL_PROPAGATE which can be 0 to mean disable propagation and

[PATCH net-next v3 0/2] mpls: allow TTL propagation to/from IP packets to be configured

2017-03-10 Thread Robert Shearman
It is sometimes desirable to present an MPLS transport network as a single hop to traffic transiting it because it prevents confusion when diagnosing failures. An example of where confusion can be generated is when addresses used in the provider network overlap with addresses in the overlay

Re: [PATCH v2] selinux: check for address length in selinux_socket_bind()

2017-03-10 Thread Paul Moore
On Fri, Mar 10, 2017 at 7:01 AM, Paul Moore wrote: > On Thu, Mar 9, 2017 at 2:12 AM, David Miller wrote: >> From: Alexander Potapenko >> Date: Mon, 6 Mar 2017 19:46:14 +0100 >> >>> KMSAN (KernelMemorySanitizer, a new error detection

Re: net/sctp: recursive locking in sctp_do_peeloff

2017-03-10 Thread Dmitry Vyukov
On Fri, Mar 10, 2017 at 8:46 PM, Marcelo Ricardo Leitner wrote: > On Fri, Mar 10, 2017 at 4:11 PM, Dmitry Vyukov wrote: >> Hello, >> >> I've got the following recursive locking report while running >> syzkaller fuzzer on

Re: net/sctp: recursive locking in sctp_do_peeloff

2017-03-10 Thread Marcelo Ricardo Leitner
On Fri, Mar 10, 2017 at 4:11 PM, Dmitry Vyukov wrote: > Hello, > > I've got the following recursive locking report while running > syzkaller fuzzer on net-next/9c28286b1b4b9bce6e35dd4c8a1265f03802a89a: > > [ INFO: possible recursive locking detected ] > 4.10.0+ #14 Not tainted

net/sctp: recursive locking in sctp_do_peeloff

2017-03-10 Thread Dmitry Vyukov
Hello, I've got the following recursive locking report while running syzkaller fuzzer on net-next/9c28286b1b4b9bce6e35dd4c8a1265f03802a89a: [ INFO: possible recursive locking detected ] 4.10.0+ #14 Not tainted - syz-executor3/5560 is trying to acquire

[PATCH net-next 09/13] nfp: store dma direction in data path structure

2017-03-10 Thread Jakub Kicinski
Instead of testing if xdp_prog is present store the dma direction in data path structure. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 11 -- .../net/ethernet/netronome/nfp/nfp_net_common.c| 45

[PATCH net-next 11/13] nfp: reorganize pkt_off variable

2017-03-10 Thread Jakub Kicinski
Rename pkt_off variable to dma_off, it should hold data offset counting from beginning of DMA mapping. Compute the value only in XDP context. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 19 ++- 1 file

[PATCH net-next 07/13] nfp: use dp to carry xdp_prog at reconfig time

2017-03-10 Thread Jakub Kicinski
Use xdp_prog member of data path struct to carry the xdp_prog to alloc/free free functions. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 1 - .../net/ethernet/netronome/nfp/nfp_net_common.c| 82 +-

[PATCH net-next 10/13] nfp: validate rx offset from the BAR and size down it's field

2017-03-10 Thread Jakub Kicinski
NFP_NET_CFG_RX_OFFSET is 32bit wide, make sure what we read from there is reasonable for packet headroom. This allows us to store the rx_offset in a 8bit variable. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h| 6 +++---

[PATCH net-next 05/13] nfp: use dp to carry fl_bufsz at reconfig time

2017-03-10 Thread Jakub Kicinski
Use fl_bufsz member of data path struct to carry desired size of free list entries. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 3 -- .../net/ethernet/netronome/nfp/nfp_net_common.c| 56 +++--- 2 files

[PATCH net-next 13/13] nfp: add support for xdp_adjust_head()

2017-03-10 Thread Jakub Kicinski
Support prepending data from XDP. We are already always allocating some headroom because FW may prepend metadata to packets. xdp_adjust_head() can be supported by making sure that headroom is big enough for XDP. In case FW had prepended metadata to the packet, however, we have to move it out of

[PATCH net-next 06/13] nfp: use dp to carry mtu at reconfig time

2017-03-10 Thread Jakub Kicinski
Move the mtu member from ring set to data path struct. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 4 +++- .../net/ethernet/netronome/nfp/nfp_net_common.c| 23 +++---

[PATCH net-next 12/13] nfp: prepare metadata handling for xdp_adjust_head()

2017-03-10 Thread Jakub Kicinski
XDP may require us to move metadata to make room for pushing headers. Track meta data location with a pointer and pass it explicitly to functions. While at it validate that meta_len from the descriptor is not bogus. Signed-off-by: Jakub Kicinski ---

[PATCH net-next 03/13] nfp: pass new data path to ring reconfig

2017-03-10 Thread Jakub Kicinski
Make callers of nfp_net_ring_reconfig() pass newly allocated data path structure. We will gradually make use of that structure instead of passing parameters around to all the allocation functions. This commit adds allocation and propagation of new data path struct, no parameters are converted,

[PATCH net-next 02/13] nfp: move control BAR pointer into data path structure

2017-03-10 Thread Jakub Kicinski
Control BAR pointer is used to unmask interrupts so it should be in the first cacheline of adapter structure. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h| 21 +++--

[PATCH net-next 08/13] nfp: switch to using data path structures for reconfiguration

2017-03-10 Thread Jakub Kicinski
Instead of passing around sets of rings and their parameters just store all information in the data path structure. We will no longer user xchg() on XDP programs when we swap programs while the traffic is guaranteed not to be flowing. This allows us to simply assign the entire data path

[PATCH net-next 04/13] nfp: use dp to carry number of stack tx rings and vectors

2017-03-10 Thread Jakub Kicinski
Instead of passing variables around use dp to store number of tx rings for the stack and number of IRQ vectors. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfp_net_common.c| 62 +++--- 1 file changed, 31 insertions(+), 31

[PATCH net-next 01/13] nfp: separate data path information from the reset of adapter structure

2017-03-10 Thread Jakub Kicinski
Move all data path information into a separate structure. This way we will be able to allocate new data path with all new rings etc. and swap it in easily. No functional changes. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h

[PATCH net-next 00/13] nfp: XDP adjust head support

2017-03-10 Thread Jakub Kicinski
Hi! This series adds support for XDP adjust head. Bulk of the code is actually just paying technical debt. On reconfiguration request nfp was allocating new resources separately leaving device running with the existing set of rings. We used to manage the new resources in special ring set

[PATCH v5 net-next 1/9] net: stmmac: multiple queues dt configuration

2017-03-10 Thread Joao Pinto
This patch adds the multiple queues configuration in the Device Tree. It was also created a set of structures to keep the RX and TX queues configurations to be used in the driver. Signed-off-by: Joao Pinto --- Changes v4->v5: - patch title update (stmicro replaced by stmmac)

[PATCH v5 net-next 9/9] net: stmmac: configuration of CBS in case of a TX AVB queue

2017-03-10 Thread Joao Pinto
This patch adds the configuration of the AVB Credit-Based Shaper. Signed-off-by: Joao Pinto --- Changes v4->v5: - patch title update (stmicro replaced by stmmac) Changes v3->v4: - variable init was simplified in some functions Changes v1->v3: - Added in v3

[PATCH v5 net-next 4/9] net: stmmac: mtl rx queue enabled as dcb or avb

2017-03-10 Thread Joao Pinto
This patch introduces the enabling of RX queues as DCB or as AVB based on configuration. Signed-off-by: Joao Pinto --- Changes v4->v5: - patch title update (stmicro replaced by stmmac) Changes v3->v4: - variable init was simplified in some functions Changes v1->v3: - Just to

[PATCH v5 net-next 8/9] net: stmmac: mac debug prepared for multiple queues

2017-03-10 Thread Joao Pinto
This patch prepares mac debug dump for multiple queues. Signed-off-by: Joao Pinto --- Changes v4->v5: - patch title update (stmicro replaced by stmmac) Changes v3->v4: - Debug function now gets all rx / tx queues data Changes v1->v3: - Just to keep up with patch-set version

[PATCH v5 net-next 3/9] net: stmmac: configure tx queue weight

2017-03-10 Thread Joao Pinto
This patch adds TX queues weight programming. Signed-off-by: Joao Pinto --- Changes v4->v5: - patch title update (stmicro replaced by stmmac) Changes v3->v4: - variable init was simplified in some functions Changes v2->v3: - local variable declarations from longest to

[PATCH v5 net-next 6/9] net: stmmac: flow_ctrl functions adapted to mtl

2017-03-10 Thread Joao Pinto
This patch adapts flow_ctrl function to prepare it for multiple queues. Signed-off-by: Joao Pinto --- Changes v4->v5: - patch title update (stmicro replaced by stmmac) Changes v3->v4: - variable init simplified in some functions Changes v1->v3: - Just to keep up with

[PATCH v5 net-next 2/9] net: stmmac: configure mtl rx and tx algorithms

2017-03-10 Thread Joao Pinto
This patch adds the RX and TX scheduling algorithms programming. It introduces the multiple queues configuration function (stmmac_mtl_configuration) in stmmac_main. Signed-off-by: Joao Pinto --- Changes v4->v5: - patch title update (stmicro replaced by stmmac) Changes

[PATCH v5 net-next 7/9] net: stmmac: prepare irq_status for mtl

2017-03-10 Thread Joao Pinto
This patch prepares mac irq status treatment for multiple queues. Signed-off-by: Joao Pinto --- Changes v4->v5: - patch title update (stmicro replaced by stmmac) Changes v3->v4: - Build error in dwmac4_irq_mtl_status() - variable init simplified in some functions Changes

[PATCH v5 net-next 5/9] net: stmmac: mapping mtl rx to dma channel

2017-03-10 Thread Joao Pinto
This patch adds the functionality of RX queue to dma channel mapping based on configuration. Signed-off-by: Joao Pinto --- Changes v4->v5: - patch title update (stmicro replaced by stmmac) Changes v3->v4: - variable init was simplified in some functions Changes v1->v3: -

[PATCH v5 net-next 0/9] prepare mac operations for multiple queues

2017-03-10 Thread Joao Pinto
As agreed with David Miller, this patch-set is the first of 3 to enable multiple queues in stmmac. This first one concentrates on mac operations adding functionalities as: a) Configuration through DT b) RX and TX scheduling algorithms programming b) TX queues weight programming (essential in

Re: [PATCH net] amd-xgbe: Enable IRQs only if napi_complete_done() is true

2017-03-10 Thread David Miller
From: Tom Lendacky Date: Fri, 10 Mar 2017 08:19:37 -0600 > On 3/9/2017 8:31 PM, David Miller wrote: >> From: Tom Lendacky >> Date: Thu, 9 Mar 2017 17:48:23 -0600 >> >>> Depending on the hardware, the amd-xgbe driver may use >>>

Re: amd-xgbe: unbalanced irq enable in v4.11-rc1

2017-03-10 Thread Mark Rutland
On Fri, Mar 10, 2017 at 11:39:42AM -0600, Tom Lendacky wrote: > On 3/10/2017 11:19 AM, Mark Rutland wrote: > >Hi, > > > >I'm seeing the below splat when transferring data over the network, using > >v4.11-rc1 on an AMD Seattle platform. I don't see the splat with v4.10. > > > >Looking at just the

Re: [PATCH net 0/5] Mellanox mlx5 fixes 2017-03-09

2017-03-10 Thread David Miller
From: Saeed Mahameed Date: Fri, 10 Mar 2017 14:33:00 +0200 > This series contains some mlx5 core and ethernet driver fixes. > > For -stable: > net/mlx5e: remove IEEE/CEE mode check when setting DCBX mode (for kernel >= > 4.10) > net/mlx5e: Avoid wrong identification of

Re: [PATCH v4 net-next 0/9] prepare mac operations for multiple queues

2017-03-10 Thread Joao Pinto
Às 5:50 PM de 3/10/2017, David Miller escreveu: > From: Joao Pinto > Date: Fri, 10 Mar 2017 12:18:25 + > >> As agreed with David Miller, this patch-set is the first of 3 to enable >> multiple queues in stmmac. > > I have one more request to make. > > The name of

Re: [PATCH v4 net-next 0/9] prepare mac operations for multiple queues

2017-03-10 Thread David Miller
From: Joao Pinto Date: Fri, 10 Mar 2017 12:18:25 + > As agreed with David Miller, this patch-set is the first of 3 to enable > multiple queues in stmmac. I have one more request to make. The name of the driver is "stmmac" therefore I'd like you to use "stmmac: " as

Re: net: BUG in unix_notinflight

2017-03-10 Thread Cong Wang
On Tue, Mar 7, 2017 at 2:23 PM, Nikolay Borisov wrote: > >>> >>> >>> New report from linux-next/c0b7b2b33bd17f7155956d0338ce92615da686c9 >>> >>> [ cut here ] >>> kernel BUG at net/unix/garbage.c:149! >>> invalid opcode: [#1] SMP KASAN >>>

[PATCH] mpls: Send route delete notifications when router module is unloaded

2017-03-10 Thread David Ahern
When the mpls_router module is unloaded, mpls routes are deleted but notifications are not sent to userspace leaving userspace caches out of sync. Add the call to mpls_notify_route in mpls_net_exit as routes are freed. Fixes: 0189197f44160 ("mpls: Basic routing support") Signed-off-by: David

Re: [patch net-next 0/2] ipv4: fib: FIB notifications cleanup

2017-03-10 Thread David Miller
From: Jiri Pirko Date: Fri, 10 Mar 2017 08:56:17 +0100 > Ido says: > > The first patch moves the core FIB notification code to a separate file, > so that code related to FIB rules is placed in fib_rules.c and not > fib_trie.c. The reason for the change will become even more

Re: amd-xgbe: unbalanced irq enable in v4.11-rc1

2017-03-10 Thread Tom Lendacky
On 3/10/2017 11:19 AM, Mark Rutland wrote: Hi, I'm seeing the below splat when transferring data over the network, using v4.11-rc1 on an AMD Seattle platform. I don't see the splat with v4.10. Looking at just the driver, I couldn't see any suspicious changes. Reverting commit 402168b4c2dc0734

Re: [patch net-next 00/10] mlxsw: Preparations for VRF offload

2017-03-10 Thread David Miller
From: Jiri Pirko Date: Fri, 10 Mar 2017 08:53:33 +0100 > Ido says: > > This patchset aims to prepare the mlxsw driver for VRF offload. The > follow-up patchsets that introduce VRF support can be found here: > https://github.com/idosch/linux/tree/idosch-next > > The first four

Re: [PATCH net] rxrpc: Wake up the transmitter if Rx window size increases on the peer

2017-03-10 Thread David Miller
From: David Howells Date: Fri, 10 Mar 2017 07:48:49 + > The RxRPC ACK packet may contain an extension that includes the peer's > current Rx window size for this call. We adjust the local Tx window size > to match. However, the transmitter can stall if the receive

Re: [PATCH net] act_connmark: avoid crashing on malformed nlattrs with null parms

2017-03-10 Thread Cong Wang
On Fri, Mar 10, 2017 at 7:55 AM, Etienne Noss wrote: > tcf_connmark_init does not check in its configuration if TCA_CONNMARK_PARMS > is set, resulting in a null pointer dereference when trying to access it. > > [501099.043007] BUG: unable to handle kernel NULL pointer

amd-xgbe: unbalanced irq enable in v4.11-rc1

2017-03-10 Thread Mark Rutland
Hi, I'm seeing the below splat when transferring data over the network, using v4.11-rc1 on an AMD Seattle platform. I don't see the splat with v4.10. Looking at just the driver, I couldn't see any suspicious changes. Reverting commit 402168b4c2dc0734 ("amd-xgbe: Stop the PHY before releasing

Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.

2017-03-10 Thread Yasuaki Ishimatsu
On 03/09/2017 08:35 PM, David Miller wrote: From: Yasuaki Ishimatsu Date: Wed, 8 Mar 2017 16:05:18 -0500 The fjes driver is used only by FUJITSU servers and almost of all servers in the world never use it. But currently if ACPI PNP0C02 is defined in the ACPI table,

Re: [PATCH iproute2] man: Fix formatting of vrf parameter of ip-link show command

2017-03-10 Thread Stephen Hemminger
On Thu, 9 Mar 2017 12:56:14 + Robert Shearman wrote: > Add missing opening " [" for the vrf parameter. > > Signed-off-by: Robert Shearman Applied

Re: [PATCH iproute2] iplink: add support for afstats subcommand

2017-03-10 Thread Stephen Hemminger
On Thu, 9 Mar 2017 12:43:36 + Robert Shearman wrote: > Add support for new afstats subcommand. This uses the new > IFLA_STATS_AF_SPEC attribute of RTM_GETSTATS messages to show > per-device, AF-specific stats. At the moment the kernel only supports > MPLS AF stats, so

Re: [iproute PATCH] man: ss.8: Add missing protocols to description of -A

2017-03-10 Thread Stephen Hemminger
On Thu, 9 Mar 2017 17:07:33 +0100 Phil Sutter wrote: > The list was missing dccp and sctp protocols. > > Signed-off-by: Phil Sutter Applied, thanks

[PATCH v2 6/9] net: stmmac: Parse FIFO sizes from feature registers

2017-03-10 Thread Thierry Reding
From: Thierry Reding New version of this core encode the FIFO sizes in one of the feature registers. Use these sizes as default, but still allow device tree to override them for backwards compatibility. Reviewed-by: Mikko Perttunen Signed-off-by:

[PATCH v2 9/9] net: stmmac: dwc-qos: Add Tegra186 support

2017-03-10 Thread Thierry Reding
From: Thierry Reding The NVIDIA Tegra186 SoC contains an instance of the Synopsys DWC ethernet QOS IP core. The binding that it uses is slightly different from existing ones because of the integration (clocks, resets, ...). Signed-off-by: Thierry Reding

[PATCH v2 1/9] net: stmmac: Rename clk_ptp_ref clock to ptp_ref

2017-03-10 Thread Thierry Reding
From: Thierry Reding There aren't currently any users of the "clk_ptp_ref", but there are other references to "ptp_ref", so I'm leaning towards considering that a typo. Fix it. Cc: Mark Rutland Cc: Rob Herring Cc:

[PATCH v2 7/9] net: stmmac: Program RX queue size and flow control

2017-03-10 Thread Thierry Reding
From: Thierry Reding Program the receive queue size based on the RX FIFO size and enable hardware flow control for large FIFOs. Signed-off-by: Thierry Reding --- Changes in v2: - add comments to clarify flow control threshold programming

[PATCH v2 8/9] net: stmmac: dwc-qos: Split out ->probe() and ->remove()

2017-03-10 Thread Thierry Reding
From: Thierry Reding Split out the binding specific parts of ->probe() and ->remove() to enable the driver to support variants of the binding. This is useful in order to keep backwards-compatibility while making it easy for a sub- driver to deal only with the updated bindings

[PATCH v2 3/9] net: stmmac: Disable PTP reference clock on error

2017-03-10 Thread Thierry Reding
From: Thierry Reding If an error occurs while opening the device, make sure to disable the PTP reference clock. Signed-off-by: Thierry Reding --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v2 0/9] net: stmmac: Fixes and Tegra186 support

2017-03-10 Thread Thierry Reding
nation of the Synopsys DWC QOS IP found on NVIDIA Tegra186 SoCs. This is based on next-20170310. Changes in v2: - address review comments by Mikko and Joao - add two additional cleanup patches Thanks, Thierry Thierry Reding (9): net: stmmac: Rename clk_ptp_ref clock to ptp_ref net: stmmac: Stop PHY and

[PATCH v2 4/9] net: stmmac: Balance PTP reference clock enable/disable

2017-03-10 Thread Thierry Reding
From: Thierry Reding clk_prepare_enable() and clk_disable_unprepare() for this clock aren't properly balanced, which can trigger a WARN_ON() in the common clock framework. Reviewed-By: Joao Pinto Signed-off-by: Thierry Reding ---

[PATCH v2 5/9] net: stmmac: Check for DMA mapping errors

2017-03-10 Thread Thierry Reding
From: Thierry Reding When DMA mapping an SKB fragment, the mapping must be checked for errors, otherwise the DMA debug code will complain upon unmap. Signed-off-by: Thierry Reding --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ 1 file

[PATCH v2 2/9] net: stmmac: Stop PHY and remove TX timer on error

2017-03-10 Thread Thierry Reding
From: Thierry Reding If an error occurs while opening the device, make sure that both the TX timer and the PHY are properly cleaned up. Signed-off-by: Thierry Reding --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +- 1 file changed, 5

Re: [PATCH net-next v2] net: Add sysctl to toggle early demux for tcp and udp

2017-03-10 Thread Tom Herbert
On Thu, Mar 9, 2017 at 9:26 PM, Subash Abhinov Kasiviswanathan wrote: > On 2017-03-09 20:42, Tom Herbert wrote: >> >> On Thu, Mar 9, 2017 at 7:31 PM, Subash Abhinov Kasiviswanathan >> wrote: >>> >>> Certain system process significant unconnected

Re: [PATCH v3] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

2017-03-10 Thread Leon Romanovsky
On Wed, Mar 08, 2017 at 03:48:57PM +0200, Yuval Shaia wrote: > On Wed, Mar 08, 2017 at 09:40:41AM +0200, Leon Romanovsky wrote: > > On Tue, Mar 07, 2017 at 09:31:58PM +0200, Yuval Shaia wrote: > > > This logic seems to be duplicated in (at least) three separate files. > > > Move it to one place so

Re: [PATCH net] amd-xgbe: Enable IRQs only if napi_complete_done() is true

2017-03-10 Thread Jeremy Linton
On 03/09/2017 05:48 PM, Tom Lendacky wrote: Depending on the hardware, the amd-xgbe driver may use disable_irq_nosync() and enable_irq() when an interrupt is received to process Rx packets. If the napi_complete_done() return value isn't checked an unbalanced enable for the IRQ could result,

Re: [patch net-next 2/2] ipv4: fib: Remove redundant argument

2017-03-10 Thread David Ahern
On 3/10/17 12:56 AM, Jiri Pirko wrote: > From: Ido Schimmel > > We always pass the same event type to fib_notify() and > fib_rules_notify(), so we can safely drop this argument. > > Signed-off-by: Ido Schimmel > Signed-off-by: Jiri Pirko

Re: [patch net-next 1/2] ipv4: fib: Move FIB notification code to a separate file

2017-03-10 Thread David Ahern
On 3/10/17 12:56 AM, Jiri Pirko wrote: > From: Ido Schimmel > > Most of the code concerned with the FIB notification chain currently > resides in fib_trie.c, but this isn't really appropriate, as the FIB > notification chain is also used for FIB rules. > > Therefore, it

[PATCH RFC] virtio_net: fix mergeable bufs error handling

2017-03-10 Thread Michael S. Tsirkin
On xdp error we try to free head_skb without having initialized it, that's clearly bogus. Fixes: f600b6905015 ("virtio_net: Add XDP support") Cc: John Fastabend Signed-off-by: Michael S. Tsirkin --- I'm cleaning up a bunch of issues in this code, thus

[PATCH net] act_connmark: avoid crashing on malformed nlattrs with null parms

2017-03-10 Thread Etienne Noss
tcf_connmark_init does not check in its configuration if TCA_CONNMARK_PARMS is set, resulting in a null pointer dereference when trying to access it. [501099.043007] BUG: unable to handle kernel NULL pointer dereference at 0004 [501099.043039] IP: [] tcf_connmark_init+0x8b/0x180

[net-next v1] vxlan: use appropriate family on L3 miss

2017-03-10 Thread Vincent Bernat
When sending a L3 miss, the family is set to AF_INET even for IPv6. This causes userland (eg "ip monitor") to be confused. Ensure we send the appropriate family in this case. For L2 miss, keep using AF_INET. Signed-off-by: Vincent Bernat --- drivers/net/vxlan.c | 2 +- 1 file

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-10 Thread Jiri Pirko
Fri, Mar 10, 2017 at 04:20:21PM CET, simon.hor...@netronome.com wrote: >On Fri, Mar 10, 2017 at 03:27:32PM +0100, Jiri Pirko wrote: >> Fri, Mar 10, 2017 at 03:19:13PM CET, simon.hor...@netronome.com wrote: >> >On Tue, Feb 21, 2017 at 04:28:10PM +0100, Jiri Pirko wrote: >> >> Thu, Feb 02, 2017 at

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-10 Thread Simon Horman
On Fri, Mar 10, 2017 at 03:27:32PM +0100, Jiri Pirko wrote: > Fri, Mar 10, 2017 at 03:19:13PM CET, simon.hor...@netronome.com wrote: > >On Tue, Feb 21, 2017 at 04:28:10PM +0100, Jiri Pirko wrote: > >> Thu, Feb 02, 2017 at 11:37:34AM CET, simon.hor...@netronome.com wrote: > >> >Allow dissection of

Re: [PATCH v2] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-10 Thread David Arcari
Hi, On 03/09/2017 05:43 PM, Lino Sanfilippo wrote: > Hi, > > On 09.03.2017 22:03, David Arcari wrote: >> When the aquantia device mtu is changed the net_device structure is not >> updated. As a result the ip command does not properly reflect the mtu >> change. >> >> Commit 5513e16421cb

[PATCH] vlan: support ingress/egress priority map flushing

2017-03-10 Thread Thierry Du Tre
When sending packets via a vlan device we can manipulate the priority bits in the vlan header (PCP) via a mapping based on tc class value. Similarly, when packets are received via a vlan device, the PCP value can be mapped onto a tc class value, which is available for iptables rules and tc

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-10 Thread Jiri Pirko
Fri, Mar 10, 2017 at 03:19:13PM CET, simon.hor...@netronome.com wrote: >On Tue, Feb 21, 2017 at 04:28:10PM +0100, Jiri Pirko wrote: >> Thu, Feb 02, 2017 at 11:37:34AM CET, simon.hor...@netronome.com wrote: >> >Allow dissection of Neighbour Discovery target IP, and source and >> >destination

Re: [PATCH net] amd-xgbe: Enable IRQs only if napi_complete_done() is true

2017-03-10 Thread Tom Lendacky
On 3/9/2017 8:31 PM, David Miller wrote: From: Tom Lendacky Date: Thu, 9 Mar 2017 17:48:23 -0600 Depending on the hardware, the amd-xgbe driver may use disable_irq_nosync() and enable_irq() when an interrupt is received to process Rx packets. If the

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-10 Thread Simon Horman
On Tue, Feb 21, 2017 at 04:28:10PM +0100, Jiri Pirko wrote: > Thu, Feb 02, 2017 at 11:37:34AM CET, simon.hor...@netronome.com wrote: > >Allow dissection of Neighbour Discovery target IP, and source and > >destination link-layer addresses for neighbour solicitation and > >advertisement messages. >

  1   2   >