[PATCH] dsa: mv88e6xxx: fix returnvar.cocci warnings

Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Andrew Lunn Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- It's a minor issue, but since there is no

[PATCH net-next] net: phy: Relax error checking on sysfs_create_link()

Some Ethernet drivers will attach/connect to a PHY device before calling register_netdevice() which is responsible for calling netdev_register_kobject() which would do the network device's kobject initialization. In such a case, sysfs_create_link() would return -ENOENT because the network device's

Re: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

On 05/26/2017 06:31 PM, woojung@microchip.com wrote: >> >> Yes, that's a very valid point, how about we even do this: >> >> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c >> index f84414b8f2ee..dc666ec13651 100644 >> --- a/drivers/net/phy/phy_device.c >> +++

[PATCH 3/7] mlx5: Disable {add,del}_offloaded_rule() code if eswitch offloads are disabled

This code will not be called if CONFIG_MLX5_EN_ESWITCH_OFFLOADS is disabled. Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 17 + .../net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +- 2 files changed, 18

[PATCH 0/7] mlx5: Make eswitch_offloads a compile option

Hi, This changes the code to allow for eswitch_offloads to be compile time option, reducing the size of the driver module for those who do not need it. The patches do it step by step by introducing stubs and then finally gets rid of all the #ifdefs once the code can compile and link without

[PATCH 2/7] mlx5: eswitch vlan functionality is only called if SRIOV_OFFLOADS is set

This allows not compiling this code if eswitch offloads are disabled. Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 13 + drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 ++ 2 files changed, 15

[PATCH 4/7] mlx5: Stub out eswitch offload vport functions

This code isn't called if CONFIG_MLX5_EN_ESWITCH_OFFLOADS isn't enabled Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h| 20 +++- .../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 ++ 2 files changed, 21

[PATCH 1/7] mlx5: Allow support for eswitch offloads to be disabled

This allows users to disable eswitch offloads. Follow-on patches will clean up how the eswitch_offloads code is being called and get rid of all the #ifdefs. Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig| 10 ++

[PATCH 5/7] mlx5: Stub out create_vport_rx_rule when eswitch_offloads disabled

One more vport related function to disable. Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 11 --- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-) diff

[PATCH 7/7] mlx5: Do not build eswitch_offloads if CONFIG_MLX5_EN_ESWITCH_OFFLOADS is set

This gets rid of the temporary #ifdef spaghetti and allows the code to compile without offload support enabled. Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/Makefile | 4 +++- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 9

[PATCH 6/7] mlx5: Stub out sqs2vport functions

These aren't called if CONFIG_MLX5_EN_ESWITCH_OFFLOADS isn't enabled, so do not build them. Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 14 ++ drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 -- 2

Re: [for-next 5/6] net/mlx5: Bump driver version

On Fri, 26 May 2017 12:55:22 -0400, Dennis Dalessandro wrote: > >> I realize Dave has already pulled this and I'm not asking for it to be > >> reverted but maybe some discussion will help guide future patch submissions > >> which do this stuff. > >> > > > > Sure, although i don't think we are

[PATCH net-next] net: ndisc.c: reduce size of __ndisc_fill_addr_option()

From: yuan linyu Signed-off-by: yuan linyu --- net/ipv6/ndisc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index d310dc4..414e929 100644 ---

[PATCH net-next 0/3] net: dsa: mv88e6xxx: PHY nitpicks

This patchset isolates more PPU code into phy.c and makes distinction between PHY Registers read and write implementations vs. generic PHY routines. Vivien Didelot (3): net: dsa: mv88e6xxx: provide a PHY setup helper net: dsa: mv88e6xxx: rename PHY PPU accessors net: dsa: mv88e6xxx: rename

[PATCH net-next 2/3] net: dsa: mv88e6xxx: rename PHY PPU accessors

Make it clear that mv88e6xxx_phy_ppu_{read,write} are an implementation of the .phy_{read,write} operations, by renaming them with the mv88e6185 prefix, since 88E6185 it is the reference switch model supported in an upstream board (ZII Dev Rev B), which makes use of them. Distinguish the

[PATCH net-next 1/3] net: dsa: mv88e6xxx: provide a PHY setup helper

Similarly to the VTU, PVT and ATU setup, provide a mv88e6xxx_phy_setup helper which wraps mv88e6xxx_ppu_enable, so that no more PPU-related functions are exposed outside of phy.c. Thus make mv88e6xxx_ppu_enable static. Signed-off-by: Vivien Didelot ---

[PATCH net-next] net: dsa: b53: remove unused dev argument

The port net device passed to b53_fdb_copy is not used. Remove it. Signed-off-by: Vivien Didelot --- drivers/net/dsa/b53/b53_common.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c

Re: [PATCH net-next 1/2] net: ndisc.c: fix coding style issue

On 六, 2017-05-27 at 02:25 +0900, 吉藤英明 wrote: > Hi, > > 2017-05-26 22:55 GMT+09:00 yuan linyu : > > > > On 五, 2017-05-26 at 22:45 +0900, 吉藤英明 wrote: > > > > > > Hi, > > > > > > 2017-05-26 22:23 GMT+09:00 yuan linyu : > > > > > > > > > > > > From: yuan linyu

[PATCH net-next 3/3] net: dsa: mv88e6xxx: rename PHY PPU functions

Respect the implicit naming convention used in all register sets specific files, by renaming the mv88e6xxx_ppu_* functions with the mv88e6xxx_phy_* prefix. This is simply a s/xxx_ppu/xxx_phy_ppu/ substitution. Signed-off-by: Vivien Didelot ---

[PATCH net-next] net: dsa: remove dsa_port_is_bridged

The helper is only used once and makes the code more complicated that it should. Remove it and reorganize the variables so that it fits on 80 columns. Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 13 - 1 file changed, 4 insertions(+), 9

Re: [PATCH net-next] net: dsa: b53: remove unused dev argument

On 05/26/2017 03:07 PM, Vivien Didelot wrote: > The port net device passed to b53_fdb_copy is not used. Remove it. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian

[PATCH net-next] net: dsa: remove dev arg of dsa_register_switch

The current dsa_register_switch function takes a useless struct device pointer argument, which always equals ds->dev. Drivers either call it with ds->dev, or with the same device pointer passed to dsa_switch_alloc, which ends up being assigned to ds->dev. This patch removes the second argument

RE: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

> @@ -960,6 +960,15 @@ int phy_attach_direct(struct net_device *dev, struct > phy_device *phydev, > > phydev->attached_dev = dev; > dev->phydev = phydev; > + err = sysfs_create_link(>mdio.dev.kobj, >dev.kobj, > + "attached_dev"); > + if (err) > +

Re: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

Hi Woojung, On 05/26/2017 04:34 PM, woojung@microchip.com wrote: >> @@ -960,6 +960,15 @@ int phy_attach_direct(struct net_device *dev, struct >> phy_device *phydev, >> >> phydev->attached_dev = dev; >> dev->phydev = phydev; >> +err = sysfs_create_link(>mdio.dev.kobj, >dev.kobj,

RE: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

Hi Florian, > > I knew that it is applied to net-next. > > However, sysfs_create_link() fails when fixed phy > (drivers/net/phy/fixed_phy.c) > > Do you have a chance to test with it? > > I did, my main test system (BCM7445 w/ bcm_sf2) has one normal PHY > driver and 3 fixed PHYs (including one

Re: [patch iproute2 v2 repost 1/3] tc_filter: add support for chain index

On Fri, 26 May 2017 21:48:05 +0200 Daniel Borkmann wrote: > On 05/23/2017 03:40 PM, Jiri Pirko wrote: > > Mon, May 22, 2017 at 10:33:15PM CEST, step...@networkplumber.org wrote: > [...] > >> Applied to net-next branch of iproute2 > > > > Looks like you missed the uapi

Re: [PATCH net-next] net: dsa: remove dsa_port_is_bridged

On 05/26/2017 03:12 PM, Vivien Didelot wrote: > The helper is only used once and makes the code more complicated that it > should. Remove it and reorganize the variables so that it fits on 80 > columns. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian

RE: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

> OK, I am confused now. You are describing what is going on with your > platform right? Can you describe a bit further here what is happening > and with which type of interface? Is this with the CPU interface or > something? Yes. It's on our platform. Like your platform, fixed phy is used to

Re: [patch iproute2 v2 repost 1/3] tc_filter: add support for chain index

On 05/27/2017 02:11 AM, Stephen Hemminger wrote: On Fri, 26 May 2017 21:48:05 +0200 Daniel Borkmann wrote: On 05/23/2017 03:40 PM, Jiri Pirko wrote: Mon, May 22, 2017 at 10:33:15PM CEST, step...@networkplumber.org wrote: [...] Applied to net-next branch of iproute2

RE: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

Hi Florian, > OK, so here is what is happening: macb_mii_init() calls macb_mii_probe() > and so by the time we call phy_connect_direct(), we have not called > register_netdevice() yet, netdev_register_kobject() has not been called > either, and so sysfs_create_link() fails I just found same

RE: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

Hi Florian, > >> OK, so here is what is happening: macb_mii_init() calls macb_mii_probe() > >> and so by the time we call phy_connect_direct(), we have not called > >> register_netdevice() yet, netdev_register_kobject() has not been called > >> either, and so sysfs_create_link() fails > > I

RE: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

> > Yes, that's a very valid point, how about we even do this: > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index f84414b8f2ee..dc666ec13651 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -960,15 +960,21 @@ int

Re: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

On 05/26/2017 06:00 PM, woojung@microchip.com wrote: > Hi Florian, OK, so here is what is happening: macb_mii_init() calls macb_mii_probe() and so by the time we call phy_connect_direct(), we have not called register_netdevice() yet, netdev_register_kobject() has not been

RE: [PATCH] e1000e: use disable_hardirq() also for MSIX vectors in e1000_netpoll()

> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Konstantin Khlebnikov > Sent: Friday, May 19, 2017 12:19 AM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey > T > Cc: Dave Jones

Re: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

Hi Woojung, On 05/26/2017 05:43 PM, woojung@microchip.com wrote: > Hi Florian, > >> OK, so here is what is happening: macb_mii_init() calls macb_mii_probe() >> and so by the time we call phy_connect_direct(), we have not called >> register_netdevice() yet, netdev_register_kobject() has not

Re: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

On 05/26/2017 05:20 PM, woojung@microchip.com wrote: >> OK, I am confused now. You are describing what is going on with your >> platform right? Can you describe a bit further here what is happening >> and with which type of interface? Is this with the CPU interface or >> something? > > Yes.

Re: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

On 05/26/2017 04:52 PM, woojung@microchip.com wrote: > Hi Florian, > >>> I knew that it is applied to net-next. >>> However, sysfs_create_link() fails when fixed phy >> (drivers/net/phy/fixed_phy.c) >>> Do you have a chance to test with it? >> >> I did, my main test system (BCM7445 w/

[PATCH net-next] net: dsa: mv88e6xxx: handle SERDES error appropriately

mv88e6xxx_serdes_power returns an error, so no need to print an error message inside of it. Rather print it in its caller when the error is ignored, which is in the mv88e6xxx_port_disable void function. Catch and return its error in the counterpart mv88e6xxx_port_enable. Fixes: 04aca9938255

Re: [PATCH V5 1/2] rtnl: Add support for netdev event to link messages

On 5/26/17 2:01 PM, Vlad Yasevich wrote: >> Also, generically the IFLA_EVENT attribute should be considered >> independent of NETDEV_ events. >> >> For example, userspace should be notified if the speed / duplex for a >> device changes, so we could have another one of these -- e.g., >>

Re: [PATCH V5 1/2] rtnl: Add support for netdev event to link messages

On 05/26/2017 03:40 PM, David Ahern wrote: > On 5/25/17 9:31 AM, Vladislav Yasevich wrote: >> @@ -911,4 +912,14 @@ enum { >> >> #define IFLA_XDP_MAX (__IFLA_XDP_MAX - 1) >> >> +enum { >> +IFLA_EVENT_UNSPEC, >> +IFLA_EVENT_REBOOT, >> +IFLA_EVENT_FEAT_CHANGE, >> +

[GIT] Networking

1) Fix state pruning in bpf verifier wrt. alignment, from Daniel Borkmann. 2) Handle non-linear SKBs properly in SCTP ICMP parsing, from Davide Caratti. 3) Fix bit field definitions for rss_hash_type of descriptors in mlx5 driver, from Jesper Brouer. 4) Defer slave->link updates until

Re: [patch iproute2 v2 repost 1/3] tc_filter: add support for chain index

On 05/23/2017 03:40 PM, Jiri Pirko wrote: Mon, May 22, 2017 at 10:33:15PM CEST, step...@networkplumber.org wrote: [...] Applied to net-next branch of iproute2 Looks like you missed the uapi part: CC tc_filter.o tc_filter.c: In function ‘tc_filter_modify’: tc_filter.c:159:34:

Re: [PATCH V5 2/2] bonding: Prevent duplicate userspace notification

On 5/25/17 9:31 AM, Vladislav Yasevich wrote: > Whenever a user changes bonding options, a NETDEV_CHANGEINFODATA > notificatin is generated which results in a rtnelink message to > be sent. While runnig 'ip monitor', we can actually see 2 messages, > one a result of the event, and the other a

Re: [PATCH V5 1/2] rtnl: Add support for netdev event to link messages

On 5/25/17 9:31 AM, Vladislav Yasevich wrote: > @@ -911,4 +912,14 @@ enum { > > #define IFLA_XDP_MAX (__IFLA_XDP_MAX - 1) > > +enum { > + IFLA_EVENT_UNSPEC, > + IFLA_EVENT_REBOOT, > + IFLA_EVENT_FEAT_CHANGE, > + IFLA_EVENT_BONDING_FAILOVER, > + IFLA_EVENT_NOTIFY_PEERS, > +

Re: [PATCH net-next v3] ibmvnic: Enable TSO support

From: Thomas Falcon Date: Fri, 26 May 2017 11:15:46 -0500 > Enable TSO in the ibmvnic driver. Scatter-gather is also enabled, > though there currently is no support for scatter-gather in > vNIC-compatible hardware, resulting in forced linearization > of all

Re: [PATCH net-next 00/11] ibmvnic: Driver updates

From: Nathan Fontenot Date: Fri, 26 May 2017 10:30:07 -0400 > This set of patches implements several updates to the ibmvnic driver > to fix issues that have been found in testing. Most of the updates > invovle updating queue handling during driver close and reset >

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

On 05/26/2017 09:20 PM, David Daney wrote: On 05/26/2017 12:09 PM, Daniel Borkmann wrote: On 05/26/2017 05:39 PM, David Daney wrote: On 05/26/2017 08:14 AM, Daniel Borkmann wrote: On 05/26/2017 02:38 AM, David Daney wrote: Since the eBPF machine has 64-bit registers, we only support this in

Re: [patch net-next 00/18] mlxsw: Improve extensibility

From: David Miller Date: Fri, 26 May 2017 15:20:35 -0400 (EDT) > Nice cleanups and consolidation, but like Nikolay I'm not so sure > about all the exports. > > It might even be cleaner (believe it or not) to have the bridge > structure (or at least a subset of it) be

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

On 05/26/2017 12:09 PM, Daniel Borkmann wrote: On 05/26/2017 05:39 PM, David Daney wrote: On 05/26/2017 08:14 AM, Daniel Borkmann wrote: On 05/26/2017 02:38 AM, David Daney wrote: Since the eBPF machine has 64-bit registers, we only support this in 64-bit kernels. As of the writing of this

Re: [patch net-next 00/18] mlxsw: Improve extensibility

From: Jiri Pirko Date: Fri, 26 May 2017 08:37:22 +0200 > Ido says: > > Since the initial introduction of the bridge offload in commit > 56ade8fe3fe1 ("mlxsw: spectrum: Add initial support for Spectrum ASIC") > the per-port struct was used to store both physical properties of

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

On 05/26/2017 05:39 PM, David Daney wrote: On 05/26/2017 08:14 AM, Daniel Borkmann wrote: On 05/26/2017 02:38 AM, David Daney wrote: Since the eBPF machine has 64-bit registers, we only support this in 64-bit kernels. As of the writing of this commit log test-bpf is showing: test_bpf:

Re: [PATCH 0/2] Document and use eeprom-length property

From: Andrew Lunn Date: Fri, 26 May 2017 01:44:42 +0200 > The mv88e6xxx switch driver allows the size of the attached EEPROM to > be described in DT. This property is missing from the binding > documentation. Add it. And make use of it on the ZII Devel B board. > > David, Shawn,

Re: [PATCH v3 net-next 0/5] net: dsa: mv88e6xxx: Add basic SERDES support

From: Andrew Lunn Date: Fri, 26 May 2017 01:03:19 +0200 > Some of the Marvell switches are SERDES interface, which must be > powered up before packets can be passed. This is particularly true on > the 6390, where the SERDES defaults to down, probably to save power. > > This

Re: [PATCH net] ipv4: add reference counting to metrics

From: Eric Dumazet Date: Thu, 25 May 2017 14:27:35 -0700 > From: Eric Dumazet > > Andrey Konovalov reported crashes in ipv4_mtu() > > I could reproduce the issue with KASAN kernels, between > 10.246.7.151 and 10.246.7.152 : > > 1) 20 concurrent

Re: [PATCH net] net: ethernet: ax88796: don't call free_irq without request_irq first

From: Uwe Kleine-König Date: Thu, 25 May 2017 22:54:53 +0200 > The function ax_init_dev (which is called only from the driver's .probe > function) calls free_irq in the error path without having requested the > irq in the first place. So drop the free_irq call in

Re: [PATCH net-next] net: ethernet: ax88796: support generating a random mac address

From: Uwe Kleine-König Date: Thu, 25 May 2017 22:55:11 +0200 > Instead of falling back to 00:00:00:00:00:00 generate a random address > if none is provided via platform data or from the the device's register > space. > > Signed-off-by: Uwe Kleine-König

Re: [PATCH net,v2] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

From: Peter Dawson Date: Fri, 26 May 2017 06:35:18 +1000 > This fix addresses two problems in the way the DSCP field is formulated > on the encapsulating header of IPv6 tunnels. > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=195661 > > 1) The IPv6 tunneling code

Re: [PATCH v2 net-next 0/4] More marvell phy cleanups

From: Andrew Lunn Date: Thu, 25 May 2017 21:42:04 +0200 > This patchset continues the cleanup of the Marvell PHY driver. These > phys use pages to allow more than the 32 registers that fit into the > MDIO address space. Cleanup the code used for changing pages. > > v2 > Reverse

Re: [PATCH net-next] liquidio: fix inaccurate count of napi-processed rx packets reported to Octeon

From: Felix Manlunas Date: Thu, 25 May 2017 10:54:29 -0700 > From: Prasad Kanneganti > > lio_enable_irq (called by napi poll) is reporting to Octeon an inaccurate > count of processed rx packets causing Octeon to eventually stop

Re: [PATCH net-next] liquidio: fix rare pci_driver.probe failure of VF driver

From: Felix Manlunas Date: Thu, 25 May 2017 10:42:14 -0700 > From: Prasad Kanneganti > > There's a rare pci_driver.probe failure of the VF driver that's caused by > PF/VF handshake going out of sync. The culprit is octeon_mbox_write()

Re: [PATCH net v2] sctp: fix ICMP processing if skb is non-linear

From: Davide Caratti Date: Thu, 25 May 2017 19:14:56 +0200 > sometimes ICMP replies to INIT chunks are ignored by the client, even if > the encapsulated SCTP headers match an open socket. This happens when the > ICMP packet is carried by a paged skb: use skb_header_pointer()

Re: [PATCH net-next v2 0/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

From: Andrew Lunn Date: Thu, 25 May 2017 18:42:27 +0200 > On Thu, May 25, 2017 at 09:21:40AM -0700, Florian Fainelli wrote: >> Hi David, Andrew, >> >> This patch series addresses a device topology shortcoming where a program >> scanning /sys would not be able to establish a

Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

On 05/26/2017 04:29 AM, Saeed Mahameed wrote: On Thu, May 25, 2017 at 11:48 PM, Jes Sorensen wrote: On 05/25/2017 06:40 AM, Saeed Mahameed wrote: Hi Jes, No, It is clearly stated in the commit message : "The FPGA is a bump-on-the-wire and thus affects operation of the

Re: [PATCH v5 net-next 0/2] rtnetlink: Updates to rtnetlink_event()

From: Vladislav Yasevich Date: Thu, 25 May 2017 11:31:53 -0400 > This is a version 5 series came out of the conversation that started > as a result my first attempt to add netdevice event info to netlink > messages. David Ahern, please review. Thanks.

Re: [PATCH 1/5] MIPS: Optimize uasm insn lookup.

On 05/26/2017 01:07 AM, Matt Redfearn wrote: [...] -{ insn_lwx, 0, 0 }, -{ insn_ldx, 0, 0 }, -{ insn_invalid, 0, 0 } +static struct insn insn_table_MM[insn_invalid] = { ^ You could make this const too, like you have the one in uasm-mips.c. Good catch. I meant to do that. I

Re: [PATCH] net: llc: add lock_sock in llc_ui_bind to avoid a race condition

From: Lin Zhang Date: Thu, 25 May 2017 14:07:18 +0800 > There is a race condition in llc_ui_bind if two or more processes/threads > try to bind a same socket. > > If more processes/threads bind a same socket success that will lead to > two problems, one is this action

Re: [PATCH net-next v2 0/8] net: extend RTM_GETROUTE to return fib result

From: Roopa Prabhu Date: Thu, 25 May 2017 10:42:32 -0700 > This series adds a new RTM_F_FIB_MATCH flag to return matched fib result > with RTM_GETROUTE. This is useful for applications and protocols in > userspace wanting to query the selected route. Looks good,

Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

On Fri, May 26, 2017 at 10:56:25AM -0700, Alexei Starovoitov wrote: > > for that feature which is the originating place, before defining > > APIs/infrastructures, > > until the feature is complete and every body is happy about it. > > There is driver/fpga to manage fpga, but mlx fpga+nic combo >

Dearest One.

Dear Ma/Sir, My Name is Miss Safiatou Ibrahim from Libya, I am 22 years old, I am in St. Christopher's Parish for refugee in Burkina Faso under United Nations High commission for Refugee ,I lost my parents in the recent war in Libya, right now am in Burkina Faso, please save my life i am in

Re: [for-next 5/6] net/mlx5: Bump driver version

On Fri, May 26, 2017 at 12:55:22PM -0400, Dennis Dalessandro wrote: > On 5/26/2017 12:35 PM, Saeed Mahameed wrote: > > On Fri, May 26, 2017 at 3:56 PM, Dennis Dalessandro > > wrote: > > > On 5/23/2017 7:44 AM, Saeed Mahameed wrote: > > > Anyway i don't think we are

Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

On Fri, May 26, 2017 at 11:59:26AM +0300, Saeed Mahameed wrote: > > And for FPGA support, we did it correctly this time, all the new code > is under mlx5/core/fgpa .. s/correctly/incorrectly/ ? > Well, this is a well known dilemma, if one has a new feature and has no > sandbox > area to put it

[PATCH] tcp: reinitialize MTU probing when setting MSS in a TCP repair

From: Douglas Caetano dos Santos MTU probing initialization occurred only at connect() and at SYN or SYN-ACK reception, but the former sets MSS to either the default or the user set value (through TCP_MAXSEG sockopt) and the latter never happens with repaired sockets.

Re: [PATCH net] ipv4: add reference counting to metrics

On Fri, May 26, 2017 at 10:13 AM, Eric Dumazet wrote: > On Fri, May 26, 2017 at 10:08 AM, Cong Wang wrote: >> On Thu, May 25, 2017 at 2:27 PM, Eric Dumazet wrote: > >> Just one nit below. >> >>> -const u32

Re: [PATCH net-next 1/2] net: ndisc.c: fix coding style issue

Hi, 2017-05-26 22:55 GMT+09:00 yuan linyu : > On 五, 2017-05-26 at 22:45 +0900, 吉藤英明 wrote: >> Hi, >> >> 2017-05-26 22:23 GMT+09:00 yuan linyu : >> > >> > From: yuan linyu >> > >> > Signed-off-by: yuan linyu

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

Hi David, [auto build test ERROR on linus/master] [also build test ERROR on v4.12-rc2] [cannot apply to next-20170526] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/David-Daney/MIPS-Implement

Re: [PATCH net] ipv4: add reference counting to metrics

On Fri, May 26, 2017 at 10:08 AM, Cong Wang wrote: > On Thu, May 25, 2017 at 2:27 PM, Eric Dumazet wrote: > Just one nit below. > >> -const u32 dst_default_metrics[RTAX_MAX + 1] = { >> +const struct dst_metrics dst_default_metrics = { >>

Re: [PATCH net] ipv4: add reference counting to metrics

On Thu, May 25, 2017 at 2:27 PM, Eric Dumazet wrote: > From: Eric Dumazet > > Andrey Konovalov reported crashes in ipv4_mtu() > > I could reproduce the issue with KASAN kernels, between > 10.246.7.151 and 10.246.7.152 : > > 1) 20 concurrent netperf -t

Re: [Patch net-next] net_sched: only create filter chains for new filters/actions

On Fri, May 26, 2017 at 7:54 AM, David Miller wrote: > And I also didn't find the boolean logic hard to understand at all. > > It is in fact a very common pattern to pass a "create" boolean into > lookup functions, to tell them whether to create a new object on > lookup

Re: [for-next 5/6] net/mlx5: Bump driver version

On 5/26/2017 12:35 PM, Saeed Mahameed wrote: On Fri, May 26, 2017 at 3:56 PM, Dennis Dalessandro wrote: On 5/23/2017 7:44 AM, Saeed Mahameed wrote: From: Tariq Toukan Remove date and bump version for mlx5_core driver. Signed-off-by: Tariq

Re: A bug report for Linux TCP congestion control algorithms

On Thu, May 25, 2017 at 11:08 PM, Wei Sun wrote: > > Hi there, > > we find a special case for Linux TCP undo operations where > tp->snd_cwnd could be extremely large (e.g., 4294967294) by two > consecutive cwnd undo operations when using >

Re: [PATCH] mwifiex: simplify the code around ra_list

On Fri, May 26, 2017 at 09:41:49AM +0800, Shawn Lin wrote: > We don't need to check if the list is empty separately > as we could use list_first_entry_or_null to cover it. > > Signed-off-by: Shawn Lin Looks fine to me. Reviewed-by: Brian Norris

Re: [for-next 5/6] net/mlx5: Bump driver version

On Fri, May 26, 2017 at 3:56 PM, Dennis Dalessandro wrote: > On 5/23/2017 7:44 AM, Saeed Mahameed wrote: >> >> From: Tariq Toukan >> >> Remove date and bump version for mlx5_core driver. >> >> Signed-off-by: Tariq Toukan >>

[PATCH v2 6/6] stmmac: pci: Remove setup handler indirection via stmmac_pci_info

By now, stmmac_pci_info only contains a single entry. Register this directly with the PCI device table, removing one indirection. Signed-off-by: Jan Kiszka --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 35 +--- 1 file changed, 13

[PATCH v2 3/6] stmmac: pci: Make stmmac_pci_find_phy_addr truly generic

Move the special case for the early Galileo firmware into quark_default_setup. This allows to use stmmac_pci_find_phy_addr for non-quark cases. Signed-off-by: Jan Kiszka --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 19 --- 1 file changed, 12

[PATCH net-next v3] ibmvnic: Enable TSO support

Enable TSO in the ibmvnic driver. Scatter-gather is also enabled, though there currently is no support for scatter-gather in vNIC-compatible hardware, resulting in forced linearization of all fragmented SKB's. Though not ideal, given the throughput improvement gained by enabling TSO, it has been

Re: [PATCH net-next] ibmvnic: Enable TSO support

On 05/25/2017 01:49 PM, David Miller wrote: > From: David Miller > Date: Thu, 25 May 2017 14:46:26 -0400 (EDT) > >> From: Thomas Falcon >> Date: Wed, 24 May 2017 21:29:26 -0500 >> >>> The feature is also enabled by a module parameter. >>> This

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

On 05/25/2017 07:23 PM, Alexei Starovoitov wrote: On Thu, May 25, 2017 at 05:38:26PM -0700, David Daney wrote: Since the eBPF machine has 64-bit registers, we only support this in 64-bit kernels. As of the writing of this commit log test-bpf is showing: test_bpf: Summary: 316 PASSED, 0

[PATCH v2 2/6] stmmac: pci: Use stmmac_pci_info for all devices

Make stmmac_default_data compatible with stmmac_pci_info.setup and use an info structure for all devices. This allows to make the probing more regular. Signed-off-by: Jan Kiszka --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 33 +++- 1 file

[PATCH v2 1/6] stmmac: pci: Make stmmac_pci_info structure constant

By removing the PCI device reference from the structure and passing it as parameters to the interested functions, we can make quark_pci_info const. Signed-off-by: Jan Kiszka --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 23 +++ 1 file

[PATCH v2 4/6] stmmac: pci: Select quark_pci_dmi_data from quark_default_data

No need to carry this reference in stmmac_pci_info - the Quark-specific setup handler knows that it needs to use the Quark-specific DMI table. This also allows to drop the stmmac_pci_info reference from the setup handler parameter list. Signed-off-by: Jan Kiszka ---

[PATCH v2 5/6] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses

Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr. Signed-off-by: Jan Kiszka --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 77 ++-- 1 file changed, 45 insertions(+), 32 deletions(-) diff --git

[PATCH v2 0/6] stmmac: pci: Refactor DMI probing

Some cleanups of the way we probe DMI platforms in the driver. Reduces a bit of open-coding and makes the logic easier reusable for any potential DMI platform != Quark. Tested on IOT2000 and Galileo Gen2. Changes in v2: - fixed bug that broke x86-64 build (and likely more) - refactored series

Re: [PATCH net-next 3/4] tls: kernel TLS support

On Fri, 2017-05-26 at 11:18 -0400, David Miller wrote: > From: Eric Dumazet > Date: Fri, 26 May 2017 07:16:59 -0700 > > > On Wed, 2017-05-24 at 09:27 -0700, Dave Watson wrote: > >> Software implementation of transport layer security, implemented using ULP > >>

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

On Thu, 25 May 2017 23:58:30 -0400 (EDT) David Miller wrote: > From: Stephen Hemminger > Date: Thu, 25 May 2017 15:05:02 -0700 > > > Ok, the issue is that lockdep is being stupid and thinking that > > seqcount's behave like locks. > > Well..

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

On 05/26/2017 08:14 AM, Daniel Borkmann wrote: On 05/26/2017 02:38 AM, David Daney wrote: Since the eBPF machine has 64-bit registers, we only support this in 64-bit kernels. As of the writing of this commit log test-bpf is showing: test_bpf: Summary: 316 PASSED, 0 FAILED, [308/308

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

On 05/26/2017 05:14 PM, Daniel Borkmann wrote: On 05/26/2017 02:38 AM, David Daney wrote: Since the eBPF machine has 64-bit registers, we only support this in 64-bit kernels. As of the writing of this commit log test-bpf is showing: test_bpf: Summary: 316 PASSED, 0 FAILED, [308/308 JIT'ed]

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

From: David Daney Date: Thu, 25 May 2017 17:38:26 -0700 > +static int gen_int_prologue(struct jit_ctx *ctx) > +{ > + int stack_adjust = 0; > + int store_offset; > + int locals_size; > + > + if (ctx->flags & EBPF_SAVE_RA) > + /* > +

Re: [PATCH net-next 3/4] tls: kernel TLS support

From: Eric Dumazet Date: Fri, 26 May 2017 07:16:59 -0700 > On Wed, 2017-05-24 at 09:27 -0700, Dave Watson wrote: >> Software implementation of transport layer security, implemented using ULP >> infrastructure. tcp proto_ops are replaced with tls equivalents of sendmsg

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

On 05/26/2017 02:38 AM, David Daney wrote: Since the eBPF machine has 64-bit registers, we only support this in 64-bit kernels. As of the writing of this commit log test-bpf is showing: test_bpf: Summary: 316 PASSED, 0 FAILED, [308/308 JIT'ed] All current test cases are successfully

Re: [PATCH net-next v2 0/6] nfp: devlink port implementation

From: Jiri Pirko Date: Fri, 26 May 2017 10:25:32 +0200 > Fri, May 26, 2017 at 10:03:30AM CEST, jakub.kicin...@netronome.com wrote: >>Hi! >> >>This series adds basic devlink support. The operations we can perform >>are port show and port split/unsplit. >> >>v2: >>Register

  1   2   >