RE: [PATCH net-next 1/8] qed: LL2 to use packed information for tx

2017-06-09 Thread David Laight
From: Mintz, Yuval > Sent: 09 June 2017 08:52 > > From: David Laight [mailto:david.lai...@aculab.com] > > Sent: Friday, June 09, 2017 10:28 AM > > To: 'David Miller' ; Mintz, Yuval > > > > Cc: netdev@vger.kernel.org; linux-r...@vger.kernel.org;

Re: [PATCH net] net/flow: fix fc->percpu NULL pointer dereference

2017-06-09 Thread Hangbin Liu
Hi Steffen, BTW, If we put the check in xfrm_policy_flush(), we can prevent it earlier. But If we put the check in flow_cache_percpu_empty(), we can prevent other functions set fc->percpu to NULL, although not much possible : ) So I'm not quite sure whether we should put the check in

Re: [PATCH 1/5] net: mvpp2: remove mvpp2_bm_cookie_{build,pool_get}

2017-06-09 Thread kbuild test robot
-and-cleanups/20170609-083211 config: arm64-defconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save

[PATCH net] net/flow: fix fc->percpu NULL pointer dereference

2017-06-09 Thread Hangbin Liu
Now we will force to do garbage collection if any policy removed in xfrm_policy_flush(). But during xfrm_net_exit(). We call flow_cache_fini() first and set set fc->percpu to NULL. Then after we call xfrm_policy_fini() -> frxm_policy_flush() -> flow_cache_flush(), we will get NULL pointer

Re: [PATCH] wireless: wlcore: spi: remove unnecessary variable

2017-06-09 Thread Kalle Valo
"Gustavo A. R. Silva" writes: > Remove unnecessary variable and refactor the code. > > Addresses-Coverity-ID: 1365000 > Signed-off-by: Gustavo A. R. Silva I'll remove "wireless:" from the prefix. -- Kalle Valo

RE: [PATCH net-next 1/8] qed: LL2 to use packed information for tx

2017-06-09 Thread Mintz, Yuval
> -Original Message- > From: David Laight [mailto:david.lai...@aculab.com] > Sent: Friday, June 09, 2017 10:28 AM > To: 'David Miller' ; Mintz, Yuval > > Cc: netdev@vger.kernel.org; linux-r...@vger.kernel.org; Kalderon, Michal >

RE: [PATCH net-next 1/8] qed: LL2 to use packed information for tx

2017-06-09 Thread David Laight
From: David Miller > Sent: 09 June 2017 00:24 > > From: Yuval Mintz > Date: Thu, 8 Jun 2017 19:13:16 +0300 > > > @@ -67,6 +79,21 @@ struct qed_ll2_stats { > > u64 sent_bcast_pkts; > > }; > > > > +struct qed_ll2_tx_pkt_info { > > + u8 num_of_bds; > > + u16 vlan;

RE: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

2017-06-09 Thread 高峰
> From: Sven Eckelmann [mailto:s...@narfation.org] > Sent: Friday, June 9, 2017 3:23 PM > Subject: Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks > when fail to register_netdevice > > On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote: > > From: Gao Feng

Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

2017-06-09 Thread Sven Eckelmann
On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote: > From: Gao Feng > > Because the func batadv_softif_init_late allocate some resources and > it would be invoked in register_netdevice. So we need to invoke the > func batadv_softif_free instead of

Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver

2017-06-09 Thread Belgazal, Netanel
My apologies, I was not aware. Will make sure this won't happen again. Regards, Netanel From: David Miller Sent: Friday, June 9, 2017 2:17 AM To: Belgazal, Netanel Cc: netdev@vger.kernel.org; Woodhouse, David; Machulsky, Zorik;

Re: [PATCH 2/2 net-next] net: stmmac: Improve documentation on AVB parameters

2017-06-09 Thread Giuseppe CAVALLARO
Hi Joao On 6/8/2017 8:02 PM, Joao Pinto wrote: This patch fixes the description of the DT AVB parameters and gives an accurate example. It was also included the base values that were used to get the example' CBS paremeter values. Signed-off-by: Joao Pinto ---

RE: [PATCH net-next 1/8] qed: LL2 to use packed information for tx

2017-06-09 Thread Mintz, Yuval
> > +struct qed_ll2_tx_pkt_info { > > + u8 num_of_bds; > > + u16 vlan; > > + u8 bd_flags; > > + u16 l4_hdr_offset_w;/* from start of packet */ > > + enum qed_ll2_tx_dest tx_dest; > > + enum qed_ll2_roce_flavor_type qed_roce_flavor; > > + dma_addr_t first_frag; > > + u16

[PATCH net-next 8/8] net: ena: bug fix in lost tx packets detection mechanism

2017-06-09 Thread netanel
From: Netanel Belgazal check_for_missing_tx_completions() is called from a timer task and looking for lost tx packets. The old implementation accumulate all the lost tx packets and did not check if those packets were retrieved on a later stage. This cause to a situation where

[PATCH net-next 6/8] net: ena: fix theoretical Rx stuck on low memory systems

2017-06-09 Thread netanel
From: Netanel Belgazal For the rare case where the device runs out of free rx buffer descriptors (in case of pressure on kernel memory), and the napi handler continuously fail to refill new Rx descriptors until device rx queue totally runs out of all free rx buffers to post

[PATCH net-next 7/8] net: ena: disable admin msix while working in polling mode

2017-06-09 Thread netanel
From: Netanel Belgazal Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c index

[PATCH net-next 5/8] net: ena: add missing unmap bars on device removal

2017-06-09 Thread netanel
From: Netanel Belgazal This patch also change the mapping functions to devm_ functions Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git

[PATCH net-next 3/8] net: ena: add missing return when ena_com_get_io_handlers() fails

2017-06-09 Thread netanel
From: Netanel Belgazal Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c

[PATCH net-next 6/8] net: ena: fix theoretical Rx hang on low memory systems

2017-06-09 Thread netanel
From: Netanel Belgazal For the rare case where the device runs out of free rx buffer descriptors (in case of pressure on kernel memory), and the napi handler continuously fail to refill new Rx descriptors until device rx queue totally runs out of all free rx buffers to post

[PATCH net-next 2/8] net: ena: fix bug that might cause hang after consecutive open/close interface.

2017-06-09 Thread netanel
From: Netanel Belgazal Fixing a bug that the driver does not unmask the IO interrupts in ndo_open(): occasionally, the MSI-X interrupt (for one or more IO queues) can be masked when ndo_close() was called. If that is followed by ndo open(), then the MSI-X will be still masked

[PATCH net-next 1/8] net: ena: fix rare uncompleted admin command false alarm

2017-06-09 Thread netanel
From: Netanel Belgazal The current flow to detect admin completion is: while (command_not_completed) { if (timeout) error check_for_completion() sleep() } So in case the sleep took more than the timeout (in case the

[PATCH net-next 0/8] Bug fixes in ena ethernet driver

2017-06-09 Thread netanel
From: Netanel Belgazal This patchset contains fixes for the bugs that were discovered so far. Netanel Belgazal (8): net: ena: fix rare uncompleted admin command false alarm net: ena: fix bug that might cause hang after consecutive open/close interface. net: ena:

[PATCH net-next 4/8] net: ena: fix race condition between submit and completion admin command

2017-06-09 Thread netanel
From: Netanel Belgazal Bug: "Completion context is occupied" error printout will be noticed in dmesg. This error will cause the admin command to fail, which will lead to an ena_probe() failure or a watchdog reset (depends on which admin command failed). Root cause:

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Antoine Tenart
Hi Andrew, On Thu, Jun 08, 2017 at 06:03:31PM +0200, Andrew Lunn wrote: > On Thu, Jun 08, 2017 at 11:26:52AM +0200, Antoine Tenart wrote: > > +#define MVMDIO_XSMI_MGNT_REG 0x0 > > +#define MVMDIO_XSMI_READ_VALIDBIT(29) > > +#define MVMDIO_XSMI_BUSY BIT(30) > >

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Antoine Tenart
Hello Florian, Andrew, On Thu, Jun 08, 2017 at 06:55:46PM +0200, Andrew Lunn wrote: > On Thu, Jun 08, 2017 at 09:42:21AM -0700, Florian Fainelli wrote: > > On 06/08/2017 02:26 AM, Antoine Tenart wrote: > > > This patch adds the xMDIO interface support in the mvmdio driver. This > > > interface is

Re: [PATCH net] ipv4: igmp: fix a use after free

2017-06-09 Thread Xin Long
On Fri, Jun 9, 2017 at 2:05 PM, Cong Wang wrote: > On Thu, Jun 8, 2017 at 6:37 PM, Eric Dumazet wrote: >> On Thu, 2017-06-08 at 17:59 -0700, Cong Wang wrote: >>> On Thu, Jun 8, 2017 at 1:33 PM, Eric Dumazet wrote: >>> > I

Re: [PATCH net] ipv4: igmp: fix a use after free

2017-06-09 Thread Xin Long
On Fri, Jun 9, 2017 at 8:59 AM, Cong Wang wrote: > On Thu, Jun 8, 2017 at 1:33 PM, Eric Dumazet wrote: >> I mentioned (in https://lkml.org/lkml/2017/5/31/619 ) that we might need >> to defer freeing after rcu grace period but for some reason

ixgbe tx hang with XDP_TX beyond queue limit

2017-06-09 Thread Brenden Blanco
Hi, I am doing some XDP testing on a dual socket, combined 40 core machine with ixgbe. I have found that with the default settings, depending on which core a packet is received on, the xdp tx queue will hang with: ixgbe :01:00.0 eno1: Detected Tx Unit Hang (XDP) Tx Queue

Re: [PATCH net] ipv4: igmp: fix a use after free

2017-06-09 Thread Cong Wang
On Thu, Jun 8, 2017 at 6:37 PM, Eric Dumazet wrote: > On Thu, 2017-06-08 at 17:59 -0700, Cong Wang wrote: >> On Thu, Jun 8, 2017 at 1:33 PM, Eric Dumazet wrote: >> > I mentioned (in https://lkml.org/lkml/2017/5/31/619 ) that we might need >> > to

<    1   2   3