[PATCH 00/10] Constify isdn pci_device_id's.

2017-07-14 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. Arvind Yadav (10): [PATCH 01/10] isdn: hisax: constify pci_device_id. [PATCH 02/10] isdn: hisax: hfc4s8s_l1:

[PATCH 01/10] isdn: hisax: constify pci_device_id.

2017-07-14 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 1368620644416 201664ec6

Re: [PATCH 05/14] isdn: isdnloop: suppress a gcc-7 warning

2017-07-14 Thread Kevin Easton
On Fri, Jul 14, 2017 at 12:37:05PM +0200, Arnd Bergmann wrote: > On Fri, Jul 14, 2017 at 12:08 PM, Joe Perches wrote: > > On Fri, 2017-07-14 at 11:25 +0200, Arnd Bergmann wrote: > >> We test whether a bit is set in a mask here, which is correct > >> but gcc warns about it as it

[PATCH 02/10] isdn: hisax: hfc4s8s_l1: constify pci_device_id.

2017-07-14 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 10512 536 4 110522b2c

[PATCH 03/10] isdn: hisax: hisax_fcpcipnp: constify pci_device_id.

2017-07-14 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 5989 576 0656519a5

[PATCH 04/10] isdn: eicon: constify pci_device_id.

2017-07-14 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 6224 655 868871ae7

[PATCH 06/10] isdn: mISDN: hfcmulti: constify pci_device_id.

2017-07-14 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 6345015361492 66478 103ae

[PATCH 07/10] isdn: mISDN: w6692: constify pci_device_id.

2017-07-14 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 139594080 24 18063468f

[PATCH 05/10] isdn: mISDN: netjet: constify pci_device_id.

2017-07-14 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 109411776 16 1273331bd

[PATCH 08/10] isdn: mISDN: avmfritz: constify pci_device_id.

2017-07-14 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 99631936 16 119152e8b

[PATCH 09/10] isdn: mISDN: hfcpci: constify pci_device_id.

2017-07-14 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 216561024 96 2277658f8

[PATCH 10/10] isdn: avm: c4: constify pci_device_id.

2017-07-14 Thread Arvind Yadav
pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 11803 544 1 12348303c

Re: [PATCH 1/6] [next-queue]net: mqprio: Introduce new hardware offload mode in mqprio for offloading full TC configurations

2017-07-14 Thread Nambiar, Amritha
On 7/14/2017 1:36 AM, Jamal Hadi Salim wrote: On 17-07-11 06:18 AM, Amritha Nambiar wrote: This patch introduces a new hardware offload mode in mqprio which makes full use of the mqprio options, the TCs, the queue configurations and the bandwidth rates for the TCs. This is achieved by setting

Re: [PATCH net-next 2/4] net-next: mediatek: add platform data to adapt into various hardware

2017-07-14 Thread Sean Wang
On Wed, 2017-07-12 at 16:50 +0200, Andrew Lunn wrote: > > +static int mtk_clk_enable(struct mtk_eth *eth) > > +{ > > + int clk, ret; > > + > > + for (clk = 0; clk < MTK_CLK_MAX ; clk++) { > > + if (eth->clks[clk]) { > > + ret = clk_prepare_enable(eth->clks[clk]); >

[PATCH RFC, iproute2] tc/mqprio: Add support to configure bandwidth rate limit through mqprio

2017-07-14 Thread Amritha Nambiar
Support bandwidth rate limit information for a traffic class in addition to the number of TCs and associated queue configuration data. This is supported in the new hardware offload mode in mqprio by setting the value of 'hw' option to 2. This new hardware offload mode in mqprio makes full use of

Re: [PATCH net 1/5] tcp_bbr: cut pacing rate only if filled pipe

2017-07-14 Thread Neal Cardwell
On Fri, Jul 14, 2017 at 7:15 PM, Stephen Hemminger wrote: > On Fri, 14 Jul 2017 18:54:02 -0400 > Neal Cardwell wrote: > >> On Fri, Jul 14, 2017 at 6:36 PM, Stephen Hemminger >> wrote: >> > On Fri, 14 Jul 2017 17:49:21

Re: [PATCH net 1/5] tcp_bbr: cut pacing rate only if filled pipe

2017-07-14 Thread Stephen Hemminger
On Fri, 14 Jul 2017 18:54:02 -0400 Neal Cardwell wrote: > On Fri, Jul 14, 2017 at 6:36 PM, Stephen Hemminger > wrote: > > On Fri, 14 Jul 2017 17:49:21 -0400 > > Neal Cardwell wrote: > > > >> In bbr_set_pacing_rate(),

[PATCH net 1/2] net: bcmgenet: Fix unmapping of fragments in bcmgenet_xmit()

2017-07-14 Thread Doug Berger
In case we fail to map a single fragment, we would be leaving the transmit ring populated with stale entries. This commit introduces the helper function bcmgenet_put_txcb() which takes care of rewinding the per-ring write pointer back to where we left. It also consolidates the functionality of

[PATCH net 0/2] Fragmented SKB corrections

2017-07-14 Thread Doug Berger
Two issues were observed in a review of the bcmgenet driver support for fragmented SKBs which are addressed by this patch set. The first addresses a problem that could occur if the driver is not able to DMA map a fragment of the SKB. This would be a highly unusual event but it would leave the

[PATCH net 2/2] net: bcmgenet: Free skb after last Tx frag

2017-07-14 Thread Doug Berger
Since the skb is attached to the first control block of a fragmented skb it is possible that the skb could be freed when reclaiming that control block before all fragments of the skb have been consumed by the hardware and unmapped. This commit introduces first_cb and last_cb pointers to the skb

Re: [PATCH net 1/5] tcp_bbr: cut pacing rate only if filled pipe

2017-07-14 Thread Neal Cardwell
On Fri, Jul 14, 2017 at 6:36 PM, Stephen Hemminger wrote: > On Fri, 14 Jul 2017 17:49:21 -0400 > Neal Cardwell wrote: > >> In bbr_set_pacing_rate(), which decides whether to cut the pacing >> rate, there was some code that considered exiting

Re: [PATCH 13/22] liquidio: fix possible eeprom format string overflow

2017-07-14 Thread Burla, Satananda
The 07/14/2017 09:04, David Miller wrote: > From: Arnd Bergmann > Date: Fri, 14 Jul 2017 14:07:05 +0200 > > > gcc reports that the temporary buffer for computing the > > string length may be too small here: > > > > drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function >

Re: [PATCH net 1/5] tcp_bbr: cut pacing rate only if filled pipe

2017-07-14 Thread Stephen Hemminger
On Fri, 14 Jul 2017 17:49:21 -0400 Neal Cardwell wrote: > In bbr_set_pacing_rate(), which decides whether to cut the pacing > rate, there was some code that considered exiting STARTUP to be > equivalent to the notion of filling the pipe (i.e., > bbr_full_bw_reached()).

Re: Quirks of the Atheros 8035 PHY

2017-07-14 Thread Mason
On 14/07/2017 23:28, Florian Fainelli wrote: > On 07/14/2017 02:08 PM, Mason wrote: > >> I've discussed this subject in the past, but we never reached >> a conclusion, AFAIR. >> >> The Atheros 8035 GigE PHY has IMO 2 quirks wrt to clock delays. >> >>

Re: [PATCH v2 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2017-07-14 Thread Florian Fainelli
On 07/14/2017 01:48 PM, Moritz Fischer wrote: > Add support for the National Instruments XGE 1/10G network device. > > It uses the EEPROM on the board via NVMEM. > > Signed-off-by: Moritz Fischer > --- > + > +static void nixge_handle_link_change(struct net_device *ndev) > +{ >

[PATCH net 3/5] tcp_bbr: introduce bbr_init_pacing_rate_from_rtt() helper

2017-07-14 Thread Neal Cardwell
Introduce a helper to initialize the BBR pacing rate unconditionally, based on the current cwnd and RTT estimate. This is a pure refactor, but is needed for two following fixes. Fixes: 0f8782ea1497 ("tcp_bbr: add BBR congestion control") Signed-off-by: Neal Cardwell

[PATCH net 5/5] tcp_bbr: init pacing rate on first RTT sample

2017-07-14 Thread Neal Cardwell
Fixes the following behavior: for connections that had no RTT sample at the time of initializing congestion control, BBR was initializing the pacing rate to a high nominal rate (based an a guess of RTT=1ms, in case this is LAN traffic). Then BBR never adjusted the pacing rate downward upon

[PATCH net 4/5] tcp_bbr: remove sk_pacing_rate=0 transient during init

2017-07-14 Thread Neal Cardwell
Fix a corner case noticed by Eric Dumazet, where BBR's setting sk->sk_pacing_rate to 0 during initialization could theoretically cause packets in the sending host to hang if there were packets "in flight" in the pacing infrastructure at the time the BBR congestion control state is initialized.

[PATCH net 1/5] tcp_bbr: cut pacing rate only if filled pipe

2017-07-14 Thread Neal Cardwell
In bbr_set_pacing_rate(), which decides whether to cut the pacing rate, there was some code that considered exiting STARTUP to be equivalent to the notion of filling the pipe (i.e., bbr_full_bw_reached()). Specifically, as the code was structured, exiting STARTUP and going into PROBE_RTT could

[PATCH net 2/5] tcp_bbr: introduce bbr_bw_to_pacing_rate() helper

2017-07-14 Thread Neal Cardwell
Introduce a helper to convert a BBR bandwidth and gain factor to a pacing rate in bytes per second. This is a pure refactor, but is needed for two following fixes. Fixes: 0f8782ea1497 ("tcp_bbr: add BBR congestion control") Signed-off-by: Neal Cardwell Signed-off-by:

Re: Quirks of the Atheros 8035 PHY

2017-07-14 Thread Florian Fainelli
On 07/14/2017 02:08 PM, Mason wrote: > Hello, > > I've discussed this subject in the past, but we never reached > a conclusion, AFAIR. > > The Atheros 8035 GigE PHY has IMO 2 quirks wrt to clock delays. > > https://www.redeszone.net/app/uploads/2014/04/AR8035.pdf > > > 1) RX clock delay > >

Re: Quirks of the Atheros 8035 PHY

2017-07-14 Thread Mason
Mugunthan's address bounces. Removing it. Adding Grygorii's address instead. On 14/07/2017 23:08, Mason wrote: > Hello, > > I've discussed this subject in the past, but we never reached > a conclusion, AFAIR. > > The Atheros 8035 GigE PHY has IMO 2 quirks wrt to clock delays. > >

Quirks of the Atheros 8035 PHY

2017-07-14 Thread Mason
Hello, I've discussed this subject in the past, but we never reached a conclusion, AFAIR. The Atheros 8035 GigE PHY has IMO 2 quirks wrt to clock delays. https://www.redeszone.net/app/uploads/2014/04/AR8035.pdf 1) RX clock delay Commit 2e5f9f281ee8369f56d403b4a52942f19b6978f8 In fact, RX

[PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-14 Thread Moritz Fischer
This adds bindings for the NI XGE 1G/10G network device. Signed-off-by: Moritz Fischer --- Documentation/devicetree/bindings/net/nixge.txt | 32 + 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/nixge.txt diff

[PATCH v2 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2017-07-14 Thread Moritz Fischer
Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer --- Changes from v1: - Added dependency on ARCH_ZYNQ (Kbuild) - Removed unused variables - Use of_phy_connect as suggested - Removed

Re: [PATCH v2] sctp: don't dereference ptr before leaving _sctp_walk_{params,errors}()

2017-07-14 Thread kbuild test robot
Hi Alexander, [auto build test WARNING on net-next/master] [also build test WARNING on next-20170714] [cannot apply to v4.12] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Alexander-Potapenko

Re: [iovisor-dev] [PATCH v3 net-next 00/12] bpf: rewrite value tracking in verifier

2017-07-14 Thread Y Song
I did an experiment with one of our internal bpf programs. The program has 1563 insns. Without Edward's patch: processed 13634 insns, stack depth 160 With Edward's patch: processed 15807 insns, stack depth 160 So the number of processed insns regressed by roughly 16%. Did anybody do any similar

Re: [PATCH 18/22] gpio: acpi: fix string overflow for large pin numbers

2017-07-14 Thread Arnd Bergmann
On Fri, Jul 14, 2017 at 2:52 PM, Andy Shevchenko wrote: > On Fri, 2017-07-14 at 14:07 +0200, Arnd Bergmann wrote: >> gcc-7 notices that the pin_table is an array of 16-bit numbers, >> but we assume it can be printed as a two-character hexadecimal >> string: >>

Re: [PATCH 17/22] platform/x86: alienware-wmi: fix format string overflow warning

2017-07-14 Thread Andy Shevchenko
On Fri, Jul 14, 2017 at 10:37 PM, Arnd Bergmann wrote: > On Fri, Jul 14, 2017 at 9:18 PM, Andy Shevchenko > wrote: >> On Fri, Jul 14, 2017 at 3:07 PM, Arnd Bergmann wrote: >>> gcc points out a possible format string overflow for a large

[PATCH V3 net] openvswitch: Fix for force/commit action failures

2017-07-14 Thread Greg Rose
When there is an established connection in direction A->B, it is possible to receive a packet on port B which then executes ct(commit,force) without first performing ct() - ie, a lookup. In this case, we would expect that this packet can delete the existing entry so that we can commit a connection

Re: [PATCH 17/22] platform/x86: alienware-wmi: fix format string overflow warning

2017-07-14 Thread Arnd Bergmann
On Fri, Jul 14, 2017 at 9:18 PM, Andy Shevchenko wrote: > On Fri, Jul 14, 2017 at 3:07 PM, Arnd Bergmann wrote: >> gcc points out a possible format string overflow for a large value of 'zone': >> >> drivers/platform/x86/alienware-wmi.c: In function

Re: [PATCH 17/22] platform/x86: alienware-wmi: fix format string overflow warning

2017-07-14 Thread Andy Shevchenko
On Fri, Jul 14, 2017 at 3:07 PM, Arnd Bergmann wrote: > gcc points out a possible format string overflow for a large value of 'zone': > > drivers/platform/x86/alienware-wmi.c: In function 'alienware_wmi_init': > drivers/platform/x86/alienware-wmi.c:461:24: error: '%02X' directive

Re: [PATCH] ipv6: initialize treq->txhash in cookie_v6_check()

2017-07-14 Thread Neal Cardwell
On Fri, Jul 14, 2017 at 1:35 PM, Alexander Potapenko wrote: > On Fri, Jul 14, 2017 at 7:04 PM, Neal Cardwell wrote: >> On Fri, Jul 14, 2017 at 12:54 PM, Alexander Potapenko >> wrote: >>> KMSAN reported use of uninitialized memory in

Re: [PATCH v2] sctp: don't dereference ptr before leaving _sctp_walk_{params,errors}()

2017-07-14 Thread kbuild test robot
Hi Alexander, [auto build test ERROR on net-next/master] [also build test ERROR on next-20170714] [cannot apply to v4.12] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Alexander-Potapenko/sctp

Re: [PATCH net] openvswitch: Fix for force/commit action failures

2017-07-14 Thread Greg Rose
On 07/14/2017 11:42 AM, Joe Stringer wrote: On 14 July 2017 at 09:10, Greg Rose wrote: > When there is an established connection in direction A->B, it is > possible to receive a packet on port B which then executes > ct(commit,force) without first performing ct() - ie, a

Re: [PATCH net] openvswitch: Fix for force/commit action failures

2017-07-14 Thread Joe Stringer
On 14 July 2017 at 09:10, Greg Rose wrote: > When there is an established connection in direction A->B, it is > possible to receive a packet on port B which then executes > ct(commit,force) without first performing ct() - ie, a lookup. > In this case, we would expect that

RE: [PATCH 17/22] platform/x86: alienware-wmi: fix format string overflow warning

2017-07-14 Thread Mario.Limonciello
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Friday, July 14, 2017 7:07 AM > To: linux-ker...@vger.kernel.org; Darren Hart ; Andy > Shevchenko > Cc: Greg Kroah-Hartman ; Linus Torvalds >

Re: [PATCH net] openvswitch: Fix for force/commit action failures

2017-07-14 Thread Joe Stringer
On 14 July 2017 at 09:10, Greg Rose wrote: > When there is an established connection in direction A->B, it is > possible to receive a packet on port B which then executes > ct(commit,force) without first performing ct() - ie, a lookup. > In this case, we would expect that

[PATCH net-next] tcp: adjust tail loss probe timeout

2017-07-14 Thread Yuchung Cheng
This patch adjusts the timeout formula to schedule the TCP loss probe (TLP). The previous formula uses 2*SRTT or 1.5*RTT + DelayACKMax if only one packet is in flight. It keeps a lower bound of 10 msec which is too large for short RTT connections (e.g. within a data-center). The new formula =

[PATCH net-next,1/1] tools: hv: ignore a NIC if it has been configured

2017-07-14 Thread Simon Xiao
Let bondvf.sh ignore this NIC if it has been configured, to prevent user configuration from being overwritten unexpectly. Signed-off-by: Simon Xiao --- tools/hv/bondvf.sh | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] sctp: don't dereference ptr before leaving _sctp_walk_{params,errors}()

2017-07-14 Thread David Miller
From: Alexander Potapenko Date: Fri, 14 Jul 2017 19:33:54 +0200 > On Fri, Jul 14, 2017 at 7:23 PM, David Miller wrote: >> From: Alexander Potapenko >> Date: Fri, 14 Jul 2017 18:33:01 +0200 >> >>> On Fri, Jul 14, 2017 at 5:58 PM, David

Re: [PATCH v7 3/3] net/cxgb4: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-14 Thread Casey Leedom
Reviewed-by: Casey Leedom

Re: [PATCH] ipv6: initialize treq->txhash in cookie_v6_check()

2017-07-14 Thread Alexander Potapenko
On Fri, Jul 14, 2017 at 7:04 PM, Neal Cardwell wrote: > On Fri, Jul 14, 2017 at 12:54 PM, Alexander Potapenko > wrote: >> KMSAN reported use of uninitialized memory in skb_set_hash_from_sk(), >> which originated from the TCP request socket created in >>

Re: [PATCH v2] sctp: don't dereference ptr before leaving _sctp_walk_{params,errors}()

2017-07-14 Thread Alexander Potapenko
On Fri, Jul 14, 2017 at 7:23 PM, David Miller wrote: > From: Alexander Potapenko > Date: Fri, 14 Jul 2017 18:33:01 +0200 > >> On Fri, Jul 14, 2017 at 5:58 PM, David Miller wrote: >>> From: Alexander Potapenko >>>

Re: [PATCH v2] sctp: don't dereference ptr before leaving _sctp_walk_{params,errors}()

2017-07-14 Thread David Miller
From: Alexander Potapenko Date: Fri, 14 Jul 2017 18:33:01 +0200 > On Fri, Jul 14, 2017 at 5:58 PM, David Miller wrote: >> From: Alexander Potapenko >> Date: Fri, 14 Jul 2017 12:03:29 +0200 >> >>> v2: per comment from David Miller,

Re: [PATCH] ipv6: initialize treq->txhash in cookie_v6_check()

2017-07-14 Thread Neal Cardwell
On Fri, Jul 14, 2017 at 12:54 PM, Alexander Potapenko wrote: > KMSAN reported use of uninitialized memory in skb_set_hash_from_sk(), > which originated from the TCP request socket created in > cookie_v6_check(): ... > --- a/net/ipv6/syncookies.c > +++ b/net/ipv6/syncookies.c >

[PATCH] ipv6: initialize treq->txhash in cookie_v6_check()

2017-07-14 Thread Alexander Potapenko
KMSAN reported use of uninitialized memory in skb_set_hash_from_sk(), which originated from the TCP request socket created in cookie_v6_check(): == BUG: KMSAN: use of uninitialized memory in tcp_transmit_skb+0xf77/0x3ec0 CPU: 1

[PATCH v3] sctp: don't dereference ptr before leaving _sctp_walk_{params,errors}()

2017-07-14 Thread Alexander Potapenko
If the length field of the iterator (|pos.p| or |err|) is past the end of the chunk, we shouldn't access it. This bug has been detected by KMSAN. For the following pair of system calls: socket(PF_INET6, SOCK_STREAM, 0x84 /* IPPROTO_??? */) = 3 sendto(3, "A", 1, MSG_OOB, {sa_family=AF_INET6,

Re: [PATCH v2] sctp: don't dereference ptr before leaving _sctp_walk_{params,errors}()

2017-07-14 Thread Alexander Potapenko
On Fri, Jul 14, 2017 at 5:58 PM, David Miller wrote: > From: Alexander Potapenko > Date: Fri, 14 Jul 2017 12:03:29 +0200 > >> v2: per comment from David Miller, make sure the whole iterator->length >> fits into the remaining buffer. > > Please

[PATCH net] openvswitch: Fix for force/commit action failures

2017-07-14 Thread Greg Rose
When there is an established connection in direction A->B, it is possible to receive a packet on port B which then executes ct(commit,force) without first performing ct() - ie, a lookup. In this case, we would expect that this packet can delete the existing entry so that we can commit a connection

Re: [PATCH 08/22] isdn: divert: fix sprintf buffer overflow warning

2017-07-14 Thread David Miller
From: Arnd Bergmann Date: Fri, 14 Jul 2017 14:07:00 +0200 > One string we pass into the cs->info buffer might be too long, > as pointed out by gcc: > > drivers/isdn/divert/isdn_divert.c: In function 'll_callback': > drivers/isdn/divert/isdn_divert.c:488:22: error: '%d' directive

Re: [PATCH net] sctp: fix an array overflow when all ext chunks are set

2017-07-14 Thread David Miller
From: Xin Long Date: Fri, 14 Jul 2017 22:07:33 +0800 > Marcelo noticed an array overflow caused by commit c28445c3cb07 > ("sctp: add reconf_enable in asoc ep and netns"), in which sctp > would add SCTP_CID_RECONF into extensions when reconf_enable is > set in sctp_make_init

Re: [PATCH 11/22] net: thunder_bgx: avoid format string overflow warning

2017-07-14 Thread David Miller
From: Arnd Bergmann Date: Fri, 14 Jul 2017 14:07:03 +0200 > gcc warns that the temporary buffer might be too small here: > > drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_probe': > drivers/net/ethernet/cavium/thunder/thunder_bgx.c:1020:16: error: '%d' >

Re: [PATCH 13/22] liquidio: fix possible eeprom format string overflow

2017-07-14 Thread David Miller
From: Arnd Bergmann Date: Fri, 14 Jul 2017 14:07:05 +0200 > gcc reports that the temporary buffer for computing the > string length may be too small here: > > drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function > 'lio_get_eeprom_len': >

Re: [PATCH 10/22] bnx2x: fix format overflow warning

2017-07-14 Thread David Miller
From: Arnd Bergmann Date: Fri, 14 Jul 2017 14:07:02 +0200 > gcc notices that large queue numbers would overflow the queue name > string: > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c: In function > 'bnx2x_get_strings': >

Re: [PATCH 12/22] vmxnet3: avoid format strint overflow warning

2017-07-14 Thread David Miller
From: Arnd Bergmann Date: Fri, 14 Jul 2017 14:07:04 +0200 > gcc-7 notices that "-event-%d" could be more than 11 characters long > if we had larger 'vector' numbers: > > drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_activate_dev': >

Re: [PATCH 09/22] net: niu: fix format string overflow warning:

2017-07-14 Thread David Miller
From: Arnd Bergmann Date: Fri, 14 Jul 2017 14:07:01 +0200 > We get a warning for the port_name string that might be longer than > six characters if we had more than 10 ports: > > drivers/net/ethernet/sun/niu.c: In function 'niu_put_parent': >

Re: [PATCH v2] sctp: don't dereference ptr before leaving _sctp_walk_{params,errors}()

2017-07-14 Thread David Miller
From: Alexander Potapenko Date: Fri, 14 Jul 2017 12:03:29 +0200 > v2: per comment from David Miller, make sure the whole iterator->length > fits into the remaining buffer. Please compile and functionally test your changes: In file included from

Re: [PATCH] [for 4.13] net: qcom/emac: fix double free of SGMII IRQ during shutdown

2017-07-14 Thread David Miller
From: Timur Tabi Date: Thu, 13 Jul 2017 15:45:41 -0500 > If the interface is not up, then don't try to close it during a > shutdown. This avoids possible double free of the IRQ, which > can happen during a shutdown. > > Fixes: 03eb3eb4d4d5 ("net: qcom/emac: add shutdown

Re: [PATCH] smsc95xx: use ethtool_op_get_ts_info()

2017-07-14 Thread David Miller
From: Petr Kulhavy Date: Thu, 13 Jul 2017 19:40:57 +0200 > This change enables the use of SW timestamping on Raspberry PI. > > smsc95xx uses the usbnet transmit function usbnet_start_xmit(), which > implements software timestamping. However the SOF_TIMESTAMPING_TX_SOFTWARE >

Re: [PATCH net 1/1] net sched actions: rename act_get_notify() to tcf_get_notify()

2017-07-14 Thread David Miller
From: Roman Mashak Date: Thu, 13 Jul 2017 13:12:18 -0400 > Make name consistent with other TC event notification routines, such as > tcf_add_notify() and tcf_del_notify() > > Signed-off-by: Roman Mashak Applied.

Re: IGMP snooping, switchdev and local multicast receiver on br interface

2017-07-14 Thread Vivien Didelot
Hi All, Andrew Lunn writes: > I've been testing IGMP snooping support with DSA, putting MDB entries > into the switch so that traffic only goes out ports where there has > been an interest indicated via IGMP. It mostly works, but i've come > across one use case which does not. >

Re: [PATCH net] net/packet: Fix Tx queue selection for AF_PACKET

2017-07-14 Thread David Miller
From: Iván Briano Date: Thu, 13 Jul 2017 09:46:58 -0700 > When PACKET_QDISC_BYPASS is not used, Tx queue selection will be done > before the packet is enqueued, taking into account any mappings set by > a queuing discipline such as mqprio without hardware offloading. This

Re: [PATCH net v2] cxgb4: ptp_clock_register() returns error pointers

2017-07-14 Thread David Miller
From: Ganesh Goudar Date: Thu, 13 Jul 2017 18:36:50 +0530 > Check ptp_clock_register() return not only for NULL but > also for error pointers, and also nullify adapter->ptp_clock > if ptp_clock_register() fails. > > Fixes: 9c33e4208bce ("cxgb4: Add PTP Hardware Clock (PHC)

Re: [PATCH net] net: bridge: fix dest lookup when vlan proto doesn't match

2017-07-14 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 13 Jul 2017 16:09:10 +0300 > With 802.1ad support the vlan_ingress code started checking for vlan > protocol mismatch which causes the current tag to be inserted and the > bridge vlan protocol & pvid to be set. The vlan tag

Re: [PATCH net] net: hns: add acpi function of xge led control

2017-07-14 Thread David Miller
From: Date: Thu, 13 Jul 2017 18:57:54 +0800 > From: LiuJian > > The current code only support DT method to control xge led. > This patch is the implementation of acpi method to control xge led. > > Signed-off-by: LiuJian >

Re: [Patch net] netpoll: shut up a kernel warning on refcount

2017-07-14 Thread David Miller
From: Cong Wang Date: Wed, 12 Jul 2017 15:56:41 -0700 > When we convert atomic_t to refcount_t, a new kernel warning > on "increment on 0" is introduced in the netpoll code, > zap_completion_queue(). In fact for this special case, we know > the refcount is 0 and we just

Re: [PATCH V3] Set NTB format again after altsetting switch for Huawei devices

2017-07-14 Thread David Miller
From: Enrico Mioso Date: Tue, 11 Jul 2017 17:21:52 +0200 > Some firmwares in Huawei E3372H devices have been observed to switch back > to NTB 32-bit format after altsetting switch. > This patch implements a driver flag to check for the device settings and > set NTB format to

Re: [PATCH net] mdio: mux: fix parsing mux registers outside of the PHY address range

2017-07-14 Thread David Miller
From: Martin Blumenstingl Date: Mon, 10 Jul 2017 14:35:23 +0200 > mdio_mux_init parses the child nodes of the MDIO mux. When using > "mdio-mux-mmioreg" the child nodes are describing the register value > that is written to switch between the MDIO busses. > >

IGMP snooping, switchdev and local multicast receiver on br interface

2017-07-14 Thread Andrew Lunn
Hi Folks I've been testing IGMP snooping support with DSA, putting MDB entries into the switch so that traffic only goes out ports where there has been an interest indicated via IGMP. It mostly works, but i've come across one use case which does not. I have a multicast listener running on the

[PATCH net] sctp: fix an array overflow when all ext chunks are set

2017-07-14 Thread Xin Long
Marcelo noticed an array overflow caused by commit c28445c3cb07 ("sctp: add reconf_enable in asoc ep and netns"), in which sctp would add SCTP_CID_RECONF into extensions when reconf_enable is set in sctp_make_init and sctp_make_init_ack. Then now when all ext chunks are set, 4 ext chunk ids can

Re: [PATCH 15/22] hwmon: applesmc: fix format string overflow

2017-07-14 Thread Guenter Roeck
On 07/14/2017 05:07 AM, Arnd Bergmann wrote: gcc-7 warns that the key might exceed five bytes for lage index values: drivers/hwmon/applesmc.c: In function 'applesmc_show_fan_position': drivers/hwmon/applesmc.c:906:18: error: '%d' directive writing between 1 and 5 bytes into a region of size 4

Re: [PATCH 19/22] block: DAC960: shut up format-overflow warning

2017-07-14 Thread Jens Axboe
On 07/14/2017 06:07 AM, Arnd Bergmann wrote: > gcc-7 points out that a large controller number would overflow the > string length for the procfs name and the firmware version string: > > drivers/block/DAC960.c: In function 'DAC960_Probe': > drivers/block/DAC960.c:6591:38: warning: 'sprintf' may

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-07-14 Thread Sinan Kaya
On 7/13/2017 9:26 PM, Ding Tianhong wrote: > There is no code to enable the PCIe Relaxed Ordering bit in the configuration > space, > it is only be enable by default according to the PCIe Standard Specification, > what we > do is to distinguish the RC problematic platform and clear the Relaxed

Re: [PATCH 22/22] IB/mlx4: fix sprintf format warning

2017-07-14 Thread Leon Romanovsky
On Fri, Jul 14, 2017 at 02:07:14PM +0200, Arnd Bergmann wrote: > gcc-7 points out that a negative port_num value would overflow > the string buffer: > > drivers/infiniband/hw/mlx4/sysfs.c: In function > 'mlx4_ib_device_register_sysfs': > drivers/infiniband/hw/mlx4/sysfs.c:251:16: error: 'sprintf'

Re: [PATCH 18/22] gpio: acpi: fix string overflow for large pin numbers

2017-07-14 Thread Andy Shevchenko
On Fri, 2017-07-14 at 14:07 +0200, Arnd Bergmann wrote: > gcc-7 notices that the pin_table is an array of 16-bit numbers, > but we assume it can be printed as a two-character hexadecimal > string: > > drivers/gpio/gpiolib-acpi.c: In function > 'acpi_gpiochip_request_interrupt': >

Re: [PATCH 11/22] net: thunder_bgx: avoid format string overflow warning

2017-07-14 Thread Robin Murphy
On 14/07/17 13:07, Arnd Bergmann wrote: > gcc warns that the temporary buffer might be too small here: > > drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_probe': > drivers/net/ethernet/cavium/thunder/thunder_bgx.c:1020:16: error: '%d' > directive writing between 1 and 10

Re: [PATCH 20/22] sound: pci: avoid string overflow warnings

2017-07-14 Thread Takashi Iwai
On Fri, 14 Jul 2017 14:07:12 +0200, Arnd Bergmann wrote: > > With gcc-7, we get various warnings about a possible string overflow: > > sound/pci/rme9652/hdspm.c: In function 'snd_hdspm_create_alsa_devices': > sound/pci/rme9652/hdspm.c:2123:17: error: ' MIDIoverMADI' directive writing > 13 bytes

[PATCH 07/22] scsi: gdth: increase the procfs event buffer size

2017-07-14 Thread Arnd Bergmann
We print a 256 byte event string into a buffer that is only 161 bytes long, this is clearly wrong: drivers/scsi/gdth_proc.c: In function 'gdth_show_info': drivers/scsi/gdth.c:3660:41: error: '%s' directive writing up to 255 bytes into a region of size between 141 and 150

[PATCH 05/22] scsi: gdth: avoid buffer overflow warning

2017-07-14 Thread Arnd Bergmann
gcc notices that we would overflow the buffer for the inquiry of the product name if we have too many adapters: drivers/scsi/gdth.c: In function 'gdth_next': drivers/scsi/gdth.c:2357:29: warning: 'sprintf' may write a terminating nul past the end of the destination [-Wformat-overflow=]

[PATCH 14/22] [media] usbvision-i2c: fix format overflow warning

2017-07-14 Thread Arnd Bergmann
gcc-7 notices that we copy a fixed length string into another string of the same size, with additional characters: drivers/media/usb/usbvision/usbvision-i2c.c: In function 'usbvision_i2c_register': drivers/media/usb/usbvision/usbvision-i2c.c:190:36: error: '%d' directive writing between 1 and

[PATCH 20/22] sound: pci: avoid string overflow warnings

2017-07-14 Thread Arnd Bergmann
With gcc-7, we get various warnings about a possible string overflow: sound/pci/rme9652/hdspm.c: In function 'snd_hdspm_create_alsa_devices': sound/pci/rme9652/hdspm.c:2123:17: error: ' MIDIoverMADI' directive writing 13 bytes into a region of size between 1 and 32 [-Werror=format-overflow=]

[PATCH 22/22] IB/mlx4: fix sprintf format warning

2017-07-14 Thread Arnd Bergmann
gcc-7 points out that a negative port_num value would overflow the string buffer: drivers/infiniband/hw/mlx4/sysfs.c: In function 'mlx4_ib_device_register_sysfs': drivers/infiniband/hw/mlx4/sysfs.c:251:16: error: 'sprintf' may write a terminating nul past the end of the destination

[PATCH 21/22] fscache: fix fscache_objlist_show format processing

2017-07-14 Thread Arnd Bergmann
gcc points out a minor bug in the handling of unknown cookie types, which could result in a string overflow when the integer is copied into a 3-byte string: fs/fscache/object-list.c: In function 'fscache_objlist_show': fs/fscache/object-list.c:265:19: error: 'sprintf' may write a terminating nul

[PATCH 16/22] x86: intel-mid: fix a format string overflow warning

2017-07-14 Thread Arnd Bergmann
We have space for exactly one character for the index in "max7315_%d_base", but as gcc points out having more would cause an string overflow: arch/x86/platform/intel-mid/device_libs/platform_max7315.c: In function 'max7315_platform_data':

[PATCH 19/22] block: DAC960: shut up format-overflow warning

2017-07-14 Thread Arnd Bergmann
gcc-7 points out that a large controller number would overflow the string length for the procfs name and the firmware version string: drivers/block/DAC960.c: In function 'DAC960_Probe': drivers/block/DAC960.c:6591:38: warning: 'sprintf' may write a terminating nul past the end of the destination

[PATCH 18/22] gpio: acpi: fix string overflow for large pin numbers

2017-07-14 Thread Arnd Bergmann
gcc-7 notices that the pin_table is an array of 16-bit numbers, but we assume it can be printed as a two-character hexadecimal string: drivers/gpio/gpiolib-acpi.c: In function 'acpi_gpiochip_request_interrupt': drivers/gpio/gpiolib-acpi.c:206:24: warning: '%02X' directive writing between 2 and 4

[PATCH 17/22] platform/x86: alienware-wmi: fix format string overflow warning

2017-07-14 Thread Arnd Bergmann
gcc points out a possible format string overflow for a large value of 'zone': drivers/platform/x86/alienware-wmi.c: In function 'alienware_wmi_init': drivers/platform/x86/alienware-wmi.c:461:24: error: '%02X' directive writing between 2 and 8 bytes into a region of size 6

[PATCH 15/22] hwmon: applesmc: fix format string overflow

2017-07-14 Thread Arnd Bergmann
gcc-7 warns that the key might exceed five bytes for lage index values: drivers/hwmon/applesmc.c: In function 'applesmc_show_fan_position': drivers/hwmon/applesmc.c:906:18: error: '%d' directive writing between 1 and 5 bytes into a region of size 4 [-Werror=format-overflow=] sprintf(newkey,

[PATCH 11/22] net: thunder_bgx: avoid format string overflow warning

2017-07-14 Thread Arnd Bergmann
gcc warns that the temporary buffer might be too small here: drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_probe': drivers/net/ethernet/cavium/thunder/thunder_bgx.c:1020:16: error: '%d' directive writing between 1 and 10 bytes into a region of size between 9 and 11

  1   2   >