Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-18 Thread Sekhar Nori
On Wednesday 18 October 2017 07:47 PM, Franklin S Cooper Jr wrote: > > > On 10/18/2017 08:24 AM, Sekhar Nori wrote: >> Hi Marc, >> >> On Wednesday 18 October 2017 06:14 PM, Marc Kleine-Budde wrote: >>> On 09/21/2017 02:48 AM, Franklin S Cooper Jr wrote: On 09/20/2017 04:37 PM,

[PATCH net] hv_sock: add locking in the open/close/release code paths

2017-10-18 Thread Dexuan Cui
Without the patch, when hvs_open_connection() hasn't completely established a connection (e.g. it has changed sk->sk_state to SS_CONNECTED, but hasn't inserted the sock into the connected queue), vsock_stream_connect() may see the sk_state change and return the connection to the userspace, and

Re: [PATCH 1/5] net: virtio dynamically disable/enable LRO

2017-10-18 Thread Michael S. Tsirkin
On Wed, Oct 18, 2017 at 07:18:31PM -0700, Caleb Raitto wrote: > On Fri, Nov 18, 2016 at 11:00 AM, John Fastabend > wrote: > > > > From: John Fastabend > > Date: Fri, Nov 18, 2016 at 11:00 AM > > Subject: [PATCH 1/5] net: virtio dynamically

[PATCH net 1/5] net/ncsi: Fix AEN HNCDSC packet length

2017-10-18 Thread Samuel Mendoza-Jonas
Correct the value of the HNCDSC AEN packet. Fixes: 7a82ecf4cfb85 "net/ncsi: NCSI AEN packet handler" Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-aen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c

[PATCH net 3/5] net/ncsi: Disable HWA mode when no channels are found

2017-10-18 Thread Samuel Mendoza-Jonas
From: Gavin Shan When there are no NCSI channels probed, HWA (Hardware Arbitration) mode is enabled. It's not correct because HWA depends on the fact: NCSI channels exist and all of them support HWA mode. This disables HWA when no channels are probed. Signed-off-by:

[PATCH net 2/5] net/ncsi: Stop monitor if channel times out or is inactive

2017-10-18 Thread Samuel Mendoza-Jonas
ncsi_channel_monitor() misses stopping the channel monitor in several places that it should, causing a WARN_ON_ONCE() to trigger when the monitor is re-started later, eg: [ 459.04] WARNING: CPU: 0 PID: 1093 at net/ncsi/ncsi-manage.c:269 ncsi_start_channel_monitor+0x7c/0x90 [ 459.04]

[PATCH net 4/5] net/ncsi: Enforce failover on link monitor timeout

2017-10-18 Thread Samuel Mendoza-Jonas
From: Gavin Shan The NCSI channel has been configured to provide service if its link monitor timer is enabled, regardless of its state (inactive or active). So the timeout event on the link monitor indicates the out-of-service on that channel, for which a failover is

[PATCH net 5/5] net/ncsi: Fix length of GVI response packet

2017-10-18 Thread Samuel Mendoza-Jonas
From: Gavin Shan The length of GVI (GetVersionInfo) response packet should be 40 instead of 36. This issue was found from /sys/kernel/debug/ncsi/eth0/stats. # ethtool --ncsi eth0 swstats : RESPONSE OK TIMEOUT ERROR

RE: [PATCH 1/5] net: virtio dynamically disable/enable LRO

2017-10-18 Thread Caleb Raitto
On Fri, Nov 18, 2016 at 11:00 AM, John Fastabend wrote: > > From: John Fastabend > Date: Fri, Nov 18, 2016 at 11:00 AM > Subject: [PATCH 1/5] net: virtio dynamically disable/enable LRO > To: , , >

45488 netdev

2017-10-18 Thread marketing
<>

Re: [PATCH net-next v6 0/5] bpf: security: New file mode and LSM hooks for eBPF object permission control

2017-10-18 Thread James Morris
On Wed, 18 Oct 2017, David Miller wrote: > Series applied. I hadn't gotten to reviewing this patchset yet. Please wait for more acks/reviews from LSM folk for things touching security/, next time. -- James Morris

Re: [PATCH net-next v2 2/2] ipv6: remove from fib tree aged out RTF_CACHE dst

2017-10-18 Thread Martin KaFai Lau
On Wed, Oct 18, 2017 at 08:23:32PM +, Paolo Abeni wrote: > The commit 2b760fcf5cfb ("ipv6: hook up exception table to store > dst cache") partially reverted 1e2ea8ad37be ("ipv6: set > dst.obsolete when a cached route has expired"). > > As a result, RTF_CACHE dst referenced outside the fib

Re: RFC(v2): Audit Kernel Container IDs

2017-10-18 Thread Eric W. Biederman
Aleksa Sarai writes: >>> The security implications are that anything that can change the label >>> could also hide itself and its doings from the audit system and thus >>> would be used as a means to evade detection. I actually think this >>> means the label should be write once

Re: [PATCH net-next v2 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-10-18 Thread Masahiro Yamada
2017-10-18 19:23 GMT+09:00 Kunihiko Hayashi : > On Mon, 16 Oct 2017 00:08:21 +0900 wrote: >> priv->rst = devm_reset_control_get_optional_shared(dev, NULL); >> if (IS_ERR(priv->rst)) >> return PTR_ERR(priv->rst); > > The clk

Re: RFC(v2): Audit Kernel Container IDs

2017-10-18 Thread Richard Guy Briggs
On 2017-10-17 01:10, Casey Schaufler wrote: > On 10/16/2017 5:33 PM, Richard Guy Briggs wrote: > > On 2017-10-12 16:33, Casey Schaufler wrote: > >> On 10/12/2017 7:14 AM, Richard Guy Briggs wrote: > >>> Containers are a userspace concept. The kernel knows nothing of them. > >>> > >>> The Linux

[PATCH net-next] ipv4: ipv4_default_advmss() should use route mtu

2017-10-18 Thread Eric Dumazet
From: Eric Dumazet ipv4_default_advmss() incorrectly uses the device MTU instead of the route provided one. IPv6 has the proper behavior, lets harmonize the two protocols. Signed-off-by: Eric Dumazet --- net/ipv4/route.c |2 +- 1 file changed, 1

Re: Linux 4.12+ memory leak on router with i40e NICs

2017-10-18 Thread Paweł Staszewski
W dniu 2017-10-19 o 01:56, Paweł Staszewski pisze: W dniu 2017-10-19 o 01:51, Paweł Staszewski pisze: W dniu 2017-10-19 o 01:37, Alexander Duyck pisze: On Wed, Oct 18, 2017 at 4:22 PM, Paweł Staszewski wrote: W dniu 2017-10-19 o 00:58, Paweł Staszewski pisze:

Re: Linux 4.12+ memory leak on router with i40e NICs

2017-10-18 Thread Paweł Staszewski
W dniu 2017-10-19 o 01:51, Paweł Staszewski pisze: W dniu 2017-10-19 o 01:37, Alexander Duyck pisze: On Wed, Oct 18, 2017 at 4:22 PM, Paweł Staszewski wrote: W dniu 2017-10-19 o 00:58, Paweł Staszewski pisze: W dniu 2017-10-19 o 00:50, Paweł Staszewski pisze:

Re: Linux 4.12+ memory leak on router with i40e NICs

2017-10-18 Thread Paweł Staszewski
W dniu 2017-10-19 o 01:37, Alexander Duyck pisze: On Wed, Oct 18, 2017 at 4:22 PM, Paweł Staszewski wrote: W dniu 2017-10-19 o 00:58, Paweł Staszewski pisze: W dniu 2017-10-19 o 00:50, Paweł Staszewski pisze: W dniu 2017-10-19 o 00:20, Paweł Staszewski pisze:

Re: RFC(v2): Audit Kernel Container IDs

2017-10-18 Thread Aleksa Sarai
The security implications are that anything that can change the label could also hide itself and its doings from the audit system and thus would be used as a means to evade detection. I actually think this means the label should be write once (once you've set it, you can't change it) ...

Re: Linux 4.12+ memory leak on router with i40e NICs

2017-10-18 Thread Paweł Staszewski
W dniu 2017-10-19 o 01:29, Alexander Duyck pisze: On Mon, Oct 16, 2017 at 10:51 PM, Vitezslav Samel wrote: On Tue, Oct 17, 2017 at 01:34:29AM +0200, Paweł Staszewski wrote: W dniu 2017-10-16 o 18:26, Paweł Staszewski pisze: W dniu 2017-10-16 o 13:20, Pavlos Parissis

Re: [PATCH net-next] tcp: socket option to set TCP fast open key

2017-10-18 Thread Christoph Paasch
On 18/10/17 - 11:22:51, Yuchung Cheng wrote: > New socket option TCP_FASTOPEN_KEY to allow different keys per > listener. The listener by default uses the global key until the > socket option is set. The key is a 16 bytes long binary data. This > option has no effect on regular non-listener TCP

Re: Linux 4.12+ memory leak on router with i40e NICs

2017-10-18 Thread Alexander Duyck
On Wed, Oct 18, 2017 at 4:22 PM, Paweł Staszewski wrote: > > > W dniu 2017-10-19 o 00:58, Paweł Staszewski pisze: > >> >> >> W dniu 2017-10-19 o 00:50, Paweł Staszewski pisze: >>> >>> >>> >>> W dniu 2017-10-19 o 00:20, Paweł Staszewski pisze: W dniu

Re: Linux 4.12+ memory leak on router with i40e NICs

2017-10-18 Thread Alexander Duyck
On Mon, Oct 16, 2017 at 10:51 PM, Vitezslav Samel wrote: > On Tue, Oct 17, 2017 at 01:34:29AM +0200, Paweł Staszewski wrote: >> W dniu 2017-10-16 o 18:26, Paweł Staszewski pisze: >> > W dniu 2017-10-16 o 13:20, Pavlos Parissis pisze: >> > > On 15/10/2017 02:58 πμ, Alexander

Re: Linux 4.12+ memory leak on router with i40e NICs

2017-10-18 Thread Paweł Staszewski
W dniu 2017-10-19 o 00:58, Paweł Staszewski pisze: W dniu 2017-10-19 o 00:50, Paweł Staszewski pisze: W dniu 2017-10-19 o 00:20, Paweł Staszewski pisze: W dniu 2017-10-18 o 17:44, Paweł Staszewski pisze: W dniu 2017-10-17 o 16:08, Paweł Staszewski pisze: W dniu 2017-10-17 o 

[PATCH v2 net] packet: avoid panic in packet_getsockopt()

2017-10-18 Thread Eric Dumazet
From: Eric Dumazet syzkaller got crashes in packet_getsockopt() processing PACKET_ROLLOVER_STATS command while another thread was managing to change po->rollover Using RCU will fix this bug. We might later add proper RCU annotations for sparse sake. In v2: I replaced

Re: [10/26] netfilter: Allow xt_owner in any user namespace

2017-10-18 Thread Andrei Vagin
On Wed, Jul 06, 2016 at 04:23:52PM +0200, Pablo Neira Ayuso wrote: > From: "Eric W. Biederman" > > Making this work is a little tricky as it really isn't kosher to > change the xt_owner_match_info in a check function. > > Without changing xt_owner_match_info we need to

Re: Linux 4.12+ memory leak on router with i40e NICs

2017-10-18 Thread Paweł Staszewski
W dniu 2017-10-19 o 00:50, Paweł Staszewski pisze: W dniu 2017-10-19 o 00:20, Paweł Staszewski pisze: W dniu 2017-10-18 o 17:44, Paweł Staszewski pisze: W dniu 2017-10-17 o 16:08, Paweł Staszewski pisze: W dniu 2017-10-17 o 13:52, Paweł Staszewski pisze: W dniu 2017-10-17 o 

Re: Linux 4.12+ memory leak on router with i40e NICs

2017-10-18 Thread Paweł Staszewski
W dniu 2017-10-19 o 00:20, Paweł Staszewski pisze: W dniu 2017-10-18 o 17:44, Paweł Staszewski pisze: W dniu 2017-10-17 o 16:08, Paweł Staszewski pisze: W dniu 2017-10-17 o 13:52, Paweł Staszewski pisze: W dniu 2017-10-17 o 13:05, Paweł Staszewski pisze: W dniu 2017-10-17 o 

[next-queue PATCH] net/sched/sch_cbs: Fix compilation on 32bit architectures

2017-10-18 Thread Vinicius Costa Gomes
There was still a couple of divisions of 64bit quantities happening, which can fail to compile if there aren't instructions to handle that kind of division. It will fail with a message like this: ERROR: "__aeabi_ldivmod" [net/sched/sch_cbs.ko] undefined! Signed-off-by: Vinicius Costa Gomes

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

2017-10-18 Thread Paweł Staszewski
W dniu 2017-10-18 o 23:54, Eric Dumazet pisze: On Wed, 2017-10-18 at 23:49 +0200, Paweł Staszewski wrote: How far it is from applying this to the kernel ? So far im using this on all my servers from about 3 months now without problems It is a hack, and does not support properly

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-10-18 Thread Jesus Sanchez-Palencia
Hi Richard, On 09/19/2017 10:25 PM, Richard Cochran wrote: (...) > >> I have a question, what about a controller that doesn't provide a way to >> set a per-packet transmission time, but it supports Qbv/Qbu. What would >> be your proposal to configure it? > > SO_TXTIME will have a generic SW

Re: [PATCH RFC V1 net-next 0/6] Time based packet transmission

2017-10-18 Thread Jesus Sanchez-Palencia
Hi Richard, On 09/18/2017 12:41 AM, Richard Cochran wrote: > This series is an early RFC that introduces a new socket option > allowing time based transmission of packets. This option will be > useful in implementing various real time protocols over Ethernet, > including but not limited to

Re: Linux 4.12+ memory leak on router with i40e NICs

2017-10-18 Thread Paweł Staszewski
W dniu 2017-10-18 o 17:44, Paweł Staszewski pisze: W dniu 2017-10-17 o 16:08, Paweł Staszewski pisze: W dniu 2017-10-17 o 13:52, Paweł Staszewski pisze: W dniu 2017-10-17 o 13:05, Paweł Staszewski pisze: W dniu 2017-10-17 o 12:59, Paweł Staszewski pisze: W dniu 2017-10-17 o 

[PATCH net] packet: avoid panic in packet_getsockopt()

2017-10-18 Thread Eric Dumazet
From: Eric Dumazet syzkaller got crashes in packet_getsockopt() processing PACKET_ROLLOVER_STATS command while another thread was managing to change po->rollover Using RCU will fix this bug. We might later add proper RCU annotations for sparse sake. Fixes: a9b6391814d5

pull-request: ieee802154 2017-10-18

2017-10-18 Thread Stefan Schmidt
From: Stefan Schmidt Hello Dave. Please find below a pull request from the ieee802154 subsystem for net-next. regards Stefan Schmidt The following changes since commit b9f1f1ce866c28e3d9b86202441b220244754a69: tcp: fix tcp_xmit_retransmit_queue() after rbtree

[PATCH net-next] spectrum: Convert fib event handlers to use container_of on info arg

2017-10-18 Thread David Ahern
Use container_of to convert the generic fib_notifier_info into the event specific data structure. Signed-off-by: David Ahern Reviewed-by: Ido Schimmel --- .../net/ethernet/mellanox/mlxsw/spectrum_router.c | 29 +- 1 file changed, 23

Re: [PATCH 1/1] net: ethtool: add support for reset of AP inside NIC interface.

2017-10-18 Thread Scott Branden
+netdev@vger.kernel.org On 17-10-18 09:01 AM, Scott Branden wrote: Add ETH_RESET_AP to reset the application processor inside the NIC interface. Signed-off-by: Scott Branden --- include/uapi/linux/ethtool.h | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 0/1] net: ethtool: add SmartNIC reset support

2017-10-18 Thread Scott Branden
+netdev@vger.kernel.org On 17-10-18 02:30 PM, Andy Gospodarek wrote: On Wed, Oct 18, 2017 at 12:31:28PM -0700, Scott Branden wrote: Hi Andrew, On 17-10-18 12:16 PM, Andrew Lunn wrote: Yes, there is also a management processor. O.K. Maybe it would be nice to add some more text to the

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

2017-10-18 Thread Eric Dumazet
On Wed, 2017-10-18 at 23:49 +0200, Paweł Staszewski wrote: > How far it is from applying this to the kernel ? > > So far im using this on all my servers from about 3 months now without > problems It is a hack, and does not support properly bonding/team. ( If the real_dev->privflags

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

2017-10-18 Thread Paweł Staszewski
W dniu 2017-09-21 o 23:41, Florian Fainelli pisze: On 09/21/2017 02:26 PM, Paweł Staszewski wrote: W dniu 2017-08-15 o 11:11, Paweł Staszewski pisze: diff --git a/net/8021q/vlan_netlink.c b/net/8021q/vlan_netlink.c index

Re: [PATCH net 0/3] Fix for BPF devmap percpu allocation splat

2017-10-18 Thread Dennis Zhou
Hi Daniel and Tejun, On Wed, Oct 18, 2017 at 06:25:26AM -0700, Tejun Heo wrote: > > Daniel Borkmann (3): > > mm, percpu: add support for __GFP_NOWARN flag > > This looks fine. > Looks good to me too. > > bpf: fix splat for illegal devmap percpu allocation > > bpf: do not test for

Re: [PATCH net-next] tcp: fix tcp_send_syn_data()

2017-10-18 Thread Yuchung Cheng
On Wed, Oct 18, 2017 at 2:20 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > syn_data was allocated by sk_stream_alloc_skb(), meaning > its destructor and _skb_refdst fields are mangled. > > We need to call tcp_skb_tsorted_anchor_cleanup() before >

[PATCH net-next] tcp: fix tcp_send_syn_data()

2017-10-18 Thread Eric Dumazet
From: Eric Dumazet syn_data was allocated by sk_stream_alloc_skb(), meaning its destructor and _skb_refdst fields are mangled. We need to call tcp_skb_tsorted_anchor_cleanup() before calling kfree_skb() or kernel crashes. Bug was reported by syzkaller bot. Fixes:

Re: [PATCH net-next v12] openvswitch: enable NSH support

2017-10-18 Thread Jiri Benc
On Mon, 16 Oct 2017 21:53:29 +0800, Yi Yang wrote: > +static int set_nsh(struct sk_buff *skb, struct sw_flow_key *flow_key, > +const struct nlattr *a) > +{ > + struct nshhdr *nh; > + size_t length; > + int err; > + u8 flags; > + u8 ttl; > + int i; > + > +

Re: [PATCH net-next v7 1/5] bpf: Add file mode configuration into bpf maps

2017-10-18 Thread Daniel Borkmann
On 10/18/2017 10:00 PM, Chenbo Feng wrote: From: Chenbo Feng Introduce the map read/write flags to the eBPF syscalls that returns the map fd. The flags is used to set up the file mode when construct a new file descriptor for bpf maps. To not break the backward capability, the

Re: [PATCH] mac80211: aggregation: Convert timers to use timer_setup()

2017-10-18 Thread Kees Cook
On Wed, Oct 18, 2017 at 1:50 PM, Johannes Berg wrote: > On Wed, 2017-10-18 at 07:19 -0700, Kees Cook wrote: >> On Wed, Oct 18, 2017 at 3:29 AM, Johannes Berg >> wrote: >> > > This has been the least trivial timer conversion yet. Given the use

Re: RFC(v2): Audit Kernel Container IDs

2017-10-18 Thread Paul Moore
On Tue, Oct 17, 2017 at 11:44 AM, James Bottomley wrote: > On Tue, 2017-10-17 at 11:28 -0400, Simo Sorce wrote: >> > Without a *kernel* policy on containerIDs you can't say what >> > security policy is being exempted. >> >> The policy has been basically

Re: Problems with mvneta

2017-10-18 Thread Thomas Petazzoni
Hello, I'm adding my colleagues Grégory Clement and Antoine Ténart in Cc, as well as Marcin Wojtas, who also worked on mvneta, and the netdev mailing list. I'm keeping your full message below so that others can read the context. On Wed, 18 Oct 2017 22:34:25 +0200, Sven Müller wrote: > I've

[PATCH] i40e/virtchnl: fix application of sizeof to pointer

2017-10-18 Thread Gustavo A. R. Silva
sizeof when applied to a pointer typed expression gives the size of the pointer. The proper fix in this particular case is to code sizeof(*vfres) instead of sizeof(vfres). This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- This

Re: [PATCH] mac80211: aggregation: Convert timers to use timer_setup()

2017-10-18 Thread Johannes Berg
On Wed, 2017-10-18 at 07:19 -0700, Kees Cook wrote: > On Wed, Oct 18, 2017 at 3:29 AM, Johannes Berg > wrote: > > > This has been the least trivial timer conversion yet. Given the use of > > > RCU and other things I may not even know about, I'd love to get a close > > >

Re: [PATCH net-next] tcp: socket option to set TCP fast open key

2017-10-18 Thread Eric Dumazet
On Wed, Oct 18, 2017 at 1:13 PM, Christoph Paasch wrote: > > Hello Yuchung, > > On 18/10/17 - 11:22:51, Yuchung Cheng wrote: > > New socket option TCP_FASTOPEN_KEY to allow different keys per > > listener. The listener by default uses the global key until the > > socket option

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-18 Thread Paolo Abeni
On Wed, 2017-10-18 at 12:05 -0700, Martin KaFai Lau wrote: > Another thing (not limited to this case), > > Considering we have a limited size in the exception table now and > the oldest one will get removed when the table is full, > do we still need to purge this periodically in gc? At least in

[PATCH net-next v2 1/2] ipv6: start fib6 gc on RTF_CACHE dst creation

2017-10-18 Thread Paolo Abeni
After the commit Fixes: 2b760fcf5cfb ("ipv6: hook up exception table to store dst cache"), the fib6 gc is not started after the creation of a RTF_CACHE via a redirect or pmtu update, since fib6_add() isn't invoked anymore for such dsts. We need the fib6 gc to run periodically to clean the

[PATCH net-next v2 2/2] ipv6: remove from fib tree aged out RTF_CACHE dst

2017-10-18 Thread Paolo Abeni
The commit 2b760fcf5cfb ("ipv6: hook up exception table to store dst cache") partially reverted 1e2ea8ad37be ("ipv6: set dst.obsolete when a cached route has expired"). As a result, RTF_CACHE dst referenced outside the fib tree will not be removed until the next sernum change; dst_check() does

[PATCH net-next v2 0/2] ipv6: fixes for RTF_CACHE entries

2017-10-18 Thread Paolo Abeni
This series addresses 3 different but related issues with RTF_CACHE introduced by the recent refactory. patch 1 restore the gc timer for such routes patch 2 removes the aged out dst from the fib tree v1 -> v2: - dropped the for ip route show cache - avoid touching dst.obsolete when the dst is

Re: Regression in throughput between kvm guests over virtual bridge

2017-10-18 Thread Matthew Rosato
On 10/12/2017 02:31 PM, Wei Xu wrote: > On Thu, Oct 05, 2017 at 04:07:45PM -0400, Matthew Rosato wrote: >> >> Ping... Jason, any other ideas or suggestions? > > Hi Matthew, > Recently I am doing similar test on x86 for this patch, here are some, > differences between our testbeds. > > 1. It is

Re: [PATCH net-next] tcp: socket option to set TCP fast open key

2017-10-18 Thread Christoph Paasch
Hello Yuchung, On 18/10/17 - 11:22:51, Yuchung Cheng wrote: > New socket option TCP_FASTOPEN_KEY to allow different keys per > listener. The listener by default uses the global key until the > socket option is set. The key is a 16 bytes long binary data. This > option has no effect on regular

[PATCH v5 net-next 05/12] gtp: Change to use gro_cells

2017-10-18 Thread Tom Herbert
Call gro_cells_receive instead of netif_rx. Signed-off-by: Tom Herbert --- drivers/net/Kconfig | 1 + drivers/net/gtp.c | 11 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index

[PATCH v5 net-next 01/12] iptunnel: Add common functions to get a tunnel route

2017-10-18 Thread Tom Herbert
ip_tunnel_get_route and ip6_tnl_get_route are created to return routes for a tunnel. These functions are derived from the VXLAN functions. Signed-off-by: Tom Herbert --- include/net/ip6_tunnel.h | 33 + include/net/ip_tunnels.h | 32

[PATCH v5 net-next 12/12] gtp: Allow configuring GTP interface as standalone

2017-10-18 Thread Tom Herbert
Add new configuration of GTP interfaces that allow specifying a port to listen on (as opposed to having to get sockets from a userspace control plane). This allows GTP interfaces to be configured and the data path tested without requiring a GTP-C daemon. Signed-off-by: Tom Herbert

[PATCH v5 net-next 03/12] gtp: Call common functions to get tunnel routes and add dst_cache

2017-10-18 Thread Tom Herbert
Call ip_tunnel_get_route and dst_cache to pdp context which should improve performance by obviating the need to perform a route lookup on every packet. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 62 +++ 1 file

[PATCH v5 net-next 02/12] vxlan: Call common functions to get tunnel routes

2017-10-18 Thread Tom Herbert
Call ip_tunnel_get_route and ip6_tnl_get_route to handle getting a route and dealing with the dst_cache. Signed-off-by: Tom Herbert --- drivers/net/vxlan.c | 84 - 1 file changed, 5 insertions(+), 79 deletions(-) diff

[PATCH v5 net-next 07/12] gtp: udp recv clean up

2017-10-18 Thread Tom Herbert
Create separate UDP receive functions for GTP version 0 and version 1. Set encap_rcv appropriately when configuring a socket. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 100 ++ 1 file changed, 49 insertions(+), 51

[PATCH v5 net-next 06/12] gtp: Use goto for exceptions in gtp_udp_encap_recv funcs

2017-10-18 Thread Tom Herbert
Consolidate return logic to make it easier to extend. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index f2aac5d01143..00e5ea5cb935

[PATCH v5 net-next 09/12] gtp: Eliminate pktinfo and add port configuration

2017-10-18 Thread Tom Herbert
The gtp pktinfo structure is unnecessary and needs a lot of code to manage it. Remove it. Also, add per pdp port configuration for transmit. Signed-off-by: Tom Herbert --- drivers/net/gtp.c| 177 +--

[PATCH v5 net-next 08/12] gtp: Call function to update path mtu

2017-10-18 Thread Tom Herbert
Replace mtu handling with call to __iptunnel_update_pmtu. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index

[PATCH v5 net-next 10/12] gtp: Experimental encapsulation of IPv6 packets

2017-10-18 Thread Tom Herbert
Allow IPv6 mobile subscriber packets. This entails adding an IPv6 mobile subscriber address to pdp context and IPv6 specific variants to find pdp contexts by address. Note that this is experimental support of IPv6, more work is necessary to make this compliant with 3GPP standard. Signed-off-by:

[PATCH v5 net-next 00/12] gtp: Additional feature support - Part I

2017-10-18 Thread Tom Herbert
This patch set builds upon the initial GTP implementation to make support closer to that enjoyed by other encapsulation protocols. The major items are: - Experimental IPv6 support - Configurable networking interfaces so that GTP kernel can be used and tested without needing GSN network

[PATCH v5 net-next 04/12] iptunnel: Generalize tunnel update pmtu

2017-10-18 Thread Tom Herbert
Add __iptunnel_update_pmtu exported function which does not take an iptunnel argument but instead includes the fields from the iptunnel structure as arguments which are needed in the function. iptunnel_update_pmtu was modified to call __iptunnel_update_pmtu. Signed-off-by: Tom Herbert

[PATCH v5 net-next 11/12] gtp: Experimental support encpasulating over IPv6

2017-10-18 Thread Tom Herbert
Allows using GTP datapath over IPv6. Remote peers are indicated by IPv6. Note this is experimental, more work is needed to make this compliant with 3GPP standard. Signed-off-by: Tom Herbert --- drivers/net/gtp.c| 248 ++-

[PATCH net-next v7 2/5] bpf: Add tests for eBPF file mode

2017-10-18 Thread Chenbo Feng
From: Chenbo Feng Two related tests are added into bpf selftest to test read only map and write only map. The tests verified the read only and write only flags are working on hash maps. Signed-off-by: Chenbo Feng Acked-by: Daniel Borkmann

[PATCH net-next v7 1/5] bpf: Add file mode configuration into bpf maps

2017-10-18 Thread Chenbo Feng
From: Chenbo Feng Introduce the map read/write flags to the eBPF syscalls that returns the map fd. The flags is used to set up the file mode when construct a new file descriptor for bpf maps. To not break the backward capability, the f_flags is set to O_RDWR if the flag passed

[PATCH net-next v7 3/5] security: bpf: Add LSM hooks for bpf object related syscall

2017-10-18 Thread Chenbo Feng
From: Chenbo Feng Introduce several LSM hooks for the syscalls that will allow the userspace to access to eBPF object such as eBPF programs and eBPF maps. The security check is aimed to enforce a per object security protection for eBPF object so only processes with the right

[PATCH net-next v7 4/5] selinux: bpf: Add selinux check for eBPF syscall operations

2017-10-18 Thread Chenbo Feng
From: Chenbo Feng Implement the actual checks introduced to eBPF related syscalls. This implementation use the security field inside bpf object to store a sid that identify the bpf object. And when processes try to access the object, selinux will check if processes have the

[PATCH net-next v7 5/5] selinux: bpf: Add addtional check for bpf object file receive

2017-10-18 Thread Chenbo Feng
From: Chenbo Feng Introduce a bpf object related check when sending and receiving files through unix domain socket as well as binder. It checks if the receiving process have privilege to read/write the bpf map or use the bpf program. This check is necessary because the bpf maps

[PATCH net-next v7 0/5] bpf: security: New file mode and LSM hooks for eBPF object permission control

2017-10-18 Thread Chenbo Feng
From: Chenbo Feng Much like files and sockets, eBPF objects are accessed, controlled, and shared via a file descriptor (FD). Unlike files and sockets, the existing mechanism for eBPF object access control is very limited. Currently there are two options for granting accessing

Re: RFC(v2): Audit Kernel Container IDs

2017-10-18 Thread Paul Moore
On Tue, Oct 17, 2017 at 8:31 AM, Simo Sorce wrote: > The container Id can be used also for authorization purposes (by other > processes on the host), not just audit, I think this is why a separate > control has been proposed. Apologies, but I'm just now getting a chance to work

Re: [PATCH 00/58] networking: Convert timers to use timer_setup()

2017-10-18 Thread Kees Cook
On Tue, Oct 17, 2017 at 10:44 PM, Kalle Valo wrote: > Kees Cook writes: >> Which split is preferred? I had been trying to separate wireless from >> the rest of net (but missed some cases). > > So what we try to follow is that I apply all patches for >

[PATCH iproute2 1/1] ss: initialize 'fackets' member of tcpstat structure

2017-10-18 Thread Roman Mashak
'fackets' has never been initialized with kernel extracted information, thus never really printed. Signed-off-by: Roman Mashak --- misc/ss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/misc/ss.c b/misc/ss.c index 09bff8a..465e867 100644 --- a/misc/ss.c +++ b/misc/ss.c

Re: [PATCH 00/58] networking: Convert timers to use timer_setup()

2017-10-18 Thread Kees Cook
On Wed, Oct 18, 2017 at 4:42 AM, David Miller wrote: > From: Kees Cook > Date: Mon, 16 Oct 2017 17:28:44 -0700 > >> This is the current set of outstanding networking patches to perform >> conversions to the new timer interface (rebased to -next). This

Re: Get rid of RCU callbacks in TC filters?

2017-10-18 Thread Paul E. McKenney
On Wed, Oct 18, 2017 at 10:36:28AM -0700, Cong Wang wrote: > Hi, all > > Recently, the RCU callbacks used in TC filters and TC actions keep > drawing my attention, they introduce at least 4 race condition bugs: > > 1. A simple one fixed by Daniel: > > commit

Re: [PATCH] lib/dynamic_queue_limits.c: relax BUG_ON to WARN_ON in dql_complete()

2017-10-18 Thread Ard Biesheuvel
On 18 October 2017 at 19:45, Eric Dumazet wrote: > On Wed, 2017-10-18 at 18:57 +0100, Ard Biesheuvel wrote: >> On 18 October 2017 at 17:29, Eric Dumazet wrote: >> > On Wed, 2017-10-18 at 16:45 +0100, Ard Biesheuvel wrote: >> >> Even though calling

Re: [net-next] dsa: slave: support phy devices on external MII bus

2017-10-18 Thread Andrew Lunn
> I guess, thanks for making me post this example and realize this is > probably no longer necessary :) Hi Florian You are welcome. Please test and report back. This code is complex, so removing part of it would be great. Andrew

Re: [PATCH net-next] net: ipv4: Change fib notifiers to take a fib_alias

2017-10-18 Thread Ido Schimmel
On Wed, Oct 18, 2017 at 11:39:13AM -0700, David Ahern wrote: > All of the notifier data (fib_info, tos, type and table id) are > contained in the fib_alias. Pass it to the notifier instead of > each data separately shortening the argument list by 3. > > Signed-off-by: David Ahern

Re: [net-next] dsa: slave: support phy devices on external MII bus

2017-10-18 Thread Florian Fainelli
On 10/18/2017 12:09 PM, Andrew Lunn wrote: >> Yes, but with the caveat already covered today: there is a possible >> problem with having to divert MDIO accesses of a PHY pointed by >> phy-handle towards the internal switch bus because of specific problems >> such as those explained in

[PATCH net-next] net-tun: fix panics at dismantle time

2017-10-18 Thread Eric Dumazet
From: Eric Dumazet syzkaller got crashes at dismantle time [1] It is not correct to test (tun->flags & IFF_NAPI) in tun_napi_disable() and tun_napi_del() : Each tun_file can have different mode, depending on how they were created. Similarly I have changed tun_get_user()

Re: [net-next] dsa: slave: support phy devices on external MII bus

2017-10-18 Thread Andrew Lunn
> Yes, but with the caveat already covered today: there is a possible > problem with having to divert MDIO accesses of a PHY pointed by > phy-handle towards the internal switch bus because of specific problems > such as those explained in drivers/net/bcm_sf2.c, I don't mind trying to > do things

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-18 Thread Martin KaFai Lau
On Wed, Oct 18, 2017 at 05:56:39PM +, Wei Wang wrote: > On Wed, Oct 18, 2017 at 6:03 AM, Paolo Abeni wrote: > > On Tue, 2017-10-17 at 13:48 -0700, Wei Wang wrote: > >> On Tue, Oct 17, 2017 at 1:02 PM, Paolo Abeni wrote: > >> > Meanwhile others sockets

Re: [PATCH V2 net-next] liquidio: pass date and time info to NIC firmware

2017-10-18 Thread Andrew Lunn
Hi Felix > +static void lio_sync_octeon_time(struct work_struct *work) > +{ > + struct cavium_wk *wk = (struct cavium_wk *)work; > + struct lio *lio = (struct lio *)wk->ctxptr; > + struct octeon_device *oct = lio->oct_dev; > + struct octeon_soft_command *sc; > + struct

Re: [net-next] dsa: slave: support phy devices on external MII bus

2017-10-18 Thread Florian Fainelli
On 10/18/2017 10:30 AM, Martin Hundebøll wrote: > > > On 2017-10-18 18:51, Florian Fainelli wrote: >> On 10/18/2017 09:21 AM, Andrew Lunn wrote: >>> Hi Martin >>> >>> Sorry for starting a new thread. I deleted the patchset from my mailbox. >>> >>> Florian said: >>> The logic goes like this:

Re: [PATCH v7 02/10] arm: dts: sunxi: Restore EMAC changes

2017-10-18 Thread Corentin Labbe
On Wed, Oct 18, 2017 at 06:44:50PM +0200, Andrew Lunn wrote: > On Wed, Oct 18, 2017 at 01:44:50PM +0200, Corentin Labbe wrote: > > The original dwmac-sun8i DT bindings have some issue on how to handle > > integrated PHY and was reverted in last RC of 4.13. > > But now we have a solution so we need

Re: [net-next v2 3/4] openvswitch: Add meter infrastructure

2017-10-18 Thread Pravin Shelar
On Tue, Oct 17, 2017 at 12:36 AM, Andy Zhou wrote: > OVS kernel datapath so far does not support Openflow meter action. > This is the first stab at adding kernel datapath meter support. > This implementation supports only drop band type. > > Signed-off-by: Andy Zhou

Re: [PATCH] lib/dynamic_queue_limits.c: relax BUG_ON to WARN_ON in dql_complete()

2017-10-18 Thread Eric Dumazet
On Wed, 2017-10-18 at 18:57 +0100, Ard Biesheuvel wrote: > On 18 October 2017 at 17:29, Eric Dumazet wrote: > > On Wed, 2017-10-18 at 16:45 +0100, Ard Biesheuvel wrote: > >> Even though calling dql_completed() with a count that exceeds the > >> queued count is a serious

[PATCH net-next] net: ipv4: Change fib notifiers to take a fib_alias

2017-10-18 Thread David Ahern
All of the notifier data (fib_info, tos, type and table id) are contained in the fib_alias. Pass it to the notifier instead of each data separately shortening the argument list by 3. Signed-off-by: David Ahern --- net/ipv4/fib_trie.c | 39

[RFC] ip: introduce IFA_F_DHCP flag

2017-10-18 Thread Girish Moodalbail
This flag identifies that the address was obtained through DHCP. Today there is no easy way to find out whether an address on an interface is DHCP controlled or is static. Either you will need to grep for 'dhclient' process (or something else in case one is using a different DHCP client) or if

Re: [PATCH net v2 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-10-18 Thread Troy Kisky
On 10/18/2017 11:10 AM, Troy Kisky wrote: > On 10/17/2017 7:30 PM, Andy Duan wrote: >> From: Troy Kisky Sent: Wednesday, October >> 18, 2017 5:34 AM > This is better for code locality and should slightly speed up normal >>> interrupts. > > This also

[PATCH net-next] tcp: socket option to set TCP fast open key

2017-10-18 Thread Yuchung Cheng
New socket option TCP_FASTOPEN_KEY to allow different keys per listener. The listener by default uses the global key until the socket option is set. The key is a 16 bytes long binary data. This option has no effect on regular non-listener TCP sockets. Signed-off-by: Yuchung Cheng

Re: [PATCH net v2 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-10-18 Thread Troy Kisky
On 10/17/2017 7:30 PM, Andy Duan wrote: > From: Troy Kisky Sent: Wednesday, October > 18, 2017 5:34 AM This is better for code locality and should slightly speed up normal >> interrupts. This also allows PPS clock output to start working for i.mx7.

[iproute PATCH] ss: Detect IPPROTO_ICMPV6 sockets

2017-10-18 Thread Phil Sutter
Prefix IPPROTO_ICMPV6 sockets with 'icmp6' instead of '???'. Signed-off-by: Phil Sutter --- misc/ss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/misc/ss.c b/misc/ss.c index e37aba6022eb4..b5c6bbc05766e 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -784,6 +784,8 @@ static

  1   2   3   4   >