Re: general protection fault in skb_segment

2017-12-29 Thread Willem de Bruijn
> syzkaller hit the following crash on > 37759fa6d0fa9e4d6036d19ac12f555bfc0aeafd > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. > C reproducer is attached > syzkaller reproducer is attached. See

RE: [PATCH v3] igb: Free IRQs when device is hotplugged

2017-12-29 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Lyude Paul > Sent: Tuesday, December 12, 2017 11:32 AM > To: intel-wired-...@lists.osuosl.org > Cc: Fujinaka, Todd ; Stephen Hemminger > ;

Re: [PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW

2017-12-29 Thread Michael Chan
On Fri, Dec 29, 2017 at 7:12 AM, Alexander Duyck wrote: > On Fri, Dec 29, 2017 at 4:43 AM, Sabrina Dubroca wrote: >> 2017-12-22, 10:14:32 -0800, Alexander Duyck wrote: >>> On Fri, Dec 22, 2017 at 6:57 AM, Sabrina Dubroca

Re: [PATCH iproute2 4/4] man: routel/routef: don't mention filesystem paths

2017-12-29 Thread Stephen Hemminger
On Fri, 29 Dec 2017 23:01:25 +0100 Luca Boccassi wrote: > The filesytem paths to these scripts might be different on various > distros, so don't mention it in the manpages. It is not really useful > information anyway. > > Originally submitted as Debian bug: > >

Re: [PATCH iproute2 3/4] man: ip-address: document 15-char limit for LABEL

2017-12-29 Thread Stephen Hemminger
On Fri, 29 Dec 2017 23:01:24 +0100 Luca Boccassi wrote: > Trying to set a label longer than 15 characters returns an error: > RTNETLINK answers: Numerical result out of range > > Document the limit in the manpage. > > Originally reported as a Debian bug: > >

Re: [PATCH iproute2 2/4] man: add more keywords to ip.8 short description

2017-12-29 Thread Stephen Hemminger
On Fri, 29 Dec 2017 23:01:23 +0100 Luca Boccassi wrote: > A Debian user suggested adding more network-related keywords to the > ip manpage, so that manpage-scraping and indexing software like > apropos can do a better job of categorizing the programs. > >

Re: iproute2 net-next

2017-12-29 Thread Stephen Hemminger
On Fri, 29 Dec 2017 09:58:23 +0100 Jiri Pirko wrote: > Fri, Dec 29, 2017 at 12:46:31AM CET, dan...@iogearbox.net wrote: > >On 12/26/2017 10:35 AM, Leon Romanovsky wrote: > >> On Mon, Dec 25, 2017 at 10:14:26PM -0800, Stephen Hemminger wrote: > >>> On Tue, 26 Dec 2017

[PATCH net-next 0/2] net: stmmac: Couple of debug prints improvements

2017-12-29 Thread Florian Fainelli
Hi all, While working on a particular problem, I had to turn on debug prints and found them to be useful, but could deserve some improvements in order to help debug situations. Florian Fainelli (2): net: stmmac: Pad ring number with zeroes in display_ring() net: stmmac: Allow debug prints of

[PATCH net-next 1/2] net: stmmac: Pad ring number with zeroes in display_ring()

2017-12-29 Thread Florian Fainelli
Make the printing of the ring number consistent and properly aligned by padding the ring number with up to 3 zeroes, which covers the maximum ring size. This makes it a lot easier to see outliers in debug prints. Signed-off-by: Florian Fainelli ---

[PATCH net-next 2/2] net: stmmac: Allow debug prints of frame_len/COE

2017-12-29 Thread Florian Fainelli
There is no reason not to allow printing the frame_len/COE value and put that under a check for ETH_FRAME_LEN, drop it so we can see what the descriptor reports. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 ++--- 1 file

Re: b53 tags on bpi-r1 (bcm53125)

2017-12-29 Thread Florian Fainelli
Le 12/29/17 à 13:56, Florian Fainelli a écrit : > Le 12/29/17 à 12:21, Florian Fainelli a écrit : >> Hi Jochen, >> >> Le 12/18/17 à 02:44, Jochen Friedrich a écrit : >>> Hi Florian, >>> >>> unfortunately, this doesn't make any difference. >>> >>> Just out of curiosity, BPI-R1 has pull-down

RE: ATTENTION!!!

2017-12-29 Thread Loretta Robles
From: Loretta Robles Sent: Friday, December 29, 2017 1:01 PM To: Loretta Robles Subject: ATTENTION!!! You have been randomly selected for a donation. Contact soriz4...@gmail.com for claims.

Re: KMSAN reports use of uninitialized memory in pfkey_sendmsg()

2017-12-29 Thread Eric Biggers
On Fri, Dec 29, 2017 at 05:49:34PM +0100, Dmitry Vyukov wrote: > On Fri, Dec 29, 2017 at 5:48 PM, Alexander Potapenko > wrote: > > Hi all, > > > > KMSAN reports a use of uninitialized value on the following program: > > > > == > > // autogenerated by

[PATCH] af_key: fix buffer overread in parse_exthdrs()

2017-12-29 Thread Eric Biggers
From: Eric Biggers If a message sent to a PF_KEY socket ended with an incomplete extension header (fewer than 4 bytes remaining), then parse_exthdrs() read past the end of the message, into uninitialized memory. Fix it by returning -EINVAL in this case. Reproducer:

[PATCH] af_key: fix buffer overread in verify_address_len()

2017-12-29 Thread Eric Biggers
From: Eric Biggers If a message sent to a PF_KEY socket ended with one of the extensions that takes a 'struct sadb_address' but there were not enough bytes remaining in the message for the ->sa_family member of the 'struct sockaddr' which is supposed to follow, then

Re: [PATCH v3 bpf-next 1/2] tools/bpftool: use version from the kernel source tree

2017-12-29 Thread Daniel Borkmann
On 12/27/2017 08:16 PM, Roman Gushchin wrote: > Bpftool determines it's own version based on the kernel > version, which is picked from the linux/version.h header. > > It's strange to use the version of the installed kernel > headers, and makes much more sense to use the version > of the actual

Re: [RFT net-next v3 3/5] net: stmmac: dwmac-meson8b: fix internal RGMII clock configuration

2017-12-29 Thread Martin Blumenstingl
Hi Jerome, On Fri, Dec 29, 2017 at 6:57 PM, Jerome Brunet wrote: > On Thu, 2017-12-28 at 23:21 +0100, Martin Blumenstingl wrote: >> While testing the dwmac-meson8b with an RGMII PHY on Meson8b we >> discovered that the m25_div is not actually a divider but rather a gate. >>

Re: [RFT net-next v3 0/5] dwmac-meson8b: RGMII clock fixes for Meson8b

2017-12-29 Thread Emiliano Ingrassia
Hi Jerome, Hi Martin, On Fri, Dec 29, 2017 at 07:04:23PM +0100, Jerome Brunet wrote: > On Fri, 2017-12-29 at 02:31 +0100, Emiliano Ingrassia wrote: > > Hi Martin, Hi Dave, > > > > On Thu, Dec 28, 2017 at 11:21:23PM +0100, Martin Blumenstingl wrote: > > > Hi Dave, > > > > > > please do not apply

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-29 Thread Antoine Tenart
Hi Russell, On Thu, Dec 28, 2017 at 06:59:21PM +, Russell King - ARM Linux wrote: > On Thu, Dec 28, 2017 at 11:04:16AM +0100, Antoine Tenart wrote: > > > > That's not what I remembered. You had some valid points, and others > > related to PHY modes the driver wasn't supporting before the

Re: [PATCH net-next 2/2] l2tp: add peer_offset parameter

2017-12-29 Thread Lorenzo Bianconi
> Sorry for only just seeing this (vacation). > > > On 28/12/17 19:45, Guillaume Nault wrote: >> >> On Thu, Dec 28, 2017 at 07:23:48PM +0100, Lorenzo Bianconi wrote: >>> >>> On Dec 28, Guillaume Nault wrote: After a quick review of L2TPv3 and pseudowires RFCs, I still don't see how

[PATCH iproute2 2/4] man: add more keywords to ip.8 short description

2017-12-29 Thread Luca Boccassi
A Debian user suggested adding more network-related keywords to the ip manpage, so that manpage-scraping and indexing software like apropos can do a better job of categorizing the programs. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=877983 Suggested-by: Lynoure Braakman

[PATCH iproute2 3/4] man: ip-address: document 15-char limit for LABEL

2017-12-29 Thread Luca Boccassi
Trying to set a label longer than 15 characters returns an error: RTNETLINK answers: Numerical result out of range Document the limit in the manpage. Originally reported as a Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=661886 Reported-by: Gabor Kiss

[PATCH iproute2 4/4] man: routel/routef: don't mention filesystem paths

2017-12-29 Thread Luca Boccassi
The filesytem paths to these scripts might be different on various distros, so don't mention it in the manpages. It is not really useful information anyway. Originally submitted as Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561424 Reported-by: jida...@jidanni.org

[PATCH iproute2 1/4] man: drop references to Debian-specific paths

2017-12-29 Thread Luca Boccassi
Documentation should be distribution-agnostic - any specific quirks should be handled by downstream maintainers, if necessary. Remove mentions of Debian paths and package names. Signed-off-by: Luca Boccassi --- man/man8/lnstat.8 | 3 +-- man/man8/ss.8 | 3 +-- 2 files

Re: b53 tags on bpi-r1 (bcm53125)

2017-12-29 Thread Florian Fainelli
Le 12/29/17 à 12:21, Florian Fainelli a écrit : > Hi Jochen, > > Le 12/18/17 à 02:44, Jochen Friedrich a écrit : >> Hi Florian, >> >> unfortunately, this doesn't make any difference. >> >> Just out of curiosity, BPI-R1 has pull-down resistors on LED6 and 7 >> (MII_MODE0/1). However, the public

[PATCH] p54spi: Delete an error message for a failed memory allocation in p54spi_rx()

2017-12-29 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 29 Dec 2017 22:33:10 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] rt2x00: Delete an error message for a failed memory allocation in rt2x00queue_allocate()

2017-12-29 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 29 Dec 2017 22:11:42 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] cw1200: Delete an error message for a failed memory allocation in three functions

2017-12-29 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 29 Dec 2017 21:48:05 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: b53 tags on bpi-r1 (bcm53125)

2017-12-29 Thread Florian Fainelli
Hi Jochen, Le 12/18/17 à 02:44, Jochen Friedrich a écrit : > Hi Florian, > > unfortunately, this doesn't make any difference. > > Just out of curiosity, BPI-R1 has pull-down resistors on LED6 and 7 > (MII_MODE0/1). However, the public available 53125U sheet doesn't > document these pins: > >

[PATCH] wlcore: Delete an error message for a failed memory allocation in three functions

2017-12-29 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 29 Dec 2017 20:40:49 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH net-next] net: dsa: Fix dsa_legacy_register() return value

2017-12-29 Thread Florian Fainelli
We need to make the dsa_legacy_register() stub return 0 in order for dsa_init_module() to successfully register and continue registering the ETH_P_XDSA packet handler. Fixes: 2a93c1a3651f ("net: dsa: Allow compiling out legacy support") Reported-by: Egil Hjelmeland

Re: [PATCH net-next 2/2] l2tp: add peer_offset parameter

2017-12-29 Thread James Chapman
Sorry for only just seeing this (vacation). On 28/12/17 19:45, Guillaume Nault wrote: On Thu, Dec 28, 2017 at 07:23:48PM +0100, Lorenzo Bianconi wrote: On Dec 28, Guillaume Nault wrote: After a quick review of L2TPv3 and pseudowires RFCs, I still don't see how adding some padding between the

[net 1/1] tipc: fix problems with multipoint-to-point flow control

2017-12-29 Thread Jon Maloy
In commit 04d7b574b245 ("tipc: add multipoint-to-point flow control") we introduced a protocol for preventing buffer overflow when many group members try to simultaneously send messages to the same receiving member. Stress test of this mechanism has revealed a couple of related bugs: - When the

[PATCH net] cxgb4: Fix FW flash errors

2017-12-29 Thread Ganesh Goudar
From: Arjun Vynipadath Initialize adapter->params.sf_fw_start to fix firmware flash issues. Use existing macros defined for FW flash addresses. Fixes: 96ac18f14a5a ("cxgb4: Add support for new flash parts") Signed-off-by: Arjun Vynipadath Signed-off-by:

Re: [PATCH RESEND 1/3] net: Fix possible race in peernet2id_alloc()

2017-12-29 Thread Eric W. Biederman
Kirill Tkhai writes: > peernet2id_alloc() is racy without rtnl_lock() as atomic_read(>count) > under net->nsid_lock does not guarantee, peer is alive: > > rcu_read_lock() > peernet2id_alloc().. > spin_lock_bh(>nsid_lock) .. >

Re: [RFT net-next v3 0/5] dwmac-meson8b: RGMII clock fixes for Meson8b

2017-12-29 Thread Jerome Brunet
On Fri, 2017-12-29 at 02:31 +0100, Emiliano Ingrassia wrote: > Hi Martin, Hi Dave, > > On Thu, Dec 28, 2017 at 11:21:23PM +0100, Martin Blumenstingl wrote: > > Hi Dave, > > > > please do not apply this series until it got a Tested-by from Emiliano. > > > > > > Hi Emiliano, > > > > you

[PATCH net] ethtool: do not print warning for applications using legacy API

2017-12-29 Thread Stephen Hemminger
From: Stephen Hemminger In kernel log ths message appears on every boot: "warning: `NetworkChangeNo' uses legacy ethtool link settings API, link modes are only partially reported" When ethtool link settings API changed, it started complaining about usages of old

Re: [RFT net-next v3 3/5] net: stmmac: dwmac-meson8b: fix internal RGMII clock configuration

2017-12-29 Thread Jerome Brunet
On Thu, 2017-12-28 at 23:21 +0100, Martin Blumenstingl wrote: > While testing the dwmac-meson8b with an RGMII PHY on Meson8b we > discovered that the m25_div is not actually a divider but rather a gate. > This matches with the datasheet which describes bit 10 as "Generate > 25MHz clock for PHY".

Re: [patch net-next v2 00/10] Add support for resource abstraction

2017-12-29 Thread Arkadi Sharshevsky
On 12/28/2017 06:33 PM, David Ahern wrote: > On 12/28/17 10:23 AM, Jiri Pirko wrote: >>> So there are 4 tables exported to userspace: >>> >>> 1. mlxsw_erif table which is not in any of the kvd regions (no >>> resource path is given) and it has a size of 1000. Does >>> mlxsw_erif mean a rif as

Re: ACPI issues on cold power on [bisected]

2017-12-29 Thread Jonathan McDowell
On Fri, Dec 22, 2017 at 09:21:09AM +0900, Joonsoo Kim wrote: > On Fri, Dec 08, 2017 at 03:11:59PM +, Jonathan McDowell wrote: > > I've been sitting on this for a while and should have spent time to > > investigate sooner, but it's been an odd failure mode that wasn't quite > > obvious. > > >

KMSAN reports use of uninitialized memory in pfkey_sendmsg()

2017-12-29 Thread Alexander Potapenko
Hi all, KMSAN reports a use of uninitialized value on the following program: == // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include int main() { int sock = socket(PF_KEY, SOCK_RAW, 2); char buf[24]; memset(buf, 0, 24);

Re: KMSAN reports use of uninitialized memory in pfkey_sendmsg()

2017-12-29 Thread Dmitry Vyukov
On Fri, Dec 29, 2017 at 5:48 PM, Alexander Potapenko wrote: > Hi all, > > KMSAN reports a use of uninitialized value on the following program: > > == > // autogenerated by syzkaller (http://github.com/google/syzkaller) > > #include > #include >

[PATCH] 3c59x: fix missing dma_mapping_error check

2017-12-29 Thread Neil Horman
A few spots in 3c59x missed calls to dma_mapping_error checks, casuing WARN_ONS to trigger. Clean those up. Signed-off-by: Neil Horman CC: Steffen Klassert CC: "David S. Miller" Reported-by: tedheads...@gmail.com ---

Re: [PATCH net v2] netns, rtnetlink: fix struct net reference leak

2017-12-29 Thread Craig Gallek
On Sat, Dec 23, 2017 at 5:12 PM, Nicolas Dichtel wrote: > Le 22/12/2017 à 21:36, Craig Gallek a écrit : >> From: Craig Gallek >> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c >> index 60a71be75aea..4b7ea33f5705 100644 >> ---

Re: net-next lan9303 and CONFIG_NET_DSA_LEGACY

2017-12-29 Thread Egil Hjelmeland
On 15. des. 2017 21:06, Florian Fainelli wrote: On December 15, 2017 6:51:45 AM PST, Egil Hjelmeland wrote: Hi I found that our lan9303 board is unable to receive network data unless CONFIG_NET_DSA_LEGACY is set. Is that a problem with the driver, or our Any

[iptables] extensions: add support for 'srh' match

2017-12-29 Thread Ahmed Abdelsalam
This patch adds a new exetension to iptables to supprt 'srh' match The implementation considers revision 7 of the SRH draft. https://tools.ietf.org/html/draft-ietf-6man-segment-routing-header-07 Signed-off-by: Ahmed Abdelsalam --- extensions/libip6t_srh.c|

[net-next] netfilter: add segment routing header 'srh' match

2017-12-29 Thread Ahmed Abdelsalam
It allows matching packets based on Segment Routing Header (SRH) information. The implementation considers revision 7 of the SRH draft. https://tools.ietf.org/html/draft-ietf-6man-segment-routing-header-07 Currently supported match options include: (1) Next Header (2) Hdr Ext Len (3) Segments

Re: [PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW

2017-12-29 Thread Alexander Duyck
On Fri, Dec 29, 2017 at 4:43 AM, Sabrina Dubroca wrote: > 2017-12-22, 10:14:32 -0800, Alexander Duyck wrote: >> On Fri, Dec 22, 2017 at 6:57 AM, Sabrina Dubroca >> wrote: >> > IIUC, with the patches that were applied, each driver can define >> >

3c59x: pci_unmap_single() oops

2017-12-29 Thread tedheadster
In the 4.15.0-rc5 kernel (and likely earlier) I get the following oops. 3c59x :00:0c.0 enp0s12: renamed from eth0 enp0s12: setting half-duplex. [ cut here ] 3c59x :00:0c.0: DMA-API: device driver failed to check map error[device address=0x09e1b040]

Compliment of the day

2017-12-29 Thread Kabore Zongo
-- Compliment of the day , I am a professional banker with International and Qualified Experience. Please i seek your Urgent Attention and Cooperation to transfer the sum of $8.5M into your account. Risk free and Beneficial. Waiting response so that we can proceed to the next

[PATCH net-next 3/5] net: phy: marvell10g: clean up interface mode switching

2017-12-29 Thread Russell King
Centralise the PHY interface mode switching, rather than having it in two places. Signed-off-by: Russell King --- drivers/net/phy/marvell10g.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git

[PATCH net-next 5/5] net: phy: marvell10g: add support for half duplex 100M and 10M

2017-12-29 Thread Russell King
Add support for half-duplex 100M and 10M copper connections by parsing the advertisment results rather than trying to decode the negotiated speed from one of the PHYs "vendor" registers. This allows us to decode the duplex as well, which means we can support half-duplex mode for the slower

[PATCH net-next 4/5] net: phy: add helper to convert negotiation result to phy settings

2017-12-29 Thread Russell King
Add a helper to convert the result of the autonegotiation advertisment into the PHYs speed and duplex settings. If the result is full duplex, also extract the pause mode settings from the link partner advertisment. Signed-off-by: Russell King ---

[PATCH net-next 2/5] net: phy: marvell10g: add MDI swap reporting

2017-12-29 Thread Russell King
Add reporting of the MDI swap to the Marvell 10G PHY driver by providing a generic implementation for the standard 10GBASE-T pair swap register and polarity register. We also support reading the MDI swap status for 1G and below from a PCS register. Signed-off-by: Russell King

[PATCH net-next 1/5] net: phy: marvell10g: update header comments

2017-12-29 Thread Russell King
Update header comments to indicate the newly found behaviour with XAUI interfaces. Signed-off-by: Russell King --- drivers/net/phy/marvell10g.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/marvell10g.c

[PATCH net-next 0/5] marvell10g updates

2017-12-29 Thread Russell King - ARM Linux
Hi, This series: - adds MDI/MDIX reporting - adds support for 10/100Mbps half-duplex link modes - adds a comment describing the setup on VF610 ZII boards (where the phy interface mode doesn't change.) - cleans up the phy interace mode switching drivers/net/phy/marvell10g.c | 110

Re: [PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW

2017-12-29 Thread Sabrina Dubroca
2017-12-22, 10:14:32 -0800, Alexander Duyck wrote: > On Fri, Dec 22, 2017 at 6:57 AM, Sabrina Dubroca wrote: > > IIUC, with the patches that were applied, each driver can define > > whether GRO_HW depends on GRO? From a user's perspective, this > > inconsistent behavior is

[PATCH net-next 1/2] net: dsa: lan9303: phy_addr_sel_strap rename and retype

2017-12-29 Thread Egil Hjelmeland
chip->phy_addr_sel_strap is declared as a bool, but is also used as an integer address base. Rename 'phy_addr_sel_strap' to 'phy_addr_base', and change type to int. Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 20 ++--

[PATCH net-next 2/2] net: dsa: lan9303: Adjust phy_addr_base expressions

2017-12-29 Thread Egil Hjelmeland
Simplify calculation of chip->phy_addr_base in lan9303_detect_phy_setup(). Use GENMASK to calculate phys_mii_mask from LAN9303_NUM_PORTS and phy_addr_base. Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 10 +- 1 file changed, 5

[PATCH net-next 0/2] net: dsa: lan9303: phy_addr_sel_strap rename and retype

2017-12-29 Thread Egil Hjelmeland
Non functional cleanups involving chip->phy_addr_sel_strap. As promised in https://lkml.org/lkml/2017/11/6/273 Egil Hjelmeland (2): net: dsa: lan9303: phy_addr_sel_strap rename and retype net: dsa: lan9303: Adjust phy_addr_base expressions drivers/net/dsa/lan9303-core.c | 24

Re: [PATCH bpf-next v3 3/3] libbpf: add missing SPDX-License-Identifier

2017-12-29 Thread Philippe Ombredanne
Eric, On Thu, Dec 28, 2017 at 9:04 AM, Eric Leblond wrote: > Signed-off-by: Eric Leblond > Acked-by: Alexei Starovoitov > --- > tools/lib/bpf/bpf.c| 2 ++ > tools/lib/bpf/bpf.h| 2 ++ > tools/lib/bpf/libbpf.c | 2 ++ >

Re: [PATCH net-next 2/2] tuntap: XDP transmission

2017-12-29 Thread Jesper Dangaard Brouer
On Fri, 29 Dec 2017 18:00:04 +0800 Jason Wang wrote: > This patch implements XDP transmission for TAP. Since we can't create > new queues for TAP during XDP set, exist ptr_ring was reused for > queuing XDP buffers. To differ xdp_buff from sk_buff, TUN_XDP_FLAG > (0x1ULL) was

[PATCH net-next 1/7] net: mdiobus: add unlocked accessors

2017-12-29 Thread Russell King
Add unlocked versions of the bus accessors, which allows access to the bus with all the tracing. These accessors validate that the bus mutex is held, which is a basic requirement for all mii bus accesses. Reviewed-by: Florian Fainelli Signed-off-by: Russell King

[PATCH net-next 4/7] net: phy: add paged phy register accessors

2017-12-29 Thread Russell King
Add a set of paged phy register accessors which are inherently safe in their design against other accesses interfering with the paged access. Signed-off-by: Russell King --- drivers/net/phy/phy-core.c | 157 +

[PATCH net-next 2/7] net: phy: use unlocked accessors for indirect MMD accesses

2017-12-29 Thread Russell King
Use unlocked accessors for indirect MMD accesses to clause 22 PHYs. This permits tracing of these accesses. Reviewed-by: Florian Fainelli Signed-off-by: Russell King --- drivers/net/phy/phy-core.c | 11 ++- 1 file changed, 6

[PATCH net-next 6/7] net: phy: add phy_modify() accessor

2017-12-29 Thread Russell King
Add phy_modify() convenience accessor to complement the mdiobus counterpart. Signed-off-by: Russell King --- drivers/net/phy/phy-core.c | 23 +++ include/linux/phy.h| 1 + 2 files changed, 24 insertions(+) diff --git

[PATCH net-next 5/7] net: phy: marvell: fix paged access races

2017-12-29 Thread Russell King
For paged accesses to be truely safe, we need to hold the bus lock to prevent anyone else gaining access to the registers while we modify them. The phydev->lock mutex does not do this: userspace via the MII ioctl can still sneak in and read or write any register while we are on a different page,

[PATCH net-next 3/7] net: phy: add unlocked accessors

2017-12-29 Thread Russell King
Add unlocked versions of the bus accessors, which allows access to the bus with all the tracing. These accessors validate that the bus mutex is held, which is a basic requirement for all mii bus accesses. Also added is a read-modify-write unlocked accessor with the same locking requirements.

[PATCH net-next 7/7] net: phy: convert read-modify-write to phy_modify()

2017-12-29 Thread Russell King
Convert read-modify-write sequences in at803x, Marvell and core phylib to use phy_modify() to ensure safety. Signed-off-by: Russell King --- drivers/net/phy/at803x.c | 20 +++ drivers/net/phy/marvell.c| 82

[PATCH net-next 0/7] Resolve races in phy accessors

2017-12-29 Thread Russell King - ARM Linux
Hi, This series resolves races with various accesses to PHY registers. The first five patches are necessary before we add phylink support to mvneta, the remaining three are merely cleanups for unobserved races, and hence are less critical. There are two possible classes of races that can occur:

[PATCH net-next A 3/5] sfp: add support for 1000Base-PX and 1000Base-BX10

2017-12-29 Thread Russell King
Add support for decoding the transceiver information for 1000Base-PX and 1000Base-BX10. These use 1000BASE-X protocol. Signed-off-by: Russell King --- drivers/net/phy/sfp-bus.c | 21 + 1 file changed, 21 insertions(+) diff --git

[PATCH net-next A 2/5] sfp: don't guess support from connector type

2017-12-29 Thread Russell King
Don't try to guess the support mask from the connector type - this is mostly irrelevant to the speeds that the transceiver supports. Signed-off-by: Russell King --- drivers/net/phy/sfp-bus.c | 29 - 1 file changed, 29 deletions(-) diff

[PATCH net-next A 4/5] sfp: improve support for direct-attach copper cables

2017-12-29 Thread Russell King
Improve the support for direct-attach copper so that we avoid kernel warning messages, and report the appropriate PORT_DA type to userspace. Direct Attach cables can use a number of protocols depending on their range of speeds. Signed-off-by: Russell King ---

[PATCH net-next A 1/5] sfp: use precision to print non-null terminated strings

2017-12-29 Thread Russell King
Rather than memcpy()'ing the strings and null terminate them, printf allows non-NULL terminated strings provided the precision is not more than the size of the buffer. Use this form to print the basic module information rather than copying and terminating the strings. Signed-off-by: Russell King

[PATCH net-next A 0/5] further sfp/phylink updates

2017-12-29 Thread Russell King - ARM Linux
Hi, This series: - cleans up printing of module information - improves the transceiver capability decoding, getting rid of the guessing by connector type, improves direct-attach cable support and adds support for 1G Base-PX and Base-BX10 modules. - cleans up phylink_sfp_module_insert()

Re: [RFT net-next v3 0/5] dwmac-meson8b: RGMII clock fixes for Meson8b

2017-12-29 Thread Emiliano Ingrassia
Hi Martin, On Fri, Dec 29, 2017 at 08:48:54AM +0100, Martin Blumenstingl wrote: > Hi Emiliano, > > On Fri, Dec 29, 2017 at 2:31 AM, Emiliano Ingrassia > wrote: > > Hi Martin, Hi Dave, > > > > On Thu, Dec 28, 2017 at 11:21:23PM +0100, Martin Blumenstingl wrote: > >> Hi

Re: [PATCH] NET: usb: qmi_wwan: add support for YUGA CLM920-NC5 PID 0x9625

2017-12-29 Thread Bjørn Mork
"SZ Lin (林上智)" writes: > This patch adds support for PID 0x9625 of YUGA CLM920-NC5. > > YUGA CLM920-NC5 needs to enable QMI_WWAN_QUIRK_DTR before QMI operation. > > qmicli -d /dev/cdc-wdm0 -p --dms-get-revision > [/dev/cdc-wdm0] Device revision retrieved: > Revision:

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-29 Thread Russell King - ARM Linux
On Fri, Dec 29, 2017 at 12:12:15PM +0100, Marcin Wojtas wrote: > Hi Russell, > > I see that I misspelled your email address, hence the series remained > unnoticed: > https://lkml.org/lkml/2017/12/18/216 > > In terms of the phylink support, I think the most important are: > * 3/8 >

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-29 Thread Marcin Wojtas
Hi Russell, 2017-12-28 19:46 GMT+01:00 Russell King - ARM Linux : > On Thu, Dec 28, 2017 at 07:27:39PM +0100, Antoine Tenart wrote: >> Hi Florian, >> >> On Thu, Dec 28, 2017 at 07:02:09AM -0800, Florian Fainelli wrote: >> > On 12/28/2017 02:05 AM, Antoine Tenart wrote: >> >

Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time

2017-12-29 Thread Colin Ian King
On 29/12/17 07:44, Loic Poulain wrote: > Hi Colin, Bjorn, > > On 26 December 2017 at 21:13, Bjorn Andersson > wrote: >> On Tue 19 Dec 09:04 PST 2017, Colin King wrote: >> >>> From: Colin Ian King >>> >>> msg_body.min_ch_time is being

[PATCH net-next 0/2] XDP transmission for tuntap

2017-12-29 Thread Jason Wang
Hi all: This series tries to implement XDP transmission (ndo_xdp_xmit) for tuntap. Pointer ring was used for queuing both XDP buffers and sk_buff, this is done by encoding the type into lowest bit of the pointer and storin XDP metadata in the headroom of XDP buff. Tests gets 3.05 Mpps when doing

[PATCH net-next 2/2] tuntap: XDP transmission

2017-12-29 Thread Jason Wang
This patch implements XDP transmission for TAP. Since we can't create new queues for TAP during XDP set, exist ptr_ring was reused for queuing XDP buffers. To differ xdp_buff from sk_buff, TUN_XDP_FLAG (0x1ULL) was encoded into lowest bit of xpd_buff pointer during ptr_ring_produce, and was

[PATCH net-next 1/2] tun/tap: use ptr_ring instead of skb_array

2017-12-29 Thread Jason Wang
This patch switches to use ptr_ring instead of skb_array. This will be used to enqueue different types of pointers by encoding type into lower bits. Signed-off-by: Jason Wang --- drivers/net/tap.c | 41 + drivers/net/tun.c |

[PATCH][V2] wcn36xx: fix incorrect assignment to msg_body.min_ch_time

2017-12-29 Thread Colin King
From: Colin Ian King The second assignment to msg_body.min_ch_time is incorrect, it should actually be to msg_body.max_ch_time. Thanks to Bjorn Andersson for identifying the correct way to fix this as my original fix was incorrect. Detected by CoverityScan,

[PATCH][V2] wcn36xx: fix incorrect assignment to msg_body.min_ch_time

2017-12-29 Thread Colin King
From: Colin Ian King The second assignment to msg_body.min_ch_time is incorrect, it should actually be to msg_body.max_ch_time. Thanks to Bjorn Andersson for identifying the correct way to fix this as my original fix was incorrect. Detected by CoverityScan,

[PATCH] NET: usb: qmi_wwan: add support for YUGA CLM920-NC5 PID 0x9625

2017-12-29 Thread 林上智
This patch adds support for PID 0x9625 of YUGA CLM920-NC5. YUGA CLM920-NC5 needs to enable QMI_WWAN_QUIRK_DTR before QMI operation. qmicli -d /dev/cdc-wdm0 -p --dms-get-revision [/dev/cdc-wdm0] Device revision retrieved: Revision: 'CLM920_NC5-V1 1 [Oct 23 2016 19:00:00]'

Re: iproute2 net-next

2017-12-29 Thread Jiri Pirko
Fri, Dec 29, 2017 at 12:46:31AM CET, dan...@iogearbox.net wrote: >On 12/26/2017 10:35 AM, Leon Romanovsky wrote: >> On Mon, Dec 25, 2017 at 10:14:26PM -0800, Stephen Hemminger wrote: >>> On Tue, 26 Dec 2017 06:47:43 +0200 >>> Leon Romanovsky wrote: >>> On Mon, Dec 25, 2017

[PATCH net-next] net: hns: add ACPI mode support for ethtool -p

2017-12-29 Thread Peng Li
From: Jian Shen The locate operation interface of fiber port can only work with DT mode. Add a new interface to control the locate led for ACPI mode. Signed-off-by: Jian Shen Signed-off-by: Peng Li Tested-by: Zhou Wang

Re: [RFC PATCH bpf-next v2 1/4] tracing/kprobe: bpf: Check error injectable event is on function entry

2017-12-29 Thread Masami Hiramatsu
On Thu, 28 Dec 2017 17:03:24 -0800 Alexei Starovoitov wrote: > On 12/28/17 12:20 AM, Masami Hiramatsu wrote: > > On Wed, 27 Dec 2017 20:32:07 -0800 > > Alexei Starovoitov wrote: > > > >> On 12/27/17 8:16 PM, Steven Rostedt wrote: > >>> On Wed, 27 Dec 2017 19:45:42

Re: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered

2017-12-29 Thread Jakub Kicinski
On Fri, 29 Dec 2017 08:00:33 +, Belgazal, Netanel wrote: > Yes, I mean in my driver. > netif_carrier_off() have no effect when netdev is uninitialized. Please look at the implementation again, test_*and_set*_bit(). > So I must call it after register_netdev(). Is there a user-visible problem

Re: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered

2017-12-29 Thread Belgazal, Netanel
Yes, I mean in my driver. netif_carrier_off() have no effect when netdev is uninitialized. So I must call it after register_netdev(). On 12/29/17, 9:46 AM, "Jakub Kicinski" wrote: By "should" you mean in your driver, right? I think calling netif_carrier_off() on an