[PATCH net 1/2] net: Fix vlan untag for bridge and vlan_dev with reorder_hdr off

When we have a bridge with vlan_filtering on and a vlan device on top of it, packets would be corrupted in skb_vlan_untag() called from br_dev_xmit(). The problem sits in skb_reorder_vlan_header() used in skb_vlan_untag(), which makes use of skb->mac_len. In this function mac_len is meant for

RE: [PATCH v4 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Monday, March 12, 2018 4:37 PM > To: Razvan Stefanescu > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; netdev@vger.kernel.org; Alexander

Re: [PATCH v2 1/1] net: check before dereferencing netdev_ops during busy poll

On 03/12/2018 10:32 PM, Josh Elsasser wrote: init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. Avoid this by ensuring

BUG_ON triggered in skb_segment

Hi, One of our in-house projects, bpf-based NAT, hits a kernel BUG_ON at net-next function skb_segment, line 3667. 3472 struct sk_buff *skb_segment(struct sk_buff *head_skb, 3473 netdev_features_t features) 3474 { 3475 struct sk_buff *segs = NULL; 3476

[PATCH v2 1/1] net: check before dereferencing netdev_ops during busy poll

init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. Avoid this by ensuring napi->dev->netdev_ops is valid before following the pointer,

[PATCH 0/1] net: avoid a kernel panic during sk_busy_loop

V2: just check napi->dev->netdev_ops instead of getting clever with the netdev registration state. Original cover letter: Hi Dave, I stumbled across a reproducible kernel panic while playing around with busy_poll on a Linux 4.9.86 kernel. There's an unfortunate interaction between

Re: [PATCH 1/1] net: check dev->reg_state before deref of napi netdev_ops

On Mon, Mar 12, 2018 at 4:17 PM, Cong Wang wrote: > On Sun, Mar 11, 2018 at 12:22 PM, Josh Elsasser wrote: >> init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads >> to a NULL pointer dereference when sk_busy_loop fires against an

Re: [Intel-wired-lan] [PATCH 01/15] ice: Add basic driver framework for Intel(R) E800 Series

On Mon, 12 Mar 2018 09:56:30 -0700, Jeff Kirsher wrote: > On Fri, 2018-03-09 at 14:16 -0800, Jakub Kicinski wrote: > > On Fri, 9 Mar 2018 09:21:22 -0800, Anirudh Venkataramanan wrote: > > > diff --git a/Documentation/networking/ice.txt > > > b/Documentation/networking/ice.txt > > > new file

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

On Mon, Mar 12, 2018 at 4:57 PM, Linus Torvalds wrote: > On Mon, Mar 12, 2018 at 3:55 PM, Andrew Morton > wrote: >> >> Replacing the __builtin_choose_expr() with ?: works of course. > > Hmm. That sounds like the right thing to do. We were

Re: [PATCH v3 net-next 1/4] net: macb: Reorganize macb_mii bringup

Hi Brad, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v2] netfilter: nf_tables: remove VLA usage

In preparation to enabling -Wvla, remove VLA and replace it with dynamic memory allocation. >From a security viewpoint, the use of Variable Length Arrays can be a vector for stack overflow attacks. Also, in general, as the code evolves it is easy to lose track of how big a VLA can get. Thus, we

Re: [PATCH] net: hns: use put_device() if device_register fail

On Monday 12 March 2018 10:59 PM, Richard Weinberger wrote: On Mon, Mar 12, 2018 at 5:27 PM, arvindY wrote: On Monday 12 March 2018 08:13 PM, David Miller wrote: From: Arvind Yadav Date: Fri, 9 Mar 2018 16:11:17 +0530 if

[PATCH net-next v2] sctp: fix error return code in sctp_sendmsg_new_asoc()

Return error code -EINVAL in the address len check error handling case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' in the for loop. Fixes: 2c0dbaa0c43d ("sctp: add support for SCTP_DSTADDRV4/6 Information for sendmsg") Signed-off-by: Wei Yongjun

[PATCH net-next 0/4] net: qualcomm: rmnet: Updates 2018-03-12

This series contains some minor updates for rmnet driver. Patch 1 contains fixes for sparse warnings. Patch 2 updates the copyright date to 2018. Patch 3 is a cleanup in receive path. Patch 4 has the implementation of the fill_info operation. Subash Abhinov Kasiviswanathan (4): net: qualcomm:

[PATCH net-next 2/4] net: qualcomm: rmnet: Update copyright year to 2018

Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 2 +- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h | 2 +- drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c| 2 +-

[PATCH net-next 4/4] net: qualcomm: rmnet: Implement fill_info

This is needed to query the mux_id and flags of a rmnet device. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 30 ++ 1 file changed, 30 insertions(+) diff --git

[PATCH net-next 1/4] net: qualcomm: rmnet: Fix casting issues

Fix warnings which were reported when running with sparse (make C=1 CF=-D__CHECK_ENDIAN__) drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:81:15: warning: cast to restricted __be16 drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:271:37: warning: incorrect type in assignment (different

[PATCH net-next 3/4] net: qualcomm: rmnet: Remove unnecessary device assignment

Device of the de-aggregated skb is correctly assigned after inspecting the mux_id, so remove the assignment in rmnet_map_deaggregate(). Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c | 1 - 1 file changed, 1

Re: [Intel-wired-lan] [PATCH 07/15] ice: Add support for VSI allocation and deallocation

On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: This patch introduces data structures and functions to alloc/free VSIs. The driver represents a VSI using the ice_vsi structure. Some noteworthy points about VSI allocation: 1) A VSI is allocated in the firmware using the "add VSI" admin queue

Re: [Intel-wired-lan] [PATCH 04/15] ice: Get switch config, scheduler config and device capabilities

On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: This patch adds to the initialization flow by getting switch configuration, scheduler configuration and device capabilities. Switch configuration: On boot, an L2 switch element is created in the firmware per physical function. Each physical

Re: [Intel-wired-lan] [PATCH 06/15] ice: Initialize PF and setup miscellaneous interrupt

On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: This patch continues the initialization flow as follows: 1) Allocate and initialize necessary fields (like vsi, num_alloc_vsi, irq_tracker, etc) in the ice_pf instance. 2) Setup the miscellaneous interrupt handler. This also known as the

[PATCH net-next] ibmvnic: Fix recent errata commit

Sorry, one of the patches I sent in an earlier series has some dumb mistakes. One was that I had changed the parameter for the errata workaround function but forgot to make that change in the code that called it. The second mistake was a forgotten return value at the end of the function in case

Re: [Intel-wired-lan] [PATCH 02/15] ice: Add support for control queues

On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: A control queue is a hardware interface which is used by the driver to interact with other subsystems (like firmware, PHY, etc.). It is implemented as a producer-consumer ring. More specifically, an "admin queue" is a type of control queue used

Re: [Intel-wired-lan] [PATCH 03/15] ice: Start hardware initialization

On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: This patch implements multiple pieces of the initialization flow as follows: 1) A reset is issued to ensure a clean device state, followed by initialization of admin queue interface. 2) Once the admin queue interface is up, clear the PF

Re: [pull request][for-next 00/11] Mellanox, mlx5 IPSec updates 2018-02-28-2 (Part 2)

On Mon, 2018-03-12 at 21:43 +, Saeed Mahameed wrote: > On Thu, 2018-03-08 at 14:14 -0500, Doug Ledford wrote: > > On 3/8/2018 1:04 PM, David Miller wrote: > > > From: Saeed Mahameed > > > Date: Wed, 7 Mar 2018 17:26:03 -0800 > > > > > > > Hi Dave and Doug, > > > > > >

[PATCH] netfilter: nf_tables: remove VLA usage

In preparation to enabling -Wvla, remove VLA and replace it with dynamic memory allocation. >From a security viewpoint, the use of Variable Length Arrays can be a vector for stack overflow attacks. Also, in general, as the code evolves it is easy to lose track of how big a VLA can get. Thus, we

Re: [PATCH net-next] net: stmmac: remove superfluous wmb() memory barriers

From: Niklas Cassel Date: Mon, 12 Mar 2018 09:55:42 +0100 > Jose is simply responding to the commit message description of this patch. > > You explained that there is an implicit memory barrier between physical memory > writes and those to MMIO register space, as long as

Re: [RFC PATCH net-next 3/5] bridge: allow switchdev port to handle flooding by itself

> The flag was introduced to enable hardware switch capabilities of > drivers/net/wireless/quantenna/qtnfmac wifi driver. It does not have any > switchdev functionality in upstream tree at this moment, and this patchset > was intended as a preparatory change. O.K. But i suggest you add basic

Re: [RESEND PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

From: Roman Mashak Date: Mon, 12 Mar 2018 16:07:02 -0400 > Signed-off-by: Roman Mashak Applied. > -] > +] > \ No newline at end of file Please fix this.

Re: [RESEND PATCH net-next 1/1] tc-testing: add TC vlan action tests

From: Roman Mashak Date: Mon, 12 Mar 2018 16:06:37 -0400 > Signed-off-by: Roman Mashak Applied.

Re: [PATCH net] net: dsa: Fix dsa_is_user_port() test inversion

From: Florian Fainelli Date: Mon, 12 Mar 2018 16:00:40 -0700 > During the conversion to dsa_is_user_port(), a condition ended up being > reversed, which would prevent the creation of any user port when using > the legacy binding and/or platform data, fix that. > > Fixes:

Re: [PATCH net-next v2 0/4] ibmvnic: Fix VLAN and other device errata

On 03/12/2018 07:59 PM, David Miller wrote: > From: Thomas Falcon > Date: Mon, 12 Mar 2018 17:07:38 -0500 > >> On 03/12/2018 11:56 AM, David Miller wrote: >>> From: Thomas Falcon >>> Date: Mon, 12 Mar 2018 11:51:01 -0500 >>> This

Re: [PATCH net-next] net: phy: set link state to down when creating the phy_device

From: Heiner Kallweit Date: Sun, 11 Mar 2018 15:00:37 +0100 > Currently the link state is initialized to "up" when the phy_device is > being created. This is not consistent with the phy state being > initialized to PHY_DOWN. > > Usually this doen't do any harm because the

Re: [PATCH net-next v2 0/4] ibmvnic: Fix VLAN and other device errata

From: Thomas Falcon Date: Mon, 12 Mar 2018 17:07:38 -0500 > On 03/12/2018 11:56 AM, David Miller wrote: >> From: Thomas Falcon >> Date: Mon, 12 Mar 2018 11:51:01 -0500 >> >>> This patch series contains fixes for VLAN and other backing

[PATCH] netfilter: nfnetlink_cthelper: Remove VLA usage

In preparation to enabling -Wvla, remove VLA and replace it with dynamic memory allocation. >From a security viewpoint, the use of Variable Length Arrays can be a vector for stack overflow attacks. Also, in general, as the code evolves it is easy to lose track of how big a VLA can get. Thus, we

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got conflicts in: drivers/net/ethernet/mellanox/mlxsw/spectrum.h drivers/net/ethernet/mellanox/mlxsw/spectrum.c between commit: 663f1b26f9c1 ("mlxsw: spectrum: Prevent duplicate mirrors") from the net tree and commit: a629ef210d89

Re: [RFC PATCH v0 2/2] skbuff: Notify errors with sk_error_report()

On 03/12/2018 04:10 PM, Vinicius Costa Gomes wrote: When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the correct application is not notified. Your patch makes sense, thanks.

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/phy/phy.c between commit: a2c054a896b8 ("net: phy: Tell caller result of phy_change()") from the net tree and commit: 4fff2d33c707 ("net: phy: remove phy_error from phy_disable_interrupts") from the

Re: [PATCH] netfilter: cttimeout: remove VLA usage

On Mon, 2018-03-12 at 18:14 -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA and replace it > with dynamic memory allocation. > > From a security viewpoint, the use of Variable Length Arrays can be > a vector for stack overflow attacks. Also, in general, as the

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

On Mon, Mar 12, 2018 at 3:55 PM, Andrew Morton wrote: > > Replacing the __builtin_choose_expr() with ?: works of course. Hmm. That sounds like the right thing to do. We were so myopically staring at the __builtin_choose_expr() problem that we overlooked the obvious

[PATCH] netfilter: cttimeout: remove VLA usage

In preparation to enabling -Wvla, remove VLA and replace it with dynamic memory allocation. >From a security viewpoint, the use of Variable Length Arrays can be a vector for stack overflow attacks. Also, in general, as the code evolves it is easy to lose track of how big a VLA can get. Thus, we

Re: [PATCH 1/1] net: check dev->reg_state before deref of napi netdev_ops

On Sun, Mar 11, 2018 at 12:22 PM, Josh Elsasser wrote: > init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads > to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi > wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. > >

[RFC PATCH v0 2/2] skbuff: Notify errors with sk_error_report()

When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the correct application is not notified. Reported-by: Randy E. Witt Signed-off-by: Vinicius Costa Gomes --- net/core/skbuff.c | 2 +- 1 file

[RFC PATCH v0 1/2] selftests/txtimestamp: Add more configurable parameters

Add a way to configure if poll() should wait forever for an event, the number of packets that should be sent for each and if there should be any delay between packets. Signed-off-by: Vinicius Costa Gomes --- .../selftests/networking/timestamping/txtimestamp.c | 21

[RFC PATCH v0 0/2] skbuff: Fix applications not being woken for errors

Hi, This is actually a "bug report"-RFC instead of the more usual "new feature"-RFC. We are developing an application that uses TX hardware timestamping to make some measurements, and during development Randy Witt initially reported that the application poll() never unblocked when TX hardware

Re: [PATCH net-next 0/5] Switchdev: flooding offload option

On 03/10/2018 02:08 PM, Andrew Lunn wrote: Hi Igor You don't appear to be adding any user of this. Please also make one of the switchdev drivers actually use this new functionality. Andrew Hi Andrew, a first user is supposed to be drivers/net/wireless/quantenna/qtnfmac wifi driver. I

Re: [RFC PATCH net-next 3/5] bridge: allow switchdev port to handle flooding by itself

On 03/10/2018 08:55 AM, Andrew Lunn wrote: Is this sufficiently granular? There are a few different use cases for flooding: There is no fdb entry in the software switch for the destination MAC address, so flood the packet out all ports of the bridge. The hardware switch might have an entry in

[PATCH net] net: dsa: Fix dsa_is_user_port() test inversion

During the conversion to dsa_is_user_port(), a condition ended up being reversed, which would prevent the creation of any user port when using the legacy binding and/or platform data, fix that. Fixes: 4a5b85ffe2a0 ("net: dsa: use dsa_is_user_port everywhere") Signed-off-by: Florian Fainelli

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

On Fri, 9 Mar 2018 17:30:15 -0800 Kees Cook wrote: > > It's one reason why I wondered if simplifying the expression to have > > just that single __builtin_constant_p() might not end up working.. > > Yeah, it seems like it doesn't bail out as "false" for complex >

Re: [PATCH net-next 1/1] net sched actions: return explicit error when tunnel_key mode is not specified

On Mon, Mar 12, 2018 at 1:20 PM, Roman Mashak wrote: > If set/unset mode of the tunnel_key action is not provided, ->init() still > returns 0, and the caller proceeds with bogus 'struct tc_action *' object, > this results in crash: ... > Fixes: d0f6dd8a914f ("net/sched:

Re: [PATCH bpf-next v4 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

> On Mar 12, 2018, at 2:31 PM, Alexei Starovoitov wrote: > > On 3/12/18 2:12 PM, Song Liu wrote: >> >>> On Mar 12, 2018, at 2:00 PM, Alexei Starovoitov wrote: >>> >>> On 3/12/18 1:39 PM, Song Liu wrote: + page = find_get_page(vma->vm_file->f_mapping, 0); >>>

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

Apologies, still some comments going. Please see inline. On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala wrote: > This patch enables virtio_net to switch over to a VF datapath when a VF > netdev is present with the same MAC address. It allows live migration > of a

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

On 02/27/2018 11:08 AM, Rafał Miłecki wrote: I've problem when using OpenWrt/LEDE on a home router with Broadcom's FullMAC WiFi chipset. First of all OpenWrt/LEDE uses bridge interface for LAN network with: 1) IFLA_BRPORT_MCAST_TO_UCAST 2) Clients isolation in hostapd 3) Hairpin mode enabled

Re: [PATCH v4 net-next 3/4] net: macb: Add phy-handle DT support

On 03/12/2018 02:57 PM, Andrew Lunn wrote: >> +/* attempt to find a phy-handle */ >> +if (!(bp->phy_node = of_parse_phandle(np, "phy-handle", >> 0))) { >> + >> +/* fallback to standard phy registration if no >> phy were >> +

Re: [PATCH net-next] net: phy: set link state to down when creating the phy_device

On 03/11/2018 07:00 AM, Heiner Kallweit wrote: > Currently the link state is initialized to "up" when the phy_device is > being created. This is not consistent with the phy state being > initialized to PHY_DOWN. > > Usually this doen't do any harm because the link state is updated > once the PHY

Re: [PATCH net-next v2 0/4] ibmvnic: Fix VLAN and other device errata

On 03/12/2018 11:56 AM, David Miller wrote: > From: Thomas Falcon > Date: Mon, 12 Mar 2018 11:51:01 -0500 > >> This patch series contains fixes for VLAN and other backing hardware >> errata. The VLAN fixes are mostly to account for the additional four >> bytes VLAN

Re: [PATCH bpf-next v4 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

On Mon, Mar 12, 2018 at 01:39:56PM -0700, Song Liu wrote: > +static void stack_map_get_build_id_offset(struct bpf_map *map, > + struct stack_map_bucket *bucket, > + u64 *ips, u32 trace_nr) > +{ > + int i; > +

Re: [PATCH v4 net-next 3/4] net: macb: Add phy-handle DT support

> + /* attempt to find a phy-handle */ > + if (!(bp->phy_node = of_parse_phandle(np, "phy-handle", > 0))) { > + > + /* fallback to standard phy registration if no > phy were > + * found during dt phy

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Sat, Mar 3, 2018 at 8:04 PM, Michael S. Tsirkin wrote: > On Fri, Mar 02, 2018 at 03:56:31PM -0800, Siwei Liu wrote: >> On Fri, Mar 2, 2018 at 1:36 PM, Michael S. Tsirkin wrote: >> > On Fri, Mar 02, 2018 at 01:11:56PM -0800, Siwei Liu wrote: >> >> On Thu, Mar

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

On 12 March 2018 at 12:48, Linus Lüssing wrote: > On Mon, Mar 12, 2018 at 12:08:56PM +0100, Linus Lüssing wrote: >> On Tue, Feb 27, 2018 at 11:08:20AM +0100, Rafał Miłecki wrote: >> > I've problem when using OpenWrt/LEDE on a home router with Broadcom's >> > FullMAC WiFi

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

On 12 March 2018 at 12:08, Linus Lüssing wrote: > On Tue, Feb 27, 2018 at 11:08:20AM +0100, Rafał Miłecki wrote: >> I've problem when using OpenWrt/LEDE on a home router with Broadcom's >> FullMAC WiFi chipset. > > Hi Rafał, > > Thanks for reporting this issue! > >> Can

Re: [pull request][for-next 00/11] Mellanox, mlx5 IPSec updates 2018-02-28-2 (Part 2)

On Thu, 2018-03-08 at 14:14 -0500, Doug Ledford wrote: > On 3/8/2018 1:04 PM, David Miller wrote: > > From: Saeed Mahameed > > Date: Wed, 7 Mar 2018 17:26:03 -0800 > > > > > Hi Dave and Doug, > > > > > > This series includes shared code updates (IPSec part2) for mlx5 > > >

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

On Mon, 2018-03-12 at 14:03 -0700, Stephen Hemminger wrote: > This reverts commit 9135c4d6037ff9f1818507bac0049fc44db8c3d2. > > Debian maintainer found that basic command: > # ip route flush all > No longer worked as expected which breaks user scripts and > expectations. It no longer

[PATCH v4 net-next 2/4] net: macb: Remove redundant poll irq assignment

In phy_device's general probe, this device will already be set for phy register polling, rendering this code redundant. Signed-off-by: Brad Mouring Suggested-by: Andrew Lunn Reviewed-by: Florian Fainelli ---

[PATCH v4 net-next 3/4] net: macb: Add phy-handle DT support

This optional binding (as described in the ethernet DT bindings doc) directs the netdev to the phydev to use. This is useful for a phy chip that has >1 phy in it, and two netdevs are using the same phy chip (i.e. the second mac's phy lives on the first mac's MDIO bus) The devicetree snippet would

[PATCH v4 net-next 4/4] Documentation: macb: Document phy-handle binding

Document the existance of the optional binding, directing to the general ethernet document that describes this binding. Signed-off-by: Brad Mouring Reviewed-by: Florian Fainelli --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed,

[PATCH v4 net-next 1/4] net: macb: Reorganize macb_mii bringup

The macb mii setup (mii_probe() and mii_init()) previously was somewhat interspersed, likely a result of organic growth and hacking. This change moves mii bus registration into mii_init and probing the bus for devices into mii_probe. Signed-off-by: Brad Mouring

[PATCH v4 net-next 0/4]

Consider the situation where a macb netdev is connected through a phydev that sits on a mii bus other than the one provided to this particular netdev. This situation is what this patchset aims to accomplish through the existing phy-handle optional binding. This optional binding (as described in

Re: [PATCH net] kcm: lock lower socket in kcm_attach

On Mon, Mar 12, 2018 at 02:25:41PM -0700, Tom Herbert wrote: > On Mon, Mar 12, 2018 at 2:09 PM, Eric Biggers wrote: > > On Mon, Mar 12, 2018 at 02:04:12PM -0700, Tom Herbert wrote: > >> Need to lock lower socket in order to provide mutual exclusion > >> with kcm_unattach. >

Re: [PATCH bpf-next v4 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

On 3/12/18 2:12 PM, Song Liu wrote: On Mar 12, 2018, at 2:00 PM, Alexei Starovoitov wrote: On 3/12/18 1:39 PM, Song Liu wrote: + page = find_get_page(vma->vm_file->f_mapping, 0); did you test it with config_debug_atomic_sleep ? it should have complained... Yeah, I

Re: [net-next 0/6][pull request] 10GbE Intel Wired LAN Driver Updates 2018-03-12

From: Jeff Kirsher Date: Mon, 12 Mar 2018 13:12:09 -0700 > This series contains updates to ixgbe and ixgbevf only. Pulled, thanks Jeff.

Re: [PATCH net] kcm: lock lower socket in kcm_attach

On Mon, Mar 12, 2018 at 2:09 PM, Eric Biggers wrote: > On Mon, Mar 12, 2018 at 02:04:12PM -0700, Tom Herbert wrote: >> Need to lock lower socket in order to provide mutual exclusion >> with kcm_unattach. >> >> Fixes: ab7ac4eb9832e32a09f4e804 ("kcm: Kernel Connection

Re: [PATCH bpf-next v4 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

> On Mar 12, 2018, at 2:00 PM, Alexei Starovoitov wrote: > > On 3/12/18 1:39 PM, Song Liu wrote: >> +page = find_get_page(vma->vm_file->f_mapping, 0); > > did you test it with config_debug_atomic_sleep ? > it should have complained... Yeah, I have CONFIG_DEBUG_ATOMIC_SLEEP=y.

Re: [PATCH net] kcm: lock lower socket in kcm_attach

On Mon, Mar 12, 2018 at 02:04:12PM -0700, Tom Herbert wrote: > Need to lock lower socket in order to provide mutual exclusion > with kcm_unattach. > > Fixes: ab7ac4eb9832e32a09f4e804 ("kcm: Kernel Connection Multiplexor module") > Signed-off-by: Tom Herbert > --- Is this

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

Mon, Mar 12, 2018 at 09:58:06PM CET, sridhar.samudr...@intel.com wrote: > > >On 3/12/2018 1:12 PM, Jiri Pirko wrote: >> Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: >> > This patch enables virtio_net to switch over to a VF datapath when a VF >> > netdev is present with

[PATCH net] kcm: lock lower socket in kcm_attach

Need to lock lower socket in order to provide mutual exclusion with kcm_unattach. Fixes: ab7ac4eb9832e32a09f4e804 ("kcm: Kernel Connection Multiplexor module") Signed-off-by: Tom Herbert --- net/kcm/kcmsock.c | 33 +++-- 1 file changed, 23

Re: [PATCH bpf-next v4 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

On 3/12/18 1:39 PM, Song Liu wrote: + page = find_get_page(vma->vm_file->f_mapping, 0); did you test it with config_debug_atomic_sleep ? it should have complained...

[PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

This reverts commit 9135c4d6037ff9f1818507bac0049fc44db8c3d2. Debian maintainer found that basic command: # ip route flush all No longer worked as expected which breaks user scripts and expectations. It no longer flushed all IPv4 routes. Reported-by: Luca Boccassi

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/12/2018 1:12 PM, Jiri Pirko wrote: Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF

Re: de-indirect TCP congestion control

On Mon, 12 Mar 2018 16:05:16 -0400 (EDT) David Miller wrote: > From: Eric Dumazet > Date: Mon, 12 Mar 2018 13:03:35 -0700 > > > > > > > On 03/12/2018 12:48 PM, Stephen Hemminger wrote: > >> On Mon, 12 Mar 2018 15:04:06 -0400 (EDT) > >> David

[PATCH bpf-next v4 0/2] bpf stackmap with build_id+offset

This is v4 of this work. Changes since v3: 1. Add fallback when build_id lookup failed. In this case, status is set to BPF_STACK_BUILD_ID_IP, and ip of this entry is saved. 2. Handle cases where vma is only part of the file (vma->vm_pgoff != 0). Thanks to Teng for helping me identify this

[PATCH bpf-next v4 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

Currently, bpf stackmap store address for each entry in the call trace. To map these addresses to user space files, it is necessary to maintain the mapping from these virtual address to symbols in the binary. Usually, the user space profiler (such as perf) has to scan /proc/pid/maps at the

[PATCH bpf-next v4 2/2] bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID

test_stacktrace_build_id() is added. It accesses tracepoint urandom_read with "dd" and "urandom_read" and gathers stack traces. Then it reads the stack traces from the stackmap. urandom_read is a statically link binary that reads from /dev/urandom. test_stacktrace_build_id() calls readelf to read

Re: "wrong" ifindex on received VLAN tagged packet?

On 3/6/18 5:27 PM, Lawrence Kreeger wrote: > Using ETH_P_ALL instead of ETH_P_802_2, is causing mstpd to get 3 > copies of the same BPDU. One from eth0, one from eth0.100, and > another from vlan100 (the bridge). > mstpd will drop the one from vlan100, but since there is also an > instance of

Re: [PATCH 00/30] Netfilter/IPVS updates for net-next

On 2018-03-12 21:01, David Miller wrote: > From: Felix Fietkau > Date: Mon, 12 Mar 2018 20:30:01 +0100 > >> It's not dead and useless. In its current state, it has a software fast >> path that significantly improves nftables routing/NAT throughput, >> especially on embedded

[PATCH net-next 1/1] net sched actions: return explicit error when tunnel_key mode is not specified

If set/unset mode of the tunnel_key action is not provided, ->init() still returns 0, and the caller proceeds with bogus 'struct tc_action *' object, this results in crash: % tc actions add action tunnel_key src_ip 1.1.1.1 dst_ip 2.2.2.1 id 7 index 1 [ 35.805515] general protection fault:

Re: [pci PATCH v5 1/4] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

On Mon, Mar 12, 2018 at 11:23 AM, Keith Busch wrote: > On Mon, Mar 12, 2018 at 11:09:34AM -0700, Alexander Duyck wrote: >> On Mon, Mar 12, 2018 at 10:40 AM, Keith Busch wrote: >> > On Mon, Mar 12, 2018 at 10:21:29AM -0700, Alexander Duyck wrote: >>

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: >This patch enables virtio_net to switch over to a VF datapath when a VF >netdev is present with the same MAC address. It allows live migration >of a VM with a direct attached VF without the need to setup a bond/team >between

[net-next 6/6] ixgbe: fix disabling hide VLAN on VF reset

From: Paul Greenwalt If port VLAN is enabled, set PFQDE.HIDE_VLAN during VF reset. Setting only PFQDE.PFQDE during VF reset was clearing PFQDE.HIDE_VLAN. Signed-off-by: Paul Greenwalt Tested-by: Andrew Bowers

[net-next 0/6][pull request] 10GbE Intel Wired LAN Driver Updates 2018-03-12

This series contains updates to ixgbe and ixgbevf only. Shannon Nelson provides three fixes to the ipsec portion of ixgbe. Make sure we are using 128-bit authentication, since it is the only size supported for hardware offload. Fixed the transmit trailer length calculation for ipsec by finding

[net-next 3/6] ixgbe: remove unneeded ipsec state free callback

From: Shannon Nelson With commit 7f05b467a735 ("xfrm: check for xdo_dev_state_free") we no longer need to add an empty callback function to the driver, so now let's remove the useless code. Signed-off-by: Shannon Nelson Tested-by: Andrew

[net-next 5/6] ixgbevf: fix unused variable warning

From: Arnd Bergmann The new ixgbevf_set_rx_buffer_len() function causes a harmless warnings in configurations with large page size: drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c: In function 'ixgbevf_set_rx_buffer_len':

Re: [PATCH net-next v2] ibmvnic: Bail from ibmvnic_open if driver is already open

On 03/12/2018 03:10 PM, Andrew Lunn wrote: >> The problem here is that our routine to change the mtu does a full reset on >> the driver meaning that in the process we go from effectively "open" to >> "closed" to "open" again. >> >> Consider the scenario where we change the mtu by running "ifdown

[net-next 1/6] ixgbe: check for 128-bit authentication

From: Shannon Nelson Make sure the Security Association is using a 128-bit authentication, since that's the only size that the hardware offload supports. Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers

[net-next 2/6] ixgbe: fix ipsec trailer length

From: Shannon Nelson Fix up the Tx trailer length calculation. We can't believe the trailer len from the xstate information because it was calculated before the packet was put together and padding added. This bit of code finds the padding value in the trailer, adds

[net-next 4/6] ixgbe: Add receive length error counter

From: Tonghao Zhang ixgbe enabled rlec counter and the rx_error used it. We can export the counter directly via ethtool -S ethX. Signed-off-by: Tonghao Zhang Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

Re: [PATCH net-next v2] ibmvnic: Bail from ibmvnic_open if driver is already open

> The problem here is that our routine to change the mtu does a full reset on > the driver meaning that in the process we go from effectively "open" to > "closed" to "open" again. > > Consider the scenario where we change the mtu by running "ifdown ", > editing the ifcfg file with the new mtu,

Re: [PATCH net-next 2/5] bridge: propagate BR_ flags updates through sysfs to switchdev

On 03/10/2018 08:38 AM, Andrew Lunn wrote: + return 0; + + err = br_switchdev_set_port_flag(p, flags, mask); + if (err) + return err; You might want to consider the br_warn() in br_switchdev_set_port_flag(). Do we want to spam the kernel log? Or should

[RESEND PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

Signed-off-by: Roman Mashak --- .../tc-testing/tc-tests/actions/gact.json | 73 +- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/gact.json

[RESEND PATCH net-next 1/1] tc-testing: add TC vlan action tests

Signed-off-by: Roman Mashak --- .../tc-testing/tc-tests/actions/vlan.json | 410 + 1 file changed, 410 insertions(+) create mode 100644 tools/testing/selftests/tc-testing/tc-tests/actions/vlan.json diff --git

  1   2   3   4   >