[PATCH v6 4/5] ixgbe: Report PCIe link properties with pcie_print_link_status()

2018-05-03 Thread Bjorn Helgaas
From: Bjorn Helgaas Previously the driver used pcie_get_minimum_link() to warn when the NIC is in a slot that can't supply as much bandwidth as the NIC could use. pcie_get_minimum_link() can be misleading because it finds the slowest link and the narrowest link (which may

Re: [PATCH] atm: zatm: Fix potential Spectre v1

2018-05-03 Thread David Miller
From: Randy Dunlap Date: Thu, 3 May 2018 12:09:40 -0700 > Just for (my) info: all of these types of patches are to prevent > what is loaded in cache when the index is out of range, right? > Not some random pool_info[random], but pool_info[valid, i.e., 0]. > > Since the

Re: KMSAN: uninit-value in strcmp

2018-05-03 Thread David Miller
From: syzbot Date: Thu, 03 May 2018 11:44:02 -0700 > Call Trace: > __dump_stack lib/dump_stack.c:17 [inline] > dump_stack+0x185/0x1d0 lib/dump_stack.c:53 > kmsan_report+0x142/0x240 mm/kmsan/kmsan.c:1067 > __msan_warning_32+0x6c/0xb0

Re: [PATCH net] dccp: fix tasklet usage

2018-05-03 Thread David Miller
From: Eric Dumazet Date: Thu, 3 May 2018 09:39:20 -0700 > syzbot reported a crash in tasklet_action_common() caused by dccp. > > dccp needs to make sure socket wont disappear before tasklet handler > has completed. > > This patch takes a reference on the socket when

Re: [PATCH] atm: zatm: Fix potential Spectre v1

2018-05-03 Thread Randy Dunlap
On 05/03/2018 11:17 AM, Gustavo A. R. Silva wrote: > pool can be indirectly controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > > drivers/atm/zatm.c:1462 zatm_ioctl() warn: potential

[PATCH] net: atm: Fix potential Spectre v1

2018-05-03 Thread Gustavo A. R. Silva
ioc_data.dev_num can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: net/atm/lec.c:702 lec_vcc_attach() warn: potential spectre issue 'dev_lec' Fix this by sanitizing ioc_data.dev_num

Re: [PATCH net 0/3] net/smc: fixes 2018/05/03

2018-05-03 Thread David Miller
From: Ursula Braun Date: Thu, 3 May 2018 17:57:36 +0200 > From: Ursula Braun > > Dave, > > here are smc fixes for 2 problems: > * receive buffers in SMC must be registered. If registration fails >these buffers must not be kept within the

Re: [PATCH] qed: fix spelling mistake: "offloded" -> "offloaded"

2018-05-03 Thread David Miller
From: Colin King Date: Thu, 3 May 2018 16:19:32 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in DP_NOTICE message > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] net/mlx5: fix spelling mistake: "modfiy" -> "modify"

2018-05-03 Thread David Miller
From: Colin King Date: Thu, 3 May 2018 14:35:03 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in netdev_warn warning message > > Signed-off-by: Colin Ian King Saeed, please send this to me in

KMSAN: uninit-value in strcmp

2018-05-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:d2d741e5d189 kmsan: add initialization for shmem pages git tree: https://github.com/google/kmsan.git/master console output: https://syzkaller.appspot.com/x/log.txt?x=1005149780 kernel config:

Re: [PATCH net-next v2 00/15] ARM: sun8i: r40: Add Ethernet support

2018-05-03 Thread David Miller
From: Maxime Ripard Date: Thu, 3 May 2018 15:12:57 +0200 > Hi Dave, > > On Wed, May 02, 2018 at 11:06:17AM -0400, David Miller wrote: >> From: Chen-Yu Tsai >> Date: Wed, 2 May 2018 00:33:45 +0800 >> >> > I should've mentioned that patches 3 ~ 10, and

[PATCH] atm: zatm: Fix potential Spectre v1

2018-05-03 Thread Gustavo A. R. Silva
pool can be indirectly controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: drivers/atm/zatm.c:1462 zatm_ioctl() warn: potential spectre issue 'zatm_dev->pool_info' (local cap) Fix this by

[PATCH rdma-next] MAINTAINERS: Remove bouncing @mellanox.com addresses

2018-05-03 Thread Leon Romanovsky
From: Leon Romanovsky Delete non-existent @mellanox.com addresses from MAINTAINERS file. Signed-off-by: Leon Romanovsky --- MAINTAINERS | 6 -- 1 file changed, 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0a1410d5a621..1b52c7e7fc7d

Re: [PATCH net-next] net: stmmac: Add support for U32 TC filter using Flexible RX Parser

2018-05-03 Thread David Miller
From: Jose Abreu Date: Thu, 3 May 2018 13:45:30 +0100 > +static int dwmac5_rxp_update_single_entry(void __iomem *ioaddr, > + struct stmmac_tc_entry *entry, int pos) Please follow the Linux networking coding style for function arguments in function

Re: [PATCH bpf-next v4 0/4] Hash support for sock

2018-05-03 Thread David Miller
From: John Fastabend Date: Thu, 3 May 2018 11:28:24 -0700 > In the original sockmap implementation we got away with using an > array similar to devmap. However, unlike devmap where an ifindex > has a nice 1:1 function into the map we have found some use cases > with

[PATCH bpf-next v4 4/4] bpf: bpftool, support for sockhash

2018-05-03 Thread John Fastabend
This adds the SOCKHASH map type to bpftools so that we get correct pretty printing. Signed-off-by: John Fastabend --- tools/bpf/bpftool/map.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c index a6cdb64..4420b1a

[PATCH bpf-next v4 3/4] bpf: selftest additions for SOCKHASH

2018-05-03 Thread John Fastabend
This runs existing SOCKMAP tests with SOCKHASH map type. To do this we push programs into include file and build two BPF programs. One for SOCKHASH and one for SOCKMAP. We then run the entire test suite with each type. Signed-off-by: John Fastabend ---

[PATCH bpf-next v4 2/4] bpf: sockmap, add hash map support

2018-05-03 Thread John Fastabend
Sockmap is currently backed by an array and enforces keys to be four bytes. This works well for many use cases and was originally modeled after devmap which also uses four bytes keys. However, this has become limiting in larger use cases where a hash would be more appropriate. For example users

[PATCH bpf-next v4 0/4] Hash support for sock

2018-05-03 Thread John Fastabend
In the original sockmap implementation we got away with using an array similar to devmap. However, unlike devmap where an ifindex has a nice 1:1 function into the map we have found some use cases with sockets that need to be referenced using longer keys. This series adds support for a sockhash

[PATCH bpf-next v4 1/4] bpf: sockmap, refactor sockmap routines to work with hashmap

2018-05-03 Thread John Fastabend
This patch only refactors the existing sockmap code. This will allow much of the psock initialization code path and bpf helper codes to work for both sockmap bpf map types that are backed by an array, the currently supported type, and the new hash backed bpf map type sockhash. Most the fallout

Re: [PATCH net-next] net: core: rework skb_probe_transport_header()

2018-05-03 Thread David Miller
From: Paolo Abeni Date: Thu, 03 May 2018 19:59:16 +0200 > On Thu, 2018-05-03 at 13:32 -0400, David Miller wrote: >> From: Paolo Abeni >> Date: Thu, 3 May 2018 11:35:35 +0200 >> >> > When the transport header is not available, skb_probe_transport_header()

Re: [lkp-robot] 486ad79630 [ 15.532543] BUG: unable to handle kernel NULL pointer dereference at 0000000000000004

2018-05-03 Thread Cong Wang
On Wed, May 2, 2018 at 10:44 PM, Andrew Morton wrote: > On Wed, 2 May 2018 21:58:25 -0700 Cong Wang wrote: > >> On Wed, May 2, 2018 at 9:27 PM, Andrew Morton >> wrote: >> > >> > So it's saying that something which

Re: [PATCH net-next] net: core: rework skb_probe_transport_header()

2018-05-03 Thread Paolo Abeni
On Thu, 2018-05-03 at 13:32 -0400, David Miller wrote: > From: Paolo Abeni > Date: Thu, 3 May 2018 11:35:35 +0200 > > > When the transport header is not available, skb_probe_transport_header() > > resorts to fully dissect the flow keys, even if it only needs the > > ransport

Re: [PATCH net-next mlxsw v2 0/2] bridge: FDB: Notify about removal of non-user-added entries

2018-05-03 Thread David Miller
From: Petr Machata Date: Thu, 03 May 2018 14:43:40 +0200 > Device drivers may generally need to keep in sync with bridge's FDB. In > particular, for its offload of tc mirror action where the mirrored-to > device is a gretap device, mlxsw needs to listen to a number of events,

Re: [PATCH net-next 0/4] mlxsw: Introduce support for CQEv1/2

2018-05-03 Thread David Miller
From: Ido Schimmel Date: Thu, 3 May 2018 14:59:38 +0300 > Jiri says: > > Current SwitchX2 and Spectrum FWs support CQEv0 and that is what we > implement in mlxsw. Spectrum FW also supports CQE v1 and v2. > However, Spectrum-2 won't support CQEv0. Prepare for it and setup

Re: [PATCH net-next] net: bridge: avoid duplicate notification on up/down/change netdev events

2018-05-03 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 3 May 2018 13:47:24 +0300 > While handling netdevice events, br_device_event() sometimes uses > br_stp_(disable|enable)_port which unconditionally send a notification, > but then a second notification for the same event is sent

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-05-03 Thread Mikulas Patocka
On Wed, 2 May 2018, John Stoffel wrote: > You miss my point, which is that there's no explanation of what the > difference is between SLAB and SLUB and which I should choose. The > same goes here. If the KConfig option doesn't give useful info, it's > useless. So what, we could write

Re: [PATCH net-next mlxsw 0/3] selftests: forwarding: Updates to sysctl handling

2018-05-03 Thread David Miller
From: Petr Machata Date: Thu, 03 May 2018 12:36:52 +0200 > Some selftests need to adjust sysctl settings. In order to be neutral to > the system that the test is run on, it is a good practice to change back > to the original setting after the test ends. That involves some >

Re: [PATCH net-next] net: core: rework skb_probe_transport_header()

2018-05-03 Thread David Miller
From: Paolo Abeni Date: Thu, 3 May 2018 11:35:35 +0200 > When the transport header is not available, skb_probe_transport_header() > resorts to fully dissect the flow keys, even if it only needs the > ransport offset. We can obtain the latter using a simpler flow dissector - >

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-05-03 Thread Mikulas Patocka
On Tue, 1 May 2018, Andrew Morton wrote: > On Tue, 24 Apr 2018 12:33:01 -0400 (EDT) Mikulas Patocka > wrote: > > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > On Tue 24-04-18 11:30:40, Mikulas Patocka wrote: > > > > > > > > > > > > On Tue, 24 Apr

Re: [PATCH net-next] net: core: rework skb_probe_transport_header()

2018-05-03 Thread Paolo Abeni
On Thu, 2018-05-03 at 20:55 +0800, Jason Wang wrote: > > On 2018年05月03日 17:35, Paolo Abeni wrote: > > When the transport header is not available, skb_probe_transport_header() > > resorts to fully dissect the flow keys, even if it only needs the > > ransport offset. We can obtain the latter using

Re: [PATCH] net/mlx5e: fix spelling mistake: "loobpack" -> "loopback"

2018-05-03 Thread David Miller
From: Colin King Date: Thu, 3 May 2018 10:12:53 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in netdev_err error message > > Signed-off-by: Colin Ian King Transposed characters are so annoying

Re: [PATCH V2] net/netlink: optimize seq_puts and seq_printf in af_netlink.c

2018-05-03 Thread David Miller
From: YU Bo Date: Thu, 3 May 2018 05:09:04 -0400 > Before the patch, the command `cat /proc/net/netlink` will output > like: > > https://clbin.com/BojZv > > After the patch: > > https://clbin.com/lnu4L > > The optimization will make convenience for using `cat >

Re: [PATCH net-next 0/2] selftests: forwarding: Two enhancements

2018-05-03 Thread David Miller
From: Ido Schimmel Date: Thu, 3 May 2018 10:51:31 +0300 > First patch increases the maximum deviation in the multipath tests which > proved to be too low in some cases. > > Second patch allows user to run only specific tests from each file using > the TESTS environment

Re: [PATCH net-next] cxgb4: update latest firmware version supported

2018-05-03 Thread David Miller
From: Ganesh Goudar Date: Thu, 3 May 2018 11:54:23 +0530 > Change t4fw_version.h to update latest firmware version > number to 1.19.1.0. > > Signed-off-by: Ganesh Goudar Applied, thanks.

Re: [PATCH] bpf: fix possible spectre-v1 in find_and_alloc_map()

2018-05-03 Thread David Miller
From: Mark Rutland Date: Thu, 3 May 2018 17:04:59 +0100 > It's possible for userspace to control attr->map_type. Sanitize it when > using it as an array index to prevent an out-of-bounds value being used > under speculation. > > Found by smatch. > > Signed-off-by: Mark

[PATCH net] dccp: fix tasklet usage

2018-05-03 Thread Eric Dumazet
syzbot reported a crash in tasklet_action_common() caused by dccp. dccp needs to make sure socket wont disappear before tasklet handler has completed. This patch takes a reference on the socket when arming the tasklet, and moves the sock_put() from dccp_write_xmit_timer() to dccp_write_xmitlet()

[PATCH net-next] net: hns3: Add support of hardware rx-vlan-offload to HNS3 VF driver

2018-05-03 Thread Salil Mehta
From: Yunsheng Lin This patch adds support of hardware rx-vlan-offload to VF driver. VF uses mailbox to convey PF to configure the hardware. Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li Signed-off-by: Salil Mehta

Re: [PATCH v6] bpf, x86_32: add eBPF JIT compiler for ia32

2018-05-03 Thread Daniel Borkmann
On 05/03/2018 08:10 AM, Wang YanQing wrote: > The JIT compiler emits ia32 bit instructions. Currently, It supports eBPF > only. Classic BPF is supported because of the conversion by BPF core. > > Almost all instructions from eBPF ISA supported except the following: > BPF_ALU64 | BPF_DIV | BPF_K >

[PATCH net] openvswitch: Don't swap table in nlattr_set() after OVS_ATTR_NESTED is found

2018-05-03 Thread Stefano Brivio
If an OVS_ATTR_NESTED attribute type is found while walking through netlink attributes, we call nlattr_set() recursively passing the length table for the following nested attributes, if different from the current one. However, once we're done with those sub-nested attributes, we should continue

[PATCH net-next 2/4] smc: make smc_rx_wait_data() generic

2018-05-03 Thread Ursula Braun
From: Stefan Raspl Turn smc_rx_wait_data into a generic function that can be used at various instances to wait on traffic to complete with varying criteria. Signed-off-by: Stefan Raspl Signed-off-by: Ursula Braun < ---

[PATCH net-next 0/4] net/smc: splice implementation

2018-05-03 Thread Ursula Braun
From: Ursula Braun Dave, Stefan comes up with an smc implementation for splice(). The first three patches are preparational patches, the 4th patch implements splice(). Thanks, Ursula Stefan Raspl (4): smc: simplify abort logic smc: make smc_rx_wait_data() generic

[PATCH net-next 1/4] smc: simplify abort logic

2018-05-03 Thread Ursula Braun
From: Stefan Raspl Some of the conditions to exit recv() are common in two pathes - cleaning up code by moving the check up so we have it only once. Signed-off-by: Stefan Raspl Signed-off-by: Ursula Braun < ---

[PATCH net-next 3/4] smc: allocate RMBs as compound pages

2018-05-03 Thread Ursula Braun
From: Stefan Raspl Preparatory work for splice() support. Signed-off-by: Stefan Raspl Signed-off-by: Ursula Braun < --- net/smc/smc_core.c | 18 +- net/smc/smc_core.h | 1 + 2 files changed, 10

[PATCH net-next 4/4] smc: add support for splice()

2018-05-03 Thread Ursula Braun
From: Stefan Raspl Provide an implementation for splice() when we are using SMC. See smc_splice_read() for further details. Signed-off-by: Stefan Raspl Signed-off-by: Ursula Braun < --- net/smc/af_smc.c | 38 +++--

[PATCH] bpf: fix possible spectre-v1 in find_and_alloc_map()

2018-05-03 Thread Mark Rutland
It's possible for userspace to control attr->map_type. Sanitize it when using it as an array index to prevent an out-of-bounds value being used under speculation. Found by smatch. Signed-off-by: Mark Rutland Cc: Alexei Starovoitov Cc: Dan Carpenter

Re: [bug report] net/mlx5e: TLS, Add Innova TLS TX offload data path

2018-05-03 Thread Boris Pismenny
Hi Dan, Thanks for taking a look at our code. On 05/03/18 15:07, Leon Romanovsky wrote: + Saeed, Boris and netdev On Thu, May 03, 2018 at 02:23:00PM +0300, Dan Carpenter wrote: Hello Ilya Lesokhin, The patch bf23974104fa: "net/mlx5e: TLS, Add Innova TLS TX offload data path" from Apr 30,

[PATCH net 3/3] smc: fix sendpage() call

2018-05-03 Thread Ursula Braun
From: Stefan Raspl The sendpage() call grabs the sock lock before calling the default implementation - which tries to grab it once again. Signed-off-by: Stefan Raspl Signed-off-by: Ursula Braun < --- net/smc/af_smc.c | 6

[PATCH net 0/3] net/smc: fixes 2018/05/03

2018-05-03 Thread Ursula Braun
From: Ursula Braun Dave, here are smc fixes for 2 problems: * receive buffers in SMC must be registered. If registration fails these buffers must not be kept within the link group for reuse. Patch 1 is a preparational patch; patch 2 contains the fix. * sendpage:

[PATCH net 2/3] net/smc: handle unregistered buffers

2018-05-03 Thread Ursula Braun
From: Karsten Graul When smc_wr_reg_send() fails then tag (regerr) the affected buffer and free it in smc_buf_unuse(). Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 4 +++-

[PATCH net 1/3] net/smc: call consolidation

2018-05-03 Thread Ursula Braun
From: Karsten Graul Consolidate the call to smc_wr_reg_send() in a new function. No functional changes. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 35 +++ 1

Re: [bpf-next v1 0/9] bpf: Add helper to do FIB lookups

2018-05-03 Thread David Miller
From: David Ahern Date: Wed, 2 May 2018 20:53:10 -0700 > Provide a helper for doing a FIB and neighbor lookup in the kernel > tables from an XDP program. The helper provides a fastpath for forwarding > packets. If the packet is a local delivery or for any reason is not a >

Re: [PATCH net] tcp: restore autocorking

2018-05-03 Thread David Miller
From: Eric Dumazet Date: Wed, 2 May 2018 20:25:13 -0700 > When adding rb-tree for TCP retransmit queue, we inadvertently broke > TCP autocorking. > > tcp_should_autocork() should really check if the rtx queue is not empty. > > Tested: ... > Fixes: 75c119afe14f ("tcp:

Re: [PATCH net-next] ip6_gre: correct the function name in ip6gre_tnl_addr_conflict() comment

2018-05-03 Thread David Miller
From: Sun Lianwen Date: Thu, 3 May 2018 09:34:29 +0800 > The function name is wrong in ip6gre_tnl_addr_conflict() comment, which > use ip6_tnl_addr_conflict instead of ip6gre_tnl_addr_conflict. > > Signed-off-by: Sun Lianwen Applied.

Re: [PATCH net-next v7 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-03 Thread Toke Høiland-Jørgensen
David Miller writes: > From: Toke Høiland-Jørgensen > Date: Wed, 02 May 2018 17:11:03 +0200 > >> diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c >> new file mode 100644 >> index ..18bc147f12bc >> --- /dev/null >> +++ b/net/sched/sch_cake.c

Re: [PATCH net-next] inet: add bound ports statistic

2018-05-03 Thread David Miller
From: Stephen Hemminger Date: Wed, 2 May 2018 15:11:08 -0700 > +int inet_bind_bucket_count(struct proto *prot); ... > +/* Count how many any entries are in the bind hash table */ > +unsigned int inet_bind_bucket_count(struct proto *prot) If it doesn't build, it

Re: [PATCH net] rds: do not leak kernel memory to user land

2018-05-03 Thread David Miller
From: Eric Dumazet Date: Wed, 2 May 2018 14:53:39 -0700 > syzbot/KMSAN reported an uninit-value in put_cmsg(), originating > from rds_cmsg_recv(). > > Simply clear the structure, since we have holes there, or since > rx_traces might be smaller than

Re: [PATCH net,stable] qmi_wwan: do not steal interfaces from class drivers

2018-05-03 Thread David Miller
From: Bjørn Mork Date: Wed, 2 May 2018 22:22:54 +0200 > The USB_DEVICE_INTERFACE_NUMBER matching macro assumes that > the { vendorid, productid, interfacenumber } set uniquely > identifies one specific function. This has proven to fail > for some configurable devices. One

Re: [PATCH net-next v7 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-03 Thread David Miller
From: Toke Høiland-Jørgensen Date: Wed, 02 May 2018 17:11:03 +0200 > diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c > new file mode 100644 > index ..18bc147f12bc > --- /dev/null > +++ b/net/sched/sch_cake.c > +static inline cobalt_time_t cobalt_get_time(void)

Re: [RFC][PATCH bpf] tools: bpftool: Fix tags for bpf-to-bpf calls

2018-05-03 Thread Naveen N. Rao
Alexei Starovoitov wrote: On 3/1/18 12:51 AM, Naveen N. Rao wrote: Daniel Borkmann wrote: Worst case if there's nothing better, potentially what one could do in bpf_prog_get_info_by_fd() is to dump an array of full addresses and have the imm part as the index pointing to one of them, just

[PATCH] qed: fix spelling mistake: "offloded" -> "offloaded"

2018-05-03 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in DP_NOTICE message Signed-off-by: Colin Ian King --- drivers/net/ethernet/qlogic/qed/qed_roce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net-next 0/2] Update csum tc action for batch operation.

2018-05-03 Thread David Miller
From: Craig Dillabaugh Date: Tue, 1 May 2018 10:17:42 -0400 > This patchset includes two patches the first updating act_csum.c > to include the get_fill_size routine required for batch operation, and > the second including updated TDC tests for the feature. Series

Re: [PATCH bpf-next v3 00/15] Introducing AF_XDP support

2018-05-03 Thread David Miller
From: Björn Töpel Date: Wed, 2 May 2018 13:01:21 +0200 > This patch set introduces a new address family called AF_XDP that is > optimized for high performance packet processing and, in upcoming > patch sets, zero-copy semantics. In this patch set, we have removed > all

Re: [PATCH net] tcp: restore autocorking

2018-05-03 Thread Soheil Hassas Yeganeh
On Wed, May 2, 2018 at 11:25 PM, Eric Dumazet wrote: > Fixes: 75c119afe14f ("tcp: implement rb-tree based retransmit queue") > Signed-off-by: Eric Dumazet > Reported-by: Michael Wenig > Tested-by: Michael Wenig

Re: [PATCH net] tcp: restore autocorking

2018-05-03 Thread Neal Cardwell
On Wed, May 2, 2018 at 11:25 PM Eric Dumazet wrote: > When adding rb-tree for TCP retransmit queue, we inadvertently broke > TCP autocorking. > tcp_should_autocork() should really check if the rtx queue is not empty. ... > Fixes: 75c119afe14f ("tcp: implement rb-tree

Re: [PATCH v1 net-next] net: dsa: mv88e6xxx: 88E6141/6341 SERDES support

2018-05-03 Thread Marek Behún
Sent v2 On Thu, 3 May 2018 15:15:15 +0200 Andrew Lunn wrote: > On Thu, May 03, 2018 at 03:06:48PM +0200, Marek Behún wrote: > > The 88E6141/6341 switches (also known as Topaz) have 1 SGMII lane, > > which can be configured the same way as the SERDES lane on 88E6390. > > > >

RE: [PATCH net] tcp: restore autocorking

2018-05-03 Thread Michael Wenig
Thank you, Eric, for fixing this! Michael -Original Message- From: Eric Dumazet [mailto:eduma...@google.com] Sent: Wednesday, May 2, 2018 8:25 PM To: David S . Miller Cc: netdev ; Eric Dumazet ; Michael Wenig

[PATCH v2 net-next] net: dsa: mv88e6xxx: 88E6141/6341 SERDES support

2018-05-03 Thread Marek Behún
The 88E6141/6341 switches (also known as Topaz) have 1 SGMII lane, which can be configured the same way as the SERDES lane on 88E6390. Signed-off-by: Marek Behun --- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ drivers/net/dsa/mv88e6xxx/serdes.c | 20

Re: [PATCH v2 net-next 2/4] net: add skeleton of bpfilter kernel module

2018-05-03 Thread Edward Cree
On 03/05/18 05:36, Alexei Starovoitov wrote: > bpfilter.ko consists of bpfilter_kern.c (normal kernel module code) > and user mode helper code that is embedded into bpfilter.ko > > The steps to build bpfilter.ko are the following: > - main.c is compiled by HOSTCC into the bpfilter_umh elf

Re: [PATCH 1/2] ixgbe: release lock for the duration of ixgbe_suspend_close()

2018-05-03 Thread Pavel Tatashin
> Hi Pavel, you might want to pull lock optimization out of this patch series. > The parallelization by itself is valuable, and optimizations for individual > devices including locks can come later. Hi Steve, Yes, I will pull this patch out of the series. Thank you for the suggestion. Pavel

Re: [PATCH RESEND] SUNRPC: fix include for cmpxchg_relaxed()

2018-05-03 Thread Jeff Layton
On Thu, 2018-05-03 at 14:50 +0100, Mark Rutland wrote: > Currently net/sunrpc/xprtmultipath.c is the only file outside of arch/ > headers and asm-generic/ headers to include , apparently > for the use of cmpxchg_relaxed(). > > However, many architectures do not provide cmpxchg_relaxed() in their

Re: [PATCH v1 net-next] net: dsa: mv88e6xxx: Fix name string for 88E6141

2018-05-03 Thread Marek Behún
Hmm, sorry, this is already merged. It seems I forgor to etch new commits for some time. On Thu, 3 May 2018 15:11:43 +0200 Andrew Lunn wrote: > On Thu, May 03, 2018 at 03:06:55PM +0200, Marek Behún wrote: > > The structure was copied from 88E6341 but the name was not changed. >

[PATCH] netfilter: nf_queue: Replace conntrack entry

2018-05-03 Thread Kristian Evensen
SKBs are assigned a conntrack entry before being passed to any NFQUEUEs, and if no entry is found then a new one is created. This behavior causes problems for some traffic patterns. For example, if two UDP packets to/from the same host (using the same ports) arrive at the "same" time, both are

Re: [PATCH 1/2] ixgbe: release lock for the duration of ixgbe_suspend_close()

2018-05-03 Thread Steven Sistare
On 5/3/2018 9:46 AM, Alexander Duyck wrote: > On Thu, May 3, 2018 at 6:30 AM, Pavel Tatashin > wrote: >> Hi Alex, > > Hi Pavel, > >>> I'm not a fan of dropping the mutex while we go through >>> ixgbe_close_suspend. I'm concerned it will result in us having a >>>

Re: DSA switch

2018-05-03 Thread Andrew Lunn
> It seems that although the bridge command functions, it takes several > seconds (~6-7 seconds !) from the time it resturns to shell till a > real communication works (ping between 2 PCs connected to switch). > Does it usually takes so much time ? PHY link up can take a second or two. Less if

Re: [PATCH net] tcp: restore autocorking

2018-05-03 Thread Eric Dumazet
On Thu, May 3, 2018 at 4:06 AM Tariq Toukan wrote: > On 03/05/2018 6:25 AM, Eric Dumazet wrote: > > When adding rb-tree for TCP retransmit queue, we inadvertently broke > > TCP autocorking. > > > > tcp_should_autocork() should really check if the rtx queue is not empty. >

Re: [PATCH bpf-next v3 00/15] Introducing AF_XDP support

2018-05-03 Thread Willem de Bruijn
On Wed, May 2, 2018 at 1:01 PM, Björn Töpel wrote: > From: Björn Töpel > > This patch set introduces a new address family called AF_XDP that is > optimized for high performance packet processing Great patchset, thanks. > and, in upcoming > patch

Re: DSA switch

2018-05-03 Thread Ran Shalit
On Thu, May 3, 2018 at 10:11 AM, Jiri Pirko wrote: > Thu, May 03, 2018 at 08:50:52AM CEST, ransha...@gmail.com wrote: >>On Wed, May 2, 2018 at 11:56 PM, Andrew Lunn wrote: >>> On Wed, May 02, 2018 at 11:20:05PM +0300, Ran Shalit wrote: Hello, Is

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

2018-05-03 Thread Tiwei Bie
On Thu, May 03, 2018 at 03:25:29PM +0800, Jason Wang wrote: > On 2018年05月03日 10:09, Tiwei Bie wrote: > > > > > So how about we use the straightforward way then? > > > > You mean we do new += vq->vring_packed.num instead > > > > of event_idx -= vq->vring_packed.num before calling > > > >

[PATCH RESEND] SUNRPC: fix include for cmpxchg_relaxed()

2018-05-03 Thread Mark Rutland
Currently net/sunrpc/xprtmultipath.c is the only file outside of arch/ headers and asm-generic/ headers to include , apparently for the use of cmpxchg_relaxed(). However, many architectures do not provide cmpxchg_relaxed() in their , and it is necessary to include to get this definition, as

Re: [PATCH 1/2] ixgbe: release lock for the duration of ixgbe_suspend_close()

2018-05-03 Thread Alexander Duyck
On Thu, May 3, 2018 at 6:30 AM, Pavel Tatashin wrote: > Hi Alex, Hi Pavel, >> I'm not a fan of dropping the mutex while we go through >> ixgbe_close_suspend. I'm concerned it will result in us having a >> number of races on shutdown. > > I would agree, but

Re: [PATCH] sctp: fix a potential missing-check bug

2018-05-03 Thread Wenwen Wang
On Thu, May 3, 2018 at 8:39 AM, Marcelo Ricardo Leitner wrote: > On Thu, May 03, 2018 at 08:31:28AM -0500, Wenwen Wang wrote: >> On Thu, May 3, 2018 at 7:46 AM, Marcelo Ricardo Leitner >> wrote: >> > On Thu, May 03, 2018 at 07:01:51AM -0500,

Re: [PATCH] sctp: fix a potential missing-check bug

2018-05-03 Thread Marcelo Ricardo Leitner
On Thu, May 03, 2018 at 08:31:28AM -0500, Wenwen Wang wrote: > On Thu, May 3, 2018 at 7:46 AM, Marcelo Ricardo Leitner > wrote: > > On Thu, May 03, 2018 at 07:01:51AM -0500, Wenwen Wang wrote: > >> On Wed, May 2, 2018 at 8:48 PM, Marcelo Ricardo Leitner > >>

Re: [PATCH bpf-next 00/12] Move ld_abs/ld_ind to native BPF

2018-05-03 Thread Daniel Borkmann
On 05/03/2018 03:05 AM, Daniel Borkmann wrote: > This set simplifies BPF JITs significantly by moving ld_abs/ld_ind > to native BPF, for details see individual patches. Main rationale > is in patch 'implement ld_abs/ld_ind in native bpf'. Thanks! [...] Noticed a minor issue, therefore will respin

Re: [PATCH 2/2] drivers core: multi-threading device shutdown

2018-05-03 Thread Pavel Tatashin
On Thu, May 3, 2018 at 1:54 AM Tobin C. Harding wrote: > This code was a pleasure to read, super clean. Hi Tobin, Thank you very much for your review, I will address all of your comments in the next revision. BTW, I found a lock ordering issue in my work that that I

[PATCH] net/mlx5: fix spelling mistake: "modfiy" -> "modify"

2018-05-03 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in netdev_warn warning message Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] sctp: fix a potential missing-check bug

2018-05-03 Thread Wenwen Wang
On Thu, May 3, 2018 at 7:46 AM, Marcelo Ricardo Leitner wrote: > On Thu, May 03, 2018 at 07:01:51AM -0500, Wenwen Wang wrote: >> On Wed, May 2, 2018 at 8:48 PM, Marcelo Ricardo Leitner >> wrote: >> > On Wed, May 02, 2018 at 08:27:05PM -0500,

Re: [PATCH 1/2] ixgbe: release lock for the duration of ixgbe_suspend_close()

2018-05-03 Thread Pavel Tatashin
Hi Alex, > I'm not a fan of dropping the mutex while we go through > ixgbe_close_suspend. I'm concerned it will result in us having a > number of races on shutdown. I would agree, but ixgbe_close_suspend() is already called without this mutex from ixgbe_close(). This path is executed also during

Re: [PATCH 1/2] ixgbe: release lock for the duration of ixgbe_suspend_close()

2018-05-03 Thread Alexander Duyck
On Wed, May 2, 2018 at 8:59 PM, Pavel Tatashin wrote: > Currently, during device_shutdown() ixgbe holds rtnl_lock for the duration > of lengthy ixgbe_close_suspend(). On machines with multiple ixgbe cards > this lock prevents scaling if device_shutdown() function is

Re: [PATCH v1 net-next] net: dsa: mv88e6xxx: 88E6141/6341 SERDES support

2018-05-03 Thread Andrew Lunn
On Thu, May 03, 2018 at 03:06:48PM +0200, Marek Behún wrote: > The 88E6141/6341 switches (also known as Topaz) have 1 SGMII lane, > which can be configured the same way as the SERDES lane on 88E6390. > > Signed-off-by: Marek Behun > +int mv88e6341_serdes_power(struct

[PATCH v1 net-next] net: dsa: mv88e6xxx: 88E6141/6341 SERDES support

2018-05-03 Thread Marek Behún
The 88E6141/6341 switches (also known as Topaz) have 1 SGMII lane, which can be configured the same way as the SERDES lane on 88E6390. Signed-off-by: Marek Behun --- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ drivers/net/dsa/mv88e6xxx/serdes.c | 20

[PATCH v1 net-next] net: dsa: mv88e6xxx: Fix name string for 88E6141

2018-05-03 Thread Marek Behún
The structure was copied from 88E6341 but the name was not changed. Signed-off-by: Marek Behun --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index

Re: [PATCH net-next v2 00/15] ARM: sun8i: r40: Add Ethernet support

2018-05-03 Thread Maxime Ripard
Hi Dave, On Wed, May 02, 2018 at 11:06:17AM -0400, David Miller wrote: > From: Chen-Yu Tsai > Date: Wed, 2 May 2018 00:33:45 +0800 > > > I should've mentioned that patches 3 ~ 10, and only these, should go > > through net-next. sunxi will handle the remaining clk, device tree,

Re: [PATCH v1 net-next] net: dsa: mv88e6xxx: Fix name string for 88E6141

2018-05-03 Thread Andrew Lunn
On Thu, May 03, 2018 at 03:06:55PM +0200, Marek Behún wrote: > The structure was copied from 88E6341 but the name was not changed. > > Signed-off-by: Marek Behun Hi Marek Which tree is this against? > --- > drivers/net/dsa/mv88e6xxx/chip.c | 2 +- > 1 file changed, 1

Re: [PATCH net-next mlxsw v2 2/2] net: bridge: Notify about !added_by_user FDB entries

2018-05-03 Thread Petr Machata
Nikolay Aleksandrov writes: > On 03/05/18 15:43, Petr Machata wrote: >> Do not automatically bail out on sending notifications about activity on >> non-user-added FDB entries. Instead, notify about this activity except >> for cases where the activity itself

[PATCH] dt-bindings: can: rcar_can: Fix R8A7796 SoC name

2018-05-03 Thread Geert Uytterhoeven
R8A7796 is R-Car M3-W. Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt

Re: [PATCH net-next mlxsw v2 2/2] net: bridge: Notify about !added_by_user FDB entries

2018-05-03 Thread Ivan Vecera
On 3.5.2018 14:43, Petr Machata wrote: > Do not automatically bail out on sending notifications about activity on > non-user-added FDB entries. Instead, notify about this activity except > for cases where the activity itself originates in a notification, to > avoid sending duplicate notifications.

Re: [PATCH net-next mlxsw v2 1/2] switchdev: Add fdb.added_by_user to switchdev notifications

2018-05-03 Thread Ivan Vecera
On 3.5.2018 14:43, Petr Machata wrote: > The following patch enables sending notifications also for events on FDB > entries that weren't added by the user. Give the drivers the information > necessary to distinguish between the two origins of FDB entries. > > To maintain the current behavior,

Re: [RFC PATCH 3/5] net: macb: Add pm runtime support

2018-05-03 Thread Claudiu Beznea
On 03.05.2018 14:13, Harini Katakam wrote: > Hi Claudiu, > > On Thu, May 3, 2018 at 3:39 PM, Claudiu Beznea > wrote: >> >> >> On 22.03.2018 15:51, harinikatakamli...@gmail.com wrote: >>> From: Harini Katakam > >> I would use a "goto"

Re: [PATCH net-next mlxsw v2 2/2] net: bridge: Notify about !added_by_user FDB entries

2018-05-03 Thread Nikolay Aleksandrov
On 03/05/18 15:43, Petr Machata wrote: Do not automatically bail out on sending notifications about activity on non-user-added FDB entries. Instead, notify about this activity except for cases where the activity itself originates in a notification, to avoid sending duplicate notifications.

<    1   2   3   >