Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-23 Thread Heiner Kallweit
Am 24.05.2018 um 00:04 schrieb Andrew Lunn: > On Wed, May 23, 2018 at 10:15:29PM +0200, Heiner Kallweit wrote: >> I have the issue that suspending the MAC-integrated PHY gives an >> error during system suspend. The sequence is: >> >> 1. unconnected PHY/MAC are runtime-suspended already >> 2.

Re: [PATCH bpf-next v4 3/7] tools/bpf: sync kernel header bpf.h and add bpf_task_fd_query in libbpf

2018-05-23 Thread Martin KaFai Lau
On Wed, May 23, 2018 at 05:18:43PM -0700, Yonghong Song wrote: > Sync kernel header bpf.h to tools/include/uapi/linux/bpf.h and > implement bpf_task_fd_query() in libbpf. The test programs > in samples/bpf and tools/testing/selftests/bpf, and later bpftool > will use this libbpf function to query

Re: [PATCH bpf-next v4 2/7] bpf: introduce bpf subcommand BPF_TASK_FD_QUERY

2018-05-23 Thread Martin KaFai Lau
On Wed, May 23, 2018 at 05:18:42PM -0700, Yonghong Song wrote: > Currently, suppose a userspace application has loaded a bpf program > and attached it to a tracepoint/kprobe/uprobe, and a bpf > introspection tool, e.g., bpftool, wants to show which bpf program > is attached to which

Re: [PATCH bpf-next 0/5] fix test_sockmap

2018-05-23 Thread John Fastabend
On 05/23/2018 09:47 PM, Prashant Bhole wrote: > > > On 5/23/2018 6:44 PM, Prashant Bhole wrote: >> >> >> On 5/22/2018 2:08 AM, John Fastabend wrote: >>> On 05/20/2018 10:13 PM, Prashant Bhole wrote: On 5/19/2018 1:42 AM, John Fastabend wrote: > On 05/18/2018 12:17 AM, Prashant

Re: [Cake] [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-23 Thread Kevin Darbyshire-Bryant
> On 23 May 2018, at 23:40, Toke Høiland-Jørgensen wrote: > > > Hmm, and we still have an issue with ingress filtering (where cake is > running on an ifb interface). That runs pre-NAT in the conntrack case, > and we can't do the RX trick. Here we do the lookup manually in >

Re: [PATCH bpf-next 0/5] fix test_sockmap

2018-05-23 Thread Prashant Bhole
On 5/23/2018 6:44 PM, Prashant Bhole wrote: On 5/22/2018 2:08 AM, John Fastabend wrote: On 05/20/2018 10:13 PM, Prashant Bhole wrote: On 5/19/2018 1:42 AM, John Fastabend wrote: On 05/18/2018 12:17 AM, Prashant Bhole wrote: This series fixes bugs in test_sockmap code. They weren't

[PATCH net-next] bpfilter: fix build dependency

2018-05-23 Thread Alexei Starovoitov
BPFILTER could have been enabled without INET causing this build error: ERROR: "bpfilter_process_sockopt" [net/bpfilter/bpfilter.ko] undefined! Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module") Reported-by: Jakub Kicinski Signed-off-by: Alexei

[PATCH net-next 7/8] nfp: flower: implement host cmsg handler for LAG

2018-05-23 Thread Jakub Kicinski
From: John Hurley Adds the control message handler to synchronize offloaded group config with that of the kernel. Such messages are sent from fw to driver and feature the following 3 flags: - Data: an attached cmsg could not be processed - store for retransmission -

[PATCH net-next 5/8] net: include hash policy in LAG changeupper info

2018-05-23 Thread Jakub Kicinski
From: John Hurley LAG upper event notifiers contain the tx type used by the LAG device. Extend this to also include the hash policy used for tx types that utilize hashing. Signed-off-by: John Hurley --- CC: Jiri Pirko CC:

[PATCH net-next 8/8] nfp: flower: compute link aggregation action

2018-05-23 Thread Jakub Kicinski
From: John Hurley If the egress device of an offloaded rule is a LAG port, then encode the output port to the NFP with a LAG identifier and the offloaded group ID. A prelag action is also offloaded which must be the first action of the series (although may appear

[PATCH net-next 4/8] nfp: flower: add per repr private data for LAG offload

2018-05-23 Thread Jakub Kicinski
From: John Hurley Add a bitmap to each flower repr to track its state if it is enslaved by a bond. This LAG state may be different to the port state - for example, the port may be up but LAG state may be down due to the selection in an active/backup bond.

[PATCH net-next 6/8] nfp: flower: monitor and offload LAG groups

2018-05-23 Thread Jakub Kicinski
From: John Hurley Monitor LAG events via the NETDEV_CHANGEUPPER/NETDEV_CHANGELOWERSTATE notifiers to maintain a list of offloadable groups. Sync these groups with HW via a delayed workqueue to prevent excessive re-configuration. When the workqueue is triggered it may

[PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-23 Thread Jakub Kicinski
Hi! This series from John adds bond offload to the nfp driver. Patch 5 exposes the hash type for NETDEV_LAG_TX_TYPE_HASH to make sure nfp hashing matches that of the software LAG. This may be unnecessarily conservative, let's see what LAG maintainers think :) John says: This patchset sets up

[PATCH net-next 3/8] nfp: flower: check for/turn on LAG support in firmware

2018-05-23 Thread Jakub Kicinski
From: John Hurley Check if the fw contains the _abi_flower_balance_sync_enable symbol. If it does then write a 1 to this indicating that the driver is willing to receive NIC to kernel LAG related control messages. If the write is successful, update the list of extra

[PATCH net-next 1/8] nfp: add ndo_set_mac_address for representors

2018-05-23 Thread Jakub Kicinski
From: John Hurley Adding a netdev to a bond requires that its mac address can be modified. The default eth_mac_addr is sufficient to satisfy this requirement. Signed-off-by: John Hurley Reviewed-by: Pieter Jansen van Vuuren

[PATCH net-next 2/8] nfp: nfpcore: add rtsym writing function

2018-05-23 Thread Jakub Kicinski
From: John Hurley Add an rtsym API function that combines the lookup of a symbol and the writing of a value to it. Values can be written as unsigned 32 or 64 bits. Signed-off-by: John Hurley Reviewed-by: Pieter Jansen van Vuuren

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Alexei Starovoitov
On 5/23/18 6:50 PM, Jakub Kicinski wrote: On Wed, 23 May 2018 18:33:52 -0700, Jakub Kicinski wrote: Minor glitch with Ubuntu 18.04: $ gcc --version gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 In file included from /usr/include/fcntl.h:290:0, from ../net/bpfilter/main.c:7: In function

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Jakub Kicinski
On Wed, 23 May 2018 18:33:52 -0700, Jakub Kicinski wrote: > Minor glitch with Ubuntu 18.04: > > $ gcc --version > gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 > > In file included from /usr/include/fcntl.h:290:0, > from ../net/bpfilter/main.c:7: > In function ‘open’, > inlined from

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Jakub Kicinski
Minor glitch with Ubuntu 18.04: $ gcc --version gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 In file included from /usr/include/fcntl.h:290:0, from ../net/bpfilter/main.c:7: In function ‘open’, inlined from ‘main’ at ../net/bpfilter/main.c:58:13:

[PATCH net v2] enic: set DMA mask to 47 bit

2018-05-23 Thread Govindarajulu Varadarajan
In commit 624dbf55a359b ("driver/net: enic: Try DMA 64 first, then failover to DMA") DMA mask was changed from 40 bits to 64 bits. Hardware actually supports only 47 bits. Fixes: 624dbf55a359b ("driver/net: enic: Try DMA 64 first, then failover to DMA") Signed-off-by: Govindarajulu Varadarajan

Re: [PATCH RFC net-next 00/11] udp gso

2018-05-23 Thread Willem de Bruijn
On Wed, May 23, 2018 at 8:02 PM, Marcelo Ricardo Leitner wrote: > On Wed, Apr 18, 2018 at 09:49:18AM -0400, Willem de Bruijn wrote: >> I just hacked up a sendmmsg extension to the benchmark to verify. >> Indeed that does not have nearly the same benefit as GSO: >> >>

[PATCH net-next] hv_netvsc: fix bogus ifalias on network device

2018-05-23 Thread Stephen Hemminger
If the guest network adapter is not configured with DeviceNaming enabled on the host, then the query for friendly name will return success but with a zero length name. Which then leads to a garbage value (stack contents) for ifalias. Fix is simple, just don't set name if host doesn't return it.

[PATCH bpf] bpf: properly enforce index mask to prevent out-of-bounds speculation

2018-05-23 Thread Daniel Borkmann
While reviewing the verifier code, I recently noticed that the following two program variants in relation to tail calls can be loaded. Variant 1: # bpftool p d x i 15 0: (15) if r1 == 0x0 goto pc+3 1: (18) r2 = map[id:5] 3: (05) goto pc+2 4: (18) r2 = map[id:6] 6: (b7) r3 =

[PATCH bpf-next v4 5/7] samples/bpf: add a samples/bpf test for BPF_TASK_FD_QUERY

2018-05-23 Thread Yonghong Song
This is mostly to test kprobe/uprobe which needs kernel headers. Signed-off-by: Yonghong Song --- samples/bpf/Makefile | 4 + samples/bpf/task_fd_query_kern.c | 19 ++ samples/bpf/task_fd_query_user.c | 382 +++ 3 files changed,

[PATCH bpf-next v4 6/7] tools/bpf: add two BPF_TASK_FD_QUERY tests in test_progs

2018-05-23 Thread Yonghong Song
The new tests are added to query perf_event information for raw_tracepoint and tracepoint attachment. For tracepoint, both syscalls and non-syscalls tracepoints are queries as they are treated slightly differently inside the kernel. Signed-off-by: Yonghong Song ---

[PATCH bpf-next v4 7/7] tools/bpftool: add perf subcommand

2018-05-23 Thread Yonghong Song
The new command "bpftool perf [show | list]" will traverse all processes under /proc, and if any fd is associated with a perf event, it will print out related perf event information. Documentation is also added. Below is an example to show the results using bcc commands. Running the following 4

[PATCH bpf-next v4 2/7] bpf: introduce bpf subcommand BPF_TASK_FD_QUERY

2018-05-23 Thread Yonghong Song
Currently, suppose a userspace application has loaded a bpf program and attached it to a tracepoint/kprobe/uprobe, and a bpf introspection tool, e.g., bpftool, wants to show which bpf program is attached to which tracepoint/kprobe/uprobe. Such attachment information will be really useful to

[PATCH bpf-next v4 1/7] perf/core: add perf_get_event() to return perf_event given a struct file

2018-05-23 Thread Yonghong Song
A new extern function, perf_get_event(), is added to return a perf event given a struct file. This function will be used in later patches. Signed-off-by: Yonghong Song --- include/linux/perf_event.h | 5 + kernel/events/core.c | 8 2 files changed, 13

[PATCH bpf-next v4 3/7] tools/bpf: sync kernel header bpf.h and add bpf_task_fd_query in libbpf

2018-05-23 Thread Yonghong Song
Sync kernel header bpf.h to tools/include/uapi/linux/bpf.h and implement bpf_task_fd_query() in libbpf. The test programs in samples/bpf and tools/testing/selftests/bpf, and later bpftool will use this libbpf function to query kernel. Signed-off-by: Yonghong Song ---

[PATCH bpf-next v4 4/7] tools/bpf: add ksym_get_addr() in trace_helpers

2018-05-23 Thread Yonghong Song
Given a kernel function name, ksym_get_addr() will return the kernel address for this function, or 0 if it cannot find this function name in /proc/kallsyms. This function will be used later when a kernel address is used to initiate a kprobe perf event. Acked-by: Martin KaFai Lau

[PATCH bpf-next v4 0/7] bpf: implement BPF_TASK_FD_QUERY

2018-05-23 Thread Yonghong Song
Currently, suppose a userspace application has loaded a bpf program and attached it to a tracepoint/kprobe/uprobe, and a bpf introspection tool, e.g., bpftool, wants to show which bpf program is attached to which tracepoint/kprobe/uprobe. Such attachment information will be really useful to

[PATCH v2 net-next 2/3] net/ipv6: Udate fib6_table_lookup tracepoint

2018-05-23 Thread dsahern
From: David Ahern Commit bb0ad1987e96 ("ipv6: fib6_rules: support for match on sport, dport and ip proto") added support for protocol and ports to FIB rules. Update the FIB lookup tracepoint to dump the parameters. Signed-off-by: David Ahern ---

[PATCH v2 net-next 0/3] net: Update fib_table_lookup tracepoints

2018-05-23 Thread dsahern
From: David Ahern Update the FIB lookup tracepoints to include ip proto and port fields from the flow struct. In the process make the IPv4 tracepoint inline with IPv6 which is much easier to use and follow the lookup and result. Remove the tracepoint in fib_validate_source

[PATCH v2 net-next 3/3] net/ipv4: Remove tracepoint in fib_validate_source

2018-05-23 Thread dsahern
From: David Ahern Tracepoint does not add value and the call to fib_lookup follows it which shows the same information and the fib lookup result. Signed-off-by: David Ahern --- include/trace/events/fib.h | 35 ---

[PATCH v2 net-next 1/3] net/ipv4: Udate fib_table_lookup tracepoint

2018-05-23 Thread dsahern
From: David Ahern Commit 4a2d73a4fb36 ("ipv4: fib_rules: support match on sport, dport and ip proto") added support for protocol and ports to FIB rules. Update the FIB lookup tracepoint to dump the parameters. In addition, make the IPv4 tracepoint similar to the IPv6 one

Re: [PATCH RFC net-next 00/11] udp gso

2018-05-23 Thread Marcelo Ricardo Leitner
On Wed, Apr 18, 2018 at 09:49:18AM -0400, Willem de Bruijn wrote: > I just hacked up a sendmmsg extension to the benchmark to verify. > Indeed that does not have nearly the same benefit as GSO: > > udp tx:976 MB/s 695394 calls/s 16557 msg/s > > This matches the numbers seen from TCP

Re: [PATCH 05/15] mtd: nand: pxa3xx: remove the dmaengine compat need

2018-05-23 Thread Daniel Mack
Hi Robert, Please refer to the attached patch instead of the one I sent earlier. I missed to also remove the platform_get_resource(IORESOURCE_DMA) call. Thanks, Daniel On Friday, May 18, 2018 11:31 PM, Daniel Mack wrote: Hi Robert, Thanks for this series. On Monday, April 02, 2018 04:26

Re: [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-23 Thread Toke Høiland-Jørgensen
Pablo Neira Ayuso writes: > On Tue, May 22, 2018 at 04:11:06PM +0200, Toke Høiland-Jørgensen wrote: >> Pablo Neira Ayuso writes: >> >> > Hi Toke, >> > >> > On Tue, May 22, 2018 at 03:57:38PM +0200, Toke Høiland-Jørgensen wrote: >> >> When CAKE is

[PATCH V4] mlx4_core: allocate ICM memory in page size chunks

2018-05-23 Thread Qing Huang
When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in order to complete high order memory allocations. When that happens, user processes

Re: [PATCH net-next v3] net: sched: don't disable bh when accessing action idr

2018-05-23 Thread Cong Wang
On Wed, May 23, 2018 at 1:52 AM, Vlad Buslov wrote: > Initial net_device implementation used ingress_lock spinlock to synchronize > ingress path of device. This lock was used in both process and bh context. > In some code paths action map lock was obtained while holding

Re: INFO: rcu detected stall in corrupted

2018-05-23 Thread Marcelo Ricardo Leitner
On Mon, May 21, 2018 at 11:13:46AM -0700, Eric Dumazet wrote: > > > On 05/21/2018 11:09 AM, David Miller wrote: > > From: syzbot > > Date: Mon, 21 May 2018 11:05:02 -0700 > > > >> find_match+0x244/0x13a0 net/ipv6/route.c:691 > >>

Re: [PATCH v2] ppp: remove the PPPIOCDETACH ioctl

2018-05-23 Thread Paul Mackerras
On Wed, May 23, 2018 at 02:37:38PM -0700, Eric Biggers wrote: > From: Eric Biggers > > The PPPIOCDETACH ioctl effectively tries to "close" the given ppp file > before f_count has reached 0, which is fundamentally a bad idea. It > does check 'f_count < 2', which excludes

Re: [PATCH net-next] net:sched: add action inheritdsfield to skbmod

2018-05-23 Thread Cong Wang
On Thu, May 17, 2018 at 12:33 PM, Fu, Qiaobin wrote: > net/sched: add action inheritdsfield to skbmod > > The new action inheritdsfield copies the field DS of > IPv4 and IPv6 packets into skb->prioriry. This enables > later classification of packets based on the DS field. > >

[PATCH RFC net-next 8/9] net/ipv6: Add support for specifying metric of connected routes

2018-05-23 Thread dsahern
From: David Ahern Add support for IFA_RT_PRIORITY to ipv6 addresses. If the metric is changed on an existing address then the new route is inserted before removing the old one. Since the metric is one of the route keys, the prefix route can not be atomically replaced.

[PATCH RFC net-next 4/9] net/ipv6: Pass ifa6_config struct to inet6_addr_add

2018-05-23 Thread dsahern
From: David Ahern Move the creation of struct ifa6_config up to callers of inet6_addr_add. Signed-off-by: David Ahern --- net/ipv6/addrconf.c | 112 ++-- 1 file changed, 57 insertions(+), 55 deletions(-)

[PATCH RFC net-next 2/9] net/ipv6: Convert ipv6_add_addr to struct ifa6_config

2018-05-23 Thread dsahern
From: David Ahern Convert ipv6_add_addr from a list of address parameters to use the new ifa6_config struct. Mapping of variable changes: addr --> cfg->pfx peer_addr --> cfg->peer_pfx pfxlen--> cfg->plen flags --> cfg->ifa_flags scope,

[PATCH RFC net-next 7/9] net/ipv4: Add support for specifying metric of connected routes

2018-05-23 Thread dsahern
From: David Ahern Add support for IFA_RT_PRIORITY to ipv4 addresses. If the metric is changed on an existing address then the new route is inserted before removing the old one. Since the metric is one of the route keys, the prefix route can not be replaced. Signed-off-by:

[PATCH RFC net-next 6/9] net: Add IFA_RT_PRIORITY address attribute

2018-05-23 Thread dsahern
From: David Ahern Currently, if two interfaces have addresses in the same connected route, then the order of the prefix route entries is determined by the order in which the addresses are assigned or the links brought up. Add IFA_RT_PRIORITY to allow user to specify the

[PATCH RFC net-next 3/9] net/ipv6: Remove temp variables in ipv6_create_tempaddr

2018-05-23 Thread dsahern
From: David Ahern Remove temp variables in favor of ifa6_config struct. Signed-off-by: David Ahern --- net/ipv6/addrconf.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/net/ipv6/addrconf.c

[PATCH RFC net-next 5/9] net/ipv6: Pass ifa6_config struct to inet6_addr_modify

2018-05-23 Thread dsahern
From: David Ahern Update inet6_addr_modify to take ifa6_config. Signed-off-by: David Ahern --- net/ipv6/addrconf.c | 44 +++- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/net/ipv6/addrconf.c

[PATCH RFC net-next 0/9] net: Add address attribute to control metric of prefix route

2018-05-23 Thread dsahern
From: David Ahern For use cases such as VRR (Virtual Router Redundancy) interface managers want efficient control over the order of prefix routes when multiple interfaces have addresses with overlapping/duplicate subnets. Currently, if two interfaces have addresses in the

[PATCH RFC net-next 1/9] net/ipv6: Introduce ifa6_config struct

2018-05-23 Thread dsahern
From: David Ahern Move config parameters for adding an ipv6 address to a struct. struct names stem from inet6_rtm_newaddr which is the modern handler for adding an address. Signed-off-by: David Ahern --- include/net/addrconf.h | 12 1 file

[PATCH RFC net-next 9/9] selftests: fib_tests: Add prefix route tests with metric

2018-05-23 Thread dsahern
From: David Ahern Add tests verifying prefix routes are inserted with expected metric. IPv6 prefix route tests TEST: Default metric [ OK ] TEST: User specified metric on first device [ OK ] TEST: User specified

Re: [PATCH net-next v4 0/2] openvswitch: Support conntrack zone limit

2018-05-23 Thread Pravin Shelar
On Wed, May 23, 2018 at 10:13 AM, David Miller wrote: > From: Yi-Hung Wei > Date: Mon, 21 May 2018 17:16:03 -0700 > >> v3->v4: >> - Addresses comments from Parvin that include simplify netlink API, >> and remove unncessary RCU lockings. >> -

Re: [PATCH v2 net] netfilter: provide correct argument to nla_strlcpy()

2018-05-23 Thread Pablo Neira Ayuso
On Tue, May 22, 2018 at 08:14:39AM +0200, Florian Westphal wrote: > Eric Dumazet wrote: > > Recent patch forgot to remove nla_data(), upsetting syzkaller a bit. > > Duuuh Thanks Eric. > Acked-by: Florian Westphal Applied, thanks!

Re: [PATCH bpf-next v3 01/15] net: initial AF_XDP skeleton

2018-05-23 Thread Stephen Hemminger
On Wed, 2 May 2018 13:01:22 +0200 Björn Töpel wrote: > diff --git a/net/xdp/Kconfig b/net/xdp/Kconfig > new file mode 100644 > index ..90e4a7152854 > --- /dev/null > +++ b/net/xdp/Kconfig > @@ -0,0 +1,7 @@ > +config XDP_SOCKETS > + bool "XDP sockets" > +

Re: [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-23 Thread Pablo Neira Ayuso
On Tue, May 22, 2018 at 04:11:06PM +0200, Toke Høiland-Jørgensen wrote: > Pablo Neira Ayuso writes: > > > Hi Toke, > > > > On Tue, May 22, 2018 at 03:57:38PM +0200, Toke Høiland-Jørgensen wrote: > >> When CAKE is deployed on a gateway that also performs NAT (which is a > >>

Re: [PATCH v2] ath10k: transmit queued frames after waking queues

2018-05-23 Thread Niklas Cassel
On Wed, May 23, 2018 at 06:25:49PM +0200, Erik Stromdahl wrote: > > > On 05/22/2018 11:15 PM, Niklas Cassel wrote: > > > > > > > > Earlier we observed performance issues in calling push_pending from each > > > tx completion. IMHO this change may introduce the same problem again. > > > > I

Re: [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-23 Thread Toke Høiland-Jørgensen
David Miller writes: > From: Toke Høiland-Jørgensen > Date: Wed, 23 May 2018 23:05:16 +0200 > >> Ah, right, that could work. Is there any particular field in sk_buff >> we should stomp on for this purpose, or would you prefer a new one? >> Looking through it,

Re: [kbuild-all] [PATCH net-next 2/2] sctp: add sctp_make_op_error_limited and reuse inner functions

2018-05-23 Thread Marcelo Ricardo Leitner
On Tue, May 15, 2018 at 09:23:08AM +0800, Ye Xiaolong wrote: > On 05/14, Marcelo Ricardo Leitner wrote: > >On Mon, May 14, 2018 at 07:47:20PM +0800, Ye Xiaolong wrote: > >> On 05/14, Marcelo Ricardo Leitner wrote: > >> >On Mon, May 14, 2018 at 03:40:53PM +0800, Ye Xiaolong wrote: > >> >> >>

Re: [PATCH iproute2] ip route: Print expires as signed int

2018-05-23 Thread Stephen Hemminger
On Wed, 23 May 2018 11:50:01 -0700 dsah...@kernel.org wrote: > From: David Ahern > > rta_expires is a signed int; print it as one. > > Fixes: 663c3cb23103f ("iproute: implement JSON and color output") > Signed-off-by: David Ahern Applied, thanks.

Re: [PATCH iproute2] Allow to configure /var/run/netns directory

2018-05-23 Thread Stephen Hemminger
On Fri, 18 May 2018 15:44:00 -0700 Pavel Maltsev wrote: > Currently NETNS_RUN_DIR is hardcoded and refers to /var/run/netns. > However, some systems (e.g. Android) doesn't have /var > which results in error attempts to create network namespaces on these > systems. This change

[Patch net-next] net_sched: switch to rcu_work

2018-05-23 Thread Cong Wang
Commit 05f0fe6b74db ("RCU, workqueue: Implement rcu_work") introduces new API's for dispatching work in a RCU callback. Now we can just switch to the new API's for tc filters. This could get rid of a lot of code. Cc: Tejun Heo Cc: "Paul E. McKenney"

Re: [PATCH v3] ath10k: transmit queued frames after processing rx packets

2018-05-23 Thread Niklas Cassel
On Thu, May 24, 2018 at 12:15:08AM +0200, Niklas Cassel wrote: > This problem cannot be reproduced on low-latency devices, e.g. pci, > since they call ath10k_mac_tx_push_pending() from > ath10k_htt_txrx_compl_task(). ath10k_htt_txrx_compl_task() is not called > on high-latency devices. > Fix the

Re: [PATCH 2/4] arcnet: com20020: bindings for smsc com20020

2018-05-23 Thread Andrea Greco
On 05/23/2018 06:49 PM, Rob Herring wrote: > One typo, otherwise: > > Reviewed-by: Rob Herring Yes typo, Fixed over my branch, sorry for that... I expect a comment about bps, Bit per Second, used in `bus-speed-bps` You will add it by your self in property-units.txt, or required

[PATCH v3] ath10k: transmit queued frames after processing rx packets

2018-05-23 Thread Niklas Cassel
When running iperf on ath10k SDIO, TX can stop working: iperf -c 192.168.1.1 -i 1 -t 20 -w 10K [ 3] 0.0- 1.0 sec 2.00 MBytes 16.8 Mbits/sec [ 3] 1.0- 2.0 sec 3.12 MBytes 26.2 Mbits/sec [ 3] 2.0- 3.0 sec 3.25 MBytes 27.3 Mbits/sec [ 3] 3.0- 4.0 sec 655 KBytes 5.36 Mbits/sec [ 3]

Re: [PATCH] net: phy: replace bool members in struct phy_device with bit-fields

2018-05-23 Thread Andrew Lunn
On Wed, May 23, 2018 at 08:05:20AM +0200, Heiner Kallweit wrote: > In struct phy_device we have a number of flags being defined as type > bool. Similar to e.g. struct pci_dev we can save some space by using > bit-fields. > > Signed-off-by: Heiner Kallweit Reviewed-by:

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-23 Thread Andrew Lunn
On Wed, May 23, 2018 at 10:15:29PM +0200, Heiner Kallweit wrote: > I have the issue that suspending the MAC-integrated PHY gives an > error during system suspend. The sequence is: > > 1. unconnected PHY/MAC are runtime-suspended already > 2. system suspend commences > 3. mdio_bus_phy_suspend is

Re: [PATCH bpf-next v2 0/3] bpf: add boot parameters for sysctl knobs

2018-05-23 Thread Alexei Starovoitov
On Wed, May 23, 2018 at 02:18:19PM +0200, Eugene Syromiatnikov wrote: > Some BPF sysctl knobs affect the loading of BPF programs, and during > system boot/init stages these sysctls are not yet configured. > A concrete example is systemd, that has implemented loading of BPF > programs. > > Thus,

Re: [PATCH v6 0/5] PCI: Improve PCIe link status reporting

2018-05-23 Thread Bjorn Helgaas
[+to Davem] On Thu, May 03, 2018 at 03:00:07PM -0500, Bjorn Helgaas wrote: > This is based on Tal's recent work to unify the approach for reporting PCIe > link speed/width and whether the device is being limited by a slower > upstream link. > > The new pcie_print_link_status() interface appeared

[PATCH v2] ppp: remove the PPPIOCDETACH ioctl

2018-05-23 Thread Eric Biggers
From: Eric Biggers The PPPIOCDETACH ioctl effectively tries to "close" the given ppp file before f_count has reached 0, which is fundamentally a bad idea. It does check 'f_count < 2', which excludes concurrent operations on the file since they would only be possible with a

Re: [PATCH bpf-next v3 10/10] tools: bpftool: add delimiters to multi-function JITed dumps

2018-05-23 Thread Jakub Kicinski
On Wed, 23 May 2018 16:07:40 +0530, Sandipan Das wrote: > "name": "bpf_prog_196af774a3477707_F", > "insns": [{ > "pc": "0x0", > "operation": "nop", > "operands": [null > ] > },{ > "pc":

Re: [PATCH bpf-next v3 2/7] bpf: introduce bpf subcommand BPF_TASK_FD_QUERY

2018-05-23 Thread Yonghong Song
On 5/23/18 2:04 PM, Alexei Starovoitov wrote: On Wed, May 23, 2018 at 10:13:22AM -0700, Martin KaFai Lau wrote: + __u32 prog_id;/* output: prod_id */ + __u32 attach_info;/* output: BPF_ATTACH_* */ + __u64

Re: [PATCH bpf-next v3 2/7] bpf: introduce bpf subcommand BPF_TASK_FD_QUERY

2018-05-23 Thread Yonghong Song
On 5/23/18 10:13 AM, Martin KaFai Lau wrote: On Tue, May 22, 2018 at 09:30:46AM -0700, Yonghong Song wrote: Currently, suppose a userspace application has loaded a bpf program and attached it to a tracepoint/kprobe/uprobe, and a bpf introspection tool, e.g., bpftool, wants to show which bpf

Re: [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-23 Thread David Miller
From: Toke Høiland-Jørgensen Date: Wed, 23 May 2018 23:05:16 +0200 > Ah, right, that could work. Is there any particular field in sk_buff > we should stomp on for this purpose, or would you prefer a new one? > Looking through it, the only obvious one that comes to mind is, well, >

Re: [PATCH] ppp: remove the PPPIOCDETACH ioctl

2018-05-23 Thread Eric Biggers
On Wed, May 23, 2018 at 11:56:36AM -0400, David Miller wrote: > From: Guillaume Nault > Date: Wed, 23 May 2018 15:57:08 +0200 > > > I'd rather add > > + if (cmd == PPPIOCDETACH) { > > + err = -EINVAL; > > + goto out; > > + } > > > > Making

Re: [PATCH net-next] net:sched: add action inheritdsfield to skbmod

2018-05-23 Thread Marcelo Ricardo Leitner
Hi, Some style fixes: On Thu, May 17, 2018 at 07:33:08PM +, Fu, Qiaobin wrote: > net/sched: add action inheritdsfield to skbmod This extra line above should not be here. > > The new action inheritdsfield copies the field DS of > IPv4 and IPv6 packets into skb->prioriry. This enables

Re: [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-23 Thread Toke Høiland-Jørgensen
David Miller writes: > From: Toke Høiland-Jørgensen > Date: Wed, 23 May 2018 22:38:30 +0200 > >> How would this work? > > On egress the core networking flow dissector records what you need > somewhere in SKB or wherever. You later retrieve it at egress time >

Re: [PATCH bpf-next v3 2/7] bpf: introduce bpf subcommand BPF_TASK_FD_QUERY

2018-05-23 Thread Alexei Starovoitov
On Wed, May 23, 2018 at 10:13:22AM -0700, Martin KaFai Lau wrote: > > + __u32 prog_id;/* output: prod_id */ > > + __u32 attach_info;/* output: BPF_ATTACH_* */ > > + __u64 probe_offset; /* output: probe_offset */ > > +

Re: [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-23 Thread David Miller
From: Toke Høiland-Jørgensen Date: Wed, 23 May 2018 22:38:30 +0200 > How would this work? On egress the core networking flow dissector records what you need somewhere in SKB or wherever. You later retrieve it at egress time after NAT has occurred. > It's about making sure the

Re: [Cake] [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-23 Thread David Miller
From: Jonathan Morton Date: Wed, 23 May 2018 23:33:04 +0300 > Now I'm *really* confused. > > Are you saying that the user has to set up their own conntrack > mechanism using extra userspace commands? Because complicating the > setup process that way runs directly counter

Re: [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-23 Thread Toke Høiland-Jørgensen
David Miller writes: > From: Toke Høiland-Jørgensen > Date: Tue, 22 May 2018 15:57:38 +0200 > >> When CAKE is deployed on a gateway that also performs NAT (which is a >> common deployment mode), the host fairness mechanism cannot distinguish >> internal hosts

Re: [PATCH 00/18] Netfilter updates for net-next

2018-05-23 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 23 May 2018 20:42:36 +0200 > The following patchset contains Netfilter updates for your net-next > tree, they are: ... > This batch comes with is a conflict between 25fd386e0bc0 ("netfilter: > core: add missing __rcu annotation") in your

Estimado usuario

2018-05-23 Thread 12116 PFG
Estimado usuario Su buzón ha excedido el límite de almacenamiento de 20 GB establecido por el administrador, actualmente se ejecuta en 20.9 GB, no puede enviar ni recibir mensajes nuevos hasta que verifique su buzón. Vuelva a validar su cuenta por correo, complete la siguiente información a

Re: [Cake] [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-23 Thread Jonathan Morton
> On 23 May, 2018, at 11:04 pm, David Miller wrote: > > Who said anything about using an ingress qdisc to record/remember > this information? Now I'm *really* confused. Are you saying that the user has to set up their own conntrack mechanism using extra userspace

Re: [PATCH net-next v2 00/12] amd-xgbe: AMD XGBE driver updates 2018-05-21

2018-05-23 Thread David Miller
From: Tom Lendacky Date: Wed, 23 May 2018 11:38:02 -0500 > The following updates are included in this driver update series: > > - Fix the debug output for the max channels count > - Read (once) and save the port property registers during probe > - Remove the use of the

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Jakub Kicinski
On Wed, 23 May 2018 09:03:53 -0700, John Fastabend wrote: > On 05/23/2018 08:37 AM, Huy Nguyen wrote: > > > > > > On 5/23/2018 8:52 AM, John Fastabend wrote: > >> It would be nice though if the API gave us some hint on max/min/stride > >> of allowed values. Could the get API return these along

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Jakub Kicinski
On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: > diff --git a/include/uapi/linux/dcbnl.h b/include/uapi/linux/dcbnl.h > index 2c0c6453c3f4..1ddc0a44c172 100644 > --- a/include/uapi/linux/dcbnl.h > +++ b/include/uapi/linux/dcbnl.h > @@ -163,6 +163,15 @@ struct ieee_pfc { > __u64

[PATCH net-next v2 2/2] net: phy: improve checks when to suspend the PHY

2018-05-23 Thread Heiner Kallweit
If the parent of the MDIO bus is runtime-suspended, we may not be able to access the MDIO bus. Therefore add a check for this situation. So far phy_suspend() only checks for WoL being enabled, other checks are in mdio_bus_phy_may_suspend(). Improve this and move all checks to a new function

[PATCH net-next v2 1/2] net: phy: improve check for when to call phy_resume in mdio_bus_phy_resume

2018-05-23 Thread Heiner Kallweit
We don't have to do all the checks again which we did in mdio_bus_phy_suspend already. Instead we can simply check whether the PHY is actually suspended and needs to be resumed. Signed-off-by: Heiner Kallweit --- v2: - no changes --- drivers/net/phy/phy_device.c | 12

[PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-23 Thread Heiner Kallweit
I have the issue that suspending the MAC-integrated PHY gives an error during system suspend. The sequence is: 1. unconnected PHY/MAC are runtime-suspended already 2. system suspend commences 3. mdio_bus_phy_suspend is called 4. suspend callback of the network driver is called (implicitly

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-23 Thread Jakub Kicinski
On Wed, 23 May 2018 06:52:33 -0700, John Fastabend wrote: > On 05/23/2018 02:43 AM, Jiri Pirko wrote: > > Tue, May 22, 2018 at 07:20:26AM CEST, jakub.kicin...@netronome.com wrote: > >> On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: > >>> From: Huy Nguyen > >>> >

Re: [PATCH V4 0/8] net: ethernet: stmmac: add support for stm32mp1

2018-05-23 Thread David Miller
From: Christophe Roullier Date: Wed, 23 May 2018 17:47:51 +0200 > Patches to have Ethernet support on stm32mp1 > Changelog: > Remark from Rob Herring > Move Documentation/devicetree/bindings/arm/stm32.txt in > Documentation/devicetree/bindings/arm/stm32/stm32.txt and

Re: [PATCH net-next 2/2] net: phy: improve checks for when to suspend the PHY

2018-05-23 Thread Heiner Kallweit
Am 23.05.2018 um 21:43 schrieb Florian Fainelli: > On 05/23/2018 12:31 PM, Heiner Kallweit wrote: >> If the parent of the MDIO bus is runtime-suspended, we may not be able >> to access the MDIO bus. Therefore add a check for this situation. >> >> So far phy_suspend() only checks for WoL being

Re: [patch iproute2/net-next 2/2] devlink: introduce support for showing port number and split subport number

2018-05-23 Thread David Ahern
On 5/20/18 2:15 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Signed-off-by: Jiri Pirko > --- > devlink/devlink.c| 6 ++ > include/uapi/linux/devlink.h | 2 ++ > 2 files changed, 8 insertions(+) > > diff --git a/devlink/devlink.c

Re: [Cake] [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-23 Thread David Miller
From: Jonathan Morton Date: Wed, 23 May 2018 22:31:53 +0300 > Remember that it takes two different qdiscs to implement ingress and > egress on the same physical interface, and there's no obvious > logical link between them - especially since the ingress one has to > be

Re: [patch iproute2/net-next 1/2] devlink: introduce support for showing port flavours

2018-05-23 Thread David Ahern
On 5/20/18 2:15 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Signed-off-by: Jiri Pirko > --- > devlink/devlink.c| 20 > include/uapi/linux/devlink.h | 12 > 2 files changed, 32 insertions(+) > > applied to

Re: [PATCH net-next 0/4] patches 2018-05-23

2018-05-23 Thread David Miller
From: Ursula Braun Date: Wed, 23 May 2018 16:38:08 +0200 > here are more smc-patches for net-next: > > Patch 1 fixes an ioctl problem detected by syzbot. > > Patch 2 improves smc_lgr_list locking in case of abnormal link > group termination. If you want to receive a

Re: [PATCH net-next 2/2] cxgb4: do L1 config when module is inserted

2018-05-23 Thread David Miller
From: Ganesh Goudar Date: Wed, 23 May 2018 20:03:33 +0530 > trigger an L1 configure operation when a transceiver module > is inserted in order to cause current "sticky" options like > Requested Forward Error Correction to be reapplied. > > Signed-off-by: Casey Leedom

Re: [PATCH net-next 1/2] cxgb4: change the port capability bits definition

2018-05-23 Thread David Miller
From: Ganesh Goudar Date: Wed, 23 May 2018 20:02:58 +0530 > MDI Port Capabilities bit definitions were inconsistent with > regard to the MDI enum values. 2 bits used to define MDI in > the port capabilities are not really separable, it's a 2-bit > field with 4 different

  1   2   3   4   >