Re: [bpf-next PATCH v2 2/2] bpf: bpftool, add flag to allow non-compat map definitions

2018-10-15 Thread Jakub Kicinski
On Mon, 15 Oct 2018 08:17:53 -0700, John Fastabend wrote: > Multiple map definition structures exist and user may have non-zero > fields in their definition that are not recognized by bpftool and > libbpf. The normal behavior is to then fail loading the map. Although > this is a good default behavi

Re: [bpf-next PATCH v2 1/2] bpf: bpftool, add support for attaching programs to maps

2018-10-15 Thread Jakub Kicinski
On Mon, 15 Oct 2018 08:17:48 -0700, John Fastabend wrote: > Sock map/hash introduce support for attaching programs to maps. To > date I have been doing this with custom tooling but this is less than > ideal as we shift to using bpftool as the single CLI for our BPF uses. > This patch adds new sub c

Re: Bug in MACSec - stops passing traffic after approx 5TB

2018-10-15 Thread Josh Coombs
And confirmed, starting with a high packet number results in a very short testbed run, 296 packets and then nothing, just as you surmised. Sorry for raising the alarm falsely. Looks like I need to roll my own build of wpa_supplicant as the ubuntu builds don't include the macsec driver, haven't tes

Re: Fw: [Bug 201423] New: eth0: hw csum failure

2018-10-15 Thread Eric Dumazet
On Mon, Oct 15, 2018 at 8:15 AM Stephen Hemminger wrote: > > > > Begin forwarded message: > > Date: Sun, 14 Oct 2018 10:42:48 + > From: bugzilla-dae...@bugzilla.kernel.org > To: step...@networkplumber.org > Subject: [Bug 201423] New: eth0: hw csum failure > > > https://bugzilla.kernel.org/show

[bpf-next PATCH v2 2/2] bpf: bpftool, add flag to allow non-compat map definitions

2018-10-15 Thread John Fastabend
Multiple map definition structures exist and user may have non-zero fields in their definition that are not recognized by bpftool and libbpf. The normal behavior is to then fail loading the map. Although this is a good default behavior users may still want to load the map for debugging or other rea

[bpf-next PATCH v2 1/2] bpf: bpftool, add support for attaching programs to maps

2018-10-15 Thread John Fastabend
Sock map/hash introduce support for attaching programs to maps. To date I have been doing this with custom tooling but this is less than ideal as we shift to using bpftool as the single CLI for our BPF uses. This patch adds new sub commands 'attach' and 'detach' to the 'prog' command to attach prog

[bpf-next PATCH v2 0/2] bpftool support for sockmap use cases

2018-10-15 Thread John Fastabend
The first patch adds support for attaching programs to maps. This is needed to support sock{map|hash} use from bpftool. Currently, I carry around custom code to do this so doing it using standard bpftool will be great. The second patch adds a compat mode to ignore non-zero entries in the map def.

Fw: [Bug 201423] New: eth0: hw csum failure

2018-10-15 Thread Stephen Hemminger
Begin forwarded message: Date: Sun, 14 Oct 2018 10:42:48 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 201423] New: eth0: hw csum failure https://bugzilla.kernel.org/show_bug.cgi?id=201423 Bug ID: 201423 Summary: eth0: hw

Re: BBR and TCP internal pacing causing interrupt storm with pfifo_fast

2018-10-15 Thread Eric Dumazet
On Mon, Oct 15, 2018 at 3:26 AM Gasper Zejn wrote: > > > I've tried to isolate the issue as best I could. There seems to be an > issue if the TCP socket has keepalive set and send queue is not empty > and the route goes away. > > https://github.com/zejn/bbr_pfifo_interrupts_issue > > Hope this hel

Re: [PATCH net 1/2] geneve, vxlan: Don't check skb_dst() twice

2018-10-15 Thread Nicolas Dichtel
Le 15/10/2018 à 13:08, Stefano Brivio a écrit : > On Mon, 15 Oct 2018 12:19:41 +0200 > Nicolas Dichtel wrote: > >> Le 12/10/2018 à 23:53, Stefano Brivio a écrit : >>> Commit f15ca723c1eb ("net: don't call update_pmtu unconditionally") avoids >>> that we try updating PMTU for a non-existent destin

[PATCH net] sctp: use the pmtu from the icmp packet to update transport pathmtu

2018-10-15 Thread Xin Long
Other than asoc pmtu sync from all transports, sctp_assoc_sync_pmtu is also processing transport pmtu_pending by icmp packets. But it's meaningless to use sctp_dst_mtu(t->dst) as new pmtu for a transport. The right pmtu value should come from the icmp packet, and it would be saved into transport->

Re: bond: take rcu lock in netpoll_send_skb_on_dev

2018-10-15 Thread Eran Ben Elisha
On 9/28/2018 11:26 PM, Dave Jones wrote: > The bonding driver lacks the rcu lock when it calls down into > netdev_lower_get_next_private_rcu from bond_poll_controller, which > results in a trace like: > > WARNING: CPU: 2 PID: 179 at net/core/dev.c:6567 > netdev_lower_get_next_private_rcu+0x34/0

Re: [PATCH net 1/2] geneve, vxlan: Don't check skb_dst() twice

2018-10-15 Thread Stefano Brivio
On Mon, 15 Oct 2018 12:19:41 +0200 Nicolas Dichtel wrote: > Le 12/10/2018 à 23:53, Stefano Brivio a écrit : > > Commit f15ca723c1eb ("net: don't call update_pmtu unconditionally") avoids > > that we try updating PMTU for a non-existent destination, but didn't clean > > up cases where the check wa

Apply For Affordable Loan Offer

2018-10-15 Thread rifat
Do you need a loan? If YES Kindly contact us via: citigrouploaninvestm...@aol.com

Re: BBR and TCP internal pacing causing interrupt storm with pfifo_fast

2018-10-15 Thread Gasper Zejn
On 09. 10. 2018 19:26, Eric Dumazet wrote: > On Tue, Oct 9, 2018 at 10:22 AM Gasper Zejn wrote: >> On 09. 10. 2018 19:00, Eric Dumazet wrote: >>> On 10/09/2018 09:38 AM, Gasper Zejn wrote: Hello, I am seeing interrupt storms of over 100k-900k local timer interrupts when chang

Re: [PATCH net 1/2] geneve, vxlan: Don't check skb_dst() twice

2018-10-15 Thread Nicolas Dichtel
Le 12/10/2018 à 23:53, Stefano Brivio a écrit : > Commit f15ca723c1eb ("net: don't call update_pmtu unconditionally") avoids > that we try updating PMTU for a non-existent destination, but didn't clean > up cases where the check was already explicit. Drop those redundant checks. Yes, I leave them t

Re: [PATCH net 0/2] geneve, vxlan: Don't set exceptions if skb->len < mtu

2018-10-15 Thread Xin Long
On Sat, Oct 13, 2018 at 6:54 AM Stefano Brivio wrote: > > This series fixes the exception abuse described in 2/2, and 1/2 > is just a preparatory change to make 2/2 less ugly. > > Stefano Brivio (2): > geneve, vxlan: Don't check skb_dst() twice > geneve, vxlan: Don't set exceptions if skb->len

Re: [PATCH net] ip6_tunnel: Don't update PMTU on tunnels with collect_md

2018-10-15 Thread Stefano Brivio
On Mon, 15 Oct 2018 10:48:05 +0200 Nicolas Dichtel wrote: > Le 12/10/2018 à 18:34, Stefano Brivio a écrit : > > On Fri, 12 Oct 2018 17:58:55 +0200 > > Nicolas Dichtel wrote: > [snip] > >> Could you explain in your commit log which problem your patch fixes? > > > > Nothing really. > > > > T

Re: [PATCH net] ip6_tunnel: Don't update PMTU on tunnels with collect_md

2018-10-15 Thread Nicolas Dichtel
Le 12/10/2018 à 18:34, Stefano Brivio a écrit : > On Fri, 12 Oct 2018 17:58:55 +0200 > Nicolas Dichtel wrote: [snip] >> Could you explain in your commit log which problem your patch fixes? > > Nothing really. > > The change in f15ca723c1eb looked accidental and I thought it doesn't > make sense

Re: [PATCH net 2/2] geneve, vxlan: Don't set exceptions if skb->len < mtu

2018-10-15 Thread Stefano Brivio
On Mon, 15 Oct 2018 15:01:31 +0900 Xin Long wrote: > On Sat, Oct 13, 2018 at 6:54 AM Stefano Brivio wrote: > > > > We shouldn't abuse exceptions: if the destination MTU is already higher > > than what we're transmitting, no exception should be created. > makes sense, shouldn't ip(6) tunnels al

<    1   2