Re: [PATCH 03/23] usb-gadget/uvc: use per-attribute show and store methods

Hi Christoph, please see my comments inline. With the issues addressed you can add Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: UVC is a little different from other configfs consumers in that it wants different fu

Re: [PATCH 04/23] usb-gadget/f_hid: use per-attribute show and store methods

W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/usb/gadget/function/f_hid.c | 34 ++ 1 file changed, 14 insertions(+),

Re: [PATCH 06/23] usb-gadget/ether: use per-attribute show and store methods

W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/usb/gadget/function/f_ecm.c| 8 ++--- drivers/usb/gadget/function/f_eem.c| 8 ++-

Re: [PATCH 08/23] usb-gadget/f_midi: use per-attribute show and store methods

W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/usb/gadget/function/f_midi.c | 37 1 file changed, 16 insertions(+),

Re: [PATCH 07/23] usb-gadget/f_loopback: use per-attribute show and store methods

Hi Christoph, Please see comments inline. With the issue addressed you can add Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h...@lst.de> --- drivers/usb/gadget/function/f_loo

Re: [PATCH 09/23] usb-gadget/f_printer: use per-attribute show and store methods

Hi Christoph, The same remark as for f_loopback (__CONFIGFS_ATTR location vs CONFIGFS_ATTR location after applying) If addressed Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h.

Re: [PATCH 23/23] configfs: remove old API

Hi Christoph, Please see inline. W dniu 25.09.2015 o 15:50, Christoph Hellwig pisze: Remove the old show_attribute and store_attribute methods and update the documentation. Also replace the two C samples with a single new one in the proper samples directory where people expect to find it.

Re: [PATCH 05/23] usb-gadget/f_acm: use per-attribute show and store methods

W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/usb/gadget/function/f_acm.c | 26 -- 1 file changed, 4 insertions(+), 22 deleti

Re: [PATCH 11/23] usb-gadget/f_mass_storage: use per-attribute show and store methods

Hi Christoph, The same remark as for f_loopback (__CONFIGFS_ATTR location vs CONFIGFS_ATTR location after applying) If addressed Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h.

Re: [PATCH 10/23] usb-gadget/f_sourcesink: use per-attribute show and store methods

Hi Christoph, The same remark as for f_loopback (__CONFIGFS_ATTR location vs CONFIGFS_ATTR location after applying) If addressed Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h.

Re: [PATCH 12/23] usb-gadget/f_ac1: use per-attribute show and store methods

Hi Christoph, The commit title should be " usb-gadget/f_uac1 ..." instead of " f_ac1 ..." Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h...@lst.de> -

Re: [PATCH 14/23] usb-gadget/f_obex: use per-attribute show and store methods

W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/usb/gadget/function/f_obex.c | 26 -- 1 file changed, 4 insertions(+), 22 deleti

Re: [PATCH 13/23] usb-gadget/f_uac2: use per-attribute show and store methods

W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/usb/gadget/function/f_uac2.c | 28 +++- 1 file changed, 11 insertions(+), 17 deleti

Re: [PATCH 16/23] usb-gadget/f_serial: use per-attribute show and store methods

W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/usb/gadget/function/f_serial.c | 26 -- 1 file changed, 4 insertions(+), 22 deleti

Re: [PATCH 15/23] usb-gadget/f_phonet: use per-attribute show and store methods

W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/usb/gadget/function/f_phonet.c | 25 - 1 file changed, 4 insertions(+), 21 deleti

Re: simplify configfs attributes

Hi Christoph, W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: This series consolidates the code to implement configfs attributes by providing the ->show and ->store method in common code and using container_of in the methods to access the containing structure. This reduces source and

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/usb/gadget/configfs.c | 295 ++-- include/linux/usb/gadget_conf

Re: [PATCH 07/23] usb-gadget/f_loopback: use per-attribute show and store methods

Hi, W dniu 28.09.2015 o 15:41, Christoph Hellwig pisze: On Mon, Sep 28, 2015 at 01:46:57PM +0200, Andrzej Pietrasiewicz wrote: } -static struct f_lb_opts_attribute f_lb_opts_qlen = - __CONFIGFS_ATTR(qlen, S_IRUGO | S_IWUSR, - f_lb_opts_qlen_show